Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:  ahf   |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 fixed and merged; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * cc: ahf (added)
 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 In commit `38fb651f0d740bef575ad7f95475cc504ea4cb8f`:

 {{{
 +crypto_digest_add_bytes(sha_ctx_, (const char *)(inp2), (len2));   \
 +crypto_digest_get_digest(sha_ctx_, (char *)out, 64);   \
 +crypto_digest_free(sha_ctx_);
 }}}

 and in the same commit:

 {{{
 +crypto_digest_add_bytes(sha_ctx_, (const char *)(inp3), (len3));   \
 +crypto_digest_get_digest(sha_ctx_, (char *)out, 64);   \
 +crypto_digest_free(sha_ctx_);  \
 }}}

 The `64` should probably be replaced with `DIGEST512_LEN`.

 Other than that it looks good - seems to simplify our code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 (Note that there are still openssl includes in some of the donna headers,
 but that they are no longer actually used.  Also note that tor-gencert and
 tor-checkkey in src/tool/ still use openssl APIs directly.  I'm not
 changing those right now.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .3


Comment:

 See branch 'isolate_openssl' in my public repo.  I think it improves our
 code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21841 [Core Tor/Tor]: Refactor: include openssl headers from fewer modules

[Tor Bug Tracker & Wiki]

#21841: Refactor: include openssl headers from fewer modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  .3
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs