Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712R, GeorgKoppen201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:16 mcs]:
 > The followup patch looks good to me.
 > I did notice a small issue today when I ran with the new code on macOS:
 when the Security Settings window first opens, nthe "Learn More" link has
 the keyboard focus. I suppose that is just default XUL behavior (set focus
 to the first element that can have a keyboard focus), but it looks a
 little strange because macOS draws a box around the link. If you think
 this is worth fixing, the following addition to
 `torbutton_init_security_ui()` fixes it:
 > {{{
 >   let okBtn = document.documentElement.getButton("accept");
 >   if (okBtn)
 > okBtn.focus();

 Thanks, this is included in commit
 0e9fe510277aeb8617f9de73d24b85436479f129 on `master` now. The follow-up
 ticket for getting the improvements made here back to mobile is #24653.
 > }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712R, GeorgKoppen201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 The followup patch looks good to me.
 I did notice a small issue today when I ran with the new code on macOS:
 when the Security Settings window first opens, nthe "Learn More" link has
 the keyboard focus. I suppose that is just default XUL behavior (set focus
 to the first element that can have a keyboard focus), but it looks a
 little strange because macOS draws a box around the link. If you think
 this is worth fixing, the following addition to
 `torbutton_init_security_ui()` fixes it:
 {{{
   let okBtn = document.documentElement.getButton("accept");
   if (okBtn)
 okBtn.focus();
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712R, GeorgKoppen201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:14 mcs]:
 > The changes look fine to me, except we should replace the word "tap"
 with "click" for desktop. I think it is only the
 `torbutton.prefs.sec_tap_to_play_media` entity which needs to be updated.

 Good point. Should be fixed in `bug_21847_v2`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21847_v2=678c3548779a7316c96c79295f3e85efeee05fb7).
 Please have a look again.

 > We should make sure that any minor text changes flow back to mobile
 (other than "tap" -> "click").

 I'll open a follow-up bug once we are done here.

 > Also, I wanted to compare to the Orfox interface but I could not figure
 out how to open the security slider on Android. Either it is not there or
 I cannot find it (but I am pretty sure I have seen it in the past). I
 tried with the version from Google Play (1.4rc3?) as well as this release
 candidate:
 >
 
https://github.com/guardianproject/Orfox/releases/tag/Fennec-52.2.0esr%2FTorBrowser-7.0-1%2FOrfox-1.4.1-RC-1

 Good question. I currently don't have a mobile device to test that. What I
 used instead was using the screenshot on https://blog.torproject.org/blog
 /upping-support-mobile-browsing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712R, GeorgKoppen201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 The changes look fine to me, except we should replace the word "tap" with
 "click" for desktop. I think it is only the
 `torbutton.prefs.sec_tap_to_play_media` entity which needs to be updated.

 We should make sure that any minor text changes flow back to mobile (other
 than "tap" -> "click").

 Also, I wanted to compare to the Orfox interface but I could not figure
 out how to open the security slider on Android. Either it is not there or
 I cannot find it (but I am pretty sure I have seen it in the past). I
 tried with the version from Google Play (1.4rc3?) as well as this release
 candidate:
 
https://github.com/guardianproject/Orfox/releases/tag/Fennec-52.2.0esr%2FTorBrowser-7.0-1%2FOrfox-1.4.1-RC-1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712R, GeorgKoppen201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * Attachment "torbutton-1.9.8.3_21847.xpi" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712R, GeorgKoppen201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review
 * cc: mcs, brade (added)
 * keywords:
 tbb-usability, tbb-security-slider, TorBrowserTeam201712,
 GeorgKoppen201712
 =>
 tbb-usability, tbb-security-slider, TorBrowserTeam201712R,
 GeorgKoppen201712


Comment:

 `bug_21847`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21847=e0a8b16619c691ff44488c9c5b003875f62960ca)
 in my torbutton repo has a patch for review.

 I was tempted to follow the "HTML-ization" of the dialog by adding the
 bullets but I then thought this is still XUL and mixing both might look
 weird in the end given that the remaining UI has basically no HTML
 elements. This I left the bullets out (but the result is still list-like).

 I attached an .xpi which should be working to test this in en-US bundles.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712, GeorgKoppen201712|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:11 teor]:
 > Can we do some minor English copy editing here?

 Sure.

 > "causing some sites will lose functionality"
 > "causing some sites to lose functionality"

 That's actually already fixed in the mobile strings. So it might be a copy
 and paste error or older strings which are shown in comment:description.

 > And is there any reason why these headings are different?
 >
 > "At this cautious setting:"
 > "At the strict security setting:"
 >
 > If not, let's use:
 >
 > "At the cautious security setting:"
 > "At the strict security setting:"
 >
 > Or maybe for both:
 >
 > "At this setting:"

 We have

 `safer_list_label = At this safer setting`
 `safest_list_label = At the safest setting`

 in the mobile strings. I think I'll use "At the safer setting" and "At the
 safest setting" instead assuming `safer_list_label` has a typo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201712, GeorgKoppen201712|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Can we do some minor English copy editing here?

 "causing some sites will lose functionality"
 "causing some sites to lose functionality"

 And is there any reason why these headings are different?

 "At this cautious setting:"
 "At the strict security setting:"

 If not, let's use:

 "At the cautious security setting:"
 "At the strict security setting:"

 Or maybe for both:

 "At this setting:"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201711, GeorgKoppen201711|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-usability, tbb-security-slider, TorBrowserTeam201711 =>
 tbb-usability, tbb-security-slider, TorBrowserTeam201711,
 GeorgKoppen201711


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-security-slider,  |  Actual Points:
  TorBrowserTeam201709   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-usability, tbb-security-slider => tbb-usability, tbb-
 security-slider, TorBrowserTeam201709


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
+--
 Reporter:  isabela |  Owner:  tbb-team
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-usability, tbb-security-slider  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by arthuredelstein):

 * cc: arthuredelstein (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
+--
 Reporter:  isabela |  Owner:  tbb-team
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-usability, tbb-security-slider  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-usability => tbb-usability, tbb-security-slider


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience

[Tor Bug Tracker & Wiki]

#21847: Update copy for security slider to be consistent with the mobile 
experience
--+--
 Reporter:  isabela   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-usability
 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs