Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, ff52-esr, |  Actual Points:
  TorBrowserTeam201705, GeorgKoppen201705,   |
  tbb-7.0-must   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 I tested this on different machines and operating systems. It seems the
 patch for #21766 has fixed this one as well. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:
 tbb-usability, tbb-7.0-must-alpha, ff52-esr, TorBrowserTeam201705R,
 GeorgKoppen201705
 =>
 tbb-usability, tbb-7.0-must-alpha, ff52-esr, TorBrowserTeam201705,
 GeorgKoppen201705
 * status:  needs_review => needs_revision


Comment:

 Good finding. I did not test with e10s enabled as I was only focused on
 the non-e10s case. :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705R,   |
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 On OSX, the patch seems to fix the problem of this ticket (e10s off).
 However, after I cancel from the prompt that is presented by Torbutton the
 page is left in the loading state (spinner still going inside the tab
 area). This is a nuisance but probably something we can live with for now.

 A much worse problem is that when e10s is enabled this patch causes the
 main browser process to crash due to an assertion failure (I am testing
 with a debug build). I will attach a stack, but if we cannot find a
 solution for #21766 we should consider skipping the prompt if e10s is
 enabled.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705R,   |
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * cc: arthuredelstein (added)
 * keywords:
 tbb-usability, tbb-7.0-must-alpha, ff52-esr, TorBrowserTeam201705,
 GeorgKoppen201705
 =>
 tbb-usability, tbb-7.0-must-alpha, ff52-esr, TorBrowserTeam201705R,
 GeorgKoppen201705
 * status:  needs_information => needs_review


Comment:

 Okay, I am not fully done here as I seem to still have some details
 missing (I need more detailed logs at that point) but so far the patch in
 the attachment fixes things for me and looks good according to my logs I
 took for the debugging purposes. I have a branch `bug_21886_v3`
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_21886_v3&id=96a9fe10689345b0410b6ee25134de4e27c7c883)
 for review.

 The problematic NoScript part is:
 {{{
   if (IOUtil.isMediaDocOrFrame(req, contentType)) {
 IOUtil.suspendChannel(req);
 Thread.delay(() => IOUtil.resumeParentChannel(req), 100);
   }

   isMediaDocOrFrame(channel, contentType) {
 try {
   let cpType = channel.loadInfo.externalContentPolicyType;
   if (cpType === 7 || (cpType === 6 &&
   /^(?:video|audio|application)\//i.test(contentType === undefined
 ? channel.contentType : contentType))) {
 try {
   return !/^attachment\b/i.test(req.getResponseHeader("Content-
 disposition"));
 } catch(e) {
 }
 return true;
   }
 } catch (e) {
 }
 return false;
   },
 }}}
 I don't really understand what `hread.delay(() =>
 IOUtil.resumeParentChannel(req), 100);` but I suspect that the problems we
 are seeing are caused by it.

 What happens deeper down in the stack is the request being closed after
 about 32768 bytes are handled because calling `onDataAvailable` is
 resulting in an error that gets back to `OnStateStop`
 (`NS_ERROR_UNEXPECTED`):
 {{{
 [Main Thread]: D/nsStreamPump nsInputStreamPump::OnInputStreamReady
 [this=7f4591466180]
 [Main Thread]: D/nsStreamPump   OnStateTransfer [this=7f4591466180]
 [Main Thread]: D/nsStreamPump   Available returned [stream=89904d00 rv=0
 avail=32768]
 [Main Thread]: D/nsStreamPump   calling OnDataAvailable [offset=0
 count=32768(32768)]
 [Main Thread]: D/nsHttp nsHttpChannel::OnDataAvailable [this=7f459a4da000
 request=7f4591466180 offset=0 count=32768]
 [Main Thread]: D/nsHttp sending progress and status notification
 [this=7f459a4da000 status=804b0006 progress=32768/60562619]
 [Main Thread]: D/nsStreamPump   OnStateStop [this=7f4591466180
 status=8000]
 [Main Thread]: D/nsHttp nsHttpChannel::OnStopRequest [this=7f459a4da000
 request=7f4591466180 status=8000]
 }}}

 I'd like to keep this ticket open until we understand in detail what is
 going wrong but I think having the patch in the alpha can't hurt.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 I uploaded testbuilds to people-tpo. I ran the Linux builds on three
 different systems and the Windows build on a Windows 7 machine. Everything
 worked fine. I had no chance to test macOS yet.

 https://people.torproject.org/~gk/testbuilds/21886/ has the bundles.

 I am still trying to understand why the fix is working and what the
 underlying issue of this ticket is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:22 mcs]:
 > Replying to [comment:21 gk]:
 > > Well, that's not the same as in the attachment which is why I was
 asking.
 >
 > Ah. I forgot that we posted a patch in an attachment (work in progress)
 and then later we posted a pointer to what we thought was a better patch.
 The main difference between the two patches is where our hook is added
 (`nsExternalHelperAppService::DoContent()` vs.
 `nsExternalAppHandler::OnStartRequest()`). But you probably already knew
 that...
 >
 > Do you know if the patch we posted in the attachment fixes this bug on
 Linux? We did not try it because we were hoping to find a fix for #21766
 as well, on all platforms.

 Yes, it works for me on Linux with a custom build. And your patch in the
 attachment makes the difference between a working and broken download (all
 other things are equal). And, probably of equal importance, it stops the
 "http channel Listener OnDataAvailable contract violation" message in the
 console as well. So, I am slightly optimistic for this ticket... I am
 doing some nightlies right now for better testing, having your fix on top
 of `tor-browser-52.1.0esr-7.0-2-build1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:21 gk]:
 > Well, that's not the same as in the attachment which is why I was
 asking.

 Ah. I forgot that we posted a patch in an attachment (work in progress)
 and then later we posted a pointer to what we thought was a better patch.
 The main difference between the two patches is where our hook is added
 (`nsExternalHelperAppService::DoContent()` vs.
 `nsExternalAppHandler::OnStartRequest()`). But you probably already knew
 that...

 Do you know if the patch we posted in the attachment fixes this bug on
 Linux? We did not try it because we were hoping to find a fix for #21766
 as well, on all platforms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:20 mcs]:
 > Replying to [comment:19 gk]:
 > > Alright, I think I have figured out all the pieces involved. The
 problem starts with https://bugzilla.mozilla.org/show_bug.cgi?id=1321528
 being fixed in https://hg.mozilla.org/releases/mozilla-
 beta/rev/1c4863a4ff98 AND NoScript 2.9.5.2rc3 (commit
 9eab569b1d443456325e2b253f2cca65eb453c30 in the git repo at
 https://github.com/avian2/noscript). The whole suspend/resume mechanism
 got introduced there to fix the mediasource blocking for us. ;)
 >
 > Interesting. NoScript's role is confusing to me. Are you saying that
 NoScript relies on the fix for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1321528 and that the same
 Mozilla fix causes this bug?

 No, NoScript does not rely on the fix. But it does channel
 suspense/resumse things starting with 2.9.5 (and the fixup in 2.9.5.2rc3)
 which is causing the problems. The Mozilla bugfix is the necessery bit on
 Mozilla's side to trigger the problem: if either that or Noscript is
 missing (or NoScript before 2.9.5.2rc3 is installed) the problem in this
 bug goes away.

 > > While I don't have assembled all of the pieces to a coherent picture
 yet, the proposed attached fix seems to be a good idea to me. mcs/brade:
 That one works across different platforms, right? If so, do you think you
 want to propose that one for review?
 >
 > No, the fix we proposed does not work on Linux (at least not for us).
 See comment:16.

 Well, that's not the same as in the attachment which is why I was asking.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:19 gk]:
 > Alright, I think I have figured out all the pieces involved. The problem
 starts with https://bugzilla.mozilla.org/show_bug.cgi?id=1321528 being
 fixed in https://hg.mozilla.org/releases/mozilla-beta/rev/1c4863a4ff98 AND
 NoScript 2.9.5.2rc3 (commit 9eab569b1d443456325e2b253f2cca65eb453c30 in
 the git repo at https://github.com/avian2/noscript). The whole
 suspend/resume mechanism got introduced there to fix the mediasource
 blocking for us. ;)

 Interesting. NoScript's role is confusing to me. Are you saying that
 NoScript relies on the fix for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1321528 and that the same
 Mozilla fix causes this bug?

 > While I don't have assembled all of the pieces to a coherent picture
 yet, the proposed attached fix seems to be a good idea to me. mcs/brade:
 That one works across different platforms, right? If so, do you think you
 want to propose that one for review?

 No, the fix we proposed does not work on Linux (at least not for us). See
 comment:16.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * status:  assigned => needs_information


Comment:

 Alright, I think I have figured out all the pieces involved. The problems
 starts with https://bugzilla.mozilla.org/show_bug.cgi?id=1321528 begin
 fixed with https://hg.mozilla.org/releases/mozilla-beta/rev/1c4863a4ff98
 AND NoScript 2.9.5.2rc3 (commit 9eab569b1d443456325e2b253f2cca65eb453c30
 in the git repo at https://github.com/avian2/noscript). The whole
 suspend/resume mechanism got introduced to fix the mediasource blocking
 for us. ;)

 While I don't have assembled all of the pieces to a coherent picture yet,
 the proposed attached fix seems to be a good idea to me. mcs/brade: That
 one works across different platforms, right? If so, do you think you want
 to propose that one for review?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Just to give some small update as this is a surprisingly bit PITA: A
 crucial part of the issue plays NoScript: if one disables it the problem
 in this bug goes away. If one leaves it enabled then it is safe to say the
 problem got introduced between `FIREFOX_AURORA_52_BASE` and
 `FIREFOX_BETA_52_BASE`. The exact commit is not clear yet as I get hard to
 reproduce crashes in the area of interest which are related to the problem
 I think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by cypherpunks):

 FWIW: modal dialogs are forbidden. And what's happened with
 https://dxr.mozilla.org/mozilla-
 esr52/source/uriloader/exthandler/nsExternalHelperAppService.cpp#753?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Unfortunately, the patch does not seem to fix either problem on Linux, at
 least not without introducing other problems :(
 Here it is in case someone else wants to take a look:
  https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21766-01&id=e8ed33bbb5ad632acc173ab5be3880fc08eab681

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Update: Kathy and I have a patch that fixes both this ticket and #21766,
 at least on OSX. I am going to test it on Linux before I post it here. We
 will also need to test it on Windows, although I will probably wait for a
 new nightly build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:12 gk]:
 > mcs/brade: This bug is not related to #21766 it seems. I'll put it back
 on my plate, feel free to focus (again) on #21766. I think I can figure
 our what is going wrong here tomorrow.

 That's fine. Kathy and I will be interested to see what you have learned.
 We just came up with a patch that seems to fix this ticket but not #21766.
 I will post it as an attachment for reference, although you may have a
 different fix in mind.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * owner:  mcs => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr, TorBrowserTeam201705,|
  GeorgKoppen201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:  tbb-usability, tbb-7.0-must-alpha, ff52-esr,
 TorBrowserTeam201705 =>
 tbb-usability, tbb-7.0-must-alpha, ff52-esr, TorBrowserTeam201705,
 GeorgKoppen201705


Comment:

 Replying to [comment:7 mcs]:
 > Replying to [comment:6 gk]:
 > > After looking a bit closer at it I think this is highly related to
 #21766. mcs/brade: would it be helpful to deal with that bug by looking
 closer at this issue?
 > We will look at this one at the same time as #21766.
 >
 > > Or do you feel you have a solution for #21766? If so you could test
 whether my assumption is right and this bug gets fixed with it, too.
 > We do not have a solution yet but are planning to work on that bug
 tomorrow.

 mcs/brade: This bug is not related to #21766 it seems. I'll put it back on
 my plate, feel free to focus (again) on #21766. I think I can figure our
 what is going wrong here tomorrow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21886 [Applications/Tor Browser]: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off (was: Downloading of binary files stalls at 0/0 bytes in T

[Tor Bug Tracker & Wiki]

#21886: Downloading of binary files stalls at 0/0 bytes in Tor Browser based on
ESR52 with e10s off
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-7.0-must-alpha,   |  Actual Points:
  ff52-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:9 mcs]:
 > Kathy and I can not reproduce this bug when Tor Browser is running in
 multiprocess mode. When multiprocess mode is enabled, we always see a tab
 crash, which is #21766. Also, if the pref
 `extensions.torbutton.launch_warning` is set to false, neither this bug
 nor #21766 occur.
 >
 > I wanted to mention our experience in case someone is seeing different
 behavior.

 No, this ticket got filed before we had e10s enabled in Tor Browser. And I
 only see it once I have e10s off.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs