Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---
Changes (by asn):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 That was fixed as part of the #20657 branch, and also merged upstream.
 See:
 
https://gitweb.torproject.org/tor.git/commit/?id=471489ca035a50733205f97c8d589d80c58e36e8

 Closing this for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 I don't think that's what I meant: I meant that an intro point should be
 able to have an ntor onion key, and also (say) have some other kind of
 onion key for some day in the future, too, in case we add a successor to
 ntor.

 So I think the code in decode_introduction_point needs to handle looking
 for the first `onion-key ntor` line.  Otherwise it will ignore it if the
 ntor one isn't in the first position.

 Also the spec should say something like "At least once per intro point;
 each key type must be unique per intro point"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---

Comment (by dgoulet):

 Fixup commit on both spec and code. Basically, code one changes to `T1N`
 and the spec one mentions "Exactly once per ip".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---

Comment (by nickm):

 Should this become an "At least once" element, so that we can someday have
 an ntor key and a something-else key?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 From IRC: `<+asn> LGTM`

 Actually, the fixup commit has been removed. Final branches:

 Spec: `ticket22979_01`
 Code: `ticket22979_032_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---

Comment (by dgoulet):

 Replying to [comment:6 asn]:
 > Replying to [comment:5 dgoulet]:
 > > Branch: `ticket22979_032_01`
 > >
 > > It's not that big so let me know if an Oniongit would be needed.
 >
 > LGTM, but two quick questions:
 >
 > a) I assume that `ip->onion_key` will be initialized by the service code
 that is not yet included in the branch. So it's OK that it's not really
 filled with anything on the service-side, right?

 Yes exactly. This is really just the "descriptor subsystem" support for
 decoding and encoding.

 > b) Do we really want to `goto err` if we don't recognize the key type
 when decoding descriptor? Doesn't that influence our forward-compatibility
 that the key type field was supposed to be helping?

 Hmmm yes I think you are right. Then we have the same issue with `enc-
 key`... :S

 Basically, if we don't have "ntor" following it, we should just ignore it
 and move on. See fixup commit `76533e10a`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---

Comment (by asn):

 Replying to [comment:5 dgoulet]:
 > Branch: `ticket22979_032_01`
 >
 > It's not that big so let me know if an Oniongit would be needed.

 LGTM, but two quick questions:

 a) I assume that `ip->onion_key` will be initialized by the service code
 that is not yet included in the branch. So it's OK that it's not really
 filled with anything on the service-side, right?

 b) Do we really want to `goto err` if we don't recognize the key type when
 decoding descriptor? Doesn't that influence our forward-compatibility that
 the key type field was supposed to be helping?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.1
 Reviewer:  asn|Sponsor:  SponsorR-must
---+---
Changes (by dgoulet):

 * status:  accepted => needs_review
 * reviewer:   => asn
 * points:  0.2 => 0.1


Comment:

 Branch: `ticket22979_032_01`

 It's not that big so let me know if an Oniongit would be needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888 | Points:  0.2
 Reviewer: |Sponsor:  SponsorR-must
---+---
Changes (by dgoulet):

 * status:  needs_review => accepted
 * parent:  #20657 => #21888


Comment:

 Ok, time for the code to come! Considering this as a groundwork and should
 be based on git master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #20657 | Points:  0.2
 Reviewer: |Sponsor:  SponsorR-must
---+---

Comment (by asn):

 Replying to [comment:2 dgoulet]:
 > Spec: `ticket22979_01`

 LGTM.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #20657 | Points:  0.2
 Reviewer: |Sponsor:  SponsorR-must
---+---
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 Spec: `ticket22979_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---+---
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #20657 | Points:  0.2
 Reviewer: |Sponsor:  SponsorR-must
---+---
Changes (by dgoulet):

 * status:  new => accepted
 * parent:   => #20657


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs