Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:  .25
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * points:   => .25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:8 sisbell]:
 > Yes, firefox project will use tools like ''make'' from linux. Previously
 I put Android PATH first but then needed to reverse the path back in the
 firefox build. I just needed to make the zstd project to use correct
 variant so everything works with the system path first.

 Ah yes, the Android toolchain contains a lot of things, so it makes sense
 to include it last in the PATH. I merged the patch to master with commit
 `457b60475f388bfb381abe3796d881fd5dbe7153`, thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:7 boklm]:
 > Replying to [comment:2 sisbell]:
 > > Replying to [comment:1 sysrqb]:
 > > > This is based on commit f5fdff3bf0b9e957ab011f95af9e215cca7aeed6
 from ticket:28704#comment:23.
 > > >
 > > > {{{
 > > > diff --git a/projects/android-toolchain/config b/projects/android-
 toolchain/config
 > > > index 8c9c8222..4c02b2f3 100644
 > > > --- a/projects/android-toolchain/config
 > > > +++ b/projects/android-toolchain/config
 > > > @@ -15,6 +15,7 @@ var:
 > > >  export GRADLE_HOME=/var/tmp/dist/[% project %]/gradle
 > > >  export ANDROID_HOME=$ANDROID_SDK_HOME
 > > >  export GRADLE_USER_HOME=$GRADLE_HOME
 > > > +export PATH=$ANDROID_NDK_HOME/[% c("var/toolchain_arch")
 %]/bin:$PATH
 > > > }}}
 > > > If we put the toolchain at the end, are there situations where a
 system executable is used instead of the Android toolchain?
 > >
 > > I'll need to check old logs, but yes some projects just look for clang
 without the host info so it picks up the system executable for clang.
 >
 > In that case, it seems better to have the Android toolchain first in the
 PATH. Or are there any cases where we want a system executable to be used
 instead of the version from tho Android toolchain?
 Yes, firefox project will use tools like ''make'' from linux. Previously I
 put Android PATH first but then needed to reverse the path back in the
 firefox build. I just needed to make the zstd project to use correct
 variant so everything works with the system path first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:2 sisbell]:
 > Replying to [comment:1 sysrqb]:
 > > This is based on commit f5fdff3bf0b9e957ab011f95af9e215cca7aeed6 from
 ticket:28704#comment:23.
 > >
 > > {{{
 > > diff --git a/projects/android-toolchain/config b/projects/android-
 toolchain/config
 > > index 8c9c8222..4c02b2f3 100644
 > > --- a/projects/android-toolchain/config
 > > +++ b/projects/android-toolchain/config
 > > @@ -15,6 +15,7 @@ var:
 > >  export GRADLE_HOME=/var/tmp/dist/[% project %]/gradle
 > >  export ANDROID_HOME=$ANDROID_SDK_HOME
 > >  export GRADLE_USER_HOME=$GRADLE_HOME
 > > +export PATH=$ANDROID_NDK_HOME/[% c("var/toolchain_arch")
 %]/bin:$PATH
 > > }}}
 > > If we put the toolchain at the end, are there situations where a
 system executable is used instead of the Android toolchain?
 >
 > I'll need to check old logs, but yes some projects just look for clang
 without the host info so it picks up the system executable for clang.

 In that case, it seems better to have the Android toolchain first in the
 PATH. Or are there any cases where we want a system executable to be used
 instead of the version from tho Android toolchain?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by eighthave):

 * cc: hans@… (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202002 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202002R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_information => needs_review


Comment:

 I placed the ANDROID path after the system path. I did need to make a
 change in the zstd project to use the correct variant of clang (another
 commit).

 https://github.com/sisbell/tor-browser-build/commits/bug-33215

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, TorBrowserTeam202002


Comment:

 No parity involved in this bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:1 sysrqb]:
 > This is based on commit f5fdff3bf0b9e957ab011f95af9e215cca7aeed6 from
 ticket:28704#comment:23.
 >
 > {{{
 > diff --git a/projects/android-toolchain/config b/projects/android-
 toolchain/config
 > index 8c9c8222..4c02b2f3 100644
 > --- a/projects/android-toolchain/config
 > +++ b/projects/android-toolchain/config
 > @@ -15,6 +15,7 @@ var:
 >  export GRADLE_HOME=/var/tmp/dist/[% project %]/gradle
 >  export ANDROID_HOME=$ANDROID_SDK_HOME
 >  export GRADLE_USER_HOME=$GRADLE_HOME
 > +export PATH=$ANDROID_NDK_HOME/[% c("var/toolchain_arch")
 %]/bin:$PATH
 > }}}
 > If we put the toolchain at the end, are there situations where a system
 executable is used instead of the Android toolchain?

 I'll need to check old logs, but yes some projects just look for clang
 without the host info so it picks up the system executable for clang.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  new => needs_information


Comment:

 This is based on commit f5fdff3bf0b9e957ab011f95af9e215cca7aeed6 from
 ticket:28704#comment:23.

 {{{
 diff --git a/projects/android-toolchain/config b/projects/android-
 toolchain/config
 index 8c9c8222..4c02b2f3 100644
 --- a/projects/android-toolchain/config
 +++ b/projects/android-toolchain/config
 @@ -15,6 +15,7 @@ var:
  export GRADLE_HOME=/var/tmp/dist/[% project %]/gradle
  export ANDROID_HOME=$ANDROID_SDK_HOME
  export GRADLE_USER_HOME=$GRADLE_HOME
 +export PATH=$ANDROID_NDK_HOME/[% c("var/toolchain_arch") %]/bin:$PATH
 }}}
 If we put the toolchain at the end, are there situations where a system
 executable is used instead of the Android toolchain?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs