[Touch-packages] [Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-23 Thread Daniel van Vugt
For completeness I bisected the cause of the issue (introduced in mutter
43.1):

909616b20876478bc56932cd18c8e85e982645f6 is the first bad commit
commit 909616b20876478bc56932cd18c8e85e982645f6
Author: Sebastian Wick 
Date:   Tue May 3 18:47:57 2022 +0200

window-actor/wayland: Draw black background for fullscreen windows

Fullscreen Wayland toplevel surfaces don't need to respect the
configured size in which case it should be shown centered on the monitor
with a black background. The black background becomes part of the window
geometry.

The surface container is responsible for correctly culling the surfaces
and making sure the surface actors are removed from the actor tree to
avoid destroying them.

The window actor culling implementation assumes all surfaces to be direct
children of said actor. The introduction of the surface_container actor
broke that assumption. This implements the culling interface in
MetaWindowActorWayland which is aware of the actor surface_container and
fullscreen state.

v2: Fix forwarding culling to surface even if there is a background.
v2: Don't alter passed geometry.
v2: Update window geometry code documentation to reflect these changes.
v2: Only use constrained rect if we're acked fullscreen.

Part-of: 

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wayland in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

Status in Mutter:
  New
Status in wayland:
  New
Status in mutter package in Ubuntu:
  Won't Fix
Status in wayland package in Ubuntu:
  Won't Fix

Bug description:
  Ubuntu 23.04 running wayland
  gnome-terminal 3.46.7-1ubuntu1

  In gnome-terminal, I have set the transparency to some amount. When I
  go to full screen (F11), the transparency is lost and the default
  transparency is used. When I exit full screen, the transparency comes
  back and I can see in the profile settings that the transparency has
  not changed.

  It seems that tranparency was accidentally removed, and then re-added via
  
https://git.launchpad.net/ubuntu/+source/gnome-terminal/tree/debian/patches/0001-Restore-transparency.patch?h=applied/ubuntu/lunar-devel

  However, maybe something was missed with regards to full screen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-19 Thread Bug Watch Updater
** Changed in: wayland
   Status: Unknown => New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wayland in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

Status in Mutter:
  New
Status in wayland:
  New
Status in mutter package in Ubuntu:
  Won't Fix
Status in wayland package in Ubuntu:
  Won't Fix

Bug description:
  Ubuntu 23.04 running wayland
  gnome-terminal 3.46.7-1ubuntu1

  In gnome-terminal, I have set the transparency to some amount. When I
  go to full screen (F11), the transparency is lost and the default
  transparency is used. When I exit full screen, the transparency comes
  back and I can see in the profile settings that the transparency has
  not changed.

  It seems that tranparency was accidentally removed, and then re-added via
  
https://git.launchpad.net/ubuntu/+source/gnome-terminal/tree/debian/patches/0001-Restore-transparency.patch?h=applied/ubuntu/lunar-devel

  However, maybe something was missed with regards to full screen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp


[Touch-packages] [Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Daniel van Vugt
I was expecting upstream to say "won't fix". Aside from the protocol
saying it's the expected behaviour, we also wouldn't want to impact
performance of fullscreen games just because they accidentally used RGBA
instead of RGBX or RGB. So disallowing anything to show through in full
screen makes sense to me, on balance.

** Also affects: wayland (Ubuntu)
   Importance: Undecided
   Status: New

** Bug watch added: gitlab.freedesktop.org/wayland/wayland-protocols/-/issues 
#116
   https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/116

** Also affects: wayland via
   https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/116
   Importance: Unknown
   Status: Unknown

** Changed in: wayland (Ubuntu)
   Status: New => Won't Fix

** Changed in: mutter (Ubuntu)
   Status: Triaged => Won't Fix

** Changed in: mutter (Ubuntu)
   Importance: High => Undecided

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to wayland in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

Status in Mutter:
  New
Status in wayland:
  Unknown
Status in mutter package in Ubuntu:
  Won't Fix
Status in wayland package in Ubuntu:
  Won't Fix

Bug description:
  Ubuntu 23.04 running wayland
  gnome-terminal 3.46.7-1ubuntu1

  In gnome-terminal, I have set the transparency to some amount. When I
  go to full screen (F11), the transparency is lost and the default
  transparency is used. When I exit full screen, the transparency comes
  back and I can see in the profile settings that the transparency has
  not changed.

  It seems that tranparency was accidentally removed, and then re-added via
  
https://git.launchpad.net/ubuntu/+source/gnome-terminal/tree/debian/patches/0001-Restore-transparency.patch?h=applied/ubuntu/lunar-devel

  However, maybe something was missed with regards to full screen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp