Re: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board
all these hardcoded values?
All they really do is set the GPIO's to default states and switch on an
LED. I'll change it to use #defines
to make them more readable.
+gpio-GPBCON = 0x0005;
+gpio-GPBUP = 0x07FF;
+gpio-GPBDAT = 0x01C0; /* Switch on LED1. */
+gpio-GPCCON = 0x;
+gpio-GPCUP = 0x;
+gpio-GPDCON = 0x;
snip
+
+/* arch number of SBC2440-II Board */
+ gd-bd-bi_arch_number = MACH_TYPE_SBC2440II;
please use tab for indent
+
+/* adress of boot parameters */
+gd-bd-bi_boot_params = 0x3100;
please use this style RAM_BASE + 0x100
+
+icache_enable();
+dcache_enable();
do you support mmu? if not enable the dcache will have no effect
No mmu - I'll remove these lines.
+
+return 0;
+}
+
+int dram_init(void)
+{
+gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
+gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+
+return 0;
+}
diff --git a/board/embest/sbc2440ii/u-boot.lds
b/board/embest/sbc2440ii/u-boot.lds
please remove no more need
new file mode 100644
index 000..3b79776
snip
--- a/cpu/arm920t/s3c24x0/speed.c
+++ b/cpu/arm920t/s3c24x0/speed.c
@@ -30,12 +30,15 @@
*/
#include common.h
-#if defined(CONFIG_S3C2400) || defined (CONFIG_S3C2410) || defined
(CONFIG_TRAB)
+#if defined(CONFIG_S3C2400) || defined(CONFIG_S3C2410) || \
+defined(CONFIG_S3C2440) || defined(CONFIG_TRAB)
#if defined(CONFIG_S3C2400)
#include s3c2400.h
#elif defined(CONFIG_S3C2410)
#include s3c2410.h
+#elif defined(CONFIG_S3C2440)
+#include s3c2440.h
#endif
#define MPLL 0
@@ -53,49 +56,81 @@
static ulong get_PLLCLK(int pllreg)
{
-S3C24X0_CLOCK_POWER * const clk_power = S3C24X0_GetBase_CLOCK_POWER();
-ulong r, m, p, s;
-
-if (pllreg == MPLL)
-r = clk_power-MPLLCON;
-else if (pllreg == UPLL)
-r = clk_power-UPLLCON;
-else
-hang();
-
-m = ((r 0xFF000) 12) + 8;
-p = ((r 0x003F0) 4) + 2;
-s = r 0x3;
-
-return((CONFIG_SYS_CLK_FREQ * m) / (p s));
+S3C24X0_CLOCK_POWER * const clk_power = S3C24X0_GetBase_CLOCK_POWER();
please do not mix codind style fix and new code in the same patch
+ulong r, m, p, s;
+
+if (pllreg == MPLL)
+r = clk_power-MPLLCON;
+else if (pllreg == UPLL)
+r = clk_power-UPLLCON;
+else
+hang();
+
+m = ((r 0xFF000) 12) + 8;
+p = ((r 0x003F0) 4) + 2;
+s = r 0x3;
+
+#ifdef CONFIG_S3C2440
+if (pllreg == MPLL)
+return (2 * CONFIG_SYS_CLK_FREQ * m) / (p s);
+else
please add the #else here
+return (CONFIG_SYS_CLK_FREQ * m) / (p s);
+#else
+return (CONFIG_SYS_CLK_FREQ * m) / (p s);
+#endif
}
/* return FCLK frequency */
ulong get_FCLK(void)
{
-return(get_PLLCLK(MPLL));
+return get_PLLCLK(MPLL);
}
/* return HCLK frequency */
please send a new version before continuing the review
as you mix codind style fix and new code in the same patch
it's really hard to review
OK - I'll make the changes and split it into multiple patches as you
suggested then re-send.
Regards
Best Regards,
J.
__ Information from ESET NOD32 Antivirus, version of virus signature
database 4125 (20090603) __
The message was checked by ESET NOD32 Antivirus.
http://www.eset.com
--
Kevin Morfitt
Fearnside Systems Ltd
25 Holbeck Road
Nottingham
NG8 3PB
t: 0115 9136703
m: 07939 126277
e: kevin.morf...@fearnside-systems.co.uk
__ Information from ESET NOD32 Antivirus, version of virus signature
database 4126 (20090603) __
The message was checked by ESET NOD32 Antivirus.
http://www.eset.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] iMX27 PDK board support
Hey guys, J've seen that U-Boot V2 supports different MX27 CPU boards. Is U-Boot supported on Freescale i.MX27 PDK board ? Thanks in advance. Brice Walzer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board
Dear kevin.morf...@fearnside-systems.co.uk, In message 4a263923.2030...@fearnside-systems.co.uk you wrote: +#define BWSCON0x4800 + +#define DW8 (0x0) +#define DW16 (0x1) +#define DW32 (0x2) +#define WAIT (0x1 2) +#define UBLB (0x1 3) what is all theses macro? for what use? They make setting the fields of the memory controller registers more readable. For example BSWCON is the Bus Width and Wait Control Register, DW32 sets a Data Width value bit-field in BWSCON to 8-bit etc. They're used later in the patch to configure the memory controller registers. The names are the same as those used in the S3C2440 data sheet. Please make sure to use C structs to descrive device register layout, and use proper I/O accessor functions for the actual access. + gpio-GPBCON = 0x0005; + gpio-GPBUP = 0x07FF; + gpio-GPBDAT = 0x01C0; /* Switch on LED1. */ + gpio-GPCCON = 0x; + gpio-GPCUP = 0x; + gpio-GPDCON = 0x; Such code will not be accepted. Please use C structs and I/O accessor functions. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Consistency requires you to be as ignorant today as you were a year ago. - Bernard Berenson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board
Dear Wolfgang/Jean-Christophe I'd be grateful if you could give me some advice on this please as I haven't been working with u-boot for very long. Although the code you've both commented on is new it uses a lot of the existing Samsung S3C common code in cpu/arm920t/s3c24x0 and various s3c24x0 drivers code. This common code also has the problems you commented on and additionally it doesn't meet the coding style requirements. It would probably be better for me to re-work the existing common code first and submit a patch, then submit a new SBC2440-II Board patch based on the code after the re-work patch has been applied. I'm happy to do this but I just have a few questions: - if I re-work the existing common S3C2410 code I can check the existing Samsung S3C boards still build but how do I make sure they still work (I can't test them as I only have an SBC2440-II Board)? - once I've re-worked the existing common S3C2410 code a new patch for the SBC2440-II Board would only really make sense if it was based on the code after the common code re-work patch was applied. Is it OK to submit an SBC2440 Board patch that assumes the re-work patch has been applied first? I'm sure this has come up before but I can't find any mention of it in the mail archives. Regards Kevin Morfitt 03/06/2009 11:05, Wolfgang Denk wrote: Dear kevin.morf...@fearnside-systems.co.uk, In message 4a263923.2030...@fearnside-systems.co.uk you wrote: +#define BWSCON0x4800 + +#define DW8 (0x0) +#define DW16 (0x1) +#define DW32 (0x2) +#define WAIT (0x1 2) +#define UBLB (0x1 3) what is all theses macro? for what use? They make setting the fields of the memory controller registers more readable. For example BSWCON is the Bus Width and Wait Control Register, DW32 sets a Data Width value bit-field in BWSCON to 8-bit etc. They're used later in the patch to configure the memory controller registers. The names are the same as those used in the S3C2440 data sheet. Please make sure to use C structs to descrive device register layout, and use proper I/O accessor functions for the actual access. + gpio-GPBCON = 0x0005; + gpio-GPBUP = 0x07FF; + gpio-GPBDAT = 0x01C0; /* Switch on LED1. */ + gpio-GPCCON = 0x; + gpio-GPCUP = 0x; + gpio-GPDCON = 0x; Such code will not be accepted. Please use C structs and I/O accessor functions. Best regards, Wolfgang Denk -- Kevin Morfitt Fearnside Systems Ltd 25 Holbeck Road Nottingham NG8 3PB t: 0115 9136703 m: 07939 126277 e: kevin.morf...@fearnside-systems.co.uk __ Information from ESET NOD32 Antivirus, version of virus signature database 4126 (20090603) __ The message was checked by ESET NOD32 Antivirus. http://www.eset.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB gadget interface from cdc branch into mainline
2009.06 is the current release. This change is too intrusive to integrate it at this stage in the current release. So, it will go in the next. Thank you, this is useful. If you have patches for OMAP3 I am happy to queue them up in the cdc branch, so that they will move to ML when the merge window is open. I am working on patches. Kind Regards, -Ragha ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board
Dear Kevin, in message 4a2654cb.1020...@fearnside-systems.co.uk you wrote: Although the code you've both commented on is new it uses a lot of the existing Samsung S3C common code in cpu/arm920t/s3c24x0 and various s3c24x0 drivers code. This common code also has the problems you commented on and additionally it doesn't meet the coding style Yes, unfortunately we have not always been that strict in the past. requirements. It would probably be better for me to re-work the existing common code first and submit a patch, then submit a new SBC2440-II Board patch based on the code after the re-work patch has been applied. I'm happy to do this but I just have a few questions: Thanks a lot in advance. - if I re-work the existing common S3C2410 code I can check the existing Samsung S3C boards still build but how do I make sure they still work (I can't test them as I only have an SBC2440-II Board)? Such testing is supposed to be done by the respective board maintainers. - once I've re-worked the existing common S3C2410 code a new patch for the SBC2440-II Board would only really make sense if it was based on the code after the common code re-work patch was applied. Is it OK to submit an SBC2440 Board patch that assumes the re-work patch has been applied first? Yes, this is OK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Men don't talk peace unless they're ready to back it up with war. -- Col. Green, The Savage Curtain, stardate 5906.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-coldfire next
Hi Wolfgang, Please pull this change for u-boot-coldfire/next into your next branch: The following changes since commit 9f2b981c3b47a12f8e2691b68776c4fbe0fb1394: Stefan Roese (1): ppc4xx: Remove PCI async bootup message if PCI is not used are available in the git repository at: git://www.denx.de/git/u-boot-coldfire.git next Richard Retanubun (3): Adds WATCHDOG_RESET() function call to lib_m68k dtimer_interrupt. Compier warning cleanup Coldfire M5271: Activate u-boot system timer interrupt. include/asm-m68k/immap.h |2 +- lib_m68k/board.c |3 +-- lib_m68k/time.c | 13 - 3 files changed, 14 insertions(+), 4 deletions(-) Thanks. Regards, TsiChung ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] KB9202: Add NAND support
hi,
El Fri, May 15, 2009 at 05:30:48PM -0500 Scott Wood ha dit:
Matthias Kaehlcke wrote:
+/*
+ * Board-specific function to access the device ready signal.
+ */
+static int kb9202_nand_ready(struct mtd_info *mtd)
+{
+return (((AT91C_BASE_PIOC-PIO_PDSR) KB9202_NAND_BUSY) != 0);
+}
Use I/O accessors.
+int board_nand_init(struct nand_chip *nand)
+{
+unsignedvalue;
[snip]
+ /* enable internal NAND controller */
+ value = *(AT91C_EBI_CSA);
+ value |= AT91C_EBI_CS3A_SMC_SmartMedia;
+ *(AT91C_EBI_CSA) = value;
This is a hardware register. Surely it has a defined width?
+/* setup nand flash access (allow ample margin) */
+/* 4 wait states, 1 setup, 1 hold, 1 float for 8-bit device */
+((AT91PS_SMC2)AT91C_BASE_SMC2)-SMC2_CSR[3] =
+AT91C_SMC2_WSEN |
+(4 AT91C_SMC2_NWS) |
+((1 8) AT91C_SMC2_TDF) |
+AT91C_SMC2_DBW_8 |
+((1 24) AT91C_SMC2_RWSETUP) |
+((1 29) AT91C_SMC2_RWHOLD);
What is AT91PS_SMC2? Please don't hide pointers inside typedefs. Please
define symbols to have the proper type in the first place, rather than
casting at the point of use.
here is a version of the patch that addresses the issues you pointed
out. sorry for the late response, my development system died and i
needed some time to get a new machine and restore the setup
--
This is a forward port of the patch submitted by Christian from
Kwikbyte in 06/2007
(http://lists.denx.de/pipermail/u-boot/2007-June/022068.html)
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
board/kb9202/Makefile|2 +-
board/kb9202/nand.c | 153 ++
include/configs/kb9202.h | 10 +++-
3 files changed, 163 insertions(+), 2 deletions(-)
create mode 100644 board/kb9202/nand.c
diff --git a/board/kb9202/Makefile b/board/kb9202/Makefile
index 363f665..0ba4fcc 100644
--- a/board/kb9202/Makefile
+++ b/board/kb9202/Makefile
@@ -28,7 +28,7 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).a
-COBJS := kb9202.o
+COBJS := kb9202.o nand.o
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/kb9202/nand.c b/board/kb9202/nand.c
new file mode 100644
index 000..fa63aa1
--- /dev/null
+++ b/board/kb9202/nand.c
@@ -0,0 +1,153 @@
+/*
+ * (C) Copyright 2006 KwikByte kb9200_...@kwikbyte.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include asm/io.h
+#include asm/arch/AT91RM9200.h
+#include asm/arch/hardware.h
+
+#ifdef CONFIG_CMD_NAND
+
+#include nand.h
+
+/*
+ * hardware specific access to control-lines
+ */
+
+#define MASK_ALE(1 22) /* our ALE is A22 */
+#define MASK_CLE(1 21) /* our CLE is A21 */
+
+#define KB9202_NAND_NCE (1 28) /* EN* on D28 */
+#define KB9202_NAND_BUSY (1 29) /* RB* on D29 */
+
+/*
+ * Board-specific function to access device control signals
+ */
+static void kb9202_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int
ctrl)
+{
+ struct nand_chip *this = mtd-priv;
+
+ if (ctrl NAND_CTRL_CHANGE) {
+ ulong IO_ADDR_W = (ulong) this-IO_ADDR_W;
+
+ /* clear ALE and CLE bits */
+ IO_ADDR_W = ~(MASK_ALE | MASK_CLE);
+
+ if (ctrl NAND_CLE)
+ IO_ADDR_W |= MASK_CLE;
+
+ if (ctrl NAND_ALE)
+ IO_ADDR_W |= MASK_ALE;
+
+ this-IO_ADDR_W = (void *) IO_ADDR_W;
+
+ if (ctrl NAND_NCE)
+ AT91C_BASE_PIOC-PIO_CODR = KB9202_NAND_NCE;
+ else
+ AT91C_BASE_PIOC-PIO_SODR = KB9202_NAND_NCE;
+ }
+
+ if (cmd != NAND_CMD_NONE)
+ writeb(cmd, this-IO_ADDR_W);
+}
+
+
+/*
+ * Board-specific function to access the device ready signal.
+ */
+static int kb9202_nand_ready(struct mtd_info *mtd)
+{
+ const unsigned int value = readl(AT91C_PIOC_PDSR);
+
+ return ((value KB9202_NAND_BUSY) != 0);
+}
+
+
+/*
+ * Board-specific NAND init. Copied from include/linux/mtd/nand.h for
reference.
+ *
+ * struct nand_chip - NAND Private Flash Chip Data
+
Re: [U-Boot] TSEC ethernet controller problems (crc errors/ corruption)
On Tue, Jun 02, 2009 at 06:08:17PM -0500, Kim Phillips wrote: On Tue, 2 Jun 2009 15:19:18 -0700 Ira Snyder i...@ovro.caltech.edu wrote: On Tue, Jun 02, 2009 at 02:25:03PM -0700, Ira Snyder wrote: And what is the SICRH[30-31]? Did you have the matching settings for GMII with 3.3V? = md e118 1 e118: 0002 This looks wrong. The MPC8349EMDS board has the exact same setting in that register. Writing 0x0 to the SICRH register did not cause the problem to go away. The MPC8349EMDS config has had that setting since it was imported into U-Boot. I've copied the relevant part of include/configs/MPC8349EMDS.h below. #define CONFIG_SYS_SICRH SICRH_TSOBI1 This seems wrong for the MPC8349EMDS board. I tried setting the register value to 0x0 by hand on my MPC8349EMDS eval board, and the network still works as expected. still works or does not work? 100mbit or 1000mbit?? Network works, both 100 and 1000 mbit. Is this a bug in the MPC8349EMDS config? It might be. Another thing that changed wrt that area was commit 846f1574. Assuming this is all still clear to me, perhaps what that patch does should be made 8349-revision dependent? My MPC8349EMDS reference manual says that bits 28-29 should be preserved, which is exactly what the commit message states. I don't see a problem with commit 846f1574 at all. The bug is that SICRH is set to SICRH_TSOBI1 (0x2), which changes the TSEC1 output buffer parameters to RGMII/RTBI mode. The MPC8349EMDS's PHY's are both in GMII mode, the do not use RGMII/RTBI or any of the other reduced pin count interfaces. Therefore, I think the bit should be cleared, and SICRH should be set to 0x0. Even if I'm wrong, then the bits for both TSEC1 and TSEC2 should be the same. Right now, TSEC1 has the RGMII/RTBI output parameters, and TSEC2 has the GMII output parameters. In practice, this doesn't seem to make a difference on the MPC8349EMDS eval board. Both settings work without any errors. For people like me, who are copying an existing board port to a similar board, it would be nice if it was correct. Thanks, Ira ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] UBI on NAND flash again
I know there has been some traffic regaring the UBI layer recently, however, reading the conversations didn't solve the issue I'm facing. With a current U-Boot (git as of today) and 128MB NAND flash on a PXA303, I get the following: $ mtdparts device nand0 nand0, # parts = 5 #: namesizeoffset mask_flags 0: u-boot 0x0008 0x 0 1: env 0x0002 0x0008 0 2: splash 0x0006 0x000a 0 3: kernel 0x0030 0x0010 0 4: ubilayer0x07c0 0x0040 0 active partition: nand0,0 - (u-boot) 0x0008 @ 0x defaults: mtdids : nand0=nand0 mtdparts: mtdparts=nand0:512k(u-boot),128k(env),384k(splash),3M(kernel),-(ubilayer) $ ubi part ubilayer Creating 1 MTD partitions on nand0: 0x0040-0x0800 : mtd=4 UBI: attaching mtd1 to ubi0 UBI: physical eraseblock size: 131072 bytes (128 KiB) UBI: logical eraseblock size:126976 bytes UBI: smallest flash I/O unit:2048 UBI: VID header offset: 2048 (aligned 2048) UBI: data offset:4096 UBI error: ubi_init: cannot attach mtd1 UBI error: ubi_init: UBI error: cannot initialize UBI, error -12 UBI init error -12 exit not allowed from main input shell. What puzzles me is this 'UBI: attaching mtd1 to ubi0' - shouldn't that be 'mtd4'? The same layout works well under Linux, btw. Any hints? Daniel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] Fix a typo in the instructions on using omap3's gpio interface.
On 20:53 Tue 02 Jun , Tom Rix wrote:
Using the example for reading a gpio, shows the problem.
NULL should be the gpio number.
Signed-off-by: Tom Rix tom@windriver.com
---
doc/README.omap3 |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/doc/README.omap3 b/doc/README.omap3
index e05e816..66e781d 100644
--- a/doc/README.omap3
+++ b/doc/README.omap3
@@ -106,7 +106,7 @@ To clear a bit :
To read a bit :
if (!omap_request_gpio(N)) {
- omap_set_gpio_direction(NULL, 1);
+ omap_set_gpio_direction(N, 1);
val = omap_get_gpio_datain(N);
omap_free_gpio(N);
}
--
1.6.0.5
On 20:53 Tue 02 Jun , Tom Rix wrote:
There are currently 3 versions of the zoom2 board.
The production board, that is currently being released.
The beta board, similar in form to the production board but not released.
The alpha board, a set of PCBs with a very limited circulation.
GPIO 94 is used to determine the version of the board. If GPIO 94 is clear,
the board is a production board, otherwise it is a beta board.
The alpha board will likely be mistaken for a beta board. An alpha board
was unavailible for testing.
This has been tested on the beta and production boards.
Signed-off-by: Tom Rix tom@windriver.com
---
board/omap3/zoom2/zoom2.c | 62 ++--
board/omap3/zoom2/zoom2.h |9 ++
2 files changed, 68 insertions(+), 3 deletions(-)
diff --git a/board/omap3/zoom2/zoom2.c b/board/omap3/zoom2/zoom2.c
index e5c248d..94231da 100644
--- a/board/omap3/zoom2/zoom2.c
+++ b/board/omap3/zoom2/zoom2.c
@@ -33,6 +33,7 @@
#include status_led.h
#endif
#include asm/io.h
+#include asm/arch/gpio.h
#include asm/arch/mem.h
#include asm/arch/mux.h
#include asm/arch/sys_proto.h
@@ -60,6 +61,60 @@ static u32 gpmc_serial_TL16CP754C[GPMC_MAX_REG] = {
0x1D0904C4, 0
};
+/* Used to track the revision of the board */
+static ZOOM2_REVISION zoom2_revision = ZOOM2_REVISION_UNKNOWN;
no uppercase please
if you are ok I'll remane it before apply
static zoom2_revision revision = ZOOM2_REVISION_UNKNOWN;
Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] Fix a typo in the instructions on using omap3's gpio interface.
On 09:58 Fri 29 May , Tom Rix wrote: Using the example for reading a gpio, shows the problem. NULL should be the gpio number. Signed-off-by: Tom Rix tom@windriver.com --- applied to arm/next Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] Fix a typo in the instructions on using omap3's gpio interface.
Jean-Christophe PLAGNIOL-VILLARD wrote: On 20:53 Tue 02 Jun , Tom Rix wrote: Using the example for reading a gpio, shows the problem. NULL should be the gpio number. snip +/* Used to track the revision of the board */ +static ZOOM2_REVISION zoom2_revision = ZOOM2_REVISION_UNKNOWN; no uppercase please if you are ok I'll remane it before apply static zoom2_revision revision = ZOOM2_REVISION_UNKNOWN; Please do. Thanks Tom Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] Beagle Convert the board version detection to use the OMAP3 GPIO interface.
On 20:53 Tue 02 Jun , Tom Rix wrote: There is no new functionality in the change. This change is a conversion from the using raw register access to using the OMAP3 GPIO API described in doc/README.omap3. Signed-off-by: Tom Rix tom@windriver.com --- applied to arm/next Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] OMAP3 Turn on the GPIO bank clocks
On 13:57 Fri 29 May , Tom Rix wrote: The function and interface clocks for each GPIO bank, except the first, must be explicitly turned on. These are controlled by the config level defines CONFIG_OMAP3_GPIO_n where n is from 2 to 6. Signed-off-by: Tom Rix tom@windriver.com --- applied to arm/next Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ZOOM2 Define GPIO banks used.
On 13:57 Fri 29 May , Tom Rix wrote: Enable the function and interface clocks for banks 2,3,5 and 6. Signed-off-by: Tom Rix tom@windriver.com --- applied to arm/next Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3 V3] ZOOM2 detect the version of the zoom2 board at runtime.
From: Tom Rix tom@windriver.com
There are currently 3 versions of the zoom2 board.
The production board, that is currently being released.
The beta board, similar in form to the production board but not released.
The alpha board, a set of PCBs with a very limited circulation.
GPIO 94 is used to determine the version of the board. If GPIO 94 is clear,
the board is a production board, otherwise it is a beta board.
The alpha board will likely be mistaken for a beta board. An alpha board
was unavailible for testing.
This has been tested on the beta and production boards.
Signed-off-by: Tom Rix tom@windriver.com
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com
---
board/omap3/zoom2/zoom2.c | 62 ++--
board/omap3/zoom2/zoom2.h |9 ++
2 files changed, 68 insertions(+), 3 deletions(-)
diff --git a/board/omap3/zoom2/zoom2.c b/board/omap3/zoom2/zoom2.c
index e5c248d..08fdafb 100644
--- a/board/omap3/zoom2/zoom2.c
+++ b/board/omap3/zoom2/zoom2.c
@@ -33,6 +33,7 @@
#include status_led.h
#endif
#include asm/io.h
+#include asm/arch/gpio.h
#include asm/arch/mem.h
#include asm/arch/mux.h
#include asm/arch/sys_proto.h
@@ -60,6 +61,60 @@ static u32 gpmc_serial_TL16CP754C[GPMC_MAX_REG] = {
0x1D0904C4, 0
};
+/* Used to track the revision of the board */
+static zoom2_revision revision = ZOOM2_REVISION_UNKNOWN;
+
+/*
+ * Routine: zoom2_get_revision
+ * Description: Return the revision of the Zoom2 this code is running on.
+ */
+zoom2_revision zoom2_get_revision(void)
+{
+ return revision;
+}
+
+/*
+ * Routine: zoom2_identify
+ * Description: Detect which version of Zoom2 we are running on.
+ */
+void zoom2_identify(void)
+{
+ /*
+* To check for production board vs beta board,
+* check if gpio 94 is clear.
+*
+* No way yet to check for alpha board identity.
+* Alpha boards were produced in very limited quantities
+* and they are not commonly used. They are mentioned here
+* only for completeness.
+*/
+ if (!omap_request_gpio(94)) {
+ unsigned int val;
+
+ omap_set_gpio_direction(94, 1);
+ val = omap_get_gpio_datain(94);
+ omap_free_gpio(94);
+
+ if (val)
+ revision = ZOOM2_REVISION_BETA;
+ else
+ revision = ZOOM2_REVISION_PRODUCTION;
+ }
+
+ printf(Board revision );
+ switch (revision) {
+ case ZOOM2_REVISION_PRODUCTION:
+ printf(Production\n);
+ break;
+ case ZOOM2_REVISION_BETA:
+ printf(Beta\n);
+ break;
+ default:
+ printf(Unknown\n);
+ break;
+ }
+}
+
/*
* Routine: board_init
* Description: Early hardware init.
@@ -96,10 +151,11 @@ int board_init (void)
* Routine: misc_init_r
* Description: Configure zoom board specific configurations
*/
-int misc_init_r (void)
+int misc_init_r(void)
{
- power_init_r ();
- dieid_num_r ();
+ zoom2_identify();
+ power_init_r();
+ dieid_num_r();
return 0;
}
diff --git a/board/omap3/zoom2/zoom2.h b/board/omap3/zoom2/zoom2.h
index cae8a7a..a21d1d6 100644
--- a/board/omap3/zoom2/zoom2.h
+++ b/board/omap3/zoom2/zoom2.h
@@ -32,6 +32,15 @@ const omap3_sysinfo sysinfo = {
NAND,
};
+typedef enum {
+ ZOOM2_REVISION_UNKNOWN = 0,
+ ZOOM2_REVISION_ALPHA,
+ ZOOM2_REVISION_BETA,
+ ZOOM2_REVISION_PRODUCTION
+} zoom2_revision;
+
+zoom2_revision zoom2_get_revision(void);
+
/*
* IEN - Input Enable
* IDIS- Input Disable
--
1.6.2.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] ARM next Pull Request
Hi Wolfgang Please pull The following changes since commit cab6c2a6135cc8f4244d8e9c005bddd208d2a26f: Wolfgang Denk (1): TQM834x: use buffered writes to accelerate writing to flash are available in the git repository at: git://git.denx.de/u-boot-arm.git next Dirk Behme (2): OMAP3: Zoom2: Enable Board and CPU info OMAP3: Fix CKE1 MUX setting to allow self-refresh Jean-Christophe PLAGNIOL-VILLARD (10): afeb9260: fix macb device init arm: unify linker script arm: unify interrupt init arm: remove cpu_init pxa: move serial driver to drivers/serial lh7a40x: move serial driver to drivers/serial omap24xx: rename reset file at91: extract reset from timer at91: move cpu name define to arm/arch/ cpu header at91: move cpu info print to cpu Prafulla Wadaskar (1): arch_misc_init support for ARM architectures Tom Rix (7): ZOOM2 Add serial support. ZOOM2 Add led support. OMAP3 Turn on the GPIO bank clocks ZOOM2 Define GPIO banks used. Fix a typo in the instructions on using omap3's gpio interface. Beagle Convert the board version detection to use the OMAP3 GPIO interface. ZOOM2 detect the version of the zoom2 board at runtime. arm_config.mk |2 + board/actux1/config.mk |2 + board/actux2/config.mk |2 + board/actux3/config.mk |2 + board/armadillo/u-boot.lds | 55 board/armltd/integratorap/config.mk|6 - board/armltd/integratorap/split_by_variant.sh |4 - board/armltd/integratorap/u-boot.lds.template | 53 board/armltd/integratorcp/config.mk|6 - board/armltd/integratorcp/split_by_variant.sh |4 - board/armltd/integratorcp/u-boot.lds.template | 53 board/armltd/versatile/u-boot.lds | 51 board/atmel/at91rm9200dk/u-boot.lds| 57 - board/atmel/at91rm9200ek/u-boot.lds| 56 - board/cerf250/u-boot.lds | 56 - board/cm4008/u-boot.lds| 56 - board/cm41xx/u-boot.lds| 56 - board/cmc_pu2/u-boot.lds | 57 - board/cradle/u-boot.lds| 56 - board/csb226/u-boot.lds| 56 - board/csb637/u-boot.lds| 56 - board/dave/B2/u-boot.lds | 58 - board/davedenx/qong/u-boot.lds | 58 - board/delta/u-boot.lds | 56 - board/dnp1110/u-boot.lds | 56 - board/ep7312/u-boot.lds| 56 - board/evb4510/u-boot.lds | 69 --- board/freescale/mx31ads/config.mk |2 + board/gcplus/u-boot.lds| 58 - board/impa7/u-boot.lds | 56 - board/imx31_litekit/u-boot.lds | 59 - board/imx31_phycore/u-boot.lds | 59 - board/innokom/u-boot.lds | 56 - board/kb9202/u-boot.lds| 56 - board/lart/u-boot.lds | 56 - board/logodl/u-boot.lds| 56 - board/lpc2292sodimm/u-boot.lds | 55 board/lubbock/u-boot.lds | 56 - board/m501sk/u-boot.lds| 55 board/modnet50/u-boot.lds | 69 --- board/mp2usb/u-boot.lds| 56 - board/mpl/vcma9/u-boot.lds | 57 - board/mx1ads/u-boot.lds| 58 - board/netstar/u-boot.lds | 55 board/ns9750dev/u-boot.lds | 59 - board/omap1510inn/u-boot.lds | 57 - board/omap1610inn/u-boot.lds | 52 board/omap2420h4/u-boot.lds| 59 - board/omap3/beagle/beagle.c| 32 +++-- board/omap3/beagle/beagle.h|2 +- board/omap3/overo/overo.h |2 +- board/omap3/zoom2/Makefile |7 +- board/omap3/zoom2/led.c| 129 +++ board/omap3/zoom2/zoom2.c | 102 +++- board/omap3/zoom2/zoom2.h |9 ++
Re: [U-Boot] [PATCH 2/2] KB9202: Add NAND support
Matthias Kaehlcke wrote:
hi,
El Fri, May 15, 2009 at 05:30:48PM -0500 Scott Wood ha dit:
Matthias Kaehlcke wrote:
+/*
+ * Board-specific function to access the device ready signal.
+ */
+static int kb9202_nand_ready(struct mtd_info *mtd)
+{
+ return (((AT91C_BASE_PIOC-PIO_PDSR) KB9202_NAND_BUSY) != 0);
+}
Use I/O accessors.
[snip]
+ if (ctrl NAND_NCE)
+ AT91C_BASE_PIOC-PIO_CODR = KB9202_NAND_NCE;
+ else
+ AT91C_BASE_PIOC-PIO_SODR = KB9202_NAND_NCE;
You're still not using I/O accessors in many places.
+#ifdef CONFIG_CMD_NAND
Put this in the makefile instead.
+static int kb9202_nand_ready(struct mtd_info *mtd)
+{
+ const unsigned int value = readl(AT91C_PIOC_PDSR);
+
+ return ((value KB9202_NAND_BUSY) != 0);
+}
static int kb9202_nand_ready(struct mtd_info *mtd)
{
return readl(AT91C_PIOC_PDSR) KB9202_NAND_BUSY;
}
+int board_nand_init(struct nand_chip *nand)
+{
+ unsigned int value;
+ struct _AT91S_SMC2 *at91s_smc2 = AT91C_BASE_SMC2;
+
+ nand-ecc.mode = NAND_ECC_SOFT;
+ nand-options = ~(NAND_BUSWIDTH_16);
Unnecessary parens.
+ nand-cmd_ctrl = kb9202_nand_hwcontrol;
+ nand-dev_ready = kb9202_nand_ready;
+
+ /* in case running outside of bootloader */
+ AT91C_BASE_PMC-PMC_PCER = ((unsigned) 1 AT91C_ID_PIOC);
Unnecessary cast and parens.
+ at91s_smc2-SMC2_CSR[3] =
+ AT91C_SMC2_WSEN |
+ (4 AT91C_SMC2_NWS) |
+ ((1 8) AT91C_SMC2_TDF) |
+ AT91C_SMC2_DBW_8 |
+ ((1 24) AT91C_SMC2_RWSETUP) |
+ ((1 29) AT91C_SMC2_RWHOLD);
Are those instances of (constant1 constant2) ever going to evaluate to
anything but constant1? Can we get rid of the magic numbers?
Otherwise, ACK.
-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] TSEC ethernet controller problems (crc errors/ corruption)
On Wed, 3 Jun 2009 10:50:25 -0700 Ira Snyder i...@ovro.caltech.edu wrote: On Tue, Jun 02, 2009 at 06:08:17PM -0500, Kim Phillips wrote: On Tue, 2 Jun 2009 15:19:18 -0700 Ira Snyder i...@ovro.caltech.edu wrote: On Tue, Jun 02, 2009 at 02:25:03PM -0700, Ira Snyder wrote: And what is the SICRH[30-31]? Did you have the matching settings for GMII with 3.3V? = md e118 1 e118: 0002 This looks wrong. The MPC8349EMDS board has the exact same setting in that register. Writing 0x0 to the SICRH register did not cause the problem to go away. ok this... The MPC8349EMDS config has had that setting since it was imported into U-Boot. I've copied the relevant part of include/configs/MPC8349EMDS.h below. #define CONFIG_SYS_SICRH SICRH_TSOBI1 This seems wrong for the MPC8349EMDS board. I tried setting the register value to 0x0 by hand on my MPC8349EMDS eval board, and the network still works as expected. still works or does not work? 100mbit or 1000mbit?? Network works, both 100 and 1000 mbit. and this seeming contradiction lead to my source of confusion. What I think is going on is that you're setting SICRH to 0 on your custom board and it still has its network problems, and setting it to 0 on the original MPC8349E-MDS board makes no difference - networking works with it set to both 0 and 2. ok. Is this a bug in the MPC8349EMDS config? It might be. Another thing that changed wrt that area was commit 846f1574. Assuming this is all still clear to me, perhaps what that patch does should be made 8349-revision dependent? My MPC8349EMDS reference manual says that bits 28-29 should be preserved, which is exactly what the commit message states. I don't see a problem with commit 846f1574 at all. The bug is that SICRH is set to SICRH_TSOBI1 (0x2), which changes the TSEC1 output buffer parameters to RGMII/RTBI mode. yeah my bad, I miscalculated which bits that commit was masking. The MPC8349EMDS's PHY's are both in GMII mode, the do not use RGMII/RTBI or any of the other reduced pin count interfaces. Therefore, I think the bit should be cleared, and SICRH should be set to 0x0. technically BCSR5 holds the reduced mode MII setting (set via SW4). The default is GMII, but, as in the case of the 8360 MDS, networking didn't work out of the box with the default switch settings. Even if I'm wrong, then the bits for both TSEC1 and TSEC2 should be the same. Right now, TSEC1 has the RGMII/RTBI output parameters, and TSEC2 has the GMII output parameters. In practice, this doesn't seem to make a difference on the MPC8349EMDS eval board. Both settings work without any errors. For people like me, who are copying an existing board port to a similar board, it would be nice if it was correct. granted. I'm betting the sbc8349 and tqm834x just copied the setting from the MDS code, so those should get 0 too. Board maintainers, please test: diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 3c57403..2d2799e 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -598,7 +598,7 @@ #define CONFIG_SYS_SCCR_TSEC2CM1 /* TSEC2 I2C0 clock mode (0-3) /* System IO Config */ -#define CONFIG_SYS_SICRH SICRH_TSOBI1 +#define CONFIG_SYS_SICRH 0 #define CONFIG_SYS_SICRL SICRL_LDP_A #define CONFIG_SYS_HID0_INIT 0x0 diff --git a/include/configs/TQM834x.h b/include/configs/TQM834x.h index 5ca8720..5510730 100644 --- a/include/configs/TQM834x.h +++ b/include/configs/TQM834x.h @@ -393,7 +393,7 @@ extern int tqm834x_num_flash_banks; #endif /* System IO Config */ -#define CONFIG_SYS_SICRH SICRH_TSOBI1 +#define CONFIG_SYS_SICRH 0 #define CONFIG_SYS_SICRL SICRL_LDP_A /* i-cache and d-cache disabled */ diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h index d0338f1..edd928d 100644 --- a/include/configs/sbc8349.h +++ b/include/configs/sbc8349.h @@ -519,7 +519,7 @@ #endif /* System IO Config */ -#define CONFIG_SYS_SICRH SICRH_TSOBI1 +#define CONFIG_SYS_SICRH 0 #define CONFIG_SYS_SICRL SICRL_LDP_A #define CONFIG_SYS_HID0_INIT 0x0 Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 1243826230-22233-1-git-send-email-vap...@gentoo.org you wrote: The following changes since commit 5520ab1f7685721314dcfb7cdcc7c15e6571473f: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-blackfin are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master Mike Frysinger (2): Blackfin: fix if() logic in bootrom evt1 check Blackfin: spi: fix pin handling of SPI0 SSEL4 drivers/spi/bfin_spi.c |2 +- include/asm-blackfin/blackfin-config-pre.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Es sind überhaupt nur die Dummköpfe, die sich den Befehlen der Mäch- tigen widersetzen. Um sie zu ruinieren ist es genug, ihre Befehle treu zu erfüllen. - Peter Hacks: Die schöne Helena ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-coldfire next
Dear Liew Tsi Chung-R5AAHP, In message 4791e710007feb4bbf83775d787f462f08a21...@az33exm22.fsl.freescale.net you wrote: Hi Wolfgang, Please pull this change for u-boot-coldfire/next into your next branch: The following changes since commit 9f2b981c3b47a12f8e2691b68776c4fbe0fb1394: Stefan Roese (1): ppc4xx: Remove PCI async bootup message if PCI is not used are available in the git repository at: git://www.denx.de/git/u-boot-coldfire.git next Richard Retanubun (3): Adds WATCHDOG_RESET() function call to lib_m68k dtimer_interrupt. Compier warning cleanup Coldfire M5271: Activate u-boot system timer interrupt. include/asm-m68k/immap.h |2 +- lib_m68k/board.c |3 +-- lib_m68k/time.c | 13 - 3 files changed, 14 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ...this does not mean that some of us should not want, in a rather dispassionate sort of way, to put a bullet through csh's head. - Larry Wall in 1992aug6.221512.5...@netlabs.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM next Pull Request
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090603190856.gh31...@game.jcrosoft.org you wrote: Hi Wolfgang Please pull The following changes since commit cab6c2a6135cc8f4244d8e9c005bddd208d2a26f: Wolfgang Denk (1): TQM834x: use buffered writes to accelerate writing to flash are available in the git repository at: git://git.denx.de/u-boot-arm.git next Dirk Behme (2): OMAP3: Zoom2: Enable Board and CPU info OMAP3: Fix CKE1 MUX setting to allow self-refresh Jean-Christophe PLAGNIOL-VILLARD (10): afeb9260: fix macb device init arm: unify linker script A patch for this commit has not been posted, it seems. Please make sure this does not happen again. Next time I will reject the pull. arm: unify interrupt init arm: remove cpu_init pxa: move serial driver to drivers/serial lh7a40x: move serial driver to drivers/serial omap24xx: rename reset file at91: extract reset from timer at91: move cpu name define to arm/arch/ cpu header at91: move cpu info print to cpu Prafulla Wadaskar (1): arch_misc_init support for ARM architectures Tom Rix (7): ZOOM2 Add serial support. ZOOM2 Add led support. OMAP3 Turn on the GPIO bank clocks ZOOM2 Define GPIO banks used. Fix a typo in the instructions on using omap3's gpio interface. Beagle Convert the board version detection to use the OMAP3 GPIO interface. ZOOM2 detect the version of the zoom2 board at runtime. arm_config.mk |2 + board/actux1/config.mk |2 + board/actux2/config.mk |2 + board/actux3/config.mk |2 + board/armadillo/u-boot.lds | 55 board/armltd/integratorap/config.mk|6 - board/armltd/integratorap/split_by_variant.sh |4 - board/armltd/integratorap/u-boot.lds.template | 53 board/armltd/integratorcp/config.mk|6 - board/armltd/integratorcp/split_by_variant.sh |4 - board/armltd/integratorcp/u-boot.lds.template | 53 board/armltd/versatile/u-boot.lds | 51 board/atmel/at91rm9200dk/u-boot.lds| 57 - board/atmel/at91rm9200ek/u-boot.lds| 56 - board/cerf250/u-boot.lds | 56 - board/cm4008/u-boot.lds| 56 - board/cm41xx/u-boot.lds| 56 - board/cmc_pu2/u-boot.lds | 57 - board/cradle/u-boot.lds| 56 - board/csb226/u-boot.lds| 56 - board/csb637/u-boot.lds| 56 - board/dave/B2/u-boot.lds | 58 - board/davedenx/qong/u-boot.lds | 58 - board/delta/u-boot.lds | 56 - board/dnp1110/u-boot.lds | 56 - board/ep7312/u-boot.lds| 56 - board/evb4510/u-boot.lds | 69 --- board/freescale/mx31ads/config.mk |2 + board/gcplus/u-boot.lds| 58 - board/impa7/u-boot.lds | 56 - board/imx31_litekit/u-boot.lds | 59 - board/imx31_phycore/u-boot.lds | 59 - board/innokom/u-boot.lds | 56 - board/kb9202/u-boot.lds| 56 - board/lart/u-boot.lds | 56 - board/logodl/u-boot.lds| 56 - board/lpc2292sodimm/u-boot.lds | 55 board/lubbock/u-boot.lds | 56 - board/m501sk/u-boot.lds| 55 board/modnet50/u-boot.lds | 69 --- board/mp2usb/u-boot.lds| 56 - board/mpl/vcma9/u-boot.lds | 57 - board/mx1ads/u-boot.lds| 58 - board/netstar/u-boot.lds | 55 board/ns9750dev/u-boot.lds | 59 - board/omap1510inn/u-boot.lds | 57 - board/omap1610inn/u-boot.lds | 52 board/omap2420h4/u-boot.lds| 59 - board/omap3/beagle/beagle.c| 32 +++-- board/omap3/beagle/beagle.h|2 +- board/omap3/overo/overo.h
Re: [U-Boot] TSEC ethernet controller problems (crc errors/ corruption)
On Wed, Jun 03, 2009 at 03:19:05PM -0500, Kim Phillips wrote: On Wed, 3 Jun 2009 10:50:25 -0700 Ira Snyder i...@ovro.caltech.edu wrote: On Tue, Jun 02, 2009 at 06:08:17PM -0500, Kim Phillips wrote: On Tue, 2 Jun 2009 15:19:18 -0700 Ira Snyder i...@ovro.caltech.edu wrote: On Tue, Jun 02, 2009 at 02:25:03PM -0700, Ira Snyder wrote: And what is the SICRH[30-31]? Did you have the matching settings for GMII with 3.3V? = md e118 1 e118: 0002 This looks wrong. The MPC8349EMDS board has the exact same setting in that register. Writing 0x0 to the SICRH register did not cause the problem to go away. ok this... The MPC8349EMDS config has had that setting since it was imported into U-Boot. I've copied the relevant part of include/configs/MPC8349EMDS.h below. #define CONFIG_SYS_SICRH SICRH_TSOBI1 This seems wrong for the MPC8349EMDS board. I tried setting the register value to 0x0 by hand on my MPC8349EMDS eval board, and the network still works as expected. still works or does not work? 100mbit or 1000mbit?? Network works, both 100 and 1000 mbit. and this seeming contradiction lead to my source of confusion. What I think is going on is that you're setting SICRH to 0 on your custom board and it still has its network problems, and setting it to 0 on the original MPC8349E-MDS board makes no difference - networking works with it set to both 0 and 2. ok. Yes, that is exactly correct. Sorry for my poor choice of words earlier. Is this a bug in the MPC8349EMDS config? It might be. Another thing that changed wrt that area was commit 846f1574. Assuming this is all still clear to me, perhaps what that patch does should be made 8349-revision dependent? My MPC8349EMDS reference manual says that bits 28-29 should be preserved, which is exactly what the commit message states. I don't see a problem with commit 846f1574 at all. The bug is that SICRH is set to SICRH_TSOBI1 (0x2), which changes the TSEC1 output buffer parameters to RGMII/RTBI mode. yeah my bad, I miscalculated which bits that commit was masking. The MPC8349EMDS's PHY's are both in GMII mode, the do not use RGMII/RTBI or any of the other reduced pin count interfaces. Therefore, I think the bit should be cleared, and SICRH should be set to 0x0. technically BCSR5 holds the reduced mode MII setting (set via SW4). The default is GMII, but, as in the case of the 8360 MDS, networking didn't work out of the box with the default switch settings. Even if I'm wrong, then the bits for both TSEC1 and TSEC2 should be the same. Right now, TSEC1 has the RGMII/RTBI output parameters, and TSEC2 has the GMII output parameters. In practice, this doesn't seem to make a difference on the MPC8349EMDS eval board. Both settings work without any errors. For people like me, who are copying an existing board port to a similar board, it would be nice if it was correct. granted. I'm betting the sbc8349 and tqm834x just copied the setting from the MDS code, so those should get 0 too. Board maintainers, please test: diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 3c57403..2d2799e 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -598,7 +598,7 @@ #define CONFIG_SYS_SCCR_TSEC2CM1 /* TSEC2 I2C0 clock mode (0-3) /* System IO Config */ -#define CONFIG_SYS_SICRH SICRH_TSOBI1 +#define CONFIG_SYS_SICRH 0 #define CONFIG_SYS_SICRL SICRL_LDP_A #define CONFIG_SYS_HID0_INIT 0x0 I can ACK this board. I've run the following combinations on my MPC8349EMDS eval board. All of the configurations worked perfectly. U-Boot, PCI Host mode, 1000 mbit U-Boot, PCI Host mode, 100 mbit U-Boot, PCI Agent mode, 1000 mbit U-Boot, PCI Agent mode, 100 mbit Linux, PCI Host mode, 1000 mbit Linux, PCI Host mode, 100 mbit Thanks for looking at this! Ira ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM next Pull Request
On 22:45 Wed 03 Jun , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090603190856.gh31...@game.jcrosoft.org you wrote: Hi Wolfgang Please pull The following changes since commit cab6c2a6135cc8f4244d8e9c005bddd208d2a26f: Wolfgang Denk (1): TQM834x: use buffered writes to accelerate writing to flash are available in the git repository at: git://git.denx.de/u-boot-arm.git next Dirk Behme (2): OMAP3: Zoom2: Enable Board and CPU info OMAP3: Fix CKE1 MUX setting to allow self-refresh Jean-Christophe PLAGNIOL-VILLARD (10): afeb9260: fix macb device init arm: unify linker script A patch for this commit has not been posted, it seems. I do have send it http://www.mail-archive.com/u-boot@lists.denx.de/msg14770.html rename cpu/lh7a40x/serial.c = drivers/serial/serial_lh7a40x.c (100%) rename cpu/pxa/serial.c = drivers/serial/serial_pxa.c (100%) Applied, but mind the note above. tks Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM next Pull Request
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090603204158.ga7...@game.jcrosoft.org you wrote: A patch for this commit has not been posted, it seems. I do have send it http://www.mail-archive.com/u-boot@lists.denx.de/msg14770.html This was no patch, just the patch statistics. Even though your patch consisted mostly of renames, there were still a number of changes to files about which you gave zero information - for example: board/actux1/config.mk |2 + board/actux2/config.mk |2 + board/actux3/config.mk |2 + ... board/armltd/integratorap/config.mk |6 -- board/armltd/integratorap/split_by_variant.sh |4 - ... board/armltd/integratorcp/config.mk |6 -- board/armltd/integratorcp/split_by_variant.sh |4 - ... board/freescale/mx31ads/config.mk |2 + ... board/samsung/smdk6400/config.mk|2 + ... board/trab/config.mk|2 + and so on. Please stick to the well-documented rules. Next time I will reject such a pull request, no exceptions. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The computer can't tell you the emotional story. It can give you the exact mathematical design, but what's missing is the eyebrows. - Frank Zappa ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM DaVinci: EMIF settings
On Sunday 31 May 2009, Jean-Christophe PLAGNIOL-VILLARD wrote: On 19:46 Sun 03 May , Thomas Lange wrote: NAND module should not modify EMIF registers unrelated to CS2 that is used for NAND, i.e. do not modify EWAIT config register or registers for other Chip Selects. Without this patch, EMIF configurations made in board_init() will be invalidated. Signed-off-by: Thomas Lange tho...@corelatus.se --- David, Sandeep is one of you can test it on some boards too? I'd just merge it as-is (it builds, yes?). That code is *extremely* dubious already, and the boards using that driver only use NAND on CS2. Code reconfiguring other chipselects is broken. That code is already dm6446-specific. I have one dm6446 board, which only uses CS2 ... so the only error I could turn up would be a build error. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] make MODEM SUPPORT generic instead of duplicate it
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1240664272-29583-1-git-send-email-plagn...@jcrosoft.com you wrote: and fix comment Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- v2: Fix comment Best Regards, J. common/Makefile |1 + common/modem.c | 122 +++ lib_arm/board.c | 99 lib_ppc/board.c | 97 --- 4 files changed, 123 insertions(+), 196 deletions(-) create mode 100644 common/modem.c Applied, after modifying the file header: diff --git a/common/modem.c b/common/modem.c new file mode 100644 index 000..44567b2 --- /dev/null +++ b/common/modem.c @@ -0,0 +1,122 @@ +/* + * (C) Copyright 2002-2006 + * Wolfgang Denk, DENX Software Engineering, w...@denx.de. + * + * (C) Copyright 2002 + * Sysgo Real-Time Solutions, GmbH www.elinos.com + * Marius Groeger mgroe...@sysgo.de + * + * See file CREDITS for list of people who contributed to this + * project. I deleted the Sysgo Copyright entry here, as I am sure that no part of this code was written by Sysgo. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de An Ada exception is when a routine gets in trouble and says 'Beam me up, Scotty'. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [patch] Convert DM9000 driver for CONFIG_NET_MULTI
Dear Ben, In message f8328f7c0905021953x494fff2aof44a9b3dc4194...@mail.gmail.com you wrote: All drivers need to be converted to CONFIG_NET_MULTI. This patch converts the dm9000 driver. Signed-off-by: Thomas Smits ts.sm...@gmail.com Signed-off-by: Remy Bohmer li...@bohmer.net Thanks so much for doing this! I'll look it over very soon and will provide feedback. I'm sure the driver is find, but I just want to be sure that all the board_eth_init() calls are correct. What's the state of this patch, then? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Committee, n.: A group of men who individually can do nothing but as a group decide that nothing can be done. - Fred Allen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Bug] IXP425 and e1000 network driver
Dear Ben, In message f8328f7c0905021956x56c17a13ocee92bceb353d...@mail.gmail.com you wrote: On 19:31 Sat 20 Dec , Stefan Althoefer wrote: Hi, I found that IXP425 (big endian ARM) did not work with e1000 network driver. The reason is broken access to controller registers. I get it working with this patch: Ben Ping Best Regards, J. Sorry, I let another month slip by. This looks reasonable to me, but isn't a properly-formatted patch. Stefan - if you don't have time to re-submit, just let me know and I'll do it for you. Seems Stefan has no time. Could you please take care of this, then? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A direct quote from the Boss: We passed over a lot of good people to get the ones we hired. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size
Dear Stefan Roese, In message 1242050635-7152-1-git-send-email...@denx.de you wrote: --===0052372897== This patch brings the U-Boot MTD infrastructure in sync with the current Linux MTD version (2.6.30-rc3). Biggest change is the 64bit device size support and a resync of the mtdpart.c file which has seen multiple fixes meanwhile. Signed-off-by: Stefan Roese s...@denx.de Cc: Scott Wood scottw...@freescale.com Cc: Kyungmin Park kmp...@infradead.org --- common/cmd_onenand.c |6 +- common/env_onenand.c |2 +- drivers/mtd/cfi_mtd.c|4 +- drivers/mtd/mtdpart.c| 488 +++--- drivers/mtd/nand/nand_util.c | 11 +- include/linux/mtd/mtd.h | 29 ++- 6 files changed, 256 insertions(+), 284 deletions(-) Applied to next, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nearly everyone is in favor of going to heaven but too many are hoping they'll live long enough to see an easing of the entrance requirements. Never appeal to a man's better nature. he might not have one. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] TSEC ethernet controller problems (crc errors/corruption)
The MPC8349EMDS config has had that setting since it was imported into U-Boot. I've copied the relevant part of include/configs/MPC8349EMDS.h below. #define CONFIG_SYS_SICRH SICRH_TSOBI1 This seems wrong for the MPC8349EMDS board. I tried setting the register value to 0x0 by hand on my MPC8349EMDS eval board, and the network still works as expected. Is this a bug in the MPC8349EMDS config? IIRC, the MPC8349EMDS has one configuration LVDD for TSEC1/2 MAC-PHY interface, That is jumpers to choose 2.5v or 3.3v . It is possible we leave the mess in the code at that time. Please fix the bug according to real fact. Thanks, Dave ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] TSEC ethernet controller problems (crc errors/corruption)
Hi Dave, The MPC8349EMDS config has had that setting since it was imported into U-Boot. I've copied the relevant part of include/configs/MPC8349EMDS.h below. #define CONFIG_SYS_SICRH SICRH_TSOBI1 This seems wrong for the MPC8349EMDS board. I tried setting the register value to 0x0 by hand on my MPC8349EMDS eval board, and the network still works as expected. Is this a bug in the MPC8349EMDS config? IIRC, the MPC8349EMDS has one configuration LVDD for TSEC1/2 MAC-PHY interface, That is jumpers to choose 2.5v or 3.3v . It is possible we leave the mess in the code at that time. Please fix the bug according to real fact. The MPC8349EA LVDD power is supposed to be 3.3V for GMII and 2.5V for RGMII. As you comment, the evaluation board has a jumper to select the power rail. By default the board is setup for GMII with LVDD at 3.3V, so the TSEC impedance bits should be left low. The patch by Kim is correct for the MPC8349EA-MDS nominal board configuration. Cheers, Dave ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mtd: MTD related config header changes (mtdparts command)
Dear Stefan Roese, In message 1242131578-23000-1-git-send-email...@denx.de you wrote: By changing the cmd_mtdparts to only use the MTD infrastructure and not the direct interface to the CFI NOR FLASH driver we now need to add the MTD infrastructure to all boards using those mtdparts commands. This patch adds those components: CONFIG_MTD_DEVICE (for all FLASH types) plus CONFIG_FLASH_CFI_MTD (for NOR FLASH) To all board maintainers: Please test this on your platforms and report any problems/issues found. Thanks. Signed-off-by: Stefan Roese s...@denx.de Cc: Wolfgang Denk w...@denx.de Cc: Ron Madrid i...@sheldoninst.com Cc: Georg Schardt scha...@team-ctech.de Cc: Michal Simek mon...@monstr.eu Cc: Ladislav Michl la...@linux-mips.org Cc: Martin Krause martin.kra...@tqs.de Cc: Gary Jennejohn g...@denx.de Cc: Ricardo Ribalda ricardo.riba...@uam.es --- include/configs/BC3450.h |2 ++ include/configs/FPS850L.h|2 ++ include/configs/FPS860L.h|2 ++ include/configs/SIMPC8313.h |1 + include/configs/TB5200.h |2 ++ include/configs/TQM5200.h|2 ++ include/configs/TQM823L.h|2 ++ include/configs/TQM823M.h|2 ++ include/configs/TQM834x.h|2 ++ include/configs/TQM850L.h|2 ++ include/configs/TQM850M.h|2 ++ include/configs/TQM855L.h|2 ++ include/configs/TQM855M.h|2 ++ include/configs/TQM85xx.h|2 ++ include/configs/TQM860L.h|2 ++ include/configs/TQM860M.h|2 ++ include/configs/TQM862L.h|2 ++ include/configs/TQM862M.h|2 ++ include/configs/TQM866M.h|2 ++ include/configs/apollon.h|1 + include/configs/cm5200.h |2 ++ include/configs/fx12mm.h |2 ++ include/configs/idmr.h |2 ++ include/configs/microblaze-generic.h |2 ++ include/configs/motionpro.h |2 ++ include/configs/mx1fs2.h |2 ++ include/configs/netstar.h|2 ++ include/configs/omap3_beagle.h |1 + include/configs/qong.h |2 ++ include/configs/smmaco4.h|2 ++ include/configs/trab.h |2 ++ include/configs/vct.h|1 + include/configs/virtlab2.h |2 ++ include/configs/voiceblue.h |2 ++ include/configs/xilinx-ppc.h |2 ++ 35 files changed, 66 insertions(+), 0 deletions(-) Applied to next (after fixing the typo in Gary's mail address). Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A dog always bit deepest on the veterinary hand. - Terry Pratchett, _Wyrd Sisters_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mtd: Introduce CONFIG_MTD_DEVICE to select compilation of mtdcore.o
Dear Stefan Roese, In message 1242131478-22916-1-git-send-email...@denx.de you wrote: This new define enables mtdcore.c compilation and with this we can select the MTD device infrastructure needed for the reworked mtdparts command. We now have the 2 MTD infrastructure defines, CONFIG_MTD_DEVICE and CONFIG_MTD_PARTITIONS. CONFIG_MTD_DEVICE is needed (as explained above) for the mtdparts command and CONFIG_MTD_PARTITIONS is needed for UBI. Signed-off-by: Stefan Roese s...@denx.de Cc: Scott Wood scottw...@freescale.com --- README | 11 +++ drivers/mtd/Makefile|3 ++- drivers/mtd/nand/nand.c |2 +- drivers/mtd/onenand/onenand_uboot.c |2 +- 4 files changed, 15 insertions(+), 3 deletions(-) Applied to next, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The sight of death frightens them [Earthers]. -- Kras the Klingon, Friday's Child, stardate 3497.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_mtdparts: Move to common handling of FLASH devices via MTD layer
Dear Stefan Roese, In message 1242131516-22957-1-git-send-email...@denx.de you wrote: This patch removes all references to the direct CFI FLASH interface (via flash_info[]). Now that all FLASH types currently handled in mtdparts are available (if selected, see below) via the MTD infrastructure. This is NOR, NAND and OneNAND right now. This can be achieved by defining the following options: CONFIG_MTD_DEVICE (for all FLASH types) plus CONFIG_FLASH_CFI_MTD (for NOR FLASH) So we need to add those defines to the board config headers currently using the mtdparts commands. This is done via another patch, so we shouldn't break mtdparts compatibility. One big advantage from this solution is that the cmd_mtdparts.c is *much* cleaner now. Lot's of #ifdef's are removed and the code itself is smaller. Additionally the newly added MDT concatenation feature can new be used via the mtdparts infrastructure and therefor via UBI etc. Signed-off-by: Stefan Roese s...@denx.de Cc: Ladislav Michl la...@linux-mips.org Cc: Scott Wood scottw...@freescale.com --- v2: - Use CONFIG_MTD_DEVICE instead of CONFIG_MTD_PARTITIONS in commit text. common/cmd_mtdparts.c | 240 1 files changed, 80 insertions(+), 160 deletions(-) Applied to next. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Microsoft Multimedia: You have nice graphics, sound and animations when the system crashes. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] 74xx_7xx: Add CPCI adapter/target support for the CPCI750
Dear Stefan Roese, In message 1242278769-23870-1-git-send-email...@denx.de you wrote: The CPCI750 can be built as CPCI host or adapter/target board. This patch adds support for runtime detection of those variants. It seems this patch also does a lot of other things, which are not mentioned in the commit message. I recommend to split this into separate commits. Signed-off-by: Stefan Roese s...@denx.de Cc: Reinhard Arlt reinhard.a...@esd-electronics.com --- board/esd/cpci750/cpci750.c | 108 +++ board/esd/cpci750/ide.c |4 +- board/esd/cpci750/pci.c | 57 -- include/configs/CPCI750.h |5 ++- 4 files changed, 147 insertions(+), 27 deletions(-) Not applied. Sorry. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If God had a beard, he'd be a UNIX programmer. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: it's safe to ignore mmc_send_if_cond() return value
Dear Ilya Yanok, In message 1242295389-3682-1-git-send-email-ya...@emcraft.com you wrote: Return value of mmc_send_if_cond() can be safely ignored (as it is done in Linux). This makes older cards work with MXC MCI controller. Signed-off-by: Ilya Yanok ya...@emcraft.com --- drivers/mmc/mmc.c |4 1 files changed, 0 insertions(+), 4 deletions(-) Applied to master. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The man on tops walks a lonely street; the chain of command is often a noose. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Redundant Environment: protect full sector size
Hello, In message 1242339363-28686-3-git-send-email...@denx.de you wrote: Several boards used different ways to specify the size of the protected area when enabling flash write protection for the sectors holding the environment variables: some used CONFIG_ENV_SIZE and CONFIG_ENV_SIZE_REDUND, some used CONFIG_ENV_SECT_SIZE, and some even a mix of both for the normal and the redundant areas. Normally, this makes no difference at all. However, things are different when you have to deal with boards that can come with different types of flash chips, which may have different sector sizes. Here we may have to chose CONFIG_ENV_SECT_SIZE such that it fits the biggest sector size, which may include several sectors on boards using the smaller sector flash types. In such a case, using CONFIG_ENV_SIZE or CONFIG_ENV_SIZE_REDUND to enable the protection may lead to the case that only the first of these sectors get protected, while the following ones aren't. This is no real problem, but it can be confusing for the user - especially on boards that use CONFIG_ENV_SECT_SIZE to protect the normal areas, while using CONFIG_ENV_SIZE_REDUND for the redundant area. To avoid such inconsistencies, I changed all sucn boards that I found to consistently use CONFIG_ENV_SECT_SIZE for protection. This should not cause any functional changes to the code. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Paul Ruhland Cc: Pantelis Antoniou pa...@intracom.gr Cc: Stefan Roese s...@denx.de Cc: Gary Jennejohn ga...@denx.de Cc: Dave Ellis d...@sixnetio.com --- board/lpd7a40x/flash.c |4 ++-- board/mcc200/mcc200.c |2 +- board/netphone/flash.c |4 ++-- board/netta/flash.c|4 ++-- board/netta2/flash.c |4 ++-- board/netvia/flash.c |4 ++-- board/pleb2/flash.c|4 ++-- board/prodrive/pdnb3/flash.c |2 +- board/rmu/flash.c |6 +++--- board/samsung/smdk2400/flash.c |4 ++-- board/sixnet/flash.c |4 ++-- board/socrates/socrates.c |2 +- board/tqc/tqm85xx/tqm85xx.c|2 +- board/trab/flash.c |4 ++-- drivers/mtd/cfi_flash.c|2 +- 15 files changed, 26 insertions(+), 26 deletions(-) Applied to master. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If that makes any sense to you, you have a big problem. -- C. Durance, Computer Science 234 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_mtdparts.c: allow to omit definitions for default settings
Hello, In message 1242568914-21978-1-git-send-email...@denx.de you wrote: There is actually no good reason to enforce that all board configuations must define default settings for mtdids and mtdparts. Actually this may be difficult to handle, especially on boards where different sizes of flash chips can be fit, so there is no real default partition map for all boards. Lift this arbitrary limitation. Signed-off-by: Wolfgang Denk w...@denx.de --- common/cmd_mtdparts.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Applied to next. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Humans do claim a great deal for that particular emotion (love). -- Spock, The Lights of Zetar, stardate 5725.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] EP88x: fix broken linker script
Signed-off-by: Wolfgang Denk w...@denx.de
Tested-by: Mikhail Zaturenskiy mzaturens...@shoppertrak.com
---
board/ep88x/u-boot.lds |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/board/ep88x/u-boot.lds b/board/ep88x/u-boot.lds
index dd62e58..b3849de 100644
--- a/board/ep88x/u-boot.lds
+++ b/board/ep88x/u-boot.lds
@@ -90,11 +90,13 @@ SECTIONS
_edata = .;
PROVIDE (edata = .);
+ . = .;
__u_boot_cmd_start = .;
.u_boot_cmd : { *(.u_boot_cmd) }
__u_boot_cmd_end = .;
+ . = .;
__start___ex_table = .;
__ex_table : { *(__ex_table) }
__stop___ex_table = .;
--
1.6.0.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] TSEC ethernet controller problems (crc errors/ corruption)
Kim Phillips wrote: On Wed, 3 Jun 2009 10:50:25 -0700 Ira Snyder i...@ovro.caltech.edu wrote: ... In practice, this doesn't seem to make a difference on the MPC8349EMDS eval board. Both settings work without any errors. For people like me, who are copying an existing board port to a similar board, it would be nice if it was correct. granted. I'm betting the sbc8349 and tqm834x just copied the setting You would be correct (at least for the sbc). from the MDS code, so those should get 0 too. Board maintainers, please test: I won't be able to test this on an sbc until later this week, but don't let that stop you from queueing it up; I suspect it will just be a formality. Thanks, Paul. diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h index d0338f1..edd928d 100644 --- a/include/configs/sbc8349.h +++ b/include/configs/sbc8349.h @@ -519,7 +519,7 @@ #endif /* System IO Config */ -#define CONFIG_SYS_SICRH SICRH_TSOBI1 +#define CONFIG_SYS_SICRH 0 #define CONFIG_SYS_SICRL SICRL_LDP_A #define CONFIG_SYS_HID0_INIT 0x0 Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: it's safe to ignore mmc_send_if_cond() return value
On Wed, Jun 3, 2009 at 5:15 PM, Wolfgang Denk w...@denx.de wrote: Dear Ilya Yanok, In message 1242295389-3682-1-git-send-email-ya...@emcraft.com you wrote: Return value of mmc_send_if_cond() can be safely ignored (as it is done in Linux). This makes older cards work with MXC MCI controller. Signed-off-by: Ilya Yanok ya...@emcraft.com --- drivers/mmc/mmc.c |4 1 files changed, 0 insertions(+), 4 deletions(-) Applied to master. Thanks. Wolfgang, I have an identical, but different patch from Yauhen Kharuzhy applied to my tree, ready for pulling... I can take it out, but I hope I don't have to back out a bunch of patches. :) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Create the S5PC100 SoC header under the include/asm-arm/arch-s5pc100
Dear Dirk, Ah, I was busy yesterday. Well, I can write the message now. I wonder if there is any patch missing here? Is it correct that this series stops after 2 patches? Shouldn't there be at least something added to board directory? And I miss a config file to be able to compile this stuff. Ok. I have a patch. It's a board specific file. But, It's not ready to send yet. It's working on. So, I update the SoC Header patches first to be reviewed to maintainers or countributors. Is it available? or not? I was not sure whether it was right or not. As soon as possible, I'll update Board patch for SMDKC100. Perhaps, It'll be next weeks, and I will re-update any other my fixed patches. - new S5PC100 #0, 1, 2. Thanks to keep watching :) Best Regards, riverful ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-mpc85xx.git
are available in the git repository at: git://www.denx.de/git/u-boot-mpc85xx.git master Dave Liu (3): 85xx: Fix the clock adjust of mpc8569mds board 85xx: Fix the wrong BCSR address of 8569MDS 85xx: Fix the wrong SYS_CLK_IN for 8569MDS Fredrik Arnerup (1): 85xx: bugfix for reading maximum TLB size on mpc85xx Srikanth Srinivasan (1): 85xx: Add P2020DS support MAKEALL|2 + Makefile |9 + board/freescale/mpc8569mds/bcsr.c |2 +- board/freescale/mpc8569mds/ddr.c |2 +- board/freescale/p2020ds/Makefile | 54 +++ board/freescale/p2020ds/config.mk | 32 ++ board/freescale/p2020ds/ddr.c | 130 +++ board/freescale/p2020ds/law.c | 42 ++ board/freescale/p2020ds/p2020ds.c | 634 ++ board/freescale/p2020ds/tlb.c | 95 + board/freescale/p2020ds/u-boot.lds | 143 +++ cpu/mpc85xx/tlb.c |2 +- include/configs/MPC8569MDS.h |4 +- include/configs/P2020DS.h | 741 14 files changed, 1887 insertions(+), 5 deletions(-) create mode 100644 board/freescale/p2020ds/Makefile create mode 100644 board/freescale/p2020ds/config.mk create mode 100644 board/freescale/p2020ds/ddr.c create mode 100644 board/freescale/p2020ds/law.c create mode 100644 board/freescale/p2020ds/p2020ds.c create mode 100644 board/freescale/p2020ds/tlb.c create mode 100644 board/freescale/p2020ds/u-boot.lds create mode 100644 include/configs/P2020DS.h ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver
Kuribayashi-san, Do you think that you should include the Acked SATA driver in merge window of the next release (2009/08 or -09?)? I want to open the ACKed SATA driver to the public to the CanyonLands user. Regards, Kazuaki Ichinohe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
