Re: [U-Boot] [PATCH 2/2] calimain: Generate random MAC address for factory tests
Hello Wolfgang,
Thank you again for your comments.
On 2013-01-08 18:39, Wolfgang Denk wrote:
Dear Christian Riesch,
In message 6cc4810c-1e2e-4ebf-912a-96936f035...@mary.at.omicron.at you wrote:
Signed-off-by: Christian Riesch christian.rie...@omicron.at
---
board/omicron/calimain/calimain.c | 31 ++-
include/configs/calimain.h|2 ++
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/board/omicron/calimain/calimain.c
b/board/omicron/calimain/calimain.c
index 1060a1f..80e3893 100644
--- a/board/omicron/calimain/calimain.c
+++ b/board/omicron/calimain/calimain.c
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 OMICRON electronics GmbH
+ * Copyright (C) 2011-2013 OMICRON electronics GmbH
*
* Based on da850evm.c. Original Copyrights follow:
*
@@ -136,6 +136,35 @@ int board_init(void)
return 0;
}
+/* seed random number generator with uninitialized SRAM content */
+static void srand_sram(void)
+{
+ int *p;
+ int seed = 0;
+
+ for (p = (int *) 0x8000; p (int *) 0x8001; p++)
+ seed ^= *p;
+
+ srand(seed);
+}
Note that your uninitialized SRAM content is probably not so much
random at all -
There are several papers around describing the use of initial SRAM value
after power up for the generation of random numbers. This is why I gave
it a try, and it works pretty well for me. I get a different seed for
each power-up cycle. I guess that the randomness is limited and that
part of the generated seed is more a fingerprint for the chip, therefore
it may not be good enough for security related stuff, but for my purpose
it's ok.
I guess, it is much less random than the originally
used timer value.
In my case the timer value is not random at all since it is reset to
zero at power-up. Since seeding the random number generator is always
done at the same time after power-up in the current code, the seed will
always be the same for my devices. Therefore the generated MAC address
will always be the same for all devices.
What exactly is your justification for such a change? Please
elucidate...
Actually I do not change anything ;-)
For the lsxl board that is currently the only user of eth_random_enet(),
nothing changes. get_timer(0) remains the source of the randomness for
this board. My patches only allow other boards to use a sources of
randomness that is available to them instead of forcing everyone to use
get_timer(0).
+int board_late_init(void)
+{
+ uchar enetaddr[6];
+
+ if (!eth_getenv_enetaddr(ethaddr, enetaddr)) {
+ srand_sram();
+ eth_random_enetaddr(enetaddr);
+ if (eth_setenv_enetaddr(ethaddr, enetaddr)) {
+ printf(Failed to set random ethernet address\n);
+ } else {
+ printf(Setting random ethernet address %pM.\n,
+ enetaddr);
+ }
+ }
+ return 0;
+}
NAK! You are but duplicating the code already present in net/eth.c
Apparently I am missing something here. I do not see a call of
eth_random_enetaddr() in net/eth.c. To which part of net/eth.c are you
referring?
Regards, Christian
This makes no sense.
Best regards,
Wolfgang Denk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] net: Remove call of srand from eth_random_enetaddr()
Dear Christian Riesch, In message cabklobrl2bhkmjh9nccv1uq-cbfjisuidk8joe8dsaoekqi...@mail.gmail.com you wrote: I don't like this change. What exactly is wrong with using the timer here? It is probably much more random that the (so-called) un-initialized memory you suggest to use instead. On the AM1808 SoC the counter is reset to zero on power up. So using it to generate random numbers in code that is called interactively by the user is fine and will yield a random MAC address, but in my case I will get the same MAC address on each board at each power up. I think the whole concept of using random MAC adresses is broken. You should consider thinking about fixing the root cause of your problem. If there is really need to use another inital valu, only this should be fixed - but the srand() call itself should remain as is. For other boards it may be ok to use a counter, and for some there may be no SRAM or it may be already overwritten, e.g by the SPL... Therefore I am not changing this for all boards, but make it board specific. I don't want to see any board specific code here. If using the timer is not good enough, then pass a weak funtion as argument to srand() which defaults to using the timer as we do now, and which can be redefined in board specific code. Other than this, the common code should not be changed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The main thing is the play itself. I swear that greed for money has nothing to do with it, although heaven knows I am sorely in need of money. - Feodor Dostoyevsky ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] calimain: Generate random MAC address for factory tests
Dear Christian Riesch, In message 50ed2b84.2080...@omicron.at you wrote: What exactly is your justification for such a change? Please elucidate... Actually I do not change anything ;-) Why do you need a patch then? :-P NAK! You are but duplicating the code already present in net/eth.c Apparently I am missing something here. I do not see a call of eth_random_enetaddr() in net/eth.c. To which part of net/eth.c are you referring? Hm... I can't find it now, either. Dunno what I have seen then. eventually I was looking at your patch in two windows :-( Sorry - but still: very similar code exists in rescue_mode() in board/buffalo/lsxl/lsxl.c; this should be factored out. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Any sufficiently advanced technology is indistinguishable from a rigged demo. - Andy Finkel, computer guy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] fs: fat: Fix mkcksum() function parameters
Dear Aaron Williams, Hi Marek, This patch is broken. It breaks detecting duplicate filenames. The problem is that you are using sizeof(name) and sizeof(ext). This does not work since this just reports the size of the pointer in gcc 4.7, which according to our compiler guy is the correct behavior. Instead of using sizeof, just use 8 and 3 respectively. Otherwise it is doing a checksum of 4 and 4 characters. You're right. Can you post a patch for that please? This was already applied. Also, do you see any symptoms? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V6 0/4] Add support for FIMD and DP on SMDK5250
[PATCH V6 1/4] EXYNOS5: Change parent clock of FIMD to MPLL [PATCH V6 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM [PATCH V6 3/4] video: Modify exynos_fimd driver to support LCD console [PATCH V6 4/4] EXYNOS5: Add support for FIMD and DP arch/arm/cpu/armv7/exynos/clock.c| 2 +- arch/arm/include/asm/arch-exynos/dp_info.h | 2 + arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 ++ board/samsung/smdk5250/smdk5250.c| 97 drivers/video/exynos_fb.c| 2 + drivers/video/exynos_fimd.c | 12 ++-- include/configs/exynos5250-dt.h | 8 +++ 7 files changed, 125 insertions(+), 5 deletions(-) -- 1.8.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V6 1/4] EXYNOS5: Change parent clock of FIMD to MPLL
With VPLL as source clock to FIMD, Exynos DP Initializaton was failing sometimes with unstable clock. Changing FIMD source to MPLL resolves this issue. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com Acked-by: Simon Glass s...@chromium.org Acked-by: Donghwa Lee dh09@samsung.com --- Changes in V2: -- Fix commit message. Had written VPLL instead of MPLL. Changes in V3: -- Added changelog in commit message. Changes in V6: -- Moved changelog to proper position arch/arm/cpu/armv7/exynos/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c index ae6d7fe..abc3272 100644 --- a/arch/arm/cpu/armv7/exynos/clock.c +++ b/arch/arm/cpu/armv7/exynos/clock.c @@ -741,7 +741,7 @@ void exynos5_set_lcd_clk(void) */ cfg = readl(clk-src_disp1_0); cfg = ~(0xf); - cfg |= 0x8; + cfg |= 0x6; writel(cfg, clk-src_disp1_0); /* -- 1.8.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V6 3/4] video: Modify exynos_fimd driver to support LCD console
Currently, exynos FIMD driver is being used to support only TIZEN LOGOs. In order to get LCD console, we need to enable half word swap feature of FIMD and use 16 BPP. LCD console and proprietary Logo cannot be used simultaneously. We use logo_on field inside vidinfo_t structure to decide whether user wants Logo or Console. Define CONFIG_CMD_BMP and make logo_on = 1 to get Logo on screen. Use logo_on = 0 to get output console on LCD. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- Changes in V2: -- Use CONFIG_CMD_BMP instead of CONFIG_TIZEN to distinguish between Proprietary logo support and LCD console support. Changes in V3: -- Create and use new config CONFIG_EXYNOS_LOGO instead of using CONFIG_CMD_BMP Changes in V4: -- Remove #ifdef CONFIG_EXYNOS_LOGO, instead use logo_on field to add LCD console support. Changes in V5: -- Remove dummy definition for bmp_display. Instead, place the call to bmp_display inside #ifdef CONFIG_CMD_BMP -- Added changelog in commit message. Changes in V6: -- Moved changelog to proper position drivers/video/exynos_fb.c | 2 ++ drivers/video/exynos_fimd.c | 12 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c index aac74a3..25d73cf 100644 --- a/drivers/video/exynos_fb.c +++ b/drivers/video/exynos_fb.c @@ -88,7 +88,9 @@ static void draw_logo(void) } addr = panel_info.logo_addr; +#ifdef CONFIG_CMD_BMP bmp_display(addr, x, y); +#endif } static void lcd_panel_on(vidinfo_t *vid) diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c index 06eae2e..2efe6a6 100644 --- a/drivers/video/exynos_fimd.c +++ b/drivers/video/exynos_fimd.c @@ -88,14 +88,18 @@ static void exynos_fimd_set_par(unsigned int win_id) /* DATAPATH is DMA */ cfg |= EXYNOS_WINCON_DATAPATH_DMA; - /* bpp is 32 */ - cfg |= EXYNOS_WINCON_WSWP_ENABLE; + if (pvid-logo_on) /* To get proprietary LOGO */ + cfg |= EXYNOS_WINCON_WSWP_ENABLE; + else /* To get output console on LCD */ + cfg |= EXYNOS_WINCON_HAWSWP_ENABLE; /* dma burst is 16 */ cfg |= EXYNOS_WINCON_BURSTLEN_16WORD; - /* pixel format is unpacked RGB888 */ - cfg |= EXYNOS_WINCON_BPPMODE_24BPP_888; + if (pvid-logo_on) /* To get proprietary LOGO */ + cfg |= EXYNOS_WINCON_BPPMODE_24BPP_888; + else /* To get output console on LCD */ + cfg |= EXYNOS_WINCON_BPPMODE_16BPP_565; writel(cfg, (unsigned int)fimd_ctrl-wincon0 + EXYNOS_WINCON(win_id)); -- 1.8.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 4/4] EXYNOS5: Add support for FIMD and DP
Add panel_info structure required by LCD driver
and DP panel platdata for SMDK5250.
Add GPIO configuration for LCD.
Enable FIMD and DP support on SMDK5250.
DP Panel size: 2560x1600.
We use 16BPP resolution to get LCD console.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
Acked-by: Simon Glass s...@chomium.org
---
changes in V2:
-- Move LCD GPIO confiration from exynos common file to board file.
changes in V3:
-- Remove explicit call for cfg_lcd_gpio and add it as callback.
changes in V4:
-- use logo_on = 1 for smdk5250 panel_info structure.
changes in V5:
-- Move CONFIGS from smdk5250.h to exynos5250-dt.h.
-- Added changelog in commit message.
Changes in V6:
-- Fix compilation warning:
implicit declaration of function 'exynos_set_dp_platform_data'
-- Moved changelog to proper position
arch/arm/include/asm/arch-exynos/dp_info.h | 2 +
board/samsung/smdk5250/smdk5250.c | 97 ++
include/configs/exynos5250-dt.h| 8 +++
3 files changed, 107 insertions(+)
diff --git a/arch/arm/include/asm/arch-exynos/dp_info.h
b/arch/arm/include/asm/arch-exynos/dp_info.h
index 3569498..102b709 100644
--- a/arch/arm/include/asm/arch-exynos/dp_info.h
+++ b/arch/arm/include/asm/arch-exynos/dp_info.h
@@ -211,4 +211,6 @@ unsigned int exynos_init_dp(void)
}
#endif
+void exynos_set_dp_platform_data(struct exynos_dp_platform_data *pd);
+
#endif /* _DP_INFO_H */
diff --git a/board/samsung/smdk5250/smdk5250.c
b/board/samsung/smdk5250/smdk5250.c
index d80f75d..9c4bf9b 100644
--- a/board/samsung/smdk5250/smdk5250.c
+++ b/board/samsung/smdk5250/smdk5250.c
@@ -24,13 +24,16 @@
#include fdtdec.h
#include asm/io.h
#include i2c.h
+#include lcd.h
#include netdev.h
#include spi.h
#include asm/arch/cpu.h
#include asm/arch/gpio.h
#include asm/arch/mmc.h
#include asm/arch/pinmux.h
+#include asm/arch/power.h
#include asm/arch/sromc.h
+#include asm/arch/dp_info.h
#include power/pmic.h
DECLARE_GLOBAL_DATA_PTR;
@@ -277,3 +280,97 @@ int board_early_init_f(void)
return err;
}
#endif
+
+void cfg_lcd_gpio(void)
+{
+ struct exynos5_gpio_part1 *gpio1 =
+ (struct exynos5_gpio_part1 *) samsung_get_base_gpio_part1();
+
+ /* For Backlight */
+ s5p_gpio_cfg_pin(gpio1-b2, 0, GPIO_OUTPUT);
+ s5p_gpio_set_value(gpio1-b2, 0, 1);
+
+ /* LCD power on */
+ s5p_gpio_cfg_pin(gpio1-x1, 5, GPIO_OUTPUT);
+ s5p_gpio_set_value(gpio1-x1, 5, 1);
+
+ /* Set Hotplug detect for DP */
+ s5p_gpio_cfg_pin(gpio1-x0, 7, GPIO_FUNC(0x3));
+}
+
+vidinfo_t panel_info = {
+ .vl_freq= 60,
+ .vl_col = 2560,
+ .vl_row = 1600,
+ .vl_width = 2560,
+ .vl_height = 1600,
+ .vl_clkp= CONFIG_SYS_LOW,
+ .vl_hsp = CONFIG_SYS_LOW,
+ .vl_vsp = CONFIG_SYS_LOW,
+ .vl_dp = CONFIG_SYS_LOW,
+ .vl_bpix= 4,/* LCD_BPP = 2^4, for output conosle on LCD */
+
+ /* wDP panel timing infomation */
+ .vl_hspw= 32,
+ .vl_hbpd= 80,
+ .vl_hfpd= 48,
+
+ .vl_vspw= 6,
+ .vl_vbpd= 37,
+ .vl_vfpd= 3,
+ .vl_cmd_allow_len = 0xf,
+
+ .win_id = 3,
+ .cfg_gpio = cfg_lcd_gpio,
+ .backlight_on = NULL,
+ .lcd_power_on = NULL,
+ .reset_lcd = NULL,
+ .dual_lcd_enabled = 0,
+
+ .init_delay = 0,
+ .power_on_delay = 0,
+ .reset_delay= 0,
+ .interface_mode = FIMD_RGB_INTERFACE,
+ .dp_enabled = 1,
+};
+
+static struct edp_device_info edp_info = {
+ .disp_info = {
+ .h_res = 2560,
+ .h_sync_width = 32,
+ .h_back_porch = 80,
+ .h_front_porch = 48,
+ .v_res = 1600,
+ .v_sync_width = 6,
+ .v_back_porch = 37,
+ .v_front_porch = 3,
+ .v_sync_rate = 60,
+ },
+ .lt_info = {
+ .lt_status = DP_LT_NONE,
+ },
+ .video_info = {
+ .master_mode = 0,
+ .bist_mode = DP_DISABLE,
+ .bist_pattern = NO_PATTERN,
+ .h_sync_polarity = 0,
+ .v_sync_polarity = 0,
+ .interlaced = 0,
+ .color_space = COLOR_RGB,
+ .dynamic_range = VESA,
+ .ycbcr_coeff = COLOR_YCBCR601,
+ .color_depth = COLOR_8,
+ },
+};
+
+static struct exynos_dp_platform_data dp_platform_data = {
+ .phy_enable = set_dp_phy_ctrl,
+ .edp_dev_info = edp_info,
+};
+
+void init_panel_info(vidinfo_t *vid)
+{
+ vid-rgb_mode = MODE_RGB_P,
+
+ exynos_set_dp_platform_data(dp_platform_data);
+}
diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
index 59182f4..07bca1d 100644
--- a/include/configs/exynos5250-dt.h
+++
[U-Boot] [PATCH V6 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM
When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM.
But if we do not select CONFIG_EXYNOS_MIPI_DSIM, exynos_fb.c throws
error saying exynos_mipi_dsi_init() not defined. So, we add
dummy definition for exynos_mipi_dsi_init when CONFIG_EXYNOS_MIPI_DSIM
is not defined.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
Acked-by: Simon Glass s...@chromium.org
Acked-by: Donghwa Lee dh09@samsung.com
---
Changes in V2:
-- Make dummy definition for exynos_mipi_dsi_init as static.
Changes in V3:
-- Added Changelog in commit message.
Changes in V6:
-- Moved changelog to proper position
arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
index 9a7cbeb..c1c9a35 100644
--- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
+++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
@@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
void(*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
};
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
int exynos_mipi_dsi_init(void);
+#else
+static inline int exynos_mipi_dsi_init(void)
+{
+ return 0;
+}
+#endif
/*
* register mipi_dsim_lcd_driver object defined by lcd panel driver
--
1.8.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [U-Boot Web-Documentation misses command nand]
Hi, why is it, that the documentation in http://www.denx.de/wiki/view/DULG/Manual misses the U-Boot nand command? For newbies like me the web manual is one of the first points to start when trying to understand how to accomplish a specific boot task with the help of U-Boot. The sources contain documentation for the nand command in doc/README.nand. I wished to have had a hint in the Documentation at the very beginning of http://www.denx.de/wiki/view/DULG/Manual and maybe another hint in section 5.9 U-Boot command line interface, just a reference to the source documentation src/doc. Best regards, Christoph Petzold ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 0/6] Improve default environment for easy use
This patchset improves the default environment of machines currently
supported in OpenEmbedded and Yocto to make it compatible with
mainline and Freescale BSP Linux kernel.
A new patch has been add to change the format in mx6qsabrelite in
environment setting and already merged patches removed from this new
pull request.
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- New patch
- reformat environment change to fit in 80 cols
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
Otavio Salvador (6):
mx6qsabrelite: Use tabs to environment setting
mx28evk: We shouldn't hardcode a rootfs filesystem type
mx28evk: Add support to dynamically choose between ftd use or not
mx53loco: Add support to dynamically choose between ftd use or not
mx6qsabrelite: Add support to dynamically choose between ftd use or
not
mx6qsabre{auto,sd}: Add support to dynamically choose between ftd use
or not
include/configs/mx28evk.h | 47 ++---
include/configs/mx53loco.h | 40 +-
include/configs/mx6qsabre_common.h | 41 +--
include/configs/mx6qsabreauto.h|1 +
include/configs/mx6qsabrelite.h| 101
include/configs/mx6qsabresd.h |1 +
6 files changed, 186 insertions(+), 45 deletions(-)
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 1/6] mx6qsabrelite: Use tabs to environment setting
This rework the environment to use tabs for environment setting as
done in other boards.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- New patch
include/configs/mx6qsabrelite.h | 66 +++
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
index 0f6bbb4..ee86f9b 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -152,43 +152,43 @@
#define CONFIG_SYS_TEXT_BASE 0x1780
#define CONFIG_EXTRA_ENV_SETTINGS \
- script=boot.scr\0 \
- uimage=uImage\0 \
+ script=boot.scr\0 \
+ uimage=uImage\0 \
console=ttymxc1\0 \
- fdt_high=0x\0 \
+ fdt_high=0x\0 \
initrd_high=0x\0 \
- mmcdev=0\0 \
- mmcpart=2\0 \
- mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
- mmcargs=setenv bootargs console=${console},${baudrate} \
- root=${mmcroot}\0 \
- loadbootscript= \
- fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
- bootscript=echo Running bootscript from mmc ...; \
- source\0 \
- loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
- mmcboot=echo Booting from mmc ...; \
- run mmcargs; \
- bootm\0 \
- netargs=setenv bootargs console=${console},${baudrate} \
- root=/dev/nfs \
- ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
- netboot=echo Booting from net ...; \
- run netargs; \
- dhcp ${uimage}; bootm\0 \
+ mmcdev=0\0 \
+ mmcpart=2\0 \
+ mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
+ mmcargs=setenv bootargs console=${console},${baudrate} \
+ root=${mmcroot}\0 \
+ loadbootscript= \
+ fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
+ bootscript=echo Running bootscript from mmc ...; \
+ source\0 \
+ loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ mmcboot=echo Booting from mmc ...; \
+ run mmcargs; \
+ bootm\0 \
+ netargs=setenv bootargs console=${console},${baudrate} \
+ root=/dev/nfs \
+ ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
+ netboot=echo Booting from net ...; \
+ run netargs; \
+ dhcp ${uimage}; bootm\0
#define CONFIG_BOOTCOMMAND \
- mmc dev ${mmcdev}; \
- mmc dev ${mmcdev}; if mmc rescan; then \
- if run loadbootscript; then \
- run bootscript; \
- else \
- if run loaduimage; then \
- run mmcboot; \
- else run netboot; \
- fi; \
- fi; \
- else run netboot; fi
+ mmc dev ${mmcdev}; \
+ mmc dev ${mmcdev}; if mmc rescan; then \
+ if run loadbootscript; then \
+ run bootscript; \
+ else \
+ if run loaduimage; then \
+ run mmcboot; \
+ else run netboot; \
+ fi; \
+ fi; \
+ else run netboot; fi
#define CONFIG_ARP_TIMEOUT 200UL
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 2/6] mx28evk: We shouldn't hardcode a rootfs filesystem type
For a generic environment, we shouldn't have a fixed rootfs filesystem
so we drop it from env.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- reformat environment change to fit in 80 cols
include/configs/mx28evk.h |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 8b89b25..ac9522f 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -292,11 +292,9 @@
console_mainline=ttyAMA0\0 \
mmcdev=0\0 \
mmcpart=2\0 \
- mmcroot=/dev/mmcblk0p3 rw\0 \
- mmcrootfstype=ext3 rootwait\0 \
- mmcargs=setenv bootargs console=${console_mainline},${baudrate} \
- root=${mmcroot} \
- rootfstype=${mmcrootfstype}\0 \
+ mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
+ mmcargs=setenv bootargs console=${console_mainline},${baudrate}
+ root=${mmcroot}\0 \
loadbootscript= \
fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
bootscript=echo Running bootscript from mmc ...; \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 3/6] mx28evk: Add support to dynamically choose between ftd use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx28evk.h | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index ac9522f..46442c3 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -290,6 +290,10 @@
uimage=uImage\0 \
console_fsl=ttyAM0\0 \
console_mainline=ttyAMA0\0 \
+ fdt_file=imx28-evk.dtb\0 \
+ fdt_addr=0x4100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
@@ -300,15 +304,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console_mainline},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; if mmc rescan; then \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 4/6] mx53loco: Add support to dynamically choose between ftd use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx53loco.h | 40 ++--
1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index 996396b..27be023 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -119,6 +119,10 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
script=boot.scr\0 \
uimage=uImage\0 \
+ fdt_file=imx53-qsb.dtb\0 \
+ fdt_addr=0x7100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
@@ -128,15 +132,47 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=ttymxc0,${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0 \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo ERROR: Cannot load the DT,
aborting...; \
+ exit; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; if mmc rescan; then \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 5/6] mx6qsabrelite: Add support to dynamically choose between ftd use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx6qsabrelite.h | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
index ee86f9b..fe000d3 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -157,6 +157,10 @@
console=ttymxc1\0 \
fdt_high=0x\0 \
initrd_high=0x\0 \
+ fdt_file=imx6q-sabrelite.dtb\0 \
+ fdt_addr=0x1100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
@@ -167,15 +171,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 6/6] mx6qsabre{auto, sd}: Add support to dynamically choose between ftd use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx6qsabre_common.h | 41 +---
include/configs/mx6qsabreauto.h|1 +
include/configs/mx6qsabresd.h |1 +
3 files changed, 40 insertions(+), 3 deletions(-)
diff --git a/include/configs/mx6qsabre_common.h
b/include/configs/mx6qsabre_common.h
index bd2fb10..f0fb0fd 100644
--- a/include/configs/mx6qsabre_common.h
+++ b/include/configs/mx6qsabre_common.h
@@ -83,6 +83,10 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
script=boot.scr\0 \
uimage=uImage\0 \
+ fdt_file= CONFIG_DEFAULT_FDT_FILE \0 \
+ fdt_addr=0x1100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
console= CONFIG_CONSOLE_DEV \0 \
fdt_high=0x\0 \
initrd_high=0x\0 \
@@ -96,15 +100,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
- mmcboot=echo Booting from mmc ...; \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
+ mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0 \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; \
diff --git a/include/configs/mx6qsabreauto.h b/include/configs/mx6qsabreauto.h
index f1ff201..f4a082a 100644
--- a/include/configs/mx6qsabreauto.h
+++ b/include/configs/mx6qsabreauto.h
@@ -15,6 +15,7 @@
#define CONFIG_MACH_TYPE 3529
#define CONFIG_MXC_UART_BASE UART4_BASE
#define CONFIG_CONSOLE_DEV ttymxc3
+#define CONFIG_DEFAULT_FDT_FILEimx6q-sabreauto.dtb
#define CONFIG_MMCROOT /dev/mmcblk0p2
#define PHYS_SDRAM_SIZE(2u * 1024 * 1024 * 1024)
diff --git a/include/configs/mx6qsabresd.h b/include/configs/mx6qsabresd.h
index a1d9285..b64e925 100644
--- a/include/configs/mx6qsabresd.h
+++ b/include/configs/mx6qsabresd.h
@@ -21,6 +21,7 @@
#define CONFIG_MXC_UART_BASE UART1_BASE
#define CONFIG_CONSOLE_DEV ttymxc0
#define CONFIG_MMCROOT /dev/mmcblk1p2
+#define CONFIG_DEFAULT_FDT_FILEimx6q-sabresd.dtb
#define PHYS_SDRAM_SIZE(1u * 1024 * 1024 * 1024)
#include mx6qsabre_common.h
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] uboot and Ethernet Controller issue
Dear Sandeep C R, In message caex5uh-0brxkhjnu-o7oix9ujqdn1w34o0xnfphrqibxdul...@mail.gmail.com you wrote: The porting was done long back and now linux (2.6.24) also was ported. The observation is still there with the Linux also. Please let me know if it has to do with some configuration of 82551. Sorry, I fail to understand why you are now porting Linux v2.6.24, which is also 5 years old... ... I have developed a PowerPC MPC7410 based processor board with Tsi107 as the Host bridge and intel 82551 the ethernet controller. We have ported u-boot-1.3.1 into it as its boot loader. U-Boot v1.3.1? But this is more than 5 years old!! Why did you chose such a prehistoric version? about 90 minutes everytime. Is it something to do with the config of ethernet controller? Please advice. Please update to current code (like v2013.01-rc2 or so), and try again. As your code is not known tous, it is impossible to even guess what might be the cause. Also, we cannot remember all bugs fixed in U-Boot and Linux for the last 5 years - for example, for U-Boot since v1.3.1 we have added 14238 commits from 727 developers; a total of 1619599 lines has been added, 1030461 removed, and 589138 changed. It would really be best to update and use current code instead. The chances for free community help are very small for 5 year old out-of-tree code. Sorry. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de No journaling file system can recover your data if the disk dies. - Steve Rago in d4cw1p@plc.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 3/6] mx28evk: Add support to dynamically choose between ftd use or not
On Wed, Jan 9, 2013 at 8:20 AM, Otavio Salvador ota...@ossystems.com.br wrote:
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Subject still uses 'ftd'. It is better to make it consistent.
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx28evk.h | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index ac9522f..46442c3 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -290,6 +290,10 @@
uimage=uImage\0 \
console_fsl=ttyAM0\0 \
console_mainline=ttyAMA0\0 \
+ fdt_file=imx28-evk.dtb\0 \
+ fdt_addr=0x4100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
@@ -300,15 +304,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0
\
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
Actually you are not aborting. It was just mmc load that failed, but
tftp will be tried next.
Have all the four combinations below been tested on the hardware?
1. Load a dt kernel from mmc
2. Load a non-dt kernel from mmc
3. Load a dt kernel from tftp
4. Load a non-dt kernel from tftp
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 3/6] mx28evk: Add support to dynamically choose between ftd use or not
On Wed, Jan 9, 2013 at 9:29 AM, Fabio Estevam feste...@gmail.com wrote:
On Wed, Jan 9, 2013 at 8:20 AM, Otavio Salvador ota...@ossystems.com.br
wrote:
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Subject still uses 'ftd'. It is better to make it consistent.
Will send v5...
...
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT,
aborting...; \
Actually you are not aborting. It was just mmc load that failed, but
tftp will be tried next.
Yes; I removed the aborting for v5
Have all the four combinations below been tested on the hardware?
1. Load a dt kernel from mmc
2. Load a non-dt kernel from mmc
3. Load a dt kernel from tftp
4. Load a non-dt kernel from tftp
Stefano has helped testing it :-)
--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 0/6] Improve default environment for easy use
This patchset improves the default environment of machines currently
supported in OpenEmbedded and Yocto to make it compatible with
mainline and Freescale BSP Linux kernel.
A new patch has been add to change the format in mx6qsabrelite in
environment setting and already merged patches removed from this new
pull request.
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- New patch
- reformat environment change to fit in 80 cols
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
Otavio Salvador (6):
mx6qsabrelite: Use tabs to environment setting
mx28evk: We shouldn't hardcode a rootfs filesystem type
mx28evk: Add support to dynamically choose between fdt use or not
mx53loco: Add support to dynamically choose between fdt use or not
mx6qsabrelite: Add support to dynamically choose between fdt use or
not
mx6qsabre{auto,sd}: Add support to dynamically choose between fdt use
or not
include/configs/mx28evk.h | 47 ++---
include/configs/mx53loco.h | 40 +-
include/configs/mx6qsabre_common.h | 41 +--
include/configs/mx6qsabreauto.h|1 +
include/configs/mx6qsabrelite.h| 101
include/configs/mx6qsabresd.h |1 +
6 files changed, 186 insertions(+), 45 deletions(-)
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 1/6] mx6qsabrelite: Use tabs to environment setting
This rework the environment to use tabs for environment setting as
done in other boards.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2:
- New patch
include/configs/mx6qsabrelite.h | 66 +++
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
index 0f6bbb4..ee86f9b 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -152,43 +152,43 @@
#define CONFIG_SYS_TEXT_BASE 0x1780
#define CONFIG_EXTRA_ENV_SETTINGS \
- script=boot.scr\0 \
- uimage=uImage\0 \
+ script=boot.scr\0 \
+ uimage=uImage\0 \
console=ttymxc1\0 \
- fdt_high=0x\0 \
+ fdt_high=0x\0 \
initrd_high=0x\0 \
- mmcdev=0\0 \
- mmcpart=2\0 \
- mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
- mmcargs=setenv bootargs console=${console},${baudrate} \
- root=${mmcroot}\0 \
- loadbootscript= \
- fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
- bootscript=echo Running bootscript from mmc ...; \
- source\0 \
- loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
- mmcboot=echo Booting from mmc ...; \
- run mmcargs; \
- bootm\0 \
- netargs=setenv bootargs console=${console},${baudrate} \
- root=/dev/nfs \
- ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
- netboot=echo Booting from net ...; \
- run netargs; \
- dhcp ${uimage}; bootm\0 \
+ mmcdev=0\0 \
+ mmcpart=2\0 \
+ mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
+ mmcargs=setenv bootargs console=${console},${baudrate} \
+ root=${mmcroot}\0 \
+ loadbootscript= \
+ fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
+ bootscript=echo Running bootscript from mmc ...; \
+ source\0 \
+ loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ mmcboot=echo Booting from mmc ...; \
+ run mmcargs; \
+ bootm\0 \
+ netargs=setenv bootargs console=${console},${baudrate} \
+ root=/dev/nfs \
+ ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
+ netboot=echo Booting from net ...; \
+ run netargs; \
+ dhcp ${uimage}; bootm\0
#define CONFIG_BOOTCOMMAND \
- mmc dev ${mmcdev}; \
- mmc dev ${mmcdev}; if mmc rescan; then \
- if run loadbootscript; then \
- run bootscript; \
- else \
- if run loaduimage; then \
- run mmcboot; \
- else run netboot; \
- fi; \
- fi; \
- else run netboot; fi
+ mmc dev ${mmcdev}; \
+ mmc dev ${mmcdev}; if mmc rescan; then \
+ if run loadbootscript; then \
+ run bootscript; \
+ else \
+ if run loaduimage; then \
+ run mmcboot; \
+ else run netboot; \
+ fi; \
+ fi; \
+ else run netboot; fi
#define CONFIG_ARP_TIMEOUT 200UL
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 2/6] mx28evk: We shouldn't hardcode a rootfs filesystem type
For a generic environment, we shouldn't have a fixed rootfs filesystem
so we drop it from env.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2:
- reformat environment change to fit in 80 cols
include/configs/mx28evk.h |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 8b89b25..ac9522f 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -292,11 +292,9 @@
console_mainline=ttyAMA0\0 \
mmcdev=0\0 \
mmcpart=2\0 \
- mmcroot=/dev/mmcblk0p3 rw\0 \
- mmcrootfstype=ext3 rootwait\0 \
- mmcargs=setenv bootargs console=${console_mainline},${baudrate} \
- root=${mmcroot} \
- rootfstype=${mmcrootfstype}\0 \
+ mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
+ mmcargs=setenv bootargs console=${console_mainline},${baudrate}
+ root=${mmcroot}\0 \
loadbootscript= \
fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
bootscript=echo Running bootscript from mmc ...; \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 3/6] mx28evk: Add support to dynamically choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx28evk.h | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index ac9522f..4a95156 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -290,6 +290,10 @@
uimage=uImage\0 \
console_fsl=ttyAM0\0 \
console_mainline=ttyAMA0\0 \
+ fdt_file=imx28-evk.dtb\0 \
+ fdt_addr=0x4100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
@@ -300,15 +304,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console_mainline},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; if mmc rescan; then \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 5/6] mx6qsabrelite: Add support to dynamically choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx6qsabrelite.h | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
index ee86f9b..fbcab2f 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -157,6 +157,10 @@
console=ttymxc1\0 \
fdt_high=0x\0 \
initrd_high=0x\0 \
+ fdt_file=imx6q-sabrelite.dtb\0 \
+ fdt_addr=0x1100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
@@ -167,15 +171,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 6/6] mx6qsabre{auto, sd}: Add support to dynamically choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx6qsabre_common.h | 41 +---
include/configs/mx6qsabreauto.h|1 +
include/configs/mx6qsabresd.h |1 +
3 files changed, 40 insertions(+), 3 deletions(-)
diff --git a/include/configs/mx6qsabre_common.h
b/include/configs/mx6qsabre_common.h
index bd2fb10..0f0e51f 100644
--- a/include/configs/mx6qsabre_common.h
+++ b/include/configs/mx6qsabre_common.h
@@ -83,6 +83,10 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
script=boot.scr\0 \
uimage=uImage\0 \
+ fdt_file= CONFIG_DEFAULT_FDT_FILE \0 \
+ fdt_addr=0x1100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
console= CONFIG_CONSOLE_DEV \0 \
fdt_high=0x\0 \
initrd_high=0x\0 \
@@ -96,15 +100,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
- mmcboot=echo Booting from mmc ...; \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
+ mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0 \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; \
diff --git a/include/configs/mx6qsabreauto.h b/include/configs/mx6qsabreauto.h
index f1ff201..f4a082a 100644
--- a/include/configs/mx6qsabreauto.h
+++ b/include/configs/mx6qsabreauto.h
@@ -15,6 +15,7 @@
#define CONFIG_MACH_TYPE 3529
#define CONFIG_MXC_UART_BASE UART4_BASE
#define CONFIG_CONSOLE_DEV ttymxc3
+#define CONFIG_DEFAULT_FDT_FILEimx6q-sabreauto.dtb
#define CONFIG_MMCROOT /dev/mmcblk0p2
#define PHYS_SDRAM_SIZE(2u * 1024 * 1024 * 1024)
diff --git a/include/configs/mx6qsabresd.h b/include/configs/mx6qsabresd.h
index a1d9285..b64e925 100644
--- a/include/configs/mx6qsabresd.h
+++ b/include/configs/mx6qsabresd.h
@@ -21,6 +21,7 @@
#define CONFIG_MXC_UART_BASE UART1_BASE
#define CONFIG_CONSOLE_DEV ttymxc0
#define CONFIG_MMCROOT /dev/mmcblk1p2
+#define CONFIG_DEFAULT_FDT_FILEimx6q-sabresd.dtb
#define PHYS_SDRAM_SIZE(1u * 1024 * 1024 * 1024)
#include mx6qsabre_common.h
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 4/6] mx53loco: Add support to dynamically choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx53loco.h | 40 ++--
1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index 996396b..cbc3a82 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -119,6 +119,10 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
script=boot.scr\0 \
uimage=uImage\0 \
+ fdt_file=imx53-qsb.dtb\0 \
+ fdt_addr=0x7100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rw rootwait\0 \
@@ -128,15 +132,47 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=ttymxc0,${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0 \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo ERROR: Cannot load the DT; \
+ exit; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; if mmc rescan; then \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 4/6] mx53loco: Add support to dynamically choose between fdt use or not
-Original Message-
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Otavio Salvador
Sent: Wednesday, January 09, 2013 7:58 PM
To: U-Boot Mailing List
Cc: Estevam Fabio-R49496; Otavio Salvador
Subject: [U-Boot] [PATCH v5 4/6] mx53loco: Add support to dynamically
choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx53loco.h | 40
++--
1 file changed, 38 insertions(+), 2 deletions(-)
Acked-by: Jason Liu r64...@freescale.com
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h index
996396b..cbc3a82 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -119,6 +119,10 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
script=boot.scr\0 \
uimage=uImage\0 \
+ fdt_file=imx53-qsb.dtb\0 \
+ fdt_addr=0x7100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rw rootwait\0 \ @@ -128,15 +132,47
@@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}
${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=ttymxc0,${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0 \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo ERROR: Cannot load the DT; \
+ exit; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; if mmc rescan; then \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 1/6] mx6qsabrelite: Use tabs to environment setting
-Original Message-
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Otavio Salvador
Sent: Wednesday, January 09, 2013 7:58 PM
To: U-Boot Mailing List
Cc: Estevam Fabio-R49496; Otavio Salvador
Subject: [U-Boot] [PATCH v5 1/6] mx6qsabrelite: Use tabs to environment
setting
This rework the environment to use tabs for environment setting as done in
other boards.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2:
- New patch
include/configs/mx6qsabrelite.h | 66 +++
1 file changed, 33 insertions(+), 33 deletions(-)
Acked-by: Jason Liu r64...@freescale.com
diff --git a/include/configs/mx6qsabrelite.h
b/include/configs/mx6qsabrelite.h index 0f6bbb4..ee86f9b 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -152,43 +152,43 @@
#define CONFIG_SYS_TEXT_BASE 0x1780
#define CONFIG_EXTRA_ENV_SETTINGS \
- script=boot.scr\0 \
- uimage=uImage\0 \
+ script=boot.scr\0 \
+ uimage=uImage\0 \
console=ttymxc1\0 \
- fdt_high=0x\0 \
+ fdt_high=0x\0 \
initrd_high=0x\0 \
- mmcdev=0\0 \
- mmcpart=2\0 \
- mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
- mmcargs=setenv bootargs console=${console},${baudrate} \
- root=${mmcroot}\0 \
- loadbootscript= \
- fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
- bootscript=echo Running bootscript from mmc ...; \
- source\0 \
- loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${uimage}\0 \
- mmcboot=echo Booting from mmc ...; \
- run mmcargs; \
- bootm\0 \
- netargs=setenv bootargs console=${console},${baudrate} \
- root=/dev/nfs \
- ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
- netboot=echo Booting from net ...; \
- run netargs; \
- dhcp ${uimage}; bootm\0 \
+ mmcdev=0\0 \
+ mmcpart=2\0 \
+ mmcroot=/dev/mmcblk0p3 rootwait rw\0 \
+ mmcargs=setenv bootargs console=${console},${baudrate} \
+ root=${mmcroot}\0 \
+ loadbootscript= \
+ fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0
\
+ bootscript=echo Running bootscript from mmc ...; \
+ source\0 \
+ loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${uimage}\0 \
+ mmcboot=echo Booting from mmc ...; \
+ run mmcargs; \
+ bootm\0 \
+ netargs=setenv bootargs console=${console},${baudrate} \
+ root=/dev/nfs \
+ ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
+ netboot=echo Booting from net ...; \
+ run netargs; \
+ dhcp ${uimage}; bootm\0
#define CONFIG_BOOTCOMMAND \
- mmc dev ${mmcdev}; \
- mmc dev ${mmcdev}; if mmc rescan; then \
- if run loadbootscript; then \
- run bootscript; \
- else \
- if run loaduimage; then \
- run mmcboot; \
- else run netboot; \
- fi; \
- fi; \
- else run netboot; fi
+ mmc dev ${mmcdev}; \
+ mmc dev ${mmcdev}; if mmc rescan; then \
+ if run loadbootscript; then \
+ run bootscript; \
+ else \
+ if run loaduimage; then \
+ run mmcboot; \
+ else run netboot; \
+ fi; \
+ fi; \
+ else run netboot; fi
#define CONFIG_ARP_TIMEOUT 200UL
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 6/6] mx6qsabre{auto, sd}: Add support to dynamically choose between fdt use or not
-Original Message-
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Otavio Salvador
Sent: Wednesday, January 09, 2013 7:58 PM
To: U-Boot Mailing List
Cc: Estevam Fabio-R49496; Otavio Salvador
Subject: [U-Boot] [PATCH v5 6/6] mx6qsabre{auto, sd}: Add support to
dynamically choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx6qsabre_common.h | 41
+---
Acked-by: Jason Liu r64...@freescale.com
include/configs/mx6qsabreauto.h|1 +
include/configs/mx6qsabresd.h |1 +
3 files changed, 40 insertions(+), 3 deletions(-)
diff --git a/include/configs/mx6qsabre_common.h
b/include/configs/mx6qsabre_common.h
index bd2fb10..0f0e51f 100644
--- a/include/configs/mx6qsabre_common.h
+++ b/include/configs/mx6qsabre_common.h
@@ -83,6 +83,10 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
script=boot.scr\0 \
uimage=uImage\0 \
+ fdt_file= CONFIG_DEFAULT_FDT_FILE \0 \
+ fdt_addr=0x1100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
console= CONFIG_CONSOLE_DEV \0 \
fdt_high=0x\0 \
initrd_high=0x\0 \
@@ -96,15 +100,46 @@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${uimage}\0 \
- mmcboot=echo Booting from mmc ...; \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}
${fdt_file}\0 \
+ mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0 \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; \
diff --git a/include/configs/mx6qsabreauto.h
b/include/configs/mx6qsabreauto.h index f1ff201..f4a082a 100644
--- a/include/configs/mx6qsabreauto.h
+++ b/include/configs/mx6qsabreauto.h
@@ -15,6 +15,7 @@
#define CONFIG_MACH_TYPE 3529
#define CONFIG_MXC_UART_BASE UART4_BASE
#define CONFIG_CONSOLE_DEVttymxc3
+#define CONFIG_DEFAULT_FDT_FILE imx6q-sabreauto.dtb
#define CONFIG_MMCROOT/dev/mmcblk0p2
#define PHYS_SDRAM_SIZE (2u * 1024 * 1024 * 1024)
diff --git a/include/configs/mx6qsabresd.h b/include/configs/mx6qsabresd.h
index a1d9285..b64e925 100644
--- a/include/configs/mx6qsabresd.h
+++ b/include/configs/mx6qsabresd.h
@@ -21,6 +21,7 @@
#define CONFIG_MXC_UART_BASE UART1_BASE
#define CONFIG_CONSOLE_DEVttymxc0
#define CONFIG_MMCROOT/dev/mmcblk1p2
+#define CONFIG_DEFAULT_FDT_FILE imx6q-sabresd.dtb
#define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024)
#include mx6qsabre_common.h
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
Re: [U-Boot] [PATCH v5 5/6] mx6qsabrelite: Add support to dynamically choose between fdt use or not
-Original Message-
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Otavio Salvador
Sent: Wednesday, January 09, 2013 7:58 PM
To: U-Boot Mailing List
Cc: Estevam Fabio-R49496; Otavio Salvador
Subject: [U-Boot] [PATCH v5 5/6] mx6qsabrelite: Add support to dynamically
choose between fdt use or not
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
include/configs/mx6qsabrelite.h | 39
+--
1 file changed, 37 insertions(+), 2 deletions(-)
Acked-by: Jason Liu r64...@freescale.com
diff --git a/include/configs/mx6qsabrelite.h
b/include/configs/mx6qsabrelite.h index ee86f9b..fbcab2f 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -157,6 +157,10 @@
console=ttymxc1\0 \
fdt_high=0x\0 \
initrd_high=0x\0 \
+ fdt_file=imx6q-sabrelite.dtb\0 \
+ fdt_addr=0x1100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
mmcdev=0\0 \
mmcpart=2\0 \
mmcroot=/dev/mmcblk0p3 rootwait rw\0 \ @@ -167,15 +171,46
@@
bootscript=echo Running bootscript from mmc ...; \
source\0 \
loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}
${fdt_file}\0 \
mmcboot=echo Booting from mmc ...; \
run mmcargs; \
- bootm\0 \
+ if test ${boot_fdt} = yes; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
netargs=setenv bootargs console=${console},${baudrate} \
root=/dev/nfs \
ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
netboot=echo Booting from net ...; \
run netargs; \
- dhcp ${uimage}; bootm\0
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
#define CONFIG_BOOTCOMMAND \
mmc dev ${mmcdev}; \
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
On Tue, Jan 08, 2013 at 11:57:20PM +0100, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- drivers/mtd/nand/Makefile |4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 2c3812c..c77c0c4 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -79,6 +79,10 @@ COBJS-$(CONFIG_TEGRA_NAND) += tegra_nand.o COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o COBJS-$(CONFIG_NAND_PLAT) += nand_plat.o +else # minimal SPL drivers + +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o + endif # drivers endif # nand Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x
Hello Wolfgang,
thank you for your fast review!
On Tuesday 08 January 2013 at 19:58:37, Wolfgang Denk wrote:
+/* DDR RAM defines */
+#define DDR_CLK_MHZ303
Is this really correct? 303 ??
I am quite sure, I read this in a datasheet, but I can not find it anymore. I
set this to 333 now. mtest still works.
...
Do you plan to use this? Otherwise please just omit such dead code.
+#ifdef CONFIG_DRIVER_TI_CPSW
+static void cpsw_control(int enabled)
+{
+ /* VTP can be added here */
+
+ return;
+}
Ditto...
The cpsw driver needs a control function, otherwise the board crashes when
network initializes. On my board this is empty like on am335x_evm.
+#define CONFIG_ENV_OVERWRITE 1
Please do not define values for logical variables like this one;
please fix globally.
Fix globally ? Do you mean, I have to fix that for EVERY board that is in u-
boot, that defines CONFIG_ENV_OVERWRITE with a value to get my patch in?
There are a number of boards doing this wrong!
+#define CONFIG_ENV_IS_NOWHERE
Really?
Uuhm. Yes. At the moment I use this uEnv.txt file on sd-card, as I am not
able to use the NAND yet. The env should go to nand later.
Thanks for the other hints you gave. I will address this and send a version 2
soon.
Regards,
Lars
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: u-boot-arm/master
Hello Tom, The following changes since commit 7528cf5f016b5b8b8b12b373f6f31a10bf89233d: Merge branch 'u-boot-imx/master' into 'u-boot-arm/master' (2013-01-08 14:59:37 +0100) are available in the git repository at: git://git.denx.de/u-boot-arm.git master for you to fetch changes up to 61bdb9133593f0f881a57232039296f64bd662ed: arm: remove useless code in start.S files (2013-01-08 22:14:54 +0100) Albert ARIBAUD (2): arm: move C runtime setup code in crt0.S arm: remove useless code in start.S files arch/arm/cpu/arm1136/start.S | 71 +++- arch/arm/cpu/arm1176/start.S | 62 ++- arch/arm/cpu/arm720t/start.S | 53 ++--- arch/arm/cpu/arm920t/start.S | 61 ++ arch/arm/cpu/arm925t/start.S | 65 ++- arch/arm/cpu/arm926ejs/start.S| 86 ++ arch/arm/cpu/arm946es/start.S | 56 ++ arch/arm/cpu/arm_intcm/start.S| 63 ++- arch/arm/cpu/armv7/start.S| 58 +++--- arch/arm/cpu/ixp/start.S | 55 ++--- arch/arm/cpu/pxa/start.S | 63 ++- arch/arm/cpu/s3c44b0/start.S | 55 ++--- arch/arm/cpu/sa1100/start.S | 50 ++--- arch/arm/lib/Makefile |2 + arch/arm/lib/board.c | 11 -- arch/arm/lib/crt0.S | 173 + include/common.h |2 +- include/configs/socfpga_cyclone5.h|2 +- lib/asm-offsets.c | 14 +++ nand_spl/board/freescale/mx31pdk/Makefile |6 +- nand_spl/board/karo/tx25/Makefile |6 +- 21 files changed, 326 insertions(+), 688 deletions(-) create mode 100644 arch/arm/lib/crt0.S Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mx51evk: Let Add DVI output support
Add DVI output support and make it the default video output.
Currently the CLAA WVGA panel is supported, but this panel has to be purchased
separately, so using the DVI output as the default would allow more people to
try the splash screen feature on a mx51evk.
If someone still wants to use the CLAA WVGA, just set the panel variable as:
set panel claa
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
board/freescale/mx51evk/mx51evk.c |2 --
board/freescale/mx51evk/mx51evk_video.c | 39 ---
2 files changed, 36 insertions(+), 5 deletions(-)
diff --git a/board/freescale/mx51evk/mx51evk.c
b/board/freescale/mx51evk/mx51evk.c
index d1ef431..54c16b1 100644
--- a/board/freescale/mx51evk/mx51evk.c
+++ b/board/freescale/mx51evk/mx51evk.c
@@ -489,8 +489,6 @@ int board_init(void)
/* address of boot parameters */
gd-bd-bi_boot_params = PHYS_SDRAM_1 + 0x100;
- lcd_enable();
-
return 0;
}
diff --git a/board/freescale/mx51evk/mx51evk_video.c
b/board/freescale/mx51evk/mx51evk_video.c
index f036cf7..1583131 100644
--- a/board/freescale/mx51evk/mx51evk_video.c
+++ b/board/freescale/mx51evk/mx51evk_video.c
@@ -48,6 +48,22 @@ static struct fb_videomode const claa_wvga = {
.vmode = FB_VMODE_NONINTERLACED
};
+static struct fb_videomode const dvi = {
+ .name = DVI panel,
+ .refresh= 60,
+ .xres = 1024,
+ .yres = 768,
+ .pixclock = 15385,
+ .left_margin= 220,
+ .right_margin = 40,
+ .upper_margin = 21,
+ .lower_margin = 7,
+ .hsync_len = 60,
+ .vsync_len = 10,
+ .sync = 0,
+ .vmode = FB_VMODE_NONINTERLACED
+};
+
void setup_iomux_lcd(void)
{
/* DI2_PIN15 */
@@ -73,9 +89,26 @@ void setup_iomux_lcd(void)
gpio_direction_output(MX51EVK_LCD_BACKLIGHT, 1);
}
-void lcd_enable(void)
+int board_video_skip(void)
{
- int ret = ipuv3_fb_init(claa_wvga, 1, IPU_PIX_FMT_RGB565);
+ int ret;
+ char const *e = getenv(panel);
+
+ if (e) {
+ if (strcmp(e, claa) == 0) {
+ ret = ipuv3_fb_init(claa_wvga, 1, IPU_PIX_FMT_RGB565);
+ if (ret)
+ printf(claa cannot be configured: %d\n, ret);
+ return ret;
+ }
+ }
+
+ /*
+* 'panel' env variable not found or has different value than 'claa'
+* Defaulting to dvi output.
+*/
+ ret = ipuv3_fb_init(dvi, 0, IPU_PIX_FMT_RGB24);
if (ret)
- printf(LCD cannot be configured: %d\n, ret);
+ printf(dvi cannot be configured: %d\n, ret);
+ return ret;
}
--
1.7.9.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] mx51evk: Add DVI output support
Add DVI output support and make it the default video output.
Currently the CLAA WVGA panel is supported, but this panel has to be purchased
separately, so using the DVI output as the default would allow more people to
try the splash screen feature on a mx51evk.
If someone still wants to use the CLAA WVGA, just set the panel variable as:
set panel claa
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
Changes since v1:
- Remove 'Let' from the Subject
board/freescale/mx51evk/mx51evk.c |2 --
board/freescale/mx51evk/mx51evk_video.c | 39 ---
2 files changed, 36 insertions(+), 5 deletions(-)
diff --git a/board/freescale/mx51evk/mx51evk.c
b/board/freescale/mx51evk/mx51evk.c
index d1ef431..54c16b1 100644
--- a/board/freescale/mx51evk/mx51evk.c
+++ b/board/freescale/mx51evk/mx51evk.c
@@ -489,8 +489,6 @@ int board_init(void)
/* address of boot parameters */
gd-bd-bi_boot_params = PHYS_SDRAM_1 + 0x100;
- lcd_enable();
-
return 0;
}
diff --git a/board/freescale/mx51evk/mx51evk_video.c
b/board/freescale/mx51evk/mx51evk_video.c
index f036cf7..1583131 100644
--- a/board/freescale/mx51evk/mx51evk_video.c
+++ b/board/freescale/mx51evk/mx51evk_video.c
@@ -48,6 +48,22 @@ static struct fb_videomode const claa_wvga = {
.vmode = FB_VMODE_NONINTERLACED
};
+static struct fb_videomode const dvi = {
+ .name = DVI panel,
+ .refresh= 60,
+ .xres = 1024,
+ .yres = 768,
+ .pixclock = 15385,
+ .left_margin= 220,
+ .right_margin = 40,
+ .upper_margin = 21,
+ .lower_margin = 7,
+ .hsync_len = 60,
+ .vsync_len = 10,
+ .sync = 0,
+ .vmode = FB_VMODE_NONINTERLACED
+};
+
void setup_iomux_lcd(void)
{
/* DI2_PIN15 */
@@ -73,9 +89,26 @@ void setup_iomux_lcd(void)
gpio_direction_output(MX51EVK_LCD_BACKLIGHT, 1);
}
-void lcd_enable(void)
+int board_video_skip(void)
{
- int ret = ipuv3_fb_init(claa_wvga, 1, IPU_PIX_FMT_RGB565);
+ int ret;
+ char const *e = getenv(panel);
+
+ if (e) {
+ if (strcmp(e, claa) == 0) {
+ ret = ipuv3_fb_init(claa_wvga, 1, IPU_PIX_FMT_RGB565);
+ if (ret)
+ printf(claa cannot be configured: %d\n, ret);
+ return ret;
+ }
+ }
+
+ /*
+* 'panel' env variable not found or has different value than 'claa'
+* Defaulting to dvi output.
+*/
+ ret = ipuv3_fb_init(dvi, 0, IPU_PIX_FMT_RGB24);
if (ret)
- printf(LCD cannot be configured: %d\n, ret);
+ printf(dvi cannot be configured: %d\n, ret);
+ return ret;
}
--
1.7.9.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] mx53loco: Add support for SEIKO 4.3'' WVGA panel
Add support for the Seiko 4.3'' WVGA panel on mx53loco.
By default, the CLAA WVGA panel is selected.
In order to support the Seiko panel, the enviroment variable 'panel' must be
set to 'seiko'.
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
Changes since v2:
- Simplify lcd detection logic
Changes since v1:
- Allow a single binary to support both CLAA and Seiko panels
board/freescale/mx53loco/mx53loco.c |2 --
board/freescale/mx53loco/mx53loco_video.c | 38 ++---
2 files changed, 35 insertions(+), 5 deletions(-)
diff --git a/board/freescale/mx53loco/mx53loco.c
b/board/freescale/mx53loco/mx53loco.c
index 60cd4f0..8f39c38 100644
--- a/board/freescale/mx53loco/mx53loco.c
+++ b/board/freescale/mx53loco/mx53loco.c
@@ -503,8 +503,6 @@ int board_init(void)
mxc_set_sata_internal_clock();
setup_iomux_i2c();
- lcd_enable();
-
return 0;
}
diff --git a/board/freescale/mx53loco/mx53loco_video.c
b/board/freescale/mx53loco/mx53loco_video.c
index 69991e8..a4d5a6a 100644
--- a/board/freescale/mx53loco/mx53loco_video.c
+++ b/board/freescale/mx53loco/mx53loco_video.c
@@ -46,6 +46,21 @@ static struct fb_videomode const claa_wvga = {
.vmode = FB_VMODE_NONINTERLACED
};
+static struct fb_videomode const seiko_wvga = {
+ .name = Seiko-43WVF1G,
+ .refresh= 60,
+ .xres = 800,
+ .yres = 480,
+ .pixclock = 29851, /* picosecond (33.5 MHz) */
+ .left_margin= 89,
+ .right_margin = 164,
+ .upper_margin = 23,
+ .lower_margin = 10,
+ .hsync_len = 10,
+ .vsync_len = 10,
+ .sync = 0,
+};
+
void setup_iomux_lcd(void)
{
mxc_request_iomux(MX53_PIN_DI0_DISP_CLK, IOMUX_CONFIG_ALT0);
@@ -86,9 +101,26 @@ void setup_iomux_lcd(void)
gpio_direction_output(IOMUX_TO_GPIO(MX53_PIN_GPIO_1), 1);
}
-void lcd_enable(void)
+int board_video_skip(void)
{
- int ret = ipuv3_fb_init(claa_wvga, 0, IPU_PIX_FMT_RGB565);
+ int ret;
+ char const *e = getenv(panel);
+
+ if (e) {
+ if (strcmp(e, seiko) == 0) {
+ ret = ipuv3_fb_init(seiko_wvga, 0, IPU_PIX_FMT_RGB24);
+ if (ret)
+ printf(Seiko cannot be configured: %d\n, ret);
+ return ret;
+ }
+ }
+
+ /*
+* 'panel' env variable not found or has different value than 'seiko'
+* Defaulting to claa lcd.
+*/
+ ret = ipuv3_fb_init(claa_wvga, 0, IPU_PIX_FMT_RGB565);
if (ret)
- printf(LCD cannot be configured: %d\n, ret);
+ printf(CLAA cannot be configured: %d\n, ret);
+ return ret;
}
--
1.7.9.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: at91sam9x5: add dataflash boot support
Dear Bo Shen, Albert Aribaud agreed to apply this one to u-boot-arm/master for the upcoming release. On 07.12.2012 08:37, Bo Shen wrote: Add dataflash boot support on at91sam9x5ek board Signed-off-by: Bo Shen voice.s...@atmel.com Acked-by: Andreas Bießmann andreas.de...@googlemail.com --- boards.cfg |1 + include/configs/at91sam9x5ek.h | 10 ++ 2 files changed, 11 insertions(+) Best regards Andreas Bießmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] drivers/block/systemace - added missing else in ace_writew
2013/1/3 Alexey Brodkin alexey.brod...@gmail.com: System ACE compact flash controller supports either 8-bit (default) or 16-bit data transfers. And in corresponding driver we need to implement read/write of 16-bit data words properly for both modes of operation. In existing code if width==8 both branches get executed which may cause unexpected behavior of SystemAce controller. Addition of else fixes described issue and execution is done as expected for both (8-bit and 16-bit) data bus widths. Signed-off-by: Alexey Brodkin alexey.brod...@gmail.com Acked-by: Michal Simek mon...@monstr.eu Tom: Can you please add this patch to your tree? This is bug fixes which should go to 2013.01. If you want to me to add this single patch to my tree and ask for request please let me know. Just easier to apply it directly. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra30: fix UART2 pinmux table entry
On Tue, Jan 08, 2013 at 07:46:03PM -0800, Stephen Warren wrote: On 01/08/2013 06:23 PM, Allen Martin wrote: UART2_TXD and UART2_RXD mux 0 SFIO entries should be IRDA not UARTB. IRDA is just a needlessly different synonym for UARTB; there shouldn't be any mention of IRDA in the pinmux code anywhere, or any users of the pinmux code. Oh suck, I didn't realize we had synonyms in the pinmux tables, that seems like a really bad idea. Unfortunately it looks like this particular synonym is widespread. I see it used in the pinmux spreadsheets, the downstream Android kernel source, and gfshell code. The bug I was trying to fix here is that IRDA is referenced in the u-boot cardhu pinmux table. I guess the fix is to change that to UARTB, but it sounds like maybe a larger synonym cleanup is needed everywhere, do you know of any others? I'm thinking there needs to be some better run time error checking in the u-boot pinmux code too. There are some debug asserts in there now, but because I didn't have debug turned on this particular bug lead to silent corruption of the pinmux registers which was a PITA to track down. Thoughts on turning those asserts into always on error checking code? Not sure how much it will slow down pinmux programming. -Allen -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] tegra30: cardhu: fix UART2 pinmux settings
Use UARTB instead of IRDA synonym for cardhu pinmux settings to match
tegra30 pinmux tables.
Signed-off-by: Allen Martin amar...@nvidia.com
---
board/nvidia/cardhu/pinmux-config-cardhu.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/nvidia/cardhu/pinmux-config-cardhu.h
b/board/nvidia/cardhu/pinmux-config-cardhu.h
index 3162219..8428bba 100644
--- a/board/nvidia/cardhu/pinmux-config-cardhu.h
+++ b/board/nvidia/cardhu/pinmux-config-cardhu.h
@@ -176,8 +176,8 @@ static struct pingroup_config tegra3_pinmux_common[] = {
LV_PINMUX(VI_D7, SDMMC2, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
LV_PINMUX(VI_D10, RSVD1, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
LV_PINMUX(VI_MCLK, VI, UP, NORMAL, INPUT, DISABLE, DISABLE),
- DEFAULT_PINMUX(UART2_RXD, IRDA, NORMAL, NORMAL, INPUT),
- DEFAULT_PINMUX(UART2_TXD, IRDA, NORMAL, NORMAL, OUTPUT),
+ DEFAULT_PINMUX(UART2_RXD, UARTB, NORMAL, NORMAL, INPUT),
+ DEFAULT_PINMUX(UART2_TXD, UARTB, NORMAL, NORMAL, OUTPUT),
DEFAULT_PINMUX(UART2_RTS_N, UARTB, NORMAL, NORMAL, OUTPUT),
DEFAULT_PINMUX(UART2_CTS_N, UARTB, NORMAL, NORMAL, INPUT),
DEFAULT_PINMUX(UART3_TXD, UARTC, NORMAL, NORMAL, OUTPUT),
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 4/6] mx53loco: Add support to dynamically choose between fdt use or not
On 09/01/2013 12:57, Otavio Salvador wrote:
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Hi Otavio,
Changes in v5:
- Change subject
- Reword the warning
Changes in v4:
- Use a warning, instead of error when failing to fetch fdt
- Drop exit use
- Fix netboot
- Use fdt instead of ftd
Changes in v3:
- Add loadfdt
- Use loadfdt
- Call exit to abort script
Changes in v2:
- Allow use of dynamic/static ip
- Allow force use, or not, of fdt
- Change 'auto' to 'try'
I get some problems:
- loadbootscript is not correctly set. In fact:
env default -f -a
## Resetting to default environment
MX53LOCO U-Boot pri mmcargs
mmcargs=setenv bootargs console=ttymxc0,${baudrate} root=${mmcroot}
loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};
There is still a '0' missing for mmcargs, and loadbootscript is not set.
Then there is a problem with netboot. It is set correctly, but pri
netboot crashes:
pri netboot
netboot=echo Booting from net ...; run netargs; if test ${ip_dyn} = yes;
then setenv get_cmd dhcp; else setenv get_cmd tftp; fi; ${get_cmd}
${uimage}; if test ${boot_fdt} = yes; then if ${get_cmd} ${fdt_addr}
${fdt_file}; then bootm ${loadaddr} - ${fdt_addr}; else if test
${boot_fdt} = try; then bootm; else echo ERROR: Cannot load the DT;
exit; fi; fi; else bootm; fi;
prefetch abort
pc : [203b6d78] lr : [203b6d74]
sp : af565e00 ip : fp :
r10: 0002 r9 : r8 : af565f58
r7 : af568c7c r6 : 0001 r5 : r4 : 6f6f6220
r3 : 0083 r2 : 0060 r1 : af565cc0 r0 : 0173
Flags: nZCv IRQs off FIQs off Mode SVC_32
Resetting CPU ...
Then I do not understand the boot_fdt when set to try. I have imagined
that it tries to start a DT kernel, and if no fdt find is found, it
tries with a legacy kernel without fdt. But it does not try to load the
FDT file, because this is done only when boot_fdt = yes. When boot_fdt =
try, it starts always a legacy kernel.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] mx6: Add workaround for ARM errata
On 05/01/2013 03:07, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Add workaround for the following ARM errata: 743622 and 751472. The motivation for this change is the following kernel commit 62e4d357a (ARM: 7609/1: disable errata work-arounds which access secure registers), which removes the errata from multiplatform kernel. Since imx has been converted to multiplatform in the kernel, we need to apply such workarounds into the bootloader. Workaround code has been taken from arch/arm/mm/proc-v7.S from 3.7.1 kernel. Explanation of each erratum is provided at Chip Errata for the i.MX 6Dual/6Quad document available at: cache.freescale.com/files/32bit/doc/errata/IMX6DQCE.pdf Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Following patch has been proposed into arm kernel mailing list: http://www.spinics.net/lists/arm-kernel/msg214840.html Changes since v2: - Use c15 register (which match both the mx6 errata and kernel code) and also put a note to mx6q erratum document. Changes since v1: - Use the same style of the erratum in arch/arm/cpu/armv7/mx5/lowlevel_init.S. Applied to u-boot-imx (fix), thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] mx53loco: Add support for SEIKO 4.3'' WVGA panel
On 09/01/2013 16:10, Fabio Estevam wrote: Add support for the Seiko 4.3'' WVGA panel on mx53loco. By default, the CLAA WVGA panel is selected. In order to support the Seiko panel, the enviroment variable 'panel' must be set to 'seiko'. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra30: fix UART2 pinmux table entry
On 01/09/2013 10:58 AM, Allen Martin wrote: On Tue, Jan 08, 2013 at 07:46:03PM -0800, Stephen Warren wrote: On 01/08/2013 06:23 PM, Allen Martin wrote: UART2_TXD and UART2_RXD mux 0 SFIO entries should be IRDA not UARTB. IRDA is just a needlessly different synonym for UARTB; there shouldn't be any mention of IRDA in the pinmux code anywhere, or any users of the pinmux code. Oh suck, I didn't realize we had synonyms in the pinmux tables, that seems like a really bad idea. Unfortunately it looks like this particular synonym is widespread. I see it used in the pinmux spreadsheets, the downstream Android kernel source, and gfshell code. It will disappear from the downstream kernels once they've picked up the upstream pinctrl driver; I spent a fair bit of time correlating all the various documentation sources and eliminating duplicate names for the upstream kernel pinctrl driver. The bug I was trying to fix here is that IRDA is referenced in the u-boot cardhu pinmux table. Oh, I didn't notice that the second time round; I'm pretty sure I pointed it out in the very first review. Maybe that was just of the U-Boot pinmux driver and not the Cardhu file. I guess the fix is to change that to UARTB, but it sounds like maybe a larger synonym cleanup is needed everywhere, do you know of any others? I can't recall for sure; I think there were some. I'd suggest comparing upstream U-Boot's pinmux driver with the upstream kernel's pinctrl driver, treating the kernel as canonical now. I'm thinking there needs to be some better run time error checking in the u-boot pinmux code too. There are some debug asserts in there now, but because I didn't have debug turned on this particular bug lead to silent corruption of the pinmux registers which was a PITA to track down. Thoughts on turning those asserts into always on error checking code? Not sure how much it will slow down pinmux programming. I doubt the speed would be significantly affected, unless an error triggers and the printf/... actually happens, but you don't really care about speed then. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra30: cardhu: fix UART2 pinmux settings
On 01/09/2013 11:14 AM, Allen Martin wrote: Use UARTB instead of IRDA synonym for cardhu pinmux settings to match tegra30 pinmux tables. This seems fine as far as it goes, but I'd suggest deleting the IRDA value from the pinmux driver's enum too, so nobody can use it any more. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra30: cardhu: fix UART2 pinmux settings
On Wed, Jan 09, 2013 at 10:49:10AM -0800, Stephen Warren wrote: On 01/09/2013 11:14 AM, Allen Martin wrote: Use UARTB instead of IRDA synonym for cardhu pinmux settings to match tegra30 pinmux tables. This seems fine as far as it goes, but I'd suggest deleting the IRDA value from the pinmux driver's enum too, so nobody can use it any more. Good idea, will do. -Allen -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PULL] Please pull u-boot-atmel/master
Hi Andreas, On Sun, 9 Dec 2012 22:54:09 +0100, Andreas Bießmann andreas.de...@googlemail.com wrote: Dear Albert Aribaud, please consider the following board related changes for u-boot-arm/master. The following changes since commit b8a7c467960ffb4d5a5e1eef5f7783fb6f594542: Merge branch 'u-boot-imx/master' into 'u-boot-arm/master' (2012-11-25 13:01:58 +0100) are available in the git repository at: git://git.denx.de/u-boot-atmel.git master for you to fetch changes up to ac81e1ccf7135d8004763bbf9bef1d95a03fbe92: spi: atmel: sam9m10g45 also support WDRBT bit (2012-12-09 22:40:13 +0100) Bo Shen (1): spi: atmel: sam9m10g45 also support WDRBT bit Richard Genoud (3): at91sam9x5: enable USB support for 9x5ek board. at91sam9x5ek: regroup FAT/DOS features at91sam9x5ek: add USB configuration arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c | 13 ++ arch/arm/include/asm/arch-at91/at91sam9x5.h |2 ++ board/atmel/at91sam9x5ek/at91sam9x5ek.c |3 +++ drivers/spi/atmel_spi.c |2 +- drivers/usb/host/ohci-at91.c |6 +++-- include/configs/at91sam9x5ek.h | 29 +- 6 files changed, 51 insertions(+), 4 deletions(-) Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x
On Tue, Jan 08, 2013 at 07:58:37PM +0100, Wolfgang Denk wrote:
Dear Lars,
In message 1357663926-15937-2-git-send-email-la...@wh2.tu-dresden.de you
wrote:
...
arch/arm/include/asm/arch-am33xx/ddr_defs.h | 18 ++
board/phytec/pcm051/Makefile| 46
board/phytec/pcm051/board.c | 271 +++
board/phytec/pcm051/board.h | 33 +++
board/phytec/pcm051/mux.c | 133
boards.cfg |1 +
include/configs/pcm051.h| 308
+++
Please add an entry to the MAINTAINERS file.
Also, please run your patch through checkpatch - it complains about a
number of style errors:
WARNING: Whitespace before semicolon
+/* DDR RAM defines */
+#define DDR_CLK_MHZ303
Is this really correct? 303 ??
Yes, it's really correct.
+static void rtc32k_enable(void)
+{
+ struct rtc_regs *rtc = (struct rtc_regs *)AM335X_RTC_BASE;
+
+ /*
+* Unlock the RTC's registers. For more details please see the
+* RTC_SS section of the TRM. In order to unlock we need to
+* write these specific values (keys) in this order.
+*/
+ writel(0x83e70b13, rtc-kick0r);
+ writel(0x95a4f1e0, rtc-kick1r);
These magic numbers should probbly be moved to some header file ?
This is a copy/paste from the am335x board.c file. I specifically did a
long comment to explain what / where these values come from because that
(to me) is more helpful than
#define AM33X_RTC_KICK0R_KEY 0x...
#define AM33X_RTC_KICK1R_KEY 0x...
[snip]
+ while (readl(wdtimer-wdtwwps) != 0x0)
+ ;
No timeout?
No. I argued with Marek about some of these before too. In short, if
we don't suceed here, there's a catastrophic failure of the hardware.
+ if (!eth_getenv_enetaddr(ethaddr, mac_addr)) {
+ debug(ethaddr not set. Reading from E-fuse\n);
This should be a printf(). Any such automatic changes are always
worth to be told explicitly.
This is the normal case of asking the hardware what MAC it shipped with.
Why do we want to tell the user the expected has happened?
+ goto try_usbether;
...
+#endif
+try_usbether:
Did you ever try building without CONFIG_DRIVER_TI_CPSW set? I bet
this causes a few compiler warnings. [Hint: You define a label, but
don't use it anywhere.]
It's a valid question if this board uses the CPSW eth or not, yes.
+#define CONFIG_ENV_SIZE(128 10) /* 128 KiB */
Does this really make sense? I doubt you will ever need more than 10%
of this size - so you are just wasting a lot of time for checksumming
unused memory...
ENV stored in NAND with page size of 128KiB is probably the reason for
this.
+#define CONFIG_ENV_IS_NOWHERE
Really?
Until they add NAND (which just now hit mainline), yes.
--
Tom
signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-arm/master
On Wed, Jan 09, 2013 at 03:43:04PM +0100, Albert ARIBAUD wrote: Hello Tom, The following changes since commit 7528cf5f016b5b8b8b12b373f6f31a10bf89233d: Merge branch 'u-boot-imx/master' into 'u-boot-arm/master' (2013-01-08 14:59:37 +0100) are available in the git repository at: git://git.denx.de/u-boot-arm.git master for you to fetch changes up to 61bdb9133593f0f881a57232039296f64bd662ed: arm: remove useless code in start.S files (2013-01-08 22:14:54 +0100) Albert ARIBAUD (2): arm: move C runtime setup code in crt0.S arm: remove useless code in start.S files arch/arm/cpu/arm1136/start.S | 71 +++- arch/arm/cpu/arm1176/start.S | 62 ++- arch/arm/cpu/arm720t/start.S | 53 ++--- arch/arm/cpu/arm920t/start.S | 61 ++ arch/arm/cpu/arm925t/start.S | 65 ++- arch/arm/cpu/arm926ejs/start.S| 86 ++ arch/arm/cpu/arm946es/start.S | 56 ++ arch/arm/cpu/arm_intcm/start.S| 63 ++- arch/arm/cpu/armv7/start.S| 58 +++--- arch/arm/cpu/ixp/start.S | 55 ++--- arch/arm/cpu/pxa/start.S | 63 ++- arch/arm/cpu/s3c44b0/start.S | 55 ++--- arch/arm/cpu/sa1100/start.S | 50 ++--- arch/arm/lib/Makefile |2 + arch/arm/lib/board.c | 11 -- arch/arm/lib/crt0.S | 173 + include/common.h |2 +- include/configs/socfpga_cyclone5.h|2 +- lib/asm-offsets.c | 14 +++ nand_spl/board/freescale/mx31pdk/Makefile |6 +- nand_spl/board/karo/tx25/Makefile |6 +- 21 files changed, 326 insertions(+), 688 deletions(-) create mode 100644 arch/arm/lib/crt0.S Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Regarding M29W128GL Support in u-boot
Hi Friends. We have M5329EVB with JTAG. That board has LHF00L31 (2MB) Flash. And we have source code of u-boot, linux Kernel and rootfs with required patch (so called LTIB) which is available in freescale website. Now we have our custom board with same processor MCF5329 and M29W128GL NOR Flash. Can anybody help me how to configure u-boot (from LTIB) so i can run u-boot from this M29W128GL NOR flash. Means can i know is it supported in u-boot? If yes or no then can i know how and any patch you have? Thanks Warm Regards, Ramesh Khokhani Senior Software Engineer ~~Disclaimer~~~ Information contained and transmitted by this e-mail is confidential and proprietary to iGATE and its affiliates and is intended for use only by the recipient. If you are not the intended recipient, you are hereby notified that any dissemination, distribution, copying or use of this e-mail is strictly prohibited and you are requested to delete this e-mail immediately and notify the originator or mailad...@igate.com mailto:mailad...@igate.com. iGATE does not enter into any agreement with any party by e-mail. Any views expressed by an individual do not necessarily reflect the view of iGATE. iGATE is not responsible for the consequences of any actions taken on the basis of information provided, through this email. The contents of an attachment to this e-mail may contain software viruses, which could damage your own computer system. While iGATE has taken every reasonable precaution to minimise this risk, we cannot accept liability for any damage which you sustain as a result of software viruses. You should carry out your own virus checks before opening an attachment. To know more about iGATE please visit www.igate.com http://www.igate.com. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
On 01/08/2013 04:57:20 PM, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- drivers/mtd/nand/Makefile |4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 2c3812c..c77c0c4 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -79,6 +79,10 @@ COBJS-$(CONFIG_TEGRA_NAND) += tegra_nand.o COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o COBJS-$(CONFIG_NAND_PLAT) += nand_plat.o +else # minimal SPL drivers + +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o + endif # drivers endif # nand So, it looks like this is repairing breakage that came in through a manual merge resolution. Should such merge resolutions not be posted to the list for review? Or was it posted and I missed it? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] mmc:fix: Increase the timeout value for SDHCI_send_command()
Dear Lukasz Majewski, In message 1357665792-8141-1-git-send-email-l.majew...@samsung.com you wrote: I'd like to ask for your opinion about the following problem: I cannot comment on the problem - only a bit about the proposed patch ;-) From a brief checking I can say that it happens when we are doing consecutive MMC operations (i.e. many reads), and the 10ms timeout might be too short when eMMC firmware is forced to do some internal time consuming operations (e.g. flash blocks management, wear leveling). In this situation, the SDHCI_CMD_INHIBIT bit is set, which means that SDHCI controller didn't received response from eMMC. One proposition would be to define the per device/per memory chip specific timeouts, to replace those defined at ./drivers/mmc/sdhci.c file. Is there no way to ask the device and/or controller when it is done, so we can poll for ready state instead of adding delays, which will always have to be tailored for the so far known worst case, i. e. they will be always too long on all almost all systems. --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -137,8 +137,8 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd, unsigned int timeout, start_addr = 0; unsigned int retry = 1; - /* Wait max 10 ms */ - timeout = 10; + /* Wait max 100 ms */ + timeout = 100; We have cases where we struggle for sub-second boot times. Adding 100 ms delay here is clearly prohbitive. [Even the 10 ms are way too long IMHO.] There must be a better way to handle this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MPC8308: Fixup clocks in PCI Host configuration
Dear Barry Grussling, In message 1357669446-29334-1-git-send-email-ba...@grussling.com you wrote: While trying to bring up a custom MPC8308 based board I found that the clocking was wrong. The comment in include/configs/mpc8308_p1m.h led me to believe setting HRCWH_PCI_HOST and HRCWH_PCI1_ARBITER_ENABLE in the CONFIG_SYS_HRCW_HIGH should allow the system to work, but on my newer version of the 8308 this is not working. Setting the HRCWH_PCI_HOST bit (which doesn't exist according to the manual) doesn't latch, and as such the im-reset.rcwh HRCWH_PCI_HOST test in speed.c fails. Since this board is running off the CONFIG_83XX_CLKIN and is not a PCI client, I end up with 0xdeadbeef and hosed clock values. This patch allows for proper clocks on the 8308 as a workaround for the lack of HRCWH_PCI_HOST support. You say this patchis working on your newer version of the 8308. Can you please be specific what old and new actually means here? And has this patch been tested to also work on the old versions of the 8308? +#elif defined(CONFIG_83XX_CLKIN) defined(CONFIG_MPC8308) + /* 8308 doesn't have the HRCWH_PCI_HOST, but should + * run off the CONFIG_83XX_CLKIN */ Incorrect multiline comment style. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de May your future be limited only by your dreams. - Christa McAuliffe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot Web-Documentation misses command nand]
Dear Christoph Petzold, In message 50ed1d4e.4050...@gmx.de you wrote: why is it, that the documentation in http://www.denx.de/wiki/view/DULG/Manual misses the U-Boot nand command? For newbies like me the web manual is one of the first points to start when trying to understand how to accomplish a specific boot task with the help of U-Boot. The sources contain documentation for the nand command in doc/README.nand. The reason is very simple: nobody added it yet. I wished to have had a hint in the Documentation at the very beginning of http://www.denx.de/wiki/view/DULG/Manual and maybe another hint in section 5.9 U-Boot command line interface, just a reference to the source documentation src/doc. Well, as you can see from the URL above, the whole documentation is a wiki, i. e. a colaboration platform where everybody (including you) can contribute. If everybody who notes a wrong or missing piece invests a little time to fix or add the wrong or missing stuff, then everybody will be happy. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I can call spirits from the vasty deep. Why so can I, or so can any man; but will they come when you do call for them? - Shakespeare, 1 King Henry IV, Act III, Scene I. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] tegra: remove IRDA pinmux synonym
IRDA is a synonym for UARTB in tegra pinmux, remove all usage of this
synonym and replace with UARTB to disambiguate.
Signed-off-by: Allen Martin amar...@nvidia.com
---
arch/arm/cpu/tegra-common/board.c |2 +-
arch/arm/cpu/tegra20-common/funcmux.c |4 ++--
arch/arm/cpu/tegra20-common/pinmux.c|2 +-
arch/arm/include/asm/arch-tegra20/funcmux.h |2 +-
arch/arm/include/asm/arch-tegra20/pinmux.h |1 -
arch/arm/include/asm/arch-tegra30/pinmux.h |1 -
board/nvidia/cardhu/pinmux-config-cardhu.h |4 ++--
7 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/arch/arm/cpu/tegra-common/board.c
b/arch/arm/cpu/tegra-common/board.c
index af1879c..1ec6c06 100644
--- a/arch/arm/cpu/tegra-common/board.c
+++ b/arch/arm/cpu/tegra-common/board.c
@@ -113,7 +113,7 @@ static int uart_configs[] = {
#else
FUNCMUX_UART1_IRRX_IRTX,
#endif
- FUNCMUX_UART2_IRDA,
+ FUNCMUX_UART2_UARTB,
-1,
FUNCMUX_UART4_GMC,
-1,
diff --git a/arch/arm/cpu/tegra20-common/funcmux.c
b/arch/arm/cpu/tegra20-common/funcmux.c
index ece7ad9..a1c55a6 100644
--- a/arch/arm/cpu/tegra20-common/funcmux.c
+++ b/arch/arm/cpu/tegra20-common/funcmux.c
@@ -98,8 +98,8 @@ int funcmux_select(enum periph_id id, int config)
break;
case PERIPH_ID_UART2:
- if (config == FUNCMUX_UART2_IRDA) {
- pinmux_set_func(PINGRP_UAD, PMUX_FUNC_IRDA);
+ if (config == FUNCMUX_UART2_UARTB) {
+ pinmux_set_func(PINGRP_UAD, PMUX_FUNC_UARTB);
pinmux_tristate_disable(PINGRP_UAD);
}
break;
diff --git a/arch/arm/cpu/tegra20-common/pinmux.c
b/arch/arm/cpu/tegra20-common/pinmux.c
index a2a0916..5ad2121 100644
--- a/arch/arm/cpu/tegra20-common/pinmux.c
+++ b/arch/arm/cpu/tegra20-common/pinmux.c
@@ -390,7 +390,7 @@ const struct tegra_pingroup_desc
tegra_soc_pingroups[PINGRP_COUNT] = {
PIN(UAA, BB,SPI3, MIPI_HS, UARTA,ULPI,MIPI_HS),
PIN(UAB, BB,SPI2, MIPI_HS, UARTA,ULPI,MIPI_HS),
PIN(UAC, BB,OWR,RSVD, RSVD, RSVD,RSVD4),
- PIN(UAD, UART, IRDA, SPDIF, UARTA, SPI4,SPDIF),
+ PIN(UAD, UART, UARTB, SPDIF, UARTA, SPI4,SPDIF),
PIN(UCA, UART, UARTC, RSVD, GMI, RSVD,RSVD4),
PIN(UCB, UART, UARTC, PWM,GMI, RSVD,RSVD4),
diff --git a/arch/arm/include/asm/arch-tegra20/funcmux.h
b/arch/arm/include/asm/arch-tegra20/funcmux.h
index 1bac25e..963f021 100644
--- a/arch/arm/include/asm/arch-tegra20/funcmux.h
+++ b/arch/arm/include/asm/arch-tegra20/funcmux.h
@@ -35,7 +35,7 @@ enum {
FUNCMUX_UART1_UAA_UAB,
FUNCMUX_UART1_GPU,
FUNCMUX_UART1_SDIO1,
- FUNCMUX_UART2_IRDA = 0,
+ FUNCMUX_UART2_UARTB = 0,
FUNCMUX_UART4_GMC = 0,
/* I2C configs */
diff --git a/arch/arm/include/asm/arch-tegra20/pinmux.h
b/arch/arm/include/asm/arch-tegra20/pinmux.h
index 797e158..a9b4eda 100644
--- a/arch/arm/include/asm/arch-tegra20/pinmux.h
+++ b/arch/arm/include/asm/arch-tegra20/pinmux.h
@@ -204,7 +204,6 @@ enum pmux_func {
PMUX_FUNC_I2C2,
PMUX_FUNC_I2C3,
PMUX_FUNC_IDE,
- PMUX_FUNC_IRDA,
PMUX_FUNC_KBC,
PMUX_FUNC_MIO,
PMUX_FUNC_MIPI_HS,
diff --git a/arch/arm/include/asm/arch-tegra30/pinmux.h
b/arch/arm/include/asm/arch-tegra30/pinmux.h
index de1fc12..341951b 100644
--- a/arch/arm/include/asm/arch-tegra30/pinmux.h
+++ b/arch/arm/include/asm/arch-tegra30/pinmux.h
@@ -349,7 +349,6 @@ enum pmux_func {
PMUX_FUNC_I2C2,
PMUX_FUNC_I2C3,
PMUX_FUNC_IDE,
- PMUX_FUNC_IRDA,
PMUX_FUNC_KBC,
PMUX_FUNC_MIO,
PMUX_FUNC_MIPI_HS,
diff --git a/board/nvidia/cardhu/pinmux-config-cardhu.h
b/board/nvidia/cardhu/pinmux-config-cardhu.h
index 3162219..8428bba 100644
--- a/board/nvidia/cardhu/pinmux-config-cardhu.h
+++ b/board/nvidia/cardhu/pinmux-config-cardhu.h
@@ -176,8 +176,8 @@ static struct pingroup_config tegra3_pinmux_common[] = {
LV_PINMUX(VI_D7, SDMMC2, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
LV_PINMUX(VI_D10, RSVD1, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
LV_PINMUX(VI_MCLK, VI, UP, NORMAL, INPUT, DISABLE, DISABLE),
- DEFAULT_PINMUX(UART2_RXD, IRDA, NORMAL, NORMAL, INPUT),
- DEFAULT_PINMUX(UART2_TXD, IRDA, NORMAL, NORMAL, OUTPUT),
+ DEFAULT_PINMUX(UART2_RXD, UARTB, NORMAL, NORMAL, INPUT),
+ DEFAULT_PINMUX(UART2_TXD, UARTB, NORMAL, NORMAL, OUTPUT),
DEFAULT_PINMUX(UART2_RTS_N, UARTB, NORMAL, NORMAL, OUTPUT),
DEFAULT_PINMUX(UART2_CTS_N, UARTB, NORMAL, NORMAL, INPUT),
DEFAULT_PINMUX(UART3_TXD, UARTC, NORMAL, NORMAL, OUTPUT),
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra: remove IRDA pinmux synonym
On 01/09/2013 01:52 PM, Allen Martin wrote: IRDA is a synonym for UARTB in tegra pinmux, remove all usage of this synonym and replace with UARTB to disambiguate. Reviewed-by: Stephen Warren swar...@nvidia.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][v4] powerpc/mpc8xxxx: FSL DDR debugger auto run of stored commands
On 01/07/2013 04:01 PM, james.y...@freescale.com wrote: From: James Yang james.y...@freescale.com This patch adds the ability for the FSL DDR interactive debugger to automatically run the sequence of commands stored in the ddr_interactive environment variable. Commands are separated using ';'. ddr_interactive=compute; edit c0 d0 dimmparms caslat_X 0x3FC0; go Signed-off-by: James Yang james.y...@freescale.com --- Applied to master branch, replaced early commit. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
On Wed, Jan 09, 2013 at 01:53:21PM -0600, Scott Wood wrote: On 01/08/2013 04:57:20 PM, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- drivers/mtd/nand/Makefile |4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 2c3812c..c77c0c4 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -79,6 +79,10 @@ COBJS-$(CONFIG_TEGRA_NAND) += tegra_nand.o COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o COBJS-$(CONFIG_NAND_PLAT) += nand_plat.o +else # minimal SPL drivers + +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o + endif # drivers endif # nand So, it looks like this is repairing breakage that came in through a manual merge resolution. Should such merge resolutions not be posted to the list for review? Or was it posted and I missed it? None of the above. That powerpc was broken twice (once by this, and once by the arm head.S changes) was missed in my build testing. We don't have spelled out rules (that I'm aware of) for manual merges other than asking that someone check that X still works (in this case, am335x NAND). It did, but I didn't read the merge myself was the problem. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make patman usable outside of u-boot tree
Vadim,
Thanks for the patch! Looks good in general, though please add the
patman prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vben...@chromium.org wrote:
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
-Doug
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
On 01/09/2013 03:38:22 PM, Tom Rini wrote: On Wed, Jan 09, 2013 at 01:53:21PM -0600, Scott Wood wrote: On 01/08/2013 04:57:20 PM, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- drivers/mtd/nand/Makefile |4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 2c3812c..c77c0c4 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -79,6 +79,10 @@ COBJS-$(CONFIG_TEGRA_NAND) += tegra_nand.o COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o COBJS-$(CONFIG_NAND_PLAT) += nand_plat.o +else # minimal SPL drivers + +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o + endif # drivers endif # nand So, it looks like this is repairing breakage that came in through a manual merge resolution. Should such merge resolutions not be posted to the list for review? Or was it posted and I missed it? None of the above. That powerpc was broken twice (once by this, and once by the arm head.S changes) was missed in my build testing. We don't have spelled out rules (that I'm aware of) for manual merges other than asking that someone check that X still works (in this case, am335x NAND). It did, but I didn't read the merge myself was the problem. The NAND Makefile breakage came from commit 79f38777947ac7685e2cef8bd977f954ab198c0e, which is a manual merge by Albert. Why should manual merges be exempt from the rule that all changes get posted to the list? What if next time it's a functional breakage rather than a broken build? I tried repeating the merge between 96764df and 9bd5c1a and the only conflict marker was this: ifdef CONFIG_SPL_BUILD HEAD ifdef CONFIG_SPL_NAND_SIMPLE COBJS-y += nand_spl_simple.o endif COBJS-$(CONFIG_SPL_NAND_AM33XX_BCH) += am335x_spl_bch.o ifdef CONFIG_SPL_NAND_LOAD COBJS-y += nand_spl_load.o ||| merged common ancestors ifdef CONFIG_SPL_NAND_SIMPLE COBJS-y += nand_spl_simple.o endif ifdef CONFIG_SPL_NAND_LOAD COBJS-y += nand_spl_load.o === ifdef CONFIG_SPL_NAND_DRIVERS NORMAL_DRIVERS=y 96764df endif The fsl_elbc_spl.o part was still there, so it wasn't the automatic part of the merge that removed it. If this was simply due to a bad patch in the ARM tree, which specific patch was it? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
On 01/09/2013 03:38:22 PM, Tom Rini wrote: On Wed, Jan 09, 2013 at 01:53:21PM -0600, Scott Wood wrote: On 01/08/2013 04:57:20 PM, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- drivers/mtd/nand/Makefile |4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 2c3812c..c77c0c4 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -79,6 +79,10 @@ COBJS-$(CONFIG_TEGRA_NAND) += tegra_nand.o COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o COBJS-$(CONFIG_NAND_PLAT) += nand_plat.o +else # minimal SPL drivers + +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o + endif # drivers endif # nand So, it looks like this is repairing breakage that came in through a manual merge resolution. Should such merge resolutions not be posted to the list for review? Or was it posted and I missed it? None of the above. That powerpc was broken twice (once by this, and once by the arm head.S changes) was missed in my build testing. We don't have spelled out rules (that I'm aware of) for manual merges other than asking that someone check that X still works (in this case, am335x NAND). It did, but I didn't read the merge myself was the problem. BTW, the conflicting patch was 5846b11e8810f0ecc15e78b383b7709b9b785580 (am33xx_spl_bch: simple SPL nand loader for AM33XX). It's a NAND patch, in drivers/mtd/nand specifically. I don't see my ACK on it, and it came in through the ti tree. If we were having custodians sign-off patches as they apply them, you could tell from a glance that a patch is missing either Acked-by or Signed-off-by from a relevant maintainer. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] patman: Allow use outside of u-boot tree
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
tools/patman/patman.py | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..6620a48 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.no_check:
+ok = True
+else:
+ok = checkpatch.CheckPatches(options.verbose, args)
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Make patman usable outside of u-boot tree
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suippress patch
check. While we are at it, sort debug options alphabetically.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
tools/patman/patman.py | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..6620a48 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.no_check:
+ok = True
+else:
+ok = checkpatch.CheckPatches(options.verbose, args)
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] patman: Allow use outside of u-boot tree
On Wed, Jan 9, 2013 at 2:01 PM, Vadim Bendebury vben...@chromium.org wrote:
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
tools/patman/patman.py | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..6620a48 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.no_check:
+ok = True
+else:
+ok = checkpatch.CheckPatches(options.verbose, args)
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
Doug, thank you for a prompt review, copying your response here,
please see below:
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson diand...@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the
patman prefix to the first line of your commit message.
done
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vben...@chromium.org wrote:
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
done
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
I don't quite agree with this part - I think it's perfectly reasonable
to use 'no-check' to suppress the check, just as well as to use
'no-tags' to suppress interpreting tags.
`--no' communicates that by default the respective feature is enabled,
and to disable it one needs to add a command line option with no
parameter.
cheers,
/vb
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make patman usable outside of u-boot tree
On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass s...@google.com wrote:
Hi Vadim,
Looks good! Please can you add a single character option?
Simon, I could not think of a good single letter option to pick, so I
did not, but if you have a suggestion I implement it.
Can you also please add an option to skip the 'apply' step? This takes
quite a bit of time, and it would be nice to have a 'fast' option.
does it have to be in this CL?
cheers,
/vb
Regards,
Simon
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson diand...@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the
patman prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vben...@chromium.org wrote:
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
-Doug
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make patman usable outside of u-boot tree
Hi Vadim,
On Wed, Jan 9, 2013 at 2:16 PM, Vadim Bendebury vben...@chromium.org wrote:
On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass s...@google.com wrote:
Hi Vadim,
Looks good! Please can you add a single character option?
Simon, I could not think of a good single letter option to pick, so I
did not, but if you have a suggestion I implement it.
I can't think of a good one.
-C or -P ?
Can you also please add an option to skip the 'apply' step? This takes
quite a bit of time, and it would be nice to have a 'fast' option.
does it have to be in this CL?
No not at all.
cheers,
/vb
Regards,
Simon
Regards,
Simon
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson diand...@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the
patman prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vben...@chromium.org
wrote:
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
-Doug
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/09/2013 05:06 PM, Scott Wood wrote: On 01/09/2013 03:38:22 PM, Tom Rini wrote: On Wed, Jan 09, 2013 at 01:53:21PM -0600, Scott Wood wrote: On 01/08/2013 04:57:20 PM, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- drivers/mtd/nand/Makefile |4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index 2c3812c..c77c0c4 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -79,6 +79,10 @@ COBJS-$(CONFIG_TEGRA_NAND) += tegra_nand.o COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o COBJS-$(CONFIG_NAND_PLAT) += nand_plat.o +else # minimal SPL drivers + +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o + endif # drivers endif # nand So, it looks like this is repairing breakage that came in through a manual merge resolution. Should such merge resolutions not be posted to the list for review? Or was it posted and I missed it? None of the above. That powerpc was broken twice (once by this, and once by the arm head.S changes) was missed in my build testing. We don't have spelled out rules (that I'm aware of) for manual merges other than asking that someone check that X still works (in this case, am335x NAND). It did, but I didn't read the merge myself was the problem. BTW, the conflicting patch was 5846b11e8810f0ecc15e78b383b7709b9b785580 (am33xx_spl_bch: simple SPL nand loader for AM33XX). It's a NAND patch, in drivers/mtd/nand specifically. I don't see my ACK on it, and it came in through the ti tree. Putting on my u-boot-ti hat... If we were having custodians sign-off patches as they apply them, you could tell from a glance that a patch is missing either Acked-by or Signed-off-by from a relevant maintainer. Yes, the series was posted Oct 30, and was minor updates to an existing SoC driver (omap_gpmc), some code for new related parts of the SoC (the ELM code, for offloading bch math) and a new SPL shim because there was no other way to get the read correct. I merged it on or around Dec 10 and figured that since you hadn't spoken up in the intervening time, you didn't see anything worth commenting on. - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQ7e5pAAoJENk4IS6UOR1WQbYP+waymmRmbnoFI6j+1tbVwqAP M3ayJER63xo6kwp04cGlRJWyboqOS8IKoSJy3P6FDxyobCcC8SLmxYFcCuzoKxWD cwOLA5GxsY1cYY6JEBLY9Iy7DWh8P1YwMFvZSvSDdnh0NYJ/X4PCS4uO+JEkY4jf +kR01aylSshk11RpGzNB6T3rxgyBIyZPUsEzK1AUSJbV+R+2Opt7zhL1eUQyCRM0 18TySJEmmOBa0R0yMA510lRev0yhlCrw1WRYuXQB+F1cbNIF4G010fUO3W7QAxpe 1USrYdL0TFD65HfK/K08zGmLJO7DbOkOS7wbpVlQQTZKEul4mnyw4gkq/6n36Poz WDccGrAWEBYGARMcdNd/suNAjdpAFRpFFVKW88iKi1mZjRfT8Mm93CaWXY6TAi69 YxSmR91XlTuK5ZTEP4QZviIFvz2BBhuzsuglWnFLwCGGh/SARpKetkKAoFTX5n98 q0OBliai+KoadNy0kgkkx9iknZB5nZ7h5fKmqn035SZpOVbIhX/rfD4MSwBoWYFz ROEFofcFY6IMvrnriKcBcHBy2B97evZTY3rLA5g+9w+192xw3s3G9XniZ4SLve9Q yk1BPiZeu9v/IN2zCTD81f2hDQ+Ch7FNIZcbjv4yAVsiQnYvl1sRm8+wgyIT9kf6 AKXplnA0lkCk/vp35huN =UTij -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make patman usable outside of u-boot tree
On Wed, Jan 9, 2013 at 2:22 PM, Simon Glass s...@chromium.org wrote:
Hi Vadim,
On Wed, Jan 9, 2013 at 2:16 PM, Vadim Bendebury vben...@chromium.org wrote:
On Wed, Jan 9, 2013 at 2:13 PM, Simon Glass s...@google.com wrote:
Hi Vadim,
Looks good! Please can you add a single character option?
Simon, I could not think of a good single letter option to pick, so I
did not, but if you have a suggestion I implement it.
I can't think of a good one.
-C or -P ?
Yeah, I feel a bit awkward about these, also, it would be inconsistent
with --no-tags which does not have a single letter alternative. Let's
see what others think about it - I would rather leave it as is...
cheers,
/v
Can you also please add an option to skip the 'apply' step? This takes
quite a bit of time, and it would be nice to have a 'fast' option.
does it have to be in this CL?
No not at all.
cheers,
/vb
Regards,
Simon
Regards,
Simon
On Wed, Jan 9, 2013 at 1:48 PM, Doug Anderson diand...@chromium.org wrote:
Vadim,
Thanks for the patch! Looks good in general, though please add the
patman prefix to the first line of your commit message.
On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury vben...@chromium.org
wrote:
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suippress patch
s/suippress/suppress
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
-Doug
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix SPL build for non-ARM targets
On 01/09/2013 04:25:46 PM, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/09/2013 05:06 PM, Scott Wood wrote: BTW, the conflicting patch was 5846b11e8810f0ecc15e78b383b7709b9b785580 (am33xx_spl_bch: simple SPL nand loader for AM33XX). It's a NAND patch, in drivers/mtd/nand specifically. I don't see my ACK on it, and it came in through the ti tree. Putting on my u-boot-ti hat... If we were having custodians sign-off patches as they apply them, you could tell from a glance that a patch is missing either Acked-by or Signed-off-by from a relevant maintainer. Yes, the series was posted Oct 30, and was minor updates to an existing SoC driver (omap_gpmc), some code for new related parts of the SoC (the ELM code, for offloading bch math) and a new SPL shim because there was no other way to get the read correct. I merged it on or around Dec 10 and figured that since you hadn't spoken up in the intervening time, you didn't see anything worth commenting on. I get a lot of e-mail. Some of it gets missed. If I haven't responded to something that directly touches drivers/mtd/nand within a reasonable time frame, please remind me rather than assume acquiscence. Regardless, it's the manual merge that definitely needed review. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][v4] powerpc/mpc8xxxx: FSL DDR debugger auto run of stored commands
On 01/09/2013 01:03 PM, York Sun wrote: On 01/07/2013 04:01 PM, james.y...@freescale.com wrote: From: James Yang james.y...@freescale.com This patch adds the ability for the FSL DDR interactive debugger to automatically run the sequence of commands stored in the ddr_interactive environment variable. Commands are separated using ';'. ddr_interactive=compute; edit c0 d0 dimmparms caslat_X 0x3FC0; go Signed-off-by: James Yang james.y...@freescale.com --- Applied to master branch, replaced early commit. Oops, sorry. Posted to wrong list. I meant to post to an internal list. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] patman: Allow use outside of u-boot tree
On Wed, Jan 9, 2013 at 2:57 PM, Doug Anderson diand...@chromium.org wrote:
Vadim,
On Wed, Jan 9, 2013 at 2:07 PM, Vadim Bendebury vben...@chromium.org wrote:
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
I don't quite agree with this part - I think it's perfectly reasonable
to use 'no-check' to suppress the check, just as well as to use
'no-tags' to suppress interpreting tags.
`--no' communicates that by default the respective feature is enabled,
and to disable it one needs to add a command line option with no
parameter.
Sorry--should have been more explicit. Was still expecting the option
to be --no-check. Just asking for a change to the way it's stored.
Like this in the python dev guide:
parser.add_option(--clobber, action=store_true, dest=clobber)
parser.add_option(--no-clobber, action=store_false, dest=clobber)
In your case, I don't think you need to add the check option too,
but just store to the check option:
parser.add_option('--no-check', action='store_false', dest='check',
default=True,
help=Don't check for patch compliance)
ah, a good idea, changed. Also, modified the code in checkpatch.py not
to throw an exception, but to print an error message and return a
nonzero status.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] patman: Allow use outside of u-boot tree
Vadim,
On Wed, Jan 9, 2013 at 2:07 PM, Vadim Bendebury vben...@chromium.org wrote:
+parser.add_option('--no-check', action='store_true', dest='no_check',
+ default=False,
+ help=Don't check for patch compliance)
IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).
I don't quite agree with this part - I think it's perfectly reasonable
to use 'no-check' to suppress the check, just as well as to use
'no-tags' to suppress interpreting tags.
`--no' communicates that by default the respective feature is enabled,
and to disable it one needs to add a command line option with no
parameter.
Sorry--should have been more explicit. Was still expecting the option
to be --no-check. Just asking for a change to the way it's stored.
Like this in the python dev guide:
parser.add_option(--clobber, action=store_true, dest=clobber)
parser.add_option(--no-clobber, action=store_false, dest=clobber)
In your case, I don't think you need to add the check option too,
but just store to the check option:
parser.add_option('--no-check', action='store_false', dest='check',
default=True,
help=Don't check for patch compliance)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] patman: Allow use outside of u-boot tree
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.
Also, do not raise an exception if checkpatch.pl is not found - just
print an error message suggesting to use the new option, and return
nonzero status.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
tools/patman/checkpatch.py | 10 +-
tools/patman/patman.py | 14 ++
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py
index f72f8ee..00aef09 100644
--- a/tools/patman/checkpatch.py
+++ b/tools/patman/checkpatch.py
@@ -23,6 +23,7 @@ import command
import gitutil
import os
import re
+import sys
import terminal
def FindCheckPatch():
@@ -47,8 +48,10 @@ def FindCheckPatch():
if os.path.isfile(fname):
return fname
path = os.path.dirname(path)
-print 'Could not find checkpatch.pl'
-return None
+
+print sys.stderr, ('Cannot find checkpatch.pl - please put it in your '
+
+'~/bin directory or use --no_patch')
+sys.exit(1)
def CheckPatch(fname, verbose=False):
Run checkpatch.pl on a file.
@@ -67,9 +70,6 @@ def CheckPatch(fname, verbose=False):
error_count, warning_count, lines = 0, 0, 0
problems = []
chk = FindCheckPatch()
-if not chk:
-raise OSError, ('Cannot find checkpatch.pl - please put it in your ' +
-'~/bin directory')
item = {}
stdout = command.Output(chk, '--no-tree', fname)
#pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..e049081 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_false', dest='check_patch',
+ default=True,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.check_patch:
+ok = checkpatch.CheckPatches(options.verbose, args)
+else:
+ok = True
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] patman: Allow use outside of u-boot tree
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.
Also, do not raise an exception if checkpatch.pl is not found - just
print an error message suggesting to use the new option, and return
nonzero status.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
Changes in v2:
. addressed comments WRT use of double negative
. added code to gracefully handle absence of checkpatch.cl
tools/patman/checkpatch.py | 10 +-
tools/patman/patman.py | 14 ++
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py
index f72f8ee..00aef09 100644
--- a/tools/patman/checkpatch.py
+++ b/tools/patman/checkpatch.py
@@ -23,6 +23,7 @@ import command
import gitutil
import os
import re
+import sys
import terminal
def FindCheckPatch():
@@ -47,8 +48,10 @@ def FindCheckPatch():
if os.path.isfile(fname):
return fname
path = os.path.dirname(path)
-print 'Could not find checkpatch.pl'
-return None
+
+print sys.stderr, ('Cannot find checkpatch.pl - please put it in your '
+
+'~/bin directory or use --no_patch')
+sys.exit(1)
def CheckPatch(fname, verbose=False):
Run checkpatch.pl on a file.
@@ -67,9 +70,6 @@ def CheckPatch(fname, verbose=False):
error_count, warning_count, lines = 0, 0, 0
problems = []
chk = FindCheckPatch()
-if not chk:
-raise OSError, ('Cannot find checkpatch.pl - please put it in your ' +
-'~/bin directory')
item = {}
stdout = command.Output(chk, '--no-tree', fname)
#pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..e049081 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_false', dest='check_patch',
+ default=True,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.check_patch:
+ok = checkpatch.CheckPatches(options.verbose, args)
+else:
+ok = True
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3 V5] EXYNOS5: MAX77686 add FDT support
On 09/01/13 16:03, Rajeshwari Shinde wrote: Add FDT support to PMIC MAX77686 chip. Changes in V2: - Changed chip address from 06 to 6. - Corrected indentation errors. Changes in V3: - Rebased on top of the latest implementation of PMIC Changes in V4: - Corrected PMIC register address Changes in V5: - Rebased on latest u-boot-samsung tree. Rajeshwari Shinde (3): EXYNOS5: FDT: Add compatible strings for PMIC EXYNOS5: Add device node for PMIC PMIC: MAX77686: Add FDT Support board/samsung/dts/exynos5250-smdk5250.dts |7 + drivers/power/pmic/pmic_max77686.c| 37 ++-- include/fdtdec.h |1 + lib/fdtdec.c |1 + 4 files changed, 43 insertions(+), 3 deletions(-) applied to u-boot-samsung Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V6 0/4] Add support for FIMD and DP on SMDK5250
On 09/01/13 15:42, Ajay Kumar wrote: [PATCH V6 1/4] EXYNOS5: Change parent clock of FIMD to MPLL [PATCH V6 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM [PATCH V6 3/4] video: Modify exynos_fimd driver to support LCD console [PATCH V6 4/4] EXYNOS5: Add support for FIMD and DP arch/arm/cpu/armv7/exynos/clock.c| 2 +- arch/arm/include/asm/arch-exynos/dp_info.h | 2 + arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 ++ board/samsung/smdk5250/smdk5250.c| 97 drivers/video/exynos_fb.c| 2 + drivers/video/exynos_fimd.c | 12 ++-- include/configs/exynos5250-dt.h | 8 +++ 7 files changed, 125 insertions(+), 5 deletions(-) applied to u-boot-samsung Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] patman: Allow use outside of u-boot tree
Vadim,
Looks great with one last nit...
On Wed, Jan 9, 2013 at 4:23 PM, Vadim Bendebury vben...@chromium.org wrote:
+
+print sys.stderr, ('Cannot find checkpatch.pl - please put it in your
' +
+'~/bin directory or use --no_patch')
+sys.exit(1)
s/no_patch/no-patch
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] patman: Allow use outside of u-boot tree
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.
Also, do not raise an exception if checkpatch.pl is not found - just
print an error message suggesting to use the new option, and return
nonzero status.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
Changes in v3:
. corrected typo in the error message
Changes in v2:
. addressed comments WRT use of double negative
. added code to gracefully handle absence of checkpatch.cl
tools/patman/checkpatch.py | 10 +-
tools/patman/patman.py | 14 ++
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py
index f72f8ee..5a03314 100644
--- a/tools/patman/checkpatch.py
+++ b/tools/patman/checkpatch.py
@@ -23,6 +23,7 @@ import command
import gitutil
import os
import re
+import sys
import terminal
def FindCheckPatch():
@@ -47,8 +48,10 @@ def FindCheckPatch():
if os.path.isfile(fname):
return fname
path = os.path.dirname(path)
-print 'Could not find checkpatch.pl'
-return None
+
+print sys.stderr, ('Cannot find checkpatch.pl - please put it in your '
+
+'~/bin directory or use --no-patch')
+sys.exit(1)
def CheckPatch(fname, verbose=False):
Run checkpatch.pl on a file.
@@ -67,9 +70,6 @@ def CheckPatch(fname, verbose=False):
error_count, warning_count, lines = 0, 0, 0
problems = []
chk = FindCheckPatch()
-if not chk:
-raise OSError, ('Cannot find checkpatch.pl - please put it in your ' +
-'~/bin directory')
item = {}
stdout = command.Output(chk, '--no-tree', fname)
#pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..e049081 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_false', dest='check_patch',
+ default=True,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.check_patch:
+ok = checkpatch.CheckPatches(options.verbose, args)
+else:
+ok = True
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4] patman: Allow use outside of u-boot tree
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.
Also, do not raise an exception if checkpatch.pl is not found - just
print an error message suggesting to use the new option, and return
nonzero status.
. unit test passes:
$ ./patman -t
unittest.result.TestResult run=7 errors=0 failures=0
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabetically
Signed-off-by: Vadim Bendebury vben...@chromium.org
---
Changes in v4:
. now properly corrected typo in the error message
Changes in v3:
. corrected typo in the error message
Changes in v2:
. addressed comments WRT use of double negative
. added code to gracefully handle absence of checkpatch.cl
tools/patman/checkpatch.py | 10 +-
tools/patman/patman.py | 14 ++
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py
index f72f8ee..d3a0477 100644
--- a/tools/patman/checkpatch.py
+++ b/tools/patman/checkpatch.py
@@ -23,6 +23,7 @@ import command
import gitutil
import os
import re
+import sys
import terminal
def FindCheckPatch():
@@ -47,8 +48,10 @@ def FindCheckPatch():
if os.path.isfile(fname):
return fname
path = os.path.dirname(path)
-print 'Could not find checkpatch.pl'
-return None
+
+print sys.stderr, ('Cannot find checkpatch.pl - please put it in your '
+
+'~/bin directory or use --no-check')
+sys.exit(1)
def CheckPatch(fname, verbose=False):
Run checkpatch.pl on a file.
@@ -67,9 +70,6 @@ def CheckPatch(fname, verbose=False):
error_count, warning_count, lines = 0, 0, 0
problems = []
chk = FindCheckPatch()
-if not chk:
-raise OSError, ('Cannot find checkpatch.pl - please put it in your ' +
-'~/bin directory')
item = {}
stdout = command.Output(chk, '--no-tree', fname)
#pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE)
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index e56dd01..e049081 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -50,6 +50,9 @@ parser.add_option('-i', '--ignore-errors',
action='store_true',
help='Send patches email even if patch errors are found')
parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
default=False, help=Do a try run (create but don't email patches))
+parser.add_option('-p', '--project', default=project.DetectProject(),
+ help=Project name; affects default option values and
+ aliases [default: %default])
parser.add_option('-s', '--start', dest='start', type='int',
default=0, help='Commit to start creating patches from (0 = HEAD)')
parser.add_option('-t', '--test', action='store_true', dest='test',
@@ -58,11 +61,11 @@ parser.add_option('-v', '--verbose', action='store_true',
dest='verbose',
default=False, help='Verbose output of errors and warnings')
parser.add_option('--cc-cmd', dest='cc_cmd', type='string', action='store',
default=None, help='Output cc list for patch file (used by git)')
+parser.add_option('--no-check', action='store_false', dest='check_patch',
+ default=True,
+ help=Don't check for patch compliance)
parser.add_option('--no-tags', action='store_false', dest='process_tags',
default=True, help=Don't process subject tags as aliaes)
-parser.add_option('-p', '--project', default=project.DetectProject(),
- help=Project name; affects default option values and
- aliases [default: %default])
parser.usage = patman [options]
@@ -146,7 +149,10 @@ else:
series.DoChecks()
# Check the patches, and run them through 'git am' just to be sure
-ok = checkpatch.CheckPatches(options.verbose, args)
+if options.check_patch:
+ok = checkpatch.CheckPatches(options.verbose, args)
+else:
+ok = True
if not gitutil.ApplyPatches(options.verbose, args,
options.count + options.start):
ok = False
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC] Is anyone interested IPv6 support for u-boot
Hi, Here at $dayjob we make embedded network devices (routers switches). Because we have an interest in getting people to adopt IPv6 we've added code to our local u-boot repository to add basic IPv6 support on our boards. It's not a fully conformant IPv6 host implementation but it is enough to be able to statically configure an IPv6 address and download images from a v6 capable TFTP server. We're trying to be better FLOSS citizens so I'm proposing to my colleagues that we put some effort in getting this pushed upstream. The first step of which would be to see if anyone wants the feature and is the /net maintainer willing to take on this code (not that we intend to dump and run). Our existing code is a little too tightly coupled to our out of tree board support so I don't have a preliminary patchset to provide. If there is interest I'll work on porting it from our tree to a vanilla u-boot tree (we have a couple of supported eval boards around). Thanks for reading, Chris Packham ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MPC8308: Fixup clocks in PCI Host configuration
This patch allows for proper clocks on the 8308 as a workaround for the lack of HRCWH_PCI_HOST support. You say this patchis working on your newer version of the 8308. Can you please be specific what old and new actually means here? Not exactly unfortunately. On the 8308s I currently have u-boot doesn't work without this patch. I believe before on the 8308 development board I had the PCI_HOST bit of the HRCW_HIGH would latch when set in the #define for CONFIG_SYS_HRCW_HIGH. I don't have the old development board any more, and my new board doesn't appear to latch that bit. I also don't know what rev of the microprocessor the old one was. It is entirely possible some other change was made and this is a manifestation of that change instead (I was playing around with the 8308 development board in the u-boot 1.3.0 timeframe). And has this patch been tested to also work on the old versions of the 8308? No. Don't have the old test board anymore. As such, I have only verified it on the custom board I have currently. I did try playing with the CONFIG_SYS_HRCW_HIGH and setting the PCI_HOST bit in my current board but that didn't fix it. Out of curiousity, does anyone have one of the 8308_p1m and is the current u-boot booting on it? I can't figure out why it would work on the p1m and not my board. +#elif defined(CONFIG_83XX_CLKIN) defined(CONFIG_MPC8308) + /* 8308 doesn't have the HRCWH_PCI_HOST, but should + * run off the CONFIG_83XX_CLKIN */ Incorrect multiline comment style. Yea. Sorry about that. Fixed in V2 patch. Thanks! Barry ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] EXYNOS5: Make all display related code dependent on CONFIG_LCD
u-boot compilation fails for smdk5250 when we deselect CONFIG_LCD
from the main config file. This patch fixes it.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
board/samsung/smdk5250/smdk5250.c | 2 ++
include/configs/exynos5250-dt.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/board/samsung/smdk5250/smdk5250.c
b/board/samsung/smdk5250/smdk5250.c
index 9c4bf9b..7a5f132 100644
--- a/board/samsung/smdk5250/smdk5250.c
+++ b/board/samsung/smdk5250/smdk5250.c
@@ -281,6 +281,7 @@ int board_early_init_f(void)
}
#endif
+#ifdef CONFIG_LCD
void cfg_lcd_gpio(void)
{
struct exynos5_gpio_part1 *gpio1 =
@@ -374,3 +375,4 @@ void init_panel_info(vidinfo_t *vid)
exynos_set_dp_platform_data(dp_platform_data);
}
+#endif
diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
index 07bca1d..298bae9 100644
--- a/include/configs/exynos5250-dt.h
+++ b/include/configs/exynos5250-dt.h
@@ -299,10 +299,12 @@
/* Display */
#define CONFIG_LCD
+#ifdef CONFIG_LCD
#define CONFIG_EXYNOS_FB
#define CONFIG_EXYNOS_DP
#define LCD_XRES 2560
#define LCD_YRES 1600
#define LCD_BPPLCD_COLOR16
+#endif
#endif /* __CONFIG_H */
--
1.8.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] EXYNOS5: Enable console multiplexing in u-boot when LCD support is enabled
With this patch, stdout/stderr is assigned to serial and also to LCD. Initially, u-boot output console is observed via serial port. If you also have a DP panel connected onto your SMDK5250 board, you can switch to LCD console by typing setenv stdout lcd. You can always switch back to serial using setenv stdout serial. You can switch error console(stderr) as well, using similar commands. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- include/configs/exynos5250-dt.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h index 298bae9..49c0adf 100644 --- a/include/configs/exynos5250-dt.h +++ b/include/configs/exynos5250-dt.h @@ -305,6 +305,12 @@ #define LCD_XRES 2560 #define LCD_YRES 1600 #define LCD_BPPLCD_COLOR16 + +/* Override console configuration when LCD is present */ +#define CONFIG_CONSOLE_MUX +#define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_EXTRA_ENV_SETTINGS \ + stdout=serial,lcd\0 #endif #endif /* __CONFIG_H */ -- 1.8.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x
Hi Wolfgang, hi Tom,
as I almost have the changes requested by Wolfgang in place, you two can
choose, which version I should resubmit. ;)
Am 09.01.2013 um 20:34 schrieb Tom Rini:
+static void rtc32k_enable(void)
+{
+ struct rtc_regs *rtc = (struct rtc_regs *)AM335X_RTC_BASE;
+
+ /*
+* Unlock the RTC's registers. For more details please see the
+* RTC_SS section of the TRM. In order to unlock we need to
+* write these specific values (keys) in this order.
+*/
+ writel(0x83e70b13, rtc-kick0r);
+ writel(0x95a4f1e0, rtc-kick1r);
These magic numbers should probbly be moved to some header file ?
This is a copy/paste from the am335x board.c file. I specifically did a
long comment to explain what / where these values come from because that
(to me) is more helpful than
#define AM33X_RTC_KICK0R_KEY 0x...
#define AM33X_RTC_KICK1R_KEY 0x...
davinci does it this way. I would prefer Tom's variant having the values right
in place.
+ if (!eth_getenv_enetaddr(ethaddr, mac_addr)) {
+ debug(ethaddr not set. Reading from E-fuse\n);
This should be a printf(). Any such automatic changes are always
worth to be told explicitly.
This is the normal case of asking the hardware what MAC it shipped with.
Why do we want to tell the user the expected has happened?
Here I'd prefer the printf variant, because for a common user it is not
obivous, that it is reading the MAC from efuse. So this message is helpful.
+ goto try_usbether;
...
+#endif
+try_usbether:
Did you ever try building without CONFIG_DRIVER_TI_CPSW set? I bet
this causes a few compiler warnings. [Hint: You define a label, but
don't use it anywhere.]
It's a valid question if this board uses the CPSW eth or not, yes.
Yes, the board uses CPSW, but here I would prefer having the try_usbether label
inside the ifdef.
+#define CONFIG_ENV_IS_NOWHERE
Really?
Until they add NAND (which just now hit mainline), yes.
This is a very valuable information, thanks!
Regards,
Lars
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Regarding M29W128GL Support in u-boot
On 01/09/2013 04:42 PM, Ramesh K Khokhani wrote: We have M5329EVB with JTAG. That board has LHF00L31 (2MB) Flash. And we have source code of u-boot, linux Kernel and rootfs with required patch (so called LTIB) which is available in freescale website. Now we have our custom board with same processor MCF5329 and M29W128GL NOR Flash. Can anybody help me how to configure u-boot (from LTIB) so i can run u-boot from this M29W128GL NOR flash. Means can i know is it supported in u-boot? If yes or no then can i know how and any patch you have? The M29W flash chips are supported in current mainline U-Boot by the common CFI driver (drivers/mtd/cfi_flash.c). To configure this driver for your board I suggest you take a look at one of the boards using this driver (its used by many platforms). Search for CONFIG_FLASH_CFI_DRIVER. Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request for u-boot-marvell.git
Hi Prafulla, On Tue, 8 Jan 2013 09:21:40 -0800, Prafulla Wadaskar prafu...@marvell.com wrote: Dear Albert Please pull The following changes since commit 7528cf5f016b5b8b8b12b373f6f31a10bf89233d: Merge branch 'u-boot-imx/master' into 'u-boot-arm/master' (2013-01-08 14:59:37 +0100) are available in the git repository at: u-boot-marvell.git master branch. Albert ARIBAUD (3): mv88e61xx: refactor PHY and SWITCH level-code kirkwood: make MPP arrays static const ARM: lacie_kw: add support for WIRELESS_SPACE Andreas Bießmann (1): mv-common.h: increase malloc arena to 4MiB Holger Brunck (3): arm/km: fix memory settings km/common: drop unneeded std* environment variables km/common: cosmetic change reported from checkpatch Luke Lowrey (1): arch-kirkwood: Ethernet port macro returning incorrect address Michael Walle (1): lsxl: unset ncip for rescue mode Valentin Longchamp (1): arm/km: remove duplicate code arch/arm/cpu/arm926ejs/kirkwood/mpp.c |2 +- arch/arm/include/asm/arch-kirkwood/cpu.h|2 +- arch/arm/include/asm/arch-kirkwood/mpp.h|2 +- board/LaCie/net2big_v2/net2big_v2.c |2 +- board/LaCie/netspace_v2/netspace_v2.c |2 +- board/LaCie/wireless_space/Makefile | 46 +++ board/LaCie/wireless_space/kwbimage.cfg | 82 board/LaCie/wireless_space/wireless_space.c | 176 board/Marvell/dreamplug/dreamplug.c |2 +- board/Marvell/guruplug/guruplug.c |2 +- board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c |2 +- board/Marvell/openrd/openrd.c |2 +- board/Marvell/rd6281a/rd6281a.c |2 +- board/Marvell/sheevaplug/sheevaplug.c |2 +- board/Seagate/dockstar/dockstar.c |2 +- board/buffalo/lsxl/lsxl.c |7 +- board/cloudengines/pogo_e02/pogo_e02.c |2 +- board/d-link/dns325/dns325.c|2 +- board/iomega/iconnect/iconnect.c|2 +- board/karo/tk71/tk71.c |2 +- board/keymile/common/common.c |2 +- board/keymile/km_arm/km_arm.c | 16 +- board/keymile/km_arm/kwbimage-memphis.cfg |6 +- board/keymile/km_arm/kwbimage.cfg |6 +- board/keymile/km_arm/kwbimage_128M16_1.cfg | 25 +- board/keymile/km_arm/kwbimage_256M8_1.cfg | 25 +- board/raidsonic/ib62x0/ib62x0.c |2 +- boards.cfg |1 + drivers/net/phy/mv88e61xx.c | 495 ++ drivers/net/phy/mv88e61xx.h | 39 ++- drivers/spi/kirkwood_spi.c | 12 +- include/configs/km/keymile-common.h |3 - include/configs/lsxl.h |2 +- include/configs/mv-common.h |2 +- include/configs/wireless_space.h| 194 + include/netdev.h| 21 +- 36 files changed, 896 insertions(+), 298 deletions(-) create mode 100644 board/LaCie/wireless_space/Makefile create mode 100644 board/LaCie/wireless_space/kwbimage.cfg create mode 100644 board/LaCie/wireless_space/wireless_space.c create mode 100644 include/configs/wireless_space.h Regards... Prafulla . . . From: Albert ARIBAUD [albert.u.b...@aribaud.net] Sent: Tuesday, January 08, 2013 8:33 PM To: Prafulla Wadaskar Cc: 'u-boot@lists.denx.de'; Ashish Karkare; Prabhanjan Sarnaik; 'Wolfgang Denk'; Andreas Bießmann Subject: Re: Pull request for u-boot-marvell.git Hi Prafulla, On Mon, 7 Jan 2013 04:26:09 -0800, Prafulla Wadaskar prafu...@marvell.com wrote: -Original Message- From: Albert ARIBAUD [mailto:albert.u.b...@aribaud.net] Sent: 23 December 2012 20:40 To: Prafulla Wadaskar Cc: 'u-boot@lists.denx.de'; Ashish Karkare; Prabhanjan Sarnaik; 'Wolfgang Denk'; Andreas Bießmann Subject: Re: Pull request for u-boot-marvell.git Hi Prafulla, On Thu, 20 Dec 2012 02:05:36 -0800, Prafulla Wadaskar prafu...@marvell.com wrote: Dear Albert Please discard my earlier pull request and please pull The following changes since commit b8a7c467960ffb4d5a5e1eef5f7783fb6f594542: Albert ARIBAUD (1): Merge branch 'u-boot-imx/master' into 'u-boot-arm/master' are available in the git repository at: u-boot-marvell.git master branch. Albert ARIBAUD (3): mv88e61xx: refactor PHY and SWITCH level-code kirkwood: make MPP arrays static const ARM: lacie_kw: add support for WIRELESS_SPACE Holger Brunck (3): arm/km: fix memory settings km/common: drop
[U-Boot] NAND flash - bad blocks
Hello, First of all sorry if this question was already answered here. We are sourcing some K9F8G08U0M-PIB0 NAND flash devices. On the first erase in uboot 2011.09 I got bunch of mostly consecutive bad blocks. According to the datasheet we should get not more then 80 bad blocks for our chip but I get something like 240 bad blocks for most of the NAND chips. I seems to be able to fix this using the following procedure: In uboot ubootnand scrub.chip In uboot ubootnand erase.chip clean at this point I get usually 1,2 bad blocks which looks normal to me. In Linux we have few mtd partitions on this NAND chip. Unmount all of them and for all of them : linuxnandtest -m /dev/mtdx Usually this doesn't add any new badblocks on top of what I get on nand erase in uboot, but I really haven't tested that much device to say. After this procedure the NAND flash seems to work fine. Do you think this is reliable way? Is there something better I can do? Has anyone got NAND component batch having more bad blocks then datasheet allows. Should we consider the provider unreliable? Thank you Dimitar ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
