[U-Boot] [PPC 74xx_7xx] Please pull u-boot-74xx-7xx.git
Dear Tom, The following changes since commit ca85eb8c4271509aaac1ccb26ae3eb1a7827b4e6: Merge branch 'master' of git://git.denx.de/u-boot-net (2013-06-24 22:27:44 -0400) are available in the git repository at: git://git.denx.de/u-boot-74xx-7xx.git master for you to fetch changes up to b8bfde7f0157c1266b23d71a5da81319302d9bb4: PPC 74xx_7xx: Fix build warnings for ELPPC board (2013-06-27 08:12:28 +0200) Wolfgang Denk (1): PPC 74xx_7xx: Fix build warnings for ELPPC board board/eltec/elppc/misc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The two most common things in the universe are hydrogen and stupi- dity. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] PPC 74xx_7xx: Fix build warnings for ELPPC board
Dear Wolfgang Denk, In message 1371198044-3456-1-git-send-email...@denx.de you wrote: Fix: misc.c: In function 'misc_init_r': misc.c:210:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] misc.c:211:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] misc.c:212:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] Signed-off-by: Wolfgang Denk w...@denx.de --- board/eltec/elppc/misc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de PUBLIC NOTICE AS REQUIRED BY LAW: Any Use of This Product, in Any Manner Whatsoever, Will Increase the Amount of Disorder in the Universe. Although No Liability Is Implied Herein, the Consumer Is Warned That This Process Will Ultimately Lead to the Heat Death of the Universe. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] PPC MPC83xx: Fix MPC8323ERDB build warning
Dear Kim,
ping!!
In message 1371198068-3581-1-git-send-email...@denx.de I wrote:
Fix:
mpc8323erdb.c: In function 'mac_read_from_eeprom':
mpc8323erdb.c:198:3: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
Signed-off-by: Wolfgang Denk w...@denx.de
cc: Michael Barkowski michael.barkow...@freescale.com
cc: Kim Phillips kim.phill...@freescale.com
---
board/freescale/mpc8323erdb/mpc8323erdb.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/board/freescale/mpc8323erdb/mpc8323erdb.c
b/board/freescale/mpc8323erdb/mpc8323erdb.c
index f29b2f4..533cb08 100644
--- a/board/freescale/mpc8323erdb/mpc8323erdb.c
+++ b/board/freescale/mpc8323erdb/mpc8323erdb.c
@@ -195,7 +195,11 @@ int mac_read_from_eeprom(void)
printf(\nEEPROM @ 0x%02x read FAILED!!!\n,
CONFIG_SYS_I2C_EEPROM_ADDR);
} else {
- if (crc32(crc, buf, 24) == *(unsigned int *)buf[24]) {
+ unsigned int crc_buf;
+
+ memcpy(crc_buf, buf[24], sizeof(unsigned int));
+
+ if (crc32(crc, buf, 24) == crc_buf) {
printf(Reading MAC from EEPROM\n);
for (i = 0; i 4; i++) {
if (memcmp(buf[i * 6], \0\0\0\0\0\0, 6)) {
--
1.7.11.7
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Einstein argued that there must be simplified explanations of nature,
because God is not capricious or arbitrary. No such faith comforts
the software engineer. - Fred Brooks, Jr.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/3] Add ethernet support for Congatec qmx6qeval
Hi Leo, On Thu, 20 Jun 2013 15:46:47 +0200, SARTRE Leo lsar...@adeneo-embedded.com wrote: Changes in v2: -micrel.c : drop two unneeded changes in comments. -cgtqmx6eval.c: #ifdef CONFIG_FEC_MXC now covers the whole function board_eth_init. -README : placed in a separate patch. Leo Sartre (3): PHY: micrel: helper function for KSZ9031 ARM: Congatec: Ethernet: Add support for cgtqmx6qeval ARM: Congatec: README update Please keep patch history in each patch of the series. Why is 3/3 separate from 2/3? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 03/12] image: Add RSA support for image signing
Hi Masahiro, On Wed, Jun 26, 2013 at 9:08 PM, Masahiro Yamada yamad...@jp.panasonic.comwrote: Hello, Simon. When compiling the master branch, I got an error while a tools/mkimage build. u-boot/lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory I think this erorr is caused by commit 19c402a. I searched and installed the necessary package and I could resolve this error. $ apt-file search openssl/rsa.h libssl-dev: /usr/include/openssl/rsa.h $ sudo apt-get install libssl-dev Let me ask a question. Going forward do we always need the openssl development package for creating mkimage tool? Or is it possible to disable RSA feature by some CONFIG option? This is to support verified boot using FIT. Yes it would be possible to make it an option. I had it that way for a while, but then I worried that it would create two versions of mkimage, one of which is incapable of signing images. That means that mkimage would need to be built for a board with verified boot enabled in order to get full functionality. Perhaps another way would be to check for the header and (if not present), silently build without signing support? Regards, Simon Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: omap5_uevm: Correct the console sys prompt for 5432
Hi Tom, On Mon, 24 Jun 2013 16:30:54 -0400, Tom Rini tr...@ti.com wrote: On Sat, Jun 22, 2013 at 11:33:11AM +0200, Albert ARIBAUD wrote: Hi Tom, On Tue, 11 Jun 2013 11:53:42 -0400, Tom Rini tr...@ti.com wrote: On Thu, Jun 06, 2013 at 04:30:38PM -0500, Dan Murphy wrote: Correct the console sys prompt to display the correct processor and the corrent board Signed-off-by: Dan Murphy dmur...@ti.com Reported-by: Lubomir Popov lpo...@mm-sol.com Reviewed-by: Tom Rini tr...@ti.com But personally, this is why I'm a fan of 'U-Boot # ' as the prompt :) I'd like it too if we could simply have all boards using the same prompt, but there might be some scripts out there which rely on the prompt being something else than U-Boot # ' or worse yet, using the prompt to determine which variant of the HW the scripts are dealing with. True. Looking ahead however, given device trees and the need to know what tree to request/load, I hope more boards will go with enabling CONFIG_ENV_VARS_UBOOT_CONFIG and can then use cpu/board/board_name as needed to determine those things at run-time. How about announcing (as in, letting the whole world know by slipping it in our public announcement of 2013.07) that custom prompts will be deprecated starting with 2013.10 and that targets still having them by 2014.01 will be retired? That's what we did for ARM ELF relocation IIRC. Of course, that would require a few round of e-mails to maintainers, at least to those whose targets' config header files still have custom prompts when reaching 2014.01-rc1; and there will be some yelling that such or such board has been dropped from U-Boot and why were users not told, etc. Alternatively, we could announce and deprecate in 2013.10 and remove all custom prompts in 2013.14 ourselves, then wait for annoyed people to yell at us, and advise them to enable CONFIG_ENV_VARS_UBOOT_CONFIG and uptate their scripts. Less prep work, slightly more yelling. We could even shift the schedule, deprecate for 2013.07 and remove in 2013.10. Same amount of work, yelling goes away earlier. My vote goes to this last proposal. :) Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] usb: add support for the USB Ethernet adapter D-Link DUB-E100 H/W Ver C1
This trivial patch adds the definition of the vid/pid for the Ver C1 of the
USB Ethernet adapter D-Link DUB-E100.
Signed-off-by: Pierre Aubert p.aub...@staubli.com
CC: Marek Vasut ma...@denx.de
---
drivers/usb/eth/asix.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/asix.c b/drivers/usb/eth/asix.c
index 76624b9..db39bd8 100644
--- a/drivers/usb/eth/asix.c
+++ b/drivers/usb/eth/asix.c
@@ -585,6 +585,7 @@ struct asix_dongle {
static const struct asix_dongle const asix_dongles[] = {
{ 0x05ac, 0x1402, FLAG_TYPE_AX88772 }, /* Apple USB Ethernet Adapter */
{ 0x07d1, 0x3c05, FLAG_TYPE_AX88772 }, /* D-Link DUB-E100 H/W Ver B1 */
+ { 0x2001, 0x1a02, FLAG_TYPE_AX88772 }, /* D-Link DUB-E100 H/W Ver C1 */
/* Cables-to-Go USB Ethernet Adapter */
{ 0x0b95, 0x772a, FLAG_TYPE_AX88772 },
{ 0x0b95, 0x7720, FLAG_TYPE_AX88772 }, /* Trendnet TU2-ET100 V3.0R */
--
1.7.6.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere
Hi Simon, On Mon, 24 Jun 2013 17:52:03 -0700, Simon Glass s...@chromium.org wrote: Hi Albert, On Sun, Jun 23, 2013 at 12:29 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon, On Mon, 17 Jun 2013 07:44:52 -0700, Simon Glass s...@chromium.org wrote: Note that a config_drop.h file is added - this defines all the CONFIGs which are not used in any board config file. Without this, autoconf cannot define the macros for this CONFIGs. Compile time for main.c does not seem to be any different in my tests. The time to perform the 'dep' step (which now creates autoconf.h) increases, from about 2.8s to about 4.6s. This additional time is used to grep, sed and sort the contents of all the header file in U-Boot. The time for an incremental build is not affected. It would be much more efficient to maintain a list of all available CONFIG defines, but no such list exists at present. Stop me if I am wrong, but do you not have this list already, since at one point you grep, sed and sort the whole list of config options, then at another point generate the list of unused ones? Well yes I create the list. But I don't 'have' it in the sense that it is a pre-existing file in the tree. My point was that if the file existed I would not need to create it in the build system. I asked about this at one point, and the comment was made that putting it in the source tree 'staticly' is risky, since someone might add a new option and it would not work. Perhaps when Kconfig is in there things will be different. Understod. Granted, that's the list of config options defined, not necessarily the list of options used, but a second variation of the grep/sed/sort might give you a hint on that. Plus, I would love having scripts in tools/ that look for either defined or used config options. With this series you kind-of get this feature - you can look at the files it creates along the way. What I meant is, this patch creates those lists with scripts. I'd like these scripts to be available to the developer in tools/ so that anyone can regenerate the lists (and do this only) at any time. Regards, Simon Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] vf610twr: Add default environment in line with other Freescale boards
Hi Otavio, hi Alison, On 26/06/2013 19:12, Otavio Salvador wrote: Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- both patches are slight changes - if I get an ACK by Alison as board maintainer, I could still push them before my PR for the release. Thanks, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v1 1/1] patman: README documentation nits
the -t flag appears to have a different meaning now, refer to the --test option for the builtin unit test, and adjust a directory location (it's 'tools/patman' instead of 'tools/scripts/patman') Signed-off-by: Gerhard Sittig g...@denx.de --- tools/patman/README |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/patman/README b/tools/patman/README index 8cffcd1..b26573a 100644 --- a/tools/patman/README +++ b/tools/patman/README @@ -452,12 +452,12 @@ Most of these are indicated by a TODO in the code. It would be nice if this could handle the In-reply-to side of things. -The tests are incomplete, as is customary. Use the -t flag to run them, +The tests are incomplete, as is customary. Use the --test flag to run them, and make sure you are in the tools/scripts/patman directory first: $ cd /path/to/u-boot -$ cd tools/scripts/patman -$ patman -t +$ cd tools/patman +$ patman --test Error handling doesn't always produce friendly error messages - e.g. putting an incorrect tag in a commit may provide a confusing message. -- 1.7.10.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere
Hi Albert, On Thu, Jun 27, 2013 at 12:04 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon, On Mon, 24 Jun 2013 17:52:03 -0700, Simon Glass s...@chromium.org wrote: Hi Albert, On Sun, Jun 23, 2013 at 12:29 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon, On Mon, 17 Jun 2013 07:44:52 -0700, Simon Glass s...@chromium.org wrote: Note that a config_drop.h file is added - this defines all the CONFIGs which are not used in any board config file. Without this, autoconf cannot define the macros for this CONFIGs. Compile time for main.c does not seem to be any different in my tests. The time to perform the 'dep' step (which now creates autoconf.h) increases, from about 2.8s to about 4.6s. This additional time is used to grep, sed and sort the contents of all the header file in U-Boot. The time for an incremental build is not affected. It would be much more efficient to maintain a list of all available CONFIG defines, but no such list exists at present. Stop me if I am wrong, but do you not have this list already, since at one point you grep, sed and sort the whole list of config options, then at another point generate the list of unused ones? Well yes I create the list. But I don't 'have' it in the sense that it is a pre-existing file in the tree. My point was that if the file existed I would not need to create it in the build system. I asked about this at one point, and the comment was made that putting it in the source tree 'staticly' is risky, since someone might add a new option and it would not work. Perhaps when Kconfig is in there things will be different. Understod. Granted, that's the list of config options defined, not necessarily the list of options used, but a second variation of the grep/sed/sort might give you a hint on that. Plus, I would love having scripts in tools/ that look for either defined or used config options. With this series you kind-of get this feature - you can look at the files it creates along the way. What I meant is, this patch creates those lists with scripts. I'd like these scripts to be available to the developer in tools/ so that anyone can regenerate the lists (and do this only) at any time. Yes, I figured that's what you were angling for. I will take a look. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/1] patman: README documentation nits
On Thu, Jun 27, 2013 at 12:12 AM, Gerhard Sittig g...@denx.de wrote: the -t flag appears to have a different meaning now, refer to the --test option for the builtin unit test, and adjust a directory location (it's 'tools/patman' instead of 'tools/scripts/patman') Signed-off-by: Gerhard Sittig g...@denx.de Acked-by: Simon Glass s...@chromium.org Thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/2] vf610twr: Add default environment in line with other Freescale boards
Hi, Otavio,
-Original Message-
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Wang Huan-B18965
Sent: Thursday, June 27, 2013 10:36 AM
To: Otavio Salvador; U-Boot Mailing List
Cc: Estevam Fabio-R49496
Subject: Re: [U-Boot] [PATCH v3 1/2] vf610twr: Add default environment
in line with other Freescale boards
-Original Message-
From: Otavio Salvador [mailto:otavio.salva...@gmail.com] On Behalf Of
Otavio Salvador
Sent: Thursday, June 27, 2013 2:31 AM
To: U-Boot Mailing List
Cc: Otavio Salvador; Stefano Babic; Estevam Fabio-R49496; Wang Huan-
B18965; Andy Voltz
Subject: [PATCH v3 1/2] vf610twr: Add default environment in line
with
other Freescale boards
This adds a default environment which should be able to support both
3.0.15 from Timesys and upcoming 3.11.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v3:
- add dt boot support
- use ttyLP1 as console
- change loadaddr and sys text as iMX6SL
- NOTE: It needs to be boot tested as I don't have the board
Changes in v2:
- fix console for ttymxc1 (Fabio)
include/configs/vf610twr.h | 93
--
1 file changed, 90 insertions(+), 3 deletions(-)
diff --git a/include/configs/vf610twr.h b/include/configs/vf610twr.h
index 77fe893..94c69a6 100644
--- a/include/configs/vf610twr.h
+++ b/include/configs/vf610twr.h
@@ -83,7 +83,95 @@
#define CONFIG_BOOTDELAY 3
-#define CONFIG_SYS_TEXT_BASE 0x3f008000
+#define CONFIG_LOADADDR0x8200
+#define CONFIG_SYS_TEXT_BASE 0x8780
[Alison Wang] Why do you change loadaddr and sys text base? After you
change the sys text base, the u-boot could not work.
The original sys text base is SRAM address, you change it to DDR
address. Here we should use SRAM address.
[Alison Wang] As there are large internal SRAM for VF610, the current u-boot
starts from internal SRAM instead of DDR. So in the current boot mechanism for
VF610, the sys text base should be SRAM address.
+
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ script=boot.scr\0 \
+ uimage=uImage\0 \
+ console=ttyLP1\0 \
+ fdt_high=0x\0 \
+ initrd_high=0x\0 \
+ fdt_file=vf610-twr.dtb\0 \
+ fdt_addr=0x8100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
+ mmcdev= __stringify(CONFIG_SYS_MMC_ENV_DEV) \0 \
+ mmcpart=1\0 \
+ mmcroot=/dev/mmcblk0p2 rootwait rw\0 \
+ update_sd_firmware_filename=u-boot.imx\0 \
+ update_sd_firmware= \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ if mmc dev ${mmcdev}; then\
+ if ${get_cmd} ${update_sd_firmware_filename}; then
\
+ setexpr fw_sz ${filesize} / 0x200; \
+ setexpr fw_sz ${fw_sz} + 1; \
+ mmc write ${loadaddr} 0x2 ${fw_sz}; \
+ fi; \
+ fi\0 \
+ mmcargs=setenv bootargs console=${console},${baudrate} \
+ root=${mmcroot}\0 \
+ loadbootscript= \
+ fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0
\
+ bootscript=echo Running bootscript from mmc ...; \
+ source\0 \
+ loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}
${fdt_file}\0 \
+ mmcboot=echo Booting from mmc ...; \
+ run mmcargs; \
+ if test ${boot_fdt} = yes || test ${boot_fdt} = try; then
\
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
+ netargs=setenv bootargs console=${console},${baudrate} \
+ root=/dev/nfs \
+ ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
+ netboot=echo Booting from net ...; \
+ run netargs; \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes || test ${boot_fdt} = try; then
\
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+
Re: [U-Boot] [PATCH 1/2] board/bsc9132qds: Add DSP side tlb and laws
Hi Jain, On Thu, 27 Jun 2013 03:59:16 +, Jain Priyanka-B32167 b32...@freescale.com wrote: Email-id is no longer valid as person has left the company. Git send-email was throwing error as it could not send message to that mail. (please do not top-post) Without an e-mail address, I suspect we cannot consider that person's Signed-off-by to be valid, if only because it does not identify a single individual any more. Regards Priyanka Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] vf610twr: Add default environment in line with other Freescale boards
Hi, stefano, I am ok with the default environment changes. But the sys text base should not be changed, otherwise the u-boot could not work. The reason I have explained in the other email. Best Regards, Alison Wang -Original Message- From: Stefano Babic [mailto:sba...@denx.de] Sent: Thursday, June 27, 2013 3:11 PM To: Otavio Salvador Cc: U-Boot Mailing List; Stefano Babic; Estevam Fabio-R49496; Wang Huan-B18965 Subject: Re: [PATCH v2 1/2] vf610twr: Add default environment in line with other Freescale boards Hi Otavio, hi Alison, On 26/06/2013 19:12, Otavio Salvador wrote: Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- both patches are slight changes - if I get an ACK by Alison as board maintainer, I could still push them before my PR for the release. Thanks, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] usb: fix unaligned access in device_qual()
while playing with dfu, I tapped in an unaligned access
when doing on the host side a lsusb -d [vendornr]: -v
I get on the board:
GADGET DRIVER: usb_dnl_dfu
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [8ff71db8] lr : [8ff75aec]
sp : 8ef40d18 ip : 0005 fp :
r10: r9 : 47401410 r8 : 8ef40f38
r7 : 8ef4aae8 r6 : 000a r5 : 8ef4ab28 r4 : 8ef4ab80
r3 : 000a r2 : 0006 r1 : 0006 r0 : 8ef4aae8
Flags: Nzcv IRQs off FIQs on Mode SVC_32
Resetting CPU ...
reason is that in the struct usb_composite_dev the
struct usb_device_descriptor desc; is on an odd address,
and this struct gets accessed in
drivers/usb/gadget/composite.c device_qual()
Fix it, by align this var struct desc fix to an aligned
address.
Signed-off-by: Heiko Schocher h...@denx.de
Cc: Marek Vasut marek.va...@gmail.com
Cc: Samuel Egli samuel.e...@siemens.com
---
include/linux/usb/composite.h | 2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/include/linux/usb/composite.h b/include/linux/usb/composite.h
index 53cb095..4f76f88 100644
--- a/include/linux/usb/composite.h
+++ b/include/linux/usb/composite.h
@@ -331,7 +331,7 @@ struct usb_composite_dev {
/* private: */
/* internals */
unsigned intsuspended:1;
- struct usb_device_descriptordesc;
+ struct usb_device_descriptor __aligned(CONFIG_SYS_CACHELINE_SIZE) desc;
struct list_headconfigs;
struct usb_composite_driver *driver;
u8 next_string_id;
--
1.7.11.7
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] board/bsc9132qds: Add DSP side tlb and laws
On Thu, Jun 27, 2013 at 1:21 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Jain, On Thu, 27 Jun 2013 03:59:16 +, Jain Priyanka-B32167 b32...@freescale.com wrote: Email-id is no longer valid as person has left the company. Git send-email was throwing error as it could not send message to that mail. (please do not top-post) Without an e-mail address, I suspect we cannot consider that person's Signed-off-by to be valid, if only because it does not identify a single individual any more. Yes that's rite! alternatively you can just mention his name in the commit message(with _NO_ signed-of). Regards, --Prabhakar Lad ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 1/3] arm: spl: Fix SPL booting for OMAP3
Hi Stefan, On Tue, 25 Jun 2013 09:14:12 +0200, Stefan Roese s...@denx.de wrote: Fix a problem with a re-assignment of r8 in the SPL version. This patch now moves the call to s_init() to a later stage, right before calling board_init_f(). And makes sure that r8 is correctly initialized before s_init() is called. r8 now is only written in crt0.S. This error was detected on the SPL port for the Compulab CM-T35 board (OMAP3530). Signed-off-by: Stefan Roese s...@denx.de Cc: Tom Rini tr...@ti.com Cc: Albert ARIBAUD albert.u.b...@aribaud.net --- Albert, I'm not really happy with this patch as it evolves now. As you will see, I had to make some further additions to crt0.S to fix a problem for non-SPL builds and to fix compilation errors for non-OMAP platforms. This gets quite ugly now. Looking back at my patch v1, this looks much less intrusive. What do you think? I said the first patch was NAK, and the reasons I NAKed it remain. However, there might be another solution: instead of squeezing the call to s_init() in crt0.S right between the initial environment setting and the call to board_init_f(), we could simply move the s_init() call inside board_init_f(). From a running conditions perspective, the only change would be that s_init() is going to run from a non-empty stack, but we know that there is free stack enough during board_init_f() to call functions. Moving the call to s_init() into board_init_f() removes any changes to crt0.S, which were my essential NAK reason and saves you some ugliness. I would even hazard that you could place s_init in init_sequence[], for instance as a first entry to be called (before arch_cpu_init). After all, the only difference in execution is that gdata is going to be initialized properly before s_init() kicks in. Also, a name change would be in order, because s_init() as a private OMAP function is ok, but as an init function invoked from board_init_f() it needs a more meaningful name. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] PHY support for marvell 88E1111 chip
Hi, I found a comment on blackvme board file saying that The ax88180 driver had to be patched to work around a bug in Marvell 88E B2 silicon. I am using uboot 2013.01 version. I am working on the custom board using the Marvell 88E phy connected to PPC440Gx processor and I am using emac2 (RGMII). What is the work around need to do or is there any patch to make this Marvell 88E phy working. Best Regards, Sadashiv ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] p1020rdb-pd: platform support
From: Haijun.Zhang haijun.zh...@freescale.com
Signed-off-by: Jerry Huang chang-ming.hu...@freescale.com
Signed-off-by: Haijun Zhang haijun.zh...@freescale.com
CC: Scott Wood scottw...@freescale.com
CC: Sun Yusong-R58495 york...@freescale.com
---
board/freescale/p1_p2_rdb_pc/ddr.c | 2 +-
board/freescale/p1_p2_rdb_pc/tlb.c | 2 +-
boards.cfg | 4
include/configs/p1_p2_rdb_pc.h | 48 --
4 files changed, 52 insertions(+), 4 deletions(-)
diff --git a/board/freescale/p1_p2_rdb_pc/ddr.c
b/board/freescale/p1_p2_rdb_pc/ddr.c
index 9355536..262fd36 100644
--- a/board/freescale/p1_p2_rdb_pc/ddr.c
+++ b/board/freescale/p1_p2_rdb_pc/ddr.c
@@ -80,7 +80,7 @@ dimm_params_t ddr_raw_timing = {
.refresh_rate_ps = 780,
.tFAW_ps = 3,
};
-#elif defined(CONFIG_P1020MBG)
+#elif (defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD))
/* Micron MT41J512M8_187E */
dimm_params_t ddr_raw_timing = {
.n_ranks = 2,
diff --git a/board/freescale/p1_p2_rdb_pc/tlb.c
b/board/freescale/p1_p2_rdb_pc/tlb.c
index 3e4dffd..e19002f 100644
--- a/board/freescale/p1_p2_rdb_pc/tlb.c
+++ b/board/freescale/p1_p2_rdb_pc/tlb.c
@@ -110,7 +110,7 @@ struct fsl_e_tlb_entry tlb_table[] = {
MAS3_SX|MAS3_SW|MAS3_SR, 0,
0, 8, BOOKE_PAGESZ_1G, 1),
-#ifdef CONFIG_P1020MBG
+#if defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD)
/* 2G DDR on P1020MBG, map the second 1G */
SET_TLB_ENTRY(1, CONFIG_SYS_DDR_SDRAM_BASE + 0x4000,
CONFIG_SYS_DDR_SDRAM_BASE + 0x4000,
diff --git a/boards.cfg b/boards.cfg
index 35f38f3..aefff92 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -768,6 +768,10 @@ P1020RDB-PC_SDCARD powerpc mpc85xx
p1_p2_rdb_pcfreesca
P1020RDB-PC_SPIFLASH powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020RDB,SPIFLASH
P1020RDB_SDCARD powerpc mpc85xx p1_p2_rdb
freescale - P1_P2_RDB:P1020RDB,SDCARD
P1020RDB_SPIFLASHpowerpc mpc85xx p1_p2_rdb
freescale - P1_P2_RDB:P1020RDB,SPIFLASH
+P1020RDB-PD powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020RDB_PD
+P1020RDB-PD_NAND powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020RDB_PD,NAND
+P1020RDB-PD_SDCARD powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020RDB_PD,SDCARD
+P1020RDB-PD_SPIFLASH powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020RDB_PD,SPIFLASH
P1020UTM-PC powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020UTM
P1020UTM-PC_36BITpowerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020UTM,36BIT
P1020UTM-PC_36BIT_SDCARD powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020UTM,36BIT,SDCARD
diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h
index 964bfcd..36aad8c 100644
--- a/include/configs/p1_p2_rdb_pc.h
+++ b/include/configs/p1_p2_rdb_pc.h
@@ -66,6 +66,35 @@
#define CONFIG_SYS_L2_SIZE (256 10)
#endif
+/*
+ * P1020RDB-PD board has user selectable switches for evaluating different
+ * frequency and boot options for the P1020 device. The table that
+ * follow describe the available options. The front six binary number was in
+ * accordance with SW3[1:6].
+ * 01 533 533 267 667 NOR Core0 boot; Core1 hold-off
+ * 101101 667 667 333 667 NOR Core0 boot; Core1 hold-off
+ * 011001 800 800 400 667 NOR Core0 boot; Core1 hold-off
+ * 001001 800 800 400 667 SD/MMC Core0 boot; Core1 hold-off
+ * 001101 800 800 400 667 SPI Core0 boot; Core1 hold-off
+ * 010001 800 800 400 667 NAND Core0 boot; Core1 hold-off
+ * 011101 800 800 400 667 PCIe-2 Core0 boot; Core1 hold-off
+ */
+#if defined(CONFIG_P1020RDB_PD)
+#define CONFIG_BOARDNAME P1020RDB-PD
+#define CONFIG_NAND_FSL_ELBC
+#define CONFIG_P1020
+#define CONFIG_SPI_FLASH
+#define CONFIG_VSC7385_ENET
+#define CONFIG_SLIC
+#define __SW_BOOT_MASK 0x03
+#define __SW_BOOT_NOR 0x64
+#define __SW_BOOT_SPI 0x34
+#define __SW_BOOT_SD 0x24
+#define __SW_BOOT_NAND 0x44
+#define __SW_BOOT_PCIE 0x74
+#define CONFIG_SYS_L2_SIZE (256 10)
+#endif
+
#if defined(CONFIG_P1021RDB)
#define CONFIG_BOARDNAME P1021RDB-PC
#define CONFIG_NAND_FSL_ELBC
@@ -274,7 +303,7 @@
#define SPD_EEPROM_ADDRESS 0x52
#undef CONFIG_FSL_DDR_INTERACTIVE
-#ifdef CONFIG_P1020MBG
+#if (defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD))
#define CONFIG_SYS_SDRAM_SIZE_LAW LAW_SIZE_2G
#define CONFIG_CHIP_SELECTS_PER_CTRL 2
#else
@@ -345,7 +374,7 @@
/*
* Local Bus Definitions
*/
-#if
Re: [U-Boot] [PATCH v2 1/2] vf610twr: Add default environment in line with other Freescale boards
Hi Alison, On 27/06/2013 10:00, Wang Huan-B18965 wrote: Hi, stefano, I am ok with the default environment changes. But the sys text base should not be changed, otherwise the u-boot could not work. The reason I have explained in the other email. Of course, and I will not apply the patches until there are open comments. Regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Hi, Scott Sorry to reply to so late. Pls see my reply below. Regards Thanks Haijun. -Original Message- From: Wood Scott-B07421 Sent: Wednesday, May 22, 2013 6:24 AM To: Zhang Haijun-B42677 Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote: From: Haijun.Zhang haijun.zh...@freescale.com Add platform support for p1020rdb-pd Explain what is different about -pd and why this new revision requires a separate compile-time target. [Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on. They are all supported. Nand, DDR, Nor and Spi Flash are different between them. So I thinks they should be two separate board as P1020UTM and P1020MBG do. If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime? [Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file. If it's due to different NAND page size, that will no longer be an issue once this is applied: http://patchwork.ozlabs.org/patch/223436/ +#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD)) #if defined(CONFIG_P1020RDB) #define CONFIG_BOARDNAME P1020RDB-PC +#elif defined(CONFIG_P1020RDB_PD) +#define CONFIG_BOARDNAME P1020RDB-PD +#endif CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] SMDK5250: Remove reduntant code
Hi Minkyu, Please do let me know your coments on the same. If no comments can we get this patch merged. On Tue, Jun 25, 2013 at 7:25 PM, Simon Glass s...@chromium.org wrote: On Tue, Jun 25, 2013 at 6:47 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: enum boot_mode is defined twice once in spl.h and also in spl_boot.c, hence removing the same from spl_boot.c and including the header file. Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com Acked-by: Simon Glass s...@chromium.org ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Regards, Rajeshwari Shinde ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] OpenRD: relocate environment to 640kB
Hi Sascha, On Tue, 25 Jun 2013 11:42:53 +0200, Sascha Silbe t-ub...@infra-silbe.de wrote: Hello Albert, hello Tom, Albert ARIBAUD albert.u.b...@aribaud.net writes: [Move environment to account for increase in U-Boot size] This patch is for 2013.10, not 2013.07, but I prefer raising the issue as early as possible. If there is no way to make things smoother, then I think the 2013.10 release notes should contain a red, blinking, paragraph about this. I would *hate* it if people were not warned and given a method to port their current environment setting over. Possibly even, the 2013.07 could have a warning about the change to come, so that people have a better chance yet to prepare for the change. The situation has gotten better recently and U-Boot fits into the previous partition size of 384KiB again. So it isn't broken on OpenRD anymore and the above would seem like a good approach. How well does it fit again, and do you have any idea what caused the increase in size, and what caused the decrease? Where are the U-Boot Release Notes located? Who is responsible for editing them? Sascha Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 2/2] config: Tegra: Improve TFTP booting performance
Add CONFIG_USBKB_TESTC_PERIOD configuration if CONFIG_USB_KEYBOARD is defined in platform configuration file. Signed-off-by: Jim Lin ji...@nvidia.com --- Changes in v2: - None Changes in v3: - Add CONFIG_USBKB_TESTC_PERIOD in include/configs/tegra-common-post.h include/configs/tegra-common-post.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/configs/tegra-common-post.h b/include/configs/tegra-common-post.h index 6ed2fde..ee341ef 100644 --- a/include/configs/tegra-common-post.h +++ b/include/configs/tegra-common-post.h @@ -128,6 +128,7 @@ #ifdef CONFIG_USB_KEYBOARD #define STDIN_KBD_USB ,usbkbd #define CONFIG_SYS_USB_EVENT_POLL +#define CONFIG_USBKB_TESTC_PERIOD 100 #define CONFIG_PREBOOT usb start #else #define STDIN_KBD_USB -- 1.7.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 1/2] console: usbkbd: Improve TFTP booting performance
TFTP booting is observed a little bit slow, especially when a USB
keyboard is installed.
The fix is to move polling to every second if we sense that other task
like TFTP boot is running.
Signed-off-by: Jim Lin ji...@nvidia.com
---
Changes in v2:
1. Change configuration name from CONFIG_CTRLC_POLL_MS to CONFIG_CTRLC_POLL_S.
2. New code will be executed only when CONFIG_CTRLC_POLL_S is defined in
configuration header file.
3. Add description in README.console.
Changes in v3:
1. Move changes to common/usb_kbd.c and doc/README.usb
2. Rename config setting to CONFIG_USBKB_TESTC_PERIOD.
3. Remove slow response on USB-keyboard input when TFTP boot is not running.
common/usb_kbd.c | 20
doc/README.usb | 15 ++-
2 files changed, 34 insertions(+), 1 deletions(-)
diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index 3174b5e..25bf677 100644
--- a/common/usb_kbd.c
+++ b/common/usb_kbd.c
@@ -121,6 +121,11 @@ struct usb_kbd_pdata {
uint8_t flags;
};
+#ifdef CONFIG_USBKB_TESTC_PERIOD
+/* The period of time between two calls of usb_kbd_testc(). */
+static unsigned long kbd_testc_tms;
+#endif
+
/* Generic keyboard event polling. */
void usb_kbd_generic_poll(void)
{
@@ -366,6 +371,21 @@ static int usb_kbd_testc(void)
struct usb_device *usb_kbd_dev;
struct usb_kbd_pdata *data;
+#ifdef CONFIG_USBKB_TESTC_PERIOD
+ /*
+* T is the time between two calls of usb_kbd_testc().
+* If CONFIG_USBKB_TESTC_PERIOD ms T 1000 ms,
+* it implies other task like TFTP boot is running,
+* then we reduce polling to every second
+* to improve TFTP booting performance.
+*/
+ if ((get_timer(kbd_testc_tms) =
+ (CONFIG_USBKB_TESTC_PERIOD * CONFIG_SYS_HZ / 1000))
+ (get_timer(kbd_testc_tms) CONFIG_SYS_HZ))
+ return 0;
+ else
+ kbd_testc_tms = get_timer(0);
+#endif
dev = stdio_get_by_name(DEVNAME);
usb_kbd_dev = (struct usb_device *)dev-priv;
data = usb_kbd_dev-privptr;
diff --git a/doc/README.usb b/doc/README.usb
index b4c3ef5..ff4ee6f 100644
--- a/doc/README.usb
+++ b/doc/README.usb
@@ -80,7 +80,20 @@ CONFIG_USB_UHCI defines the lowlevel part.A
lowlevel part must be defined
CONFIG_USB_KEYBOARD enables the USB Keyboard
CONFIG_USB_STORAGE enables the USB storage devices
CONFIG_USB_HOST_ETHER enables USB ethernet adapter support
-
+CONFIG_USBKB_TESTC_PERIOD defines the average time (in ms) between two calls
+ of usb_kbd_testc() when TFTP boot is not running
+ In u-boot console, usb_kbd_testc() will be called
+ periodically.
+ When this configuration is defined and other task like
+ TFTP boot is running, USB keyboard will be polled less
+ frequently and will be polled every second.
+ This is to improve TFTP booting performance when USB
+ keyboard is installed.
+ In u-boot console, no impact on keyboard input if TFTP
+ boot is not running.
+ Example:
+ Define the following in configuration header file
+ #define CONFIG_USBKB_TESTC_PERIOD 100
USB Host Networking
===
--
1.7.7
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/2] Optimized nand_read_buf for kirkwood
Hi Phil,
On Wed, 26 Jun 2013 20:25:25 +0200, Phil Sutter
phil.sut...@viprinet.com wrote:
The basic idea is taken from the linux-kernel, but further optimized.
First align the buffer to 8 bytes, then use ldrd/strd to read and store
in 8 byte quantities, then do the final bytes.
Tested using: 'date ; nand read.raw 0xE0 0x0 0x1 ; date'.
Without this patch, NAND read of 132MB took 49s (~2.69MB/s). With this
patch in place, reading the same amount of data was done in 27s
(~4.89MB/s). So read performance is increased by ~80%!
Signed-off-by: Nico Erfurth n...@erfurth.eu
Tested-by: Phil Sutter phil.sut...@viprinet.com
Cc: Prafulla Wadaskar prafu...@marvell.com
---
Patch history missing.
drivers/mtd/nand/kirkwood_nand.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/mtd/nand/kirkwood_nand.c
b/drivers/mtd/nand/kirkwood_nand.c
index 0a99a10..85ea5d2 100644
--- a/drivers/mtd/nand/kirkwood_nand.c
+++ b/drivers/mtd/nand/kirkwood_nand.c
@@ -38,6 +38,37 @@ struct kwnandf_registers {
static struct kwnandf_registers *nf_reg =
(struct kwnandf_registers *)KW_NANDF_BASE;
+
+/*
+ * The basic idea is stolen from the linux kernel, but the inner loop is
+ * optimized a bit more.
+ */
+static void kw_nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
+{
+ struct nand_chip *chip = mtd-priv;
+
+ while (len (unsigned long)buf 7) {
+ *buf++ = readb(chip-IO_ADDR_R);
+ len--;
+ };
+
+ /* This loop reads and writes 64bit per round. */
+ asm volatile (
+ 1:\n
+ subs %0, #8\n
+ ldrpld r2, [%2]\n
+ strpld r2, [%1], #8\n
+ bhi1b\n
+ addne %0, #8\n
+ : +r (len), +r (buf)
+ : r (chip-IO_ADDR_R)
+ : r2, r3, memory, cc
+ );
Are assembler instructions *really* required? IOW, can you not get
enough performance simply with a cleverly written C loop?
+ while (len--)
+ *buf++ = readb(chip-IO_ADDR_R);
+}
+
/*
* hardware specific access to control-lines/bits
*/
@@ -80,6 +111,7 @@ int board_nand_init(struct nand_chip *nand)
nand-ecc.mode = NAND_ECC_SOFT;
#endif
nand-cmd_ctrl = kw_nand_hwcontrol;
+ nand-read_buf = kw_nand_read_buf;
nand-chip_delay = 40;
nand-select_chip = kw_nand_select_chip;
return 0;
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command
Hi, Fleming and Fabio Sorry to reply to you so late. As our manual described. In the eSDHC, the data buffer can hold up to 128 words (32-bit). The watermark levels for both write and read can be configured for CPU polling mode. The watermark level can be from 1 word to the maximum of 128 words. For both DMA read and write, the burst length, can be configured from 1 to the maximum of 16. The host driver may configure watermark level and burst length value according to the system situation and requirement in the watermark level register (WML). So if we define CONFIG_SYS_FSL_ESDHC_USE_PIO, this should be needed for CPU Polling mode. My patch works well on my board both for DMA mod and CPU Polling mode. Since commit 48e0b2bd (powerpc/esdhc: Correct judgement for DATA PIO mode) we see mx6 systems to hang after doing a 'save' command. Fabio, Did you boot up from sdcard? If so save command will write to SD card. In this case write command will be failed. I'm not familiar with mx6 system. I don't know if there are some difference in Watermark Level Register (eSDHC_WML). Regards Haijun. -Original Message- From: Fleming Andy-AFLEMING Sent: Wednesday, May 29, 2013 3:52 AM To: Estevam Fabio-R49496 Cc: Zhang Haijun-B42677; w...@denx.de; u-boot@lists.denx.de; sba...@denx.de; tap...@technexion.com Subject: Re: [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command On May 28, 2013, at 1:09 PM, Fabio Estevam wrote: Since commit 48e0b2bd (powerpc/esdhc: Correct judgement for DATA PIO mode) we see mx6 systems to hang after doing a 'save' command. Revert this commit since the original 'ifdef' logic from 7b43db92 (drivers/mmc/fsl_esdhc.c: fix compiler warnings) was the correct one. Reported-by: Tapani Utriainen tap...@technexion.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com My apologies. I misread that patch. I found it hard to believe that Wolfgang had broken the logic, and that it had been broken for 2 years, but somehow my brain insisted that was the case. I now agree with your assessment, and will apply your patch. Haijun, please investigate the problem you were trying to solve with this patch, and determine what the actual cause was, and then submit a new patch to fix it. Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] board/bsc9132qds: Add DSP side tlb and laws
Hi Prabhakar, On Thu, 27 Jun 2013 13:36:16 +0530, Prabhakar Lad prabhakar.cse...@gmail.com wrote: On Thu, Jun 27, 2013 at 1:21 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Jain, On Thu, 27 Jun 2013 03:59:16 +, Jain Priyanka-B32167 b32...@freescale.com wrote: Email-id is no longer valid as person has left the company. Git send-email was throwing error as it could not send message to that mail. (please do not top-post) Without an e-mail address, I suspect we cannot consider that person's Signed-off-by to be valid, if only because it does not identify a single individual any more. Yes that's rite! alternatively you can just mention his name in the commit message(with _NO_ signed-of). Note however that we *do* need a signed-off-by line. Regards, --Prabhakar Lad Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] fs/ext4: caculate log2blksz from blksz, other its value = 0
From: Lan Yixun (dlan) dennis.y...@gmail.com err: lt703a # ext4ls nand 3:0 Failed to mount ext2 filesystem... ** Unrecognized filesystem type ** bug may introduced by commit: commit 50ce4c07df1c98aabf4630b35152ed95a87242f7 Author: Egbert Eich e...@suse.com Date: Wed May 1 01:13:19 2013 + fs/ext4: Support device block sizes != 512 bytes Signed-off-by: Lan Yixun (dlan) dennis.y...@gmail.com --- disk/part.c | 4 1 file changed, 4 insertions(+) diff --git a/disk/part.c b/disk/part.c index fc8404d..dbc94c4 100644 --- a/disk/part.c +++ b/disk/part.c @@ -551,6 +551,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, goto cleanup; } + (*dev_desc)-log2blksz = LOG2((*dev_desc)-blksz); + info-start = 0; info-size = (*dev_desc)-lba; info-blksz = (*dev_desc)-blksz; @@ -634,6 +636,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, goto cleanup; } + (*dev_desc)-log2blksz = LOG2((*dev_desc)-blksz); + ret = part; goto cleanup; -- 1.8.2.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Hi Heiko,
On Thu, 27 Jun 2013 10:04:57 +0200, Heiko Schocher h...@denx.de wrote:
while playing with dfu, I tapped in an unaligned access
when doing on the host side a lsusb -d [vendornr]: -v
I get on the board:
GADGET DRIVER: usb_dnl_dfu
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [8ff71db8] lr : [8ff75aec]
sp : 8ef40d18 ip : 0005 fp :
r10: r9 : 47401410 r8 : 8ef40f38
r7 : 8ef4aae8 r6 : 000a r5 : 8ef4ab28 r4 : 8ef4ab80
r3 : 000a r2 : 0006 r1 : 0006 r0 : 8ef4aae8
Flags: Nzcv IRQs off FIQs on Mode SVC_32
Resetting CPU ...
reason is that in the struct usb_composite_dev the
struct usb_device_descriptor desc; is on an odd address,
and this struct gets accessed in
drivers/usb/gadget/composite.c device_qual()
Fix it, by align this var struct desc fix to an aligned
address.
Please keep the commit message to a minimum -- what is wrong and how it
is fixed -- and move the rest (context and additional details) after
the commit message separator ('---' below).
Signed-off-by: Heiko Schocher h...@denx.de
Cc: Marek Vasut marek.va...@gmail.com
Cc: Samuel Egli samuel.e...@siemens.com
---
include/linux/usb/composite.h | 2 +-
1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/include/linux/usb/composite.h b/include/linux/usb/composite.h
index 53cb095..4f76f88 100644
--- a/include/linux/usb/composite.h
+++ b/include/linux/usb/composite.h
@@ -331,7 +331,7 @@ struct usb_composite_dev {
/* private: */
/* internals */
unsigned intsuspended:1;
- struct usb_device_descriptordesc;
+ struct usb_device_descriptor __aligned(CONFIG_SYS_CACHELINE_SIZE) desc;
struct list_headconfigs;
struct usb_composite_driver *driver;
u8 next_string_id;
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fs/ext4: caculate log2blksz from blksz, other its value = 0
Hi Lan, On Thu, 27 Jun 2013 17:42:31 +0800, Lan Yixun (dlan) dennis.y...@gmail.com wrote: From: Lan Yixun (dlan) dennis.y...@gmail.com err: lt703a # ext4ls nand 3:0 Failed to mount ext2 filesystem... ** Unrecognized filesystem type ** bug may introduced by commit: commit 50ce4c07df1c98aabf4630b35152ed95a87242f7 Author: Egbert Eich e...@suse.com Date: Wed May 1 01:13:19 2013 + fs/ext4: Support device block sizes != 512 bytes Please make the commit summary a description of what is wrong and how it is fixed, and move the context (how the bug was found, console output, etc) after the commit message separator '---' below. Also, fix probably typo in the commit summary (first commit message line) (other for otherwise). Signed-off-by: Lan Yixun (dlan) dennis.y...@gmail.com --- disk/part.c | 4 1 file changed, 4 insertions(+) diff --git a/disk/part.c b/disk/part.c index fc8404d..dbc94c4 100644 --- a/disk/part.c +++ b/disk/part.c @@ -551,6 +551,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, goto cleanup; } + (*dev_desc)-log2blksz = LOG2((*dev_desc)-blksz); + info-start = 0; info-size = (*dev_desc)-lba; info-blksz = (*dev_desc)-blksz; @@ -634,6 +636,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, goto cleanup; } + (*dev_desc)-log2blksz = LOG2((*dev_desc)-blksz); + ret = part; goto cleanup; Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Hi Albert,
On 06/27/2013 12:11 PM, Albert ARIBAUD wrote:
while playing with dfu, I tapped in an unaligned access
when doing on the host side a lsusb -d [vendornr]: -v
I get on the board:
GADGET DRIVER: usb_dnl_dfu
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [8ff71db8] lr : [8ff75aec]
sp : 8ef40d18 ip : 0005 fp :
r10: r9 : 47401410 r8 : 8ef40f38
r7 : 8ef4aae8 r6 : 000a r5 : 8ef4ab28 r4 : 8ef4ab80
r3 : 000a r2 : 0006 r1 : 0006 r0 : 8ef4aae8
Flags: Nzcv IRQs off FIQs on Mode SVC_32
Resetting CPU ...
reason is that in the struct usb_composite_dev the
struct usb_device_descriptor desc; is on an odd address,
and this struct gets accessed in
drivers/usb/gadget/composite.c device_qual()
Fix it, by align this var struct desc fix to an aligned
address.
Please keep the commit message to a minimum -- what is wrong and how it
is fixed -- and move the rest (context and additional details) after
the commit message separator ('---' below).
I personally find this expanded description quite helpful. Everything
below the --- line is removed from the git history. So +1 for this
expanded description from me.
Thanks,
Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] common: remove unaligned access error in bootmenu_getoption()
From: Lan Yixun (dlan) dennis.y...@gmail.com
Some ARM compilers may emit code that makes unaligned accesses when
faced with constructs such as:
char name[12] = bootmenu_;
same fix as commit: 064d55f8bc8d7d205ed0be6abb6717e92eeb7cad
=
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [3ff4b60c] lr : [3ff4b7b0]
sp : 3f346a58 ip : 3ff9c8e6 fp : 0260
r10: r9 : 3df47fc0 r8 : 3f347f40
r7 : r6 : r5 : 0003 r4 : 3f759140
r3 : 03f0 r2 : r1 : 03f1 r0 :
Flags: nzCv IRQs on FIQs off Mode SVC_32
Resetting CPU ...
==
Signed-off-by: Lan Yixun (dlan) dennis.y...@gmail.com
---
common/cmd_bootmenu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cmd_bootmenu.c b/common/cmd_bootmenu.c
index 7041273..d414c17 100644
--- a/common/cmd_bootmenu.c
+++ b/common/cmd_bootmenu.c
@@ -65,12 +65,12 @@ enum bootmenu_key {
static char *bootmenu_getoption(unsigned short int n)
{
- char name[MAX_ENV_SIZE] = bootmenu_;
+ char name[MAX_ENV_SIZE];
if (n MAX_COUNT)
return NULL;
- sprintf(name + 9, %d, n);
+ sprintf(name, bootmenu_%d, n);
return getenv(name);
}
--
1.8.2.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-Boot build issue
Dear Wolfgang Denk, [...] OUT-OF-TREE BUILD: powerpc___a3m071 eldk5.2 Configuring for a3m071 board... make[1]: *** [/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/spl/arch/powerpc/cpu/mpc5xxx/libmpc5xxx.o] Error 2 make: *** [/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/spl/u- boot-spl.bin] Error 2 textdata bss dec hex filename 69 12004 27744 373117 5b17d /opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/u- boot make[2]: *** No rule to make target `/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/de', needed by `/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/spl/arch/powerpc/cpu/mpc5xxx/cpu_init.o'. Stop. make[2]: *** Waiting for unfinished jobs make[1]: *** [/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/spl/arch/powerpc/cpu/mpc5xxx/libmpc5xxx.o] Error 2 make[1]: *** Waiting for unfinished jobs make: *** [/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/spl/u- boot-spl.bin] Error 2 - SUMMARY Boards compiled: 1 Boards with errors: 1 ( a3m071 ) -- ELDK 5.2 , powerpc board ... notice the path is again trimmed . Ok, this seems to be enough proof something is not right. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Dear Stefan Roese,
Hi Albert,
On 06/27/2013 12:11 PM, Albert ARIBAUD wrote:
while playing with dfu, I tapped in an unaligned access
when doing on the host side a lsusb -d [vendornr]: -v
I get on the board:
GADGET DRIVER: usb_dnl_dfu
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [8ff71db8] lr : [8ff75aec]
sp : 8ef40d18 ip : 0005 fp :
r10: r9 : 47401410 r8 : 8ef40f38
r7 : 8ef4aae8 r6 : 000a r5 : 8ef4ab28 r4 : 8ef4ab80
r3 : 000a r2 : 0006 r1 : 0006 r0 : 8ef4aae8
Flags: Nzcv IRQs off FIQs on Mode SVC_32
Resetting CPU ...
reason is that in the struct usb_composite_dev the
struct usb_device_descriptor desc; is on an odd address,
and this struct gets accessed in
drivers/usb/gadget/composite.c device_qual()
Fix it, by align this var struct desc fix to an aligned
address.
Please keep the commit message to a minimum -- what is wrong and how it
is fixed -- and move the rest (context and additional details) after
the commit message separator ('---' below).
I personally find this expanded description quite helpful. Everything
below the --- line is removed from the git history. So +1 for this
expanded description from me.
Agreed
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Dear Heiko Schocher, while playing with dfu, I tapped in an unaligned access when doing on the host side a lsusb -d [vendornr]: -v I get on the board: Applied, thanks btw you can send this stuff to my @denx address, it's much more convenient for me. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: add support for the USB Ethernet adapter D-Link DUB-E100 H/W Ver C1
Dear Pierre Aubert,
This trivial patch adds the definition of the vid/pid for the Ver C1 of the
USB Ethernet adapter D-Link DUB-E100.
Signed-off-by: Pierre Aubert p.aub...@staubli.com
CC: Marek Vasut ma...@denx.de
---
drivers/usb/eth/asix.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/asix.c b/drivers/usb/eth/asix.c
index 76624b9..db39bd8 100644
--- a/drivers/usb/eth/asix.c
+++ b/drivers/usb/eth/asix.c
@@ -585,6 +585,7 @@ struct asix_dongle {
static const struct asix_dongle const asix_dongles[] = {
{ 0x05ac, 0x1402, FLAG_TYPE_AX88772 }, /* Apple USB Ethernet Adapter */
{ 0x07d1, 0x3c05, FLAG_TYPE_AX88772 }, /* D-Link DUB-E100 H/W Ver B1 */
+ { 0x2001, 0x1a02, FLAG_TYPE_AX88772 }, /* D-Link DUB-E100 H/W Ver C1 */
/* Cables-to-Go USB Ethernet Adapter */
{ 0x0b95, 0x772a, FLAG_TYPE_AX88772 },
{ 0x0b95, 0x7720, FLAG_TYPE_AX88772 }, /* Trendnet TU2-ET100 V3.0R */
Applied, thanks
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Hi Marek, On Thu, 27 Jun 2013 13:26:39 +0200, Marek Vasut ma...@denx.de wrote: Dear Heiko Schocher, while playing with dfu, I tapped in an unaligned access when doing on the host side a lsusb -d [vendornr]: -v I get on the board: Applied, thanks Now we have console log output in commit messages. :( Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Hi Stefan,
On Thu, 27 Jun 2013 12:26:24 +0200, Stefan Roese s...@denx.de wrote:
Hi Albert,
On 06/27/2013 12:11 PM, Albert ARIBAUD wrote:
while playing with dfu, I tapped in an unaligned access
when doing on the host side a lsusb -d [vendornr]: -v
I get on the board:
GADGET DRIVER: usb_dnl_dfu
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [8ff71db8] lr : [8ff75aec]
sp : 8ef40d18 ip : 0005 fp :
r10: r9 : 47401410 r8 : 8ef40f38
r7 : 8ef4aae8 r6 : 000a r5 : 8ef4ab28 r4 : 8ef4ab80
r3 : 000a r2 : 0006 r1 : 0006 r0 : 8ef4aae8
Flags: Nzcv IRQs off FIQs on Mode SVC_32
Resetting CPU ...
reason is that in the struct usb_composite_dev the
struct usb_device_descriptor desc; is on an odd address,
and this struct gets accessed in
drivers/usb/gadget/composite.c device_qual()
Fix it, by align this var struct desc fix to an aligned
address.
Slow thinking: if the issue is odd address, why align using
cache-related constant? Alignment should just be to even address --
maybe even 4-byte alignment, to be checked.
Please keep the commit message to a minimum -- what is wrong and how it
is fixed -- and move the rest (context and additional details) after
the commit message separator ('---' below).
I personally find this expanded description quite helpful. Everything
below the --- line is removed from the git history. So +1 for this
expanded description from me.
I am not against an expanded explanation of the why and how of the
patch; but here, the console output copy, as well as the anecdote about
the circumstances which led to discovering the bug, only add noise to
the commit -- they're good for discussion the patch, hence my
suggestion. The commit message is just as informative when spelled out
thus:
- 8 -
usb: fix unaligned access in device_qual()
File include/linux/usb/composite.h contains struct usb_composite_dev in
which field 'desc' is misaligned, causing an alignment data abort in
function device_qual() in file drivers/usb/gadget/composite.c.
Fixed by forcing 'desc' field alignment to {even,4-byte} address.
[...]
---
When doing on the host side a lsusb -d [vendornr]: -v
I get on the board:
GADGET DRIVER: usb_dnl_dfu
data abort
MAYBE you should read doc/README.arm-unaligned-accesses
pc : [8ff71db8] lr : [8ff75aec]
sp : 8ef40d18 ip : 0005 fp :
r10: r9 : 47401410 r8 : 8ef40f38
r7 : 8ef4aae8 r6 : 000a r5 : 8ef4ab28 r4 : 8ef4ab80
r3 : 000a r2 : 0006 r1 : 0006 r0 : 8ef4aae8
Flags: Nzcv IRQs off FIQs on Mode SVC_32
Resetting CPU ...
[...]
- 8 -
Thanks,
Stefan
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Thu, Jun 27, 2013 at 02:35:34AM +, Zhang Ying-B40530 wrote: -Original Message- From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Tom Rini [snip] Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed? Did you also build am335x_evm_usbspl? -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] vf610twr: Add default environment in line with other Freescale boards
On Thu, Jun 27, 2013 at 5:58 AM, Stefano Babic sba...@denx.de wrote: On 27/06/2013 10:00, Wang Huan-B18965 wrote: Hi, stefano, I am ok with the default environment changes. But the sys text base should not be changed, otherwise the u-boot could not work. The reason I have explained in the other email. Of course, and I will not apply the patches until there are open comments. I will fix this. As I don't have the board can you, Alison, provide me the right loadaddr and fdt_addr? So we avoid many revisions. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 03/12] image: Add RSA support for image signing
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/27/2013 02:44 AM, Simon Glass wrote: Hi Masahiro, On Wed, Jun 26, 2013 at 9:08 PM, Masahiro Yamada yamad...@jp.panasonic.com mailto:yamad...@jp.panasonic.com wrote: Hello, Simon. When compiling the master branch, I got an error while a tools/mkimage build. u-boot/lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory I think this erorr is caused by commit 19c402a. I searched and installed the necessary package and I could resolve this error. $ apt-file search openssl/rsa.h libssl-dev: /usr/include/openssl/rsa.h $ sudo apt-get install libssl-dev Let me ask a question. Going forward do we always need the openssl development package for creating mkimage tool? Or is it possible to disable RSA feature by some CONFIG option? This is to support verified boot using FIT. Yes it would be possible to make it an option. I had it that way for a while, but then I worried that it would create two versions of mkimage, one of which is incapable of signing images. That means that mkimage would need to be built for a board with verified boot enabled in order to get full functionality. Perhaps another way would be to check for the header and (if not present), silently build without signing support? Hurk, dang it.. Yes, I think we need to build and go with an error message on attempted use. Skimming the code, we can't rely on CONFIG_FIT_SIGNATURE being inherited from the config, on the host side, yes? - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRzDUoAAoJENk4IS6UOR1WOF8P/in1joGCy0NcOJ3g3PKRRi5Y eUgwTbOaQ3x82dJ3820YEkxSpaJIxiw+l0cvbWVH9TR6wO/7EiVjNLmFwauhuVBU BAf9ghleHjd3T6utxEzDk0z9O2E9f8aliSQ1d31oK1NrM/IvhW06udv6V0shFRCN i3uD4bkWPgv+qChZ+94ma4rc3SDz393lG2dwn0L9TZ/Kv3qOaoEr1qTDSS2fRXqg 2Yd1vFD3mT9ZEMQwfteoThuXWZfyWFYfh9wsUjwjHonJNauwKkZgWFHnZpYCv6tJ TQEOH7pVpO7RAMFw/7f/tXdk/U2Qnmq/GH0Gy/p9E7UYb4IqXNGrXBOjhEGizH+c gA4bAxjooHoVayUf/m3m6g5WUd1uv6cKhcS5WppmaduPdPncB8wPKxksT/ti1NKi 4yDdFLsudPvO+0R94MT+5dgV4Album8aoICmSgzxRy+3x9lGGxEGHeCleDtwnLTR dQEnmUEweKvwL1MNJZ6TBtqekbf/hKVbgn4EqEi0fb4CLKCVFOGT3YSu8oWDaZEQ q0C08/hn6lNgbGqTQL83I0lahp2HiPjHZMvUVVcE0lzOIowkTLLxvsZLfLhlCdXv LxG26Pi0rG/CU8BnYQ/W00X4HPi20UDOt9nLyINq63ctKLWKMMA3B7IkcpBGbT2U dA8uceK04MStQdxiB3kh =wI1Q -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-Boot build issue
On Thu, Jun 27, 2013 at 01:21:04PM +0200, Marek Vasut wrote: Dear Wolfgang Denk, [...] OUT-OF-TREE BUILD: powerpc___a3m071 eldk5.2 Configuring for a3m071 board... make[1]: *** [/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/UBOOT_BUILD/spl/arch/powerpc/cpu/mpc5xxx/libmpc5xxx.o] Error 2 [snip] ELDK 5.2 , powerpc board ... notice the path is again trimmed . Ok, this seems to be enough proof something is not right. What's your host distro? -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-Boot build issue
Dear Tom Rini, On Thu, Jun 27, 2013 at 01:21:04PM +0200, Marek Vasut wrote: Dear Wolfgang Denk, [...] OUT-OF-TREE BUILD: powerpc___a3m071 eldk5.2 Configuring for a3m071 board... make[1]: *** [/opt/work/jenkins/jobs/U-Boot___u- boot_master/workspace/workspace/compiler/eldk5.2/device/powerpc___a3m071/ UBOOT_BUILD/spl/arch/powerpc/cpu/mpc5xxx/libmpc5xxx.o] Error 2 [snip] ELDK 5.2 , powerpc board ... notice the path is again trimmed . Ok, this seems to be enough proof something is not right. What's your host distro? Debian testing/jessie , I keep it up-to-date. For Jenkins, it's fedora 17 (I think). Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Hello Albert, Hi Marek, On Thu, 27 Jun 2013 13:26:39 +0200, Marek Vasut ma...@denx.de wrote: Dear Heiko Schocher, while playing with dfu, I tapped in an unaligned access when doing on the host side a lsusb -d [vendornr]: -v I get on the board: Applied, thanks Now we have console log output in commit messages. :( Don't be sad, I will buy you a tartelette ;) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm sub_command' can use the same code. Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code. Signed-off-by: Simon Glass s...@chromium.org Simon, this patch breaks bootm (at least on powerpc), while booting an compressed uImage (with DT). It just hangs while decompressing the kernel image: ## Booting kernel from Legacy Image at 0100 ... Image Name: Linux-3.5.7 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:2203312 Bytes = 2.1 MiB Load Address: Entry Point: ## Flattened Device Tree blob at 0180 Booting using the fdt blob at 0x180 Uncompressing Kernel Image ... I bisected mainline and this patch is the one that breaks booting: [stefan@ubuntu-2012 u-boot ((983c72f...)|BISECTING)]$ git bisect good 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 is the first bad commit commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 Author: Simon Glass s...@chromium.org Date: Tue Jun 11 11:14:47 2013 -0700 Refactor the bootm command to reduce code duplication I already looked what might be wrong but I couldn't find any problem upon a quick glance. You know this code may better. Perhaps you could take look at it and give it a try as well. Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH1/1] socfpga: Separating the configuration file for Virtual Target and real hardware Cyclone V development kit
socfpga: Separating the configuration file for Virtual Target and
real hardware Cyclone V development kit
Signed-off-by: Chin Liang See cl...@altera.com
---
include/configs/socfpga_cyclone5.h | 28 +---
1 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/include/configs/socfpga_cyclone5.h
b/include/configs/socfpga_cyclone5.h
index 5633d2a..86563b7 100644
--- a/include/configs/socfpga_cyclone5.h
+++ b/include/configs/socfpga_cyclone5.h
@@ -22,6 +22,8 @@
/*
* High level configuration
*/
+/* Running on virtual target or real hardware */ #define
+CONFIG_SOCFPGA_VIRTUAL_TARGET
#define CONFIG_ARMV7
#define CONFIG_L2_OFF
@@ -32,11 +34,12 @@
#define CONFIG_SINGLE_BOOTLOADER
#define CONFIG_SOCFPGA
+/* base address for .text section */
+#ifdef CONFIG_SOCFPGA_VIRTUAL_TARGET
#define CONFIG_SYS_TEXT_BASE0x0840
-#define V_NS16550_CLK100
-#define CONFIG_BAUDRATE57600
-#define CONFIG_SYS_HZ1000
-#define CONFIG_TIMER_CLOCK_KHZ2400
+#else
+#define CONFIG_SYS_TEXT_BASE0x0140
+#endif
#define CONFIG_SYS_LOAD_ADDR0x7fc0
/* Console I/O Buffer Size */
@@ -165,7 +168,7 @@
/* SDRAM Bank #1 */
#define CONFIG_SYS_SDRAM_BASE0x
/* SDRAM memory size */
-#define PHYS_SDRAM_1_SIZE0x8000
+#define PHYS_SDRAM_1_SIZE0x4000
#define PHYS_SDRAM_1CONFIG_SYS_SDRAM_BASE
#define CONFIG_SYS_MEMTEST_START0x
@@ -181,8 +184,13 @@
#define CONFIG_SYS_NS16550_CLK V_NS16550_CLK
#define CONFIG_CONS_INDEX 1
#define CONFIG_SYS_NS16550_COM1UART0_BASE
-
#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600, 115200}
+#ifdef CONFIG_SOCFPGA_VIRTUAL_TARGET
+#define V_NS16550_CLK100
+#else
+#define V_NS16550_CLK1
+#endif
+#define CONFIG_BAUDRATE115200
/*
* FLASH
@@ -195,9 +203,15 @@
/* This timer use eosc1 where the clock frequency is fixed
* throughout any condition */
#define CONFIG_SYS_TIMERBASESOCFPGA_OSC1TIMER0_ADDRESS
-
/* reload value when timer count to zero */
#define TIMER_LOAD_VAL0x
+/* Timer info */
+#define CONFIG_SYS_HZ1000
+#ifdef CONFIG_SOCFPGA_VIRTUAL_TARGET
+#define CONFIG_TIMER_CLOCK_KHZ2400
+#else
+#define CONFIG_TIMER_CLOCK_KHZ25000
+#endif
#define CONFIG_ENV_IS_NOWHERE
--
1.7.7.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/1] socfpga: Adding System Manager driver which will configure the pin mux for real hardware Cyclone V
socfpga: Adding System Manager driver which will configure the pin mux
for real hardware Cyclone V development kit (not Virtual Platform)
Signed-off-by: Chin Liang See cl...@altera.com
---
arch/arm/cpu/armv7/socfpga/Makefile|2 +-
arch/arm/cpu/armv7/socfpga/spl.c |6 +
arch/arm/cpu/armv7/socfpga/system_manager.c| 40
.../include/asm/arch-socfpga/socfpga_base_addrs.h |1 +
arch/arm/include/asm/arch-socfpga/system_manager.h | 32 +++
board/altera/socfpga_cyclone5/Makefile |4 +-
board/altera/socfpga_cyclone5/pinmux_config.c | 213
board/altera/socfpga_cyclone5/pinmux_config.h | 53 +
include/configs/socfpga_cyclone5.h |1 +
9 files changed, 350 insertions(+), 2 deletions(-) create mode
100644 arch/arm/cpu/armv7/socfpga/system_manager.c
create mode 100644 arch/arm/include/asm/arch-socfpga/system_manager.h
create mode 100644 board/altera/socfpga_cyclone5/pinmux_config.c
create mode 100644 board/altera/socfpga_cyclone5/pinmux_config.h
diff --git a/arch/arm/cpu/armv7/socfpga/Makefile
b/arch/arm/cpu/armv7/socfpga/Makefile
index 518e67a..cf2829a 100644
--- a/arch/arm/cpu/armv7/socfpga/Makefile
+++ b/arch/arm/cpu/armv7/socfpga/Makefile
@@ -29,7 +29,7 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(SOC).o
SOBJS := lowlevel_init.o
-COBJS-y:= misc.o timer.o reset_manager.o
+COBJS-y:= misc.o timer.o reset_manager.o system_manager.o
COBJS-$(CONFIG_SPL_BUILD) += spl.o
COBJS := $(COBJS-y)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
index 84216eb..28d8c99 100644
--- a/arch/arm/cpu/armv7/socfpga/spl.c
+++ b/arch/arm/cpu/armv7/socfpga/spl.c
@@ -23,6 +23,7 @@
#include image.h
#include asm/arch/reset_manager.h
#include spl.h
+#include asm/arch/system_manager.h
DECLARE_GLOBAL_DATA_PTR;
@@ -36,6 +37,11 @@ u32 spl_boot_device(void)
*/
void spl_board_init(void)
{
+#ifndef CONFIG_SOCFPGA_VIRTUAL_TARGET
+ /* configure the pin muxing through system manager */
+ sysmgr_pinmux_init();
+#endif /* CONFIG_SOCFPGA_VIRTUAL_TARGET */
+
/* de-assert reset for peripherals and bridges based on handoff */
reset_deassert_peripherals_handoff();
diff --git a/arch/arm/cpu/armv7/socfpga/system_manager.c
b/arch/arm/cpu/armv7/socfpga/system_manager.c
new file mode 100644
index 000..f2707d8b
--- /dev/null
+++ b/arch/arm/cpu/armv7/socfpga/system_manager.c
@@ -0,0 +1,40 @@
+/*
+ * Copyright Altera Corporation (C) 2013. All rights reserved
+ *
+ * This program is free software; you can redistribute it and/or
+modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but
+WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public
+License
+ * for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+along
+ * with this program. If not, see http://www.gnu.org/licenses/.
+ */
+
+#include common.h
+#include asm/io.h
+#include asm/arch/system_manager.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/*
+ * Configure all the pin mux
+ */
+void sysmgr_pinmux_init(void)
+{
+ unsigned long offset = CONFIG_SYSMGR_PINMUXGRP_OFFSET;
+
+ const unsigned long *pval = sys_mgr_init_table;
+ unsigned long i;
+
+ for (i = 0;
+ i ((sizeof(sys_mgr_init_table)) / sizeof(unsigned long));
+ i++, offset += sizeof(unsigned long)) {
+ writel(*pval++, (SOCFPGA_SYSMGR_ADDRESS + offset));
+ }
+}
+
+
diff --git a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
index f353eb2..819c280 100644
--- a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
+++ b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h
@@ -23,5 +23,6 @@
#define SOCFPGA_UART1_ADDRESS 0xffc03000 #define
SOCFPGA_OSC1TIMER0_ADDRESS 0xffd0 #define SOCFPGA_RSTMGR_ADDRESS
0xffd05000
+#define SOCFPGA_SYSMGR_ADDRESS 0xffd08000
#endif /* _SOCFPGA_BASE_ADDRS_H_ */
diff --git a/arch/arm/include/asm/arch-socfpga/system_manager.h
b/arch/arm/include/asm/arch-socfpga/system_manager.h
new file mode 100644
index 000..aec9be7
--- /dev/null
+++ b/arch/arm/include/asm/arch-socfpga/system_manager.h
@@ -0,0 +1,32 @@
+/*
+ * Copyright Altera Corporation (C) 2013. All rights reserved
+ *
+ * This program is free software; you can redistribute it and/or
+modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but
+WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+or
+ * FITNESS FOR A
[U-Boot] [PATCH 1/1] socfpga: Consolidating reset code into reset_manager.c. Also separating reset configuration for virtual target and real hardware Cyclone V development kit
socfpga: Consolidating reset code into reset_manager.c. Also separating
reset configuration for virtual target and real hardware Cyclone V
development kit
Signed-off-by: Chin Liang See cl...@altera.com
---
arch/arm/cpu/armv7/socfpga/Makefile |2 +-
arch/arm/cpu/armv7/socfpga/misc.c | 27 ---
arch/arm/cpu/armv7/socfpga/reset_manager.c| 50 +
arch/arm/include/asm/arch-socfpga/reset_manager.h | 17 +++
4 files changed, 68 insertions(+), 28 deletions(-) create mode
100644 arch/arm/cpu/armv7/socfpga/reset_manager.c
diff --git a/arch/arm/cpu/armv7/socfpga/Makefile
b/arch/arm/cpu/armv7/socfpga/Makefile
index 376a4bd..518e67a 100644
--- a/arch/arm/cpu/armv7/socfpga/Makefile
+++ b/arch/arm/cpu/armv7/socfpga/Makefile
@@ -29,7 +29,7 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(SOC).o
SOBJS:= lowlevel_init.o
-COBJS-y:= misc.o timer.o
+COBJS-y:= misc.o timer.o reset_manager.o
COBJS-$(CONFIG_SPL_BUILD) += spl.o
COBJS:= $(COBJS-y)
diff --git a/arch/arm/cpu/armv7/socfpga/misc.c
b/arch/arm/cpu/armv7/socfpga/misc.c
index fa16424..59f5b94 100644
--- a/arch/arm/cpu/armv7/socfpga/misc.c
+++ b/arch/arm/cpu/armv7/socfpga/misc.c
@@ -17,36 +17,9 @@
#include common.h
#include asm/io.h
-#include asm/arch/reset_manager.h
DECLARE_GLOBAL_DATA_PTR;
-static const struct socfpga_reset_manager *reset_manager_base =
-(void *)SOCFPGA_RSTMGR_ADDRESS;
-
-/*
- * Write the reset manager register to cause reset
- */
-void reset_cpu(ulong addr)
-{
-/* request a warm reset */
-writel(RSTMGR_CTRL_SWWARMRSTREQ_LSB, reset_manager_base-ctrl);
-/*
- * infinite loop here as watchdog will trigger and reset
- * the processor
- */
-while (1)
-;
-}
-
-/*
- * Release peripherals from reset based on handoff
- */
-void reset_deassert_peripherals_handoff(void)
-{
-writel(0, reset_manager_base-per_mod_reset);
-}
-
int dram_init(void)
{
gd-ram_size = get_ram_size((long *)PHYS_SDRAM_1,
PHYS_SDRAM_1_SIZE); diff --git
a/arch/arm/cpu/armv7/socfpga/reset_manager.c
b/arch/arm/cpu/armv7/socfpga/reset_manager.c
new file mode 100644
index 000..b0cc399
--- /dev/null
+++ b/arch/arm/cpu/armv7/socfpga/reset_manager.c
@@ -0,0 +1,50 @@
+/*
+ * Copyright Altera Corporation (C) 2013. All rights reserved
+ *
+ * This program is free software; you can redistribute it and/or
+modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but
+WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public
+License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
along with
+ * this program. If not, see http://www.gnu.org/licenses/.
+ */
+
+#include common.h
+#include asm/io.h
+#include asm/arch/reset_manager.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static const struct socfpga_reset_manager *reset_manager_base =
+(void *)SOCFPGA_RSTMGR_ADDRESS;
+
+/*
+ * Write the reset manager register to cause reset */ void
+reset_cpu(ulong addr) {
+/* request a warm reset */
+writel((1 RSTMGR_CTRL_SWWARMRSTREQ_LSB),
+reset_manager_base-ctrl);
+/*
+ * infinite loop here as watchdog will trigger and reset
+ * the processor
+ */
+while (1)
+;
+}
+
+/*
+ * Release peripherals from reset based on handoff */ void
+reset_deassert_peripherals_handoff(void)
+{
+writel(0, reset_manager_base-per_mod_reset);
+}
+
+
diff --git a/arch/arm/include/asm/arch-socfpga/reset_manager.h
b/arch/arm/include/asm/arch-socfpga/reset_manager.h
index d9d2c1c..58d85e3 100644
--- a/arch/arm/include/asm/arch-socfpga/reset_manager.h
+++ b/arch/arm/include/asm/arch-socfpga/reset_manager.h
@@ -21,6 +21,7 @@
void reset_cpu(ulong addr);
void reset_deassert_peripherals_handoff(void);
+#if defined(CONFIG_SOCFPGA_VIRTUAL_TARGET)
struct socfpga_reset_manager {
u32padding1;
u32ctrl;
@@ -31,7 +32,23 @@ struct socfpga_reset_manager {
u32per2_mod_reset;
u32brg_mod_reset;
};
+#else
+struct socfpga_reset_manager {
+u32status;
+u32ctrl;
+u32counts;
+u32padding1;
+u32mpu_mod_reset;
+u32per_mod_reset;
+u32per2_mod_reset;
+u32brg_mod_reset;
+};
+#endif
+#if defined(CONFIG_SOCFPGA_VIRTUAL_TARGET)
+#define RSTMGR_CTRL_SWWARMRSTREQ_LSB 2
+#else
#define RSTMGR_CTRL_SWWARMRSTREQ_LSB 1
+#endif
#endif /* _RESET_MANAGER_H_ */
--
1.7.7.4
Confidentiality Notice.
This message may contain information that is confidential or otherwise
protected from disclosure. If you are not the intended recipient, you
are hereby notified that any use, disclosure, dissemination,
distribution, or copying of this message, or any attachments, is
strictly
Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
On Thu, Jun 27, 2013 at 03:40:36PM +0200, Stefan Roese wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm sub_command' can use the same code. Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code. Signed-off-by: Simon Glass s...@chromium.org Simon, this patch breaks bootm (at least on powerpc), while booting an compressed uImage (with DT). It just hangs while decompressing the kernel image: I swear I had boot tested a kernel on beaglebone with the series, but I see the similar behavior right now, on ARM. I also see it with FIT images (which I think I'm building correctly, but they go far off into the weeds and are ignoring entry/load values). It's not a hang, it's return to prompt. If you follow with a bootm go, it hangs. With or without CONFIG_SYS_GENERIC_BOARD set. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Build error of u-boot mater branch
Hi All, When build u-boot master branch, I meet the following of error. ---8--- lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory ---8--- The master git commit id I build is: 1b9591c2375d59be333c98c760e06605007e20c3 (ColdFire: Update the arch_global_date changes for mcf5441x) And lib/rsa/rsa-sign.c commit id is: 19c402afa2e1190f596f35a84ac049b10d814f1f (image: Add RSA support for image signing) Best Regards, Bo Shen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Build error of u-boot mater branch
Hi Bo, 2013/6/27 Bo Shen voice.s...@gmail.com: Hi All, When build u-boot master branch, I meet the following of error. ---8--- lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory ---8--- The master git commit id I build is: 1b9591c2375d59be333c98c760e06605007e20c3 (ColdFire: Update the arch_global_date changes for mcf5441x) And lib/rsa/rsa-sign.c commit id is: 19c402afa2e1190f596f35a84ac049b10d814f1f (image: Add RSA support for image signing) Best Regards, Bo Shen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot FYI, from IRC vstehle eballetbo: I remarked that this morning as well. Install openssl dev package and you should be ok vstehle eballetbo: I think this is now used by mkimage, for signing, presumably? eballetbo vstehle: ok, i see, now these headers are required to build the host tools. Thanks You should install openssl dev package in your host machine. Hope it helps you, Enric ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Build error of u-boot mater branch
Hi Enric, 于 6/27/2013 10:55 PM, Enric Balletbo Serra 写道: Hi Bo, 2013/6/27 Bo Shen voice.s...@gmail.com: Hi All, When build u-boot master branch, I meet the following of error. ---8--- lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory ---8--- The master git commit id I build is: 1b9591c2375d59be333c98c760e06605007e20c3 (ColdFire: Update the arch_global_date changes for mcf5441x) And lib/rsa/rsa-sign.c commit id is: 19c402afa2e1190f596f35a84ac049b10d814f1f (image: Add RSA support for image signing) Best Regards, Bo Shen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot FYI, from IRC vstehle eballetbo: I remarked that this morning as well. Install openssl dev package and you should be ok vstehle eballetbo: I think this is now used by mkimage, for signing, presumably? eballetbo vstehle: ok, i see, now these headers are required to build the host tools. Thanks You should install openssl dev package in your host machine. it is solved the problem. Thanks for you information. Hope it helps you, Enric Best Regards, Bo Shen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
Hi Stefann, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm sub_command' can use the same code. Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code. Signed-off-by: Simon Glass s...@chromium.org Simon, this patch breaks bootm (at least on powerpc), while booting an compressed uImage (with DT). It just hangs while decompressing the kernel image: ## Booting kernel from Legacy Image at 0100 ... Image Name: Linux-3.5.7 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:2203312 Bytes = 2.1 MiB Load Address: Entry Point: ## Flattened Device Tree blob at 0180 Booting using the fdt blob at 0x180 Uncompressing Kernel Image ... I bisected mainline and this patch is the one that breaks booting: [stefan@ubuntu-2012 u-boot ((983c72f...)|BISECTING)]$ git bisect good 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 is the first bad commit commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 Author: Simon Glass s...@chromium.org Date: Tue Jun 11 11:14:47 2013 -0700 Refactor the bootm command to reduce code duplication I already looked what might be wrong but I couldn't find any problem upon a quick glance. You know this code may better. Perhaps you could take look at it and give it a try as well. Yes I will take a look today. I created a test suite for it but it did not include decompression - I will see if I can diagnose it and then add another test. If you have the .its file (device tree input to mkimage) please send it to me. Regards, Simon Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 03/12] image: Add RSA support for image signing
Hi Tom, On Thu, Jun 27, 2013 at 5:50 AM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/27/2013 02:44 AM, Simon Glass wrote: Hi Masahiro, On Wed, Jun 26, 2013 at 9:08 PM, Masahiro Yamada yamad...@jp.panasonic.com mailto:yamad...@jp.panasonic.com wrote: Hello, Simon. When compiling the master branch, I got an error while a tools/mkimage build. u-boot/lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory I think this erorr is caused by commit 19c402a. I searched and installed the necessary package and I could resolve this error. $ apt-file search openssl/rsa.h libssl-dev: /usr/include/openssl/rsa.h $ sudo apt-get install libssl-dev Let me ask a question. Going forward do we always need the openssl development package for creating mkimage tool? Or is it possible to disable RSA feature by some CONFIG option? This is to support verified boot using FIT. Yes it would be possible to make it an option. I had it that way for a while, but then I worried that it would create two versions of mkimage, one of which is incapable of signing images. That means that mkimage would need to be built for a board with verified boot enabled in order to get full functionality. Perhaps another way would be to check for the header and (if not present), silently build without signing support? Hurk, dang it.. Yes, I think we need to build and go with an error message on attempted use. Skimming the code, we can't rely on CONFIG_FIT_SIGNATURE being inherited from the config, on the host side, yes? Yes I can make this check CONFIG_FIT_SIGNATURE - as mentioned I had it that way originally but worred about creating different versions of mkimage. There is actually code there for this which we can use: #ifdef CONFIG_FIT_SIGNATURE fprintf(stderr, Signing / verified boot options: [-k keydir] [-K dtb] [ -c comment] [-r]\n -k = set directory containing private keys\n -K = write public keys to this .dtb file\n -c = add comment in signature node\n -F = re-sign existing FIT image\n -r = mark keys used as 'required' in dtb\n); #else fprintf(stderr, Signing / verified boot not supported (CONFIG_FIT_SIGNATURE undefined)\n); #endif Let me know if this is the preferred option and I will prepare a patch. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 03/12] image: Add RSA support for image signing
On Thu, Jun 27, 2013 at 08:45:34AM -0700, Simon Glass wrote: Hi Tom, On Thu, Jun 27, 2013 at 5:50 AM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/27/2013 02:44 AM, Simon Glass wrote: Hi Masahiro, On Wed, Jun 26, 2013 at 9:08 PM, Masahiro Yamada yamad...@jp.panasonic.com mailto:yamad...@jp.panasonic.com wrote: Hello, Simon. When compiling the master branch, I got an error while a tools/mkimage build. u-boot/lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory I think this erorr is caused by commit 19c402a. I searched and installed the necessary package and I could resolve this error. $ apt-file search openssl/rsa.h libssl-dev: /usr/include/openssl/rsa.h $ sudo apt-get install libssl-dev Let me ask a question. Going forward do we always need the openssl development package for creating mkimage tool? Or is it possible to disable RSA feature by some CONFIG option? This is to support verified boot using FIT. Yes it would be possible to make it an option. I had it that way for a while, but then I worried that it would create two versions of mkimage, one of which is incapable of signing images. That means that mkimage would need to be built for a board with verified boot enabled in order to get full functionality. Perhaps another way would be to check for the header and (if not present), silently build without signing support? Hurk, dang it.. Yes, I think we need to build and go with an error message on attempted use. Skimming the code, we can't rely on CONFIG_FIT_SIGNATURE being inherited from the config, on the host side, yes? Yes I can make this check CONFIG_FIT_SIGNATURE - as mentioned I had it that way originally but worred about creating different versions of mkimage. There is actually code there for this which we can use: #ifdef CONFIG_FIT_SIGNATURE fprintf(stderr, Signing / verified boot options: [-k keydir] [-K dtb] [ -c comment] [-r]\n -k = set directory containing private keys\n -K = write public keys to this .dtb file\n -c = add comment in signature node\n -F = re-sign existing FIT image\n -r = mark keys used as 'required' in dtb\n); #else fprintf(stderr, Signing / verified boot not supported (CONFIG_FIT_SIGNATURE undefined)\n); #endif Let me know if this is the preferred option and I will prepare a patch. The Makefile fragments I saw implied we couldn't use this approach on the host. But if we can, lets. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] U-boot2013:07-Recompile with -fPIC error for mips64 board
Hi All, I am cross-compiling u-boot2013-07 for mips64 board.These steps i have followed: 1)I have exported envionment variables CC,LD,AS,CCAS,AR and LD_LIBRARY_PATH. 2)export CROSS_COMPILE=mips64-unknown-elf- 3)make tools 4)make board_config 5)make all Linking error:relocation R_X86_64_32 against `board_init_f' can not be used when making a shared object; recompile with -fPIC /arch/mips/cpu.mips64./../../../lib/start.o: could not read symbols: Bad value.Please provide me pointer to resolve this. Regards, Krishna ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: fix unaligned access in device_qual()
Hi Marek, On Thu, 27 Jun 2013 15:23:33 +0200, Marek Vasut ma...@denx.de wrote: Hello Albert, Hi Marek, On Thu, 27 Jun 2013 13:26:39 +0200, Marek Vasut ma...@denx.de wrote: Dear Heiko Schocher, while playing with dfu, I tapped in an unaligned access when doing on the host side a lsusb -d [vendornr]: -v I get on the board: Applied, thanks Now we have console log output in commit messages. :( Don't be sad, I will buy you a tartelette ;) Actually the sad part is that the patch in itself is bad: the actual alignment boundary should have been 16 bit, not one cacheline. Also, the issue could / should have been solved by reordering the fields rather than using an attribute. And I'm not going to eat a tartelette when I'm about 30 minutes from going to a restaurant (admittedly small, but undoubtedly near). Best regards, Marek Vasut Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 03/12] image: Add RSA support for image signing
Hi Tom, On Thu, Jun 27, 2013 at 8:48 AM, Tom Rini tr...@ti.com wrote: On Thu, Jun 27, 2013 at 08:45:34AM -0700, Simon Glass wrote: Hi Tom, On Thu, Jun 27, 2013 at 5:50 AM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/27/2013 02:44 AM, Simon Glass wrote: Hi Masahiro, On Wed, Jun 26, 2013 at 9:08 PM, Masahiro Yamada yamad...@jp.panasonic.com mailto:yamad...@jp.panasonic.com wrote: Hello, Simon. When compiling the master branch, I got an error while a tools/mkimage build. u-boot/lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory I think this erorr is caused by commit 19c402a. I searched and installed the necessary package and I could resolve this error. $ apt-file search openssl/rsa.h libssl-dev: /usr/include/openssl/rsa.h $ sudo apt-get install libssl-dev Let me ask a question. Going forward do we always need the openssl development package for creating mkimage tool? Or is it possible to disable RSA feature by some CONFIG option? This is to support verified boot using FIT. Yes it would be possible to make it an option. I had it that way for a while, but then I worried that it would create two versions of mkimage, one of which is incapable of signing images. That means that mkimage would need to be built for a board with verified boot enabled in order to get full functionality. Perhaps another way would be to check for the header and (if not present), silently build without signing support? Hurk, dang it.. Yes, I think we need to build and go with an error message on attempted use. Skimming the code, we can't rely on CONFIG_FIT_SIGNATURE being inherited from the config, on the host side, yes? Yes I can make this check CONFIG_FIT_SIGNATURE - as mentioned I had it that way originally but worred about creating different versions of mkimage. There is actually code there for this which we can use: #ifdef CONFIG_FIT_SIGNATURE fprintf(stderr, Signing / verified boot options: [-k keydir] [-K dtb] [ -c comment] [-r]\n -k = set directory containing private keys\n -K = write public keys to this .dtb file\n -c = add comment in signature node\n -F = re-sign existing FIT image\n -r = mark keys used as 'required' in dtb\n); #else fprintf(stderr, Signing / verified boot not supported (CONFIG_FIT_SIGNATURE undefined)\n); #endif Let me know if this is the preferred option and I will prepare a patch. The Makefile fragments I saw implied we couldn't use this approach on the host. But if we can, lets. That still seems to work OK. Will send a patch. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 06/11] powerpc/T4240EMU: Add T4240EMU target
On 06/26/2013 03:03 PM, Wolfgang Denk wrote: Dear York Sun, In message 1372263479-10588-1-git-send-email-york...@freescale.com you wrote: Add emulator support for T4240. Emulator has limited peripherals and interfaces. Difference between emulator and T4240QDS includes: ECC for DDR is disabled due the procedure to load images No board FPGA (QIXIS) NOR flash has 32-bit port for higher loading speed IFC and I2C timing don't really matter, so set them fast No ethernet Signed-off-by: York Sun york...@freescale.com --- So what exactly are the changes compared to V1? Added entry to MAINTAINERS Fixed checkpatch warning - WARNING: quoted string split across lines - WARNING: Avoid unnecessary line continuations --- a/MAINTAINERS +++ b/MAINTAINERS @@ -538,6 +538,10 @@ Detlev Zundel d...@denx.de inka4x0 MPC5200 +York Sun york...@freescale.com + +T4240EMUT4240 + Can you please keep the list sorted? Thanks. The list is not sorted. I tried with my best guess, sort on CPU. That's why I put it at the end of PowerPC Systems. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 06/11] powerpc/T4240EMU: Add T4240EMU target
On 06/27/2013 12:30:25 PM, York Sun wrote: On 06/26/2013 03:03 PM, Wolfgang Denk wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -538,6 +538,10 @@ Detlev Zundel d...@denx.de inka4x0 MPC5200 +York Sun york...@freescale.com + + T4240EMUT4240 + Can you please keep the list sorted? Thanks. The list is not sorted. I tried with my best guess, sort on CPU. That's why I put it at the end of PowerPC Systems. It is sorted by maintainer name (as noted at the top of the file) within each architecture section. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 06/11] powerpc/T4240EMU: Add T4240EMU target
On 06/27/2013 10:35 AM, Scott Wood wrote: On 06/27/2013 12:30:25 PM, York Sun wrote: On 06/26/2013 03:03 PM, Wolfgang Denk wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -538,6 +538,10 @@ Detlev Zundel d...@denx.de inka4x0MPC5200 +York Sun york...@freescale.com + +T4240EMUT4240 + Can you please keep the list sorted? Thanks. The list is not sorted. I tried with my best guess, sort on CPU. That's why I put it at the end of PowerPC Systems. It is sorted by maintainer name (as noted at the top of the file) within each architecture section. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mkimage: Build signing only if board has CONFIG_FIT_SIGNATURE
At present mkimage is set up to always build with image signing support.
This means that the SSL libraries (e.g. libssl-dev) are always required.
Adjust things so that mkimage can be built with and without image signing,
controlled by the presence of CONFIG_FIT_SIGNATURE in the board config file.
If CONFIG_FIT_SIGNATURE is not enabled, then mkimage will report a warning
that signing is not supported. If the option is enabled, but libraries are
not available, then a build error similar to this will be shown:
lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory
Signed-off-by: Simon Glass s...@chromium.org
---
config.mk | 6 +-
include/image.h | 3 ---
tools/Makefile | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/config.mk b/config.mk
index 5a91203..81c2584 100644
--- a/config.mk
+++ b/config.mk
@@ -96,7 +96,6 @@ HOSTCFLAGS+= $(call os_x_before, 10, 4,
-traditional-cpp)
HOSTLDFLAGS+= $(call os_x_before, 10, 5, -multiply_defined suppress)
else
HOSTCC = gcc
-HOSTLIBS += -lssl -lcrypto
endif
ifeq ($(HOSTOS),cygwin)
@@ -211,6 +210,11 @@ CPPFLAGS += -ffunction-sections -fdata-sections
LDFLAGS_FINAL += --gc-sections
endif
+# TODO(s...@chromium.org): Is this correct on Mac OS?
+ifdef CONFIG_FIT_SIGNATURE
+HOSTLIBS += -lssl -lcrypto
+endif
+
ifneq ($(CONFIG_SYS_TEXT_BASE),)
CPPFLAGS += -DCONFIG_SYS_TEXT_BASE=$(CONFIG_SYS_TEXT_BASE)
endif
diff --git a/include/image.h b/include/image.h
index 2614918..a7b93db 100644
--- a/include/image.h
+++ b/include/image.h
@@ -46,9 +46,6 @@ struct lmb;
#define CONFIG_OF_LIBFDT 1
#define CONFIG_FIT_VERBOSE 1 /* enable fit_format_{error,warning}() */
-/* Support FIT image signing on host */
-#define CONFIG_FIT_SIGNATURE
-
#define IMAGE_ENABLE_IGNORE0
#define IMAGE_INDENT_STRING
diff --git a/tools/Makefile b/tools/Makefile
index cc912fb..46159b2 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -126,7 +126,7 @@ LIBFDT_OBJ_FILES-y += fdt_strerror.o
LIBFDT_OBJ_FILES-y += fdt_wip.o
# RSA objects
-RSA_OBJ_FILES-y += rsa-sign.o
+RSA_OBJ_FILES-$(CONFIG_FIT_SIGNATURE) += rsa-sign.o
# Generated LCD/video logo
LOGO_H = $(OBJTREE)/include/bmp_logo.h
--
1.8.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-boot2013:07-Recompile with -fPIC error for mips64 board
Dear krishna dwivedi, In message CAKAK--mG07ZxHFzhw=qtVONpfrQS61Q=Ai_mYrLLYg+XmFj=d...@mail.gmail.com you wrote: --===1781805000== Content-Type: multipart/alternative; boundary=047d7bd6c6425eb96b04e02592ae --047d7bd6c6425eb96b04e02592ae Content-Type: text/plain; charset=ISO-8859-1 Hi All, I am cross-compiling u-boot2013-07 for mips64 board.These steps i have followed: 1)I have exported envionment variables CC,LD,AS,CCAS,AR and LD_LIBRARY_PATH. 2)export CROSS_COMPILE=mips64-unknown-elf- 3)make tools 4)make board_config 5)make all This is NOT the noral order of steps. There is no need to build tools manually, and in no way this should be done before the config target. I think I asked this before: which _exact_ machine configuration are you using, i. e. what is your board name? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The optimum committee has no members. - Norman Augustine ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 06/11] powerpc/T4240EMU: Add T4240EMU target
Dear York Sun, In message 51cc76b1.6030...@freescale.com you wrote: So what exactly are the changes compared to V1? Added entry to MAINTAINERS Fixed checkpatch warning - WARNING: quoted string split across lines - WARNING: Avoid unnecessary line continuations And why do you not include this information with the patch? You've been around here long enough that you should know this requirement. --- a/MAINTAINERS +++ b/MAINTAINERS @@ -538,6 +538,10 @@ Detlev Zundel d...@denx.de inka4x0 MPC5200 +York Sun york...@freescale.com + + T4240EMUT4240 + Can you please keep the list sorted? Thanks. The list is not sorted. I tried with my best guess, sort on CPU. That's why I put it at the end of PowerPC Systems. The list IS sorted. The sort key is the last name of the maintainer. Sun clearly sorts before Zundel. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Be careful what you wish for. You never know who will be listening. - Terry Pratchett, _Soul Music_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 06/11] powerpc/T4240EMU: Add T4240EMU target
On 06/27/2013 10:51 AM, Wolfgang Denk wrote: Dear York Sun, In message 51cc76b1.6030...@freescale.com you wrote: So what exactly are the changes compared to V1? Added entry to MAINTAINERS Fixed checkpatch warning - WARNING: quoted string split across lines - WARNING: Avoid unnecessary line continuations And why do you not include this information with the patch? You've been around here long enough that you should know this requirement. I forgot. Updated in v3 patch. --- a/MAINTAINERS +++ b/MAINTAINERS @@ -538,6 +538,10 @@ Detlev Zundel d...@denx.de inka4x0 MPC5200 +York Sun york...@freescale.com + + T4240EMUT4240 + Can you please keep the list sorted? Thanks. The list is not sorted. I tried with my best guess, sort on CPU. That's why I put it at the end of PowerPC Systems. The list IS sorted. The sort key is the last name of the maintainer. Sun clearly sorts before Zundel. Got it. Updated in v3 patch. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/2] console: usbkbd: Improve TFTP booting performance
On 06/27/2013 03:45 AM, Jim Lin wrote: TFTP booting is observed a little bit slow, especially when a USB keyboard is installed. The fix is to move polling to every second if we sense that other task like TFTP boot is running. diff --git a/common/usb_kbd.c b/common/usb_kbd.c +#ifdef CONFIG_USBKB_TESTC_PERIOD + /* + * T is the time between two calls of usb_kbd_testc(). + * If CONFIG_USBKB_TESTC_PERIOD ms T 1000 ms, + * it implies other task like TFTP boot is running, + * then we reduce polling to every second + * to improve TFTP booting performance. + */ + if ((get_timer(kbd_testc_tms) = + (CONFIG_USBKB_TESTC_PERIOD * CONFIG_SYS_HZ / 1000)) + (get_timer(kbd_testc_tms) CONFIG_SYS_HZ)) + return 0; + else + kbd_testc_tms = get_timer(0); +#endif I have a hard time understanding why the fact that some other task is running implies anything at all re: how often usb_kbd_testc() would be called. It's quite possible that some other task is extremely fine-grained, and calls usb_kbd_testc() every 0.1ms, and would be severely negatively affected by usb_kbd_testc() taking a long time to execute. Conversly, it's quite possible that some other task is quite granular, and calls usb_kbd_testc() a wide intervals, say every 200ms. So, I think this change keys of entirely the wrong thing. Shouldn't the TFTP process (or use of USB networking?) or other long-running tasks that do check for keyboard IO simply set some flag to indicate to usb_kbd_testc() that it should run at a reduced rate, or even just have those long-running processses call usb_kbd_testc() at a reduced rate themselves? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] board/bsc9132qds: Add DSP side tlb and laws
On 06/26/2013 10:59:16 PM, Jain Priyanka-B32167 wrote: Email-id is no longer valid as person has left the company. Git send-email was throwing error as it could not send message to that mail. You can use --suppress-cc=sob to tell git send-email to not automatically CC people with sign-off lines. Or, you could use an ordinary e-mail client to send it, as long as it doesn't mangle the patch (mutt works well for this). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] board/bsc9132qds: Add DSP side tlb and laws
On 06/27/2013 05:05:55 AM, Albert ARIBAUD wrote: Hi Prabhakar, On Thu, 27 Jun 2013 13:36:16 +0530, Prabhakar Lad prabhakar.cse...@gmail.com wrote: On Thu, Jun 27, 2013 at 1:21 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Jain, On Thu, 27 Jun 2013 03:59:16 +, Jain Priyanka-B32167 b32...@freescale.com wrote: Email-id is no longer valid as person has left the company. Git send-email was throwing error as it could not send message to that mail. (please do not top-post) Without an e-mail address, I suspect we cannot consider that person's Signed-off-by to be valid, if only because it does not identify a single individual any more. Yes that's rite! alternatively you can just mention his name in the commit message(with _NO_ signed-of). Note however that we *do* need a signed-off-by line. We would still have Priyanka's signed-off-by. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command
On Thu, Jun 27, 2013 at 4:50 AM, Zhang Haijun-B42677 b42...@freescale.comwrote: Hi, Fleming and Fabio Sorry to reply to you so late. As our manual described. In the eSDHC, the data buffer can hold up to 128 words (32-bit). The watermark levels for both write and read can be configured for CPU polling mode. The watermark level can be from 1 word to the maximum of 128 words. For both DMA read and write, the burst length, can be configured from 1 to the maximum of 16. The host driver may configure watermark level and burst length value according to the system situation and requirement in the watermark level register (WML). I think you may have misunderstood the WML register. My read of the manual indicates it is most definitely necessary for DMA. I think it is also necessary for polling mode, and WML configuration was not added properly when polling mode support was added to the driver. The solution may be to set up WML for both modes, but the manual is a bit unclear (it sometimes likes to refer to polling mode as External DMA). Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
Hi Stefan, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm sub_command' can use the same code. Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code. Signed-off-by: Simon Glass s...@chromium.org Simon, this patch breaks bootm (at least on powerpc), while booting an compressed uImage (with DT). It just hangs while decompressing the kernel image: ## Booting kernel from Legacy Image at 0100 ... Image Name: Linux-3.5.7 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:2203312 Bytes = 2.1 MiB Load Address: Entry Point: ## Flattened Device Tree blob at 0180 Booting using the fdt blob at 0x180 Uncompressing Kernel Image ... I bisected mainline and this patch is the one that breaks booting: [stefan@ubuntu-2012 u-boot ((983c72f...)|BISECTING)]$ git bisect good 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 is the first bad commit commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 Author: Simon Glass s...@chromium.org Date: Tue Jun 11 11:14:47 2013 -0700 Refactor the bootm command to reduce code duplication I already looked what might be wrong but I couldn't find any problem upon a quick glance. You know this code may better. Perhaps you could take look at it and give it a try as well. I thought I had a repro, but it turned out to be that I was using kernel_noload so it was decompressing onto itself: Uncompressing Kernel Image (no loading done) ... LZO: uncompress or overwrite error -6 - must RESET board to recover When I give a load address, it seems to work: Bytes transferred = 3953092 (3c51c4 hex) ## Loading kernel from FIT Image at 40008000 ... Using 'conf@8' configuration Trying 'kernel@1' kernel subimage Description: unavailable Type: Kernel Image Compression: gzip compressed Data Start: 0x400080c8 Data Size:3633253 Bytes = 3.5 MiB Architecture: ARM OS: Linux Load Address: 0x20008000 Entry Point: 0x20008000 Verifying Hash Integrity ... OK ## Loading fdt from FIT Image at 40008000 ... Using 'conf@8' configuration Trying 'fdt@8' fdt subimage Description: exynos5420-peach-pit-rev3.dtb Type: Flat Device Tree Compression: uncompressed Data Start: 0x403b19e0 Data Size:43298 Bytes = 42.3 KiB Architecture: ARM Hash algo:sha1 Hash value: 097dda51183eed6948ab942c57b14581c77ea22f Verifying Hash Integrity ... sha1+ OK Booting using the fdt blob at 0x403b19e0 Uncompressing Kernel Image ... OK Loading Device Tree to 3ffed000, end 3921 ... OK So I think it might be something to do with the load address. I'm going to fall back to code inspection... Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/27/2013 03:51 PM, Simon Glass wrote: Hi Stefan, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de mailto:s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm sub_command' can use the same code. Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code. Signed-off-by: Simon Glass s...@chromium.org mailto:s...@chromium.org Simon, this patch breaks bootm (at least on powerpc), while booting an compressed uImage (with DT). It just hangs while decompressing the kernel image: ## Booting kernel from Legacy Image at 0100 ... Image Name: Linux-3.5.7 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:2203312 Bytes = 2.1 MiB Load Address: Entry Point: ## Flattened Device Tree blob at 0180 Booting using the fdt blob at 0x180 Uncompressing Kernel Image ... I bisected mainline and this patch is the one that breaks booting: [stefan@ubuntu-2012 u-boot ((983c72f...)|BISECTING)]$ git bisect good 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 is the first bad commit commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 Author: Simon Glass s...@chromium.org mailto:s...@chromium.org Date: Tue Jun 11 11:14:47 2013 -0700 Refactor the bootm command to reduce code duplication I already looked what might be wrong but I couldn't find any problem upon a quick glance. You know this code may better. Perhaps you could take look at it and give it a try as well. I thought I had a repro, but it turned out to be that I was using kernel_noload so it was decompressing onto itself: Uncompressing Kernel Image (no loading done) ... LZO: uncompress or overwrite error -6 - must RESET board to recover When I give a load address, it seems to work: Bytes transferred = 3953092 (3c51c4 hex) ## Loading kernel from FIT Image at 40008000 ... Using 'conf@8' configuration Trying 'kernel@1' kernel subimage Description: unavailable Type: Kernel Image Compression: gzip compressed Data Start: 0x400080c8 Data Size:3633253 Bytes = 3.5 MiB Architecture: ARM OS: Linux Load Address: 0x20008000 Entry Point: 0x20008000 Verifying Hash Integrity ... OK ## Loading fdt from FIT Image at 40008000 ... Using 'conf@8' configuration Trying 'fdt@8' fdt subimage Description: exynos5420-peach-pit-rev3.dtb Type: Flat Device Tree Compression: uncompressed Data Start: 0x403b19e0 Data Size:43298 Bytes = 42.3 KiB Architecture: ARM Hash algo:sha1 Hash value: 097dda51183eed6948ab942c57b14581c77ea22f Verifying Hash Integrity ... sha1+ OK Booting using the fdt blob at 0x403b19e0 Uncompressing Kernel Image ... OK Loading Device Tree to 3ffed000, end 3921 ... OK So I think it might be something to do with the load address. I'm going to fall back to code inspection... Or FIT images? I couldn't come up with a working FIT image here (since my DDR starts at offset 0x8000 not 0x0 and it was dumping to much lower than my base, despite the entry/load in the .its file), but a simple uImage fails to work. - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRzJudAAoJENk4IS6UOR1WZkkQALHEtAd978EYUggvCMv7mZM3 iMLXbug7qhbTQe0PsEvkuQggwrZDGUpArqe3TRrNy6GPP9wvVHDI5D0WFQ0zPb3B 42W/Sejes5DvbCcjpSyoo113PCieoVH+csXODXWOb4Dp4+xIGDckmaQVs1yoK1j4 1/ofXihmSzdw8lHRZrTYTCSk6MxCYZYqjRv5hHGn6KZIptnSb/Koh7JXTuq+zPbV rJxpS8q7wKC43LPxLJr4VlGmUex/SoAhVbUvdt05ZU/xIiI9qXcLlI0mgPQOpGEP Zamqk6rZ6Kq2PxLuL/J81aiE1/cHwpMvDf7T++quSRP/4rX03wfvRhj9zJQbhlwB 8vcVx6kyBYWgBqX9bQUig81ij/oVE7huaGm0lhguO4TqmT490X8JMLeefT6N7bhr 3e8QJwOB0ZrnVBhi4Q7JyKZR1xNvNU0sgFBPGsdpHNcJDbscEs2puJtSuCYxTTbw QN7aHWOumdA1fT+OE+jj0HTO2tHh7sCGDOPpTQlnYAtSxz3yvgpJRHxJsAlbTa+l wpxmqa2s+cKqtQfra+SMMkXU6XiGnK8cqqH7ydpHJ8+5qZNBzn4QNU2xz9E7DJA9 lH7X980h+XQP69ClWkIHpshDVlLPoi8oiwBf828LAB13zJd/MgtL1L2K4bYSS2tK /jopfv09h/7xbUKhOi5j =2yZU -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote: Hi, Scott Sorry to reply to so late. Pls see my reply below. Regards Thanks Haijun. -Original Message- From: Wood Scott-B07421 Sent: Wednesday, May 22, 2013 6:24 AM To: Zhang Haijun-B42677 Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote: From: Haijun.Zhang haijun.zh...@freescale.com Add platform support for p1020rdb-pd Explain what is different about -pd and why this new revision requires a separate compile-time target. [Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on. They are all supported. Nand, DDR, Nor and Spi Flash are different between them. So I thinks they should be two separate board as P1020UTM and P1020MBG do. Put this information in the changelog. If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime? [Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file. Is there any reason why SPD would not be found? +#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD)) #if defined(CONFIG_P1020RDB) #define CONFIG_BOARDNAME P1020RDB-PC +#elif defined(CONFIG_P1020RDB_PD) +#define CONFIG_BOARDNAME P1020RDB-PD +#endif CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things. Could you reply to this one? ...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB-PC. :-) -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On 06/27/2013 07:17:48 AM, Tom Rini wrote: On Thu, Jun 27, 2013 at 02:35:34AM +, Zhang Ying-B40530 wrote: -Original Message- From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Tom Rini [snip] Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed? Did you also build am335x_evm_usbspl? It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mkimage: Build signing only if board has CONFIG_FIT_SIGNATURE
Hi Simon, On Thu, 27 Jun 2013 10:43:18 -0700, Simon Glass s...@chromium.org wrote: If CONFIG_FIT_SIGNATURE is not enabled, then mkimage will report a warning that signing is not supported. Not sure I understand this scenario. Can you develop? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface
Lukasz Majewski writes: This commit fixes problems with some non-standard requests send with device address instead of interface address (bmRequestType.Receipent field). This happens with dfu-util (debian version: 0.5), which address non standard requests (like w_value=0x21 and bRequest=GET_DESCRIPTOR) to device. Dear u-boot developers, The above comment seems to imply that dfu-util is sending non-standard requests. For the record, that would be wrong. dfu-util is sending a standard get descriptor request. These always go to the device, not to an interface. The descriptor it is asking for is, although not mandatory per the core USB standard, a class-specific descriptor which is part of the DFU 1.0 standard. So this is all standard. While on this topic, I would recommend that you include this descriptor in the configuration descriptor set, that is, in the complete configuration descriptor that the host OS usually requests during enumeration. Also this class-specific descriptor belongs here. In that case, the OS and libusb will keep a copy of this descriptor, and dfu-util will not have to send an explicit request (through libusb_get_descriptor()) to retrieve it. Without this fix, the above request is STALLED, and hence causes dfu-util to assume some standard configuration (packet size = 1024B instead of 4096B) Note that this number is the Maximum number of bytes that the device can accept per control-write transaction. The DFU transactions should work fine if a smaller packet size is used - as long as it is larger or equal to the bMaxPacketSize0. Of course, smaller packets will cause more overhead and be less efficient, but you must make sure that your device can handle this. I am not sure from these comments whether the smaller packet size caused errors in your implementation, or if the problem was just reduced performance. Best regards, Tormod Volden ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mkimage: Build signing only if board has CONFIG_FIT_SIGNATURE
On Thu, Jun 27, 2013 at 10:55:19PM +0200, Albert ARIBAUD wrote: Hi Simon, On Thu, 27 Jun 2013 10:43:18 -0700, Simon Glass s...@chromium.org wrote: If CONFIG_FIT_SIGNATURE is not enabled, then mkimage will report a warning that signing is not supported. Not sure I understand this scenario. Can you develop? mkimage is stand-alone and for example, some distributions build and ship a copy. If they build it without ssl stuff installed, their distribution shipped copy will not be able to make signed images. I'll make sure to spell things out in the release notes. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Thu, Jun 27, 2013 at 03:16:34PM -0500, Scott Wood wrote: On 06/27/2013 07:17:48 AM, Tom Rini wrote: On Thu, Jun 27, 2013 at 02:35:34AM +, Zhang Ying-B40530 wrote: -Original Message- From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Tom Rini [snip] Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed? Did you also build am335x_evm_usbspl? It builds OK for me with the ifdef removed. It adds 81 bytes to the SPL. I think we can live with that. Acked-by: Tom Rini tr...@ti.com -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/10 v5] powerpc/mpc85xx: support application without resetvec segment in the linker script
On Fri, Jun 21, 2013 at 07:36:09AM +0200, Wolfgang Denk wrote: Dear ying.zh...@freescale.com, In message 1371715468-21120-1-git-send-email-ying.zh...@freescale.com you wrote: --- a/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds +++ b/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds @@ -1,8 +1,5 @@ /* - * (C) Copyright 2006 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de - * - * Copyright 2009 Freescale Semiconductor, Inc. + * Copyright 2013 Freescale Semiconductor, Inc. Please never, ever modify existing copyright headers in any such way!! You MUST keeep existing entries (unless they are clearly wrong). NAK! Please address this NAK and make sure it's not also happening in the rest of the series. Thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/10 v5] Makefile: move the common makefile line to public area
On Thu, Jun 20, 2013 at 04:04:22PM +0800, ying.zh...@freescale.com wrote: From: Ying Zhang b40...@freescale.com Move the common makefile line shared by the SPL and non-SPL to the public area, so that we can avoid excessive SPL symbols. Some of them will be used by the SPL later. This patch is on top of the patch common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL. Signed-off-by: Ying Zhang b40...@freescale.com Acked-by: Tom Rini tr...@ti.com -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/10 v5] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL
On Thu, Jun 20, 2013 at 04:04:21PM +0800, ying.zh...@freescale.com wrote: From: Ying Zhang b40...@freescale.com There will need the environment in SPL for reasons other than network support (in particular, hwconfig contains info for how to set up DDR). Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT for environment in common/Makefile. Signed-off-by: Ying Zhang b40...@freescale.com Acked-by: Tom Rini tr...@ti.com -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/10 v5] powerpc/mpc85xx: support application without resetvec segment in the linker script
On Thu, Jun 27, 2013 at 5:01 PM, Tom Rini tr...@ti.com wrote: On Fri, Jun 21, 2013 at 07:36:09AM +0200, Wolfgang Denk wrote: Dear ying.zh...@freescale.com, In message 1371715468-21120-1-git-send-email-ying.zh...@freescale.com you wrote: --- a/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds +++ b/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds @@ -1,8 +1,5 @@ /* - * (C) Copyright 2006 - * Wolfgang Denk, DENX Software Engineering, w...@denx.de - * - * Copyright 2009 Freescale Semiconductor, Inc. + * Copyright 2013 Freescale Semiconductor, Inc. Please never, ever modify existing copyright headers in any such way!! You MUST keeep existing entries (unless they are clearly wrong). NAK! Please address this NAK and make sure it's not also happening in the rest of the series. Thanks! Unfortunately, this went in with the last batch: commit 5df572f0131cf5e0abd8ce4e8f57841b790c40d4 Author: Ying Zhang b40...@freescale.com Date: Mon May 20 14:07:23 2013 +0800 powerpc/mpc85xx: support application without resetvec segment in the linker Fortunately, while the change history on this patch says No change, the copyright screwup WAS a change, and does NOT exist in the committed version of the patch. Sometimes two wrongs do make a right. :) Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/10 v5] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL
This patch was On Thu, Jun 27, 2013 at 5:03 PM, Tom Rini tr...@ti.com wrote: On Thu, Jun 20, 2013 at 04:04:21PM +0800, ying.zh...@freescale.com wrote: From: Ying Zhang b40...@freescale.com There will need the environment in SPL for reasons other than network support (in particular, hwconfig contains info for how to set up DDR). Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT for environment in common/Makefile. Signed-off-by: Ying Zhang b40...@freescale.com Acked-by: Tom Rini tr...@ti.com A prior version of this patch was already applied. I'll sort out what needs to be done to get this patchset correct tomorrow. Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command
On Thu, Jun 27, 2013 at 6:50 AM, Zhang Haijun-B42677 b42...@freescale.com wrote: Fabio, Did you boot up from sdcard? If so save command will write to SD card. In this case write command will be failed. I'm not familiar with mx6 system. I don't know if there are some difference in Watermark Level Register (eSDHC_WML). Yes, I boot from sd card. Can you try removing CONFIG_SYS_FSL_ESDHC_USE_PIO from your board file? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] SMDK5250: Remove reduntant code
On 25/06/13 22:47, Rajeshwari Shinde wrote:
enum boot_mode is defined twice once in spl.h and also in
spl_boot.c, hence removing the same from spl_boot.c and including
the header file.
Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
---
arch/arm/include/asm/arch-exynos/spl.h |1 +
board/samsung/smdk5250/spl_boot.c | 10 +-
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/spl.h
b/arch/arm/include/asm/arch-exynos/spl.h
index 46b25a6..59bb7e0 100644
--- a/arch/arm/include/asm/arch-exynos/spl.h
+++ b/arch/arm/include/asm/arch-exynos/spl.h
@@ -32,6 +32,7 @@ enum boot_mode {
* pin values are the same across Exynos4 and Exynos5.
*/
BOOT_MODE_MMC = 4,
+ BOOT_MODE_EMMC = 8, /* EMMC4.4 */
BOOT_MODE_SERIAL = 20,
/* Boot based on Operating Mode pin settings */
BOOT_MODE_OM = 32,
diff --git a/board/samsung/smdk5250/spl_boot.c
b/board/samsung/smdk5250/spl_boot.c
index 98f2286..83275f1 100644
--- a/board/samsung/smdk5250/spl_boot.c
+++ b/board/samsung/smdk5250/spl_boot.c
@@ -26,6 +26,7 @@
#include asm/arch-exynos/dmc.h
#include asm/arch/clock.h
#include asm/arch/clk.h
+#include asm/arch/spl.h
#include clock_init.h
@@ -48,15 +49,6 @@ u32 irom_ptr_table[] = {
[USB_INDEX] = 0x02020070, /* iROM Function Pointer-USB boot*/
};
-enum boot_mode {
- BOOT_MODE_MMC = 4,
- BOOT_MODE_SERIAL = 20,
- BOOT_MODE_EMMC = 8, /* EMMC4.4 */
- /* Boot based on Operating Mode pin settings */
- BOOT_MODE_OM = 32,
- BOOT_MODE_USB, /* Boot using USB download */
-};
-
void *get_irom_func(int index)
{
return (void *)*(u32 *)irom_ptr_table[index];
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/7] ARM: prepare armv7.h to be included from assembly source
Hello Andre, diff --git a/arch/arm/include/asm/armv7.h b/arch/arm/include/asm/armv7.h index a73630b..20caa7c 100644 --- a/arch/arm/include/asm/armv7.h +++ b/arch/arm/include/asm/armv7.h @@ -23,7 +23,6 @@ */ #ifndef ARMV7_H #define ARMV7_H -#include linux/types.h /* Cortex-A9 revisions */ #define MIDR_CORTEX_A9_R0P1 0x410FC091 @@ -57,6 +56,9 @@ #define ARMV7_CLIDR_CTYPE_INSTRUCTION_DATA 3 #define ARMV7_CLIDR_CTYPE_UNIFIED4 +#ifndef __ASSEMBLY__ +#include linux/types.h + /* * CP15 Barrier instructions * Please note that we have separate barrier instructions in ARMv7 @@ -74,4 +76,6 @@ void v7_outer_cache_inval_all(void); void v7_outer_cache_flush_range(u32 start, u32 end); void v7_outer_cache_inval_range(u32 start, u32 end); +#endif /* ! __ASSEMBLY__ */ + #endif Instread of moving #include linux/types.h line, I'd like to suggest to add #ifndef __ASSEMBLY__ guard to include/linux/types.h. I think this is a more correct way of fixing. If I see Linux Kernel include/linux/types.h, typedefs are placed inside #ifndef __ASSEMBLEY__ .. #endif. On the other hand, include/linux/types.h of U-Boot does not have #ifndef __ASSEMBLY__ guard. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fs/ext4: caculate log2blksz from blksz, other its value = 0
Hi Albert, Eich On Thu, Jun 27, 2013 at 6:17 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Lan, On Thu, 27 Jun 2013 17:42:31 +0800, Lan Yixun (dlan) dennis.y...@gmail.com wrote: From: Lan Yixun (dlan) dennis.y...@gmail.com err: lt703a # ext4ls nand 3:0 Failed to mount ext2 filesystem... ** Unrecognized filesystem type ** bug may introduced by commit: commit 50ce4c07df1c98aabf4630b35152ed95a87242f7 Author: Egbert Eich e...@suse.com Date: Wed May 1 01:13:19 2013 + fs/ext4: Support device block sizes != 512 bytes Please make the commit summary a description of what is wrong and how it is fixed, and move the context (how the bug was found, console output, etc) after the commit message separator '---' below. Also, fix probably typo in the commit summary (first commit message line) (other for otherwise). Thanks for your comments I'm sending this patch mainly for pre-review, Eich, Can you have a look? Since you are original patch author. The problem here is that uboot can't mount ext4 filesystem with commit 50ce4c07df1 applied. As I looking into the code, we use hard-coded SECTOR_SIZE(512) previously, but now we introduce (block_dev_desc_t *)-log2blksz, and problem here is that I couldn't find where/when this value been set. And after calling do_ls()-fs_set_blk_dev(), the value of log2blksz we got is still 0 (initialized value), which I think it's not correct. As I haven't dig too much into the code, and just cook this as a quick fix.. I'm trying to solve this by calculating log2blksz from blksz. Signed-off-by: Lan Yixun (dlan) dennis.y...@gmail.com --- disk/part.c | 4 1 file changed, 4 insertions(+) diff --git a/disk/part.c b/disk/part.c index fc8404d..dbc94c4 100644 --- a/disk/part.c +++ b/disk/part.c @@ -551,6 +551,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, goto cleanup; } + (*dev_desc)-log2blksz = LOG2((*dev_desc)-blksz); + info-start = 0; info-size = (*dev_desc)-lba; info-blksz = (*dev_desc)-blksz; @@ -634,6 +636,8 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, goto cleanup; } + (*dev_desc)-log2blksz = LOG2((*dev_desc)-blksz); + ret = part; goto cleanup; Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Regards
Haijun.
-Original Message-
From: Wood Scott-B07421
Sent: Friday, June 28, 2013 4:10 AM
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421; Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang
Changming-R66093; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote:
Hi, Scott
Sorry to reply to so late.
Pls see my reply below.
Regards Thanks
Haijun.
-Original Message-
From: Wood Scott-B07421
Sent: Wednesday, May 22, 2013 6:24 AM
To: Zhang Haijun-B42677
Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang
Changming-R66093;
Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote:
From: Haijun.Zhang haijun.zh...@freescale.com
Add platform support for p1020rdb-pd
Explain what is different about -pd and why this new revision
requires
a separate compile-time target.
[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board
later on.
They are all supported. Nand, DDR, Nor and Spi Flash are different
between them.
So I thinks they should be two separate board as P1020UTM and P1020MBG
do.
Put this information in the changelog.
[Haijun Wrote:] change log you mean?
If it's due to raw DDR config, say so in the changelog. Is there
any way
we could read a revision register to select the proper DDR config at
runtime?
[Haijun Wrote:] Now we read DDR config from SPD fist, if not found
read from config file.
Is there any reason why SPD would not be found?
[Haijun Wrote:] If someone erase the I2C area(SPD EEPROM) by mistake or change
by other possible reason.
They will need to read from local config file to make sure uboot can working.
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
#if defined(CONFIG_P1020RDB)
#define CONFIG_BOARDNAME P1020RDB-PC
+#elif defined(CONFIG_P1020RDB_PD) #define CONFIG_BOARDNAME
+P1020RDB-PD
+#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC
revision.
Change it so that CONFIG_P1020RDB is set for all revisions of
P1020RDB,
and introduce CONFIG_P1020RDB-PC for PC-specific things.
Could you reply to this one?
...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB-
PC. :-)
[Haijun Wrote:] Oh, yes I agree. It a little strange to have -PD, but this
patch was aim at add new board p1020rdb-pd board. If need i'll send another
patch to change the config name for PC,RDB and PD.
I had send another patch(Mean v2 of this patch), pls give some advice.
Thanks in advance.
-Scott
---BeginMessage---
From: Haijun.Zhang haijun.zh...@freescale.com
Signed-off-by: Jerry Huang chang-ming.hu...@freescale.com
Signed-off-by: Haijun Zhang haijun.zh...@freescale.com
CC: Scott Wood scottw...@freescale.com
CC: Sun Yusong-R58495 york...@freescale.com
---
board/freescale/p1_p2_rdb_pc/ddr.c | 2 +-
board/freescale/p1_p2_rdb_pc/tlb.c | 2 +-
boards.cfg | 4
include/configs/p1_p2_rdb_pc.h | 48 --
4 files changed, 52 insertions(+), 4 deletions(-)
diff --git a/board/freescale/p1_p2_rdb_pc/ddr.c
b/board/freescale/p1_p2_rdb_pc/ddr.c
index 9355536..262fd36 100644
--- a/board/freescale/p1_p2_rdb_pc/ddr.c
+++ b/board/freescale/p1_p2_rdb_pc/ddr.c
@@ -80,7 +80,7 @@ dimm_params_t ddr_raw_timing = {
.refresh_rate_ps = 780,
.tFAW_ps = 3,
};
-#elif defined(CONFIG_P1020MBG)
+#elif (defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD))
/* Micron MT41J512M8_187E */
dimm_params_t ddr_raw_timing = {
.n_ranks = 2,
diff --git a/board/freescale/p1_p2_rdb_pc/tlb.c
b/board/freescale/p1_p2_rdb_pc/tlb.c
index 3e4dffd..e19002f 100644
--- a/board/freescale/p1_p2_rdb_pc/tlb.c
+++ b/board/freescale/p1_p2_rdb_pc/tlb.c
@@ -110,7 +110,7 @@ struct fsl_e_tlb_entry tlb_table[] = {
MAS3_SX|MAS3_SW|MAS3_SR, 0,
0, 8, BOOKE_PAGESZ_1G, 1),
-#ifdef CONFIG_P1020MBG
+#if defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD)
/* 2G DDR on P1020MBG, map the second 1G */
SET_TLB_ENTRY(1, CONFIG_SYS_DDR_SDRAM_BASE + 0x4000,
CONFIG_SYS_DDR_SDRAM_BASE + 0x4000,
diff --git a/boards.cfg b/boards.cfg
index 35f38f3..aefff92 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -768,6 +768,10 @@ P1020RDB-PC_SDCARD powerpc mpc85xx
p1_p2_rdb_pcfreesca
P1020RDB-PC_SPIFLASH powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1020RDB,SPIFLASH
P1020RDB_SDCARD powerpc mpc85xx p1_p2_rdb
freescale - P1_P2_RDB:P1020RDB,SDCARD
P1020RDB_SPIFLASHpowerpc mpc85xx p1_p2_rdb
freescale -
[U-Boot] [PATCH v4 2/2] vf610twr: Remove SoC name from U-Boot prompt
We've been dropping SoC name from U-Boot prompt as it increase complexity for automatic testing and makes line longer for no good reason. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- Changes in v4: None Changes in v3: None Changes in v2: None include/configs/vf610twr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/vf610twr.h b/include/configs/vf610twr.h index 9474aeb..41d7d9a 100644 --- a/include/configs/vf610twr.h +++ b/include/configs/vf610twr.h @@ -177,7 +177,7 @@ #define CONFIG_SYS_LONGHELP/* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 -#define CONFIG_SYS_PROMPT Vybrid U-Boot +#define CONFIG_SYS_PROMPT = #undef CONFIG_AUTO_COMPLETE #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ #define CONFIG_SYS_PBSIZE \ -- 1.8.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 1/2] vf610twr: Add default environment in line with other Freescale boards
This adds a default environment which should be able to support both
3.0.15 from Timesys and upcoming 3.11.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- revert sys text address change (Alison)
- add mem=128M to bootargs/netargs (Andy)
Changes in v3:
- add dt boot support
- use ttyLP1 as console
- change loadaddr and sys text as iMX6SL
- NOTE: It needs to be boot tested as I don't have the board
Changes in v2:
- fix console for ttymxc1 (Fabio)
include/configs/vf610twr.h | 91 +-
1 file changed, 89 insertions(+), 2 deletions(-)
diff --git a/include/configs/vf610twr.h b/include/configs/vf610twr.h
index 77fe893..9474aeb 100644
--- a/include/configs/vf610twr.h
+++ b/include/configs/vf610twr.h
@@ -83,8 +83,96 @@
#define CONFIG_BOOTDELAY 3
+#define CONFIG_LOADADDR0x8200
#define CONFIG_SYS_TEXT_BASE 0x3f008000
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ script=boot.scr\0 \
+ uimage=uImage\0 \
+ console=ttyLP1\0 \
+ fdt_high=0x\0 \
+ initrd_high=0x\0 \
+ fdt_file=vf610-twr.dtb\0 \
+ fdt_addr=0x8100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
+ mmcdev= __stringify(CONFIG_SYS_MMC_ENV_DEV) \0 \
+ mmcpart=1\0 \
+ mmcroot=/dev/mmcblk0p2 rootwait rw\0 \
+ update_sd_firmware_filename=u-boot.imx\0 \
+ update_sd_firmware= \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ if mmc dev ${mmcdev}; then\
+ if ${get_cmd} ${update_sd_firmware_filename}; then \
+ setexpr fw_sz ${filesize} / 0x200; \
+ setexpr fw_sz ${fw_sz} + 1; \
+ mmc write ${loadaddr} 0x2 ${fw_sz}; \
+ fi; \
+ fi\0 \
+ mmcargs=setenv bootargs console=${console},${baudrate} \
+ root=${mmcroot} mem=128M\0 \
+ loadbootscript= \
+ fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
+ bootscript=echo Running bootscript from mmc ...; \
+ source\0 \
+ loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0 \
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
+ mmcboot=echo Booting from mmc ...; \
+ run mmcargs; \
+ if test ${boot_fdt} = yes || test ${boot_fdt} = try; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
+ netargs=setenv bootargs console=${console},${baudrate} \
+ root=/dev/nfs mem=128M \
+ ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
+ netboot=echo Booting from net ...; \
+ run netargs; \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes || test ${boot_fdt} = try; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
+
+#define CONFIG_BOOTCOMMAND \
+ mmc dev ${mmcdev}; if mmc rescan; then \
+ if run loadbootscript; then \
+ run bootscript; \
+ else \
+ if run loaduimage; then \
+ run mmcboot; \
+ else run netboot; \
+ fi; \
+ fi; \
+ else run netboot; fi
+
/* Miscellaneous configurable options */
#define CONFIG_SYS_LONGHELP/* undef to save memory */
#define CONFIG_SYS_HUSH_PARSER /* use hush command parser */
@@ -101,8 +189,7 @@
#define CONFIG_SYS_MEMTEST_START
Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command
On Thu, Jun 27, 2013 at 11:00 PM, Zhang Haijun-B42677 b42...@freescale.com wrote: My board use DMA to transfer data by default. So we don't use CONFIG_SYS_FSL_ESDHC_USE_PIO by default. Also my board works fine with PIO mode(with my patch). What about your board? Using PIO? We use DMA on i.MX. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 1/2] vf610twr: Add default environment in line with other Freescale boards
On Thu, Jun 27, 2013 at 10:59 PM, Otavio Salvador
ota...@ossystems.com.br wrote:
This adds a default environment which should be able to support both
3.0.15 from Timesys and upcoming 3.11.
Signed-off-by: Otavio Salvador ota...@ossystems.com.br
---
Changes in v4:
- revert sys text address change (Alison)
- add mem=128M to bootargs/netargs (Andy)
Just curious: why do we need to pass mem=128M?
Changes in v3:
- add dt boot support
- use ttyLP1 as console
- change loadaddr and sys text as iMX6SL
- NOTE: It needs to be boot tested as I don't have the board
Changes in v2:
- fix console for ttymxc1 (Fabio)
include/configs/vf610twr.h | 91
+-
1 file changed, 89 insertions(+), 2 deletions(-)
diff --git a/include/configs/vf610twr.h b/include/configs/vf610twr.h
index 77fe893..9474aeb 100644
--- a/include/configs/vf610twr.h
+++ b/include/configs/vf610twr.h
@@ -83,8 +83,96 @@
#define CONFIG_BOOTDELAY 3
+#define CONFIG_LOADADDR0x8200
#define CONFIG_SYS_TEXT_BASE 0x3f008000
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ script=boot.scr\0 \
+ uimage=uImage\0 \
+ console=ttyLP1\0 \
+ fdt_high=0x\0 \
+ initrd_high=0x\0 \
+ fdt_file=vf610-twr.dtb\0 \
+ fdt_addr=0x8100\0 \
+ boot_fdt=try\0 \
+ ip_dyn=yes\0 \
+ mmcdev= __stringify(CONFIG_SYS_MMC_ENV_DEV) \0 \
+ mmcpart=1\0 \
+ mmcroot=/dev/mmcblk0p2 rootwait rw\0 \
+ update_sd_firmware_filename=u-boot.imx\0 \
+ update_sd_firmware= \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ if mmc dev ${mmcdev}; then\
+ if ${get_cmd} ${update_sd_firmware_filename}; then
\
+ setexpr fw_sz ${filesize} / 0x200; \
+ setexpr fw_sz ${fw_sz} + 1; \
+ mmc write ${loadaddr} 0x2 ${fw_sz}; \
+ fi; \
+ fi\0 \
+ mmcargs=setenv bootargs console=${console},${baudrate} \
+ root=${mmcroot} mem=128M\0 \
+ loadbootscript= \
+ fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0 \
+ bootscript=echo Running bootscript from mmc ...; \
+ source\0 \
+ loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0
\
+ loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0 \
+ mmcboot=echo Booting from mmc ...; \
+ run mmcargs; \
+ if test ${boot_fdt} = yes || test ${boot_fdt} = try; then \
+ if run loadfdt; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0 \
+ netargs=setenv bootargs console=${console},${baudrate} \
+ root=/dev/nfs mem=128M \
+ ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0 \
+ netboot=echo Booting from net ...; \
+ run netargs; \
+ if test ${ip_dyn} = yes; then \
+ setenv get_cmd dhcp; \
+ else \
+ setenv get_cmd tftp; \
+ fi; \
+ ${get_cmd} ${uimage}; \
+ if test ${boot_fdt} = yes || test ${boot_fdt} = try; then \
+ if ${get_cmd} ${fdt_addr} ${fdt_file}; then \
+ bootm ${loadaddr} - ${fdt_addr}; \
+ else \
+ if test ${boot_fdt} = try; then \
+ bootm; \
+ else \
+ echo WARN: Cannot load the DT; \
+ fi; \
+ fi; \
+ else \
+ bootm; \
+ fi;\0
+
+#define CONFIG_BOOTCOMMAND \
+ mmc dev ${mmcdev}; if mmc rescan; then \
+ if run loadbootscript; then \
+ run bootscript; \
+ else \
+ if run loaduimage; then \
+ run mmcboot; \
+ else run netboot; \
+ fi; \
+ fi; \
+ else run netboot; fi
+
/*
Re: [U-Boot] [PATCH v4 1/2] vf610twr: Add default environment in line with other Freescale boards
On Thu, Jun 27, 2013 at 11:03 PM, Fabio Estevam feste...@gmail.com wrote: On Thu, Jun 27, 2013 at 10:59 PM, Otavio Salvador ota...@ossystems.com.br wrote: This adds a default environment which should be able to support both 3.0.15 from Timesys and upcoming 3.11. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- Changes in v4: - revert sys text address change (Alison) - add mem=128M to bootargs/netargs (Andy) Just curious: why do we need to pass mem=128M? Board fails to boot otherwise ... Andy did try it so he can explain it with more detail. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command
On Thu, Jun 27, 2013 at 11:06 PM, Zhang Haijun-B42677 b42...@freescale.com wrote: How about the read write command and erase command in your uboot with my patch? I mean this: mmcinfo mmc read addr blk# cnt mmc write addr blk# cnt mmc erase blk# cnt mmc rescan mmc part - lists available partition on current mmc device mmc dev [dev] [part] - show or set current mmc device [partition] mmc list - lists available devices I don't have the board handy to try, but your patch introduced a bug by inverting the ifdef logic from commit 7b43db92. And you never explained why you need 48e0b2bd, which board shows the issue, what is the issue, etc. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
On 06/27/2013 08:55:26 PM, Zhang Haijun-B42677 wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, June 28, 2013 4:10 AM To: Zhang Haijun-B42677 Cc: Wood Scott-B07421; Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote: Hi, Scott Sorry to reply to so late. Pls see my reply below. Regards Thanks Haijun. -Original Message- From: Wood Scott-B07421 Sent: Wednesday, May 22, 2013 6:24 AM To: Zhang Haijun-B42677 Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote: From: Haijun.Zhang haijun.zh...@freescale.com Add platform support for p1020rdb-pd Explain what is different about -pd and why this new revision requires a separate compile-time target. [Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on. They are all supported. Nand, DDR, Nor and Spi Flash are different between them. So I thinks they should be two separate board as P1020UTM and P1020MBG do. Put this information in the changelog. [Haijun Wrote:] change log you mean? The git commit message. If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime? [Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file. Is there any reason why SPD would not be found? [Haijun Wrote:] If someone erase the I2C area(SPD EEPROM) by mistake or change by other possible reason. They will need to read from local config file to make sure uboot can working. I don't think we normally provide backup DDR config for such a case. There are many other, easier ways the user can accidentally screw up the system (e.g. they could erase U-Boot). And it would get little to no testing, so likely bitrot or otherwise not work (e.g. the board starts shipping with different RAM, or the settings were never quite right to begin with). +#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD)) #if defined(CONFIG_P1020RDB) #define CONFIG_BOARDNAME P1020RDB-PC +#elif defined(CONFIG_P1020RDB_PD) #define CONFIG_BOARDNAME +P1020RDB-PD +#endif CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things. Could you reply to this one? ...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB- PC. :-) [Haijun Wrote:] Oh, yes I agree. It a little strange to have -PD, but this patch was aim at add new board p1020rdb-pd board. If need i'll send another patch to change the config name for PC,RDB and PD. I had send another patch(Mean v2 of this patch), pls give some advice. Respin that patch so that CONFIG_P1020RDB is set for all revisions of p1020rdb, and either CONFIG_P1020RDB_PC or CONFIG_P1020RDB_PD is specified to indicated the revision. -SCott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication
Hi Stefan, I can create something with or without compression and I cannot see the failure. Tom is seeing it though. I will see if I can get another board to try. If you have any ideas please let me know. scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 1 Ethernet Device(s) found Waiting for Ethernet connection... done. BOOTP broadcast 1 *** Unhandled DHCP Option in OFFER/ACK: 2 *** Unhandled DHCP Option in OFFER/ACK: 176 *** Unhandled DHCP Option in OFFER/ACK: 35 *** Unhandled DHCP Option in OFFER/ACK: 208 *** Unhandled DHCP Option in OFFER/ACK: 242 *** Unhandled DHCP Option in OFFER/ACK: 101 *** Unhandled DHCP Option in OFFER/ACK: 119 *** Unhandled DHCP Option in OFFER/ACK: 42 *** Unhandled DHCP Option in OFFER/ACK: 2 *** Unhandled DHCP Option in OFFER/ACK: 176 *** Unhandled DHCP Option in OFFER/ACK: 35 *** Unhandled DHCP Option in OFFER/ACK: 208 *** Unhandled DHCP Option in OFFER/ACK: 242 *** Unhandled DHCP Option in OFFER/ACK: 101 *** Unhandled DHCP Option in OFFER/ACK: 119 *** Unhandled DHCP Option in OFFER/ACK: 42 DHCP client bound to address 172.22.83.47 Using asx0 device TFTP from server 172.22.83.1; our IP address is 172.22.83.47 Filename '/var/lib/tftpboot/image.plain'. Load address: 0x40008000 Loading: # # # # # # # # ## 4.4 MiB/s done Bytes transferred = 8183088 (7cdd30 hex) Using asx0 device TFTP from server 172.22.83.1; our IP address is 172.22.83.47 Filename '/var/lib/tftpboot/exynos5420-peach-pit-rev3.dtb'. Load address: 0x4100 Loading: ### 640.6 KiB/s done Bytes transferred = 43298 (a922 hex) * kernel: cmdline image address = 0x40008000 ## Booting kernel from Legacy Image at 40008000 ... Image Name: plain Image Type: ARM Linux Kernel Image (uncompressed) Data Size:8183024 Bytes = 7.8 MiB Load Address: 20008000 Entry Point: 20008000 Verifying Checksum ... OK kernel data at 0x40008040, len = 0x007cdcf0 (8183024) ## Flattened Device Tree blob at 4100 Booting using the fdt blob at 0x4100 Loading Kernel Image ... load_buff=20008000, image_buf=40008040, image_len=7cdcf0 OK OK kernel loaded at 0x20008000, end = 0x207d5cf0 load_end = 207d5cf0 Loading Device Tree to 3ffed000, end 3921 ... OK boot_kernel.c: ft_board_setup: warning: g_crossystem_data is NULL Starting kernel ... Regards, SImon On Thu, Jun 27, 2013 at 12:51 PM, Simon Glass s...@chromium.org wrote: Hi Stefan, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm sub_command' can use the same code. Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code. Signed-off-by: Simon Glass s...@chromium.org Simon, this patch breaks bootm (at least on powerpc), while booting an compressed uImage (with DT). It just hangs while decompressing the kernel image: ## Booting kernel from Legacy Image at 0100 ... Image Name: Linux-3.5.7 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:2203312 Bytes = 2.1 MiB Load Address: Entry Point: ## Flattened Device Tree blob at 0180 Booting using the fdt blob at 0x180 Uncompressing Kernel Image ... I bisected mainline and this patch is the one that breaks booting: [stefan@ubuntu-2012 u-boot ((983c72f...)|BISECTING)]$ git bisect good 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 is the first bad commit commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 Author: Simon Glass s...@chromium.org Date: Tue Jun 11 11:14:47 2013 -0700 Refactor the bootm command to reduce code duplication I already looked what might be wrong but I couldn't find any problem upon a quick glance. You know this code may better. Perhaps you could take look at it and give it a try as well. I thought I had a repro, but it turned out to be that I was using kernel_noload
Re: [U-Boot] [PATCH v4 1/2] vf610twr: Add default environment in line with other Freescale boards
On Thu, Jun 27, 2013 at 11:12 PM, Otavio Salvador ota...@ossystems.com.br wrote: Just curious: why do we need to pass mem=128M? Board fails to boot otherwise ... Andy did try it so he can explain it with more detail. Hmm...Is DDR being incorrectly configured then? We need to understand why this happens. Andy, can you comment on this, please? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Regards Haijun. -Original Message- From: Zhang Haijun-B42677 Sent: Friday, June 28, 2013 9:55 AM To: Wood Scott-B07421 Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; sun york-R58495 Subject: RE: [U-Boot] [PATCH] p1020rdb-pd: platform support Regards Haijun. -Original Message- From: Wood Scott-B07421 Sent: Friday, June 28, 2013 4:10 AM To: Zhang Haijun-B42677 Cc: Wood Scott-B07421; Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote: Hi, Scott Sorry to reply to so late. Pls see my reply below. Regards Thanks Haijun. -Original Message- From: Wood Scott-B07421 Sent: Wednesday, May 22, 2013 6:24 AM To: Zhang Haijun-B42677 Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang Changming-R66093; Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote: From: Haijun.Zhang haijun.zh...@freescale.com Add platform support for p1020rdb-pd Explain what is different about -pd and why this new revision requires a separate compile-time target. [Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on. They are all supported. Nand, DDR, Nor and Spi Flash are different between them. So I thinks they should be two separate board as P1020UTM and P1020MBG do. Put this information in the changelog. [Haijun Wrote:] change log you mean? If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime? [Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file. Is there any reason why SPD would not be found? [Haijun Wrote:] If someone erase the I2C area(SPD EEPROM) by mistake or change by other possible reason. They will need to read from local config file to make sure uboot can working. +#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD)) #if defined(CONFIG_P1020RDB) #define CONFIG_BOARDNAME P1020RDB-PC +#elif defined(CONFIG_P1020RDB_PD) #define CONFIG_BOARDNAME +P1020RDB-PD +#endif CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things. Could you reply to this one? ...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB- PC. :-) [Haijun Wrote:] Oh, yes I agree. It a little strange to have -PD, but this patch was aim at add new board p1020rdb-pd board. If need i'll send another patch to change the config name for PC,RDB and PD. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/7] ARM: add secure monitor handler to switch to non-secure state
Hi, Andre +_secure_vectors: + .word 0 /* reset */ + .word 0 /* undef */ + adr pc, _secure_monitor + .word 0 + .word 0 + .word 0 + .word 0 + .word 0 + .word 0 /* pad */ I think _monitor_vectors seems more precise name than _secure_vectors. For example, MVBAR is a short for Monitor Vector Base Address Register. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
