date:20220720

RE: [PATCH] spi: cadence_ospi_versal: Reset ospi controller using reset driver api's

2022-07-20 Thread Soma, Ashok Reddy

Hi,

Please ignore this patch. I will send this as part of another patch series.

Thanks,
Ashok

-Original Message-
From: Ashok Reddy Soma  
Sent: Wednesday, July 20, 2022 3:36 PM
To: u-boot@lists.denx.de
Cc: ja...@amarulasolutions.com; Simek, Michal ; 
g...@xilinx.com; git (AMD-Xilinx) ; Reddy, T Karthik 
; Ashok Reddy Soma 
Subject: [PATCH] spi: cadence_ospi_versal: Reset ospi controller using reset 
driver api's

From: T Karthik Reddy 

Add a new function to reset the ospi controller. Use reset_assert, 
reset_deassert api's to reset the ospi controller. In mini U-Boot case as 
ZYNQMP_FIRMWARE config is disabled, reset the controller directly using 
register writes.

Signed-off-by: T Karthik Reddy 
Signed-off-by: Ashok Reddy Soma 
---

 arch/arm/mach-versal/include/mach/hardware.h |  1 +
 drivers/spi/cadence_ospi_versal.c| 29 
 drivers/spi/cadence_qspi.h   |  1 +
 3 files changed, 31 insertions(+)

diff --git a/arch/arm/mach-versal/include/mach/hardware.h 
b/arch/arm/mach-versal/include/mach/hardware.h
index 000af974e8..429765234f 100644
--- a/arch/arm/mach-versal/include/mach/hardware.h
+++ b/arch/arm/mach-versal/include/mach/hardware.h
@@ -61,6 +61,7 @@ struct rpu_regs {
 #define VERSAL_SLCR_BASEADDR   0xF106
 #define VERSAL_AXI_MUX_SEL (VERSAL_SLCR_BASEADDR + 0x504)
 #define VERSAL_OSPI_LINEAR_MODEBIT(1)
+#define VERSAL_OSPI_CTRL_RST   (VERSAL_CRP_BASEADDR + 0x304)
 
 struct crp_regs {
u32 reserved0[128];
diff --git a/drivers/spi/cadence_ospi_versal.c 
b/drivers/spi/cadence_ospi_versal.c
index 52bcad053f..a9c5daff20 100644
--- a/drivers/spi/cadence_ospi_versal.c
+++ b/drivers/spi/cadence_ospi_versal.c
@@ -127,6 +127,35 @@ int cadence_qspi_apb_wait_for_dma_cmplt(struct 
cadence_spi_plat *plat)
return 0;
 }
 
+int cadence_spi_versal_ctrl_reset(struct cadence_spi_priv *priv) {
+   int ret;
+
+   if (CONFIG_IS_ENABLED(ZYNQMP_FIRMWARE)) {
+   /* Assert ospi controller */
+   ret = reset_assert(priv->resets->resets);
+   if (ret)
+   return ret;
+
+   udelay(10);
+
+   /* Deassert ospi controller */
+   ret = reset_deassert(priv->resets->resets);
+   if (ret)
+   return ret;
+   } else {
+   /* Assert ospi controller */
+   setbits_le32((u32 *)VERSAL_OSPI_CTRL_RST, 1);
+
+   udelay(10);
+
+   /* Deassert ospi controller */
+   clrbits_le32((u32 *)VERSAL_OSPI_CTRL_RST, 1);
+   }
+
+   return 0;
+}
+
 #if defined(CONFIG_DM_GPIO)
 int cadence_spi_versal_flash_reset(struct udevice *dev)  { diff --git 
a/drivers/spi/cadence_qspi.h b/drivers/spi/cadence_qspi.h index 
c8d16bb0e4..3f5f45282d 100644
--- a/drivers/spi/cadence_qspi.h
+++ b/drivers/spi/cadence_qspi.h
@@ -285,5 +285,6 @@ int cadence_qspi_apb_wait_for_dma_cmplt(struct 
cadence_spi_plat *plat);  int cadence_qspi_apb_exec_flash_cmd(void *reg_base, 
unsigned int reg);  int cadence_qspi_versal_flash_reset(struct udevice *dev);  
void cadence_qspi_apb_enable_linear_mode(bool enable);
+int cadence_spi_versal_ctrl_reset(struct cadence_spi_priv *priv);
 
 #endif /* __CADENCE_QSPI_H__ */
--
2.17.1

[RFCv1] CI: Move to Ubuntu 2022.04 "Jammy" for CI base

2022-07-20 Thread Tom Rini

- We now have a new enough sbsigntools in the distro, stop building.
- Use the 20220531 tag for Jammy.
- Move to pygit2 1.9.2 (current version) as the old one doesn't build on
 "Jammy".
- Add the working directory to the list of safe directories for git.
- Adjust where we have "exit on error" set in some scripts due to
  pylibfdt needing to be updated for python distutils deprecation.
- Move to pytest 6.2.5 to address other issues.
- Cleanup Azure logic a little bit.

Signed-off-by: Tom Rini 
---
Note that in both CI cases, pylint and binman, etc, test jobs both fail
and need further investigation.
---
 .azure-pipelines.yml | 12 ++--
 .gitlab-ci.yml   | 10 --
 test/py/requirements.txt |  4 ++--
 tools/docker/Dockerfile  | 14 ++
 4 files changed, 18 insertions(+), 22 deletions(-)

diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index bc2b437bd999..f57ae92a200d 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -2,7 +2,7 @@ variables:
   windows_vm: windows-2019
   ubuntu_vm: ubuntu-18.04
   macos_vm: macOS-10.15
-  ci_runner_image: trini/u-boot-gitlab-ci-runner:focal-20220302-15Mar2022
+  ci_runner_image: trini/u-boot-gitlab-ci-runner:jammy-20220531-13Jul2022
   # Add '-u 0' options for Azure pipelines, otherwise we get "permission
   # denied" error when it tries to "useradd -m -u 1001 vsts_azpcontainer",
   # since our $(ci_runner_image) user is not root.
@@ -171,12 +171,10 @@ stages:
 steps:
   - script: |
   cat << EOF > build.sh
-  set -ex
-  cd ${WORK_DIR}
-  EOF
-  cat << "EOF" >> build.sh
+  cd $(work_dir)
   git config --global user.name "Azure Pipelines"
   git config --global user.email bmeng...@gmail.com
+  git config --global --add safe.directory $(work_dir)
   export USER=azure
   virtualenv -p /usr/bin/python3 /tmp/venv
   . /tmp/venv/bin/activate
@@ -185,6 +183,7 @@ stages:
   export PYTHONPATH=${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt
   export PATH=${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}
   ./tools/buildman/buildman -T0 -o ${UBOOT_TRAVIS_BUILD_DIR} -w 
--board sandbox_spl
+  set -ex
   ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools test
   ./tools/buildman/buildman -t
   ./tools/dtoc/dtoc -t
@@ -217,7 +216,7 @@ stages:
   options: $(container_option)
 steps:
   - script: |
-  cd ${WORK_DIR}
+  git config --global --add safe.directory $(work_dir)
   export USER=azure
   pip install -r test/py/requirements.txt
   pip install asteval pylint==2.12.2 pyopenssl
@@ -226,6 +225,7 @@ stages:
   echo "load-plugins=pylint.extensions.docparams" >> .pylintrc
   export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl
   ./tools/buildman/buildman -T0 -o ${UBOOT_TRAVIS_BUILD_DIR} -w 
--board sandbox_spl
+  set -ex
   pylint --version
   export PYTHONPATH=${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt
   make pylint_err
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index f9cd41750791..5082ad7599c8 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -2,7 +2,7 @@
 
 # Grab our configured image.  The source for this is found at:
 # https://source.denx.de/u-boot/gitlab-ci-runner
-image: trini/u-boot-gitlab-ci-runner:focal-20220302-15Mar2022
+image: trini/u-boot-gitlab-ci-runner:jammy-20220531-13Jul2022
 
 # We run some tests in different order, to catch some failures quicker.
 stages:
@@ -199,15 +199,18 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
   script:
 - git config --global user.name "GitLab CI Runner";
   git config --global user.email tr...@konsulko.com;
+  git config --global --add safe.directory "${CI_PROJECT_DIR}";
   export USER=gitlab;
   virtualenv -p /usr/bin/python3 /tmp/venv;
   . /tmp/venv/bin/activate;
   pip install -r test/py/requirements.txt;
+  set +e
   export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
   export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
   export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";
   ./tools/buildman/buildman -T0 -o ${UBOOT_TRAVIS_BUILD_DIR} -w
 --board sandbox_spl;
+  set -e
   ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools test;
   ./tools/buildman/buildman -t;
   ./tools/dtoc/dtoc -t;
@@ -224,14 +227,17 @@ Run tests for Nokia RX-51 (aka N900):
 Run pylint:
   stage: testsuites
   script:
+- git config --global --add safe.directory "${CI_PROJECT_DIR}"
 - pip install -r test/py/requirements.txt
 - pip install asteval pylint==2.12.2 pyopenssl
 - export PATH=${PATH}:~/.local/bin
 - echo "[MASTER]" >> .pylintrc
 - echo "load-plugins=pylint.extensions.docparams" >> .pylintrc
 - export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl
-- ./tools/buildman/buildman -T0

Re: [PATCH 3/4] ARM: imx8: DH: Use common mac address functions

2022-07-20 Thread Marek Vasut


On 7/4/22 13:11, Philip Oberfichtner wrote:

To reduce code duplication, let the imx8 based DH boards use the common
code for setting up their mac addresses.

Signed-off-by: Philip Oberfichtner 


Tested-by: Marek Vasut

Re: [PATCH 1/4] board: dhelectronics: Implement common mac address functions

2022-07-20 Thread Marek Vasut


On 7/4/22 13:11, Philip Oberfichtner wrote:

[...]


+++ b/board/dhelectronics/common/dh_common.c
@@ -0,0 +1,64 @@


[...]


+int dh_get_mac_from_eeprom(unsigned char *enetaddr, const char *alias)
+{
+   struct udevice *dev;
+   int ret, offset;
+
+   offset = fdt_path_offset(gd->fdt_blob, alias);
+   if (offset < 0) {
+   printf("%s: Path offset for %s not found! Error %d\n", 
__func__, alias, offset);


Use "ret = %d" instead of "Error %d" consistently with the rest of this 
function.



+   return offset;
+   }
+
+   ret = uclass_get_device_by_of_offset(UCLASS_I2C_EEPROM, offset, );
+   if (ret) {
+   printf("%s: Cannot find EEPROM! ret =  %d\n", __func__, ret);


Two spaces between "ret =" and "%d"

[...]

Re: [PATCH 4/4] ARM: stm32: DH: Use common mac address functions

2022-07-20 Thread Marek Vasut


On 7/4/22 13:11, Philip Oberfichtner wrote:

To reduce code duplication, let the stm32 based DH boards use the common
code for setting up their mac addresses.

Signed-off-by: Philip Oberfichtner 


"MAC address" is written in capitals , please fix the lowercase 'mac' 
all over the place  and make it uppercase (except for function names, 
there is should stay lowercase).


Tested-by: Marek Vasut

Re: [PATCH 2/4] ARM: imx6: DH: Use common mac address functions

2022-07-20 Thread Marek Vasut


On 7/4/22 13:11, Philip Oberfichtner wrote:

To reduce code duplication, let the imx6 based DH boards use the common
code for setting up their mac addresses.

Signed-off-by: Philip Oberfichtner 


Tested-by: Marek Vasut

Re: [PATCH 01/19] video: Renname vbe.h to vesa.h

2022-07-20 Thread Bin Meng

Hi Simon,

On Thu, Jul 21, 2022 at 1:00 AM Simon Glass  wrote:
>
> We want to use VBE to mean Verfiied Boot for Embedded in U-Boot. Rename

typo: Verified

Is there a doc link to describe the Verified Boot for Embedded ? Just
want to make sure if this acronym is the correct one to replace
another existing and old VBE.

> the existing VBE (Vesa BIOS extensions) to allow this.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/lib/bios.c | 2 +-
>  arch/x86/lib/coreboot_table.c   | 2 +-
>  arch/x86/lib/fsp/fsp_graphics.c | 2 +-
>  cmd/elf.c   | 2 +-
>  drivers/bios_emulator/atibios.c | 2 +-
>  drivers/pci/pci_rom.c   | 2 +-
>  drivers/video/broadwell_igd.c   | 2 +-
>  drivers/video/coreboot.c| 2 +-
>  drivers/video/efi.c | 2 +-
>  drivers/video/ivybridge_igd.c   | 2 +-
>  drivers/video/vesa.c| 2 +-
>  include/{vbe.h => vesa.h}   | 4 ++--
>  lib/elf.c   | 2 +-
>  13 files changed, 14 insertions(+), 14 deletions(-)
>  rename include/{vbe.h => vesa.h} (98%)
>

Regards,
Bin

Re: [PATCH v2] Improve Windows build documentation

2022-07-20 Thread Bin Meng

On Wed, Jul 20, 2022 at 11:00 PM Martin Bonner
 wrote:
>
> I have recently build the u-boot tools on Windows and ran into
> difficulties.  This patch to the documentation would have avoided
> those difficulties.  Contentious points:
>
> * While I have run the document through a rst previewer, I haven't run
> the full test suite.  I know, I know, everyone thinks _they_ don't
> need to run the tests because reasons, but I think it's true this
> time.
> * I have removed the version numbers from the list of packages.  I
> don't think they are helpful, and are just maintenance overhead.  (I
> don't think I got those versions for example).
>
> I'd be grateful if @Bin Meng could review this, because `git blame`
> says the file I am changing is all his.
>
> No actual changes, but hopefully closer to the required formalities:
>

The above commit message should be completely rewritten. It should be
considered to formally describe what has changed in this commit,
something like:

Add missing dependencies to build U-Boot host tools on Windows. The
version number of the dependent packages are removed too as they may
not reflect their current version in the upstream MSYS2 distribution.

> Signed-off-by: Martin Bonner 
>

This patch format is not correct. It should contain a valid ---
followed by changes statistics.

You should use 'git format-patch' which should do this automatically for you.


> commit e3615603d919ab19fddbee4a68e8a37b91a75f3e (HEAD ->
> better-windows-build-doc)
> Author: Martin Bonner 
> Date:   Tue Jul 5 09:10:59 2022 +0100
>
> Tweak docs for building tools on Windows
>
> * Add three more modules that are required.
> * Remove the version numbers (because they are hard to keep in sync)
> * Add a pacman command line to install everything.
>
> diff --git a/doc/build/tools.rst b/doc/build/tools.rst
> index c06f915274..95f1246617 100644
> --- a/doc/build/tools.rst
> +++ b/doc/build/tools.rst
> @@ -24,14 +24,20 @@ you can use MSYS2, a software distro and building
> platform for Windows.
>  Download the MSYS2 installer from https://www.msys2.org. Make sure you have
>  installed all required packages below in order to build these host tools::
>
> -   * gcc (9.1.0)
> -   * make (4.2.1)
> -   * bison (3.4.2)
> -   * diffutils (3.7)
> -   * openssl-devel (1.1.1.d)
> -
> -Note the version numbers in these parentheses above are the package versions
> -at the time being when writing this document. The MSYS2 installer tested is
> +   * gcc
> +   * make
> +   * bison
> +   * diffutils
> +   * openssl-devel
> +   * flex
> +   * libgnutls-devel
> +   * libuuid-devel
> +
> +You probably want ``git`` as well.  You can install all these with::
> +
> +$ pacman -S gcc make bison diffutils openssl=devel flex

This one is missing. s/=/-

> libgnutls-devel libuuid-devel git
> +
> +The MSYS2 installer tested is
>  http://repo.msys2.org/distrib/x86_64/msys2-x86_64-20190524.exe.
>
>  There are 3 MSYS subsystems installed: MSYS2, MinGW32 and MinGW64. Each
>
> --

Regards,
Bin

How to create a bootable SPL for USB booting for the i.MX8M Mini

2022-07-20 Thread Patrick Boettcher

Hi list,

We are having some difficulties getting USB-boot (for a starter with
SPL) to work on a imx8mm.

Doing this is part of a debug-session for another problem, which is
worth mentioning, as it has been discussed on this list in
January/February 2022.

The original problem: we have a "complete" yocto-environment (kirkstone)
using meta-imx (and thus u-boot-imx 2022.04) where we are building a
booloader image without FIT.

We patched the atf to assign the UART4 to the Cortex A53 because it is
this UART which is used as serial console.

The binary produced by imx-boot in this environment starts booting SPL
and when jumping to the ATF it hangs.

Similar to what is seen here (some people from that thread are on CC,
sorry for the noise).

https://lore.kernel.org/all/20220203164637.GV7515@bill-the-cat/t/#r9071b8b65566bd68bd39ada6d5b6db6e78e034e5

We tried several things to understand what's happening, without
success.

A next step is now to build a SPL with upstream u-boot 2022.07 using an
existing board (our board/dts-files are really not in good shape yet).
We started using the imx8mm-beacon and then tried imx8mm-cl-iot-gate,
when loading their SPL with uuu nothing is printed on the
serial-console.

Here are the steps we did to build and flash it:

- patch imx-atf-2.6 to liberate UART4 into the Cortex A53-domain
- build it and place the bl31.bin in uboot's source-tree
- download ddr-firmwares and put them to uboot's source-tree
- modify board/beacon/../spl.c to UART4 (pads and init_uart_clk(3))
- add FASTBOOT and USB_FUNCTION_FASTBOOT to its defconfig.
- make deconfig && make
- run "uuu SDP: boot -f flash.bin"

1 2 >

1 - 100 of 149 matches

Mail list logo