Re: [U-Boot] [PATCH] imx: imximage: add new CHECK/CLR BIT command
On Mon, Jun 15, 2015 at 8:20 AM, Otavio Salvador ota...@ossystems.com.br wrote: While I agree we ought to use SPL as much as possible I also believe the DCD support should be as complete as possible; some people might have reasons to avoid the SPL and rely on DCD for it. Do you believe SPL can be assumed to be a viable option for everyone? What about boards that don't use (and don't need) SPL right now? -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] build: create time and date independent binary
On Fri, Jun 12, 2015 at 8:31 AM, Heiko Schocher h...@denx.de wrote: With this option enabled each compilation creates the exact same binary. There are no timestamps, with which a U-Boot binary can be identified. Works on usbarmory. Tested-by: Chris Kuethe chris.kue...@gmail.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] patch - arm - define SYS_CACHELINE_SIZE for mx5
Bump... can this be merged? On Tue, Jun 2, 2015 at 4:42 PM, Fabio Estevam feste...@gmail.com wrote: On Tue, Jun 2, 2015 at 8:31 PM, Chris Kuethe chris.kue...@gmail.com wrote: mx5 is a cortex-a8 which has 64 byte cache lines. i'll need this for adding gadget support to usbarmory, but it's a property common the the entire SoC family - may as well make it available to all MX5 boards Works on usbarmory; compile-tested on mx53loco and mx51_efikamx too Signed-off-by: Chris Kuethe chris.kue...@gmail.com Cc: Tom Rini tr...@konsulko.com Cc: Matthew Starr mst...@hedonline.com Cc: Andrej Rosano and...@inversepath.com Cc: Stefano Babic sba...@denx.de Cc: Chris Kuethe chris.kue...@gmail.com Cc: Fabio Estevam feste...@gmail.com Cc: Marek Vasut ma...@denx.de diff --git a/arch/arm/include/asm/arch-mx5/imx-regs.h b/arch/arm/include/asm/arch-mx5/imx-regs.h index f059d0f..5f0e1e6 100644 --- a/arch/arm/include/asm/arch-mx5/imx-regs.h +++ b/arch/arm/include/asm/arch-mx5/imx-regs.h @@ -9,6 +9,8 @@ #define ARCH_MXC +#define CONFIG_SYS_CACHELINE_SIZE 64 + This is correct for Cortex A8: Reviewed-by: Fabio Estevam fabio.este...@freescale.com -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] patch: fix typo in mxc_hab docs
diff --git a/doc/README.mxc_hab b/doc/README.mxc_hab index a1b1d34..5fe977c 100644 --- a/doc/README.mxc_hab +++ b/doc/README.mxc_hab @@ -69,7 +69,7 @@ CONFIG_SECURE_BOOT CONFIG_SYS_FSL_SEC_COMPAT4 /* HAB version */ CONFIG_FSL_CAAM CONFIG_CMD_DEKBLOB -CONFIG_SYS_FSL_LE +CONFIG_SYS_FSL_SEC_LE Note: The encrypted boot feature is only supported by HABv4 or greater. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] patch - arm - define SYS_CACHELINE_SIZE for mx5
mx5 is a cortex-a8 which has 64 byte cache lines. i'll need this for adding gadget support to usbarmory, but it's a property common the the entire SoC family - may as well make it available to all MX5 boards Works on usbarmory; compile-tested on mx53loco and mx51_efikamx too Signed-off-by: Chris Kuethe chris.kue...@gmail.com Cc: Tom Rini tr...@konsulko.com Cc: Matthew Starr mst...@hedonline.com Cc: Andrej Rosano and...@inversepath.com Cc: Stefano Babic sba...@denx.de Cc: Chris Kuethe chris.kue...@gmail.com Cc: Fabio Estevam feste...@gmail.com Cc: Marek Vasut ma...@denx.de diff --git a/arch/arm/include/asm/arch-mx5/imx-regs.h b/arch/arm/include/asm/arch-mx5/imx-regs.h index f059d0f..5f0e1e6 100644 --- a/arch/arm/include/asm/arch-mx5/imx-regs.h +++ b/arch/arm/include/asm/arch-mx5/imx-regs.h @@ -9,6 +9,8 @@ #define ARCH_MXC +#define CONFIG_SYS_CACHELINE_SIZE 64 + #if defined(CONFIG_MX51) #define IRAM_BASE_ADDR 0x1FFE /* internal ram */ #define IPU_SOC_BASE_ADDR 0x4000 -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 1/2] ARM: mx5: move to a standard arch/board approach
On Wed, Apr 8, 2015 at 9:56 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Move the MX5 based boards to arch/arm/cpu/armv7/mx5, following the commit: 89ebc82137bebb11a8191f8b9cbf08f2533ae8bc Signed-off-by: Andrej Rosano and...@inversepath.com Cc: Stefano Babic sba...@denx.de Cc: Vagrant Cascadian vagr...@debian.org Tested-by: Chris Kuethe chris.kue...@gmail.com -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] ARM: mx5: add support for USB armory board
On Wed, Apr 8, 2015 at 9:56 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Add support for Inverse Path USB armory board, an open source flash-drive sized computer based on Freescale i.MX53 SoC. http://inversepath.com/usbarmory Signed-off-by: Andrej Rosano and...@inversepath.com Cc: Stefano Babic sba...@denx.de Cc: Chris Kuethe chris.kue...@gmail.com Cc: Fabio Estevam feste...@gmail.com Cc: Vagrant Cascadian vagr...@debian.org Works for me Tested-by: Chris Kuethe chris.kue...@gmail.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/2] ARM: mx5: add support for USB armory board
Any chance of this being accepted into 2015.04? On Thu, Mar 26, 2015 at 3:28 PM, Chris Kuethe chris.kue...@gmail.com wrote: On Thu, Mar 26, 2015 at 3:23 PM, Andrej Rosano and...@inversepath.com wrote: Please note that the patch is prepared against imx tree and not the mainline one, where the arch/board approach is not yet merged. OK, it all works for me. -- GDB has a 'break' feature; why doesn't it have 'fix' too? -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 1/2] ARM: mx5: move to a standard arch/board approach
On Thu, Mar 26, 2015 at 4:49 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Move the MX5 based boards to arch/arm/cpu/armv7/mx5, following the commit: 89ebc82137bebb11a8191f8b9cbf08f2533ae8bc Signed-off-by: Andrej Rosano and...@inversepath.com Cc: Stefano Babic sba...@denx.de Cc: Vagrant Cascadian vagr...@debian.org Tested-by: Chris Kuethe chris.kue...@gmail.com -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/2] ARM: mx5: add support for USB armory board
On Thu, Mar 26, 2015 at 4:49 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Hello, this series adds support for USB armory board. The patches are prepared against imx tree as it uses the new arch/board approach. The first patch add introduces the arch/board approach for mx5, as already done for mx6. Yep, that works. The second patch adds basic support for USB armory board and is an updated version (v4) with the modifications described bellow. If I test this against HEAD as of f643d9294f45487f22e8f33d6572530f17eff4e9, I get an error reated to IMX_CONFIG. board/inversepath/usbarmory/Kconfig:3:warning: config symbol defined without type Here's a diff to fix that diff --git a/board/inversepath/usbarmory/Kconfig b/board/inversepath/usbarmory/Kconfig index c2cd544..4776b1d 100644 --- a/board/inversepath/usbarmory/Kconfig +++ b/board/inversepath/usbarmory/Kconfig @@ -1,8 +1,5 @@ if TARGET_USBARMORY -config IMX_CONFIG -default board/inversepath/usbarmory/imximage.cfg - config SYS_BOARD default usbarmory diff --git a/configs/usbarmory_defconfig b/configs/usbarmory_defconfig index 10bdd9e..237b1ca 100644 --- a/configs/usbarmory_defconfig +++ b/configs/usbarmory_defconfig @@ -1,3 +1,4 @@ CONFIG_ARM=y CONFIG_ARCH_MX5=y CONFIG_TARGET_USBARMORY=y +CONFIG_SYS_EXTRA_OPTIONS=IMX_CONFIG=board/inversepath/usbarmory/imximage.cfg Changes for v4: - Remove ifdef for CONFIG_FSL_ESDHC as it must always be present - Remove explicit GPIO input setup (all GPIO are input after reset) - Remove dummy board_late_init() and CONFIG_BOARD_LATE_INIT - Remove CONFIG_BOOTARGS - Fix compiling errors due to config_distro_bootcmd.h inclusion position Tested-by: Chris Kuethe chris.kue...@gmail.com Changes for v3: - Add config_distro support Changes for v2: - Fix double print_cpuinfo() call - Fix CONFIG_BOOTCOMMAND typo - Fix CONFIG_SYS_FSL_ESDHC_NUM to 1 Andrej Rosano (2): ARM: mx5: move to a standard arch/board approach ARM: mx5: add support for USB armory board Andrej Rosano (2): ARM: mx5: move to a standard arch/board approach ARM: mx5: add support for USB armory board -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/2] ARM: mx5: add support for USB armory board
On Thu, Mar 26, 2015 at 3:23 PM, Andrej Rosano and...@inversepath.com wrote: Please note that the patch is prepared against imx tree and not the mainline one, where the arch/board approach is not yet merged. OK, it all works for me. -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] arm: mx5: Add support for USB armory board
On Tue, Mar 24, 2015 at 4:25 PM, Vagrant Cascadian vagr...@debian.org wrote: Unfortunately, this fails to build with numerous errors such as: Heh. I was just about to go investigate that. ... +#include config_distro_bootcmd.h + #define MEM_LAYOUT_ENV_SETTINGS \ This section works for me. I'd like to propose only setting bootargs when the default action is kicking in to allow for a different root device, or root device discovery from an initramfs, or boot scripts, etc... Something along these lines (untested): This section also untested by me. -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: mx5: Add support for USB armory board
On Wed, Mar 18, 2015 at 3:53 PM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Add support for Inverse Path USB armory board, an open source flash-drive sized computer based on Freescale i.MX53 SoC. http://inversepath.com/usbarmory Signed-off-by: Andrej Rosano and...@inversepath.com Cc: Stefano Babic sba...@denx.de Cc: Chris Kuethe chris.kue...@gmail.com Cc: Fabio Estevam feste...@gmail.com Tested-by: Chris Kuethe chris.kue...@gmail.com --- I don't have the default kernel image in place; the board boots when I do point it at a valid image. U-Boot 2015.04-rc4-dirty (Mar 18 2015 - 16:12:11) CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: POR Board: Inverse Path USB armory MkI I2C: ready DRAM: 512 MiB MMC: FSL_SDHC: 0 *** Warning - bad CRC, using default environment In:serial Out: serial Err: serial Net: CPU Net Initialization Failed No ethernet found. Hit any key to stop autoboot: 1 0 ** File not found /boot/uImage ** 16610 bytes read in 70 ms (231.4 KiB/s) Wrong Image Format for bootm command ERROR: can't get kernel image! = reset resetting ... U-Boot 2015.04-rc4-dirty (Mar 18 2015 - 16:12:11) CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: WDOG Board: Inverse Path USB armory MkI I2C: ready DRAM: 512 MiB MMC: FSL_SDHC: 0 *** Warning - bad CRC, using default environment In:serial Out: serial Err: serial Net: CPU Net Initialization Failed No ethernet found. Hit any key to stop autoboot: 1 0 ** File not found /boot/uImage ** 16610 bytes read in 69 ms (234.4 KiB/s) Wrong Image Format for bootm command ERROR: can't get kernel image! = -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx5: Add support for USB armory board
On Tue, Mar 17, 2015 at 9:30 AM, Fabio Estevam feste...@gmail.com wrote: On Mon, Mar 16, 2015 at 1:50 PM, Chris Kuethe chris.kue...@gmail.com wrote: U-Boot 2015.04-rc3-00209-ga74ef40-dirty (Mar 15 2015 - 22:04:22) CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: WDOG Here the reset cause is printed correctly. ... ,but here it fails. Why does CPU version and reset cause are printed twice? I noticed that too - will investigate that later tonight. Is this happening with all mx53 boards or only with this one? I currently don't have access to any mx53 board to test this myself. Can't say if this happens on other boards as this is the only mx53 I have. It also happens on -rc2 = U-Boot 2015.04-rc2 (Mar 17 2015 - 01:35:15) CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: POR Board: Inverse Path USB armory MkI I2C: ready DRAM: 512 MiB MMC: FSL_SDHC: 0 In:serial Out: serial Err: serial CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: unknown reset Net: CPU Net Initialization Failed No ethernet found. Hit any key to stop autoboot: 0 = I am adding some folks on Cc who may have access to other mx53 boards and could probably test whether we have a common mx53 issue here. There was some discussion not long ago about reset cause handling (especially on mx6) which I haven't had a chance to fully digest yet. -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx5: Add support for USB armory board
On Tue, Feb 24, 2015 at 1:03 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Add support for Inverse Path USB armory board, an open source flash-drive sized computer based on Freescale i.MX53 SoC. http://inversepath.com/usbarmory Signed-off-by: Andrej Rosano and...@inversepath.com Tested-by: Chris Kuethe chris.kuethe+git...@gmail.com = reset resetting ... U-Boot 2015.04-rc3-00209-ga74ef40-dirty (Mar 15 2015 - 22:04:22) CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: WDOG Board: Inverse Path USB armory MkI I2C: ready DRAM: 512 MiB MMC: FSL_SDHC: 0 In:serial Out: serial Err: serial CPU: Freescale i.MX53 rev2.1 at 800 MHz Reset cause: unknown reset Net: CPU Net Initialization Failed No ethernet found. -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx5: Add support for USB armory board
On Mon, Mar 16, 2015 at 9:50 AM, Chris Kuethe chris.kue...@gmail.com wrote: On Tue, Feb 24, 2015 at 1:03 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Add support for Inverse Path USB armory board, an open source flash-drive sized computer based on Freescale i.MX53 SoC. http://inversepath.com/usbarmory Signed-off-by: Andrej Rosano and...@inversepath.com Tested-by: Chris Kuethe chris.kuethe+git...@gmail.com Derp. I didn't notice this before because I had a saved boot command... +#define CONFIG_BOOTCOMMAND \ + ext2load mmc 0:1 0x7080 /boot/uImage; ext2load mmc 0:1 \ + 0x7100 /boot/imx53-usbarmory.dtb; bootm 0x7080 - 0x7100 Needs a space after mmc 0:1 or before 0x7100, otherwise you get ext2load mmc 0:10x7100 which won't boot. -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx5: Add support for USB armory board
I'll be able to test this next week, but I'd like to see usbarmory be a supported board. On Tue, Feb 24, 2015 at 1:03 AM, and...@inversepath.com wrote: From: Andrej Rosano and...@inversepath.com Add support for Inverse Path USB armory board, an open source flash-drive sized computer based on Freescale i.MX53 SoC. http://inversepath.com/usbarmory Signed-off-by: Andrej Rosano and...@inversepath.com --- arch/arm/Kconfig |5 + board/inversepath/usbarmory/Kconfig | 15 + board/inversepath/usbarmory/MAINTAINERS |6 + board/inversepath/usbarmory/Makefile | 10 + board/inversepath/usbarmory/imximage.cfg | 82 ++ board/inversepath/usbarmory/usbarmory.c | 440 ++ configs/usbarmory_defconfig |3 + include/configs/usbarmory.h | 115 8 files changed, 676 insertions(+) create mode 100644 board/inversepath/usbarmory/Kconfig create mode 100644 board/inversepath/usbarmory/MAINTAINERS create mode 100644 board/inversepath/usbarmory/Makefile create mode 100644 board/inversepath/usbarmory/imximage.cfg create mode 100644 board/inversepath/usbarmory/usbarmory.c create mode 100644 configs/usbarmory_defconfig create mode 100644 include/configs/usbarmory.h diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 820ba1c..11f0e8b 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -473,6 +473,10 @@ config TARGET_MX53SMD bool Support mx53smd select CPU_V7 +config TARGET_USBARMORY + bool Support USB armory + select CPU_V7 + config TARGET_MX51_EFIKAMX bool Support mx51_efikamx select CPU_V7 @@ -818,6 +822,7 @@ source board/h2200/Kconfig source board/hale/tt01/Kconfig source board/icpdas/lp8x4x/Kconfig source board/imx31_phycore/Kconfig +source board/inversepath/usbarmory/Kconfig source board/isee/igep0033/Kconfig source board/jornada/Kconfig source board/karo/tx25/Kconfig diff --git a/board/inversepath/usbarmory/Kconfig b/board/inversepath/usbarmory/Kconfig new file mode 100644 index 000..254b6c9 --- /dev/null +++ b/board/inversepath/usbarmory/Kconfig @@ -0,0 +1,15 @@ +if TARGET_USBARMORY + +config SYS_BOARD + default usbarmory + +config SYS_VENDOR + default inversepath + +config SYS_SOC + default mx5 + +config SYS_CONFIG_NAME + default usbarmory + +endif diff --git a/board/inversepath/usbarmory/MAINTAINERS b/board/inversepath/usbarmory/MAINTAINERS new file mode 100644 index 000..71a3dd4 --- /dev/null +++ b/board/inversepath/usbarmory/MAINTAINERS @@ -0,0 +1,6 @@ +USBARMORY BOARD +M: Andrej Rosano and...@inversepath.com +S: Maintained +F: board/inversepath/usbarmory/ +F: include/configs/usbarmory.h +F: configs/usbarmory_defconfig diff --git a/board/inversepath/usbarmory/Makefile b/board/inversepath/usbarmory/Makefile new file mode 100644 index 000..9b8bd80 --- /dev/null +++ b/board/inversepath/usbarmory/Makefile @@ -0,0 +1,10 @@ +# +# USB armory MkI board Makefile +# http://inversepath.com/usbarmory +# +# Copyright (C) 2015, Inverse Path +# Andrej Rosano and...@inversepath.com +# +# SPDX-License-Identifier:|GPL-2.0+ + +obj-y := usbarmory.o diff --git a/board/inversepath/usbarmory/imximage.cfg b/board/inversepath/usbarmory/imximage.cfg new file mode 100644 index 000..392d2f9 --- /dev/null +++ b/board/inversepath/usbarmory/imximage.cfg @@ -0,0 +1,82 @@ +/* + * USB armory MkI board imximage configuration + * http://inversepath.com/usbarmory + * + * Copyright (C) 2015, Inverse Path + * Andrej Rosano and...@inversepath.com + * + * SPDX-License-Identifier:|GPL-2.0+ + */ + +IMAGE_VERSION 2 +BOOT_FROM sd + + +/* IOMUX */ + +DATA 4 0x53fa86f4 0x /* GRP_DDRMODE_CTL */ +DATA 4 0x53fa8714 0x /* GRP_DDRMODE */ +DATA 4 0x53fa86fc 0x /* GRP_DDRPKE */ +DATA 4 0x53fa8724 0x0400 /* GRP_DDR_TYPE*/ + +DATA 4 0x53fa872c 0x0030 /* GRP_B3DS */ +DATA 4 0x53fa8554 0x0030 /* DRAM_DQM3 */ +DATA 4 0x53fa8558 0x00300040 /* DRAM_SDQS3 */ + +DATA 4 0x53fa8728 0x0030 /* GRP_B2DS */ +DATA 4 0x53fa8560 0x0030 /* DRAM_DQM2 */ +DATA 4 0x53fa8568 0x00300040 /* DRAM_SDQS2 */ + +DATA 4 0x53fa871c 0x0030 /* GRP_B1DS */ +DATA 4 0x53fa8594 0x0030 /* DRAM_DQM1 */ +DATA 4 0x53fa8590 0x00300040 /* DRAM_SDQS1 */ + +DATA 4 0x53fa8718 0x0030 /* GRP_B0DS */ +DATA 4 0x53fa8584 0x0030 /* DRAM_DQM0 */ +DATA 4 0x53fa857c 0x00300040 /* DRAM_SDQS0 */ + +DATA 4 0x53fa8578 0x0030 /* DRAM_SDCLK0 */ +DATA 4 0x53fa8570 0x0030 /* DRAM_SDCLK1 */ + +DATA 4 0x53fa8574 0x0030 /* DRAM_CAS */ +DATA 4 0x53fa8588 0x0030 /* DRAM_RAS */ +DATA 4 0x53fa86f0 0x0030 /* GRP_ADDS */ +DATA 4 0x53fa8720 0x0030 /* GRP_CTLDS */ + +DATA 4 0x53fa8564 0x00300040 /* DRAM_SDODT1 */ +DATA 4 0x53fa8580
Re: [U-Boot] [PATCH] RSA depends on DM
On Tue, Feb 3, 2015 at 5:01 PM, Simon Glass s...@chromium.org wrote: We certainly must avoid the build break. My concern is that CONFIG_DM may introduce a run-time break. For example if you don't have pre-relocation malloc() available the board may not boot. Driver model is a fundamental core feature, and we are working to move everything over to it, but I'm not quite comfortable with forcing it on when someone changes a feature. It feel it would be better to not offer it. I'm interested to hear other viewpoints though. Perhaps soon we can enable CONFIG_DM globally but we are not there yet. I appreciate the caution. For now, vexpress works with qemu which means I can get back to playing with verified boot. I haven't checked to see if it's possible to make RSA not always require DM - I defer to those who know the code better than I do. -C -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] RSA depends on DM
Discovered while experimenting with signature checking on vexpress which doesn't typically use DM. --- Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/Kconfig b/Kconfig index fed488f..8090790 100644 --- a/Kconfig +++ b/Kconfig @@ -118,6 +118,7 @@ config FIT_VERBOSE config FIT_SIGNATURE bool Enable signature verification of FIT uImages depends on FIT + depends on DM select RSA help This option enables signature verification of FIT uImages, -- 2.1.0 -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] RSA depends on DM
On Tue, Feb 3, 2015 at 4:38 PM, Simon Glass s...@chromium.org wrote: +Masahiro Hi Chris, On 3 February 2015 at 00:42, Chris Kuethe chris.kue...@gmail.com wrote: Discovered while experimenting with signature checking on vexpress which doesn't typically use DM. Rather than complaining about unmet dependencies it might be better to enable those them. --- lib/rsa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index 1268a1b..4db5da4 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -2,6 +2,7 @@ config RSA bool Use RSA Library select RSA_FREESCALE_EXP if FSL_CAAM select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP + select DM help RSA support. This enables the RSA algorithm used for FIT image verification in U-Boot. I wonder whether 'depends on DM' might be better? It seems odd to have the tail wagging the dog. Regards, Simon No, that would not be better because a few lines down, RSA_SOFTWARE_EXP and RSA_FREESCALE_EXP both say depends on DM but they don't actually enable it if they need it. As a user, my expectation is that when I turn on some high level feature, that will enable all of its lower level dependencies. Would it be less strange to make FIT_SIGNATURE turn on DM instead of RSA? -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] RSA depends on DM
Discovered while experimenting with signature checking on vexpress which doesn't typically use DM. Rather than complaining about unmet dependencies it might be better to enable those them. --- lib/rsa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index 1268a1b..4db5da4 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -2,6 +2,7 @@ config RSA bool Use RSA Library select RSA_FREESCALE_EXP if FSL_CAAM select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP + select DM help RSA support. This enables the RSA algorithm used for FIT image verification in U-Boot. -- 2.1.0 -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: switch armltd vexpress to GENERIC_BOARD
Bump. Anyone want to comment or commit? http://patchwork.ozlabs.org/patch/431675/ On Wed, Jan 21, 2015 at 8:52 PM, Chris Kuethe chris.kue...@gmail.com wrote: only tested tested under QEMU with vexpress_ca9x4 (-M vexpress-a9) and vexpress_ca15_tc2 (-M vexpress-a15). Makes the ugly warning go away. Signed-off-by: Chris Kuethe chris.kuethe+git...@gmail.com --- include/configs/vexpress_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h index 7e78f8a..2dea921 100644 --- a/include/configs/vexpress_common.h +++ b/include/configs/vexpress_common.h @@ -122,7 +122,7 @@ #define CONFIG_SETUP_MEMORY_TAGS 1 #define CONFIG_SYS_L2CACHE_OFF 1 #define CONFIG_INITRD_TAG 1 - +#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_OF_LIBFDT 1 /* Size of malloc() pool */ -- 2.1.0 -- GDB has a 'break' feature; why doesn't it have 'fix' too? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] arm: switch armltd vexpress to GENERIC_BOARD
only tested tested under QEMU with vexpress_ca9x4 (-M vexpress-a9) and vexpress_ca15_tc2 (-M vexpress-a15). Makes the ugly warning go away. Signed-off-by: Chris Kuethe chris.kuethe+git...@gmail.com --- include/configs/vexpress_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h index 7e78f8a..2dea921 100644 --- a/include/configs/vexpress_common.h +++ b/include/configs/vexpress_common.h @@ -122,7 +122,7 @@ #define CONFIG_SETUP_MEMORY_TAGS 1 #define CONFIG_SYS_L2CACHE_OFF 1 #define CONFIG_INITRD_TAG 1 - +#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_OF_LIBFDT 1 /* Size of malloc() pool */ -- 2.1.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
