CVE-2018-25032 on u-boot zlib

2022-04-21 Thread Gan, Yau Wai
This is to report that CVE is detected during u-boot scanning. Sending to open 
mailing list as get_maintainer suggested.

The current zlib version used in u-boot contains CVE-2018-25032 [1].
Corresponding fix in zlib mainline has been addressed in v1.2.12 [2].
It is required to upgrade zlib in u-boot to that version or later to mitigate 
the CVE.

[1] https://www.cve.org/CVERecord?id=CVE-2018-25032
[2] 
https://github.com/madler/zlib/commit/5c44459c3b28a9bd3283aaceab7c615f8020c531

- Yau Wai



Re: [U-Boot] [PATCH] nios2: 10m50: Add CPU pre-relocation in device tree

2017-08-14 Thread Gan, Yau Wai
Hi all, this patch has been sent for a while. I did cc the patch to the u-boot 
custodian for Nios II, Thomas Chou. Can I know how can I get this patch 
reviewed and merged sooner? Thank you.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Nios II 10m50 is not working

2017-07-28 Thread Gan, Yau Wai
Hi Kirill,

Yes I did manage to debug using GDB and found the issue is with the device tree 
dm-pre-reloc for CPU. Thanks for confirming this.
I sent the patch so we can have fix for the 10m50 board. I am using the golden 
hardware reference design which has MMU enabled.

Best regards,
Yau Wai

-Original Message-
From: Kirill Smirnov [mailto:kirill.k.smir...@gmail.com] 
Sent: Wednesday, July 26, 2017 6:00 PM
To: Gan, Yau Wai <yau.wai@intel.com>; u-boot@lists.denx.de
Subject: [U-Boot] Nios II 10m50 is not working

Hi, Yau

I had a very similar problem with my project. It was sufficient for me to add 
"u-boot,dm-pre-reloc" stanza to cpu node only. This is necessary to properly 
setup mmu/nommu-related memory mappings. Other nodes remain unchanged.

The resulting cpu node (omitting details) is as follows:

cpu: cpu@0x0 {
device_type = "cpu";
compatible = "altr,nios2-16.0", "altr,nios2-1.1";
reg = <0x>;
u-boot,dm-pre-reloc; 
}

This works for my custom no-mmu project. Unfortunately, I cannot test this 
solution on other boards.


-------

On Thu Jul 6 14:30:54 UTC 2017 Gan, Yau Wai wrote:


I tried adding the dm-pre-reloc line to every node and sub-node, but it doesn’t 
help.


On 06/07/2017, 8:26 PM, "Lothar Waßmann"  wrote:

>Hi,
>
>On Thu, 6 Jul 2017 10:32:57 + Gan, Yau Wai wrote:
>> U-boot for Nios II on the 10m50 dev board is not functioning. The serial 
>> terminal prints nothing upon booting up. The u-boot image is loaded via 
>> GDB/JTAG to the FPGA on-chip RAM.
>>
>> Bisect activities were carried and discovered that the change from using 
>> dm_scan_fdt_node to dm_scan_fdt_dev in the simple_bus.c. This leads to 
>> suspecting the 10m50_devboard.dts need update to include 
>> "u-boot,dm-pre-reloc".
>>
>u-boot,dm-pre-reloc has to be present in each item of the DT path 
>leading to the node where you need it.
>
>
>Lothar Waßmann
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] nios2: 10m50: Add CPU pre-relocation in device tree

2017-07-28 Thread Gan, Yau Wai
Tag CPU with dm-pre-reloc to enable driver before
relocation.

Signed-off-by: Gan, Yau Wai <yau.wai@intel.com>
Cc: Thomas Chou <tho...@wytron.com.tw>
---
 arch/nios2/dts/10m50_devboard.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/nios2/dts/10m50_devboard.dts 
b/arch/nios2/dts/10m50_devboard.dts
index 05eac30..461ae68 100644
--- a/arch/nios2/dts/10m50_devboard.dts
+++ b/arch/nios2/dts/10m50_devboard.dts
@@ -19,6 +19,7 @@
#size-cells = <0>;
 
cpu: cpu@0 {
+   u-boot,dm-pre-reloc;
device_type = "cpu";
compatible = "altr,nios2-1.1";
reg = <0x>;
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] Question about uclass_add function

2017-07-18 Thread Gan, Yau Wai
For Nios II arch_cpu_init_dm, the uclass_first_device_err is called to find the 
UCLASS_CPU. This happened right after initf_dm during board_init_f. No SPL is 
involved here.

Tracing through uclass_first_device_err function, I notice that it tries to 
find the uclass (via uclass_get) but not success. The code is then continue by 
adding the uclass (via uclass_add).

Inside uclass_add, the code is able to locate memory address for 
u_boot_list_2_uclass_2_cpu ( which I believe it is doing the job right). 
However, it then try to init the uclass's dev_head by pointing the next and 
prev of the doubly linked list to itself.

Upon returning to its caller, it then checks for dev_head is list_empty. This 
is true and the function return without error code, and a NULL pointer for the 
devp. This subsequently failed the Nios CPU dm init.

May I consult if the above behavior is expected? What fix is needed if 
otherwise? Thank you.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] Nios II 10m50 is not working

2017-07-07 Thread Gan, Yau Wai
I tried adding the dm-pre-reloc line to every node and sub-node, but it doesn’t 
help.




On 06/07/2017, 8:26 PM, "Lothar Waßmann" <l...@karo-electronics.de> wrote:

>Hi,
>
>On Thu, 6 Jul 2017 10:32:57 + Gan, Yau Wai wrote:
>> U-boot for Nios II on the 10m50 dev board is not functioning. The serial 
>> terminal prints nothing upon booting up. The u-boot image is loaded via 
>> GDB/JTAG to the FPGA on-chip RAM.
>> 
>> Bisect activities were carried and discovered that the change from using 
>> dm_scan_fdt_node to dm_scan_fdt_dev in the simple_bus.c. This leads to 
>> suspecting the 10m50_devboard.dts need update to include 
>> "u-boot,dm-pre-reloc".
>> 
>u-boot,dm-pre-reloc has to be present in each item of the DT path
>leading to the node where you need it.
>
>
>Lothar Waßmann
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] Nios II 10m50 is not working

2017-07-06 Thread Gan, Yau Wai
U-boot for Nios II on the 10m50 dev board is not functioning. The serial 
terminal prints nothing upon booting up. The u-boot image is loaded via 
GDB/JTAG to the FPGA on-chip RAM.

Bisect activities were carried and discovered that the change from using 
dm_scan_fdt_node to dm_scan_fdt_dev in the simple_bus.c. This leads to 
suspecting the 10m50_devboard.dts need update to include "u-boot,dm-pre-reloc".

However, changing the 10m50_devboard.dts still does not solve the problem. Any 
idea? Sorry if missing out any info and I will glad to supply.
Thanks.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot