Re: [U-Boot] spi: Drop atmel_dataflash_spi.c

2017-06-05 Thread Stelian Pop
Hi everybody,

> The problem here is that you need to remove the boards in question as
> well.  I see the baord maintainer was Cc'd on this email, so this is a
> bit stronger of a poke, as I guess we need to drop these boards..

It looks like I'm still listed as the maintainer, although I haven't
been involved in u-boot development for years...

I no longer have access to any AT91 board, so if someone wants to take
over, it's ok to me. Otherwise, you can mark those boards as orphaned,
or remove them from the tree.

Thanks,

Stelian.
-- 
Stelian Pop <stel...@popies.net>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] Fix Stelian's email address

2010-12-06 Thread Stelian Pop
Change my old email address which is no longer valid.

Signed-off-by: Stelian Pop stel...@popies.net
---

On Sat, Nov 27, 2010 at 11:27:28PM +0100, Albert ARIBAUD wrote:
 
 Apparently MAINTAINERS entry for Stelian Pop is not correct any
 more; CC:ing Stelian's address as last seen on the list. If this one
 is correct, then MAINTAINERS should be fixed.

Indeed, I've changed employers some time ago.

The attached patch replaces all occurences of my old work email
with my personal (and persistent) email address.

Please apply.

Thanks,

Stelian.

 CREDITS|2 +-
 MAINTAINERS|2 +-
 arch/arm/cpu/arm926ejs/at91/at91cap9_devices.c |2 +-
 arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c  |2 +-
 arch/arm/cpu/arm926ejs/at91/at91sam9261_devices.c  |2 +-
 arch/arm/cpu/arm926ejs/at91/at91sam9263_devices.c  |2 +-
 .../cpu/arm926ejs/at91/at91sam9m10g45_devices.c|2 +-
 arch/arm/cpu/arm926ejs/at91/at91sam9rl_devices.c   |2 +-
 arch/arm/cpu/arm926ejs/at91/led.c  |2 +-
 arch/arm/cpu/arm926ejs/at91/reset.c|2 +-
 arch/arm/cpu/arm926ejs/at91/timer.c|2 +-
 arch/arm/cpu/arm926ejs/mb86r0x/timer.c |2 +-
 arch/arm/include/asm/arch-at91/at91_common.h   |2 +-
 arch/arm/include/asm/arch-at91/at91cap9.h  |2 +-
 arch/arm/include/asm/arch-at91/at91cap9_matrix.h   |2 +-
 arch/arm/include/asm/arch-at91/clk.h   |2 +-
 arch/arm/include/asm/arch-at91/memory-map.h|2 +-
 arch/arm/include/asm/dma-mapping.h |2 +-
 board/afeb9260/Makefile|2 +-
 board/afeb9260/afeb9260.c  |2 +-
 board/atmel/at91cap9adk/Makefile   |2 +-
 board/atmel/at91cap9adk/at91cap9adk.c  |2 +-
 board/atmel/at91cap9adk/led.c  |2 +-
 board/atmel/at91sam9260ek/Makefile |2 +-
 board/atmel/at91sam9260ek/at91sam9260ek.c  |2 +-
 board/atmel/at91sam9260ek/led.c|2 +-
 board/atmel/at91sam9261ek/Makefile |2 +-
 board/atmel/at91sam9261ek/at91sam9261ek.c  |2 +-
 board/atmel/at91sam9261ek/led.c|2 +-
 board/atmel/at91sam9263ek/Makefile |2 +-
 board/atmel/at91sam9263ek/at91sam9263ek.c  |2 +-
 board/atmel/at91sam9263ek/led.c|2 +-
 board/atmel/at91sam9m10g45ek/Makefile  |2 +-
 board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c|2 +-
 board/atmel/at91sam9m10g45ek/led.c |2 +-
 board/atmel/at91sam9rlek/Makefile  |2 +-
 board/atmel/at91sam9rlek/at91sam9rlek.c|2 +-
 board/atmel/at91sam9rlek/led.c |2 +-
 board/calao/sbc35_a9g20/Makefile   |2 +-
 board/calao/sbc35_a9g20/sbc35_a9g20.c  |2 +-
 board/calao/tny_a9260/Makefile |2 +-
 board/calao/tny_a9260/tny_a9260.c  |2 +-
 board/esd/meesc/Makefile   |2 +-
 board/esd/meesc/meesc.c|2 +-
 board/esd/otc570/Makefile  |2 +-
 board/esd/otc570/otc570.c  |2 +-
 board/eukrea/cpu9260/Makefile  |2 +-
 board/eukrea/cpu9260/cpu9260.c |2 +-
 board/ronetix/pm9261/Makefile  |2 +-
 board/ronetix/pm9261/led.c |2 +-
 board/ronetix/pm9261/pm9261.c  |2 +-
 board/ronetix/pm9263/Makefile  |2 +-
 board/ronetix/pm9263/led.c |2 +-
 board/ronetix/pm9263/pm9263.c  |2 +-
 board/ronetix/pm9g45/Makefile  |2 +-
 board/ronetix/pm9g45/pm9g45.c  |2 +-
 board/syteco/jadecpu/Makefile  |2 +-
 drivers/mtd/nand/atmel_nand.c  |2 +-
 include/configs/at91cap9adk.h  |2 +-
 include/configs/at91sam9260ek.h|2 +-
 include/configs/at91sam9261ek.h|2 +-
 include/configs/at91sam9263ek.h|2 +-
 include/configs/at91sam9m10g45ek.h |2 +-
 include/configs/at91sam9rlek.h |2 +-
 include/configs/cpu9260.h  |2 +-
 include/configs/meesc.h|2 +-
 include/configs/otc570.h   |2 +-
 include/configs/pm9261.h   |2 +-
 include/configs/pm9263.h   |2 +-
 include/configs/pm9g45.h   |2 +-
 include/configs/tny_a9260.h|2 +-
 71 files changed, 71 insertions(+), 71

Re: [U-Boot] [PATCH] at91sam9260/9263: add back up fot the rst(reset controller).

2009-06-23 Thread Stelian Pop
On Tue, Jun 23, 2009 at 12:46:50PM +0200, Sedji Gaouaou wrote:

 On the boards at91sam9260ek, at91sam9263ek and afed9260, the rstc register was
 set to 0 after being set to 500 ms for the PHY reset.
 Now if back up is enable it will be set to the saved value.

The changelog message is not very clear. What means if backup is enabled ?
I don't see anything in the patch which can be enabled or disabled...

I think you meant something like: Do backup the old reset length and restore
it after the MACB initialisation.

 + rstc = at91_sys_read(AT91_RSTC_MR);
[...]
   /* Restore NRST value */
   at91_sys_write(AT91_RSTC_MR, AT91_RSTC_KEY |
 -  AT91_RSTC_ERSTL | (0x0  8) |
 +  (rstc) |
AT91_RSTC_URSTEN);

Also, I don't like this: you backup in 'rstc' the _whole_ contents
of the MR register (including for example the URSTEN bit), but on
restore you still construct a bit mask...

In order to be consistent, I would do either:

rstc = at91_sys_read(AT91_RSTC_MR);
...
at91_sys_write(AT91_RSTC_MR, AT91_RSTC_KEY | rstc);

or

rstc = at91_sys_read(AT91_RSTC_MR)  AT91_RSTC_ERSTL;
...
at91_sys_write(AT91_RSTC_MR, AT91_RSTC_KEY | rstc | AT91_RSTC_URSTEN);

Not sure what version would be best though...

Stelian.
-- 
Stelian Pop stel...@popies.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH V2] Add display cpuinfo for Atmel at91 arm926ejs based cores

2009-06-01 Thread Stelian Pop
Hi Rémy,

I do have a few comments, see below:

On Mon, Jun 01, 2009 at 08:21:42PM +0200, Remy Bohmer wrote:

  V2 reworked comments from Jean-Christophe PLAGNIOL-VILLARD
[...]

 +COBJS-$(CONFIG_DISPLAY_CPUINFO) +=cpuinfo.o

missing space ?

 + switch ((cidr  AT91_CIDR_EPROC)  5) {
 +  /* 0x1 = ARM946ES, 0x2 = ARM7TDMI, 0x4 = ARM920T */
 + case 0x5: txt = ARM926EJS;break;
 + default:  txt = undefined;break;

since there are only four choices (until now at least...), why not
put the 'txt' for all of them ?

and the 'undefined' string is not a good choice: it represents a
configuration not known to U-Boot, but its numeric value is well
defined. So I suggest you change this to 'unknown', or even better,
'unknown: 0xfoo'.

 + }
 + printf(Embedded Processor: %s\n, txt);
 +
 + switch ((cidr  AT91_CIDR_ARCH)  20) {
 + case 0x19: txt = AT91SAM9xx;  break;
 + case 0x29: txt = AT91SAM9XExx;break;
 + case 0x39: txt = CAP9;break;
 + default:   txt = undefined;   break;

same comments as above for 'undefined'.

 + switch ((cidr  AT91_CIDR_NVPTYP)  28) {
 + case 0x0: txt = ROM;   break;
 + case 0x1: txt = ROMless or onchip flash;   break;
 + case 0x2: txt = Embedded flash memory; break;
 + case 0x3: txt = ROM and Embedded flash memory; break;
 + case 0x4: txt = SRAM emulating ROM;break;
 + default:  txt = undefined; break;

ditto.

 + switch (cidr  AT91_CIDR_SRAMSIZ) {
 + case AT91_CIDR_SRAMSIZ_1K: txt = 1K;  break;
 + case AT91_CIDR_SRAMSIZ_2K: txt = 2K;  break;
 + case AT91_CIDR_SRAMSIZ_112K: txt = 112K;  break;
 + case AT91_CIDR_SRAMSIZ_4K: txt = 4K;  break;
 + case AT91_CIDR_SRAMSIZ_80K: txt = 80K;break;
 + case AT91_CIDR_SRAMSIZ_160K: txt = 160K;  break;
 + case AT91_CIDR_SRAMSIZ_8K: txt = 8K;  break;
 + case AT91_CIDR_SRAMSIZ_16K: txt = 16K;break;
 + case AT91_CIDR_SRAMSIZ_32K: txt = 32K;break;
 + case AT91_CIDR_SRAMSIZ_64K: txt = 64K;break;
 + case AT91_CIDR_SRAMSIZ_128K: txt = 128K;  break;
 + case AT91_CIDR_SRAMSIZ_256K: txt = 256K;  break;
 + case AT91_CIDR_SRAMSIZ_96K: txt = 96K;break;
 + case AT91_CIDR_SRAMSIZ_512K: txt = 512K;  break;
 + default:  txt = undefined;break;

bad alignment here (you did align the 'txt =' properly in all other
switch/case statements, but not here).

ditto for 'undefined'.

Stelian.

-- 
Stelian Pop stel...@popies.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] Enable display CPU-Info for at91sam9261

2009-06-01 Thread Stelian Pop
On Mon, Jun 01, 2009 at 08:21:43PM +0200, Remy Bohmer wrote:

 Signed-off-by: Remy Bohmer li...@bohmer.net
 ---
  include/configs/at91sam9261ek.h |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/include/configs/at91sam9261ek.h b/include/configs/at91sam9261ek.h
 index fdaa71c..9a50347 100644
 --- a/include/configs/at91sam9261ek.h
 +++ b/include/configs/at91sam9261ek.h
 @@ -45,6 +45,8 @@
  #define CONFIG_SKIP_LOWLEVEL_INIT
  #define CONFIG_SKIP_RELOCATE_UBOOT
  
 +#define CONFIG_DISPLAY_CPUINFO  1

For homogeneity reasons, since this is a generic AT91 config option, I think
it makes sense to define this by default for all the AT91 boards - or not
define it at all. Your pick.

Stelian.
-- 
Stelian Pop stel...@popies.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/1] V2 Add config option for disabling DM9000-SROM support.

2009-05-03 Thread Stelian Pop
On Sun, May 03, 2009 at 12:11:40PM +0200, Remy Bohmer wrote:

 Some boards do not have SROM support for the DM9000 network adapter.
 Instead of listing these board names in the driver code, make this
 option configurable from the board config file.
 
 It also removes a build warning for the at91sam9261ek board:
 'dm9000x.c:545: warning: 'read_srom_word' defined but not used'
 
 And it repaires the trizepsiv board build which was broken around the
 same routines
 
 Signed-off-by: Remy Bohmer li...@bohmer.net

FWIW:
Signed-off-by: Stelian Pop stel...@popies.net

Thanks,

-- 
Stelian Pop stel...@popies.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 13/13] at91sam9263ek: active hush and auto compelete support

2009-03-31 Thread Stelian Pop
On Tue, Mar 31, 2009 at 10:35:00PM +0200, Wolfgang Denk wrote:

  Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com
  +#define CONFIG_AUTO_COMPLETE
  +#define CONFIG_SYS_HUSH_PARSER
  +#define CONFIG_SYS_PROMPT_HUSH_PS2  
 
 You are not the maintainer of this board.
 
 You are not supposed to make any such modifications without permission
 of the board mainteiner.
 
 Stelian, please comment.

In the interest of keeping the various Atmel boards uniform, I'm ok
with this patch. So:
Signed-off-by: Stelian Pop stel...@popies.net

JC: please CC: me directly next time, I'm rather busy lately and not
always following the posts on the mailing list...

Thanks !

-- 
Stelian Pop stel...@popies.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] Problems with USB mass storage on at91sam9263

2009-01-16 Thread Stelian Pop
On Wed, Jan 14, 2009 at 07:53:29PM +0100, Remy Bohmer wrote:

 Hello,

Hi,

 
 2009/1/14 Paal Bakken pabak...@online.no:
  I have problems with usb mass storage in u-boot.
  We have our own at91sam9263 board, but I experience exactly the same 
  problems on the standard at91sam9263ek. And the usb-port AND memory stick 
  works fine in linux. I have tried both FAT and FAT32. Below follows an 
  edited screendump of some usb commands with a u-boot snapshot version from 
  13.01.2009.
 
 The current version should work, indeed a lot has been done in that
 area for these cores. However, IIRC there were some problems with the
 bootstrap code not initialising the PLLB correctly, which resulted in
 similar errors. I thought that Stelian got it to work finally on this
 particular core as well, so maybe he can confirm this. (I concentrated
 the patches on the sam9261)

I do reproduce exactly the same kind of problems here. As I originally said
in my October 9 mail (Message-Id: 1223564465.6130.20.ca...@galileo),
correcting the bootstrap PLLB settings made USB work, but USB storage
did work only with one of my three USB sticks.

I suspect the rest of the issues to be USB specific and not hardware
specific at this point, but I haven't looked closer into it.

Stelian.
-- 
Stelian Pop stel...@popies.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH RFC] at91sam9/at91cap: move common initialisation to cpu

2008-11-14 Thread Stelian Pop
Le jeudi 13 novembre 2008 à 23:32 +0100, Jean-Christophe
PLAGNIOL-VILLARD a écrit :

  Note however that serial and spi are not the only initialisations that
  can be moved: the very same thing can be done with all the other device
  initialisations.
 I've just put serial  spi for the RFC

Ok then.

[...]

  Why don't just do at91_serial_hw_init() once, and test the CONFIG_USART*
  inside the cpu specific at91_serial_hw_init function() ?
  
  This also eliminates that unneeded switch case in that function.
 The idea is too allow multiple serial at the same time.
 
 I've plan to add the multi serial support to the at91 serial drivers

I'm not sure exactly what you mean by multi serial support but isn't
this orthogonal to what I'm saying (putting the #ifdef CONFIG_USART0
inside the cpu specific file instead of board specific file) ?

Stelian.
-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH RFC] at91sam9/at91cap: move common initialisation to cpu

2008-11-13 Thread Stelian Pop
Le vendredi 07 novembre 2008 à 20:38 +0100, Jean-Christophe
PLAGNIOL-VILLARD a écrit :

 Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
 ---
 The idea is to reduce common code initialisation which is actually in board.
 as done on afeb9260 and Ronetix eval board for 9260  9263

[...]

I agree with the general idea of moving the serial and spi from board
specific files to the cpu specific files.

Note however that serial and spi are not the only initialisations that
can be moved: the very same thing can be done with all the other device
initialisations. Some devices will need to specify which GPIOs are used
when it's board specific, and this can be passed as arguments to the cpu
specfic function. One can look at the Linux kernel files which nicely
separates the cpu specific GPIOs (in arch/arm/mach-at91/XXX_devices.c)
and the board specific GPIOs (in arch/arm/mach-at91/board-YYY.c). Or one
can also RTFM of course.

I also don't like this:

 --- a/board/atmel/at91cap9adk/at91cap9adk.c
 +++ b/board/atmel/at91cap9adk/at91cap9adk.c

  #ifdef CONFIG_USART0
 - at91_set_A_periph(AT91_PIN_PA22, 1);/* TXD0 */
 - at91_set_A_periph(AT91_PIN_PA23, 0);/* RXD0 */
 - at91_sys_write(AT91_PMC_PCER, 1  AT91CAP9_ID_US0);
 + at91_serial_hw_init(0);
  #endif

Why don't just do at91_serial_hw_init() once, and test the CONFIG_USART*
inside the cpu specific at91_serial_hw_init function() ?

This also eliminates that unneeded switch case in that function.

Stelian.
-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] AT91: Use AT91_CPU_CLOCK in displays

2008-11-06 Thread Stelian Pop
Le jeudi 06 novembre 2008 à 20:29 +0100, Jean-Christophe
PLAGNIOL-VILLARD a écrit :
 On 18:07 Tue 21 Oct , Stelian Pop wrote:
  Introduce AT91_CPU_CLOCK and use it for displaying the CPU
  speed in the LCD driver.
  
  Also make AT91_MAIN_CLOCK and AT91_MASTER_CLOCK reflect the
  corresponding board clocks.
  
  Signed-off-by: Stelian Pop [EMAIL PROTECTED]
  ---
   common/lcd.c|2 +-
   include/configs/at91cap9adk.h   |5 +++--
   include/configs/at91sam9260ek.h |6 --
   include/configs/at91sam9261ek.h |5 +++--
   include/configs/at91sam9263ek.h |5 +++--
   include/configs/at91sam9rlek.h  |5 +++--
   6 files changed, 17 insertions(+), 11 deletions(-)
 failed to apply
 
 could you rebase it against u-boot-at91

Here it is.

Thanks,

Stelian.

-
From 5a769ae742ca62d451e412a77dbf31e691b755bf Mon Sep 17 00:00:00 2001
From: Stelian Pop [EMAIL PROTECTED]
Date: Thu, 6 Nov 2008 22:47:15 +0100
Subject: [PATCH] AT91: Use AT91_CPU_CLOCK in displays

Introduce AT91_CPU_CLOCK and use it for displaying the CPU
speed in the LCD driver.

Also make AT91_MAIN_CLOCK and AT91_MASTER_CLOCK reflect the
corresponding board clocks.

Signed-off-by: Stelian Pop [EMAIL PROTECTED]
---
 board/atmel/at91cap9adk/at91cap9adk.c |2 +-
 board/atmel/at91sam9261ek/at91sam9261ek.c |2 +-
 board/atmel/at91sam9263ek/at91sam9263ek.c |2 +-
 board/atmel/at91sam9rlek/at91sam9rlek.c   |2 +-
 include/configs/at91cap9adk.h |7 ---
 include/configs/at91sam9260ek.h   |8 +---
 include/configs/at91sam9261ek.h   |7 ---
 include/configs/at91sam9263ek.h   |7 ---
 include/configs/at91sam9rlek.h|7 ---
 9 files changed, 25 insertions(+), 19 deletions(-)

diff --git a/board/atmel/at91cap9adk/at91cap9adk.c 
b/board/atmel/at91cap9adk/at91cap9adk.c
index af145cc..f7d68b7 100644
--- a/board/atmel/at91cap9adk/at91cap9adk.c
+++ b/board/atmel/at91cap9adk/at91cap9adk.c
@@ -342,7 +342,7 @@ void lcd_show_board_info(void)
lcd_printf ([EMAIL PROTECTED]);
lcd_printf (%s CPU at %s MHz\n,
AT91_CPU_NAME,
-   strmhz(temp, AT91_MAIN_CLOCK));
+   strmhz(temp, AT91_CPU_CLOCK));
 
dram_size = 0;
for (i = 0; i  CONFIG_NR_DRAM_BANKS; i++)
diff --git a/board/atmel/at91sam9261ek/at91sam9261ek.c 
b/board/atmel/at91sam9261ek/at91sam9261ek.c
index 185d6e1..14f236d 100644
--- a/board/atmel/at91sam9261ek/at91sam9261ek.c
+++ b/board/atmel/at91sam9261ek/at91sam9261ek.c
@@ -225,7 +225,7 @@ void lcd_show_board_info(void)
lcd_printf ([EMAIL PROTECTED]);
lcd_printf (%s CPU at %s MHz\n,
AT91_CPU_NAME,
-   strmhz(temp, AT91_MAIN_CLOCK));
+   strmhz(temp, AT91_CPU_CLOCK));
 
dram_size = 0;
for (i = 0; i  CONFIG_NR_DRAM_BANKS; i++)
diff --git a/board/atmel/at91sam9263ek/at91sam9263ek.c 
b/board/atmel/at91sam9263ek/at91sam9263ek.c
index 4feed9a..ebd4649 100644
--- a/board/atmel/at91sam9263ek/at91sam9263ek.c
+++ b/board/atmel/at91sam9263ek/at91sam9263ek.c
@@ -276,7 +276,7 @@ void lcd_show_board_info(void)
lcd_printf ([EMAIL PROTECTED]);
lcd_printf (%s CPU at %s MHz\n,
AT91_CPU_NAME,
-   strmhz(temp, AT91_MAIN_CLOCK));
+   strmhz(temp, AT91_CPU_CLOCK));
 
dram_size = 0;
for (i = 0; i  CONFIG_NR_DRAM_BANKS; i++)
diff --git a/board/atmel/at91sam9rlek/at91sam9rlek.c 
b/board/atmel/at91sam9rlek/at91sam9rlek.c
index 992dd4c..b6fef9d 100644
--- a/board/atmel/at91sam9rlek/at91sam9rlek.c
+++ b/board/atmel/at91sam9rlek/at91sam9rlek.c
@@ -197,7 +197,7 @@ void lcd_show_board_info(void)
lcd_printf ([EMAIL PROTECTED]);
lcd_printf (%s CPU at %s MHz\n,
AT91_CPU_NAME,
-   strmhz(temp, AT91_MAIN_CLOCK));
+   strmhz(temp, AT91_CPU_CLOCK));
 
dram_size = 0;
for (i = 0; i  CONFIG_NR_DRAM_BANKS; i++)
diff --git a/include/configs/at91cap9adk.h b/include/configs/at91cap9adk.h
index 30a7cb4..667e049 100644
--- a/include/configs/at91cap9adk.h
+++ b/include/configs/at91cap9adk.h
@@ -29,9 +29,10 @@
 
 /* ARM asynchronous clock */
 #define AT91_CPU_NAME  AT91CAP9
-#define AT91_MAIN_CLOCK2   /* from 12 MHz crystal 
*/
-#define AT91_MASTER_CLOCK  1   /* peripheral = main / 2 */
-#define CONFIG_SYS_HZ  100 /* 1us resolution */
+#define AT91_MAIN_CLOCK1200/* 12 MHz crystal */
+#define AT91_MASTER_CLOCK  1   /* peripheral */
+#define AT91_CPU_CLOCK 2   /* cpu */
+#define CONFIG_SYS_HZ  100 /* 1us resolution */
 
 #define AT91_SLOW_CLOCK32768   /* slow clock */
 
diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
index be9a8eb..81c8d39 100644
--- a/include/configs

Re: [U-Boot] [PATCH] AT91: Enable PLLB for USB

2008-11-06 Thread Stelian Pop
Le jeudi 06 novembre 2008 à 20:27 +0100, Jean-Christophe
PLAGNIOL-VILLARD a écrit :
 On 18:07 Tue 21 Oct , Stelian Pop wrote:
  At least some (old ?) versions of the AT91Bootstrap do not set up the
  PLLB correctly to 48 MHz in order to make USB host function correctly.
  
  This patch sets up the PLLB to the same values Linux uses, and makes USB
  work ok on the following CPUs:
  - AT91CAP9
  - AT91SAM9260
  - AT91SAM9263
  
  This patch also defines CONFIG_USB_STORAGE and CONFIG_CMD_FAT for all
  the relevant AT91CAP9/AT91SAM9 boards.
  
  Signed-off-by: Stelian Pop [EMAIL PROTECTED]
  ---
   cpu/arm926ejs/at91/usb.c|   18 ++
   include/configs/at91cap9adk.h   |3 +++
   include/configs/at91sam9260ek.h |2 ++
   include/configs/at91sam9261ek.h |1 +
   include/configs/at91sam9263ek.h |2 ++
   5 files changed, 26 insertions(+), 0 deletions(-)
 
 failed to apply
 
 could you rebase it against u-boot-at91?

Here it is.

Thanks,

Stelian.


From 87abe92b4c34d8deb58f0743d2f4ffca3bd8bf6c Mon Sep 17 00:00:00 2001
From: Stelian Pop [EMAIL PROTECTED]
Date: Thu, 6 Nov 2008 22:51:32 +0100
Subject: [PATCH] AT91: Enable PLLB for USB

At least some (old ?) versions of the AT91Bootstrap do not set up the
PLLB correctly to 48 MHz in order to make USB host function correctly.

This patch sets up the PLLB to the same values Linux uses, and makes USB
work ok on the following CPUs:
- AT91CAP9
- AT91SAM9260
- AT91SAM9263

This patch also defines CONFIG_USB_STORAGE and CONFIG_CMD_FAT for all
the relevant AT91CAP9/AT91SAM9 boards.

Signed-off-by: Stelian Pop [EMAIL PROTECTED]
---
 cpu/arm926ejs/at91/usb.c|   18 ++
 include/configs/at91cap9adk.h   |3 +++
 include/configs/at91sam9260ek.h |2 ++
 include/configs/at91sam9261ek.h |1 +
 include/configs/at91sam9263ek.h |2 ++
 5 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/cpu/arm926ejs/at91/usb.c b/cpu/arm926ejs/at91/usb.c
index 7cb082d..2f5c337 100644
--- a/cpu/arm926ejs/at91/usb.c
+++ b/cpu/arm926ejs/at91/usb.c
@@ -31,6 +31,15 @@
 
 int usb_cpu_init(void)
 {
+
+#if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
+defined(CONFIG_AT91SAM9263)
+   /* Enable PLLB */
+   at91_sys_write(AT91_CKGR_PLLBR, CFG_AT91_PLLB);
+   while ((at91_sys_read(AT91_PMC_SR)  AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
+   ;
+#endif
+
/* Enable USB host clock. */
at91_sys_write(AT91_PMC_PCER, 1  AT91_ID_UHP);
 #ifdef CONFIG_AT91SAM9261
@@ -51,6 +60,15 @@ int usb_cpu_stop(void)
 #else
at91_sys_write(AT91_PMC_SCDR, AT91_PMC_UHP);
 #endif
+
+#if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
+defined(CONFIG_AT91SAM9263)
+   /* Disable PLLB */
+   at91_sys_write(AT91_CKGR_PLLBR, 0);
+   while ((at91_sys_read(AT91_PMC_SR)  AT91_PMC_LOCKB) != 0)
+   ;
+#endif
+
return 0;
 }
 
diff --git a/include/configs/at91cap9adk.h b/include/configs/at91cap9adk.h
index 667e049..aeb06ac 100644
--- a/include/configs/at91cap9adk.h
+++ b/include/configs/at91cap9adk.h
@@ -32,6 +32,7 @@
 #define AT91_MAIN_CLOCK1200/* 12 MHz crystal */
 #define AT91_MASTER_CLOCK  1   /* peripheral */
 #define AT91_CPU_CLOCK 2   /* cpu */
+#define CFG_AT91_PLLB  0x10073e01  /* PLLB settings for USB */
 #define CONFIG_SYS_HZ  100 /* 1us resolution */
 
 #define AT91_SLOW_CLOCK32768   /* slow clock */
@@ -137,6 +138,8 @@
 #define CONFIG_SYS_USB_OHCI_REGS_BASE  0x0070  /* 
AT91_BASE_UHP */
 #define CONFIG_SYS_USB_OHCI_SLOT_NAME  at91cap9
 #define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2
+#define CONFIG_USB_STORAGE 1
+#define CONFIG_CMD_FAT 1
 
 #define CONFIG_SYS_LOAD_ADDR   0x7200  /* load address 
*/
 
diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
index 81c8d39..fbc470f 100644
--- a/include/configs/at91sam9260ek.h
+++ b/include/configs/at91sam9260ek.h
@@ -32,6 +32,7 @@
 #define AT91_MAIN_CLOCK18432000/* 18.432 MHz crystal */
 #define AT91_MASTER_CLOCK  1   /* peripheral */
 #define AT91_CPU_CLOCK 2   /* cpu */
+#define CFG_AT91_PLLB  0x107c3e18  /* PLLB settings for USB */
 #define CONFIG_SYS_HZ  100 /* 1us resolution */
 
 #define AT91_SLOW_CLOCK32768   /* slow clock */
@@ -123,6 +124,7 @@
 #define CONFIG_SYS_USB_OHCI_SLOT_NAME  at91sam9260
 #define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2
 #define CONFIG_USB_STORAGE 1
+#define CONFIG_CMD_FAT 1
 
 #define CONFIG_SYS_LOAD_ADDR   0x2200  /* load address 
*/
 
diff --git a/include/configs/at91sam9261ek.h b/include/configs/at91sam9261ek.h
index efe35a4

[U-Boot] [PATCH ARM/AT91 0/4] AT91CAP9/AT91SAM9 bugfixes for 2008.12

2008-10-21 Thread Stelian Pop
Hi,

The following patches correct a few issues mainly related to USB and
serial initializations in the various AT91CAP9 / AT91SAM9 boards.

Please merge.

Thanks,

Stelian.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] lcd: print custom strings after the logo

2008-10-21 Thread Stelian Pop
Le mardi 21 octobre 2008 à 18:43 +0200, Ilko Iliev a écrit :

  +#ifndef CONFIG_LCD_LOGO_TEXT1
  +# define CONFIG_LCD_LOGO_TEXT1 (C) 2008 ATMEL Corp
  +#endif
  
 
  Wouldn't it be better if we move this text into
  include/configs/at91xxx.h for all the boards ?

 Yes, it will be better.
 Because I'm a newbie in the U-BOOT development I didn't want to make 
 changes in all boards.


 I have also other suggestions: see my email for the lowlevel_init.S

Yes, I saw them. Wolfgang proposed to use a weak function, which is
probably way better 

 Do you know why the CPU registers are defined in this way:
 #define AT91_PMC(0xfc00 - AT91_BASE_SYS)

This is because the header files ware copied (with some editing) from
Linux, and this is how Linux does define those register offsets.

 This is OK for a C-code, but for an assembler it is a problem because 
 the following code gives an Error: bad immediate value for offset:
 ldr r1, =AT91_BASE_SYS

You shouldn't do this. Look at at91_sys_read()/at91_sys_write()
implementation. So the code should be:
ldr r1, =(AT91_BASE_SYS + AT91_PMC)

which will be optimised by cpp to:
ldr r1, =0xfc00

Stelian.
-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-09 Thread Stelian Pop
Le mercredi 08 octobre 2008 à 10:54 +0200, Remy Bohmer a écrit :

 I made it 2 seperate patches. The 1st of this series is fully tested and 
 correct
 on at least the AT91SAM9261 cores. I hope it fixes the known problems on
 AT91SAM9263 (and other) cores also, maybe Stelian can verify this.
 If it does not help on sam9263, it should not make it worse either...

It still doesn't help (on AT91SAM9263):

usb start
(Re)start USB...
USB:   scanning bus for devices... New Device 0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
set address 1
usb_control_msg: request: 0x5, requesttype: 0x0, value 0x1 index 0x0 length 0x0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x12
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x9
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x19
get_conf_no 0 Result 25, wLength 25
if 0, ep 0
##EP epmaxpacketin[1] = 2
set configuration 1
usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length 0x0
new device strings: Mfr=0, Product=1, SerialNumber=0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 length 
0xFF
USB device number 1 default language ID 0x409
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x409 
length 0xFF
Manufacturer 
Product  OHCI Root Hub
SerialNumber 
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 
0x4
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 
0x9
usb_control_msg: request: 0x0, requesttype: 0xA0, value 0x0 index 0x0 length 0x4
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x8 index 0x1 length 0x0
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x8 index 0x2 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x2 length 
0x0
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x2 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x2 length 
0x0
New Device 1
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
ERROR:  USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
usb_new_device: usb_get_descriptor() failed
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x1 index 0x2 length 0x0
2 USB Device(s) found
   scanning bus for storage devices... 0 Storage Device(s) found
U-Boot 

-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-09 Thread Stelian Pop
-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
usb_control_msg: request: 0x1, requesttype: 0x2, value 0x0 index 0x2 length 0x0
ERROR:  USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
ERROR:  USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
usb_control_msg: request: 0xFF, requesttype: 0x21, value 0x0 index 0x0 length 
0x0
ERROR:  USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)

-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes

2008-10-08 Thread Stelian Pop
Le mercredi 08 octobre 2008 à 10:54 +0200, Remy Bohmer a écrit :

 I made it 2 seperate patches. The 1st of this series is fully tested and 
 correct
 on at least the AT91SAM9261 cores. I hope it fixes the known problems on
 AT91SAM9263 (and other) cores also, maybe Stelian can verify this.
 If it does not help on sam9263, it should not make it worse either...

I'll hopefully do the tests tomorrow. 

Stelian.
-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/3] Improve stability USB memory sticks for the common OHCI USB layer.

2008-10-02 Thread Stelian Pop
Hi Remy,

Sorry it took so long but here are the results of the tests on my
AT91SAM9261-EK.

Le samedi 20 septembre 2008 à 22:14 +0200, Stelian Pop a écrit :

  Also, it would be very helpful if you would test your sticks on a
  SAM9261, because that SoC _must_ work. (I tested on AT91SAM9261-EK,
  and custom board)
  Then we can relate the problem to a specific USB stick, or to a
 certain SoC.
 
 Hmm, I can do that, but not before September 29.

The stick is fine, it does work ok on the 9261:

usb reset
(Re)start USB...
USB:   scanning bus for devices... New Device 0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
set address 1
usb_control_msg: request: 0x5, requesttype: 0x0, value 0x1 index 0x0 length 0x0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x12
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x8
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x19
get_conf_no 0 Result 25, wLength 25
if 0, ep 0
##EP epmaxpacketin[1] = 2
set configuration 1
usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length 0x0
new device strings: Mfr=0, Product=1, SerialNumber=0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 length 
0xFF
USB device number 1 default language ID 0x409
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x409 
length 0xFF
Manufacturer 
Product  OHCI Root Hub
SerialNumber 
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 
0x4
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 
0x9
usb_control_msg: request: 0x0, requesttype: 0xA0, value 0x0 index 0x0 length 0x4
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x8 index 0x1 length 0x0
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x8 index 0x2 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x1 length 
0x0
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x1 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x1 length 
0x0
New Device 1
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x1 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x1 length 
0x0
set address 2
usb_control_msg: request: 0x5, requesttype: 0x0, value 0x2 index 0x0 length 0x0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x12
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x8
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x27
get_conf_no 0 Result 39, wLength 39
if 0, ep 0
if 0, ep 1
if 0, ep 2
##EP epmaxpacketout[1] = 64
##EP epmaxpacketin[2] = 64
##EP epmaxpacketin[3] = 64
set configuration 1
usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length 0x0
new device strings: Mfr=1, Product=2, SerialNumber=3
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 length 
0xFF
USB device number 2 default language ID 0x409
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x409 
length 0xFF
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x302 index 0x409 
length 0xFF
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x303 index 0x409 
length 0xFF
Manufacturer P Technology
Product  USB Mass Storage Device
SerialNumber 000722
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4
2 USB Device(s) found
   scanning bus for storage devices... usb_control_msg: request: 0xFF, 
requesttype: 0x21, value 0x0 index 0x0 length 0x0
usb_control_msg: request: 0x1, requesttype: 0x2, value 0x0 index 0x82 length 0x0
usb_control_msg: request: 0x1, requesttype: 0x2, value 0x0 index 0x1 length 0x0
1 Storage Device(s) found
U-Boot usb storage
  Device 0: Vendor: UT163Rev: 0.00 Prod: USB Flash Disk  
Type: Removable Hard Disk
Capacity: 963.9 MB = 0.9 GB (1974271 x 512)
U-Boot 
U-Boot fatls usb 0 1
.
 51878326   download.tgz 
20351   tp.tgz 

2 file(s), 0 dir(s)

U-Boot 

-- 
Stelian Pop [EMAIL PROTECTED

Re: [U-Boot] stability USB memory sticks for the common OHCI USB layer.

2008-09-22 Thread Stelian Pop
Le lundi 22 septembre 2008 à 14:42 +0200, Remy Bohmer a écrit :
 pièce jointe document texte brut (increase-usb-control-timeout.patch)
 Hello Stelian,
 
 As promised, here is the first patch to test.

Unfortunately it doesn't seem to make much difference, see the log
below. I've enabled USB_DEBUG in common/usb.c in case some of the more
verbose printouts ring someone's bell.

 If it does not help, I would like to wait until you are able to verify if your
 problem with _your_ USB sticks also exists on a AT91sam9261-ek, to be able to
 differentiate if the problem is USB stick related or SoC related.

Sure, I'll try to test this next monday.

Stelian.

usb reset
(Re)start USB...
USB:   scanning bus for devices... New Device 0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
set address 1
usb_control_msg: request: 0x5, requesttype: 0x0, value 0x1 index 0x0 length 0x0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x12
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x8
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 
0x19
get_conf_no 0 Result 25, wLength 25
if 0, ep 0
##EP epmaxpacketin[1] = 2
set configuration 1
usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length 0x0
new device strings: Mfr=0, Product=1, SerialNumber=0
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 length 
0xFF
USB device number 1 default language ID 0x409
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x409 
length 0xFF
Manufacturer 
Product  OHCI Root Hub
SerialNumber 
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 
0x4
usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 
0x9
usb_control_msg: request: 0x0, requesttype: 0xA0, value 0x0 index 0x0 length 0x4
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x8 index 0x1 length 0x0
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x8 index 0x2 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x10 index 0x1 length 
0x0
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x1 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x1 length 
0x0
New Device 1
usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 
0x40
ERROR:  USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did
not provide a handshake (OUT) (5)
usb_new_device: 64 byte descr
usb_control_msg: request: 0x3, requesttype: 0x23, value 0x4 index 0x1 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x1 length 0x4
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x14 index 0x1 length 
0x0
set address 2
usb_control_msg: request: 0x5, requesttype: 0x0, value 0x2 index 0x0 length 0x0
ERROR: submit_control_message: pipesize for pipe 8000 is zero

  USB device not accepting new address (error=8000)
usb_control_msg: request: 0x1, requesttype: 0x23, value 0x1 index 0x1 length 0x0
usb_control_msg: request: 0x0, requesttype: 0xA3, value 0x0 index 0x2 length 0x4
2 USB Device(s) found
   scanning bus for storage devices... 0 Storage Device(s) found
U-Boot 
-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/3] Improve stability USB memory sticks for the common OHCI USB layer.

2008-09-19 Thread Stelian Pop
Le jeudi 18 septembre 2008 à 16:54 +0200, Remy Bohmer a écrit :
 Hello Stelian,

Hi Remy,

 
  I gave your patches a run on an AT91CAP9 and had limited success with
  them (usb seems to work, usb storage do not):
 
 Does it work without the patches? Is it a regression, or still an improvement?

It is an improvement, without the patches it doesn't work at all
 
  U-Boot usb part
  print_part of 0
 
  Partition Map for USB device 0  --   Partition Type: DOS
 
  Partition Start Sector Num Sectors Type
 1   63 1974208   6
 
  print_part of 1
  ## Unknown partition table
 
 These errors are normal, 'usb part' seems to look for primary
 partitions on a USB stick that is formatted as a floppy...
 
  U-Boot usb storage
   Device 0: not available

What about this one ? Isn't this supposed to say something else ?

  U-Boot fatinfo usb 0:1
 
  ** Invalid boot device **
 
 I have no explanation for this error, it could be related to the
 filesystem on the USB stick itself.

No, the filesystem is ok. (it's a 1GB stick btw).

 I do not see any errors that USB itself is not working, the problems I
 fixed were in the USB area, and they solved all the problems I
 encountered with USB sticks on AT91SAM9261 (OHCI)

I'll try to test on some other AT91SAM9 boards later today, if I find a
few minutes...

Stelian.
-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/3] Improve stability USB memory sticks for the common OHCI USB layer.

2008-09-19 Thread Stelian Pop
Le vendredi 19 septembre 2008 à 11:16 +0200, Remy Bohmer a écrit :

  I'll try to test on some other AT91SAM9 boards later today, if I find a
  few minutes...
 
 Thanks, and I expect to hear some more positive news ;-)))

I'm afraid I have more bad news.

I updated my tree to the latest git. I use the ELDK 4.1 arm compiler.

Tested on an AT91SAM9263, with two different USB sticks:

U-Boot usb reset   
(Re)start USB...
USB:   scanning bus for devices... ERROR:  USB-error: DEVICENOTRESPONDING: 
Device did not respond to token (IN) or did not provide a handshake (OUT) (5)   

ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did not provide a handshake (OUT) (5)   

ERROR:  USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did not provide a handshake (OUT) (5)   

ERROR: USB-error: DEVICENOTRESPONDING: Device did not respond to token (IN) or 
did not provide a handshake (OUT) (5)   


USB device not accepting new address (error=20)   
2 USB Device(s) found   
   scanning bus for storage devices... 0 Storage Device(s) found

Without your 3 patches applied, I get:

U-Boot usb start   
(Re)start USB...
USB:   scanning bus for devices...  
  USB device not responding, giving up (status=20)  
2 USB Device(s) found   
   scanning bus for storage devices... 0 Storage Device(s) found  

Stelian.

-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [patch 0/3] Improve stability USB memory sticks for the common OHCI USB layer.

2008-09-18 Thread Stelian Pop
 
 
## Unknown partition table  
 

 
print_part of 4 
 
## Unknown partition table  
   

U-Boot usb storage 
 
  Device 0: not available   
 

U-Boot fatinfo usb 0:1 
 

 
** Invalid boot device **   
 

-- 
Stelian Pop [EMAIL PROTECTED]

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot