Re: [U-Boot] [PATCH 1/6] arm: Remove edb9315a board
Hi Simon, I posted a patch http://patchwork.ozlabs.org/patch/516053/ to move this board to generic but still haven't got any feedback. On Sat, Sep 12, 2015 at 8:50 PM, Simon Glass wrote: > This board has not been converted to generic board by the deadline. > Remove it. > > Signed-off-by: Simon Glass > --- > > arch/arm/Kconfig | 5 - > board/cirrus/edb93xx/Kconfig | 15 -- > board/cirrus/edb93xx/MAINTAINERS | 6 - > board/cirrus/edb93xx/Makefile| 11 -- > board/cirrus/edb93xx/edb93xx.c | 382 > --- > board/cirrus/edb93xx/u-boot.lds | 116 > configs/edb9315a_defconfig | 6 - > include/configs/edb93xx.h| 284 - > 8 files changed, 825 deletions(-) > delete mode 100644 board/cirrus/edb93xx/Kconfig > delete mode 100644 board/cirrus/edb93xx/MAINTAINERS > delete mode 100644 board/cirrus/edb93xx/Makefile > delete mode 100644 board/cirrus/edb93xx/edb93xx.c > delete mode 100644 board/cirrus/edb93xx/u-boot.lds > delete mode 100644 configs/edb9315a_defconfig > delete mode 100644 include/configs/edb93xx.h > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 57c48d5..2c50ada 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -75,10 +75,6 @@ choice > config ARCH_AT91 > bool "Atmel AT91" > > -config TARGET_EDB93XX > - bool "Support edb93xx" > - select CPU_ARM920T > - > config TARGET_VCMA9 > bool "Support VCMA9" > select CPU_ARM920T > @@ -713,7 +709,6 @@ source "board/bluegiga/apx4devkit/Kconfig" > source "board/broadcom/bcm28155_ap/Kconfig" > source "board/broadcom/bcmcygnus/Kconfig" > source "board/broadcom/bcmnsp/Kconfig" > -source "board/cirrus/edb93xx/Kconfig" > source "board/compulab/cm_t335/Kconfig" > source "board/compulab/cm_t43/Kconfig" > source "board/creative/xfi3/Kconfig" > diff --git a/board/cirrus/edb93xx/Kconfig b/board/cirrus/edb93xx/Kconfig > deleted file mode 100644 > index c5f4897..000 > --- a/board/cirrus/edb93xx/Kconfig > +++ /dev/null > @@ -1,15 +0,0 @@ > -if TARGET_EDB93XX > - > -config SYS_BOARD > - default "edb93xx" > - > -config SYS_VENDOR > - default "cirrus" > - > -config SYS_SOC > - default "ep93xx" > - > -config SYS_CONFIG_NAME > - default "edb93xx" > - > -endif > diff --git a/board/cirrus/edb93xx/MAINTAINERS > b/board/cirrus/edb93xx/MAINTAINERS > deleted file mode 100644 > index 3bb2843..000 > --- a/board/cirrus/edb93xx/MAINTAINERS > +++ /dev/null > @@ -1,6 +0,0 @@ > -EDB93XX BOARD > -M: Sergey Kostanbaev > -S: Maintained > -F: board/cirrus/edb93xx/ > -F: include/configs/edb93xx.h > -F: configs/edb9315a_defconfig > diff --git a/board/cirrus/edb93xx/Makefile b/board/cirrus/edb93xx/Makefile > deleted file mode 100644 > index d03c498..000 > --- a/board/cirrus/edb93xx/Makefile > +++ /dev/null > @@ -1,11 +0,0 @@ > -# > -# (C) Copyright 2013 > -# Sergey Kostanbaev fairwaves.ru> > -# > -# (C) Copyright 2003-2006 > -# Wolfgang Denk, DENX Software Engineering, wd denx.de. > -# > -# * SPDX-License-Identifier: GPL-2.0+ > -# > - > -obj-y := edb93xx.o > diff --git a/board/cirrus/edb93xx/edb93xx.c > b/board/cirrus/edb93xx/edb93xx.c > deleted file mode 100644 > index 8963d3a..000 > --- a/board/cirrus/edb93xx/edb93xx.c > +++ /dev/null > @@ -1,382 +0,0 @@ > -/* > - * Board initialization for EP93xx > - * > - * Copyright (C) 2013 > - * Sergey Kostanbaev fairwaves.ru> > - * > - * Copyright (C) 2009 > - * Matthias Kaehlcke kaehlcke.net> > - * > - * (C) Copyright 2002 2003 > - * Network Audio Technologies, Inc. > - * Adam Bezanson netaudiotech.com> > - * > - * SPDX-License-Identifier:GPL-2.0+ > - */ > - > -#include > -#include > -#include > -#include > -#include > - > -DECLARE_GLOBAL_DATA_PTR; > - > -/* > - * usb_div: 4, nbyp2: 1, pll2_en: 1 > - * pll2_x1: 36864.00, pll2_x2ip: 1536.00, > - * pll2_x2: 38400.00, pll2_out: 19200.00 > - */ > -#define CLKSET2_VAL(23 << SYSCON_CLKSET_PLL_X2IPD_SHIFT | \ > - 24 << SYSCON_CLKSET_PLL_X2FBD2_SHIFT | \ > - 24 << SYSCON_CLKSET_PLL_X1FBD1_SHIFT | \ > - 1 << SYSCON_CLKSET_PLL_PS_SHIFT | \ > - SYSCON_CLKSET2_PLL2_EN |\ > -
Re: [U-Boot] [PATCH 09/45] arm: Remove edb9315a board
Hi Simon, It seems I missed moving to generic board CONFIG_SYS_GENERIC_BOARD. So could you point what is better to read to adopt it? Thanks On Mon, Aug 31, 2015 at 4:19 AM, Simon Glass wrote: > This board has not been converted to generic board by the deadline. > Remove it. > > Signed-off-by: Simon Glass > --- > > arch/arm/Kconfig | 5 - > board/cirrus/edb93xx/Kconfig | 15 -- > board/cirrus/edb93xx/MAINTAINERS | 6 - > board/cirrus/edb93xx/Makefile| 11 -- > board/cirrus/edb93xx/edb93xx.c | 382 > --- > board/cirrus/edb93xx/u-boot.lds | 116 > configs/edb9315a_defconfig | 6 - > include/configs/edb93xx.h| 284 - > 8 files changed, 825 deletions(-) > delete mode 100644 board/cirrus/edb93xx/Kconfig > delete mode 100644 board/cirrus/edb93xx/MAINTAINERS > delete mode 100644 board/cirrus/edb93xx/Makefile > delete mode 100644 board/cirrus/edb93xx/edb93xx.c > delete mode 100644 board/cirrus/edb93xx/u-boot.lds > delete mode 100644 configs/edb9315a_defconfig > delete mode 100644 include/configs/edb93xx.h > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 5429dc8..fa52901 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -69,10 +69,6 @@ choice > config ARCH_AT91 > bool "Atmel AT91" > > -config TARGET_EDB93XX > - bool "Support edb93xx" > - select CPU_ARM920T > - > config TARGET_SCB9328 > bool "Support scb9328" > select CPU_ARM920T > @@ -889,7 +885,6 @@ source "board/boundary/nitrogen6x/Kconfig" > source "board/broadcom/bcm28155_ap/Kconfig" > source "board/broadcom/bcmcygnus/Kconfig" > source "board/broadcom/bcmnsp/Kconfig" > -source "board/cirrus/edb93xx/Kconfig" > source "board/compulab/cm_t335/Kconfig" > source "board/compulab/cm_t43/Kconfig" > source "board/compulab/cm_fx6/Kconfig" > diff --git a/board/cirrus/edb93xx/Kconfig b/board/cirrus/edb93xx/Kconfig > deleted file mode 100644 > index c5f4897..000 > --- a/board/cirrus/edb93xx/Kconfig > +++ /dev/null > @@ -1,15 +0,0 @@ > -if TARGET_EDB93XX > - > -config SYS_BOARD > - default "edb93xx" > - > -config SYS_VENDOR > - default "cirrus" > - > -config SYS_SOC > - default "ep93xx" > - > -config SYS_CONFIG_NAME > - default "edb93xx" > - > -endif > diff --git a/board/cirrus/edb93xx/MAINTAINERS > b/board/cirrus/edb93xx/MAINTAINERS > deleted file mode 100644 > index 3bb2843..000 > --- a/board/cirrus/edb93xx/MAINTAINERS > +++ /dev/null > @@ -1,6 +0,0 @@ > -EDB93XX BOARD > -M: Sergey Kostanbaev > -S: Maintained > -F: board/cirrus/edb93xx/ > -F: include/configs/edb93xx.h > -F: configs/edb9315a_defconfig > diff --git a/board/cirrus/edb93xx/Makefile b/board/cirrus/edb93xx/Makefile > deleted file mode 100644 > index d03c498..000 > --- a/board/cirrus/edb93xx/Makefile > +++ /dev/null > @@ -1,11 +0,0 @@ > -# > -# (C) Copyright 2013 > -# Sergey Kostanbaev fairwaves.ru> > -# > -# (C) Copyright 2003-2006 > -# Wolfgang Denk, DENX Software Engineering, wd denx.de. > -# > -# * SPDX-License-Identifier: GPL-2.0+ > -# > - > -obj-y := edb93xx.o > diff --git a/board/cirrus/edb93xx/edb93xx.c > b/board/cirrus/edb93xx/edb93xx.c > deleted file mode 100644 > index 8963d3a..000 > --- a/board/cirrus/edb93xx/edb93xx.c > +++ /dev/null > @@ -1,382 +0,0 @@ > -/* > - * Board initialization for EP93xx > - * > - * Copyright (C) 2013 > - * Sergey Kostanbaev fairwaves.ru> > - * > - * Copyright (C) 2009 > - * Matthias Kaehlcke kaehlcke.net> > - * > - * (C) Copyright 2002 2003 > - * Network Audio Technologies, Inc. > - * Adam Bezanson netaudiotech.com> > - * > - * SPDX-License-Identifier:GPL-2.0+ > - */ > - > -#include > -#include > -#include > -#include > -#include > - > -DECLARE_GLOBAL_DATA_PTR; > - > -/* > - * usb_div: 4, nbyp2: 1, pll2_en: 1 > - * pll2_x1: 36864.00, pll2_x2ip: 1536.00, > - * pll2_x2: 38400.00, pll2_out: 19200.00 > - */ > -#define CLKSET2_VAL(23 << SYSCON_CLKSET_PLL_X2IPD_SHIFT | \ > - 24 << SYSCON_CLKSET_PLL_X2FBD2_SHIFT | \ > - 24 << SYSCON_CLKSET_PLL_X1FBD1_SHIFT | \ > - 1 << SYSCON_CLKSET_PLL_PS_SHIFT | \ > - SYSCON_CLKSET2_PLL2_EN |\ > -
[U-Boot] [PATCH] arm: ep9315: Add .vectors section to lds and remove obsolete lds
However ep9315 don't use
interrupt vectors during startup, but _startup symbol is used inside uboot to
calculate actual monitor size.
Signed-off-by: Sergey Kostanbaev
Cc: albert.u.b...@aribaud.net
---
arch/arm/cpu/arm920t/ep93xx/u-boot.lds | 58 --
board/cirrus/edb93xx/u-boot.lds| 1 +
2 files changed, 1 insertion(+), 58 deletions(-)
delete mode 100644 arch/arm/cpu/arm920t/ep93xx/u-boot.lds
diff --git a/arch/arm/cpu/arm920t/ep93xx/u-boot.lds
b/arch/arm/cpu/arm920t/ep93xx/u-boot.lds
deleted file mode 100644
index 623a635..000
--- a/arch/arm/cpu/arm920t/ep93xx/u-boot.lds
+++ /dev/null
@@ -1,58 +0,0 @@
-/*
- * (C) Copyright 2002
- * Gary Jennejohn, DENX Software Engineering,
- *
- * SPDX-License-Identifier:GPL-2.0+
- */
-
-OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm")
-OUTPUT_ARCH(arm)
-ENTRY(_start)
-SECTIONS
-{
- . = 0x;
-
- . = ALIGN(4);
- .text :
- {
- *(.__image_copy_start)
- *(.vectors)
- arch/arm/cpu/arm920t/start.o(.text*)
- /* the EP93xx expects to find the pattern 'CRUS' at 0x1000 */
- . = 0x1000;
- LONG(0x53555243)
- *(.text*)
- }
-
- . = ALIGN(4);
- .rodata : { *(.rodata*) }
-
- . = ALIGN(4);
- .data : { *(.data*) }
-
- . = ALIGN(4);
- .got : { *(.got) }
-
- . = .;
-
- . = ALIGN(4);
- .u_boot_list : {
- KEEP(*(SORT(.u_boot_list*)));
- }
-
- . = ALIGN(4);
-
- .image_copy_end :
- {
- *(.__image_copy_end)
- }
-
- __bss_start = .;
- .bss : { *(.bss*) }
- __bss_end = .;
-
- .end :
- {
- *(.__end)
- }
-}
diff --git a/board/cirrus/edb93xx/u-boot.lds b/board/cirrus/edb93xx/u-boot.lds
index b0d892a..4aa7891 100644
--- a/board/cirrus/edb93xx/u-boot.lds
+++ b/board/cirrus/edb93xx/u-boot.lds
@@ -21,6 +21,7 @@ SECTIONS
. = ALIGN(4);
.text : {
*(.__image_copy_start)
+ *(.vectors)
arch/arm/cpu/arm920t/start.o (.text*)
. = 0x1000;
--
1.8.3.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6] arm: ep9315: Return back Cirrus Logic EDB9315A board support
Hi Masahiro, You were right, .vectors is needed now, but for the other reason. Although the edb93xx board in uboot doesn't exploit any interrupts but the _start symbol is needed to calculate the monitor size. gd->mon_len = (ulong)&__bss_end - (ulong)_start; Without .vectors _start is 0 and gd->mon_len is about 1.5GB. Some time ago it worked fine without .vectors section at all. Adding .vectors to lds fixes mon_len to actual size and uboot works fine. So I'll add this section and remove extra lds script. Thank you for pointing out the problem. Besrt Regards, Sergey On Fri, Jul 25, 2014 at 8:27 PM, sergey kostanbaev < sergey.kostanb...@gmail.com> wrote: > Hi Masahiro, > > Sorry I missed you mail since I was on vacation. > > On Mon, Jul 7, 2014 at 2:57 PM, Masahiro Yamada > wrote: > >> I have two questions: >> >> [1] Is this board really working? >> >> This patch added a linker script >> board/cirrus/edb93xx/u-boot.lds >> >> But '.vectors' section is missing from it. >> >> In my understanding, commit 41623c91b0 expects '.vectors' >> section handling for all ARM linker scripts. >> >> On the time I made the patch it worked fine. I'll test version in master. > > > >> >> [2] Why was board/cirrus/edb93xx/u-boot.lds added >> instead of re-using (or modifying) arch/arm/cpu/arm920t/ep93xx/u-boot.lds >> ? > > >> >> 'edb9315a' is the only one board with 'ep93xx' SoC. >> >> It means, if you add 'board/cirrus/edb93xx/u-boot.lds', >> 'arch/arm/cpu/arm920t/ep93xx/u-boot.lds' is never used. >> >> Please delete either of them. >> > > Yes, I missed it I'll delete unneeded file. > > Thank you for your remarks > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6] arm: ep9315: Return back Cirrus Logic EDB9315A board support
Hi Masahiro, Sorry I missed you mail since I was on vacation. On Mon, Jul 7, 2014 at 2:57 PM, Masahiro Yamada wrote: > I have two questions: > > [1] Is this board really working? > > This patch added a linker script > board/cirrus/edb93xx/u-boot.lds > > But '.vectors' section is missing from it. > > In my understanding, commit 41623c91b0 expects '.vectors' > section handling for all ARM linker scripts. > > On the time I made the patch it worked fine. I'll test version in master. > > [2] Why was board/cirrus/edb93xx/u-boot.lds added > instead of re-using (or modifying) arch/arm/cpu/arm920t/ep93xx/u-boot.lds ? > > 'edb9315a' is the only one board with 'ep93xx' SoC. > > It means, if you add 'board/cirrus/edb93xx/u-boot.lds', > 'arch/arm/cpu/arm920t/ep93xx/u-boot.lds' is never used. > > Please delete either of them. > Yes, I missed it I'll delete unneeded file. Thank you for your remarks ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] arm: ep9315: Return back Cirrus Logic EDB9315A board support
Hi Albert,
See my comments below
> From V4 discussion:
>
> > > Is this needed? Can't the general get_ram_size() function be used?
> > >
> > This is REALLY needed. It's a key feature it calculates RAM size at
> > runtime otherwise you have to put constant of data-bus width, actual
> > memory installed. And this procedure does it and you don't have to
> > recompile it for the very specific board with similar processor
> > family.
>
> get_ram_size() does calculate the RAM size at run time, so I still fail
> to see why a dedicated function is needed. Can you please clarify this
> point?
>
If I understand correct function long get_ram_size(long *base, long
maxsize) in common/memsize.c does different job. It just calculate size
of continues memory region. But it's not always happen on EP93xx boards.
One board can have 32Mb but mapped as 4 region on 8Mb with 8Mb gap each.
Another may have 64Mb with 2*32Mb regions, and also 64*1Mb possible, etc.
So we need not just to calculate total size bu we need to understand dram
mapping configuration. E.g, for this EP9xx family on Windows CE you have to
set proper mapping during compilation. And compiled image won't work if you
have board with different DRAM chips. Some other bootloader exploits this
technique -- just to hardcode mapping. This solution calculate actual
mapping and one don't have to properly put defines and calculate it. So I
think, it's better to have very specific dedicated function but to leave it
working with many different EP-based boards.
Is it clear now?
> From V4 discussion:
>
> > > Does this board need a specific .lds file?
> > >
> > Yes. It must have special magic header to start booting otherwise it
> > will be considered as invalid image and internal boot ROOM ignore it.
>
> I guess the magic header is this portion:
>
> > +OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm")
> > +OUTPUT_ARCH(arm)
> > +ENTRY(_start)
> > +SECTIONS
> > +{
> > + . = 0x;
> > +
> > + . = ALIGN(4);
> > + .text : {
> > + *(.__image_copy_start)
> > + arch/arm/cpu/arm920t/start.o (.text*)
> - start of 'magic header'
> > + . = 0x1000;
> > +
> > + LONG(0x53555243)
> - end of 'magic header'
> > + *(.text*)
> > + }
>
> If so, then I do understand that you currently need a specific lds
> file, but please document this through a comment in the linker script.
>
You point it right, I'll add a comment here
Best Regards,
Sergey
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] arm: ep9315: Return back Cirrus Logic EDB9315A board support
Hi Albert,
See answers below
On Thu, Apr 17, 2014 at 10:12 AM, Albert ARIBAUD
wrote:
> Hi Sergey,
>
> On Thu, 6 Mar 2014 21:20:20 +0400, Sergey Kostanbaev
> wrote:
>
> > diff --git a/arch/arm/cpu/arm920t/ep93xx/lowlevel_init.S
> b/arch/arm/cpu/arm920t/ep93xx/lowlevel_init.S
> > index bf2fa2a..3ac0f88 100644
> > --- a/arch/arm/cpu/arm920t/ep93xx/lowlevel_init.S
> > +++ b/arch/arm/cpu/arm920t/ep93xx/lowlevel_init.S
> > @@ -1,49 +1,456 @@
> > /*
> > * Low-level initialization for EP93xx
> > *
> > - * Copyright (C) 2009 Matthias Kaehlcke
> > + * Copyright (C) 2013
> > + * Sergey Kostanabev fairwaves.ru>
> > *
> > - * Copyright (C) 2006 Dominic Rath
> > + * Copyright (C) 2006 Cirrus Logic Inc.
>
> Why do you remove existing copyright attributions?
>
Actually I used a completely different solution. I can add old ones.
>
> > [...]
>
> > + * Determine the size of the SDRAM. Use data=address for the scan.
> > +
> > + * Input:r0 - Start SDRAM address
> > + * Return: r0 - Single block size
> > + * r1 - Valid block mask
> > + * r2 - Total block count
> > + * Modifies: r0-r5
> > + */
> > +ep93xx_sdram_size:
>
> Is this needed? Can't the general get_ram_size() function be used?
>
This is REALLY needed. It's a key feature it calculates RAM size at runtime
otherwise you have to put constant of data-bus width, actual memory
installed. And this procedure does it and you don't have to recompile it
for the very specific board with similar processor family.
>
> > diff --git a/arch/arm/include/asm/arch-ep93xx/ep93xx.h
> b/arch/arm/include/asm/arch-ep93xx/ep93xx.h
> > index 9e7f2f3..71aa601 100644
> > --- a/arch/arm/include/asm/arch-ep93xx/ep93xx.h
> > +++ b/arch/arm/include/asm/arch-ep93xx/ep93xx.h
>
> > @@ -580,3 +658,11 @@ struct syscon_regs {
> > /*
> > * 0x8095 - 0x9000: Reserved
> > */
> > +
> > +/*
> > + * During low_level init we store memory layout in memory at specific
> location
> > + */
> > +#define UBOOT_MEMORYCNF_BANK_SIZE0x2000
> > +#define UBOOT_MEMORYCNF_BANK_MASK0x2004
> > +#define UBOOT_MEMORYCNF_BANK_COUNT 0x2008
> > +
>
> Remove blank line at EOF.
>
Ok
>
> > diff --git a/board/cirrus/edb93xx/u-boot.lds
> b/board/cirrus/edb93xx/u-boot.lds
>
> Does this board need a specific .lds file?
>
Yes. It must have special magic header to start booting otherwise it will
be considered as invalid image and internal boot ROOM ignore it.
>
> > [...]
>
> > + /DISCARD/ : { *(.dynsym) }
> > + /DISCARD/ : { *(.dynstr*) }
> > + /DISCARD/ : { *(.dynamic*) }
> > + /DISCARD/ : { *(.plt*) }
> > + /DISCARD/ : { *(.interp*) }
> > + /DISCARD/ : { *(.gnu*) }
>
> We don't /DISCARD/ these sections any more. If for some reason the
> generic .lds fils cannot be used, then adapt this one to current
> practice.
>
Ok I can remove these DISCARD.
>
> Amicalement,
> --
> Albert.
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: ep9315: Return back Cirrus Logic EDB9315A board support
Hi Albert, I modified the patch, but it didn't worked on the board. Than I realized the cause of this problem is in interrupt_init() function. It has IRQ_STACK_START_IN variable touched before relocation, which is in flash. Later I found other guys had same problem. So if it's going to be fixed my patch works ok. I'll send it right away. Maybe as a hack just to add a special #define for now just not to break other platform? Best Regards, Sergey On Mon, Dec 2, 2013 at 9:30 PM, Albert ARIBAUD wrote: > Hi sergey.kostanbaev, > > On Tue, 22 Oct 2013 17:18:45 +0400, "sergey.kostanbaev" > wrote: > >> From: Sergey Kostanbaev >> >> This patch returns back support for old ep93xx processors family >> >> Signed-off-by: Sergey Kostanbaev >> Cc: albert.u.b...@aribaud.net >> --- > > This patch seems not to apply cleanly on current ARM. Can you rebase > and send V3? > > Amicalement, > -- > Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/5] ep93xx: remove remainders of dead board
Hi Masahiro,
EP93xx is not dead! I recently submit patch for full support of
edb9315a board (see http://patchwork.ozlabs.org/patch/276429/). And
it's working well on my boards and on the original evaluation board.
Best Regards,
Sergey Kostanbaev
On Tue, Sep 24, 2013 at 5:32 AM, Masahiro Yamada
wrote:
> commit 716f7ade104a9aeed647e19a8b8c9ed9f491359d
> deleted all ep93xx SoC boards.
>
> Now ep93xx SoC specific code
> - arch/arm/cpu/arm920t/ep93xx/
> - arch/arm/include/asm/arch-ep93xx/
> are not used at all.
>
> Signed-off-by: Masahiro Yamada
> ---
> arch/arm/cpu/arm920t/ep93xx/Makefile| 41 --
> arch/arm/cpu/arm920t/ep93xx/cpu.c | 37 --
> arch/arm/cpu/arm920t/ep93xx/led.c | 85
> arch/arm/cpu/arm920t/ep93xx/lowlevel_init.S | 49 ---
> arch/arm/cpu/arm920t/ep93xx/speed.c | 96 -
> arch/arm/cpu/arm920t/ep93xx/timer.c | 120 --
> arch/arm/cpu/arm920t/ep93xx/u-boot.lds | 54 ---
> arch/arm/include/asm/arch-ep93xx/ep93xx.h | 582
>
> 8 files changed, 1064 deletions(-)
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/Makefile
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/cpu.c
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/led.c
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/lowlevel_init.S
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/speed.c
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/timer.c
> delete mode 100644 arch/arm/cpu/arm920t/ep93xx/u-boot.lds
> delete mode 100644 arch/arm/include/asm/arch-ep93xx/ep93xx.h
>
> diff --git a/arch/arm/cpu/arm920t/ep93xx/Makefile
> b/arch/arm/cpu/arm920t/ep93xx/Makefile
> deleted file mode 100644
> index 7a75c86..000
> --- a/arch/arm/cpu/arm920t/ep93xx/Makefile
> +++ /dev/null
> @@ -1,41 +0,0 @@
> -#
> -# Cirrus Logic EP93xx CPU-specific Makefile
> -#
> -# Copyright (C) 2009 Matthias Kaehlcke
> -#
> -# Copyright (C) 2004, 2005
> -# Cory T. Tusar, Videon Central, Inc.,
> -#
> -# Copyright (C) 2006
> -# Dominic Rath
> -#
> -# Based on an original Makefile, which is
> -#
> -# (C) Copyright 2000, 2001, 2002
> -# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
> -#
> -# SPDX-License-Identifier: GPL-2.0+
> -#
> -include $(TOPDIR)/config.mk
> -
> -LIB = $(obj)lib$(SOC).o
> -
> -COBJS = cpu.o led.o speed.o timer.o
> -SOBJS = lowlevel_init.o
> -
> -SRCS:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> -OBJS:= $(addprefix $(obj),$(SOBJS) $(COBJS))
> -
> -all:$(obj).depend $(LIB)
> -
> -$(LIB): $(OBJS)
> - $(call cmd_link_o_target, $(OBJS))
> -
> -#
> -
> -# defines $(obj).depend target
> -include $(SRCTREE)/rules.mk
> -
> -sinclude $(obj).depend
> -
> -#
> diff --git a/arch/arm/cpu/arm920t/ep93xx/cpu.c
> b/arch/arm/cpu/arm920t/ep93xx/cpu.c
> deleted file mode 100644
> index bb5ffd2..000
> --- a/arch/arm/cpu/arm920t/ep93xx/cpu.c
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -/*
> - * Cirrus Logic EP93xx CPU-specific support.
> - *
> - * Copyright (C) 2009 Matthias Kaehlcke
> - *
> - * Copyright (C) 2004, 2005
> - * Cory T. Tusar, Videon Central, Inc.,
> - *
> - * SPDX-License-Identifier:GPL-2.0+
> - */
> -
> -#include
> -#include
> -#include
> -
> -/* We reset the CPU by generating a 1-->0 transition on DeviceCfg bit 31. */
> -extern void reset_cpu(ulong addr)
> -{
> - struct syscon_regs *syscon = (struct syscon_regs *)SYSCON_BASE;
> - uint32_t value;
> -
> - /* Unlock DeviceCfg and set SWRST */
> - writel(0xAA, &syscon->sysswlock);
> - value = readl(&syscon->devicecfg);
> - value |= SYSCON_DEVICECFG_SWRST;
> - writel(value, &syscon->devicecfg);
> -
> - /* Unlock DeviceCfg and clear SWRST */
> - writel(0xAA, &syscon->sysswlock);
> - value = readl(&syscon->devicecfg);
> - value &= ~SYSCON_DEVICECFG_SWRST;
> - writel(value, &syscon->devicecfg);
> -
> - /* Dying... */
> - while (1)
> - ; /* noop */
> -}
> diff --git a/arch/arm/cpu/arm920t/ep93xx/led.c
> b/arch/arm/cpu/arm920t/ep93xx/led.c
> deleted file mode 100644
> index 6144729..000
> --- a/arch/arm/cpu/arm920t/ep93xx/led.c
> +++ /dev/null
> @@ -1,85 +0,0 @@
> -/*
> - * Copyright (C) 2010, 2009 Matthias Kaehlcke
> - *
> - * SPDX-License-Identifier:GPL-2.0+
> - */
> -
> -#include
> -#include
> -#include
> -#include
> -
> -static uint8_t saved_state[
Re: [U-Boot] [PATCH 5/5] net: ep93xx_eth: remove a dead driver.
Hi Masahiro,
And this driver works fine when my patch
(http://patchwork.ozlabs.org/patch/276429/) applied.
Best Regards,
Sergey Kostanbaev
On Tue, Sep 24, 2013 at 5:32 AM, Masahiro Yamada
wrote:
> commit 716f7ade104a9aeed647e19a8b8c9ed9f491359d
> deleted all ep93xx SoC boards.
>
> Now there are no boards enabling CONFIG_EP93XX,
> no boards using ep93xx_eth driver.
>
> Signed-off-by: Masahiro Yamada
> ---
> doc/driver-model/UDM-net.txt | 6 -
> drivers/net/Makefile | 1 -
> drivers/net/ep93xx_eth.c | 639
> ---
> drivers/net/ep93xx_eth.h | 127 -
> include/common.h | 3 +-
> include/netdev.h | 1 -
> 6 files changed, 1 insertion(+), 776 deletions(-)
> delete mode 100644 drivers/net/ep93xx_eth.c
> delete mode 100644 drivers/net/ep93xx_eth.h
>
> diff --git a/doc/driver-model/UDM-net.txt b/doc/driver-model/UDM-net.txt
> index 097ed69..f447f59 100644
> --- a/doc/driver-model/UDM-net.txt
> +++ b/doc/driver-model/UDM-net.txt
> @@ -217,12 +217,6 @@ III) Analysis of in-tree drivers
>This driver uses the standard new networking API, therefore there should
> be no
>obstacles throughout the conversion process.
>
> - drivers/net/ep93xx_eth.c
> -
> -
> - This driver uses the standard new networking API, therefore there should
> be no
> - obstacles throughout the conversion process.
> -
>drivers/net/ethoc.c
>---
>
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 18fd54f..7436e64 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -25,7 +25,6 @@ COBJS-$(CONFIG_E1000) += e1000.o
> COBJS-$(CONFIG_E1000_SPI) += e1000_spi.o
> COBJS-$(CONFIG_EEPRO100) += eepro100.o
> COBJS-$(CONFIG_ENC28J60) += enc28j60.o
> -COBJS-$(CONFIG_EP93XX) += ep93xx_eth.o
> COBJS-$(CONFIG_ETHOC) += ethoc.o
> COBJS-$(CONFIG_FEC_MXC) += fec_mxc.o
> COBJS-$(CONFIG_FSLDMAFEC) += fsl_mcdmafec.o mcfmii.o
> diff --git a/drivers/net/ep93xx_eth.c b/drivers/net/ep93xx_eth.c
> deleted file mode 100644
> index 1c09f10..000
> --- a/drivers/net/ep93xx_eth.c
> +++ /dev/null
> @@ -1,639 +0,0 @@
> -/*
> - * Cirrus Logic EP93xx ethernet MAC / MII driver.
> - *
> - * Copyright (C) 2010, 2009
> - * Matthias Kaehlcke
> - *
> - * Copyright (C) 2004, 2005
> - * Cory T. Tusar, Videon Central, Inc.,
> - *
> - * Based on the original eth.[ch] Cirrus Logic EP93xx Rev D. Ethernet Driver,
> - * which is
> - *
> - * (C) Copyright 2002 2003
> - * Adam Bezanson, Network Audio Technologies, Inc.
> - *
> - *
> - * SPDX-License-Identifier:GPL-2.0+
> - */
> -
> -#include
> -#include
> -#include
> -#include
> -#include
> -#include
> -#include
> -#include "ep93xx_eth.h"
> -
> -#define GET_PRIV(eth_dev) ((struct ep93xx_priv *)(eth_dev)->priv)
> -#define GET_REGS(eth_dev) (GET_PRIV(eth_dev)->regs)
> -
> -/* ep93xx_miiphy ops forward declarations */
> -static int ep93xx_miiphy_read(const char * const dev, unsigned char const
> addr,
> - unsigned char const reg, unsigned short * const
> value);
> -static int ep93xx_miiphy_write(const char * const dev, unsigned char const
> addr,
> - unsigned char const reg, unsigned short const value);
> -
> -#if defined(EP93XX_MAC_DEBUG)
> -/**
> - * Dump ep93xx_mac values to the terminal.
> - */
> -static void dump_dev(struct eth_device *dev)
> -{
> - struct ep93xx_priv *priv = GET_PRIV(dev);
> - int i;
> -
> - printf("\ndump_dev()\n");
> - printf(" rx_dq.base %p\n", priv->rx_dq.base);
> - printf(" rx_dq.current %p\n", priv->rx_dq.current);
> - printf(" rx_dq.end %p\n", priv->rx_dq.end);
> - printf(" rx_sq.base %p\n", priv->rx_sq.base);
> - printf(" rx_sq.current %p\n", priv->rx_sq.current);
> - printf(" rx_sq.end %p\n", priv->rx_sq.end);
> -
> - for (i = 0; i < NUMRXDESC; i++)
> - printf(" rx_buffer[%2.d] %p\n", i, NetRxPackets[i]);
> -
> - printf(" tx_dq.base %p\n", priv->tx_dq.base);
> - printf(" tx_dq.current %p\n", priv->tx_dq.current);
> - printf(" tx_dq.end %p\n", priv->tx_dq.end);
> - printf(" tx_sq.base %p\n", priv->tx_sq.base);
> - printf(" tx_sq.current %p\n", priv->tx_sq.current);
> - printf(" tx_sq.end
