Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
On Fri, 26 Apr 2024 15:38:10 +0200, Michal Simek wrote: > currently only DT way is supported and it is added directly to lib/smbios.c > but I think DT and env is only one way how information can be found that's > why this series is improving handling with using sysinfo driver which can > be platform specific. > At the end of day DT should be taken from smbios.c and put to sysinfo DT > driver instead of implementing it directly in this generic file. > > [...] Applied to u-boot/next, thanks! -- Tom
Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
Hi, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be platform specific. At the end of day DT should be taken from smbios.c and put to sysinfo DT driver instead of implementing it directly in this generic file. Thanks, Michal Michal Simek (3): xilinx: Enable SMBIOS command lib: smbios: Let detect the system via sysinfo lib: smbios: Detect system properties via SYSINFO IDs configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs/xilinx_zynqmp_kria_defconfig | 1 + configs/xilinx_zynqmp_virt_defconfig | 1 + include/sysinfo.h| 9 + lib/smbios.c | 42 +++- 6 files changed, 46 insertions(+), 9 deletions(-) Heinrich/Tom: Can you please take this series to your tree? Feel free to take also 1/3 which is my branch but can go with it too. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP/Versal ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal/Versal NET SoCs TF-A maintainer - Xilinx ZynqMP/Versal/Versal NET SoCs
Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
Hi Michal, On Fri, 7 Jun 2024 at 01:53, Michal Simek wrote: > > > > On 5/24/24 12:07, Ilias Apalodimas wrote: > > Hi Michal > > > > > > On Fri, 24 May 2024 at 12:45, Michal Simek wrote: > >> > >> Hi Ilias, > >> > >> On 4/26/24 15:38, Michal Simek wrote: > >>> Hi, > >>> > >>> currently only DT way is supported and it is added directly to > >>> lib/smbios.c > >>> but I think DT and env is only one way how information can be found that's > >>> why this series is improving handling with using sysinfo driver which can > >>> be platform specific. > >>> At the end of day DT should be taken from smbios.c and put to sysinfo DT > >>> driver instead of implementing it directly in this generic file. > >>> > >>> Thanks, > >>> Michal > >>> > >>> > >>> Michal Simek (3): > >>> xilinx: Enable SMBIOS command > >>> lib: smbios: Let detect the system via sysinfo > >>> lib: smbios: Detect system properties via SYSINFO IDs > >>> > >>>configs/xilinx_versal_net_virt_defconfig | 1 + > >>>configs/xilinx_versal_virt_defconfig | 1 + > >>>configs/xilinx_zynqmp_kria_defconfig | 1 + > >>>configs/xilinx_zynqmp_virt_defconfig | 1 + > >>>include/sysinfo.h| 9 + > >>>lib/smbios.c | 42 +++- > >>>6 files changed, 46 insertions(+), 9 deletions(-) > >>> > >> > >> > >> Any comment on this series? > > > > It's mostly Simon that created that sysinfo stuff, so I was expecting > > him to have a look. > > I can put in on my bucket list, but that's going to take some time > > Simon: Any comment? It looks OK to me. Regards, Simon
Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
On 5/24/24 12:07, Ilias Apalodimas wrote: Hi Michal On Fri, 24 May 2024 at 12:45, Michal Simek wrote: Hi Ilias, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be platform specific. At the end of day DT should be taken from smbios.c and put to sysinfo DT driver instead of implementing it directly in this generic file. Thanks, Michal Michal Simek (3): xilinx: Enable SMBIOS command lib: smbios: Let detect the system via sysinfo lib: smbios: Detect system properties via SYSINFO IDs configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs/xilinx_zynqmp_kria_defconfig | 1 + configs/xilinx_zynqmp_virt_defconfig | 1 + include/sysinfo.h| 9 + lib/smbios.c | 42 +++- 6 files changed, 46 insertions(+), 9 deletions(-) Any comment on this series? It's mostly Simon that created that sysinfo stuff, so I was expecting him to have a look. I can put in on my bucket list, but that's going to take some time Simon: Any comment? Thanks, Michal
Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
Hi Michal On Fri, 24 May 2024 at 12:45, Michal Simek wrote: > > Hi Ilias, > > On 4/26/24 15:38, Michal Simek wrote: > > Hi, > > > > currently only DT way is supported and it is added directly to lib/smbios.c > > but I think DT and env is only one way how information can be found that's > > why this series is improving handling with using sysinfo driver which can > > be platform specific. > > At the end of day DT should be taken from smbios.c and put to sysinfo DT > > driver instead of implementing it directly in this generic file. > > > > Thanks, > > Michal > > > > > > Michal Simek (3): > >xilinx: Enable SMBIOS command > >lib: smbios: Let detect the system via sysinfo > >lib: smbios: Detect system properties via SYSINFO IDs > > > > configs/xilinx_versal_net_virt_defconfig | 1 + > > configs/xilinx_versal_virt_defconfig | 1 + > > configs/xilinx_zynqmp_kria_defconfig | 1 + > > configs/xilinx_zynqmp_virt_defconfig | 1 + > > include/sysinfo.h| 9 + > > lib/smbios.c | 42 +++- > > 6 files changed, 46 insertions(+), 9 deletions(-) > > > > > Any comment on this series? It's mostly Simon that created that sysinfo stuff, so I was expecting him to have a look. I can put in on my bucket list, but that's going to take some time Thanks /Ilias > > Thanks, > Michal
Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
Hi Ilias, On 4/26/24 15:38, Michal Simek wrote: Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be platform specific. At the end of day DT should be taken from smbios.c and put to sysinfo DT driver instead of implementing it directly in this generic file. Thanks, Michal Michal Simek (3): xilinx: Enable SMBIOS command lib: smbios: Let detect the system via sysinfo lib: smbios: Detect system properties via SYSINFO IDs configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs/xilinx_zynqmp_kria_defconfig | 1 + configs/xilinx_zynqmp_virt_defconfig | 1 + include/sysinfo.h| 9 + lib/smbios.c | 42 +++- 6 files changed, 46 insertions(+), 9 deletions(-) Any comment on this series? Thanks, Michal
[PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver
Hi, currently only DT way is supported and it is added directly to lib/smbios.c but I think DT and env is only one way how information can be found that's why this series is improving handling with using sysinfo driver which can be platform specific. At the end of day DT should be taken from smbios.c and put to sysinfo DT driver instead of implementing it directly in this generic file. Thanks, Michal Michal Simek (3): xilinx: Enable SMBIOS command lib: smbios: Let detect the system via sysinfo lib: smbios: Detect system properties via SYSINFO IDs configs/xilinx_versal_net_virt_defconfig | 1 + configs/xilinx_versal_virt_defconfig | 1 + configs/xilinx_zynqmp_kria_defconfig | 1 + configs/xilinx_zynqmp_virt_defconfig | 1 + include/sysinfo.h| 9 + lib/smbios.c | 42 +++- 6 files changed, 46 insertions(+), 9 deletions(-) -- 2.44.0
