RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hi Alex,
> > Also I recommend to print the master clock in MHz, and to print the master
> > clock name/label from ccf driver:
> > https://github.com/u-boot/u-boot/blob/master/drivers/clk/at91/sama7g5.
> > c#L410
>
> Should be possible. I could do this and send a v2?
>
> Yes Please 😊
> Also please note that older SAM9/SAMA5 series have no ccf drivers ☹
> Only SAM9X6+ and SAMA7 series have ccf 😊
Okay I thought this would be easy, but it seems not. This is what I came up
with:
-printf("mck clock rate: %lu\n", clk_get_rate(nc->mck));
+printf("%s rate: %lu MHz\n",
+ nc->mck->dev->name ? nc->mck->dev->name : "mck clock",
+ clk_get_rate(nc->mck) / 100);
And this is the output on sam9x60 with CONFIG_CLK_CCF enabled:
pmc@fc00 rate: 200 MHz
The corresponding line from `clk dump` is:
25| | | `-- mck_div
That name, I don't get it where to get that one.
You can revert to initial print and add MHz 😊
MCK rate: 200 MHz
Thanks.
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hello everyone,
Am Mon, Mar 18, 2024 at 11:15:18AM + schrieb mihai.s...@microchip.com:
>
> > The command is very useful.
> > I would like to have also the ONFI timing mode printed for nand-flash
> > 😊
>
> As far as I can see the actually set mode is not stored anywhere. One could
> print it after it was successfully set, but that would be in nand base, not
> in the atmel driver.
>
> OK. Understood.
> Thanks.
>
> > Also I recommend to print the master clock in MHz, and to print the master
> > clock name/label from ccf driver:
> > https://github.com/u-boot/u-boot/blob/master/drivers/clk/at91/sama7g5.
> > c#L410
>
> Should be possible. I could do this and send a v2?
>
> Yes Please 😊
> Also please note that older SAM9/SAMA5 series have no ccf drivers ☹
> Only SAM9X6+ and SAMA7 series have ccf 😊
Okay I thought this would be easy, but it seems not. This is what I
came up with:
-printf("mck clock rate: %lu\n", clk_get_rate(nc->mck));
+printf("%s rate: %lu MHz\n",
+ nc->mck->dev->name ? nc->mck->dev->name : "mck clock",
+ clk_get_rate(nc->mck) / 100);
And this is the output on sam9x60 with CONFIG_CLK_CCF enabled:
pmc@fc00 rate: 200 MHz
The corresponding line from `clk dump` is:
25| | | `-- mck_div
That name, I don't get it where to get that one.
Greets
Alex
> Thanks.
>
>
> Greets
> Alex
>
> >
> > Tested-by: Mihai Sain
> >
> > Best regards,
> > Mihai Sain
RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hi Alexander, > Maybe we should add an automatic fallback for timing mode in > nand-controller.c 😊 > As of now the driver is forcing tRC_min to 30ns (mode 3), which is not > reliable for sama7 nfc controller ☹ > > https://github.com/u-boot/u-boot/blob/master/drivers/mtd/nand/raw/nand_timings.c#L167 > The nand torture command helped me to manually force tRC_min to 35ns > (mode 2). This sounds like the same problem encountered in https://github.com/linux4sam/at91bootstrap/issues/174 and the fix proposed there works in Linux and U-Boot as well. I consider the original commit message of the patch attached to that ticket not easy to understand however, so I wrote what I think is the problem. Could you please test the patch attached to this mail which does the same thing and should apply to U-Boot cleanly? I tested that on sam9x60 and sama5, but have no other boards/socs to test with. If that works on sama7, I will propose it on U-Boot, too. (I hope it is okay to attach it as an attachment for now, it's not ready for submission anyways.) I tested your patch on sama7g54-curiosity board. I also reverted to (conf->timings.sdr.tRC_min < 3), to force mode 3 😊 Indeed the decode command reports tighter timings. I tested using nand torture on 16MiB and 32MiB sizes. U-Boot> nand info Device 0: nand0, sector size 256 KiB Manufacturer MACRONIX Model MX30LF4G28AD Device size512 MiB Page size 4096 b OOB size 256 b Erase size 262144 b ecc strength 8 bits ecc step size 512 b subpagesize 4096 b options 0x40004200 bbt options 0x00028000 U-Boot> hsmc decode mck clock rate: 2 HSMC_SETUP3:0x0002 HSMC_PULSE3:0x07040703 HSMC_CYCLE3:0x00070007 HSMC_TIMINGS3: 0x880402f2 HSMC_MODE3: 0x001f0003 NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 ns) NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE signal Read operation controlled by NRD signal U-Boot> nand torture 0x80 0x100 NAND torture: device 0 offset 0x80 size 0x100 (block size 0x4) Passed: 64, failed: 0 U-Boot> nand torture 0x80 0x200 NAND torture: device 0 offset 0x80 size 0x200 (block size 0x4) Passed: 128, failed: 0 Tested-by: Mihai Sain Best regards, Mihai Sain
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hello Mihai,
Am Mon, Mar 18, 2024 at 11:28:39AM + schrieb mihai.s...@microchip.com:
> Hi Alexander,
>
> I'm sorry for quoting because the email is sent from Outlook ☹
>
> > > U-Boot> nand info
> > >
> > > Device 0: nand0, sector size 256 KiB
> > > Manufacturer MACRONIX
> > > Model MX30LF4G28AD
> > > Device size512 MiB
> > > Page size 4096 b
> > > OOB size 256 b
> > > Erase size 262144 b
> > > ecc strength 8 bits
> > > ecc step size 512 b
> > > subpagesize 4096 b
> > > options 0x4200
> > > bbt options 0x00028000
> >
> > This seems to be the same NAND chip as on the sam9x60 curiosity, but your
> > output has three additional lines, see mine:
> > Do you have some additional patches printing manufacturer, model, and
> > device size? I can't see those lines printed in
> > nand_print_and_set_info() here.
> >
> > Yes. I have 😊
> > + printf(" Manufacturer %s \n", chip->onfi_params.manufacturer);
> > + printf(" Model %s \n", chip->onfi_params.model);
> > + printf(" Device size %8d MiB\n", (int)(chip->chipsize >> 20));
>
> This is nice, and I think it would be valuable to have upstream.
> Maybe you could send a patch for that?
> Sure. I will send the patch !
>
> > > U-Boot> hsmc decode
> > >
> > > mck clock rate: 2
> > >
> > > HSMC_SETUP3:0x0001
> > > HSMC_PULSE3:0x07040804
> > > HSMC_CYCLE3:0x00070008
> > > HSMC_TIMINGS3: 0x880402f2
> > > HSMC_MODE3: 0x001f0003
> > > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35
> > > ns)
> > >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7
> > > (35 ns)
> > > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40
> > > ns)
> > >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8
> > > (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus
> > > Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE
> > > signal Read operation controlled by NRD signal
> >
> > This is also interesting. Given the mck clock rate is the same as on
> > sam9x60, I would have guessed the timings set by
> > atmel_smc_nand_prepare_smcconf() should give the same results, both for
> > ONFI timiming mode 3, which is the fastest mode the (H)SMC supports
> > according to comments in the driver. This is the output with the patch in
> > question applied on next for sam9x60:
> >
> > U-Boot> hsmc decode
> >
> > mck clock rate: 2
> >
> > SMC_SETUP3: 0x0002
> > SMC_PULSE3: 0x06030703
> > SMC_CYCLE3: 0x00060007
> > SMC_MODE3: 0x001f0003
> > NCS_RD: setup: 0 (0 ns), pulse: 6 (30 ns), hold: 0 (0 ns), cycle: 6 (30
> > ns)
> >NRD: setup: 0 (0 ns), pulse: 3 (15 ns), hold: 3 (15 ns), cycle: 6
> > (30 ns)
> > NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35
> > ns)
> >NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7
> > (35 ns)
> > Standard read is applied.
> > TDF optimization enabled
> > TDF cycles: 15 (75 ns)
> > Data Bus Width: 8-bit bus
> > NWAIT Mode: 0
> > Write operation controlled by NWE signal
> > Read operation controlled by NRD signal
> >
> > Notice the pulse times for read are one clock cycle smaller than in your
> > output, and the timings for write are also different. Do you have changes
> > for atmel_smc_nand_prepare_smcconf() applied which are not upstream yet?
> > Or is the HSMC on sama7g54 somehow different than on older SoCs?
> >
> > Yes. I force timing mode 2 in nand-controller.c:
> > + if (conf->timings.sdr.tRC_min < 30001) // force timing mode 2,
> > + 35ns for read/write cycle
> >
> > This will pass the nand torture test 😊
> >
> > U-Boot> nand torture 0x80 0x100
> >
> > NAND torture: device 0 offset 0x80 size 0x100 (block size
> > 0x4)
> > Passed: 64, failed: 0
>
> Ah okay. I have another patch here for manually setting the ONFI timing mode
> from commandline. This is probably too late for some scenarios, but it
> helped me when testing. If you're interested I could send it to the public.
> Yes. I'm very interested !
Okay, I'll add it to v2 of the series then.
> Maybe we should add an automatic fallback for timing mode in
> nand-controller.c 😊
> As of now the driver is forcing tRC_min to 30ns (mode 3), which is not
> reliable for sama7 nfc controller ☹
>
> https://github.com/u-boot/u-boot/blob/master/drivers/mtd/nand/raw/nand_timings.c#L167
> The nand torture command helped me to manually force tRC_min to 35ns
> (mode 2).
This sounds like the same problem encountered in
https://github.com/linux4sam/at91bootstrap/issues/174 and the fix
proposed there works in Linux and U-Boot as well. I consider the
original commit message of the patch attached to that ticket not easy
to understand however, so I wrote what I
RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hi Alexander,
I'm sorry for quoting because the email is sent from Outlook ☹
> > U-Boot> nand info
> >
> > Device 0: nand0, sector size 256 KiB
> > Manufacturer MACRONIX
> > Model MX30LF4G28AD
> > Device size512 MiB
> > Page size 4096 b
> > OOB size 256 b
> > Erase size 262144 b
> > ecc strength 8 bits
> > ecc step size 512 b
> > subpagesize 4096 b
> > options 0x4200
> > bbt options 0x00028000
>
> This seems to be the same NAND chip as on the sam9x60 curiosity, but your
> output has three additional lines, see mine:
> Do you have some additional patches printing manufacturer, model, and
> device size? I can't see those lines printed in
> nand_print_and_set_info() here.
>
> Yes. I have 😊
> + printf(" Manufacturer %s \n", chip->onfi_params.manufacturer);
> + printf(" Model %s \n", chip->onfi_params.model);
> + printf(" Device size %8d MiB\n", (int)(chip->chipsize >> 20));
This is nice, and I think it would be valuable to have upstream.
Maybe you could send a patch for that?
Sure. I will send the patch !
> > U-Boot> hsmc decode
> >
> > mck clock rate: 2
> >
> > HSMC_SETUP3:0x0001
> > HSMC_PULSE3:0x07040804
> > HSMC_CYCLE3:0x00070008
> > HSMC_TIMINGS3: 0x880402f2
> > HSMC_MODE3: 0x001f0003
> > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns)
> >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7
> > (35 ns)
> > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns)
> >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8
> > (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus
> > Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE
> > signal Read operation controlled by NRD signal
>
> This is also interesting. Given the mck clock rate is the same as on
> sam9x60, I would have guessed the timings set by
> atmel_smc_nand_prepare_smcconf() should give the same results, both for ONFI
> timiming mode 3, which is the fastest mode the (H)SMC supports according to
> comments in the driver. This is the output with the patch in question
> applied on next for sam9x60:
>
> U-Boot> hsmc decode
>
> mck clock rate: 2
>
> SMC_SETUP3: 0x0002
> SMC_PULSE3: 0x06030703
> SMC_CYCLE3: 0x00060007
> SMC_MODE3: 0x001f0003
> NCS_RD: setup: 0 (0 ns), pulse: 6 (30 ns), hold: 0 (0 ns), cycle: 6 (30
> ns)
>NRD: setup: 0 (0 ns), pulse: 3 (15 ns), hold: 3 (15 ns), cycle: 6 (30
> ns)
> NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35
> ns)
>NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35
> ns)
> Standard read is applied.
> TDF optimization enabled
> TDF cycles: 15 (75 ns)
> Data Bus Width: 8-bit bus
> NWAIT Mode: 0
> Write operation controlled by NWE signal
> Read operation controlled by NRD signal
>
> Notice the pulse times for read are one clock cycle smaller than in your
> output, and the timings for write are also different. Do you have changes
> for atmel_smc_nand_prepare_smcconf() applied which are not upstream yet? Or
> is the HSMC on sama7g54 somehow different than on older SoCs?
>
> Yes. I force timing mode 2 in nand-controller.c:
> + if (conf->timings.sdr.tRC_min < 30001) // force timing mode 2,
> + 35ns for read/write cycle
>
> This will pass the nand torture test 😊
>
> U-Boot> nand torture 0x80 0x100
>
> NAND torture: device 0 offset 0x80 size 0x100 (block size
> 0x4)
> Passed: 64, failed: 0
Ah okay. I have another patch here for manually setting the ONFI timing mode
from commandline. This is probably too late for some scenarios, but it helped
me when testing. If you're interested I could send it to the public.
Yes. I'm very interested !
Maybe we should add an automatic fallback for timing mode in
nand-controller.c 😊
As of now the driver is forcing tRC_min to 30ns (mode 3), which is not
reliable for sama7 nfc controller ☹
https://github.com/u-boot/u-boot/blob/master/drivers/mtd/nand/raw/nand_timings.c#L167
The nand torture command helped me to manually force tRC_min to 35ns
(mode 2).
Thanks.
Greets
Alex
>
> Note: I'm currently testing a patch changing the computation of the read
> pulse cycles based on a patch for at91bootstrap [1], but that is not applied
> here for the output quoted above.
>
> Greets
> Alex
>
> [1]
> https://github.com/linux4sam/at91bootstrap/issues/174#issuecomment-197
> 0698527
>
> >
> > Best regards,
> > Mihai Sain
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hello Mihai,
Am Mon, Mar 18, 2024 at 09:07:09AM + schrieb mihai.s...@microchip.com:
> > U-Boot> nand info
> >
> > Device 0: nand0, sector size 256 KiB
> > Manufacturer MACRONIX
> > Model MX30LF4G28AD
> > Device size512 MiB
> > Page size 4096 b
> > OOB size 256 b
> > Erase size 262144 b
> > ecc strength 8 bits
> > ecc step size 512 b
> > subpagesize 4096 b
> > options 0x4200
> > bbt options 0x00028000
>
> This seems to be the same NAND chip as on the sam9x60 curiosity, but your
> output has three additional lines, see mine:
> Do you have some additional patches printing manufacturer, model, and device
> size? I can't see those lines printed in
> nand_print_and_set_info() here.
>
> Yes. I have 😊
> + printf(" Manufacturer %s \n", chip->onfi_params.manufacturer);
> + printf(" Model %s \n", chip->onfi_params.model);
> + printf(" Device size %8d MiB\n", (int)(chip->chipsize >> 20));
This is nice, and I think it would be valuable to have upstream.
Maybe you could send a patch for that?
> > U-Boot> hsmc decode
> >
> > mck clock rate: 2
> >
> > HSMC_SETUP3:0x0001
> > HSMC_PULSE3:0x07040804
> > HSMC_CYCLE3:0x00070008
> > HSMC_TIMINGS3: 0x880402f2
> > HSMC_MODE3: 0x001f0003
> > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns)
> >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7
> > (35 ns)
> > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns)
> >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8
> > (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus
> > Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE
> > signal Read operation controlled by NRD signal
>
> This is also interesting. Given the mck clock rate is the same as on
> sam9x60, I would have guessed the timings set by
> atmel_smc_nand_prepare_smcconf() should give the same results, both for ONFI
> timiming mode 3, which is the fastest mode the (H)SMC supports according to
> comments in the driver. This is the output with the patch in question
> applied on next for sam9x60:
>
> U-Boot> hsmc decode
>
> mck clock rate: 2
>
> SMC_SETUP3: 0x0002
> SMC_PULSE3: 0x06030703
> SMC_CYCLE3: 0x00060007
> SMC_MODE3: 0x001f0003
> NCS_RD: setup: 0 (0 ns), pulse: 6 (30 ns), hold: 0 (0 ns), cycle: 6 (30
> ns)
>NRD: setup: 0 (0 ns), pulse: 3 (15 ns), hold: 3 (15 ns), cycle: 6 (30
> ns)
> NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35
> ns)
>NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35
> ns)
> Standard read is applied.
> TDF optimization enabled
> TDF cycles: 15 (75 ns)
> Data Bus Width: 8-bit bus
> NWAIT Mode: 0
> Write operation controlled by NWE signal
> Read operation controlled by NRD signal
>
> Notice the pulse times for read are one clock cycle smaller than in your
> output, and the timings for write are also different. Do you have changes
> for atmel_smc_nand_prepare_smcconf() applied which are not upstream yet? Or
> is the HSMC on sama7g54 somehow different than on older SoCs?
>
> Yes. I force timing mode 2 in nand-controller.c:
> + if (conf->timings.sdr.tRC_min < 30001) // force timing mode 2, 35ns for
> read/write cycle
>
> This will pass the nand torture test 😊
>
> U-Boot> nand torture 0x80 0x100
>
> NAND torture: device 0 offset 0x80 size 0x100 (block size 0x4)
> Passed: 64, failed: 0
Ah okay. I have another patch here for manually setting the ONFI
timing mode from commandline. This is probably too late for some
scenarios, but it helped me when testing. If you're interested I
could send it to the public.
Greets
Alex
>
> Note: I'm currently testing a patch changing the computation of the read
> pulse cycles based on a patch for at91bootstrap [1], but that is not applied
> here for the output quoted above.
>
> Greets
> Alex
>
> [1]
> https://github.com/linux4sam/at91bootstrap/issues/174#issuecomment-1970698527
>
> >
> > Best regards,
> > Mihai Sain
RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
> The command is very useful. > I would like to have also the ONFI timing mode printed for nand-flash > 😊 As far as I can see the actually set mode is not stored anywhere. One could print it after it was successfully set, but that would be in nand base, not in the atmel driver. OK. Understood. Thanks. > Also I recommend to print the master clock in MHz, and to print the master > clock name/label from ccf driver: > https://github.com/u-boot/u-boot/blob/master/drivers/clk/at91/sama7g5. > c#L410 Should be possible. I could do this and send a v2? Yes Please 😊 Also please note that older SAM9/SAMA5 series have no ccf drivers ☹ Only SAM9X6+ and SAMA7 series have ccf 😊 Thanks. Greets Alex > > Tested-by: Mihai Sain > > Best regards, > Mihai Sain
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hello Mihai, Am Mon, Mar 18, 2024 at 09:15:29AM + schrieb mihai.s...@microchip.com: > > Hi Alexander, > > > > I tested your work on sama7g54-curiosity board: > > > > U-Boot> nand info > > > > Device 0: nand0, sector size 256 KiB > > Manufacturer MACRONIX > > Model MX30LF4G28AD > > Device size512 MiB > > Page size 4096 b > > OOB size 256 b > > Erase size 262144 b > > ecc strength 8 bits > > ecc step size 512 b > > subpagesize 4096 b > > options 0x4200 > > bbt options 0x00028000 > > > > U-Boot> hsmc decode > > > > mck clock rate: 2 > > > > HSMC_SETUP3:0x0001 > > HSMC_PULSE3:0x07040804 > > HSMC_CYCLE3:0x00070008 > > HSMC_TIMINGS3: 0x880402f2 > > HSMC_MODE3: 0x001f0003 > > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) > >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 > > (35 ns) > > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns) > >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8 > > (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus > > Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE > > signal Read operation controlled by NRD signal > > > > Best regards, > > Mihai Sain > > Hello Mihai, > > If you have any suggestions for improvement, changes, or you are happy with > this command, is it useful ? > You can provide your Tested-by then if you consider this is useful > > Eugen > > -- > > Hello Eugen, > > Yes. > The command is very useful. > I would like to have also the ONFI timing mode printed for nand-flash 😊 As far as I can see the actually set mode is not stored anywhere. One could print it after it was successfully set, but that would be in nand base, not in the atmel driver. > Also I recommend to print the master clock in MHz, and to print the master > clock name/label from ccf driver: > https://github.com/u-boot/u-boot/blob/master/drivers/clk/at91/sama7g5.c#L410 Should be possible. I could do this and send a v2? Greets Alex > > Tested-by: Mihai Sain > > Best regards, > Mihai Sain
RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
> Hi Alexander, > > I tested your work on sama7g54-curiosity board: > > U-Boot> nand info > > Device 0: nand0, sector size 256 KiB > Manufacturer MACRONIX > Model MX30LF4G28AD > Device size512 MiB > Page size 4096 b > OOB size 256 b > Erase size 262144 b > ecc strength 8 bits > ecc step size 512 b > subpagesize 4096 b > options 0x4200 > bbt options 0x00028000 > > U-Boot> hsmc decode > > mck clock rate: 2 > > HSMC_SETUP3:0x0001 > HSMC_PULSE3:0x07040804 > HSMC_CYCLE3:0x00070008 > HSMC_TIMINGS3: 0x880402f2 > HSMC_MODE3: 0x001f0003 > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 > (35 ns) > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns) >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8 > (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus > Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE > signal Read operation controlled by NRD signal > > Best regards, > Mihai Sain Hello Mihai, If you have any suggestions for improvement, changes, or you are happy with this command, is it useful ? You can provide your Tested-by then if you consider this is useful Eugen -- Hello Eugen, Yes. The command is very useful. I would like to have also the ONFI timing mode printed for nand-flash 😊 Also I recommend to print the master clock in MHz, and to print the master clock name/label from ccf driver: https://github.com/u-boot/u-boot/blob/master/drivers/clk/at91/sama7g5.c#L410 Tested-by: Mihai Sain Best regards, Mihai Sain
RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
> U-Boot> nand info
>
> Device 0: nand0, sector size 256 KiB
> Manufacturer MACRONIX
> Model MX30LF4G28AD
> Device size512 MiB
> Page size 4096 b
> OOB size 256 b
> Erase size 262144 b
> ecc strength 8 bits
> ecc step size 512 b
> subpagesize 4096 b
> options 0x4200
> bbt options 0x00028000
This seems to be the same NAND chip as on the sam9x60 curiosity, but your
output has three additional lines, see mine:
Do you have some additional patches printing manufacturer, model, and device
size? I can't see those lines printed in
nand_print_and_set_info() here.
Yes. I have 😊
+ printf(" Manufacturer %s \n", chip->onfi_params.manufacturer);
+ printf(" Model %s \n", chip->onfi_params.model);
+ printf(" Device size %8d MiB\n", (int)(chip->chipsize >> 20));
> U-Boot> hsmc decode
>
> mck clock rate: 2
>
> HSMC_SETUP3:0x0001
> HSMC_PULSE3:0x07040804
> HSMC_CYCLE3:0x00070008
> HSMC_TIMINGS3: 0x880402f2
> HSMC_MODE3: 0x001f0003
> NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns)
>NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7
> (35 ns)
> NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns)
>NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8
> (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus
> Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE
> signal Read operation controlled by NRD signal
This is also interesting. Given the mck clock rate is the same as on sam9x60,
I would have guessed the timings set by
atmel_smc_nand_prepare_smcconf() should give the same results, both for ONFI
timiming mode 3, which is the fastest mode the (H)SMC supports according to
comments in the driver. This is the output with the patch in question applied
on next for sam9x60:
U-Boot> hsmc decode
mck clock rate: 2
SMC_SETUP3: 0x0002
SMC_PULSE3: 0x06030703
SMC_CYCLE3: 0x00060007
SMC_MODE3: 0x001f0003
NCS_RD: setup: 0 (0 ns), pulse: 6 (30 ns), hold: 0 (0 ns), cycle: 6 (30 ns)
NRD: setup: 0 (0 ns), pulse: 3 (15 ns), hold: 3 (15 ns), cycle: 6 (30 ns)
NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns)
NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35
ns)
Standard read is applied.
TDF optimization enabled
TDF cycles: 15 (75 ns)
Data Bus Width: 8-bit bus
NWAIT Mode: 0
Write operation controlled by NWE signal
Read operation controlled by NRD signal
Notice the pulse times for read are one clock cycle smaller than in your
output, and the timings for write are also different. Do you have changes for
atmel_smc_nand_prepare_smcconf() applied which are not upstream yet? Or is the
HSMC on sama7g54 somehow different than on older SoCs?
Yes. I force timing mode 2 in nand-controller.c:
+ if (conf->timings.sdr.tRC_min < 30001) // force timing mode 2, 35ns for
read/write cycle
This will pass the nand torture test 😊
U-Boot> nand torture 0x80 0x100
NAND torture: device 0 offset 0x80 size 0x100 (block size 0x4)
Passed: 64, failed: 0
Note: I'm currently testing a patch changing the computation of the read pulse
cycles based on a patch for at91bootstrap [1], but that is not applied here for
the output quoted above.
Greets
Alex
[1]
https://github.com/linux4sam/at91bootstrap/issues/174#issuecomment-1970698527
>
> Best regards,
> Mihai Sain
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
Hello Mihai, Am Mon, Mar 18, 2024 at 08:09:00AM + schrieb mihai.s...@microchip.com: > On 3/7/24 11:10, Alexander Dahl wrote: > > For now adds one new command 'hsmc' with a single subcommand 'decode' > > to read and display the content of the registers of the Static Memory > > Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a > > better picture on what raw nand core and atmel nand controller driver > > try to set as timings based on ONFI parameters of the connected NAND > > chip. > > > > Tested on SAMA5D2 and SAM9X60 based boards. Example output: > > > > U-Boot> hsmc decode > > > > mck clock rate: 2 > > > > SMC_SETUP3: 0x0002 > > SMC_PULSE3: 0x07040703 > > SMC_CYCLE3: 0x00070007 > > SMC_MODE3: 0x001f0003 > > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 > > ns) > >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 > > (35 ns) > > NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 > > ns) > >NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 > > (35 ns) > > Standard read is applied. > > TDF optimization enabled > > TDF cycles: 15 (75 ns) > > Data Bus Width: 8-bit bus > > NWAIT Mode: 0 > > Write operation controlled by NWE signal > > Read operation controlled by NRD signal > > Adding Mihai as he is usually very interested in such debug information and > methods. > > - > > Hi Alexander, > > I tested your work on sama7g54-curiosity board: nice, thanks for that. > U-Boot> nand info > > Device 0: nand0, sector size 256 KiB > Manufacturer MACRONIX > Model MX30LF4G28AD > Device size512 MiB > Page size 4096 b > OOB size 256 b > Erase size 262144 b > ecc strength 8 bits > ecc step size 512 b > subpagesize 4096 b > options 0x4200 > bbt options 0x00028000 This seems to be the same NAND chip as on the sam9x60 curiosity, but your output has three additional lines, see mine: U-Boot> nand info Device 0: nand0, sector size 256 KiB Page size 4096 b OOB size 256 b Erase size 262144 b ecc strength 8 bits ecc step size 512 b subpagesize 4096 b options 0x40004200 bbt options 0x00028000 Do you have some additional patches printing manufacturer, model, and device size? I can't see those lines printed in nand_print_and_set_info() here. > U-Boot> hsmc decode > > mck clock rate: 2 > > HSMC_SETUP3:0x0001 > HSMC_PULSE3:0x07040804 > HSMC_CYCLE3:0x00070008 > HSMC_TIMINGS3: 0x880402f2 > HSMC_MODE3: 0x001f0003 > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 ns) > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns) >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8 (40 ns) > TDF optimization enabled > TDF cycles: 15 (75 ns) > Data Bus Width: 8-bit bus > NWAIT Mode: 0 > Write operation controlled by NWE signal > Read operation controlled by NRD signal This is also interesting. Given the mck clock rate is the same as on sam9x60, I would have guessed the timings set by atmel_smc_nand_prepare_smcconf() should give the same results, both for ONFI timiming mode 3, which is the fastest mode the (H)SMC supports according to comments in the driver. This is the output with the patch in question applied on next for sam9x60: U-Boot> hsmc decode mck clock rate: 2 SMC_SETUP3: 0x0002 SMC_PULSE3: 0x06030703 SMC_CYCLE3: 0x00060007 SMC_MODE3: 0x001f0003 NCS_RD: setup: 0 (0 ns), pulse: 6 (30 ns), hold: 0 (0 ns), cycle: 6 (30 ns) NRD: setup: 0 (0 ns), pulse: 3 (15 ns), hold: 3 (15 ns), cycle: 6 (30 ns) NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35 ns) Standard read is applied. TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE signal Read operation controlled by NRD signal Notice the pulse times for read are one clock cycle smaller than in your output, and the timings for write are also different. Do you have changes for atmel_smc_nand_prepare_smcconf() applied which are not upstream yet? Or is the HSMC on sama7g54 somehow different than on older SoCs? Note: I'm currently testing a patch changing the computation of the read pulse cycles based on a patch for at91bootstrap [1], but that is not applied here for the output quoted above. Greets Alex [1] https://github.com/linux4sam/at91b
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
On 3/18/24 10:09, mihai.s...@microchip.com wrote: > On 3/7/24 11:10, Alexander Dahl wrote: >> For now adds one new command 'hsmc' with a single subcommand 'decode' >> to read and display the content of the registers of the Static Memory >> Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a >> better picture on what raw nand core and atmel nand controller driver >> try to set as timings based on ONFI parameters of the connected NAND >> chip. >> >> Tested on SAMA5D2 and SAM9X60 based boards. Example output: >> >> U-Boot> hsmc decode >> >> mck clock rate: 2 >> >> SMC_SETUP3: 0x0002 >> SMC_PULSE3: 0x07040703 >> SMC_CYCLE3: 0x00070007 >> SMC_MODE3: 0x001f0003 >> NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 >> ns) >>NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 >> ns) >> NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 >> ns) >>NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 >> (35 ns) >> Standard read is applied. >> TDF optimization enabled >> TDF cycles: 15 (75 ns) >> Data Bus Width: 8-bit bus >> NWAIT Mode: 0 >> Write operation controlled by NWE signal >> Read operation controlled by NRD signal > > Adding Mihai as he is usually very interested in such debug information and > methods. > > - > > Hi Alexander, > > I tested your work on sama7g54-curiosity board: > > U-Boot> nand info > > Device 0: nand0, sector size 256 KiB > Manufacturer MACRONIX > Model MX30LF4G28AD > Device size512 MiB > Page size 4096 b > OOB size 256 b > Erase size 262144 b > ecc strength 8 bits > ecc step size 512 b > subpagesize 4096 b > options 0x4200 > bbt options 0x00028000 > > U-Boot> hsmc decode > > mck clock rate: 2 > > HSMC_SETUP3:0x0001 > HSMC_PULSE3:0x07040804 > HSMC_CYCLE3:0x00070008 > HSMC_TIMINGS3: 0x880402f2 > HSMC_MODE3: 0x001f0003 > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 ns) > NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns) >NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8 (40 ns) > TDF optimization enabled > TDF cycles: 15 (75 ns) > Data Bus Width: 8-bit bus > NWAIT Mode: 0 > Write operation controlled by NWE signal > Read operation controlled by NRD signal > > Best regards, > Mihai Sain Hello Mihai, If you have any suggestions for improvement, changes, or you are happy with this command, is it useful ? You can provide your Tested-by then if you consider this is useful Eugen
RE: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
On 3/7/24 11:10, Alexander Dahl wrote: > For now adds one new command 'hsmc' with a single subcommand 'decode' > to read and display the content of the registers of the Static Memory > Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a > better picture on what raw nand core and atmel nand controller driver > try to set as timings based on ONFI parameters of the connected NAND > chip. > > Tested on SAMA5D2 and SAM9X60 based boards. Example output: > > U-Boot> hsmc decode > > mck clock rate: 2 > > SMC_SETUP3: 0x0002 > SMC_PULSE3: 0x07040703 > SMC_CYCLE3: 0x00070007 > SMC_MODE3: 0x001f0003 > NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 > ns) >NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 > ns) > NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 > ns) >NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35 > ns) > Standard read is applied. > TDF optimization enabled > TDF cycles: 15 (75 ns) > Data Bus Width: 8-bit bus > NWAIT Mode: 0 > Write operation controlled by NWE signal > Read operation controlled by NRD signal Adding Mihai as he is usually very interested in such debug information and methods. - Hi Alexander, I tested your work on sama7g54-curiosity board: U-Boot> nand info Device 0: nand0, sector size 256 KiB Manufacturer MACRONIX Model MX30LF4G28AD Device size512 MiB Page size 4096 b OOB size 256 b Erase size 262144 b ecc strength 8 bits ecc step size 512 b subpagesize 4096 b options 0x4200 bbt options 0x00028000 U-Boot> hsmc decode mck clock rate: 2 HSMC_SETUP3:0x0001 HSMC_PULSE3:0x07040804 HSMC_CYCLE3:0x00070008 HSMC_TIMINGS3: 0x880402f2 HSMC_MODE3: 0x001f0003 NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns) NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 ns) NCS_WR: setup: 0 (0 ns), pulse: 8 (40 ns), hold: 0 (0 ns), cycle: 8 (40 ns) NWE: setup: 1 (5 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 8 (40 ns) TDF optimization enabled TDF cycles: 15 (75 ns) Data Bus Width: 8-bit bus NWAIT Mode: 0 Write operation controlled by NWE signal Read operation controlled by NRD signal Best regards, Mihai Sain
Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
On 3/7/24 11:10, Alexander Dahl wrote:
> For now adds one new command 'hsmc' with a single subcommand 'decode' to
> read and display the content of the registers of the Static Memory
> Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a
> better picture on what raw nand core and atmel nand controller driver
> try to set as timings based on ONFI parameters of the connected NAND
> chip.
>
> Tested on SAMA5D2 and SAM9X60 based boards. Example output:
>
> U-Boot> hsmc decode
>
> mck clock rate: 2
>
> SMC_SETUP3: 0x0002
> SMC_PULSE3: 0x07040703
> SMC_CYCLE3: 0x00070007
> SMC_MODE3: 0x001f0003
> NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35
> ns)
>NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35
> ns)
> NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35
> ns)
>NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35
> ns)
> Standard read is applied.
> TDF optimization enabled
> TDF cycles: 15 (75 ns)
> Data Bus Width: 8-bit bus
> NWAIT Mode: 0
> Write operation controlled by NWE signal
> Read operation controlled by NRD signal
Adding Mihai as he is usually very interested in such debug information and
methods.
>
> Signed-off-by: Alexander Dahl
> ---
> drivers/mtd/nand/raw/Kconfig | 9 +
> drivers/mtd/nand/raw/atmel/nand-controller.c | 249 +++
> 2 files changed, 258 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index f6644899b0a..43057aa6c5b 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -50,12 +50,21 @@ config SYS_NAND_NO_SUBPAGE_WRITE
>
> config DM_NAND_ATMEL
> bool "Support Atmel NAND controller with DM support"
> + select MFD_ATMEL_SMC
> select SYS_NAND_SELF_INIT
> imply SYS_NAND_USE_FLASH_BBT
> help
> Enable this driver for NAND flash platforms using an Atmel NAND
> controller.
>
> +config CMD_NAND_ATMEL_DEBUG
> + bool "Optional debug commands for Atmel NAND controller"
> + depends on DM_NAND_ATMEL
> + help
> + Add commands for debugging internals of the Atmel NAND flash
> + controller, for example:
> + - Decode Static Memory Controller (SMC) registers
> +
> config NAND_ATMEL
> bool "Support Atmel NAND controller"
> select SYS_NAND_SELF_INIT
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c
> b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index e06523f3298..052d9c7b82a 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -51,11 +51,13 @@
>
> #include
> #include
> +#include
> #include
> #include
> #include
> #include
> #include
> +#include
> #include
> #include
> #include
> @@ -69,6 +71,7 @@
> #include
> #include
> #include
> +#include
>
> #include "pmecc.h"
>
> @@ -216,6 +219,7 @@ struct atmel_nand_controller_ops {
> int (*ecc_init)(struct nand_chip *chip);
> int (*setup_data_interface)(struct atmel_nand *nand, int csline,
> const struct nand_data_interface *conf);
> + void (*print_info)(struct atmel_nand *nand, int csline);
> };
>
> struct atmel_nand_controller_caps {
> @@ -2041,12 +2045,214 @@ err:
> return ret;
> }
>
> +#ifdef CONFIG_CMD_NAND_ATMEL_DEBUG
> +u32 atmel_smc_decode_ncycles(u32 reg, u32 shift, u32 msbpos, u32 msbwidth,
> u32 msbfactor)
> +{
> + /*
> + * Examples:
> + *
> + * NRD setup length = (128 * NRD_SETUP[5] + NRD_SETUP[4:0]) clock
> cycles.
> + * NRD pulse length = (256 * NRD_PULSE[6] + NRD_PULSE[5:0]) clock
> cycles.
> + * Read cycle length = (NRD_CYCLE[8:7] * 256) + NRD_CYCLE[6:0]
> clock cycles.
> + */
> +
> + reg >>= shift;
> +
> + u32 lsbmask = GENMASK(msbpos - 1, 0);
> + u32 msbmask = GENMASK(msbwidth - 1, 0) << msbpos;
> + u32 msb = (reg & msbmask) >> msbpos;
> + u32 lsb = (reg & lsbmask);
> +
> + return msb * msbfactor + lsb;
> +}
> +
> +static void atmel_smc_cs_conf_print_raw(struct atmel_smc_cs_conf *conf, int
> cs)
> +{
> + printf("SMC_SETUP%d: 0x%08x\n", cs, conf->setup);
> + printf("SMC_PULSE%d: 0x%08x\n", cs, conf->pulse);
> + printf("SMC_CYCLE%d: 0x%08x\n", cs, conf->cycle);
> + printf("SMC_MODE%d: 0x%08x\n", cs, conf->mode);
> +}
> +
> +static void atmel_hsmc_cs_conf_print_raw(struct atmel_smc_cs_conf *conf, int
> cs)
> +{
> + printf("HSMC_SETUP%d:0x%08x\n", cs, conf->setup);
> + printf("HSMC_PULSE%d:0x%08x\n", cs, conf->pulse);
> + printf("HSMC_CYCLE%d:0x%08x\n", cs, conf->cycle);
> + printf("HSMC_TIMINGS%d: 0x%08x\n", cs, conf->timings);
> + printf("HSMC_MODE%d: 0x%08x\n", cs, conf->mode);
> +}
> +
> +static void atmel
[PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands
For now adds one new command 'hsmc' with a single subcommand 'decode' to
read and display the content of the registers of the Static Memory
Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a
better picture on what raw nand core and atmel nand controller driver
try to set as timings based on ONFI parameters of the connected NAND
chip.
Tested on SAMA5D2 and SAM9X60 based boards. Example output:
U-Boot> hsmc decode
mck clock rate: 2
SMC_SETUP3: 0x0002
SMC_PULSE3: 0x07040703
SMC_CYCLE3: 0x00070007
SMC_MODE3: 0x001f0003
NCS_RD: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns)
NRD: setup: 0 (0 ns), pulse: 4 (20 ns), hold: 3 (15 ns), cycle: 7 (35 ns)
NCS_WR: setup: 0 (0 ns), pulse: 7 (35 ns), hold: 0 (0 ns), cycle: 7 (35 ns)
NWE: setup: 2 (10 ns), pulse: 3 (15 ns), hold: 2 (10 ns), cycle: 7 (35
ns)
Standard read is applied.
TDF optimization enabled
TDF cycles: 15 (75 ns)
Data Bus Width: 8-bit bus
NWAIT Mode: 0
Write operation controlled by NWE signal
Read operation controlled by NRD signal
Signed-off-by: Alexander Dahl
---
drivers/mtd/nand/raw/Kconfig | 9 +
drivers/mtd/nand/raw/atmel/nand-controller.c | 249 +++
2 files changed, 258 insertions(+)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index f6644899b0a..43057aa6c5b 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -50,12 +50,21 @@ config SYS_NAND_NO_SUBPAGE_WRITE
config DM_NAND_ATMEL
bool "Support Atmel NAND controller with DM support"
+ select MFD_ATMEL_SMC
select SYS_NAND_SELF_INIT
imply SYS_NAND_USE_FLASH_BBT
help
Enable this driver for NAND flash platforms using an Atmel NAND
controller.
+config CMD_NAND_ATMEL_DEBUG
+ bool "Optional debug commands for Atmel NAND controller"
+ depends on DM_NAND_ATMEL
+ help
+ Add commands for debugging internals of the Atmel NAND flash
+ controller, for example:
+ - Decode Static Memory Controller (SMC) registers
+
config NAND_ATMEL
bool "Support Atmel NAND controller"
select SYS_NAND_SELF_INIT
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c
b/drivers/mtd/nand/raw/atmel/nand-controller.c
index e06523f3298..052d9c7b82a 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -51,11 +51,13 @@
#include
#include
+#include
#include
#include
#include
#include
#include
+#include
#include
#include
#include
@@ -69,6 +71,7 @@
#include
#include
#include
+#include
#include "pmecc.h"
@@ -216,6 +219,7 @@ struct atmel_nand_controller_ops {
int (*ecc_init)(struct nand_chip *chip);
int (*setup_data_interface)(struct atmel_nand *nand, int csline,
const struct nand_data_interface *conf);
+ void (*print_info)(struct atmel_nand *nand, int csline);
};
struct atmel_nand_controller_caps {
@@ -2041,12 +2045,214 @@ err:
return ret;
}
+#ifdef CONFIG_CMD_NAND_ATMEL_DEBUG
+u32 atmel_smc_decode_ncycles(u32 reg, u32 shift, u32 msbpos, u32 msbwidth, u32
msbfactor)
+{
+ /*
+* Examples:
+*
+* NRD setup length = (128 * NRD_SETUP[5] + NRD_SETUP[4:0]) clock
cycles.
+* NRD pulse length = (256 * NRD_PULSE[6] + NRD_PULSE[5:0]) clock
cycles.
+* Read cycle length = (NRD_CYCLE[8:7] * 256) + NRD_CYCLE[6:0]
clock cycles.
+*/
+
+ reg >>= shift;
+
+ u32 lsbmask = GENMASK(msbpos - 1, 0);
+ u32 msbmask = GENMASK(msbwidth - 1, 0) << msbpos;
+ u32 msb = (reg & msbmask) >> msbpos;
+ u32 lsb = (reg & lsbmask);
+
+ return msb * msbfactor + lsb;
+}
+
+static void atmel_smc_cs_conf_print_raw(struct atmel_smc_cs_conf *conf, int cs)
+{
+ printf("SMC_SETUP%d: 0x%08x\n", cs, conf->setup);
+ printf("SMC_PULSE%d: 0x%08x\n", cs, conf->pulse);
+ printf("SMC_CYCLE%d: 0x%08x\n", cs, conf->cycle);
+ printf("SMC_MODE%d: 0x%08x\n", cs, conf->mode);
+}
+
+static void atmel_hsmc_cs_conf_print_raw(struct atmel_smc_cs_conf *conf, int
cs)
+{
+ printf("HSMC_SETUP%d:0x%08x\n", cs, conf->setup);
+ printf("HSMC_PULSE%d:0x%08x\n", cs, conf->pulse);
+ printf("HSMC_CYCLE%d:0x%08x\n", cs, conf->cycle);
+ printf("HSMC_TIMINGS%d: 0x%08x\n", cs, conf->timings);
+ printf("HSMC_MODE%d: 0x%08x\n", cs, conf->mode);
+}
+
+static void atmel_smc_print_reg(const char *name, u32 setup, u32 pulse,
+ u32 cycle, u32 clk_period_ns)
+{
+ u32 hold = cycle - pulse - setup;
+
+ printf("%6s: setup: %u (%u ns), pulse: %u (%u ns), hold: %u (%u ns),
cycle: %u (%u ns)\n",
+ name, setup, setup * clk_period_ns, pulse, pulse * clk_period_ns,
+
