Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
Hi Dhruva, On mer., mai 29, 2024 at 11:39, Dhruva Gole wrote: > Hi Sjoerd, > > On Aug 21, 2023 at 14:20:26 -0400, Tom Rini wrote: >> On Mon, Aug 21, 2023 at 04:13:32PM +, Marcel Ziswiler wrote: >> > Hi Sjoerd >> > >> > On Thu, 2023-06-01 at 08:37 +0200, Sjoerd Simons wrote: >> > > On Wed, 2023-05-31 at 17:14 -0400, Tom Rini wrote: >> > > > On Thu, Apr 06, 2023 at 08:55:34PM +0200, Sjoerd Simons wrote: >> > > > >> > > > > This series adds more boot sources for the TI am62x. For that the >> > > > > dts' >> > > > > are synced from the upstream ti-next git tree (to add usb nodes), >> > > > > some >> > > > > dwc3 glue is and finally the default configuration is tuned to add >> > > > > support for DFU and USB (host and gadget) >> > > > >> > > > This seems, conceptually, fine. But as we're getting the TI dts >> > > > files >> > > > in sync with the kernel, I'm deferring this version and you'll want >> > > > to >> > > > rebase and re-post once everything has settled. >> > > >> > > Thanks for the update/hint ;) I also got a few review comments so the >> > > plan is to include those and repost.. Just my may has been stupidly >> > > busy causing me to not get around it in the first place, so maybe that >> > > turned into good timing in the end. >> > >> > Any progress on this? >> > >> > I still carry your re-based series on top of latest master [1] and USB DFU >> > is working very well on Verdin AM62. >> > >> > Thanks! >> > >> > [1] https://github.com/ziswiler/u-boot/tree/verdin-am62-usb-support >> >> As the am62 files have been re-synced, re-basing this and re-posting for >> next would be appropriate at this point. > > Any updates on this? Do you have plans to rebase and resend this series? A part of this (USB DFU) has been taken over by Martyn and has been merged: https://lore.kernel.org/all/171581573300.812585.12291710364879103682.b4...@konsulko.com/ > > > > -- > Best regards, > Dhruva Gole
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
Hi Sjoerd, On Aug 21, 2023 at 14:20:26 -0400, Tom Rini wrote: > On Mon, Aug 21, 2023 at 04:13:32PM +, Marcel Ziswiler wrote: > > Hi Sjoerd > > > > On Thu, 2023-06-01 at 08:37 +0200, Sjoerd Simons wrote: > > > On Wed, 2023-05-31 at 17:14 -0400, Tom Rini wrote: > > > > On Thu, Apr 06, 2023 at 08:55:34PM +0200, Sjoerd Simons wrote: > > > > > > > > > This series adds more boot sources for the TI am62x. For that the > > > > > dts' > > > > > are synced from the upstream ti-next git tree (to add usb nodes), > > > > > some > > > > > dwc3 glue is and finally the default configuration is tuned to add > > > > > support for DFU and USB (host and gadget) > > > > > > > > This seems, conceptually, fine. But as we're getting the TI dts > > > > files > > > > in sync with the kernel, I'm deferring this version and you'll want > > > > to > > > > rebase and re-post once everything has settled. > > > > > > Thanks for the update/hint ;) I also got a few review comments so the > > > plan is to include those and repost.. Just my may has been stupidly > > > busy causing me to not get around it in the first place, so maybe that > > > turned into good timing in the end. > > > > Any progress on this? > > > > I still carry your re-based series on top of latest master [1] and USB DFU > > is working very well on Verdin AM62. > > > > Thanks! > > > > [1] https://github.com/ziswiler/u-boot/tree/verdin-am62-usb-support > > As the am62 files have been re-synced, re-basing this and re-posting for > next would be appropriate at this point. Any updates on this? Do you have plans to rebase and resend this series? -- Best regards, Dhruva Gole
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
On Mon, Aug 21, 2023 at 04:13:32PM +, Marcel Ziswiler wrote: > Hi Sjoerd > > On Thu, 2023-06-01 at 08:37 +0200, Sjoerd Simons wrote: > > On Wed, 2023-05-31 at 17:14 -0400, Tom Rini wrote: > > > On Thu, Apr 06, 2023 at 08:55:34PM +0200, Sjoerd Simons wrote: > > > > > > > This series adds more boot sources for the TI am62x. For that the > > > > dts' > > > > are synced from the upstream ti-next git tree (to add usb nodes), > > > > some > > > > dwc3 glue is and finally the default configuration is tuned to add > > > > support for DFU and USB (host and gadget) > > > > > > This seems, conceptually, fine. But as we're getting the TI dts > > > files > > > in sync with the kernel, I'm deferring this version and you'll want > > > to > > > rebase and re-post once everything has settled. > > > > Thanks for the update/hint ;) I also got a few review comments so the > > plan is to include those and repost.. Just my may has been stupidly > > busy causing me to not get around it in the first place, so maybe that > > turned into good timing in the end. > > Any progress on this? > > I still carry your re-based series on top of latest master [1] and USB DFU is > working very well on Verdin AM62. > > Thanks! > > [1] https://github.com/ziswiler/u-boot/tree/verdin-am62-usb-support As the am62 files have been re-synced, re-basing this and re-posting for next would be appropriate at this point. -- Tom signature.asc Description: PGP signature
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
Hi Sjoerd On Thu, 2023-06-01 at 08:37 +0200, Sjoerd Simons wrote: > On Wed, 2023-05-31 at 17:14 -0400, Tom Rini wrote: > > On Thu, Apr 06, 2023 at 08:55:34PM +0200, Sjoerd Simons wrote: > > > > > This series adds more boot sources for the TI am62x. For that the > > > dts' > > > are synced from the upstream ti-next git tree (to add usb nodes), > > > some > > > dwc3 glue is and finally the default configuration is tuned to add > > > support for DFU and USB (host and gadget) > > > > This seems, conceptually, fine. But as we're getting the TI dts > > files > > in sync with the kernel, I'm deferring this version and you'll want > > to > > rebase and re-post once everything has settled. > > Thanks for the update/hint ;) I also got a few review comments so the > plan is to include those and repost.. Just my may has been stupidly > busy causing me to not get around it in the first place, so maybe that > turned into good timing in the end. Any progress on this? I still carry your re-based series on top of latest master [1] and USB DFU is working very well on Verdin AM62. Thanks! [1] https://github.com/ziswiler/u-boot/tree/verdin-am62-usb-support Cheers Marcel
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
On Wed, 2023-05-31 at 17:14 -0400, Tom Rini wrote: > On Thu, Apr 06, 2023 at 08:55:34PM +0200, Sjoerd Simons wrote: > > > This series adds more boot sources for the TI am62x. For that the > > dts' > > are synced from the upstream ti-next git tree (to add usb nodes), > > some > > dwc3 glue is and finally the default configuration is tuned to add > > support for DFU and USB (host and gadget) > > This seems, conceptually, fine. But as we're getting the TI dts > files > in sync with the kernel, I'm deferring this version and you'll want > to > rebase and re-post once everything has settled. Thanks for the update/hint ;) I also got a few review comments so the plan is to include those and repost.. Just my may has been stupidly busy causing me to not get around it in the first place, so maybe that turned into good timing in the end. -- Sjoerd Simons Collabora Ltd.
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
On Thu, Apr 06, 2023 at 08:55:34PM +0200, Sjoerd Simons wrote: > This series adds more boot sources for the TI am62x. For that the dts' > are synced from the upstream ti-next git tree (to add usb nodes), some > dwc3 glue is and finally the default configuration is tuned to add > support for DFU and USB (host and gadget) > > > Changes in v2: > - Update dts sync to v6.3-rc5 > - Switch dwc3 glue to a seperate driver rather then in dwc-generic > - Minimize config changes to just DFU configuration > - Only enable usb port 0 DFU in SPL > - Create a seperate defconfig for R5 > > Sjoerd Simons (8): > omap: timer: add ti,am654-timer compatibility > arm: mach-k3: am62: Add timer0 id to the dev list > arm: dts: k3-am62: Bump dtsi from linux > arm: dts: k3-am625-sk: Enable emmc in SPL > usb: dwc3: Add dwc3 glue driver for am62 > configs: am62: Add configs for enabling USB in U-Boot > arm: dts: k3-am625-sk: Enable usb ports in u-boot > configs: am62x_evm_*: Enable USB and DFU support > > arch/arm/dts/k3-am62-main.dtsi| 259 +++--- > arch/arm/dts/k3-am62-mcu.dtsi | 49 + > arch/arm/dts/k3-am62-wakeup.dtsi | 4 +- > arch/arm/dts/k3-am625-r5-sk.dts | 2 +- > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 ++- > arch/arm/dts/k3-am625-sk.dts | 95 +- > arch/arm/dts/k3-am625.dtsi| 52 ++ > arch/arm/mach-k3/am62x/dev-data.c | 1 + > configs/am62x_evm_a53_defconfig | 35 +++- > configs/am62x_evm_r5_usbdfu_defconfig | 116 > drivers/timer/omap-timer.c| 1 + > drivers/usb/dwc3/Kconfig | 14 ++ > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-am62.c | 127 + > include/configs/am62x_evm.h | 10 +- > 15 files changed, 701 insertions(+), 92 deletions(-) > create mode 100644 configs/am62x_evm_r5_usbdfu_defconfig > create mode 100644 drivers/usb/dwc3/dwc3-am62.c > Tested-by: Ravi Gunasekaran > Tested-by: Mattijs Korpershoek This seems, conceptually, fine. But as we're getting the TI dts files in sync with the kernel, I'm deferring this version and you'll want to rebase and re-post once everything has settled. -- Tom signature.asc Description: PGP signature
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
Hi Sjoerd, Thank you for this series. On jeu., avril 06, 2023 at 20:55, Sjoerd Simons wrote: > This series adds more boot sources for the TI am62x. For that the dts' > are synced from the upstream ti-next git tree (to add usb nodes), some > dwc3 glue is and finally the default configuration is tuned to add > support for DFU and USB (host and gadget) > > > Changes in v2: > - Update dts sync to v6.3-rc5 > - Switch dwc3 glue to a seperate driver rather then in dwc-generic > - Minimize config changes to just DFU configuration > - Only enable usb port 0 DFU in SPL > - Create a seperate defconfig for R5 > > Sjoerd Simons (8): > omap: timer: add ti,am654-timer compatibility > arm: mach-k3: am62: Add timer0 id to the dev list > arm: dts: k3-am62: Bump dtsi from linux > arm: dts: k3-am625-sk: Enable emmc in SPL > usb: dwc3: Add dwc3 glue driver for am62 > configs: am62: Add configs for enabling USB in U-Boot > arm: dts: k3-am625-sk: Enable usb ports in u-boot > configs: am62x_evm_*: Enable USB and DFU support I've tested USB support on AM62x SK EVM for this whole series based on a public TI integration branch: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/log/?h=ti-u-boot-2023.04-next I did not test DFU, however with some small config changes I could test fastboot support using: => fastboot usb 0 Then from host: $ fastboot devices $ fastboot flash Tested-by: Mattijs Korpershoek > > arch/arm/dts/k3-am62-main.dtsi| 259 +++--- > arch/arm/dts/k3-am62-mcu.dtsi | 49 + > arch/arm/dts/k3-am62-wakeup.dtsi | 4 +- > arch/arm/dts/k3-am625-r5-sk.dts | 2 +- > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 ++- > arch/arm/dts/k3-am625-sk.dts | 95 +- > arch/arm/dts/k3-am625.dtsi| 52 ++ > arch/arm/mach-k3/am62x/dev-data.c | 1 + > configs/am62x_evm_a53_defconfig | 35 +++- > configs/am62x_evm_r5_usbdfu_defconfig | 116 > drivers/timer/omap-timer.c| 1 + > drivers/usb/dwc3/Kconfig | 14 ++ > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-am62.c | 127 + > include/configs/am62x_evm.h | 10 +- > 15 files changed, 701 insertions(+), 92 deletions(-) > create mode 100644 configs/am62x_evm_r5_usbdfu_defconfig > create mode 100644 drivers/usb/dwc3/dwc3-am62.c > > -- > 2.40.0
Re: [PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
On 07/04/23 12:25 am, Sjoerd Simons wrote: > This series adds more boot sources for the TI am62x. For that the dts' > are synced from the upstream ti-next git tree (to add usb nodes), some > dwc3 glue is and finally the default configuration is tuned to add > support for DFU and USB (host and gadget) > > > Changes in v2: > - Update dts sync to v6.3-rc5 > - Switch dwc3 glue to a seperate driver rather then in dwc-generic > - Minimize config changes to just DFU configuration > - Only enable usb port 0 DFU in SPL > - Create a seperate defconfig for R5 > > Sjoerd Simons (8): > omap: timer: add ti,am654-timer compatibility > arm: mach-k3: am62: Add timer0 id to the dev list > arm: dts: k3-am62: Bump dtsi from linux > arm: dts: k3-am625-sk: Enable emmc in SPL > usb: dwc3: Add dwc3 glue driver for am62 > configs: am62: Add configs for enabling USB in U-Boot > arm: dts: k3-am625-sk: Enable usb ports in u-boot > configs: am62x_evm_*: Enable USB and DFU support > > arch/arm/dts/k3-am62-main.dtsi| 259 +++--- > arch/arm/dts/k3-am62-mcu.dtsi | 49 + > arch/arm/dts/k3-am62-wakeup.dtsi | 4 +- > arch/arm/dts/k3-am625-r5-sk.dts | 2 +- > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 ++- > arch/arm/dts/k3-am625-sk.dts | 95 +- > arch/arm/dts/k3-am625.dtsi| 52 ++ > arch/arm/mach-k3/am62x/dev-data.c | 1 + > configs/am62x_evm_a53_defconfig | 35 +++- > configs/am62x_evm_r5_usbdfu_defconfig | 116 > drivers/timer/omap-timer.c| 1 + > drivers/usb/dwc3/Kconfig | 14 ++ > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-am62.c | 127 + > include/configs/am62x_evm.h | 10 +- > 15 files changed, 701 insertions(+), 92 deletions(-) > create mode 100644 configs/am62x_evm_r5_usbdfu_defconfig > create mode 100644 drivers/usb/dwc3/dwc3-am62.c I tested USB DFU boot on AM62 and it works fine. Tested-by: Ravi Gunasekaran -- Regards, Ravi
[PATCH v2 0/8] Add DFU, emmc and usb boot for TI am62x
This series adds more boot sources for the TI am62x. For that the dts' are synced from the upstream ti-next git tree (to add usb nodes), some dwc3 glue is and finally the default configuration is tuned to add support for DFU and USB (host and gadget) Changes in v2: - Update dts sync to v6.3-rc5 - Switch dwc3 glue to a seperate driver rather then in dwc-generic - Minimize config changes to just DFU configuration - Only enable usb port 0 DFU in SPL - Create a seperate defconfig for R5 Sjoerd Simons (8): omap: timer: add ti,am654-timer compatibility arm: mach-k3: am62: Add timer0 id to the dev list arm: dts: k3-am62: Bump dtsi from linux arm: dts: k3-am625-sk: Enable emmc in SPL usb: dwc3: Add dwc3 glue driver for am62 configs: am62: Add configs for enabling USB in U-Boot arm: dts: k3-am625-sk: Enable usb ports in u-boot configs: am62x_evm_*: Enable USB and DFU support arch/arm/dts/k3-am62-main.dtsi| 259 +++--- arch/arm/dts/k3-am62-mcu.dtsi | 49 + arch/arm/dts/k3-am62-wakeup.dtsi | 4 +- arch/arm/dts/k3-am625-r5-sk.dts | 2 +- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 ++- arch/arm/dts/k3-am625-sk.dts | 95 +- arch/arm/dts/k3-am625.dtsi| 52 ++ arch/arm/mach-k3/am62x/dev-data.c | 1 + configs/am62x_evm_a53_defconfig | 35 +++- configs/am62x_evm_r5_usbdfu_defconfig | 116 drivers/timer/omap-timer.c| 1 + drivers/usb/dwc3/Kconfig | 14 ++ drivers/usb/dwc3/Makefile | 1 + drivers/usb/dwc3/dwc3-am62.c | 127 + include/configs/am62x_evm.h | 10 +- 15 files changed, 701 insertions(+), 92 deletions(-) create mode 100644 configs/am62x_evm_r5_usbdfu_defconfig create mode 100644 drivers/usb/dwc3/dwc3-am62.c -- 2.40.0
