Re: [PATCH v3 1/2] rockchip: rk3399: fix incorrect ifdef check on SPL_DM_REGULATOR

2022-09-01 Thread Kever Yang 



On 2022/7/22 17:30, Quentin Schulz wrote:

From: Quentin Schulz 

The check to perform is on CONFIG_SPL_DM_REGULATOR and not
SPL_DM_REGULATOR. Also switch to in-code check instead of ifdefs.

Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
Cc: Quentin Schulz 
Signed-off-by: Quentin Schulz 


Reviewed-by: Kever Yang 

Thanks,
- Kever

---

v2:
  - use IS_ENABLED checks,

  arch/arm/mach-rockchip/rk3399/rk3399.c | 17 +
  1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c 
b/arch/arm/mach-rockchip/rk3399/rk3399.c
index 01a05599cd..8205511c25 100644
--- a/arch/arm/mach-rockchip/rk3399/rk3399.c
+++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
@@ -275,13 +275,14 @@ void spl_board_init(void)
rk3399_force_power_on_reset();
  #endif
  
-#if defined(SPL_DM_REGULATOR)

-   /*
-* Turning the eMMC and SPI back on (if disabled via the Qseven
-* BIOS_ENABLE) signal is done through a always-on regulator).
-*/
-   if (regulators_enable_boot_on(false))
-   debug("%s: Cannot enable boot on regulator\n", __func__);
-#endif
+   if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) {
+   /*
+* Turning the eMMC and SPI back on (if disabled via the Qseven
+* BIOS_ENABLE) signal is done through a always-on regulator).
+*/
+   if (regulators_enable_boot_on(false))
+   debug("%s: Cannot enable boot on regulator\n",
+ __func__);
+   }
  }
  #endif

Re: [PATCH v3 1/2] rockchip: rk3399: fix incorrect ifdef check on SPL_DM_REGULATOR

2022-08-21 Thread Peter Robinson 
On Fri, Jul 22, 2022 at 10:30 AM Quentin Schulz  wrote:
>
> From: Quentin Schulz 
>
> The check to perform is on CONFIG_SPL_DM_REGULATOR and not
> SPL_DM_REGULATOR. Also switch to in-code check instead of ifdefs.
>
> Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
> Cc: Quentin Schulz 
> Signed-off-by: Quentin Schulz 
> ---

For the series:
Reviewed-by: Peter Robinson 
Tested-by: Peter Robinson  # Rock960


> v2:
>  - use IS_ENABLED checks,
>
>  arch/arm/mach-rockchip/rk3399/rk3399.c | 17 +
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c 
> b/arch/arm/mach-rockchip/rk3399/rk3399.c
> index 01a05599cd..8205511c25 100644
> --- a/arch/arm/mach-rockchip/rk3399/rk3399.c
> +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
> @@ -275,13 +275,14 @@ void spl_board_init(void)
> rk3399_force_power_on_reset();
>  #endif
>
> -#if defined(SPL_DM_REGULATOR)
> -   /*
> -* Turning the eMMC and SPI back on (if disabled via the Qseven
> -* BIOS_ENABLE) signal is done through a always-on regulator).
> -*/
> -   if (regulators_enable_boot_on(false))
> -   debug("%s: Cannot enable boot on regulator\n", __func__);
> -#endif
> +   if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) {
> +   /*
> +* Turning the eMMC and SPI back on (if disabled via the 
> Qseven
> +* BIOS_ENABLE) signal is done through a always-on regulator).
> +*/
> +   if (regulators_enable_boot_on(false))
> +   debug("%s: Cannot enable boot on regulator\n",
> + __func__);
> +   }
>  }
>  #endif
> --
> 2.37.1
>

Re: [PATCH v3 1/2] rockchip: rk3399: fix incorrect ifdef check on SPL_DM_REGULATOR

2022-08-18 Thread Jagan Teki 
On Fri, Jul 22, 2022 at 3:00 PM Quentin Schulz  wrote:
>
> From: Quentin Schulz 
>
> The check to perform is on CONFIG_SPL_DM_REGULATOR and not
> SPL_DM_REGULATOR. Also switch to in-code check instead of ifdefs.
>
> Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
> Cc: Quentin Schulz 
> Signed-off-by: Quentin Schulz 
> ---

Reviewed-by: Jagan Teki

Re: [PATCH v3 1/2] rockchip: rk3399: fix incorrect ifdef check on SPL_DM_REGULATOR

2022-08-12 Thread Quentin Schulz 

Hi all,

Gentle ping on the series.

Cheers,
Quentin

On 7/22/22 11:30, Quentin Schulz wrote:

From: Quentin Schulz 

The check to perform is on CONFIG_SPL_DM_REGULATOR and not
SPL_DM_REGULATOR. Also switch to in-code check instead of ifdefs.

Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
Cc: Quentin Schulz 
Signed-off-by: Quentin Schulz 
---

v2:
  - use IS_ENABLED checks,

  arch/arm/mach-rockchip/rk3399/rk3399.c | 17 +
  1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c 
b/arch/arm/mach-rockchip/rk3399/rk3399.c
index 01a05599cd..8205511c25 100644
--- a/arch/arm/mach-rockchip/rk3399/rk3399.c
+++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
@@ -275,13 +275,14 @@ void spl_board_init(void)
rk3399_force_power_on_reset();
  #endif
  
-#if defined(SPL_DM_REGULATOR)

-   /*
-* Turning the eMMC and SPI back on (if disabled via the Qseven
-* BIOS_ENABLE) signal is done through a always-on regulator).
-*/
-   if (regulators_enable_boot_on(false))
-   debug("%s: Cannot enable boot on regulator\n", __func__);
-#endif
+   if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) {
+   /*
+* Turning the eMMC and SPI back on (if disabled via the Qseven
+* BIOS_ENABLE) signal is done through a always-on regulator).
+*/
+   if (regulators_enable_boot_on(false))
+   debug("%s: Cannot enable boot on regulator\n",
+ __func__);
+   }
  }
  #endif

[PATCH v3 1/2] rockchip: rk3399: fix incorrect ifdef check on SPL_DM_REGULATOR

2022-07-22 Thread Quentin Schulz 
From: Quentin Schulz 

The check to perform is on CONFIG_SPL_DM_REGULATOR and not
SPL_DM_REGULATOR. Also switch to in-code check instead of ifdefs.

Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
Cc: Quentin Schulz 
Signed-off-by: Quentin Schulz 
---

v2:
 - use IS_ENABLED checks,

 arch/arm/mach-rockchip/rk3399/rk3399.c | 17 +
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c 
b/arch/arm/mach-rockchip/rk3399/rk3399.c
index 01a05599cd..8205511c25 100644
--- a/arch/arm/mach-rockchip/rk3399/rk3399.c
+++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
@@ -275,13 +275,14 @@ void spl_board_init(void)
rk3399_force_power_on_reset();
 #endif
 
-#if defined(SPL_DM_REGULATOR)
-   /*
-* Turning the eMMC and SPI back on (if disabled via the Qseven
-* BIOS_ENABLE) signal is done through a always-on regulator).
-*/
-   if (regulators_enable_boot_on(false))
-   debug("%s: Cannot enable boot on regulator\n", __func__);
-#endif
+   if (IS_ENABLED(CONFIG_SPL_DM_REGULATOR)) {
+   /*
+* Turning the eMMC and SPI back on (if disabled via the Qseven
+* BIOS_ENABLE) signal is done through a always-on regulator).
+*/
+   if (regulators_enable_boot_on(false))
+   debug("%s: Cannot enable boot on regulator\n",
+ __func__);
+   }
 }
 #endif
-- 
2.37.1