Re: [U-Boot] [PATCH] ddr: altera: silence PHY calibration unless in debug mode
On 01/24/2018 02:19 PM, Goldschmidt Simon wrote: > On 01/11/2018 12:28, Marek Vasut wrote: >> On 01/11/2018 08:19 AM, Goldschmidt Simon wrote: >>> This driver has been using printf() including filename since it was >>> added. Convert to using debug() instead. >>> >>> Signed-off-by: Simon Goldschmidt >> >> Applied, thanks. > > I can't see this one in u-boot-socfpga. Anything wrong here? Please resend this one as well, sorry about that. -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ddr: altera: silence PHY calibration unless in debug mode
On 01/11/2018 12:28, Marek Vasut wrote:
> On 01/11/2018 08:19 AM, Goldschmidt Simon wrote:
>> This driver has been using printf() including filename since it was
>> added. Convert to using debug() instead.
>>
>> Signed-off-by: Simon Goldschmidt
>
> Applied, thanks.
I can't see this one in u-boot-socfpga. Anything wrong here?
Regards,
Simon
>> ---
>>
>> drivers/ddr/altera/sequencer.c | 8
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
>> index 6c6bd90e94..42e87b50d3 100644
>> --- a/drivers/ddr/altera/sequencer.c
>> +++ b/drivers/ddr/altera/sequencer.c
>> @@ -3534,7 +3534,7 @@ static void debug_mem_calibrate(int pass)
>> u32 debug_info;
>>
>> if (pass) {
>> - printf("%s: CALIBRATION PASSED\n", __FILE__);
>> + debug("%s: CALIBRATION PASSED\n", __FILE__);
>>
>> gbl->fom_in /= 2;
>> gbl->fom_out /= 2;
>> @@ -3553,7 +3553,7 @@ static void debug_mem_calibrate(int pass)
>> writel(debug_info, &phy_mgr_cfg->cal_debug_info);
>> writel(PHY_MGR_CAL_SUCCESS, &phy_mgr_cfg->cal_status);
>> } else {
>> - printf("%s: CALIBRATION FAILED\n", __FILE__);
>> + debug("%s: CALIBRATION FAILED\n", __FILE__);
<>
>> debug_info = gbl->error_stage;
>> debug_info |= gbl->error_substage << 8;
>> @@ -3570,7 +3570,7 @@ static void debug_mem_calibrate(int pass)
>> writel(debug_info, &sdr_reg_file->failing_stage);
>> }
>>
>> - printf("%s: Calibration complete\n", __FILE__);
>> + debug("%s: Calibration complete\n", __FILE__);
>> }
>>
>> /**
>> @@ -3741,7 +3741,7 @@ int sdram_calibration_full(void)
>>
>> initialize_tracking();
>>
>> - printf("%s: Preparing to start memory calibration\n", __FILE__);
>> + debug("%s: Preparing to start memory calibration\n", __FILE__);
>>
>> debug("%s:%d\n", __func__, __LINE__);
>> debug_cond(DLEVEL >= 1,
>>
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ddr: altera: silence PHY calibration unless in debug mode
On 01/11/2018 08:19 AM, Goldschmidt Simon wrote:
> This driver has been using printf() including filename since it was
> added. Convert to using debug() instead.
>
> Signed-off-by: Simon Goldschmidt
Applied, thanks.
> ---
>
> drivers/ddr/altera/sequencer.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
> index 6c6bd90e94..42e87b50d3 100644
> --- a/drivers/ddr/altera/sequencer.c
> +++ b/drivers/ddr/altera/sequencer.c
> @@ -3534,7 +3534,7 @@ static void debug_mem_calibrate(int pass)
> u32 debug_info;
>
> if (pass) {
> - printf("%s: CALIBRATION PASSED\n", __FILE__);
> + debug("%s: CALIBRATION PASSED\n", __FILE__);
>
> gbl->fom_in /= 2;
> gbl->fom_out /= 2;
> @@ -3553,7 +3553,7 @@ static void debug_mem_calibrate(int pass)
> writel(debug_info, &phy_mgr_cfg->cal_debug_info);
> writel(PHY_MGR_CAL_SUCCESS, &phy_mgr_cfg->cal_status);
> } else {
> - printf("%s: CALIBRATION FAILED\n", __FILE__);
> + debug("%s: CALIBRATION FAILED\n", __FILE__);
>
> debug_info = gbl->error_stage;
> debug_info |= gbl->error_substage << 8;
> @@ -3570,7 +3570,7 @@ static void debug_mem_calibrate(int pass)
> writel(debug_info, &sdr_reg_file->failing_stage);
> }
>
> - printf("%s: Calibration complete\n", __FILE__);
> + debug("%s: Calibration complete\n", __FILE__);
> }
>
> /**
> @@ -3741,7 +3741,7 @@ int sdram_calibration_full(void)
>
> initialize_tracking();
>
> - printf("%s: Preparing to start memory calibration\n", __FILE__);
> + debug("%s: Preparing to start memory calibration\n", __FILE__);
>
> debug("%s:%d\n", __func__, __LINE__);
> debug_cond(DLEVEL >= 1,
>
--
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] ddr: altera: silence PHY calibration unless in debug mode
This driver has been using printf() including filename since it was
added. Convert to using debug() instead.
Signed-off-by: Simon Goldschmidt
---
drivers/ddr/altera/sequencer.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
index 6c6bd90e94..42e87b50d3 100644
--- a/drivers/ddr/altera/sequencer.c
+++ b/drivers/ddr/altera/sequencer.c
@@ -3534,7 +3534,7 @@ static void debug_mem_calibrate(int pass)
u32 debug_info;
if (pass) {
- printf("%s: CALIBRATION PASSED\n", __FILE__);
+ debug("%s: CALIBRATION PASSED\n", __FILE__);
gbl->fom_in /= 2;
gbl->fom_out /= 2;
@@ -3553,7 +3553,7 @@ static void debug_mem_calibrate(int pass)
writel(debug_info, &phy_mgr_cfg->cal_debug_info);
writel(PHY_MGR_CAL_SUCCESS, &phy_mgr_cfg->cal_status);
} else {
- printf("%s: CALIBRATION FAILED\n", __FILE__);
+ debug("%s: CALIBRATION FAILED\n", __FILE__);
debug_info = gbl->error_stage;
debug_info |= gbl->error_substage << 8;
@@ -3570,7 +3570,7 @@ static void debug_mem_calibrate(int pass)
writel(debug_info, &sdr_reg_file->failing_stage);
}
- printf("%s: Calibration complete\n", __FILE__);
+ debug("%s: Calibration complete\n", __FILE__);
}
/**
@@ -3741,7 +3741,7 @@ int sdram_calibration_full(void)
initialize_tracking();
- printf("%s: Preparing to start memory calibration\n", __FILE__);
+ debug("%s: Preparing to start memory calibration\n", __FILE__);
debug("%s:%d\n", __func__, __LINE__);
debug_cond(DLEVEL >= 1,
--
2.11.0
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
