Re: [U-Boot] [PATCH] i2c: mvtwsi: Fix delay time for Turris Omnia
Hello Marek, Am 30.04.2019 um 09:01 schrieb Marek Behun: You mean tha patch series "[U-Boot] [PATCH u-boot-marvell v2 00/15] Fixes for Turris Omnia" So we can ignore this patch? bye, Heiko Yes :) Ok, fine. I set Patchwork state for this patch to superseded http://patchwork.ozlabs.org/patch/1090791/ bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] i2c: mvtwsi: Fix delay time for Turris Omnia
> You mean tha patch series > > "[U-Boot] [PATCH u-boot-marvell v2 00/15] Fixes for Turris Omnia" > > So we can ignore this patch? > > bye, > Heiko Yes :) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] i2c: mvtwsi: Fix delay time for Turris Omnia
Hello Marek, Am 30.04.2019 um 03:49 schrieb Marek Behun: I would really like not to see such board specific code added to this driver. Frankly, I fail to understand why used udelay(11) instead of udelay(10) should result in such a difference on your board. Could you please investigate a bit more and hopefully come up with a "better" solution for this issue? Thanks, Stefan Hi Stefan, I think I found what was the issue, just sent a patch series for Omnia, the last patch explains my theory and fixes the issue with one ndelay(100) You mean tha patch series "[U-Boot] [PATCH u-boot-marvell v2 00/15] Fixes for Turris Omnia" So we can ignore this patch? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] i2c: mvtwsi: Fix delay time for Turris Omnia
> I would really like not to see such board specific code added to this > driver. > > Frankly, I fail to understand why used udelay(11) instead of udelay(10) > should result in such a difference on your board. Could you please > investigate a bit more and hopefully come up with a "better" solution > for this issue? > > Thanks, > Stefan Hi Stefan, I think I found what was the issue, just sent a patch series for Omnia, the last patch explains my theory and fixes the issue with one ndelay(100) Marek ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] i2c: mvtwsi: Fix delay time for Turris Omnia
Hi Marek,
(added Heiko to Cc)
On 25.04.19 15:22, Marek Behún wrote:
Commit c68c6243 ("i2c: mvtwsi: Make delay times frequency-dependent")
broke the default configuration of the Turris Omnia target.
With i2c frequency at 100kHz the twsi_wait function call to ndelay(tick)
the tick variable is computed to 10340 (nanoseconds). Since ndelay
calls udelay(DIV_ROUND_UP(10340, 1000), the result is udelay(11).
For some reason this sometimes (cca every third boot) breaks the i2c
controller on Turris Omnia completely (even kernel cannot use it, and
soft reset does not help, only complete power off).
Microcontroller watchdog cannot be disabled without i2c and the device
is unusable.
The original commit message mentions erratum FE-8471889. This is weird
since Linux does not enable this erratum workaround for armada-38x. But
the commit message says that it was tested on Armada MV88F6820.
I therefore fix this in this unclean way only for Turris Omnia, because
I do not know if it would not break other devices.
Signed-off-by: Marek Behún
Cc: Mario Six
Cc: Stefan Roese
---
drivers/i2c/mvtwsi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c
index b0f7c3e057..ef269f3b0c 100644
--- a/drivers/i2c/mvtwsi.c
+++ b/drivers/i2c/mvtwsi.c
@@ -176,9 +176,13 @@ enum mvtwsi_ack_flags {
*/
inline uint calc_tick(uint speed)
{
+#ifdef CONFIG_TARGET_TURRIS_OMNIA
+ return 1;
+#else
/* One tick = the duration of a period at the specified speed in ns (we
* add 100 ns to be on the safe side) */
return (10u / speed) + 100;
+#endif
}
#ifndef CONFIG_DM_I2C
I would really like not to see such board specific code added to this
driver.
Frankly, I fail to understand why used udelay(11) instead of udelay(10)
should result in such a difference on your board. Could you please
investigate a bit more and hopefully come up with a "better" solution
for this issue?
Thanks,
Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] i2c: mvtwsi: Fix delay time for Turris Omnia
Commit c68c6243 ("i2c: mvtwsi: Make delay times frequency-dependent")
broke the default configuration of the Turris Omnia target.
With i2c frequency at 100kHz the twsi_wait function call to ndelay(tick)
the tick variable is computed to 10340 (nanoseconds). Since ndelay
calls udelay(DIV_ROUND_UP(10340, 1000), the result is udelay(11).
For some reason this sometimes (cca every third boot) breaks the i2c
controller on Turris Omnia completely (even kernel cannot use it, and
soft reset does not help, only complete power off).
Microcontroller watchdog cannot be disabled without i2c and the device
is unusable.
The original commit message mentions erratum FE-8471889. This is weird
since Linux does not enable this erratum workaround for armada-38x. But
the commit message says that it was tested on Armada MV88F6820.
I therefore fix this in this unclean way only for Turris Omnia, because
I do not know if it would not break other devices.
Signed-off-by: Marek Behún
Cc: Mario Six
Cc: Stefan Roese
---
drivers/i2c/mvtwsi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c
index b0f7c3e057..ef269f3b0c 100644
--- a/drivers/i2c/mvtwsi.c
+++ b/drivers/i2c/mvtwsi.c
@@ -176,9 +176,13 @@ enum mvtwsi_ack_flags {
*/
inline uint calc_tick(uint speed)
{
+#ifdef CONFIG_TARGET_TURRIS_OMNIA
+ return 1;
+#else
/* One tick = the duration of a period at the specified speed in ns (we
* add 100 ns to be on the safe side) */
return (10u / speed) + 100;
+#endif
}
#ifndef CONFIG_DM_I2C
--
2.21.0
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
