Re: [U-Boot] [PATCH] imx6: add Bachmann OT1200 board v2

2014-10-01 Thread Christian Gmeiner
Hi Stefano

 On 22/09/2014 13:57, Christian Gmeiner wrote:
  This patch adds support for the OT1200 series of devices.
 
  Following components are used in u-boot:
  + ethernet
  + i2c
  + emmc
  + gpio
 
  For more details see README.
 
  Changes v1  v2

 Can you also version your patches in the subject ? (aka: [PATCH vX]
 imx6:...). Rather patchwork makes some mess and it is not able to
 follow the versions, numbering helps - thanks !

Upps.


 There are some warnings reported by checkpatch, a couple opf them are
 due to line over 80 chars.

 Please fix warnings and repost, thanks !

Will do - thanks.


- make use of enable_cspi_clock(..)
- fix usage of OUTPUT_40OHM define
- added README
 
  Signed-off-by: Christian Gmeiner christian.gmei...@gmail.com
  ---
   arch/arm/Kconfig  |   4 +
   board/bachmann/ot1200/Kconfig |  23 
   board/bachmann/ot1200/MAINTAINERS |   6 +
   board/bachmann/ot1200/Makefile|   9 ++
   board/bachmann/ot1200/README  |  20 +++
   board/bachmann/ot1200/ot1200.c| 251 
  ++
   configs/ot1200_defconfig  |   3 +
   include/configs/ot1200.h  | 196 +
   8 files changed, 512 insertions(+)
   create mode 100644 board/bachmann/ot1200/Kconfig
   create mode 100644 board/bachmann/ot1200/MAINTAINERS
   create mode 100644 board/bachmann/ot1200/Makefile
   create mode 100644 board/bachmann/ot1200/README
   create mode 100644 board/bachmann/ot1200/ot1200.c
   create mode 100644 configs/ot1200_defconfig
   create mode 100644 include/configs/ot1200.h
 
  diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
  index 106aed9..8face21 100644
  --- a/arch/arm/Kconfig
  +++ b/arch/arm/Kconfig
  @@ -414,6 +414,9 @@ config TARGET_HUMMINGBOARD
   config TARGET_TQMA6
bool TQ Systems TQMa6 board
 
  +config TARGET_OT1200
  + bool Bachmann OT1200
  +
   config OMAP34XX
bool OMAP34XX SoC
 
  @@ -577,6 +580,7 @@ source board/atmel/at91sam9rlek/Kconfig
   source board/atmel/at91sam9x5ek/Kconfig
   source board/atmel/sama5d3_xplained/Kconfig
   source board/atmel/sama5d3xek/Kconfig
  +source board/bachmann/ot1200/Kconfig
   source board/balloon3/Kconfig
   source board/barco/titanium/Kconfig
   source board/bluegiga/apx4devkit/Kconfig
  diff --git a/board/bachmann/ot1200/Kconfig b/board/bachmann/ot1200/Kconfig
  new file mode 100644
  index 000..55a825d
  --- /dev/null
  +++ b/board/bachmann/ot1200/Kconfig
  @@ -0,0 +1,23 @@
  +if TARGET_OT1200
  +
  +config SYS_CPU
  + string
  + default armv7
  +
  +config SYS_BOARD
  + string
  + default ot1200
  +
  +config SYS_VENDOR
  + string
  + default bachmann
  +
  +config SYS_SOC
  + string
  + default mx6
  +
  +config SYS_CONFIG_NAME
  + string
  + default ot1200
  +
  +endif
  diff --git a/board/bachmann/ot1200/MAINTAINERS 
  b/board/bachmann/ot1200/MAINTAINERS
  new file mode 100644
  index 000..ad75c24
  --- /dev/null
  +++ b/board/bachmann/ot1200/MAINTAINERS
  @@ -0,0 +1,6 @@
  +BACHMANN ELECTRONIC OT1200 BOARD
  +M:   Christian Gmeiner christian.gmei...@gmail.com
  +S:   Maintained
  +F:   board/bachmann/ot1200
  +F:   include/configs/ot1200.h
  +F:   configs/ot1200*_defconfig
  diff --git a/board/bachmann/ot1200/Makefile b/board/bachmann/ot1200/Makefile
  new file mode 100644
  index 000..1bd42e8
  --- /dev/null
  +++ b/board/bachmann/ot1200/Makefile
  @@ -0,0 +1,9 @@
  +#
  +# Copyright (C) 2012-2013, Guennadi Liakhovetski l...@denx.de
  +# (C) Copyright 2012-2013 Freescale Semiconductor, Inc.
  +# Copyright (C) 2013, Boundary Devices i...@boundarydevices.com
  +#
  +# SPDX-License-Identifier:   GPL-2.0+
  +#
  +
  +obj-y  := ot1200.o
  diff --git a/board/bachmann/ot1200/README b/board/bachmann/ot1200/README
  new file mode 100644
  index 000..efcff11
  --- /dev/null
  +++ b/board/bachmann/ot1200/README
  @@ -0,0 +1,20 @@
  +U-Boot for the Bachmann electronic GmbH OT1200 devices
  +
  +There are two different versions of the base print,

 Do you mean here base board ?

We have two different PCBs .. I think I will go with this working or
even printed circuit boards.
It looks like board will fit the best :)

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] imx6: add Bachmann OT1200 board v2

2014-09-29 Thread Stefano Babic
Hi Christian,

On 22/09/2014 13:57, Christian Gmeiner wrote:
 This patch adds support for the OT1200 series of devices.
 
 Following components are used in u-boot:
 + ethernet
 + i2c
 + emmc
 + gpio
 
 For more details see README.
 
 Changes v1  v2

Can you also version your patches in the subject ? (aka: [PATCH vX]
imx6:...). Rather patchwork makes some mess and it is not able to
follow the versions, numbering helps - thanks !

There are some warnings reported by checkpatch, a couple opf them are
due to line over 80 chars.

Please fix warnings and repost, thanks !

   - make use of enable_cspi_clock(..)
   - fix usage of OUTPUT_40OHM define
   - added README
 
 Signed-off-by: Christian Gmeiner christian.gmei...@gmail.com
 ---
  arch/arm/Kconfig  |   4 +
  board/bachmann/ot1200/Kconfig |  23 
  board/bachmann/ot1200/MAINTAINERS |   6 +
  board/bachmann/ot1200/Makefile|   9 ++
  board/bachmann/ot1200/README  |  20 +++
  board/bachmann/ot1200/ot1200.c| 251 
 ++
  configs/ot1200_defconfig  |   3 +
  include/configs/ot1200.h  | 196 +
  8 files changed, 512 insertions(+)
  create mode 100644 board/bachmann/ot1200/Kconfig
  create mode 100644 board/bachmann/ot1200/MAINTAINERS
  create mode 100644 board/bachmann/ot1200/Makefile
  create mode 100644 board/bachmann/ot1200/README
  create mode 100644 board/bachmann/ot1200/ot1200.c
  create mode 100644 configs/ot1200_defconfig
  create mode 100644 include/configs/ot1200.h
 
 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
 index 106aed9..8face21 100644
 --- a/arch/arm/Kconfig
 +++ b/arch/arm/Kconfig
 @@ -414,6 +414,9 @@ config TARGET_HUMMINGBOARD
  config TARGET_TQMA6
   bool TQ Systems TQMa6 board
  
 +config TARGET_OT1200
 + bool Bachmann OT1200
 +
  config OMAP34XX
   bool OMAP34XX SoC
  
 @@ -577,6 +580,7 @@ source board/atmel/at91sam9rlek/Kconfig
  source board/atmel/at91sam9x5ek/Kconfig
  source board/atmel/sama5d3_xplained/Kconfig
  source board/atmel/sama5d3xek/Kconfig
 +source board/bachmann/ot1200/Kconfig
  source board/balloon3/Kconfig
  source board/barco/titanium/Kconfig
  source board/bluegiga/apx4devkit/Kconfig
 diff --git a/board/bachmann/ot1200/Kconfig b/board/bachmann/ot1200/Kconfig
 new file mode 100644
 index 000..55a825d
 --- /dev/null
 +++ b/board/bachmann/ot1200/Kconfig
 @@ -0,0 +1,23 @@
 +if TARGET_OT1200
 +
 +config SYS_CPU
 + string
 + default armv7
 +
 +config SYS_BOARD
 + string
 + default ot1200
 +
 +config SYS_VENDOR
 + string
 + default bachmann
 +
 +config SYS_SOC
 + string
 + default mx6
 +
 +config SYS_CONFIG_NAME
 + string
 + default ot1200
 +
 +endif
 diff --git a/board/bachmann/ot1200/MAINTAINERS 
 b/board/bachmann/ot1200/MAINTAINERS
 new file mode 100644
 index 000..ad75c24
 --- /dev/null
 +++ b/board/bachmann/ot1200/MAINTAINERS
 @@ -0,0 +1,6 @@
 +BACHMANN ELECTRONIC OT1200 BOARD
 +M:   Christian Gmeiner christian.gmei...@gmail.com
 +S:   Maintained
 +F:   board/bachmann/ot1200
 +F:   include/configs/ot1200.h
 +F:   configs/ot1200*_defconfig
 diff --git a/board/bachmann/ot1200/Makefile b/board/bachmann/ot1200/Makefile
 new file mode 100644
 index 000..1bd42e8
 --- /dev/null
 +++ b/board/bachmann/ot1200/Makefile
 @@ -0,0 +1,9 @@
 +#
 +# Copyright (C) 2012-2013, Guennadi Liakhovetski l...@denx.de
 +# (C) Copyright 2012-2013 Freescale Semiconductor, Inc.
 +# Copyright (C) 2013, Boundary Devices i...@boundarydevices.com
 +#
 +# SPDX-License-Identifier:   GPL-2.0+
 +#
 +
 +obj-y  := ot1200.o
 diff --git a/board/bachmann/ot1200/README b/board/bachmann/ot1200/README
 new file mode 100644
 index 000..efcff11
 --- /dev/null
 +++ b/board/bachmann/ot1200/README
 @@ -0,0 +1,20 @@
 +U-Boot for the Bachmann electronic GmbH OT1200 devices
 +
 +There are two different versions of the base print,

Do you mean here base board ?

 which differ
 +in the way ethernet is done. The variant detection is done during
 +runtime based on the address of the found phy.
 +
 +- mr variant
 +FEC is connected directly to an ethernet switch (KSZ8895). The ethernet
 +port is always up and auto-negotiation is not possible.
 +
 +- normal variant
 +FEC is connected to a normal phy and auto-negotiation is possible.
 +
 +
 +The variant name is part of the dtb file name loaded by u-boot. This
 +make is possible to boot the linux kernel and make use variant specific
 +devicetree (fixed-phy link).
 +
 +In order to support different display resoltuions/sizes the OT1200 devices
 +are making use of EDID data stored in an i2c EEPROM.
 \ No newline at end of file
 diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
 new file mode 100644
 index 000..0d5ede5
 --- /dev/null
 +++ b/board/bachmann/ot1200/ot1200.c
 @@ -0,0 +1,251 @@
 +/*
 + * Copyright (C) 2010-2013 Freescale Semiconductor, Inc.
 + * Copyright (C) 2014, Bachmann electronic GmbH
 + *
 + * 

[U-Boot] [PATCH] imx6: add Bachmann OT1200 board v2

2014-09-22 Thread Christian Gmeiner
This patch adds support for the OT1200 series of devices.

Following components are used in u-boot:
+ ethernet
+ i2c
+ emmc
+ gpio

For more details see README.

Changes v1  v2
  - make use of enable_cspi_clock(..)
  - fix usage of OUTPUT_40OHM define
  - added README

Signed-off-by: Christian Gmeiner christian.gmei...@gmail.com
---
 arch/arm/Kconfig  |   4 +
 board/bachmann/ot1200/Kconfig |  23 
 board/bachmann/ot1200/MAINTAINERS |   6 +
 board/bachmann/ot1200/Makefile|   9 ++
 board/bachmann/ot1200/README  |  20 +++
 board/bachmann/ot1200/ot1200.c| 251 ++
 configs/ot1200_defconfig  |   3 +
 include/configs/ot1200.h  | 196 +
 8 files changed, 512 insertions(+)
 create mode 100644 board/bachmann/ot1200/Kconfig
 create mode 100644 board/bachmann/ot1200/MAINTAINERS
 create mode 100644 board/bachmann/ot1200/Makefile
 create mode 100644 board/bachmann/ot1200/README
 create mode 100644 board/bachmann/ot1200/ot1200.c
 create mode 100644 configs/ot1200_defconfig
 create mode 100644 include/configs/ot1200.h

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 106aed9..8face21 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -414,6 +414,9 @@ config TARGET_HUMMINGBOARD
 config TARGET_TQMA6
bool TQ Systems TQMa6 board
 
+config TARGET_OT1200
+   bool Bachmann OT1200
+
 config OMAP34XX
bool OMAP34XX SoC
 
@@ -577,6 +580,7 @@ source board/atmel/at91sam9rlek/Kconfig
 source board/atmel/at91sam9x5ek/Kconfig
 source board/atmel/sama5d3_xplained/Kconfig
 source board/atmel/sama5d3xek/Kconfig
+source board/bachmann/ot1200/Kconfig
 source board/balloon3/Kconfig
 source board/barco/titanium/Kconfig
 source board/bluegiga/apx4devkit/Kconfig
diff --git a/board/bachmann/ot1200/Kconfig b/board/bachmann/ot1200/Kconfig
new file mode 100644
index 000..55a825d
--- /dev/null
+++ b/board/bachmann/ot1200/Kconfig
@@ -0,0 +1,23 @@
+if TARGET_OT1200
+
+config SYS_CPU
+   string
+   default armv7
+
+config SYS_BOARD
+   string
+   default ot1200
+
+config SYS_VENDOR
+   string
+   default bachmann
+
+config SYS_SOC
+   string
+   default mx6
+
+config SYS_CONFIG_NAME
+   string
+   default ot1200
+
+endif
diff --git a/board/bachmann/ot1200/MAINTAINERS 
b/board/bachmann/ot1200/MAINTAINERS
new file mode 100644
index 000..ad75c24
--- /dev/null
+++ b/board/bachmann/ot1200/MAINTAINERS
@@ -0,0 +1,6 @@
+BACHMANN ELECTRONIC OT1200 BOARD
+M: Christian Gmeiner christian.gmei...@gmail.com
+S: Maintained
+F: board/bachmann/ot1200
+F: include/configs/ot1200.h
+F: configs/ot1200*_defconfig
diff --git a/board/bachmann/ot1200/Makefile b/board/bachmann/ot1200/Makefile
new file mode 100644
index 000..1bd42e8
--- /dev/null
+++ b/board/bachmann/ot1200/Makefile
@@ -0,0 +1,9 @@
+#
+# Copyright (C) 2012-2013, Guennadi Liakhovetski l...@denx.de
+# (C) Copyright 2012-2013 Freescale Semiconductor, Inc.
+# Copyright (C) 2013, Boundary Devices i...@boundarydevices.com
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y  := ot1200.o
diff --git a/board/bachmann/ot1200/README b/board/bachmann/ot1200/README
new file mode 100644
index 000..efcff11
--- /dev/null
+++ b/board/bachmann/ot1200/README
@@ -0,0 +1,20 @@
+U-Boot for the Bachmann electronic GmbH OT1200 devices
+
+There are two different versions of the base print, which differ
+in the way ethernet is done. The variant detection is done during
+runtime based on the address of the found phy.
+
+- mr variant
+FEC is connected directly to an ethernet switch (KSZ8895). The ethernet
+port is always up and auto-negotiation is not possible.
+
+- normal variant
+FEC is connected to a normal phy and auto-negotiation is possible.
+
+
+The variant name is part of the dtb file name loaded by u-boot. This
+make is possible to boot the linux kernel and make use variant specific
+devicetree (fixed-phy link).
+
+In order to support different display resoltuions/sizes the OT1200 devices
+are making use of EDID data stored in an i2c EEPROM.
\ No newline at end of file
diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
new file mode 100644
index 000..0d5ede5
--- /dev/null
+++ b/board/bachmann/ot1200/ot1200.c
@@ -0,0 +1,251 @@
+/*
+ * Copyright (C) 2010-2013 Freescale Semiconductor, Inc.
+ * Copyright (C) 2014, Bachmann electronic GmbH
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include common.h
+#include asm/arch/clock.h
+#include asm/arch/imx-regs.h
+#include asm/arch/iomux.h
+#include malloc.h
+#include asm/arch/mx6-pins.h
+#include asm/imx-common/iomux-v3.h
+#include asm/imx-common/mxc_i2c.h
+#include asm/imx-common/boot_mode.h
+#include asm/arch/crm_regs.h
+#include mmc.h
+#include fsl_esdhc.h
+#include netdev.h
+#include i2c.h
+#include pca953x.h
+#include asm/gpio.h
+#include phy.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define OUTPUT_40OHM