Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support
Now that the device-tree is in linux-next (should land in linux 5.7), > anyone have a chance to take a stab at a v2 of this patch series? I did > a quick-and-dirty attempt, and the TPL/SPL layers worked, but failed to > load the main u-boot/atf binaries (mmc issues, I think). Yes, I got to that conclusion as well and my debug didn't get me far but I've not had time to get back to it.
Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support
On 2019-12-18, Vagrant Cascadian wrote: > On 2019-11-14, Peter Robinson wrote: >> Add initial support for Pinebook Pro laptop. Now that the device-tree is in linux-next (should land in linux 5.7), anyone have a chance to take a stab at a v2 of this patch series? I did a quick-and-dirty attempt, and the TPL/SPL layers worked, but failed to load the main u-boot/atf binaries (mmc issues, I think). live well, vagrant signature.asc Description: PGP signature
Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support
On 2019-11-14, Peter Robinson wrote:
> Add initial support for Pinebook Pro laptop.
>
> Specification
> - Rockchip RK3399
> - 4GB Dual-Channel LPDDR4
> - SD card slot
> - eMMC socket
> - 128Mb SPI Flash
> - PCIe 4X slot
> - AP6256 for WiFi + BT
> - 1920*1080 screen
> - USB 3.0, 2.0
> - USB Type C power and data
> - DC 12V/2A
5V/3A, as already mentioned.
> Signed-off-by: Peter Robinson
> ---
>
> Initial v1 for feedback
Tested on u-boot v2020.01-rc5; applied with trivial adjustments.
Thanks for working on it!
Tested-by: Vagrant Cascadian
live well,
vagrant
> U-Boot TPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33)
> Trying to boot from BOOTROM
> Returning to boot ROM...
>
> U-Boot SPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
> Trying to boot from MMC1
>
>
> U-Boot 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
>
> Model: Pine64 Pinebook Pro
> DRAM: 3.9 GiB
> PMIC: RK808
> MMC: dwmmc@fe32: 1, sdhci@fe33: 0
> In:serial@ff1a
> Out: serial@ff1a
> Err: serial@ff1a
> Model: Pine64 Pinebook Pro
> ## Error: Can't overwrite "serial#"
> ## Error inserting "serial#" variable, errno=1
> rockchip_dnl_key_pressed: adc_channel_single_shot fail!
> Net: No ethernet found.
> Hit any key to stop autoboot: 0
> =>
>
>
> arch/arm/dts/Makefile | 1 +
> arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 25 +
> arch/arm/dts/rk3399-pinebook-pro.dts | 631 ++
> arch/arm/mach-rockchip/rk3399/Kconfig | 8 +
> board/pine64/pinebook_pro_rk3399/Kconfig | 15 +
> board/pine64/pinebook_pro_rk3399/MAINTAINERS | 8 +
> board/pine64/pinebook_pro_rk3399/Makefile | 1 +
> .../pinebook_pro_rk3399/pinebook-pro-rk3399.c | 192 ++
> configs/pinebook_pro-rk3399_defconfig | 76 +++
> include/configs/pinebook_pro_rk3399.h | 29 +
> 10 files changed, 986 insertions(+)
> create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> create mode 100644 arch/arm/dts/rk3399-pinebook-pro.dts
> create mode 100644 board/pine64/pinebook_pro_rk3399/Kconfig
> create mode 100644 board/pine64/pinebook_pro_rk3399/MAINTAINERS
> create mode 100644 board/pine64/pinebook_pro_rk3399/Makefile
> create mode 100644 board/pine64/pinebook_pro_rk3399/pinebook-pro-rk3399.c
> create mode 100644 configs/pinebook_pro-rk3399_defconfig
> create mode 100644 include/configs/pinebook_pro_rk3399.h
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 5a64fcc5a7..affedfd666 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -116,6 +116,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
> rk3399-nanopi-m4.dtb \
> rk3399-nanopi-neo4.dtb \
> rk3399-orangepi.dtb \
> + rk3399-pinebook-pro.dtb \
> rk3399-puma-ddr1333.dtb \
> rk3399-puma-ddr1600.dtb \
> rk3399-puma-ddr1866.dtb \
> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> new file mode 100644
> index 00..9b0cb7010f
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Peter Robinson
> + */
> +
> +#include "rk3399-u-boot.dtsi"
> +#include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + chosen {
> + u-boot,spl-boot-order = "same-as-spl", ,
> + };
> +};
> +
> + {
> + u-boot,dm-pre-reloc;
> +};
> +
> + {
> +u-boot,dm-pre-reloc;
> +};
> +
> + {
> +u-boot,dm-pre-reloc;
> +};
> diff --git a/arch/arm/dts/rk3399-pinebook-pro.dts
> b/arch/arm/dts/rk3399-pinebook-pro.dts
> new file mode 100644
> index 00..85ce0206d7
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro.dts
> @@ -0,0 +1,631 @@
> +/*
> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +/dts-v1/;
> +#include
> +#include
> +#include
> +#include "rk3399.dtsi"
> +#include "rk3399-opp.dtsi"
> +
> +/ {
> + model = "Pine64 Pinebook Pro";
> + compatible = "pine64,pinebook-pro", "rockchip,rk3399";
> +
> + chosen {
> + stdout-path =
> + };
> +
> + aliases {
> + spi0 =
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + enable-gpios = < RK_PA0 GPIO_ACTIVE_HIGH>;
> + pwms = < 0 740740 0>;
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + autorepeat;
> + pinctrl-names = "default";
> + pinctrl-0 = <>;
> +
> + power {
> + debounce-interval = <100>;
> + gpios = < RK_PA5 GPIO_ACTIVE_LOW>;
> + label = "GPIO Key Power";
> + linux,code = ;
> + wakeup-source;
> + };
> + };
> +
> + leds {
> + status = "okay";
> +
Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support
On Wed, Nov 13, 2019 at 4:51 PM Peter Robinson wrote:
>
> Add initial support for Pinebook Pro laptop.
Hi Peter,
> Specification
> - Rockchip RK3399
> - 4GB Dual-Channel LPDDR4
> - SD card slot
> - eMMC socket
> - 128Mb SPI Flash
> - PCIe 4X slot
> - AP6256 for WiFi + BT
> - 1920*1080 screen
> - USB 3.0, 2.0
> - USB Type C power and data
> - DC 12V/2A
It's 5V/3A, see schematics
>
> Signed-off-by: Peter Robinson
> ---
>
> Initial v1 for feedback
>
> U-Boot TPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33)
> Trying to boot from BOOTROM
> Returning to boot ROM...
>
> U-Boot SPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
> Trying to boot from MMC1
>
>
> U-Boot 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
>
> Model: Pine64 Pinebook Pro
> DRAM: 3.9 GiB
> PMIC: RK808
> MMC: dwmmc@fe32: 1, sdhci@fe33: 0
> In:serial@ff1a
> Out: serial@ff1a
> Err: serial@ff1a
> Model: Pine64 Pinebook Pro
> ## Error: Can't overwrite "serial#"
> ## Error inserting "serial#" variable, errno=1
That doesn't look right to me
> rockchip_dnl_key_pressed: adc_channel_single_shot fail!
> Net: No ethernet found.
> Hit any key to stop autoboot: 0
> =>
>
>
> arch/arm/dts/Makefile | 1 +
> arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 25 +
> arch/arm/dts/rk3399-pinebook-pro.dts | 631 ++
> arch/arm/mach-rockchip/rk3399/Kconfig | 8 +
> board/pine64/pinebook_pro_rk3399/Kconfig | 15 +
> board/pine64/pinebook_pro_rk3399/MAINTAINERS | 8 +
> board/pine64/pinebook_pro_rk3399/Makefile | 1 +
> .../pinebook_pro_rk3399/pinebook-pro-rk3399.c | 192 ++
> configs/pinebook_pro-rk3399_defconfig | 76 +++
> include/configs/pinebook_pro_rk3399.h | 29 +
> 10 files changed, 986 insertions(+)
> create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> create mode 100644 arch/arm/dts/rk3399-pinebook-pro.dts
> create mode 100644 board/pine64/pinebook_pro_rk3399/Kconfig
> create mode 100644 board/pine64/pinebook_pro_rk3399/MAINTAINERS
> create mode 100644 board/pine64/pinebook_pro_rk3399/Makefile
> create mode 100644 board/pine64/pinebook_pro_rk3399/pinebook-pro-rk3399.c
> create mode 100644 configs/pinebook_pro-rk3399_defconfig
> create mode 100644 include/configs/pinebook_pro_rk3399.h
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 5a64fcc5a7..affedfd666 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -116,6 +116,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
> rk3399-nanopi-m4.dtb \
> rk3399-nanopi-neo4.dtb \
> rk3399-orangepi.dtb \
> + rk3399-pinebook-pro.dtb \
> rk3399-puma-ddr1333.dtb \
> rk3399-puma-ddr1600.dtb \
> rk3399-puma-ddr1866.dtb \
> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> new file mode 100644
> index 00..9b0cb7010f
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Peter Robinson
> + */
> +
> +#include "rk3399-u-boot.dtsi"
> +#include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + chosen {
> + u-boot,spl-boot-order = "same-as-spl", ,
> + };
> +};
> +
> + {
> + u-boot,dm-pre-reloc;
> +};
> +
> + {
> +u-boot,dm-pre-reloc;
> +};
> +
> + {
> +u-boot,dm-pre-reloc;
> +};
> diff --git a/arch/arm/dts/rk3399-pinebook-pro.dts
> b/arch/arm/dts/rk3399-pinebook-pro.dts
> new file mode 100644
> index 00..85ce0206d7
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro.dts
You have to submit this DTS into linux first and then sync linux dts to u-boot.
> @@ -0,0 +1,631 @@
> +/*
> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +/dts-v1/;
> +#include
> +#include
> +#include
> +#include "rk3399.dtsi"
> +#include "rk3399-opp.dtsi"
> +
> +/ {
> + model = "Pine64 Pinebook Pro";
> + compatible = "pine64,pinebook-pro", "rockchip,rk3399";
> +
> + chosen {
> + stdout-path =
> + };
> +
> + aliases {
> + spi0 =
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + enable-gpios = < RK_PA0 GPIO_ACTIVE_HIGH>;
> + pwms = < 0 740740 0>;
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + autorepeat;
> + pinctrl-names = "default";
> + pinctrl-0 = <>;
> +
> + power {
> + debounce-interval = <100>;
> + gpios = < RK_PA5 GPIO_ACTIVE_LOW>;
> + label = "GPIO Key Power";
> + linux,code = ;
> + wakeup-source;
> + };
> + };
Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support
Hi Peter,
Thanks for your patch for pinebook pro support. see comments below.
On 2019/11/14 上午8:51, Peter Robinson wrote:
Add initial support for Pinebook Pro laptop.
Specification
- Rockchip RK3399
- 4GB Dual-Channel LPDDR4
- SD card slot
- eMMC socket
- 128Mb SPI Flash
- PCIe 4X slot
- AP6256 for WiFi + BT
- 1920*1080 screen
- USB 3.0, 2.0
- USB Type C power and data
- DC 12V/2A
Signed-off-by: Peter Robinson
---
Initial v1 for feedback
U-Boot TPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33)
Trying to boot from BOOTROM
Returning to boot ROM...
U-Boot SPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
Trying to boot from MMC1
U-Boot 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
Model: Pine64 Pinebook Pro
DRAM: 3.9 GiB
PMIC: RK808
MMC: dwmmc@fe32: 1, sdhci@fe33: 0
In:serial@ff1a
Out: serial@ff1a
Err: serial@ff1a
Model: Pine64 Pinebook Pro
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1
rockchip_dnl_key_pressed: adc_channel_single_shot fail!
Net: No ethernet found.
Hit any key to stop autoboot: 0
=>
arch/arm/dts/Makefile | 1 +
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 25 +
arch/arm/dts/rk3399-pinebook-pro.dts | 631 ++
Does this dts sync from upstream kernel, if yes, please split it as a
separate patch and
comment which commit do you sync from.
arch/arm/mach-rockchip/rk3399/Kconfig | 8 +
board/pine64/pinebook_pro_rk3399/Kconfig | 15 +
board/pine64/pinebook_pro_rk3399/MAINTAINERS | 8 +
board/pine64/pinebook_pro_rk3399/Makefile | 1 +
.../pinebook_pro_rk3399/pinebook-pro-rk3399.c | 192 ++
configs/pinebook_pro-rk3399_defconfig | 76 +++
Could you use "pinebook-pro-rk3399_defconfig" instead?
Other source code looks good to me.
Thanks,
- Kever
include/configs/pinebook_pro_rk3399.h | 29 +
10 files changed, 986 insertions(+)
create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3399-pinebook-pro.dts
create mode 100644 board/pine64/pinebook_pro_rk3399/Kconfig
create mode 100644 board/pine64/pinebook_pro_rk3399/MAINTAINERS
create mode 100644 board/pine64/pinebook_pro_rk3399/Makefile
create mode 100644 board/pine64/pinebook_pro_rk3399/pinebook-pro-rk3399.c
create mode 100644 configs/pinebook_pro-rk3399_defconfig
create mode 100644 include/configs/pinebook_pro_rk3399.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 5a64fcc5a7..affedfd666 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -116,6 +116,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
rk3399-nanopi-m4.dtb \
rk3399-nanopi-neo4.dtb \
rk3399-orangepi.dtb \
+ rk3399-pinebook-pro.dtb \
rk3399-puma-ddr1333.dtb \
rk3399-puma-ddr1600.dtb \
rk3399-puma-ddr1866.dtb \
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
new file mode 100644
index 00..9b0cb7010f
--- /dev/null
+++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Peter Robinson
+ */
+
+#include "rk3399-u-boot.dtsi"
+#include "rk3399-sdram-lpddr4-100.dtsi"
+
+/ {
+ chosen {
+ u-boot,spl-boot-order = "same-as-spl", ,
+ };
+};
+
+ {
+ u-boot,dm-pre-reloc;
+};
+
+ {
+u-boot,dm-pre-reloc;
+};
+
+ {
+u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/dts/rk3399-pinebook-pro.dts
b/arch/arm/dts/rk3399-pinebook-pro.dts
new file mode 100644
index 00..85ce0206d7
--- /dev/null
+++ b/arch/arm/dts/rk3399-pinebook-pro.dts
@@ -0,0 +1,631 @@
+/*
+ * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+/dts-v1/;
+#include
+#include
+#include
+#include "rk3399.dtsi"
+#include "rk3399-opp.dtsi"
+
+/ {
+ model = "Pine64 Pinebook Pro";
+ compatible = "pine64,pinebook-pro", "rockchip,rk3399";
+
+ chosen {
+ stdout-path =
+ };
+
+ aliases {
+ spi0 =
+ };
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ enable-gpios = < RK_PA0 GPIO_ACTIVE_HIGH>;
+ pwms = < 0 740740 0>;
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+ pinctrl-names = "default";
+ pinctrl-0 = <>;
+
+ power {
+ debounce-interval = <100>;
+ gpios = < RK_PA5 GPIO_ACTIVE_LOW>;
+ label = "GPIO Key Power";
+ linux,code = ;
+ wakeup-source;
+ };
+ };
+
+ leds {
+ status = "okay";
+ compatible = "gpio-leds";
+
+ work-led {
+
[U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support
Add initial support for Pinebook Pro laptop.
Specification
- Rockchip RK3399
- 4GB Dual-Channel LPDDR4
- SD card slot
- eMMC socket
- 128Mb SPI Flash
- PCIe 4X slot
- AP6256 for WiFi + BT
- 1920*1080 screen
- USB 3.0, 2.0
- USB Type C power and data
- DC 12V/2A
Signed-off-by: Peter Robinson
---
Initial v1 for feedback
U-Boot TPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33)
Trying to boot from BOOTROM
Returning to boot ROM...
U-Boot SPL 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
Trying to boot from MMC1
U-Boot 2020.01-rc2-5-g7d87be0ff5 (Nov 14 2019 - 00:27:33 +)
Model: Pine64 Pinebook Pro
DRAM: 3.9 GiB
PMIC: RK808
MMC: dwmmc@fe32: 1, sdhci@fe33: 0
In:serial@ff1a
Out: serial@ff1a
Err: serial@ff1a
Model: Pine64 Pinebook Pro
## Error: Can't overwrite "serial#"
## Error inserting "serial#" variable, errno=1
rockchip_dnl_key_pressed: adc_channel_single_shot fail!
Net: No ethernet found.
Hit any key to stop autoboot: 0
=>
arch/arm/dts/Makefile | 1 +
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 25 +
arch/arm/dts/rk3399-pinebook-pro.dts | 631 ++
arch/arm/mach-rockchip/rk3399/Kconfig | 8 +
board/pine64/pinebook_pro_rk3399/Kconfig | 15 +
board/pine64/pinebook_pro_rk3399/MAINTAINERS | 8 +
board/pine64/pinebook_pro_rk3399/Makefile | 1 +
.../pinebook_pro_rk3399/pinebook-pro-rk3399.c | 192 ++
configs/pinebook_pro-rk3399_defconfig | 76 +++
include/configs/pinebook_pro_rk3399.h | 29 +
10 files changed, 986 insertions(+)
create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3399-pinebook-pro.dts
create mode 100644 board/pine64/pinebook_pro_rk3399/Kconfig
create mode 100644 board/pine64/pinebook_pro_rk3399/MAINTAINERS
create mode 100644 board/pine64/pinebook_pro_rk3399/Makefile
create mode 100644 board/pine64/pinebook_pro_rk3399/pinebook-pro-rk3399.c
create mode 100644 configs/pinebook_pro-rk3399_defconfig
create mode 100644 include/configs/pinebook_pro_rk3399.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 5a64fcc5a7..affedfd666 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -116,6 +116,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
rk3399-nanopi-m4.dtb \
rk3399-nanopi-neo4.dtb \
rk3399-orangepi.dtb \
+ rk3399-pinebook-pro.dtb \
rk3399-puma-ddr1333.dtb \
rk3399-puma-ddr1600.dtb \
rk3399-puma-ddr1866.dtb \
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
new file mode 100644
index 00..9b0cb7010f
--- /dev/null
+++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Peter Robinson
+ */
+
+#include "rk3399-u-boot.dtsi"
+#include "rk3399-sdram-lpddr4-100.dtsi"
+
+/ {
+ chosen {
+ u-boot,spl-boot-order = "same-as-spl", ,
+ };
+};
+
+ {
+ u-boot,dm-pre-reloc;
+};
+
+ {
+u-boot,dm-pre-reloc;
+};
+
+ {
+u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/dts/rk3399-pinebook-pro.dts
b/arch/arm/dts/rk3399-pinebook-pro.dts
new file mode 100644
index 00..85ce0206d7
--- /dev/null
+++ b/arch/arm/dts/rk3399-pinebook-pro.dts
@@ -0,0 +1,631 @@
+/*
+ * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+/dts-v1/;
+#include
+#include
+#include
+#include "rk3399.dtsi"
+#include "rk3399-opp.dtsi"
+
+/ {
+ model = "Pine64 Pinebook Pro";
+ compatible = "pine64,pinebook-pro", "rockchip,rk3399";
+
+ chosen {
+ stdout-path =
+ };
+
+ aliases {
+ spi0 =
+ };
+
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ enable-gpios = < RK_PA0 GPIO_ACTIVE_HIGH>;
+ pwms = < 0 740740 0>;
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+ pinctrl-names = "default";
+ pinctrl-0 = <>;
+
+ power {
+ debounce-interval = <100>;
+ gpios = < RK_PA5 GPIO_ACTIVE_LOW>;
+ label = "GPIO Key Power";
+ linux,code = ;
+ wakeup-source;
+ };
+ };
+
+ leds {
+ status = "okay";
+ compatible = "gpio-leds";
+
+ work-led {
+ label = "work";
+ gpios = < RK_PB3 GPIO_ACTIVE_HIGH>;
+ };
+
+ standby-led {
+ label = "standby";
+ gpios = < RK_PA2 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ clocks = <
