Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hi Przemyslaw, On 12 September 2014 02:39, Przemyslaw Marczak wrote: > > Hello Simon, > > > On 09/09/2014 12:31 PM, Przemyslaw Marczak wrote: >> >> Hi, >> >> I will test this patch set on a trats2 board - today evening. >> >> On 09/09/2014 08:05 AM, Simon Glass wrote: >>> >>> Hi Minkyu, >>> >>> On 25 July 2014 08:43, Simon Glass wrote: >>> Hi Lucasz, On 24 July 2014 09:34, Lukasz Majewski wrote: > > Hi Simon, > >> This series tries to unify the Samsung board configs into a few header >> files for exynos5 and exynos5. >> >> The purpose is to make it easier to move to driver model. In that case >> I would like things like the GPIO drivers and serial drivers to work >> in a standard way, and not need to support device tree and platform >> data at the same time. That would be quite painful. >> >> Another reason is that the Chrome OS EC drivers are currently >> included in boards that don't have a Chrome OS EC. This concern was >> raised by the Samsung maintainer (Minkyu) a while back. >> >> There are still a few boards that don't use CONFIG_OF_CONTROL so I >> have updated these with the most rudimentary of device tree files. >> >> Unfortunately I don't have boards for most of these (for testing) and >> I am hoping that the maintainers can come to the rescue and fix up any >> patches that have problems. I am also worried that I have used a >> common exynos file for things like smdkv310, when in fact they have >> some other chip in common. >> >> So maintainers, please can you test this and re-issue the patch, or >> make comments on my attempts? > > > We will do our best to test our Exynos4 based boards. Thanks - please feel free to re-issue the patches and I will drop mine (if you cc me). >>> >>> Can you please review this series? We are already at rc2. >>> >>> Regards, >>> Simon >>> >>> >>> >>> ___ >>> U-Boot mailing list >>> U-Boot@lists.denx.de >>> http://lists.denx.de/mailman/listinfo/u-boot >>> >> >> Best regards, > > > It works fine on trats2. > I'm currently working on PMIC framework at the top of your u-boot-dm/working > branch and it also works fine on Trats2. OK good, thanks for testing. I'll go through the feedback and see if I can give the patches another spin. It would be great if we can get exynos DM support in mainline for the upcoming release. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hello Simon, On 09/09/2014 12:31 PM, Przemyslaw Marczak wrote: Hi, I will test this patch set on a trats2 board - today evening. On 09/09/2014 08:05 AM, Simon Glass wrote: Hi Minkyu, On 25 July 2014 08:43, Simon Glass wrote: Hi Lucasz, On 24 July 2014 09:34, Lukasz Majewski wrote: Hi Simon, This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos5. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these with the most rudimentary of device tree files. Unfortunately I don't have boards for most of these (for testing) and I am hoping that the maintainers can come to the rescue and fix up any patches that have problems. I am also worried that I have used a common exynos file for things like smdkv310, when in fact they have some other chip in common. So maintainers, please can you test this and re-issue the patch, or make comments on my attempts? We will do our best to test our Exynos4 based boards. Thanks - please feel free to re-issue the patches and I will drop mine (if you cc me). Can you please review this series? We are already at rc2. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot Best regards, It works fine on trats2. I'm currently working on PMIC framework at the top of your u-boot-dm/working branch and it also works fine on Trats2. Best regards -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hi, I will test this patch set on a trats2 board - today evening. On 09/09/2014 08:05 AM, Simon Glass wrote: Hi Minkyu, On 25 July 2014 08:43, Simon Glass wrote: Hi Lucasz, On 24 July 2014 09:34, Lukasz Majewski wrote: Hi Simon, This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos5. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these with the most rudimentary of device tree files. Unfortunately I don't have boards for most of these (for testing) and I am hoping that the maintainers can come to the rescue and fix up any patches that have problems. I am also worried that I have used a common exynos file for things like smdkv310, when in fact they have some other chip in common. So maintainers, please can you test this and re-issue the patch, or make comments on my attempts? We will do our best to test our Exynos4 based boards. Thanks - please feel free to re-issue the patches and I will drop mine (if you cc me). Can you please review this series? We are already at rc2. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hi Minkyu, On 25 July 2014 08:43, Simon Glass wrote: > Hi Lucasz, > > On 24 July 2014 09:34, Lukasz Majewski wrote: > > Hi Simon, > > > >> This series tries to unify the Samsung board configs into a few header > >> files for exynos5 and exynos5. > >> > >> The purpose is to make it easier to move to driver model. In that case > >> I would like things like the GPIO drivers and serial drivers to work > >> in a standard way, and not need to support device tree and platform > >> data at the same time. That would be quite painful. > >> > >> Another reason is that the Chrome OS EC drivers are currently > >> included in boards that don't have a Chrome OS EC. This concern was > >> raised by the Samsung maintainer (Minkyu) a while back. > >> > >> There are still a few boards that don't use CONFIG_OF_CONTROL so I > >> have updated these with the most rudimentary of device tree files. > >> > >> Unfortunately I don't have boards for most of these (for testing) and > >> I am hoping that the maintainers can come to the rescue and fix up any > >> patches that have problems. I am also worried that I have used a > >> common exynos file for things like smdkv310, when in fact they have > >> some other chip in common. > >> > >> So maintainers, please can you test this and re-issue the patch, or > >> make comments on my attempts? > > > > We will do our best to test our Exynos4 based boards. > > Thanks - please feel free to re-issue the patches and I will drop mine > (if you cc me). > Can you please review this series? We are already at rc2. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hi Lucasz, On 24 July 2014 09:34, Lukasz Majewski wrote: > Hi Simon, > >> This series tries to unify the Samsung board configs into a few header >> files for exynos5 and exynos5. >> >> The purpose is to make it easier to move to driver model. In that case >> I would like things like the GPIO drivers and serial drivers to work >> in a standard way, and not need to support device tree and platform >> data at the same time. That would be quite painful. >> >> Another reason is that the Chrome OS EC drivers are currently >> included in boards that don't have a Chrome OS EC. This concern was >> raised by the Samsung maintainer (Minkyu) a while back. >> >> There are still a few boards that don't use CONFIG_OF_CONTROL so I >> have updated these with the most rudimentary of device tree files. >> >> Unfortunately I don't have boards for most of these (for testing) and >> I am hoping that the maintainers can come to the rescue and fix up any >> patches that have problems. I am also worried that I have used a >> common exynos file for things like smdkv310, when in fact they have >> some other chip in common. >> >> So maintainers, please can you test this and re-issue the patch, or >> make comments on my attempts? > > We will do our best to test our Exynos4 based boards. Thanks - please feel free to re-issue the patches and I will drop mine (if you cc me). Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hi Simon,
> This series tries to unify the Samsung board configs into a few header
> files for exynos5 and exynos5.
>
> The purpose is to make it easier to move to driver model. In that case
> I would like things like the GPIO drivers and serial drivers to work
> in a standard way, and not need to support device tree and platform
> data at the same time. That would be quite painful.
>
> Another reason is that the Chrome OS EC drivers are currently
> included in boards that don't have a Chrome OS EC. This concern was
> raised by the Samsung maintainer (Minkyu) a while back.
>
> There are still a few boards that don't use CONFIG_OF_CONTROL so I
> have updated these with the most rudimentary of device tree files.
>
> Unfortunately I don't have boards for most of these (for testing) and
> I am hoping that the maintainers can come to the rescue and fix up any
> patches that have problems. I am also worried that I have used a
> common exynos file for things like smdkv310, when in fact they have
> some other chip in common.
>
> So maintainers, please can you test this and re-issue the patch, or
> make comments on my attempts?
We will do our best to test our Exynos4 based boards.
>
>
> Simon Glass (8):
> exynos: Rename -dt config files to -common
> exynos: Move common exynos settings into a common file
> exynos: Move common smdk5420 things to common file
> exynos: config: Move cros_ec and tps65090 out of smdk boards
> config: Move arndale to use common exynos5250 file
> config: Move smdkv310 to use common exynos4 file
> samsung: Move s5p_goni to use exynos-common config
> samsung: Move smdkc100 to use exynos-common config
>
> arch/arm/dts/Makefile | 3 +
> arch/arm/dts/exynos4210-smdkv310.dts | 21 ++
> arch/arm/dts/s5pc1xx-goni.dts | 21 ++
> arch/arm/dts/s5pc1xx-smdkc100.dts | 21 ++
> arch/arm/include/asm/arch-s5pc1xx/periph.h | 61 ++
> arch/arm/include/asm/arch-s5pc1xx/pinmux.h | 50 +
> drivers/mmc/s5p_sdhci.c| 2 -
> include/configs/arndale.h | 212
> ++--- include/configs/{exynos4-dt.h =>
> exynos-common.h} | 104 +++---
> include/configs/exynos4-common.h | 64 +++
> include/configs/{exynos5-dt.h => exynos5-common.h} | 110 ++-
> include/configs/exynos5-dt-common.h| 35
> .../{exynos5250-dt.h => exynos5250-common.h} | 5
> +- .../configs/{exynos5420.h => exynos5420-common.h} | 11 +-
> include/configs/origen.h | 5 +-
> include/configs/peach-pit.h| 8 +-
> include/configs/s5p_goni.h | 55 +-
> include/configs/s5pc210_universal.h| 5 +-
> include/configs/smdk5250.h | 6 +-
> include/configs/smdk5420.h | 7 +-
> include/configs/smdkc100.h | 57 ++
> include/configs/smdkv310.h | 65 ++-
> include/configs/snow.h | 8 +-
> include/configs/trats.h| 6 +-
> include/configs/trats2.h | 6 +- 25 files
> changed, 390 insertions(+), 558 deletions(-) create mode 100644
> arch/arm/dts/exynos4210-smdkv310.dts create mode 100644
> arch/arm/dts/s5pc1xx-goni.dts create mode 100644
> arch/arm/dts/s5pc1xx-smdkc100.dts create mode 100644
> arch/arm/include/asm/arch-s5pc1xx/periph.h create mode 100644
> arch/arm/include/asm/arch-s5pc1xx/pinmux.h rename
> include/configs/{exynos4-dt.h => exynos-common.h} (54%) create mode
> 100644 include/configs/exynos4-common.h rename
> include/configs/{exynos5-dt.h => exynos5-common.h} (70%) create mode
> 100644 include/configs/exynos5-dt-common.h rename
> include/configs/{exynos5250-dt.h => exynos5250-common.h} (92%) rename
> include/configs/{exynos5420.h => exynos5420-common.h} (88%)
>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
This series tries to unify the Samsung board configs into a few header
files for exynos5 and exynos5.
The purpose is to make it easier to move to driver model. In that case
I would like things like the GPIO drivers and serial drivers to work in
a standard way, and not need to support device tree and platform data at
the same time. That would be quite painful.
Another reason is that the Chrome OS EC drivers are currently included in
boards that don't have a Chrome OS EC. This concern was raised by the
Samsung maintainer (Minkyu) a while back.
There are still a few boards that don't use CONFIG_OF_CONTROL so I have
updated these with the most rudimentary of device tree files.
Unfortunately I don't have boards for most of these (for testing) and I
am hoping that the maintainers can come to the rescue and fix up any
patches that have problems. I am also worried that I have used a common
exynos file for things like smdkv310, when in fact they have some other
chip in common.
So maintainers, please can you test this and re-issue the patch, or make
comments on my attempts?
Simon Glass (8):
exynos: Rename -dt config files to -common
exynos: Move common exynos settings into a common file
exynos: Move common smdk5420 things to common file
exynos: config: Move cros_ec and tps65090 out of smdk boards
config: Move arndale to use common exynos5250 file
config: Move smdkv310 to use common exynos4 file
samsung: Move s5p_goni to use exynos-common config
samsung: Move smdkc100 to use exynos-common config
arch/arm/dts/Makefile | 3 +
arch/arm/dts/exynos4210-smdkv310.dts | 21 ++
arch/arm/dts/s5pc1xx-goni.dts | 21 ++
arch/arm/dts/s5pc1xx-smdkc100.dts | 21 ++
arch/arm/include/asm/arch-s5pc1xx/periph.h | 61 ++
arch/arm/include/asm/arch-s5pc1xx/pinmux.h | 50 +
drivers/mmc/s5p_sdhci.c| 2 -
include/configs/arndale.h | 212 ++---
include/configs/{exynos4-dt.h => exynos-common.h} | 104 +++---
include/configs/exynos4-common.h | 64 +++
include/configs/{exynos5-dt.h => exynos5-common.h} | 110 ++-
include/configs/exynos5-dt-common.h| 35
.../{exynos5250-dt.h => exynos5250-common.h} | 5 +-
.../configs/{exynos5420.h => exynos5420-common.h} | 11 +-
include/configs/origen.h | 5 +-
include/configs/peach-pit.h| 8 +-
include/configs/s5p_goni.h | 55 +-
include/configs/s5pc210_universal.h| 5 +-
include/configs/smdk5250.h | 6 +-
include/configs/smdk5420.h | 7 +-
include/configs/smdkc100.h | 57 ++
include/configs/smdkv310.h | 65 ++-
include/configs/snow.h | 8 +-
include/configs/trats.h| 6 +-
include/configs/trats2.h | 6 +-
25 files changed, 390 insertions(+), 558 deletions(-)
create mode 100644 arch/arm/dts/exynos4210-smdkv310.dts
create mode 100644 arch/arm/dts/s5pc1xx-goni.dts
create mode 100644 arch/arm/dts/s5pc1xx-smdkc100.dts
create mode 100644 arch/arm/include/asm/arch-s5pc1xx/periph.h
create mode 100644 arch/arm/include/asm/arch-s5pc1xx/pinmux.h
rename include/configs/{exynos4-dt.h => exynos-common.h} (54%)
create mode 100644 include/configs/exynos4-common.h
rename include/configs/{exynos5-dt.h => exynos5-common.h} (70%)
create mode 100644 include/configs/exynos5-dt-common.h
rename include/configs/{exynos5250-dt.h => exynos5250-common.h} (92%)
rename include/configs/{exynos5420.h => exynos5420-common.h} (88%)
--
2.0.0.526.g5318336
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
