Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds
On Jul 14, 2010, at 4:00 PM, Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <4203e0db-91ec-4311-8c52-7ec48f570...@kernel.crashing.org> you > wrote: >> >>> NAK. Please do not add dead code. >>> >>> Please re-submit when you really add code here. >>> >>> Best regards, >>> >>> Wolfgang Denk >> >> Do you want me to just merge w/the patch that does add code here? > > Yes, squash these two commits (sorry, I saw the secont patch only > after sending the message). ok > BTW: it makes sense to wait a couple of days for reviews. I posted this on Jun 10th. Seems like a month is a few days ;) - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds
Dear Kumar Gala, In message <4203e0db-91ec-4311-8c52-7ec48f570...@kernel.crashing.org> you wrote: > > > NAK. Please do not add dead code. > > > > Please re-submit when you really add code here. > > > > Best regards, > > > > Wolfgang Denk > > Do you want me to just merge w/the patch that does add code here? Yes, squash these two commits (sorry, I saw the secont patch only after sending the message). BTW: it makes sense to wait a couple of days for reviews. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Ada is PL/I trying to be Smalltalk. - Codoso diBlini ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds
On Jul 14, 2010, at 2:29 PM, Wolfgang Denk wrote:
> Dear Kumar Gala,
>
> In message <1276143535-22532-1-git-send-email-ga...@kernel.crashing.org> you
> wrote:
>> Add 'errata' command to report what errata we workaround
>>
>> Signed-off-by: Kumar Gala
>> ---
>> arch/powerpc/cpu/mpc85xx/Makefile |1 +
>> arch/powerpc/cpu/mpc85xx/cmd_errata.c | 35
>> +
>> 2 files changed, 36 insertions(+), 0 deletions(-)
>> create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_errata.c
> ...
>> +static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>> +{
>> +return 0;
>> +}
>
> NAK. Please do not add dead code.
>
> Please re-submit when you really add code here.
>
> Best regards,
>
> Wolfgang Denk
Do you want me to just merge w/the patch that does add code here?
- k
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds
Dear Kumar Gala,
In message <1276143535-22532-1-git-send-email-ga...@kernel.crashing.org> you
wrote:
> Add 'errata' command to report what errata we workaround
>
> Signed-off-by: Kumar Gala
> ---
> arch/powerpc/cpu/mpc85xx/Makefile |1 +
> arch/powerpc/cpu/mpc85xx/cmd_errata.c | 35
> +
> 2 files changed, 36 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_errata.c
...
> +static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +{
> + return 0;
> +}
NAK. Please do not add dead code.
Please re-submit when you really add code here.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Time is fluid ... like a river with currents, eddies, backwash.
-- Spock, "The City on the Edge of Forever", stardate 3134.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds
On Jun 9, 2010, at 11:18 PM, Kumar Gala wrote: > Add 'errata' command to report what errata we workaround > > Signed-off-by: Kumar Gala > --- > arch/powerpc/cpu/mpc85xx/Makefile |1 + > arch/powerpc/cpu/mpc85xx/cmd_errata.c | 35 + > 2 files changed, 36 insertions(+), 0 deletions(-) > create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_errata.c applied to 85xx - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] powerpc/85xx: Add command to report errata workarounds
Add 'errata' command to report what errata we workaround
Signed-off-by: Kumar Gala
---
arch/powerpc/cpu/mpc85xx/Makefile |1 +
arch/powerpc/cpu/mpc85xx/cmd_errata.c | 35 +
2 files changed, 36 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_errata.c
diff --git a/arch/powerpc/cpu/mpc85xx/Makefile
b/arch/powerpc/cpu/mpc85xx/Makefile
index f064fee..e3746e6 100644
--- a/arch/powerpc/cpu/mpc85xx/Makefile
+++ b/arch/powerpc/cpu/mpc85xx/Makefile
@@ -32,6 +32,7 @@ START = start.o resetvec.o
SOBJS-$(CONFIG_MP) += release.o
SOBJS = $(SOBJS-y)
+COBJS-$(CONFIG_CMD_ERRATA) += cmd_errata.o
COBJS-$(CONFIG_CPM2) += commproc.o
# supports ddr1
diff --git a/arch/powerpc/cpu/mpc85xx/cmd_errata.c
b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
new file mode 100644
index 000..6824ebf
--- /dev/null
+++ b/arch/powerpc/cpu/mpc85xx/cmd_errata.c
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2010 Freescale Semiconductor, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include
+#include
+
+static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+ return 0;
+}
+
+U_BOOT_CMD(
+ errata, 1, 0, do_errata,
+ "Report errata workarounds",
+ ""
+);
--
1.6.0.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
