On Jul 14, 2010, at 2:29 PM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <1276143535-22532-1-git-send-email-ga...@kernel.crashing.org> you 
> wrote:
>> Add 'errata' command to report what errata we workaround
>> 
>> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org>
>> ---
>> arch/powerpc/cpu/mpc85xx/Makefile     |    1 +
>> arch/powerpc/cpu/mpc85xx/cmd_errata.c |   35 
>> +++++++++++++++++++++++++++++++++
>> 2 files changed, 36 insertions(+), 0 deletions(-)
>> create mode 100644 arch/powerpc/cpu/mpc85xx/cmd_errata.c
> ...
>> +static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>> +{
>> +    return 0;
>> +}
> 
> NAK. Please do not add dead code.
> 
> Please re-submit when you really add code here.
> 
> Best regards,
> 
> Wolfgang Denk

Do you want me to just merge w/the patch that does add code here?

- k
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to