Re: [U-Boot] [PATCH v2 00/21] imx: vybrid: Update BK4 and PCM052 boards to only use DM/DTS
On 21.01.2019 15:22, Lukasz Majewski wrote: > On Mon, 21 Jan 2019 09:33:23 +0100 > Lukasz Majewski wrote: > >> Hi Stefan, >> >> > This patch series converts PCM052 and BK4 to use Driver Model and >> > Device Tree. >> > >> > Some notable changes: >> > - The way how MAC address is read from fuses can now be adjusted >> > - DTS improvement/sync with kernel (also extract u-boot specific >> > properties) >> > - Using generic code instead of one from board >> > >> > The output of u-boot boot: >> > U-Boot 2019.01-rc3-00076-gc149229be0 (Jan 14 2019 - 08:38:48 +0100) >> > >> > CPU: Freescale Vybrid VF610 at 396 MHz >> > Reset cause: POWER ON RESET >> > Model: Liebherr (LVF) BK4 Vybrid Board >> > Board: BK4r1 (L333) >> > DRAM: 512 MiB >> > NAND: 1024 MiB >> > MMC: FSL_SDHC: 0 >> > Loading Environment from NAND... OK >> > In:serial@40028000 >> > Out: serial@40028000 >> > Err: serial@40028000 >> > Net: eth0: fec@400d, eth1: fec@400d1000 >> > Enter passphrase to stop autoboot, booting in 3 seconds >> > >> > Buildman CI: >> > ./tools/buildman/buildman.py --branch=HEAD~4 vf610 mx6 vybrid >> > --detail --verbose --show_errors --force-build --count=21 >> > --output-dir=../BUILD/ >> > >> > Travis-CI: >> > https://travis-ci.org/lmajewski/u-boot-dfu/jobs/481963146 >> >> I've bisected this error, and it turned out that the following patch >> is the culprit (on top of which I've rebased my work): >> >> "fs: fat: dynamically allocate memory for temporary buffer" >> >> Without this patch applied: >> https://travis-ci.org/lmajewski/u-boot-dfu/builds/482301236 >> >> With: >> https://travis-ci.org/lmajewski/u-boot-dfu/builds/482297604 >> >> Test: test/py qemu_arm >> >> Error is in: "test_efi_selftest" >> >> Executing 'block device' >> /home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest_block_device.c(386): >> TODO: Wrong volume label 'xxa1', expected 'U-BOOT TEST' >> /home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest_block_device.c(413): >> ERROR: Unexpected file content >> /home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest.c(110): >> ERROR: Executing 'block device' failed >> >> > > And the full travis-ci build without the above patch (all "green"): > > https://travis-ci.org/lmajewski/u-boot-dfu/builds/482308817 > I skimmed through the rest of the patchset but did not do a full review. But I am ok with the rest of the patches. I also tested the patchset on our Colibri VF50, and U-Boot seems to work fine! Thanks for your work! -- Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/21] imx: vybrid: Update BK4 and PCM052 boards to only use DM/DTS
On Mon, 21 Jan 2019 09:33:23 +0100
Lukasz Majewski wrote:
> Hi Stefan,
>
> > This patch series converts PCM052 and BK4 to use Driver Model and
> > Device Tree.
> >
> > Some notable changes:
> > - The way how MAC address is read from fuses can now be adjusted
> > - DTS improvement/sync with kernel (also extract u-boot specific
> > properties)
> > - Using generic code instead of one from board
> >
> > The output of u-boot boot:
> > U-Boot 2019.01-rc3-00076-gc149229be0 (Jan 14 2019 - 08:38:48 +0100)
> >
> > CPU: Freescale Vybrid VF610 at 396 MHz
> > Reset cause: POWER ON RESET
> > Model: Liebherr (LVF) BK4 Vybrid Board
> > Board: BK4r1 (L333)
> > DRAM: 512 MiB
> > NAND: 1024 MiB
> > MMC: FSL_SDHC: 0
> > Loading Environment from NAND... OK
> > In:serial@40028000
> > Out: serial@40028000
> > Err: serial@40028000
> > Net: eth0: fec@400d, eth1: fec@400d1000
> > Enter passphrase to stop autoboot, booting in 3 seconds
> >
> > Buildman CI:
> > ./tools/buildman/buildman.py --branch=HEAD~4 vf610 mx6 vybrid
> > --detail --verbose --show_errors --force-build --count=21
> > --output-dir=../BUILD/
> >
> > Travis-CI:
> > https://travis-ci.org/lmajewski/u-boot-dfu/jobs/481963146
>
> I've bisected this error, and it turned out that the following patch
> is the culprit (on top of which I've rebased my work):
>
> "fs: fat: dynamically allocate memory for temporary buffer"
>
> Without this patch applied:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/482301236
>
> With:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/482297604
>
> Test: test/py qemu_arm
>
> Error is in: "test_efi_selftest"
>
> Executing 'block device'
> /home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest_block_device.c(386):
> TODO: Wrong volume label 'xxa1', expected 'U-BOOT TEST'
> /home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest_block_device.c(413):
> ERROR: Unexpected file content
> /home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest.c(110):
> ERROR: Executing 'block device' failed
>
>
And the full travis-ci build without the above patch (all "green"):
https://travis-ci.org/lmajewski/u-boot-dfu/builds/482308817
>
> >
> > U-boot master branch: SHA1: c4d323793ba2e0616d93ca104e1e2b9a9fbccf9b
> >
> >
> > Changes in v2:
> > - Rename pcm052.dts to vf610-pcm052.dts
> > - Rename bk4r1.dts to vf610-bk4r1.dts
> > - Extract 'u-boot,dm-pre-reloc;' property to separate file (to
> > facilitate sync with Linux kernel dts files)
> > - New patch
> > - Disable EFI related support and commands (as we do not
> > plan to use EFI on this setup)
> >
> > Lukasz Majewski (21):
> > net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c
> > driver net: Kconfig: FEC: Add dependency on VF610
> > vybrid: ddr: Extend vf610-pinfunc.h with DDR pads definitions
> > vybrid: clock: Provide enable_i2c_clk() function for Vybrid
> > vybrid: Define the imx_get_mac_from_fuse() as a __weak function
> > pcm052: board: Remove "m4go" command as it is superseded by
> > "bootaux" pcm052: board: vybrid: Update the board name for BK4
> > device ARM: DTS: vybrid: Update vf.dtsi file to descibe more vf610
> > hardware pcm052: board: cosmetic: Add copyright notice to pcm052.c
> > ARM: DTS: Update pcm052 based dts files (bk4r1/pcm052)
> > ARM: DTS: Provide vf610-bk4r1-u-boot.dtsi for U-Boot specific
> > properties
> > defconfig: bk4/pcm052: Update bk4r1|pcm052_defconfig to support
> > DM/DT config: pcm052: Use SZ_X{MK} from linux/sizes.h for
> > include/configs/pcm052.h
> > config: bk4: Update include/configs/bk4r1.h file
> > pcm052: board: Remove in-board setup code (it is now replaced by
> > DM setup)
> > config: bk4: Update u-boot script to support recovery via SD card
> > config: bk4: Update u-boot envs to support NOR memories initial
> > setup pcm052: bk4: sdcard: Add support for SD card booting/recovery
> > pcm052: board: Add code to setup LED default states
> > pcm052: mac: Provide board specific imx_get_mac_from_fuse()
> > function pcm052: bk4: Add board_phy_config() for BK4 to setup
> > ksz8081 phy
> >
> > arch/arm/cpu/armv7/vf610/Kconfig | 1 +
> > arch/arm/cpu/armv7/vf610/generic.c| 21 +-
> > arch/arm/dts/Makefile | 4 +-
> > arch/arm/dts/bk4r1.dts| 47
> > arch/arm/dts/vf.dtsi | 62 +
> > arch/arm/dts/vf610-bk4r1-u-boot.dtsi | 27 ++
> > arch/arm/dts/vf610-bk4r1.dts | 97 +++
> > arch/arm/dts/{pcm052.dts => vf610-pcm052.dts} | 6 +-
> > arch/arm/dts/vf610-pcm052.dtsi| 259
> > + arch/arm/dts/vf610-pinfunc.h |
> > 50 arch/arm/include/asm/arch-vf610/clock.h | 3 +
> > arch/arm/include/asm/arch-vf610/imx-regs.h| 2 +
> > board/phytec/pcm052/pcm052.c | 386
> > ++
> >
Re: [U-Boot] [PATCH v2 00/21] imx: vybrid: Update BK4 and PCM052 boards to only use DM/DTS
Hi Stefan,
> This patch series converts PCM052 and BK4 to use Driver Model and
> Device Tree.
>
> Some notable changes:
> - The way how MAC address is read from fuses can now be adjusted
> - DTS improvement/sync with kernel (also extract u-boot specific
> properties)
> - Using generic code instead of one from board
>
> The output of u-boot boot:
> U-Boot 2019.01-rc3-00076-gc149229be0 (Jan 14 2019 - 08:38:48 +0100)
>
> CPU: Freescale Vybrid VF610 at 396 MHz
> Reset cause: POWER ON RESET
> Model: Liebherr (LVF) BK4 Vybrid Board
> Board: BK4r1 (L333)
> DRAM: 512 MiB
> NAND: 1024 MiB
> MMC: FSL_SDHC: 0
> Loading Environment from NAND... OK
> In:serial@40028000
> Out: serial@40028000
> Err: serial@40028000
> Net: eth0: fec@400d, eth1: fec@400d1000
> Enter passphrase to stop autoboot, booting in 3 seconds
>
> Buildman CI:
> ./tools/buildman/buildman.py --branch=HEAD~4 vf610 mx6 vybrid
> --detail --verbose --show_errors --force-build --count=21
> --output-dir=../BUILD/
>
> Travis-CI:
> https://travis-ci.org/lmajewski/u-boot-dfu/jobs/481963146
I've bisected this error, and it turned out that the following patch is
the culprit (on top of which I've rebased my work):
"fs: fat: dynamically allocate memory for temporary buffer"
Without this patch applied:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/482301236
With:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/482297604
Test: test/py qemu_arm
Error is in: "test_efi_selftest"
Executing 'block device'
/home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest_block_device.c(386):
TODO: Wrong volume label 'xxa1', expected 'U-BOOT TEST'
/home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest_block_device.c(413):
ERROR: Unexpected file content
/home/travis/build/lmajewski/u-boot-dfu/lib/efi_selftest/efi_selftest.c(110):
ERROR: Executing 'block device' failed
>
> U-boot master branch: SHA1: c4d323793ba2e0616d93ca104e1e2b9a9fbccf9b
>
>
> Changes in v2:
> - Rename pcm052.dts to vf610-pcm052.dts
> - Rename bk4r1.dts to vf610-bk4r1.dts
> - Extract 'u-boot,dm-pre-reloc;' property to separate file (to
> facilitate sync with Linux kernel dts files)
> - New patch
> - Disable EFI related support and commands (as we do not plan
> to use EFI on this setup)
>
> Lukasz Majewski (21):
> net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c
> driver net: Kconfig: FEC: Add dependency on VF610
> vybrid: ddr: Extend vf610-pinfunc.h with DDR pads definitions
> vybrid: clock: Provide enable_i2c_clk() function for Vybrid
> vybrid: Define the imx_get_mac_from_fuse() as a __weak function
> pcm052: board: Remove "m4go" command as it is superseded by
> "bootaux" pcm052: board: vybrid: Update the board name for BK4 device
> ARM: DTS: vybrid: Update vf.dtsi file to descibe more vf610 hardware
> pcm052: board: cosmetic: Add copyright notice to pcm052.c
> ARM: DTS: Update pcm052 based dts files (bk4r1/pcm052)
> ARM: DTS: Provide vf610-bk4r1-u-boot.dtsi for U-Boot specific
> properties
> defconfig: bk4/pcm052: Update bk4r1|pcm052_defconfig to support
> DM/DT config: pcm052: Use SZ_X{MK} from linux/sizes.h for
> include/configs/pcm052.h
> config: bk4: Update include/configs/bk4r1.h file
> pcm052: board: Remove in-board setup code (it is now replaced by DM
> setup)
> config: bk4: Update u-boot script to support recovery via SD card
> config: bk4: Update u-boot envs to support NOR memories initial
> setup pcm052: bk4: sdcard: Add support for SD card booting/recovery
> pcm052: board: Add code to setup LED default states
> pcm052: mac: Provide board specific imx_get_mac_from_fuse() function
> pcm052: bk4: Add board_phy_config() for BK4 to setup ksz8081 phy
>
> arch/arm/cpu/armv7/vf610/Kconfig | 1 +
> arch/arm/cpu/armv7/vf610/generic.c| 21 +-
> arch/arm/dts/Makefile | 4 +-
> arch/arm/dts/bk4r1.dts| 47
> arch/arm/dts/vf.dtsi | 62 +
> arch/arm/dts/vf610-bk4r1-u-boot.dtsi | 27 ++
> arch/arm/dts/vf610-bk4r1.dts | 97 +++
> arch/arm/dts/{pcm052.dts => vf610-pcm052.dts} | 6 +-
> arch/arm/dts/vf610-pcm052.dtsi| 259 +
> arch/arm/dts/vf610-pinfunc.h | 50
> arch/arm/include/asm/arch-vf610/clock.h | 3 +
> arch/arm/include/asm/arch-vf610/imx-regs.h| 2 +
> board/phytec/pcm052/pcm052.c | 386
> ++
> configs/bk4r1_defconfig | 49 +++-
> configs/pcm052_defconfig | 36 ++-
> drivers/net/Kconfig | 2 +-
> drivers/net/fec_mxc.c | 1 +
> include/configs/bk4r1.h | 263
> +- include/configs/pcm052.h |
> 51 +--- 19 files changed, 956 insertions(+), 411 deletions(-
[U-Boot] [PATCH v2 00/21] imx: vybrid: Update BK4 and PCM052 boards to only use DM/DTS
This patch series converts PCM052 and BK4 to use Driver Model and Device
Tree.
Some notable changes:
- The way how MAC address is read from fuses can now be adjusted
- DTS improvement/sync with kernel (also extract u-boot specific properties)
- Using generic code instead of one from board
The output of u-boot boot:
U-Boot 2019.01-rc3-00076-gc149229be0 (Jan 14 2019 - 08:38:48 +0100)
CPU: Freescale Vybrid VF610 at 396 MHz
Reset cause: POWER ON RESET
Model: Liebherr (LVF) BK4 Vybrid Board
Board: BK4r1 (L333)
DRAM: 512 MiB
NAND: 1024 MiB
MMC: FSL_SDHC: 0
Loading Environment from NAND... OK
In:serial@40028000
Out: serial@40028000
Err: serial@40028000
Net: eth0: fec@400d, eth1: fec@400d1000
Enter passphrase to stop autoboot, booting in 3 seconds
Buildman CI:
./tools/buildman/buildman.py --branch=HEAD~4 vf610 mx6 vybrid --detail
--verbose --show_errors --force-build --count=21 --output-dir=../BUILD/
Travis-CI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/481963146
U-boot master branch: SHA1: c4d323793ba2e0616d93ca104e1e2b9a9fbccf9b
Changes in v2:
- Rename pcm052.dts to vf610-pcm052.dts
- Rename bk4r1.dts to vf610-bk4r1.dts
- Extract 'u-boot,dm-pre-reloc;' property to separate file (to facilitate
sync with Linux kernel dts files)
- New patch
- Disable EFI related support and commands (as we do not plan to
use EFI on this setup)
Lukasz Majewski (21):
net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c driver
net: Kconfig: FEC: Add dependency on VF610
vybrid: ddr: Extend vf610-pinfunc.h with DDR pads definitions
vybrid: clock: Provide enable_i2c_clk() function for Vybrid
vybrid: Define the imx_get_mac_from_fuse() as a __weak function
pcm052: board: Remove "m4go" command as it is superseded by "bootaux"
pcm052: board: vybrid: Update the board name for BK4 device
ARM: DTS: vybrid: Update vf.dtsi file to descibe more vf610 hardware
pcm052: board: cosmetic: Add copyright notice to pcm052.c
ARM: DTS: Update pcm052 based dts files (bk4r1/pcm052)
ARM: DTS: Provide vf610-bk4r1-u-boot.dtsi for U-Boot specific
properties
defconfig: bk4/pcm052: Update bk4r1|pcm052_defconfig to support DM/DT
config: pcm052: Use SZ_X{MK} from linux/sizes.h for
include/configs/pcm052.h
config: bk4: Update include/configs/bk4r1.h file
pcm052: board: Remove in-board setup code (it is now replaced by DM
setup)
config: bk4: Update u-boot script to support recovery via SD card
config: bk4: Update u-boot envs to support NOR memories initial setup
pcm052: bk4: sdcard: Add support for SD card booting/recovery
pcm052: board: Add code to setup LED default states
pcm052: mac: Provide board specific imx_get_mac_from_fuse() function
pcm052: bk4: Add board_phy_config() for BK4 to setup ksz8081 phy
arch/arm/cpu/armv7/vf610/Kconfig | 1 +
arch/arm/cpu/armv7/vf610/generic.c| 21 +-
arch/arm/dts/Makefile | 4 +-
arch/arm/dts/bk4r1.dts| 47
arch/arm/dts/vf.dtsi | 62 +
arch/arm/dts/vf610-bk4r1-u-boot.dtsi | 27 ++
arch/arm/dts/vf610-bk4r1.dts | 97 +++
arch/arm/dts/{pcm052.dts => vf610-pcm052.dts} | 6 +-
arch/arm/dts/vf610-pcm052.dtsi| 259 +
arch/arm/dts/vf610-pinfunc.h | 50
arch/arm/include/asm/arch-vf610/clock.h | 3 +
arch/arm/include/asm/arch-vf610/imx-regs.h| 2 +
board/phytec/pcm052/pcm052.c | 386 ++
configs/bk4r1_defconfig | 49 +++-
configs/pcm052_defconfig | 36 ++-
drivers/net/Kconfig | 2 +-
drivers/net/fec_mxc.c | 1 +
include/configs/bk4r1.h | 263 +-
include/configs/pcm052.h | 51 +---
19 files changed, 956 insertions(+), 411 deletions(-)
delete mode 100644 arch/arm/dts/bk4r1.dts
create mode 100644 arch/arm/dts/vf610-bk4r1-u-boot.dtsi
create mode 100644 arch/arm/dts/vf610-bk4r1.dts
rename arch/arm/dts/{pcm052.dts => vf610-pcm052.dts} (81%)
create mode 100644 arch/arm/dts/vf610-pcm052.dtsi
--
2.11.0
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
