[U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
This patch adds a NAND driver for the Marvell Kirkwood SoC's.
Acked-by: Stefan Roese
Signed-off-by: Prafulla Wadaskar
---
Change log:
v2: updated as per feedback for v1 (cosmetic change)
drivers/mtd/nand/Makefile|1 +
drivers/mtd/nand/kirkwood_nand.c | 81 ++
2 files changed, 82 insertions(+), 0 deletions(-)
create mode 100644 drivers/mtd/nand/kirkwood_nand.c
diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
index 471cd6b..766c3f0 100644
--- a/drivers/mtd/nand/Makefile
+++ b/drivers/mtd/nand/Makefile
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_DRIVER_NAND_BFIN) += bfin_nand.o
COBJS-$(CONFIG_NAND_DAVINCI) += davinci_nand.o
COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o
COBJS-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o
+COBJS-$(CONFIG_NAND_KIRKWOOD) += kirkwood_nand.o
COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
COBJS-$(CONFIG_NAND_S3C64XX) += s3c64xx.o
diff --git a/drivers/mtd/nand/kirkwood_nand.c b/drivers/mtd/nand/kirkwood_nand.c
new file mode 100644
index 000..9cdbe20
--- /dev/null
+++ b/drivers/mtd/nand/kirkwood_nand.c
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates
+ * Written-by: Prafulla Wadaskar
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include
+#include
+#include
+#include
+
+/* NAND Flash Soc registers */
+struct kwnandf_registers {
+ u32 rd_params; /* 0x10418 */
+ u32 wr_param; /* 0x1041c */
+ u8 pad[0x10470 - 0x1041c - 4];
+ u32 ctrl; /* 0x10470 */
+};
+
+static struct kwnandf_registers *nf_reg =
+ (struct kwnandf_registers *)KW_NANDF_BASE;
+
+/*
+ * hardware specific access to control-lines/bits
+ */
+#define NAND_ACTCEBOOT_BIT 0x02
+
+static void kw_nand_hwcontrol(struct mtd_info *mtd, int cmd,
+ unsigned int ctrl)
+{
+ struct nand_chip *nc = mtd->priv;
+ u32 offs;
+
+ if (cmd == NAND_CMD_NONE)
+ return;
+
+ if (ctrl & NAND_CLE)
+ offs = (1 << 0);/* Commands with A[1:0] == 01 */
+ else if (ctrl & NAND_ALE)
+ offs = (1 << 1);/* Addresses with A[1:0] == 10 */
+ else
+ return;
+
+ writeb(cmd, nc->IO_ADDR_W + offs);
+}
+
+void kw_nand_select_chip(struct mtd_info *mtd, int chip)
+{
+ u32 data;
+
+ data = readl(&nf_reg->ctrl);
+ data |= NAND_ACTCEBOOT_BIT;
+ writel(data, &nf_reg->ctrl);
+}
+
+int board_nand_init(struct nand_chip *nand)
+{
+ nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+ nand->ecc.mode = NAND_ECC_SOFT;
+ nand->cmd_ctrl = kw_nand_hwcontrol;
+ nand->chip_delay = 30;
+ nand->select_chip = kw_nand_select_chip;
+ return 0;
+}
--
1.5.3.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
This patch adds a NAND driver for the Marvell Kirkwood SoC's.
Acked-by: Stefan Roese
Signed-off-by: Prafulla Wadaskar
---
Change log:
v2: updated as per feedback for v1 (cosmetic change)
drivers/mtd/nand/Makefile|1 +
drivers/mtd/nand/kirkwood_nand.c | 81 ++
2 files changed, 82 insertions(+), 0 deletions(-)
create mode 100644 drivers/mtd/nand/kirkwood_nand.c
diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
index 471cd6b..766c3f0 100644
--- a/drivers/mtd/nand/Makefile
+++ b/drivers/mtd/nand/Makefile
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_DRIVER_NAND_BFIN) += bfin_nand.o
COBJS-$(CONFIG_NAND_DAVINCI) += davinci_nand.o
COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o
COBJS-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o
+COBJS-$(CONFIG_NAND_KIRKWOOD) += kirkwood_nand.o
COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
COBJS-$(CONFIG_NAND_S3C64XX) += s3c64xx.o
diff --git a/drivers/mtd/nand/kirkwood_nand.c b/drivers/mtd/nand/kirkwood_nand.c
new file mode 100644
index 000..9cdbe20
--- /dev/null
+++ b/drivers/mtd/nand/kirkwood_nand.c
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates
+ * Written-by: Prafulla Wadaskar
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include
+#include
+#include
+#include
+
+/* NAND Flash Soc registers */
+struct kwnandf_registers {
+ u32 rd_params; /* 0x10418 */
+ u32 wr_param; /* 0x1041c */
+ u8 pad[0x10470 - 0x1041c - 4];
+ u32 ctrl; /* 0x10470 */
+};
+
+static struct kwnandf_registers *nf_reg =
+ (struct kwnandf_registers *)KW_NANDF_BASE;
+
+/*
+ * hardware specific access to control-lines/bits
+ */
+#define NAND_ACTCEBOOT_BIT 0x02
+
+static void kw_nand_hwcontrol(struct mtd_info *mtd, int cmd,
+ unsigned int ctrl)
+{
+ struct nand_chip *nc = mtd->priv;
+ u32 offs;
+
+ if (cmd == NAND_CMD_NONE)
+ return;
+
+ if (ctrl & NAND_CLE)
+ offs = (1 << 0);/* Commands with A[1:0] == 01 */
+ else if (ctrl & NAND_ALE)
+ offs = (1 << 1);/* Addresses with A[1:0] == 10 */
+ else
+ return;
+
+ writeb(cmd, nc->IO_ADDR_W + offs);
+}
+
+void kw_nand_select_chip(struct mtd_info *mtd, int chip)
+{
+ u32 data;
+
+ data = readl(&nf_reg->ctrl);
+ data |= NAND_ACTCEBOOT_BIT;
+ writel(data, &nf_reg->ctrl);
+}
+
+int board_nand_init(struct nand_chip *nand)
+{
+ nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+ nand->ecc.mode = NAND_ECC_SOFT;
+ nand->cmd_ctrl = kw_nand_hwcontrol;
+ nand->chip_delay = 30;
+ nand->select_chip = kw_nand_select_chip;
+ return 0;
+}
--
1.5.3.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagn...@jcrosoft.com] > Sent: Saturday, June 13, 2009 7:32 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Manas Saksena; Ronen Shitrit; > Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert > Buijtenhek; Scott Wood > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > On 17:34 Mon 08 Jun , Prafulla Wadaskar wrote: > > This patch adds a NAND driver for the Marvell Kirkwood SoC's. > > > > Acked-by: Stefan Roese > > Signed-off-by: Prafulla Wadaskar > > --- > > Change log: > > v2: updated as per feedback for v1 (cosmetic change) > Scott what is status for you? Hi Scott, I have re-posted this driver twice.. Any updates on this? Regards.. Prafulla . . > > Best Regards, > J. > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
Prafulla Wadaskar wrote: >> Scott what is status for you? > Hi Scott, > I have re-posted this driver twice.. Any updates on this? Sorry, I was out the previous week and have been busy catching up this past week. I'll try to get to the stack of pending NAND stuff soon. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > diff --git a/drivers/mtd/nand/kirkwood_nand.c > b/drivers/mtd/nand/kirkwood_nand.c > new file mode 100644 > index 000..9cdbe20 > --- /dev/null > +++ b/drivers/mtd/nand/kirkwood_nand.c > @@ -0,0 +1,81 @@ > +/* > + * Copyright (C) Marvell International Ltd. and its affiliates No year? > +#include > +#include > +#include > +#include I don't see kirkwood.h in upstream, so I guess this should go via an arch tree. Acked-by: Scott Wood -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Scott Wood [mailto:scottw...@freescale.com] > Sent: Tuesday, June 23, 2009 3:35 AM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > b/drivers/mtd/nand/kirkwood_nand.c > > new file mode 100644 > > index 000..9cdbe20 > > --- /dev/null > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > @@ -0,0 +1,81 @@ > > +/* > > + * Copyright (C) Marvell International Ltd. and its affiliates > > No year? I will correct this. > > > +#include > > +#include > > +#include > > +#include > > I don't see kirkwood.h in upstream, so I guess this should go > via an arch tree. Kirkwood support is available in arm/next, I hope it will be pulled soon :-) Any way this is dependency for this driver but is this blocker? I have two options- 1. remove dependency from this patch or 2. get Basic Kirkwood support up streamed There are some other drivers in pipeline i.e. i2c,spi,usb that needs Basic Kirkwood support. So I wish to go for second option Hi Jean, Can you pls help to resolve this dependency? Please let me know your feedback on this issue ASAP so that I can release next spin Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
On 23:08 Mon 22 Jun , Prafulla Wadaskar wrote: > > > > -Original Message- > > From: Scott Wood [mailto:scottw...@freescale.com] > > Sent: Tuesday, June 23, 2009 3:35 AM > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > > Ronen Shitrit > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > > Marvell Kirkwood NAND driver > > > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > > b/drivers/mtd/nand/kirkwood_nand.c > > > new file mode 100644 > > > index 000..9cdbe20 > > > --- /dev/null > > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > > @@ -0,0 +1,81 @@ > > > +/* > > > + * Copyright (C) Marvell International Ltd. and its affiliates > > > > No year? > I will correct this. > > > > > > +#include > > > +#include > > > +#include > > > +#include > > > > I don't see kirkwood.h in upstream, so I guess this should go > > via an arch tree. > > Kirkwood support is available in arm/next, I hope it will be pulled soon :-) > Any way this is dependency for this driver but is this blocker? > > I have two options- > 1. remove dependency from this patch or > 2. get Basic Kirkwood support up streamed > There are some other drivers in pipeline i.e. i2c,spi,usb that needs Basic > Kirkwood support. So I wish to go for second option > Hi Jean, > Can you pls help to resolve this dependency? Wolfgang is in vacancy so we will have to wait until he will came back the will be present in the arm tree until and then I will send him a pull request Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
Prafulla, > > -Original Message- > > From: Scott Wood [mailto:scottw...@freescale.com] > > Sent: Tuesday, June 23, 2009 3:35 AM > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > > Ronen Shitrit > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > > Marvell Kirkwood NAND driver > > > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > > b/drivers/mtd/nand/kirkwood_nand.c > > > new file mode 100644 > > > index 000..9cdbe20 > > > --- /dev/null > > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > > @@ -0,0 +1,81 @@ > > > +/* > > > + * Copyright (C) Marvell International Ltd. and its affiliates > > > > No year? > > I will correct this. > > > > +#include > > > +#include > > > +#include > > > +#include > > > > I don't see kirkwood.h in upstream, so I guess this should go > > via an arch tree. > > Kirkwood support is available in arm/next, I hope it will be pulled soon > :-) Any way this is dependency for this driver but is this blocker? > > I have two options- > 1. remove dependency from this patch or > 2. get Basic Kirkwood support up streamed > There are some other drivers in pipeline i.e. i2c,spi,usb that needs Basic > Kirkwood support. So I wish to go for second option Hi Jean, > Can you pls help to resolve this dependency? > Could you give me a rough time schedule for these new drivers? Do we talk from a view weeks or months? I have to start writing my board support functions and it would be helpful to decide on which u-boot I want to start (1.1.4 marvell or marvell git). Thanks, Dieter > Please let me know your feedback on this issue ASAP so that I can release > next spin > > Regards.. > Prafulla . . > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > Sent: Tuesday, June 23, 2009 1:23 PM > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Scott Wood; Jean-Christophe > PLAGNIOL-VILLARD; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > Prafulla, > > > > -Original Message- > > > From: Scott Wood [mailto:scottw...@freescale.com] > > > Sent: Tuesday, June 23, 2009 3:35 AM > > > To: Prafulla Wadaskar > > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan > Sarnaik; Ronen > > > Shitrit > > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell > > > Kirkwood NAND driver > > > > > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > > > b/drivers/mtd/nand/kirkwood_nand.c > > > > new file mode 100644 > > > > index 000..9cdbe20 > > > > --- /dev/null > > > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > > > @@ -0,0 +1,81 @@ > > > > +/* > > > > + * Copyright (C) Marvell International Ltd. and its affiliates > > > > > > No year? > > > > I will correct this. > > > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > > > I don't see kirkwood.h in upstream, so I guess this > should go via an > > > arch tree. > > > > Kirkwood support is available in arm/next, I hope it will be pulled > > soon > > :-) Any way this is dependency for this driver but is this blocker? > > > > I have two options- > > 1. remove dependency from this patch or 2. get Basic > Kirkwood support > > up streamed There are some other drivers in pipeline i.e. > i2c,spi,usb > > that needs Basic Kirkwood support. So I wish to go for > second option > > Hi Jean, Can you pls help to resolve this dependency? > > > > Could you give me a rough time schedule for these new drivers? > Do we talk from a view weeks or months? SPI is ready to use (available on git.marvell.com) USB will be ready latest by ~10thJuly2009 I2C lowest priority (as per need) > > I have to start writing my board support functions and it > would be helpful to decide on which u-boot I want to start > (1.1.4 marvell or marvell git). Please use marvell git, 1.1.4 is now outdated and not recommended for new development Regards.. Prafulla . . > > Thanks, > Dieter > > > Please let me know your feedback on this issue ASAP so that I can > > release next spin > > > > Regards.. > > Prafulla . . > > ___ > > U-Boot mailing list > > U-Boot@lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot > > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
Am Dienstag 23 Juni 2009 10:01:28 schrieb Prafulla Wadaskar: > > -Original Message- > > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > > Sent: Tuesday, June 23, 2009 1:23 PM > > To: u-boot@lists.denx.de > > Cc: Prafulla Wadaskar; Scott Wood; Jean-Christophe > > PLAGNIOL-VILLARD; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > > Marvell Kirkwood NAND driver > > > > Prafulla, > > > > > > -Original Message- > > > > From: Scott Wood [mailto:scottw...@freescale.com] > > > > Sent: Tuesday, June 23, 2009 3:35 AM > > > > To: Prafulla Wadaskar > > > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan > > > > Sarnaik; Ronen > > > > > > Shitrit > > > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell > > > > Kirkwood NAND driver > > > > > > > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > > > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > > > > b/drivers/mtd/nand/kirkwood_nand.c > > > > > new file mode 100644 > > > > > index 000..9cdbe20 > > > > > --- /dev/null > > > > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > > > > @@ -0,0 +1,81 @@ > > > > > +/* > > > > > + * Copyright (C) Marvell International Ltd. and its affiliates > > > > > > > > No year? > > > > > > I will correct this. > > > > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > > > > I don't see kirkwood.h in upstream, so I guess this > > > > should go via an > > > > > > arch tree. > > > > > > Kirkwood support is available in arm/next, I hope it will be pulled > > > soon > > > > > > :-) Any way this is dependency for this driver but is this blocker? > > > > > > I have two options- > > > 1. remove dependency from this patch or 2. get Basic > > > > Kirkwood support > > > > > up streamed There are some other drivers in pipeline i.e. > > > > i2c,spi,usb > > > > > that needs Basic Kirkwood support. So I wish to go for > > > > second option > > > > > Hi Jean, Can you pls help to resolve this dependency? > > > > Could you give me a rough time schedule for these new drivers? > > Do we talk from a view weeks or months? > > SPI is ready to use (available on git.marvell.com) > USB will be ready latest by ~10thJuly2009 Thats fine - you made me a birthday present :) > I2C lowest priority (as per need) Can I do something to push I2C priority? > > > I have to start writing my board support functions and it > > would be helpful to decide on which u-boot I want to start > > (1.1.4 marvell or marvell git). > > Please use marvell git, 1.1.4 is now outdated and not recommended for new > development Thats my opinion, too. Thanks, Dieter > > Regards.. > Prafulla . . > > > Thanks, > > Dieter > > > > > Please let me know your feedback on this issue ASAP so that I can > > > release next spin > > > > > > Regards.. > > > Prafulla . . > > > ___ > > > U-Boot mailing list > > > U-Boot@lists.denx.de > > > http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> > > I2C lowest priority (as per need) > Can I do something to push I2C priority? If the I/O is shared with gpio you can use bitbanging with few hours Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe PLAGNIOL-VILLARD: > > > I2C lowest priority (as per need) > > > > Can I do something to push I2C priority? > > If the I/O is shared with gpio you can use bitbanging with few hours I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too. > > Best Regards, > J. @Prafulla: in kirkwood/cpu.c there are 2 functions: kw_config_gpio() kw_config_mpp() If I implement additional functions like kw_gpio_direction(int gpio, enum direction) kw_gpio_set(int gpio, int value) int value kw_gpio_get(int gpio) If the functions are implemented in cpu.c are they accessible from cmd_xxx.c functions? Would this be ok to get it mainline or should there be an special driver for gpio access? Sorry for my newbie questions :) Dieter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > Sent: Tuesday, June 23, 2009 2:18 PM > To: Jean-Christophe PLAGNIOL-VILLARD > Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Scott Wood; > Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe > PLAGNIOL-VILLARD: > > > > > I2C lowest priority (as per need) > > > > > > Can I do something to push I2C priority? Any way this driver will be arround TWSI controller interface by h/w Again if you are using different pins then may not be helpful for you > > > > If the I/O is shared with gpio you can use bitbanging with few hours > > I think this would be the best to start - due to the fact > that I need bitbanging for FPGA flashing, too. This is a good Idea, start your development with accessing GPIO registers directly Regards.. Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
Am Dienstag 23 Juni 2009 12:38:05 schrieb Prafulla Wadaskar: > > -Original Message- > > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > > Sent: Tuesday, June 23, 2009 2:18 PM > > To: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Scott Wood; > > Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > > Marvell Kirkwood NAND driver > > > > Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe > > > > PLAGNIOL-VILLARD: > > > > > I2C lowest priority (as per need) > > > > > > > > Can I do something to push I2C priority? > > Any way this driver will be arround TWSI controller interface by h/w > Again if you are using different pins then may not be helpful for you > I2C by hardware is ok because the pins are not multiplexed with other important functions as its the case for SPI. And also I2C isn't _so_ important to bring up the first board revision :) > > > If the I/O is shared with gpio you can use bitbanging with few hours > > > > I think this would be the best to start - due to the fact > > that I need bitbanging for FPGA flashing, too. > > This is a good Idea, start your development with accessing GPIO registers > directly I start working on gpio stuff now and sending my patches to you. Maybe it is helpful for others, too, Dieter > > Regards.. > Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > Sent: Tuesday, June 23, 2009 4:53 PM > To: Prafulla Wadaskar > Cc: Jean-Christophe PLAGNIOL-VILLARD; u-boot@lists.denx.de; > Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > Am Dienstag 23 Juni 2009 12:38:05 schrieb Prafulla Wadaskar: > > > -Original Message- > > > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > > > Sent: Tuesday, June 23, 2009 2:18 PM > > > To: Jean-Christophe PLAGNIOL-VILLARD > > > Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Scott Wood; Ashish > > > Karkare; Prabhanjan Sarnaik; Ronen Shitrit > > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell > > > Kirkwood NAND driver > > > > > > Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe > > > > > > PLAGNIOL-VILLARD: > > > > > > I2C lowest priority (as per need) > > > > > > > > > > Can I do something to push I2C priority? > > > > Any way this driver will be arround TWSI controller > interface by h/w > > Again if you are using different pins then may not be > helpful for you > > > I2C by hardware is ok because the pins are not multiplexed > with other important functions as its the case for SPI. > And also I2C isn't _so_ important to bring up the first board > revision :) > > > > > If the I/O is shared with gpio you can use bitbanging with few > > > > hours > > > > > > I think this would be the best to start - due to the fact that I > > > need bitbanging for FPGA flashing, too. > > > > This is a good Idea, start your development with accessing GPIO > > registers directly > I start working on gpio stuff now and sending my patches to > you. Maybe it is helpful for others, too, You are most welcomed as one of kirkwood developer for u-boot community Post your patches to mailing list so that everyone can review and provide you feedback, follow u-boot development guidelines, go through u-boot development documentation.. Best of luck :-) Regards.. Prafulla . . > > Dieter > > > > Regards.. > > Prafulla . . . > > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
On Tuesday 23 June 2009 13:23:18 Dieter Kiermaier wrote: > > > I think this would be the best to start - due to the fact > > > that I need bitbanging for FPGA flashing, too. > > > > This is a good Idea, start your development with accessing GPIO registers > > directly > > I start working on gpio stuff now and sending my patches to you. Maybe it > is helpful for others, too, Please send your patches not only to Prafulla but to the list as well. Thanks. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
Am Dienstag 23 Juni 2009 14:06:46 schrieb Prafulla Wadaskar: > > -Original Message- > > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > > Sent: Tuesday, June 23, 2009 4:53 PM > > To: Prafulla Wadaskar > > Cc: Jean-Christophe PLAGNIOL-VILLARD; u-boot@lists.denx.de; > > Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > > Marvell Kirkwood NAND driver > > > > Am Dienstag 23 Juni 2009 12:38:05 schrieb Prafulla Wadaskar: > > > > -Original Message- > > > > From: Dieter Kiermaier [mailto:dk-arm-li...@gmx.de] > > > > Sent: Tuesday, June 23, 2009 2:18 PM > > > > To: Jean-Christophe PLAGNIOL-VILLARD > > > > Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Scott Wood; Ashish > > > > Karkare; Prabhanjan Sarnaik; Ronen Shitrit > > > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell > > > > Kirkwood NAND driver > > > > > > > > Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe > > > > > > > > PLAGNIOL-VILLARD: > > > > > > > I2C lowest priority (as per need) > > > > > > > > > > > > Can I do something to push I2C priority? > > > > > > Any way this driver will be arround TWSI controller > > > > interface by h/w > > > > > Again if you are using different pins then may not be > > > > helpful for you > > > > I2C by hardware is ok because the pins are not multiplexed > > with other important functions as its the case for SPI. > > And also I2C isn't _so_ important to bring up the first board > > revision :) > > > > > > > If the I/O is shared with gpio you can use bitbanging with few > > > > > hours > > > > > > > > I think this would be the best to start - due to the fact that I > > > > need bitbanging for FPGA flashing, too. > > > > > > This is a good Idea, start your development with accessing GPIO > > > registers directly > > > > I start working on gpio stuff now and sending my patches to > > you. Maybe it is helpful for others, too, > > You are most welcomed as one of kirkwood developer for u-boot community > Post your patches to mailing list so that everyone can review and provide > you feedback, follow u-boot development guidelines, go through u-boot > development documentation.. > > Best of luck :-) > Thanks to all - it's time to give something back to the community :) And sure - I will send the patches as well to the list! Dieter > Regards.. > Prafulla . . > > > Dieter > > > > > Regards.. > > > Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Scott Wood [mailto:scottw...@freescale.com] > Sent: Tuesday, June 23, 2009 3:35 AM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > b/drivers/mtd/nand/kirkwood_nand.c > > new file mode 100644 > > index 000..9cdbe20 > > --- /dev/null > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > @@ -0,0 +1,81 @@ > > +/* > > + * Copyright (C) Marvell International Ltd. and its affiliates > > No year? > > > +#include > > +#include > > +#include > > +#include > > I don't see kirkwood.h in upstream, so I guess this should go > via an arch tree. Hi Jean, Similar to spi driver, can you please pull this driver too? I am posting the new spin for suggested modification Regards.. Prafulla . . > > Acked-by: Scott Wood > > -Scott > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
On 00:32 Fri 26 Jun , Prafulla Wadaskar wrote: > > > > -Original Message- > > From: Scott Wood [mailto:scottw...@freescale.com] > > Sent: Tuesday, June 23, 2009 3:35 AM > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > > Ronen Shitrit > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > > Marvell Kirkwood NAND driver > > > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > > b/drivers/mtd/nand/kirkwood_nand.c > > > new file mode 100644 > > > index 000..9cdbe20 > > > --- /dev/null > > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > > @@ -0,0 +1,81 @@ > > > +/* > > > + * Copyright (C) Marvell International Ltd. and its affiliates > > > > No year? > > > > > +#include > > > +#include > > > +#include > > > +#include > > > > I don't see kirkwood.h in upstream, so I guess this should go > > via an arch tree. > Hi Jean, > Similar to spi driver, can you please pull this driver too? > I am posting the new spin for suggested modification > please fix the year and I will Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> -Original Message- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagn...@jcrosoft.com] > Sent: Saturday, June 27, 2009 8:53 PM > To: Prafulla Wadaskar > Cc: Scott Wood; u-boot@lists.denx.de; Ashish Karkare; > Prabhanjan Sarnaik; Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add > Marvell Kirkwood NAND driver > > On 00:32 Fri 26 Jun , Prafulla Wadaskar wrote: > > > > > > > -Original Message- > > > From: Scott Wood [mailto:scottw...@freescale.com] > > > Sent: Tuesday, June 23, 2009 3:35 AM > > > To: Prafulla Wadaskar > > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan > Sarnaik; Ronen > > > Shitrit > > > Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell > > > Kirkwood NAND driver > > > > > > On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote: > > > > diff --git a/drivers/mtd/nand/kirkwood_nand.c > > > > b/drivers/mtd/nand/kirkwood_nand.c > > > > new file mode 100644 > > > > index 000..9cdbe20 > > > > --- /dev/null > > > > +++ b/drivers/mtd/nand/kirkwood_nand.c > > > > @@ -0,0 +1,81 @@ > > > > +/* > > > > + * Copyright (C) Marvell International Ltd. and its affiliates > > > > > > No year? > > > > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > > > I don't see kirkwood.h in upstream, so I guess this > should go via an > > > arch tree. > > Hi Jean, > > Similar to spi driver, can you please pull this driver too? > > I am posting the new spin for suggested modification > > > please fix the year and I will Hi Jean I have already posted v3 for this, but I could not find this in your today's pull request Ref: http://lists.denx.de/pipermail/u-boot/2009-June/055110.html Can you please apply this one? Regards.. Prafulla . . > > Best Regards, > J. > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
> > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > > > > I don't see kirkwood.h in upstream, so I guess this > > should go via an > > > > arch tree. > > > Hi Jean, > > > Similar to spi driver, can you please pull this driver too? > > > I am posting the new spin for suggested modification > > > > > please fix the year and I will > Hi Jean > I have already posted v3 for this, but I could not find this in your today's > pull request > Ref: http://lists.denx.de/pipermail/u-boot/2009-June/055110.html > Can you please apply this one? I've not seen it but I'll send other pull requests for this release :) Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver
On 17:34 Mon 08 Jun , Prafulla Wadaskar wrote: > This patch adds a NAND driver for the Marvell Kirkwood SoC's. > > Acked-by: Stefan Roese > Signed-off-by: Prafulla Wadaskar > --- > Change log: > v2: updated as per feedback for v1 (cosmetic change) Scott what is status for you? Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
