Re: [U-Boot] [PATCH v2 11/15] dm: sunxi: Linksprite_pcDuino3: Correct polarity of MMC card detect

[Simon Glass]

Hi Maxime,

On 5 July 2017 at 08:43, Maxime Ripard  wrote:
> Hi,
>
> On Tue, Jul 04, 2017 at 01:31:28PM -0600, Simon Glass wrote:
>> This is shown as active high in the schematics[1], so fix it.
>>
>> [1] https://patchwork.ozlabs.org/patch/777890/
>>
>> Signed-off-by: Simon Glass 
>> Reported-by: Maxime Ripard 
>> ---
>>
>> Changes in v2:
>> - Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3
>>
>>  arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts 
>> b/arch/arm/dts/sun7i-a20-pcduino3.dts
>> index 1a8b39be1d..37b1e0ee9b 100644
>> --- a/arch/arm/dts/sun7i-a20-pcduino3.dts
>> +++ b/arch/arm/dts/sun7i-a20-pcduino3.dts
>> @@ -164,7 +164,7 @@
>>   pinctrl-0 = <_pins_a>, <_cd_pin_reference_design>;
>>   vmmc-supply = <_vcc3v3>;
>>   bus-width = <4>;
>> - cd-gpios = < 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */
>> + cd-gpios = < 7 1 GPIO_ACTIVE_LOW>; /* PH1 */
>
> Hmmm, are you sure? At least your commit log says otherwise :)

The commit message is wrong, unfortunately. The schematics suggest it
is active low and it does seem to work with this setting.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 11/15] dm: sunxi: Linksprite_pcDuino3: Correct polarity of MMC card detect

[Maxime Ripard]

Hi,

On Tue, Jul 04, 2017 at 01:31:28PM -0600, Simon Glass wrote:
> This is shown as active high in the schematics[1], so fix it.
> 
> [1] https://patchwork.ozlabs.org/patch/777890/
> 
> Signed-off-by: Simon Glass 
> Reported-by: Maxime Ripard 
> ---
> 
> Changes in v2:
> - Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3
> 
>  arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts 
> b/arch/arm/dts/sun7i-a20-pcduino3.dts
> index 1a8b39be1d..37b1e0ee9b 100644
> --- a/arch/arm/dts/sun7i-a20-pcduino3.dts
> +++ b/arch/arm/dts/sun7i-a20-pcduino3.dts
> @@ -164,7 +164,7 @@
>   pinctrl-0 = <_pins_a>, <_cd_pin_reference_design>;
>   vmmc-supply = <_vcc3v3>;
>   bus-width = <4>;
> - cd-gpios = < 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */
> + cd-gpios = < 7 1 GPIO_ACTIVE_LOW>; /* PH1 */

Hmmm, are you sure? At least your commit log says otherwise :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 11/15] dm: sunxi: Linksprite_pcDuino3: Correct polarity of MMC card detect

[Simon Glass]

This is shown as active high in the schematics[1], so fix it.

[1] https://patchwork.ozlabs.org/patch/777890/

Signed-off-by: Simon Glass 
Reported-by: Maxime Ripard 
---

Changes in v2:
- Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3

 arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts 
b/arch/arm/dts/sun7i-a20-pcduino3.dts
index 1a8b39be1d..37b1e0ee9b 100644
--- a/arch/arm/dts/sun7i-a20-pcduino3.dts
+++ b/arch/arm/dts/sun7i-a20-pcduino3.dts
@@ -164,7 +164,7 @@
pinctrl-0 = <_pins_a>, <_cd_pin_reference_design>;
vmmc-supply = <_vcc3v3>;
bus-width = <4>;
-   cd-gpios = < 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */
+   cd-gpios = < 7 1 GPIO_ACTIVE_LOW>; /* PH1 */
cd-inverted;
status = "okay";
 };
-- 
2.13.2.725.g09c95d1e9-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot