Re: [U-Boot] [PATCH v7 3/3] MIPS: JZ4740: Add qi_lb60 board support

2011-10-06 Thread Wolfgang Denk
Dear Shinya Kuribayashi,

In message 4e886da5.1010...@pobox.com you wrote:
 From: Xiangfu Liu xian...@openmobilefree.net
 Date: Fri, 19 Aug 2011 14:35:29 +0800
 
 Add support for the qi_lb60 (a.k.a QI Ben NanoNote) clamshell device
 from Qi hardware:
 
 http://en.qi-hardware.com/wiki/Ben_NanoNote
 http://en.qi-hardware.com/wiki/Main_Page
 http://en.wikipedia.org/wiki/Qi_hardware
 
 This Jz4740-based clamshell device does not use NOR flash to boot.
 The initial bring-up assumes that U-Boot is directly loaded into SDRAM
 using USB boot tool, and starts from 0x8010.
 
 About USB boot tool
 ---
 
 Jz4740 is one of the XBurst processors with USB boot functionality
 supported.  The CPU can boot from a small ROM in the LSI, initialize
 CPU and USB module, then wait for USB commands from the USB host.
 We can send 8 KB binary data to the CPU cache using USB boot tool.
 
 USB boot tool is available to the public at Ingenic website.  Also
 there is an alternative Debian package named xburst-tools.
 
 Signed-off-by: Xiangfu Liu xian...@openmobilefree.net
 Acked-by: Daniel z...@ingenic.cn
 Signed-off-by: Shinya Kuribayashi skuri...@pobox.com
 ---
 
 Changes since v6:
 
 * nanonote.h config files is folded into qi_lb60.h
 
 * Following configs are deleted:
   CONFIG_SYS_64BIT_VSPRINTF
   CONFIG_NANDBOOT_CFG
   CONFIG_QI_LB60
 
  MAINTAINERS |4 +
  MAKEALL |4 +-
  board/qi/qi_lb60/Makefile   |   45 +
  board/qi/qi_lb60/config.mk  |   31 +++
  board/qi/qi_lb60/qi_lb60.c  |  104 +
  board/qi/qi_lb60/u-boot.lds |   61 +
  boards.cfg  |1 +
  include/configs/qi_lb60.h   |  210 
 +++
  8 files changed, 459 insertions(+), 1 deletions(-)
  create mode 100644 board/qi/qi_lb60/Makefile
  create mode 100644 board/qi/qi_lb60/config.mk
  create mode 100644 board/qi/qi_lb60/qi_lb60.c
  create mode 100644 board/qi/qi_lb60/u-boot.lds
  create mode 100644 include/configs/qi_lb60.h

Checkpatch says:

total: 1 errors, 12 warnings, 478 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You humans have that emotional need  to  express  gratitude.  You're
welcome, I believe, is the correct response.
-- Spock, Bread and Circuses, stardate 4041.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v7 3/3] MIPS: JZ4740: Add qi_lb60 board support

2011-10-02 Thread Shinya Kuribayashi
From: Xiangfu Liu xian...@openmobilefree.net
Date: Fri, 19 Aug 2011 14:35:29 +0800

Add support for the qi_lb60 (a.k.a QI Ben NanoNote) clamshell device
from Qi hardware:

http://en.qi-hardware.com/wiki/Ben_NanoNote
http://en.qi-hardware.com/wiki/Main_Page
http://en.wikipedia.org/wiki/Qi_hardware

This Jz4740-based clamshell device does not use NOR flash to boot.
The initial bring-up assumes that U-Boot is directly loaded into SDRAM
using USB boot tool, and starts from 0x8010.

About USB boot tool
---

Jz4740 is one of the XBurst processors with USB boot functionality
supported.  The CPU can boot from a small ROM in the LSI, initialize
CPU and USB module, then wait for USB commands from the USB host.
We can send 8 KB binary data to the CPU cache using USB boot tool.

USB boot tool is available to the public at Ingenic website.  Also
there is an alternative Debian package named xburst-tools.

Signed-off-by: Xiangfu Liu xian...@openmobilefree.net
Acked-by: Daniel z...@ingenic.cn
Signed-off-by: Shinya Kuribayashi skuri...@pobox.com
---

Changes since v6:

* nanonote.h config files is folded into qi_lb60.h

* Following configs are deleted:
  CONFIG_SYS_64BIT_VSPRINTF
  CONFIG_NANDBOOT_CFG
  CONFIG_QI_LB60

 MAINTAINERS |4 +
 MAKEALL |4 +-
 board/qi/qi_lb60/Makefile   |   45 +
 board/qi/qi_lb60/config.mk  |   31 +++
 board/qi/qi_lb60/qi_lb60.c  |  104 +
 board/qi/qi_lb60/u-boot.lds |   61 +
 boards.cfg  |1 +
 include/configs/qi_lb60.h   |  210 +++
 8 files changed, 459 insertions(+), 1 deletions(-)
 create mode 100644 board/qi/qi_lb60/Makefile
 create mode 100644 board/qi/qi_lb60/config.mk
 create mode 100644 board/qi/qi_lb60/qi_lb60.c
 create mode 100644 board/qi/qi_lb60/u-boot.lds
 create mode 100644 include/configs/qi_lb60.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 3ab38fa..bb95e6d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -928,6 +928,10 @@ Stefan Roese s...@denx.de
 
vct_xxx MIPS32 4Kc
 
+Xiangfu Liu xian...@openmobilefree.net
+
+   qi_lb60 MIPS32 (XBurst Jz4740 SoC)
+
 #
 # Nios-II Systems: #
 #  #
diff --git a/MAKEALL b/MAKEALL
index 4d18c11..f57d47d 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -400,7 +400,9 @@ LIST_mips= \
 ## MIPS Systems(little endian)
 #
 
-LIST_mips4kc_el=
+LIST_mips4kc_el=  \
+   qi_lb60 \
+
 
 LIST_mips5kc_el=
 
diff --git a/board/qi/qi_lb60/Makefile b/board/qi/qi_lb60/Makefile
new file mode 100644
index 000..2f5b4be
--- /dev/null
+++ b/board/qi/qi_lb60/Makefile
@@ -0,0 +1,45 @@
+#
+# (C) Copyright 2006
+# Ingenic Semiconductor, jl...@ingenic.cn
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).o
+
+COBJS  := $(BOARD).o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(SOBJS) $(COBJS))
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS)
+   $(call cmd_link_o_target, $(OBJS))
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak $(obj).depend
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/qi/qi_lb60/config.mk b/board/qi/qi_lb60/config.mk
new file mode 100644
index 000..858e6a2
--- /dev/null
+++ b/board/qi/qi_lb60/config.mk
@@ -0,0 +1,31 @@
+#
+# (C) Copyright 2006 Qi Hardware, Inc.
+# Author: Xiangfu Liu xiangf...@gmail.com
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the