Re: [U-Boot] [RFC PATCH 04/21] ARM: tegra: collect SoC sources into mach-tegra
On Wed, Jan 28, 2015 at 11:11:46AM +0900, Masahiro Yamada wrote: > Hi Stephen, > > > On Mon, 26 Jan 2015 10:40:57 -0700 > Stephen Warren wrote: > > > On 01/24/2015 11:11 PM, Masahiro Yamada wrote: > > > This commit moves files as follows: > > > > > > arch/arm/cpu/arm720t/tegra20/* -> arch/arm/mach-tegra/tegra20/* > > > arch/arm/cpu/arm720t/tegra30/* -> arch/arm/mach-tegra/tegra30/* > > ... > > > > Bikeshed: I know that this matches what the Linux kernel has for > > 32-bit ARM, but I've always disliked using the word "machine" to > > describe an SoC. Would just "tegra" or "soc-tegra" be better than > > "mach-tegra"? Feel free to entirely ignore this though; I don't feel > > too strongly. > > In hindsight, arch/arm/soc-* would have been clearer than arch/arm/mach-*. > However, we are already familiar with this directory name convention, > so "machine" looks OK to me. > > > Oh and one more thing: We're starting to work on 64-bit Tegra > > support in the Linux kernel. A fair amount of the code moved by this > > patch is likely to apply on both 32-bit and 64-bit Tegra. Will > > arch/arm support 64-bit within U-Boot, or will there be a separate > > directory for 32- and 64-bit ARM? If so, should this code all be > > moved to something more like soc/tegra/... or drivers/tegra/... or > > drivers/soc/tegra/... or ... so it can be shared between the > > architectures? > > We had a hot discussion when aarch64 support was introduced to U-Boot. > > Finally, the community chose arch/arm/cpu/armv8/ rather than arch/arm64/, > i.e. single-arch-directory. And I suspect that at some point we'll also end up moving things from arch/ into drivers/soc/ to mirror the kernel as well. But I still think arch/arm for both is the right direction :) -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 04/21] ARM: tegra: collect SoC sources into mach-tegra
On Mon 2015-01-26 10:40:57, Stephen Warren wrote: > On 01/24/2015 11:11 PM, Masahiro Yamada wrote: > >This commit moves files as follows: > > > > arch/arm/cpu/arm720t/tegra20/* -> arch/arm/mach-tegra/tegra20/* > > arch/arm/cpu/arm720t/tegra30/* -> arch/arm/mach-tegra/tegra30/* > ... > > Bikeshed: I know that this matches what the Linux kernel has for 32-bit ARM, > but I've always disliked using the word "machine" to describe an SoC. Would > just "tegra" or "soc-tegra" be better than "mach-tegra"? Feel free to > entirely ignore this though; I don't feel too strongly. Please keep it consistent with Linux. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 04/21] ARM: tegra: collect SoC sources into mach-tegra
Hi Stephen, On Mon, 26 Jan 2015 10:40:57 -0700 Stephen Warren wrote: > On 01/24/2015 11:11 PM, Masahiro Yamada wrote: > > This commit moves files as follows: > > > > arch/arm/cpu/arm720t/tegra20/* -> arch/arm/mach-tegra/tegra20/* > > arch/arm/cpu/arm720t/tegra30/* -> arch/arm/mach-tegra/tegra30/* > ... > > Bikeshed: I know that this matches what the Linux kernel has for 32-bit ARM, > but I've always disliked using the word "machine" to describe an SoC. Would > just "tegra" or "soc-tegra" be better than "mach-tegra"? Feel free to > entirely ignore this though; I don't feel too strongly. In hindsight, arch/arm/soc-* would have been clearer than arch/arm/mach-*. However, we are already familiar with this directory name convention, so "machine" looks OK to me. > > Oh and one more thing: We're starting to work on 64-bit Tegra support in the > Linux kernel. A fair amount of the code moved by this patch is likely to > apply on both 32-bit and 64-bit Tegra. Will arch/arm support 64-bit within > U-Boot, or will there be a separate directory for 32- and 64-bit ARM? If so, > should this code all be moved to something more like soc/tegra/... or > drivers/tegra/... or drivers/soc/tegra/... or ... so it can be shared between > the architectures? We had a hot discussion when aarch64 support was introduced to U-Boot. Finally, the community chose arch/arm/cpu/armv8/ rather than arch/arm64/, i.e. single-arch-directory. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 04/21] ARM: tegra: collect SoC sources into mach-tegra
On 01/24/2015 11:11 PM, Masahiro Yamada wrote: This commit moves files as follows: arch/arm/cpu/arm720t/tegra20/* -> arch/arm/mach-tegra/tegra20/* arch/arm/cpu/arm720t/tegra30/* -> arch/arm/mach-tegra/tegra30/* ... Bikeshed: I know that this matches what the Linux kernel has for 32-bit ARM, but I've always disliked using the word "machine" to describe an SoC. Would just "tegra" or "soc-tegra" be better than "mach-tegra"? Feel free to entirely ignore this though; I don't feel too strongly. Oh and one more thing: We're starting to work on 64-bit Tegra support in the Linux kernel. A fair amount of the code moved by this patch is likely to apply on both 32-bit and 64-bit Tegra. Will arch/arm support 64-bit within U-Boot, or will there be a separate directory for 32- and 64-bit ARM? If so, should this code all be moved to something more like soc/tegra/... or drivers/tegra/... or drivers/soc/tegra/... or ... so it can be shared between the architectures? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 04/21] ARM: tegra: collect SoC sources into mach-tegra
Hi Masahiro, On 24 January 2015 at 23:11, Masahiro Yamada wrote: > This commit moves files as follows: > > arch/arm/cpu/arm720t/tegra20/* -> arch/arm/mach-tegra/tegra20/* > arch/arm/cpu/arm720t/tegra30/* -> arch/arm/mach-tegra/tegra30/* > arch/arm/cpu/arm720t/tegra114/* -> arch/arm/mach-tegra/tegra114/* > arch/arm/cpu/arm720t/tegra124* -> arch/arm/mach-tegra/tegra124/* > arch/arm/cpu/arm720t/tegra-common/* -> arch/arm/mach-tegra/* > arch/arm/cpu/armv7/tegra20/*-> arch/arm/mach-tegra/tegra20/* > arch/arm/cpu/armv7/tegra30/*-> arch/arm/mach-tegra/tegra30/* > arch/arm/cpu/armv7/tegra114/* -> arch/arm/mach-tegra/tegra114/* > arch/arm/cpu/armv7/tegra124/* -> arch/arm/mach-tegra/tegra124/* > arch/arm/cpu/armv7/tegra-common/* -> arch/arm/mach-tegra/* > arch/arm/cpu/tegra20-common/* -> arch/arm/mach-tegra/tegra20/* > arch/arm/cpu/tegra30-common/* -> arch/arm/mach-tegra/tegra30/* > arch/arm/cpu/tegra114-common/* -> arch/arm/mach-tegra/tegra114/* > arch/arm/cpu/tegra124-common/* -> arch/arm/mach-tegra/tegra124/* > arch/arm/cpu/tegra-common/* -> arch/arm/mach-tegra/* > > Signed-off-by: Masahiro Yamada > Cc: Stephen Warren > Cc: Tom Warren > Cc: Simon Glass Tested on nyan-big (yes I know this is just a build change but I couldn't resist) Tested-by: Simon Glass Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC PATCH 04/21] ARM: tegra: collect SoC sources into mach-tegra
This commit moves files as follows:
arch/arm/cpu/arm720t/tegra20/* -> arch/arm/mach-tegra/tegra20/*
arch/arm/cpu/arm720t/tegra30/* -> arch/arm/mach-tegra/tegra30/*
arch/arm/cpu/arm720t/tegra114/* -> arch/arm/mach-tegra/tegra114/*
arch/arm/cpu/arm720t/tegra124* -> arch/arm/mach-tegra/tegra124/*
arch/arm/cpu/arm720t/tegra-common/* -> arch/arm/mach-tegra/*
arch/arm/cpu/armv7/tegra20/*-> arch/arm/mach-tegra/tegra20/*
arch/arm/cpu/armv7/tegra30/*-> arch/arm/mach-tegra/tegra30/*
arch/arm/cpu/armv7/tegra114/* -> arch/arm/mach-tegra/tegra114/*
arch/arm/cpu/armv7/tegra124/* -> arch/arm/mach-tegra/tegra124/*
arch/arm/cpu/armv7/tegra-common/* -> arch/arm/mach-tegra/*
arch/arm/cpu/tegra20-common/* -> arch/arm/mach-tegra/tegra20/*
arch/arm/cpu/tegra30-common/* -> arch/arm/mach-tegra/tegra30/*
arch/arm/cpu/tegra114-common/* -> arch/arm/mach-tegra/tegra114/*
arch/arm/cpu/tegra124-common/* -> arch/arm/mach-tegra/tegra124/*
arch/arm/cpu/tegra-common/* -> arch/arm/mach-tegra/*
Signed-off-by: Masahiro Yamada
Cc: Stephen Warren
Cc: Tom Warren
Cc: Simon Glass
---
MAINTAINERS | 4 +---
arch/arm/Kconfig| 2 +-
arch/arm/Makefile | 2 ++
arch/arm/cpu/Makefile | 6 +-
arch/arm/cpu/arm720t/Makefile | 6 --
arch/arm/cpu/arm720t/tegra-common/Makefile | 11 ---
arch/arm/cpu/arm720t/tegra114/Makefile | 21 -
arch/arm/cpu/arm720t/tegra124/Makefile | 8
arch/arm/cpu/arm720t/tegra20/Makefile | 10 --
arch/arm/cpu/arm720t/tegra30/Makefile | 20
arch/arm/cpu/armv7/Makefile | 2 --
arch/arm/cpu/armv7/tegra-common/Makefile| 10 --
arch/arm/cpu/armv7/tegra20/Makefile | 11 ---
.../{cpu/armv7/tegra-common => mach-tegra}/Kconfig | 8
arch/arm/{cpu/tegra-common => mach-tegra}/Makefile | 12
arch/arm/{cpu/tegra-common => mach-tegra}/ap.c | 0
arch/arm/{cpu/tegra-common => mach-tegra}/board.c | 0
arch/arm/{cpu/tegra-common => mach-tegra}/cache.c | 0
arch/arm/{cpu/tegra-common => mach-tegra}/clock.c | 0
.../tegra-common => mach-tegra}/cmd_enterrcm.c | 0
.../{cpu/arm720t/tegra-common => mach-tegra}/cpu.c | 0
.../{cpu/arm720t/tegra-common => mach-tegra}/cpu.h | 0
.../tegra-common => mach-tegra}/lowlevel_init.S | 0
.../tegra-common => mach-tegra}/pinmux-common.c | 0
.../{cpu/tegra-common => mach-tegra}/powergate.c| 0
.../{cpu/arm720t/tegra-common => mach-tegra}/spl.c | 0
.../arm/{cpu/tegra-common => mach-tegra}/sys_info.c | 0
arch/arm/{cpu/armv7 => mach-tegra}/tegra114/Kconfig | 0
.../tegra114}/Makefile | 5 ++---
.../tegra114-common => mach-tegra/tegra114}/clock.c | 0
arch/arm/{cpu/arm720t => mach-tegra}/tegra114/cpu.c | 2 +-
.../tegra114}/funcmux.c | 0
.../tegra114}/pinmux.c | 0
arch/arm/{cpu/armv7 => mach-tegra}/tegra124/Kconfig | 0
.../tegra124}/Makefile | 2 ++
.../tegra124-common => mach-tegra/tegra124}/clock.c | 0
arch/arm/{cpu/arm720t => mach-tegra}/tegra124/cpu.c | 2 +-
.../tegra124}/funcmux.c | 0
.../tegra124}/pinmux.c | 0
.../tegra124}/xusb-padctl.c | 0
arch/arm/{cpu/armv7 => mach-tegra}/tegra20/Kconfig | 0
.../tegra20-common => mach-tegra/tegra20}/Makefile | 10 +++---
.../tegra20-common => mach-tegra/tegra20}/clock.c | 0
arch/arm/{cpu/arm720t => mach-tegra}/tegra20/cpu.c | 2 +-
.../tegra20-common => mach-tegra/tegra20}/crypto.c | 0
.../tegra20-common => mach-tegra/tegra20}/crypto.h | 0
.../arm/{cpu/armv7 => mach-tegra}/tegra20/display.c | 0
.../tegra20-common => mach-tegra/tegra20}/emc.c | 0
.../tegra20-common => mach-tegra/tegra20}/funcmux.c | 0
.../tegra20-common => mach-tegra/tegra20}/pinmux.c | 0
.../tegra20-common => mach-tegra/tegra20}/pmu.c | 0
arch/arm/{cpu/armv7 => mach-tegra}/tegra20/pwm.c| 0
.../tegra20}/warmboot.c | 0
.../tegra20}/warmboot_avp.c | 0
.../tegra20}/warmboot_avp.h | 0
arch/arm/{cpu/armv7 => mach-tegra}/tegra30/Kconfig | 0
.../tegra30-common => mach-tegra/tegra30}/Makefile | 5 ++---
.../tegra30-common => mach-tegra/tegra30}/clock.c | 0
arch/arm/{cpu/arm720t => mach-tegra}/tegra30/cpu.c | 2 +-
.../tegra30-common => mach-tegra/tegra30}/funcmux.c | 0
.../tegra30-common => mach-tegra/tegra30}/pinmux.c | 0
arch/arm/{cpu/tegra-common => mach-tegra}/vpr.c | 0
.../{cpu/tegra-common => mach-tegra}/xusb-padctl.c | 0
