Re: Aw: Re: Re: Re: Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 8:12 PM, Frank Wunderlich wrote: >> Gesendet: Freitag, 01. Mai 2020 um 20:08 Uhr >> Von: "Marek Vasut" >> It's a build failure, build it for versal_virt and see if the error is >> gone. Is it ? > > right, i reproduced it by these commands: > > ARCH=arm64 make xilinx_versal_virt_defconfig > CROSS_COMPILE=aarch64-linux-gnu- make > > and this build-error is gone in my tree Cool, then send V5 of the series, thanks.
Aw: Re: Re: Re: Re: [ANN] U-Boot v2020.07-rc1 released
> Gesendet: Freitag, 01. Mai 2020 um 20:08 Uhr > Von: "Marek Vasut" > It's a build failure, build it for versal_virt and see if the error is > gone. Is it ? right, i reproduced it by these commands: ARCH=arm64 make xilinx_versal_virt_defconfig CROSS_COMPILE=aarch64-linux-gnu- make and this build-error is gone in my tree
Re: Aw: Re: Re: Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 7:48 PM, Frank Wunderlich wrote:
Gesendet: Freitag, 01. Mai 2020 um 17:39 Uhr
Von: "Marek Vasut"
Build failed, please fix:
https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054
>
> could you try if all tests passing after this Patch?
>
> regards Frank
>
> commit 9c4a3633e92dbcd51aa60ff14693adc900e3c816
> Author: Frank Wunderlich
> Date: Fri May 1 19:32:12 2020 +0200
>
> fix build-error for xilinx-board caused by xhci-Patches
>
> Fixes: "usb: dwc3: use the phy bulk API to get phys"
>
> diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
> index 9fcfa39d4b..563db1a426 100644
> --- a/drivers/usb/host/xhci-dwc3.c
> +++ b/drivers/usb/host/xhci-dwc3.c
> @@ -19,8 +19,7 @@
> #include
>
> struct xhci_dwc3_platdata {
> - struct phy *usb_phys;
> - int num_phys;
> + struct phy_bulk *usb_phys;
> };
>
> void dwc3_set_mode(struct dwc3 *dwc3_reg, u32 mode)
> @@ -125,7 +124,7 @@ static int xhci_dwc3_probe(struct udevice *dev)
> hcor = (struct xhci_hcor *)((uintptr_t)hccr +
> HC_LENGTH(xhci_readl(&(hccr)->cr_capbase)));
>
> - ret = dwc3_setup_phy(dev, >usb_phys, >num_phys);
> + ret = dwc3_setup_phy(dev, plat->usb_phys);
> if (ret && (ret != -ENOTSUPP))
> return ret;
>
> @@ -168,7 +167,7 @@ static int xhci_dwc3_remove(struct udevice *dev)
> {
> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
>
> - dwc3_shutdown_phy(dev, plat->usb_phys, plat->num_phys);
> + dwc3_shutdown_phy(dev, plat->usb_phys);
>
> return xhci_deregister(dev);
> }
It's a build failure, build it for versal_virt and see if the error is
gone. Is it ?
Aw: Re: Re: Re: [ANN] U-Boot v2020.07-rc1 released
> >> Gesendet: Freitag, 01. Mai 2020 um 17:39 Uhr
> >> Von: "Marek Vasut"
> >> Build failed, please fix:
> >> https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054
could you try if all tests passing after this Patch?
regards Frank
commit 9c4a3633e92dbcd51aa60ff14693adc900e3c816
Author: Frank Wunderlich
Date: Fri May 1 19:32:12 2020 +0200
fix build-error for xilinx-board caused by xhci-Patches
Fixes: "usb: dwc3: use the phy bulk API to get phys"
diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
index 9fcfa39d4b..563db1a426 100644
--- a/drivers/usb/host/xhci-dwc3.c
+++ b/drivers/usb/host/xhci-dwc3.c
@@ -19,8 +19,7 @@
#include
struct xhci_dwc3_platdata {
- struct phy *usb_phys;
- int num_phys;
+ struct phy_bulk *usb_phys;
};
void dwc3_set_mode(struct dwc3 *dwc3_reg, u32 mode)
@@ -125,7 +124,7 @@ static int xhci_dwc3_probe(struct udevice *dev)
hcor = (struct xhci_hcor *)((uintptr_t)hccr +
HC_LENGTH(xhci_readl(&(hccr)->cr_capbase)));
- ret = dwc3_setup_phy(dev, >usb_phys, >num_phys);
+ ret = dwc3_setup_phy(dev, plat->usb_phys);
if (ret && (ret != -ENOTSUPP))
return ret;
@@ -168,7 +167,7 @@ static int xhci_dwc3_remove(struct udevice *dev)
{
struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
- dwc3_shutdown_phy(dev, plat->usb_phys, plat->num_phys);
+ dwc3_shutdown_phy(dev, plat->usb_phys);
return xhci_deregister(dev);
}
Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 5:53 PM, Anatolij Gustschin wrote: > Hi Marek, > > On Fri, 1 May 2020 17:39:27 +0200 > Marek Vasut ma...@denx.de wrote: > ... >> >> Build failed, please fix: >> https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054 > > This link is not accessible for public, could you please check the > CI/CD permission settings? Should be under gitlab project settings, > CI/CD > General pipelines > Public pipelines checkbox. Thanks! Fixed, thanks.
Re: Aw: Re: Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 5:46 PM, Frank Wunderlich wrote: > this should go to author of Patch ;) > > regards Frank > >> Gesendet: Freitag, 01. Mai 2020 um 17:39 Uhr >> Von: "Marek Vasut" >> Build failed, please fix: >> https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054 Thanks for CCing the author. Again, please stop top-posting.
Re: [ANN] U-Boot v2020.07-rc1 released
Hi Marek, On Fri, 1 May 2020 17:39:27 +0200 Marek Vasut ma...@denx.de wrote: ... > > Build failed, please fix: > https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054 This link is not accessible for public, could you please check the CI/CD permission settings? Should be under gitlab project settings, CI/CD > General pipelines > Public pipelines checkbox. Thanks! -- Anatolij
Aw: Re: Re: [ANN] U-Boot v2020.07-rc1 released
this should go to author of Patch ;) regards Frank > Gesendet: Freitag, 01. Mai 2020 um 17:39 Uhr > Von: "Marek Vasut" > Build failed, please fix: > https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054
Re: Aw: Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 5:14 PM, Marek Vasut wrote: > On 5/1/20 3:49 PM, Frank Wunderlich wrote: >> imho last discussion this (v7 part 3): >> https://patchwork.ozlabs.org/project/uboot/patch/1588140330-9910-4-git-send-email-chunfeng@mediatek.com/ >> that looks resolved for me > > Please stop top-posting. > >> regards Frank >> >> >>> Gesendet: Freitag, 01. Mai 2020 um 11:18 Uhr >>> Von: "Marek Vasut" >>> An: "Tom Rini" , "Frank Wunderlich" >>> >>> Cc: u-boot@lists.denx.de >>> Betreff: Re: [ANN] U-Boot v2020.07-rc1 released >>> >>> On 5/1/20 12:18 AM, Tom Rini wrote: >>>> On Wed, Apr 29, 2020 at 03:24:28PM +0200, Frank Wunderlich wrote: >>>>> Hi, >>>>> >>>>> I hope the mtk xhci series can be merged because further xhci-development >>>>> for mt7622/23 depends on this. >>>> >>>> If Marek is happy with the code, I won't object. >>> >>> There is still some ongoing discussion in v7, isn't there ? >>> > > Applied. Build failed, please fix: https://gitlab.denx.de/u-boot/custodians/u-boot-usb/pipelines/3054
Re: Aw: Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 3:49 PM, Frank Wunderlich wrote: > imho last discussion this (v7 part 3): > https://patchwork.ozlabs.org/project/uboot/patch/1588140330-9910-4-git-send-email-chunfeng@mediatek.com/ > that looks resolved for me Please stop top-posting. > regards Frank > > >> Gesendet: Freitag, 01. Mai 2020 um 11:18 Uhr >> Von: "Marek Vasut" >> An: "Tom Rini" , "Frank Wunderlich" >> >> Cc: u-boot@lists.denx.de >> Betreff: Re: [ANN] U-Boot v2020.07-rc1 released >> >> On 5/1/20 12:18 AM, Tom Rini wrote: >>> On Wed, Apr 29, 2020 at 03:24:28PM +0200, Frank Wunderlich wrote: >>>> Hi, >>>> >>>> I hope the mtk xhci series can be merged because further xhci-development >>>> for mt7622/23 depends on this. >>> >>> If Marek is happy with the code, I won't object. >> >> There is still some ongoing discussion in v7, isn't there ? >> Applied.
Aw: Re: [ANN] U-Boot v2020.07-rc1 released
imho last discussion this (v7 part 3): https://patchwork.ozlabs.org/project/uboot/patch/1588140330-9910-4-git-send-email-chunfeng@mediatek.com/ that looks resolved for me regards Frank > Gesendet: Freitag, 01. Mai 2020 um 11:18 Uhr > Von: "Marek Vasut" > An: "Tom Rini" , "Frank Wunderlich" > > Cc: u-boot@lists.denx.de > Betreff: Re: [ANN] U-Boot v2020.07-rc1 released > > On 5/1/20 12:18 AM, Tom Rini wrote: > > On Wed, Apr 29, 2020 at 03:24:28PM +0200, Frank Wunderlich wrote: > >> Hi, > >> > >> I hope the mtk xhci series can be merged because further xhci-development > >> for mt7622/23 depends on this. > > > > If Marek is happy with the code, I won't object. > > There is still some ongoing discussion in v7, isn't there ? >
Re: [ANN] U-Boot v2020.07-rc1 released
On 5/1/20 12:18 AM, Tom Rini wrote: > On Wed, Apr 29, 2020 at 03:24:28PM +0200, Frank Wunderlich wrote: >> Hi, >> >> I hope the mtk xhci series can be merged because further xhci-development >> for mt7622/23 depends on this. > > If Marek is happy with the code, I won't object. There is still some ongoing discussion in v7, isn't there ?
Re: [ANN] U-Boot v2020.07-rc1 released
On Wed, Apr 29, 2020 at 03:24:28PM +0200, Frank Wunderlich wrote: > Hi, > > I hope the mtk xhci series can be merged because further xhci-development for > mt7622/23 depends on this. If Marek is happy with the code, I won't object. > > Regards Frank > > Am 29. April 2020 14:49:05 MESZ schrieb Tom Rini : > >[aside, I wrote this, tagged, pushed and then forgot to send this last > >night] > > > >Hey all, > > > >Once again, it's the day after release day, and here is v2020.07-rc1. > >I > >wanted to see the DM PR issue sorted out before making -rc1 and that > >was > >this morning. And then a few more small PRs came in so I tested those, > >and here we are. As I said with the v2020.04 release, since that was > >delayed I will be a little more open to changes than I would normally, > >for a short while. > > > >In terms of a changelog, > >git log --merges v2020.04..v2020.07-rc1 > >contains what I've pulled but as always, better PR messages and tags > >will provide better results here. > > > >I'm planning on doing the standard every other Monday -rc releases from > >here on out and with a release on July 6th. Thanks all! -- Tom signature.asc Description: PGP signature
Re: [ANN] U-Boot v2020.07-rc1 released
Hi, I hope the mtk xhci series can be merged because further xhci-development for mt7622/23 depends on this. Regards Frank Am 29. April 2020 14:49:05 MESZ schrieb Tom Rini : >[aside, I wrote this, tagged, pushed and then forgot to send this last >night] > >Hey all, > >Once again, it's the day after release day, and here is v2020.07-rc1. >I >wanted to see the DM PR issue sorted out before making -rc1 and that >was >this morning. And then a few more small PRs came in so I tested those, >and here we are. As I said with the v2020.04 release, since that was >delayed I will be a little more open to changes than I would normally, >for a short while. > >In terms of a changelog, >git log --merges v2020.04..v2020.07-rc1 >contains what I've pulled but as always, better PR messages and tags >will provide better results here. > >I'm planning on doing the standard every other Monday -rc releases from >here on out and with a release on July 6th. Thanks all!
