Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes
On Wed, Mar 1, 2023 at 6:49 PM Kever Yang wrote: Hi Kever, > So I have take this patch set, and we can improve later when kernel have > a version and we have a better solution for U-Boot. My concern is that dts will be overwritten during the next dts sync with the kernel. U-boot specific properties should be moved into an appropriate -u-boot.dtsi file. Regards, Vasily
Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes
Hi Quentin, Vasily, On 2023/2/28 19:26, Quentin Schulz wrote: Hi Vasily, On 2/23/23 22:12, Vasily Khoruzhick wrote: On Mon, Feb 13, 2023 at 2:30 PM Chris Morgan wrote: From: Chris Morgan Add gpio-ranges property to GPIO nodes so that the bank ID can be correctly derived for each GPIO bank. Should not it be merged into linux first? Otherwise it will be overwritten during the next dts sync with linux. Considering that Linux maintainers have just rejected this implementation, yes we should wait on it being merged before supporting it in U-Boot :) There are still some drivers are different with kernel, eg. pinctrl&GPIO, and clock driver and etc, and kernel driver also changes. Since the gpio bank support issue has been a period, I would like to take one version driver at least can fix it and make U-Boot work with new kernel dts and new device. The U-Boot only use small set of the devices, so we want to have a small enough but enough for U-Boot version driver. So I have take this patch set, and we can improve later when kernel have a version and we have a better solution for U-Boot. Thanks, - Kever Cheers, Quentin
Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes
Hi Vasily, On 2/23/23 22:12, Vasily Khoruzhick wrote: On Mon, Feb 13, 2023 at 2:30 PM Chris Morgan wrote: From: Chris Morgan Add gpio-ranges property to GPIO nodes so that the bank ID can be correctly derived for each GPIO bank. Should not it be merged into linux first? Otherwise it will be overwritten during the next dts sync with linux. Considering that Linux maintainers have just rejected this implementation, yes we should wait on it being merged before supporting it in U-Boot :) Cheers, Quentin
Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes
On Mon, Feb 13, 2023 at 2:30 PM Chris Morgan wrote: > > From: Chris Morgan > > Add gpio-ranges property to GPIO nodes so that the bank ID can > be correctly derived for each GPIO bank. Should not it be merged into linux first? Otherwise it will be overwritten during the next dts sync with linux. > Signed-off-by: Chris Morgan > --- > arch/arm/dts/rk356x.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/dts/rk356x.dtsi b/arch/arm/dts/rk356x.dtsi > index 5706c3e24f..6492ace0de 100644 > --- a/arch/arm/dts/rk356x.dtsi > +++ b/arch/arm/dts/rk356x.dtsi > @@ -1806,6 +1806,7 @@ > interrupts = ; > clocks = <&pmucru PCLK_GPIO0>, <&pmucru DBCLK_GPIO0>; > gpio-controller; > + gpio-ranges = <&pinctrl 0 0 32>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > @@ -1817,6 +1818,7 @@ > interrupts = ; > clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>; > gpio-controller; > + gpio-ranges = <&pinctrl 0 32 32>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > @@ -1828,6 +1830,7 @@ > interrupts = ; > clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>; > gpio-controller; > + gpio-ranges = <&pinctrl 0 64 32>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > @@ -1839,6 +1842,7 @@ > interrupts = ; > clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>; > gpio-controller; > + gpio-ranges = <&pinctrl 0 96 32>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > @@ -1850,6 +1854,7 @@ > interrupts = ; > clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>; > gpio-controller; > + gpio-ranges = <&pinctrl 0 128 32>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > -- > 2.34.1 >
Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan Add gpio-ranges property to GPIO nodes so that the bank ID can be correctly derived for each GPIO bank. Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/rk356x.dtsi b/arch/arm/dts/rk356x.dtsi index 5706c3e24f..6492ace0de 100644 --- a/arch/arm/dts/rk356x.dtsi +++ b/arch/arm/dts/rk356x.dtsi @@ -1806,6 +1806,7 @@ interrupts = ; clocks = <&pmucru PCLK_GPIO0>, <&pmucru DBCLK_GPIO0>; gpio-controller; + gpio-ranges = <&pinctrl 0 0 32>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -1817,6 +1818,7 @@ interrupts = ; clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>; gpio-controller; + gpio-ranges = <&pinctrl 0 32 32>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -1828,6 +1830,7 @@ interrupts = ; clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>; gpio-controller; + gpio-ranges = <&pinctrl 0 64 32>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -1839,6 +1842,7 @@ interrupts = ; clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>; gpio-controller; + gpio-ranges = <&pinctrl 0 96 32>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; @@ -1850,6 +1854,7 @@ interrupts = ; clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>; gpio-controller; + gpio-ranges = <&pinctrl 0 128 32>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>;
