Re: [U-Boot] [PATCH] TI DaVinci DM646x: Adding initial support for DM6467 EVM
s-paul...@ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com This patch adds the initial support for DM6467 EVM. Signed-off-by: Sandeep Paulraj s-paul...@ti.com --- Changes since the initial version - Add entries to MAKEALL and MAINTAINERS as suggested by Tom - Fix whitespace issues as pointed out by Tom There are multiple flavours of the DM646x. The newest DM646x SOC can operate at 1 GHz. The DM6467 EVM from Spectrum Digital can be used for both speed grades of the DM646x SOC . The only change on the EVM being an oscilator that operated at a higher frequency. The same board file will be used to support both SOC's. Support for this feature will be added as follow up patches. This is useful information that should be included in the commit log. Please add at least.. There are multiple flavours of the DM646x. The newest DM646x SOC can operate at 1 GHz. The DM6467 EVM from Spectrum Digital can be used for both speed grades of the DM646x SOC . The only change on the EVM being an oscilator that operated at a higher frequency. The same board file will be used to support both SOC's. Ack-ed Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] TI DaVinci DM646x: Adding initial support for DM6467 EVM
s-paul...@ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com This patch adds the initial support for DM6467 EVM. Other features like NET and NAND support will be added as follow up patches. Signed-off-by: Sandeep Paulraj s-paul...@ti.com --- There are multiple flavours of the DM646x. The newest DM646x SOC can operate at 1 GHz. The DM6467 EVM from Spectrum Digital can be used for both speed grades of the DM646x SOC . The only change on the EVM being an oscilator that operated at a higher frequency. The same board file will be used to support both SOC's. Support for this feature will be added as follow up patches. Patches will also be sent to enable EMAC, NAND and other features. Makefile|3 + Needs an addition to MAKEALL and optionally Maintainers board/davinci/dm6467evm/Makefile| 52 ++ board/davinci/dm6467evm/config.mk |2 + board/davinci/dm6467evm/dm6467evm.c | 31 include/configs/davinci_dm6467evm.h | 131 +++ 5 files changed, 219 insertions(+), 0 deletions(-) create mode 100644 board/davinci/dm6467evm/Makefile create mode 100644 board/davinci/dm6467evm/config.mk create mode 100644 board/davinci/dm6467evm/dm6467evm.c create mode 100644 include/configs/davinci_dm6467evm.h diff --git a/Makefile b/Makefile index 0b61d05..dc797b0 100644 --- a/Makefile +++ b/Makefile @@ -2962,6 +2962,9 @@ davinci_dm355evm_config : unconfig davinci_dm365evm_config :unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs dm365evm davinci davinci +davinci_dm6467evm_config : unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs dm6467evm davinci davinci + imx27lite_config:unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs imx27lite logicpd mx27 diff --git a/board/davinci/dm6467evm/Makefile b/board/davinci/dm6467evm/Makefile new file mode 100644 index 000..26b0705 --- /dev/null +++ b/board/davinci/dm6467evm/Makefile @@ -0,0 +1,52 @@ +# +# (C) Copyright 2000, 2001, 2002 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# Copyright (C) 2007 Sergey Kubushyn k...@koi8.net +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS:= $(BOARD).o +SOBJS:= + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# +# This is for $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/davinci/dm6467evm/config.mk b/board/davinci/dm6467evm/config.mk new file mode 100644 index 000..ca801c2 --- /dev/null +++ b/board/davinci/dm6467evm/config.mk @@ -0,0 +1,2 @@ +#Provide at least 16MB spacing between us and the Linux Kernel image +TEXT_BASE = 0x8108 diff --git a/board/davinci/dm6467evm/dm6467evm.c b/board/davinci/dm6467evm/dm6467evm.c new file mode 100644 index 000..9605818 --- /dev/null +++ b/board/davinci/dm6467evm/dm6467evm.c @@ -0,0 +1,31 @@ +/* + * Copyright (C) 2009 Texas Instruments Incorporated + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA
Re: [U-Boot] [PATCH] TI DaVinci DM646x: Adding initial support for DM6467 EVM
Patches will also be sent to enable EMAC, NAND and other features. Makefile|3 + Needs an addition to MAKEALL and optionally Maintainers Ok I will add diff --git a/include/configs/davinci_dm6467evm.h b/include/configs/davinci_dm6467evm.h new file mode 100644 index 000..c23d533 --- /dev/null +++ b/include/configs/davinci_dm6467evm.h @@ -0,0 +1,131 @@ +/* + * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/ Above copyright did not have the http. You should be consistent. Add or remove, your choice. Ok I will rectify + +/* SoC Configuration */ +#define CONFIG_ARM926EJS /* arm926ejs CPU */ +#define CONFIG_SYS_TIMERBASE 0x01c21400 /* use timer 0 */ Is there a logical register #define you could use instead of the magic number? I can include the hardware.h and get the value from there, but the way the hardware.h for DaVinci has evolved over the years, including it in the config will result in compilation failure. I'll add this to my TODO list and send in a patch to clean up for all DaVinci SOC's the moment I get some free cycles. + +/* I2C Configuration */ +#define CONFIG_HARD_I2C +#define CONFIG_DRIVER_DAVINCI_I2C +#define CONFIG_SYS_I2C_SPEED 8 This speed is unusual. The same speed has been used with a slightly older version of U-boot and has worked fine davinci_sonata.h has a comment that it had a silicon bug with 100k Could the same comment be applied here ? I don't believe so +/* U-Boot general configuration */ +#undef CONFIG_USE_IRQ /* No IRQ/FIQ in U-Boot */ There is a TAB between #undef and CONFIG_USB_IRQ. Other undef's here use a space. Ok will fix. +#define CONFIG_BOOTDELAY 3 +#define CONFIG_BOOTFILEuImage/* Boot file name */ +#define CONFIG_SYS_PROMPT DM6467 EVM /* Monitor Command Prompt */ +#define CONFIG_SYS_CBSIZE 1024/* Console I/O Buffer Size */ +#define CONFIG_SYS_PBSIZE \ + (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_MAXARGS 16 +#define CONFIG_VERSION_VARIABLE +#define CONFIG_AUTO_COMPLETE +#define CONFIG_SYS_HUSH_PARSER +#define CONFIG_SYS_PROMPT_HUSH_PS2 +#define CONFIG_CMDLINE_EDITING +#define CONFIG_SYS_LONGHELP +#define CONFIG_CRC32_VERIFY +#define CONFIG_MX_CYCLIC +#define CONFIG_BOOTCOMMAND source 0x8208; dhcp; bootm 3 spaces at the end of CONFIG_BOOTCOMMAND can be removed. Will fix Tom Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] TI DaVinci DM646x: Adding initial support for DM6467 EVM
Paulraj, Sandeep wrote: snip + +/* SoC Configuration */ +#define CONFIG_ARM926EJS /* arm926ejs CPU */ +#define CONFIG_SYS_TIMERBASE 0x01c21400 /* use timer 0 */ Is there a logical register #define you could use instead of the magic number? I can include the hardware.h and get the value from there, but the way the hardware.h for DaVinci has evolved over the years, including it in the config will result in compilation failure. I'll add this to my TODO list and send in a patch to clean up for all DaVinci SOC's the moment I get some free cycles. That is fine. + +/* I2C Configuration */ +#define CONFIG_HARD_I2C +#define CONFIG_DRIVER_DAVINCI_I2C +#define CONFIG_SYS_I2C_SPEED 8 This speed is unusual. The same speed has been used with a slightly older version of U-boot and has worked fine davinci_sonata.h has a comment that it had a silicon bug with 100k Could the same comment be applied here ? I don't believe so Ok fine as-is. Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
