Re: [U-Boot] [PATCH] powerpc/85xx: Remove config.mk for nand linker script
On Mon, 31 Jan 2011 22:02:03 -0600 Kumar Gala wrote: > > On Jan 31, 2011, at 4:52 PM, Scott Wood wrote: > > > On Mon, 31 Jan 2011 16:37:44 -0600 > > Kumar Gala wrote: > > > >> * fix where we define this, it should !CONFIG_NAND_SPL, read the old > >> config.mk incorrectly. > > > > I don't think that will make a difference -- CONFIG_NAND_SPL is never > > set when symbols are extracted into autoconf.mk, and > > CONFIG_SYS_LDSCRIPT is not used when building the SPL. > > it seems to work out ok. My point is it will work either way, the ifdef just confuses things, since that's not actually the mechanism by which a different linker script is used for SPL (nor would it work if you relied on the ifdef for that). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Remove config.mk for nand linker script
On Jan 31, 2011, at 4:52 PM, Scott Wood wrote: > On Mon, 31 Jan 2011 16:37:44 -0600 > Kumar Gala wrote: > >> * fix where we define this, it should !CONFIG_NAND_SPL, read the old >> config.mk incorrectly. > > I don't think that will make a difference -- CONFIG_NAND_SPL is never > set when symbols are extracted into autoconf.mk, and > CONFIG_SYS_LDSCRIPT is not used when building the SPL. it seems to work out ok. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Remove config.mk for nand linker script
On Mon, 31 Jan 2011 16:37:44 -0600 Kumar Gala wrote: > * fix where we define this, it should !CONFIG_NAND_SPL, read the old > config.mk incorrectly. I don't think that will make a difference -- CONFIG_NAND_SPL is never set when symbols are extracted into autoconf.mk, and CONFIG_SYS_LDSCRIPT is not used when building the SPL. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Remove config.mk for nand linker script
On Jan 31, 2011, at 4:15 PM, Kumar Gala wrote: > Move the include of mpc85xx/u-boot-nand.lds to utilize > CONFIG_SYS_LDSCRIPT rather than having an explicit config.mk > > Signed-off-by: Kumar Gala > --- > board/freescale/mpc8536ds/config.mk | 30 -- > board/freescale/mpc8569mds/config.mk | 30 -- > board/freescale/mpc8572ds/config.mk | 30 -- > board/freescale/p1_p2_rdb/config.mk | 31 --- > include/configs/MPC8536DS.h |1 + > include/configs/MPC8569MDS.h |1 + > include/configs/MPC8572DS.h |1 + > include/configs/P1_P2_RDB.h |1 + > 8 files changed, 4 insertions(+), 121 deletions(-) > delete mode 100644 board/freescale/mpc8536ds/config.mk > delete mode 100644 board/freescale/mpc8569mds/config.mk > delete mode 100644 board/freescale/mpc8572ds/config.mk > delete mode 100644 board/freescale/p1_p2_rdb/config.mk broken in two different ways, will fix both of them: * use of $(TOPDIR)/$(CPUDIR) * fix where we define this, it should !CONFIG_NAND_SPL, read the old config.mk incorrectly. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
