Re: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
Hi Marek, On Sun, Sep 30, 2012 at 4:24 PM, Marek Vasut ma...@denx.de wrote: Dear Simon Glass, Hi Marek, On Sun, Sep 30, 2012 at 11:09 AM, Marek Vasut ma...@denx.de wrote: Dear Vadim Bendebury, On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut ma...@denx.de wrote: The driver is not used anywhere. It is a dead code and it seems to be falling apart slowly due to bitrot. Remove this driver. This driver is used in several chromeOS devices which have not quite made it upstream yet. Why does it seem falling apart? Noone tested it every since, it seems unmaintained to me. This it is only logical to drop it if there are no users. Will the chromium devices ever make it upstream? The TPM code is used by coreboot and Tegra Seaboard, both of which are upstream. We are working hard on a third :-) Where do you enable it on either board? I see this: OK I see, it seems we are missing some patches upstream. I will prepare a patch to enable for chromebook-x86. $ git grep CONFIG_GENERIC_LPC_TPM Makefile:LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o README: CONFIG_GENERIC_LPC_TPM drivers/tpm/Makefile:COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o If there is a build problem, please can you let us know? I don't know, it's not enabled anywhere. It's just code that is there but noone uses it. I recall a discussion about it, but perhaps nothing happened after that. Very much don't want this driver removed, as we are working on upstreaming another board which uses it. Regards, Simon Regards, Simon cheers, /vb Signed-off-by: Marek Vasut ma...@denx.de Cc: Vadim Bendebury vben...@chromium.org Cc: Tom Rini tr...@ti.com --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
Dear Simon Glass, Hi Marek, On Sun, Sep 30, 2012 at 4:24 PM, Marek Vasut ma...@denx.de wrote: Dear Simon Glass, Hi Marek, On Sun, Sep 30, 2012 at 11:09 AM, Marek Vasut ma...@denx.de wrote: Dear Vadim Bendebury, On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut ma...@denx.de wrote: The driver is not used anywhere. It is a dead code and it seems to be falling apart slowly due to bitrot. Remove this driver. This driver is used in several chromeOS devices which have not quite made it upstream yet. Why does it seem falling apart? Noone tested it every since, it seems unmaintained to me. This it is only logical to drop it if there are no users. Will the chromium devices ever make it upstream? The TPM code is used by coreboot and Tegra Seaboard, both of which are upstream. We are working hard on a third :-) Where do you enable it on either board? I see this: OK I see, it seems we are missing some patches upstream. I will prepare a patch to enable for chromebook-x86. Ah ok, thanks! $ git grep CONFIG_GENERIC_LPC_TPM Makefile:LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o README: CONFIG_GENERIC_LPC_TPM drivers/tpm/Makefile:COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o If there is a build problem, please can you let us know? I don't know, it's not enabled anywhere. It's just code that is there but noone uses it. I recall a discussion about it, but perhaps nothing happened after that. Very much don't want this driver removed, as we are working on upstreaming another board which uses it. Maybe you can bribe me with a chromebook* so I won't push for removal of this code** ;-) * - of course with the chip ** - of course I'm joking! Regards, Simon Regards, Simon cheers, /vb Signed-off-by: Marek Vasut ma...@denx.de Cc: Vadim Bendebury vben...@chromium.org Cc: Tom Rini tr...@ti.com --- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut ma...@denx.de wrote: The driver is not used anywhere. It is a dead code and it seems to be falling apart slowly due to bitrot. Remove this driver. This driver is used in several chromeOS devices which have not quite made it upstream yet. Why does it seem falling apart? cheers, /vb Signed-off-by: Marek Vasut ma...@denx.de Cc: Vadim Bendebury vben...@chromium.org Cc: Tom Rini tr...@ti.com --- Makefile |1 - README| 10 - drivers/tpm/Makefile | 43 drivers/tpm/generic_lpc_tpm.c | 495 - include/tpm.h | 71 -- 5 files changed, 620 deletions(-) delete mode 100644 drivers/tpm/Makefile delete mode 100644 drivers/tpm/generic_lpc_tpm.c delete mode 100644 include/tpm.h diff --git a/Makefile b/Makefile index a40d4cc..1325be0 100644 --- a/Makefile +++ b/Makefile @@ -293,7 +293,6 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o endif LIBS-y += drivers/rtc/librtc.o LIBS-y += drivers/serial/libserial.o -LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o LIBS-y += drivers/twserial/libtws.o LIBS-y += drivers/usb/eth/libusb_eth.o LIBS-y += drivers/usb/gadget/libusb_gadget.o diff --git a/README b/README index a745d0b..c4ad6d8 100644 --- a/README +++ b/README @@ -1149,16 +1149,6 @@ The following options need to be configured: CONFIG_SH_ETHER_CACHE_WRITEBACK If this option is set, the driver enables cache flush. -- TPM Support: - CONFIG_GENERIC_LPC_TPM - Support for generic parallel port TPM devices. Only one device - per system is supported at this time. - - CONFIG_TPM_TIS_BASE_ADDRESS - Base address where the generic TPM device is mapped - to. Contemporary x86 systems usually map it at - 0xfed4. - - USB Support: At the moment only the UHCI host controller is supported (PIP405, MIP405, MPC5200); define diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile deleted file mode 100644 index be11c8b..000 --- a/drivers/tpm/Makefile +++ /dev/null @@ -1,43 +0,0 @@ -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -include $(TOPDIR)/config.mk - -LIB := $(obj)libtpm.o - -COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o - -COBJS := $(COBJS-y) -SRCS := $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(COBJS)) - -all: $(LIB) - -$(LIB): $(obj).depend $(OBJS) - $(call cmd_link_o_target, $(OBJS)) - -# - -include $(SRCTREE)/rules.mk - -sinclude $(obj).depend - -# diff --git a/drivers/tpm/generic_lpc_tpm.c b/drivers/tpm/generic_lpc_tpm.c deleted file mode 100644 index 6c494eb..000 --- a/drivers/tpm/generic_lpc_tpm.c +++ /dev/null @@ -1,495 +0,0 @@ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, - * MA 02111-1307 USA - */ - -/* - * The code in this file is based on the article Writing a TPM Device Driver - * published on http://ptgmedia.pearsoncmg.com. - * - * One
Re: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
Dear Vadim Bendebury, On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut ma...@denx.de wrote: The driver is not used anywhere. It is a dead code and it seems to be falling apart slowly due to bitrot. Remove this driver. This driver is used in several chromeOS devices which have not quite made it upstream yet. Why does it seem falling apart? Noone tested it every since, it seems unmaintained to me. This it is only logical to drop it if there are no users. Will the chromium devices ever make it upstream? cheers, /vb Signed-off-by: Marek Vasut ma...@denx.de Cc: Vadim Bendebury vben...@chromium.org Cc: Tom Rini tr...@ti.com --- Makefile |1 - README| 10 - drivers/tpm/Makefile | 43 drivers/tpm/generic_lpc_tpm.c | 495 - include/tpm.h | 71 -- 5 files changed, 620 deletions(-) delete mode 100644 drivers/tpm/Makefile delete mode 100644 drivers/tpm/generic_lpc_tpm.c delete mode 100644 include/tpm.h diff --git a/Makefile b/Makefile index a40d4cc..1325be0 100644 --- a/Makefile +++ b/Makefile @@ -293,7 +293,6 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o endif LIBS-y += drivers/rtc/librtc.o LIBS-y += drivers/serial/libserial.o -LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o LIBS-y += drivers/twserial/libtws.o LIBS-y += drivers/usb/eth/libusb_eth.o LIBS-y += drivers/usb/gadget/libusb_gadget.o diff --git a/README b/README index a745d0b..c4ad6d8 100644 --- a/README +++ b/README @@ -1149,16 +1149,6 @@ The following options need to be configured: CONFIG_SH_ETHER_CACHE_WRITEBACK If this option is set, the driver enables cache flush. -- TPM Support: - CONFIG_GENERIC_LPC_TPM - Support for generic parallel port TPM devices. Only one device - per system is supported at this time. - - CONFIG_TPM_TIS_BASE_ADDRESS - Base address where the generic TPM device is mapped - to. Contemporary x86 systems usually map it at - 0xfed4. - - USB Support: At the moment only the UHCI host controller is supported (PIP405, MIP405, MPC5200); define diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile deleted file mode 100644 index be11c8b..000 --- a/drivers/tpm/Makefile +++ /dev/null @@ -1,43 +0,0 @@ -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -include $(TOPDIR)/config.mk - -LIB := $(obj)libtpm.o - -COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o - -COBJS := $(COBJS-y) -SRCS := $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(COBJS)) - -all: $(LIB) - -$(LIB): $(obj).depend $(OBJS) - $(call cmd_link_o_target, $(OBJS)) - - # - -include $(SRCTREE)/rules.mk - -sinclude $(obj).depend - - # diff --git a/drivers/tpm/generic_lpc_tpm.c b/drivers/tpm/generic_lpc_tpm.c deleted file mode 100644 index 6c494eb..000 --- a/drivers/tpm/generic_lpc_tpm.c +++ /dev/null @@ -1,495 +0,0 @@ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have
Re: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
Hi Marek, On Sun, Sep 30, 2012 at 11:09 AM, Marek Vasut ma...@denx.de wrote: Dear Vadim Bendebury, On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut ma...@denx.de wrote: The driver is not used anywhere. It is a dead code and it seems to be falling apart slowly due to bitrot. Remove this driver. This driver is used in several chromeOS devices which have not quite made it upstream yet. Why does it seem falling apart? Noone tested it every since, it seems unmaintained to me. This it is only logical to drop it if there are no users. Will the chromium devices ever make it upstream? The TPM code is used by coreboot and Tegra Seaboard, both of which are upstream. We are working hard on a third :-) If there is a build problem, please can you let us know? Regards, Simon cheers, /vb Signed-off-by: Marek Vasut ma...@denx.de Cc: Vadim Bendebury vben...@chromium.org Cc: Tom Rini tr...@ti.com --- Makefile |1 - README| 10 - drivers/tpm/Makefile | 43 drivers/tpm/generic_lpc_tpm.c | 495 - include/tpm.h | 71 -- 5 files changed, 620 deletions(-) delete mode 100644 drivers/tpm/Makefile delete mode 100644 drivers/tpm/generic_lpc_tpm.c delete mode 100644 include/tpm.h diff --git a/Makefile b/Makefile index a40d4cc..1325be0 100644 --- a/Makefile +++ b/Makefile @@ -293,7 +293,6 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o endif LIBS-y += drivers/rtc/librtc.o LIBS-y += drivers/serial/libserial.o -LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o LIBS-y += drivers/twserial/libtws.o LIBS-y += drivers/usb/eth/libusb_eth.o LIBS-y += drivers/usb/gadget/libusb_gadget.o diff --git a/README b/README index a745d0b..c4ad6d8 100644 --- a/README +++ b/README @@ -1149,16 +1149,6 @@ The following options need to be configured: CONFIG_SH_ETHER_CACHE_WRITEBACK If this option is set, the driver enables cache flush. -- TPM Support: - CONFIG_GENERIC_LPC_TPM - Support for generic parallel port TPM devices. Only one device - per system is supported at this time. - - CONFIG_TPM_TIS_BASE_ADDRESS - Base address where the generic TPM device is mapped - to. Contemporary x86 systems usually map it at - 0xfed4. - - USB Support: At the moment only the UHCI host controller is supported (PIP405, MIP405, MPC5200); define diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile deleted file mode 100644 index be11c8b..000 --- a/drivers/tpm/Makefile +++ /dev/null @@ -1,43 +0,0 @@ -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -include $(TOPDIR)/config.mk - -LIB := $(obj)libtpm.o - -COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o - -COBJS := $(COBJS-y) -SRCS := $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(COBJS)) - -all: $(LIB) - -$(LIB): $(obj).depend $(OBJS) - $(call cmd_link_o_target, $(OBJS)) - - # - -include $(SRCTREE)/rules.mk - -sinclude $(obj).depend - - # diff --git a/drivers/tpm/generic_lpc_tpm.c b/drivers/tpm/generic_lpc_tpm.c deleted file mode 100644 index 6c494eb..000 --- a/drivers/tpm/generic_lpc_tpm.c +++ /dev/null @@ -1,495 +0,0 @@ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * - * See file CREDITS for list of people who contributed to this - * project. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is
Re: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
Dear Simon Glass, Hi Marek, On Sun, Sep 30, 2012 at 11:09 AM, Marek Vasut ma...@denx.de wrote: Dear Vadim Bendebury, On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut ma...@denx.de wrote: The driver is not used anywhere. It is a dead code and it seems to be falling apart slowly due to bitrot. Remove this driver. This driver is used in several chromeOS devices which have not quite made it upstream yet. Why does it seem falling apart? Noone tested it every since, it seems unmaintained to me. This it is only logical to drop it if there are no users. Will the chromium devices ever make it upstream? The TPM code is used by coreboot and Tegra Seaboard, both of which are upstream. We are working hard on a third :-) Where do you enable it on either board? I see this: $ git grep CONFIG_GENERIC_LPC_TPM Makefile:LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o README: CONFIG_GENERIC_LPC_TPM drivers/tpm/Makefile:COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o If there is a build problem, please can you let us know? I don't know, it's not enabled anywhere. It's just code that is there but noone uses it. Regards, Simon cheers, /vb Signed-off-by: Marek Vasut ma...@denx.de Cc: Vadim Bendebury vben...@chromium.org Cc: Tom Rini tr...@ti.com --- Makefile |1 - README| 10 - drivers/tpm/Makefile | 43 drivers/tpm/generic_lpc_tpm.c | 495 - include/tpm.h | 71 -- 5 files changed, 620 deletions(-) delete mode 100644 drivers/tpm/Makefile delete mode 100644 drivers/tpm/generic_lpc_tpm.c delete mode 100644 include/tpm.h diff --git a/Makefile b/Makefile index a40d4cc..1325be0 100644 --- a/Makefile +++ b/Makefile @@ -293,7 +293,6 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o endif LIBS-y += drivers/rtc/librtc.o LIBS-y += drivers/serial/libserial.o -LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o LIBS-y += drivers/twserial/libtws.o LIBS-y += drivers/usb/eth/libusb_eth.o LIBS-y += drivers/usb/gadget/libusb_gadget.o diff --git a/README b/README index a745d0b..c4ad6d8 100644 --- a/README +++ b/README @@ -1149,16 +1149,6 @@ The following options need to be configured: CONFIG_SH_ETHER_CACHE_WRITEBACK If this option is set, the driver enables cache flush. -- TPM Support: - CONFIG_GENERIC_LPC_TPM - Support for generic parallel port TPM devices. Only one device - per system is supported at this time. - - CONFIG_TPM_TIS_BASE_ADDRESS - Base address where the generic TPM device is mapped - to. Contemporary x86 systems usually map it at - 0xfed4. - - USB Support: At the moment only the UHCI host controller is supported (PIP405, MIP405, MPC5200); define diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile deleted file mode 100644 index be11c8b..000 --- a/drivers/tpm/Makefile +++ /dev/null @@ -1,43 +0,0 @@ -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# - -include $(TOPDIR)/config.mk - -LIB := $(obj)libtpm.o - -COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o - -COBJS := $(COBJS-y) -SRCS := $(COBJS:.o=.c) -OBJS := $(addprefix $(obj),$(COBJS)) - -all: $(LIB) - -$(LIB): $(obj).depend $(OBJS) - $(call cmd_link_o_target, $(OBJS)) - -# ### # - -include $(SRCTREE)/rules.mk - -sinclude $(obj).depend - -# ### # diff --git a/drivers/tpm/generic_lpc_tpm.c b/drivers/tpm/generic_lpc_tpm.c deleted file
