Re: [U-Boot] [PATCH v3] board: sun50i: Add Amarula A64-Relic initial support
On Mon, May 28, 2018 at 04:34:43PM +0530, Jagan Teki wrote: > +CONFIG_CMD_USB_MASS_STORAGE=y You still haven't explained why this is useful to add it by default on this particular board. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] board: sun50i: Add Amarula A64-Relic initial support
On Tue, May 29, 2018 at 9:44 PM, Maxime Ripard wrote: > On Mon, May 28, 2018 at 04:34:43PM +0530, Jagan Teki wrote: >> +CONFIG_CMD_USB_MASS_STORAGE=y > > You still haven't explained why this is useful to add it by default on > this particular board. This board does have only eMMC and no external storage possibilities(like eMMC or Ethernet) so to copy images between eMMC vs host intermediate way (other than fastboot) ums can be the possible way. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] board: sun50i: Add Amarula A64-Relic initial support
On Tue, May 29, 2018 at 09:50:39PM +0530, Jagan Teki wrote: > On Tue, May 29, 2018 at 9:44 PM, Maxime Ripard > wrote: > > On Mon, May 28, 2018 at 04:34:43PM +0530, Jagan Teki wrote: > >> +CONFIG_CMD_USB_MASS_STORAGE=y > > > > You still haven't explained why this is useful to add it by default on > > this particular board. > > This board does have only eMMC and no external storage > possibilities(like eMMC or Ethernet) so to copy images between eMMC vs > host intermediate way (other than fastboot) ums can be the possible > way. We have fastboot and DFU to address that already, and a number of other boards accomodate that just fine (the CHIP, the NES Classic, etc.). Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] board: sun50i: Add Amarula A64-Relic initial support
On Thu, May 31, 2018 at 3:07 PM, Maxime Ripard wrote: > On Tue, May 29, 2018 at 09:50:39PM +0530, Jagan Teki wrote: >> On Tue, May 29, 2018 at 9:44 PM, Maxime Ripard >> wrote: >> > On Mon, May 28, 2018 at 04:34:43PM +0530, Jagan Teki wrote: >> >> +CONFIG_CMD_USB_MASS_STORAGE=y >> > >> > You still haven't explained why this is useful to add it by default on >> > this particular board. >> >> This board does have only eMMC and no external storage >> possibilities(like eMMC or Ethernet) so to copy images between eMMC vs >> host intermediate way (other than fastboot) ums can be the possible >> way. > > We have fastboot and DFU to address that already, and a number of > other boards accomodate that just fine (the CHIP, the NES Classic, > etc.). Yes, but ums is different where we can simply mount the flash on host and update the partitions data directly instead of create partitions with new data to write again. what's wrong with using ums. I always believe fastboot, DFU is different than ums where former need to create image file and later simply copy. Jagan. -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] board: sun50i: Add Amarula A64-Relic initial support
On Thu, May 31, 2018 at 03:13:15PM +0530, Jagan Teki wrote: > On Thu, May 31, 2018 at 3:07 PM, Maxime Ripard > wrote: > > On Tue, May 29, 2018 at 09:50:39PM +0530, Jagan Teki wrote: > >> On Tue, May 29, 2018 at 9:44 PM, Maxime Ripard > >> wrote: > >> > On Mon, May 28, 2018 at 04:34:43PM +0530, Jagan Teki wrote: > >> >> +CONFIG_CMD_USB_MASS_STORAGE=y > >> > > >> > You still haven't explained why this is useful to add it by default on > >> > this particular board. > >> > >> This board does have only eMMC and no external storage > >> possibilities(like eMMC or Ethernet) so to copy images between eMMC vs > >> host intermediate way (other than fastboot) ums can be the possible > >> way. > > > > We have fastboot and DFU to address that already, and a number of > > other boards accomodate that just fine (the CHIP, the NES Classic, > > etc.). > > Yes, but ums is different where we can simply mount the flash on host > and update the partitions data directly instead of create partitions > with new data to write again. what's wrong with using ums. I always > believe fastboot, DFU is different than ums where former need to > create image file and later simply copy. I'm not arguing the usefulness of the UMS gadget itself, I don't have any objections to that, and I totally get why and how it can be useful. What I'm arguing for is why you should enable it *by default*. You can very easily do that with menuconfig already, and we won't enable each and every command and feature someone finds interesting. We've already been bitten hard by this, and I have no intention of doing that kind of thing a second time. So yeah, you can definitely use UMS if you wish so. But enabling it by default when we have already two alternatives for the same use case enabled is pointless. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
