Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
On Monday 27 July 2009 17:09:28 Alessandro Rubini wrote: > > Please, is there somebody that can test this patch on a differen arch > > than PPC? I just noticed a common difference in the failing uncompression's. Load address is 0x0 in this case. Perhaps you could give this a try on your system as well (if possible). I'll try to uncompress to something != 0 tomorrow on PPC. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
> Please, is there somebody that can test this patch on a differen arch than > PPC? Arm: success. tornado% git log --pretty=oneline | head -1 b201171f2b4d509f3ad510b214bee70ff902e3d6 zlib: updated to v.1.2.3 U-Boot 2009.06-00494-gb201171 (Jul 27 2009 - 17:05:15) [...] ## Booting kernel from Legacy Image at 01308000 ... Image Name: Linux-2.6.31-rc3 Image Type: ARM Linux Kernel Image (gzip compressed) Data Size:1706717 Bytes = 1.6 MB Load Address: 8000 Entry Point: 8000 Uncompressing Kernel Image ... OK /alessandro ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
Hi All, unfortunately currently I'm not able to reproduce this issue because boards I'm using are not ported to the best so far u-boot tree. However: - I worked with zlib-1.2.3 patch on my current u-boot version (1.3.1) without problem with sh boards. - This u-boot version is a little bit different about decompression, e.g. here we have gunzip inside cmd_bootm and in the bsf it is in a different file (gunzip.c) - Given this, I backported these into 1.3.1 and tested again, with success. I mean, I tested an old u-boot version with newest decompression code. I think it should be a good test, the one I modified is common code and should be self contained. I'm wondering if something is going wrong only with PPC arch (errors are related to this arch), and in this case I cannot reproduce the issue at all. Please, is there somebody that can test this patch on a differen arch than PPC? What's your thinking about? Best regards and, please, let me know. Giuseppe Condorelli -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Friday, July 24, 2009 2:27 PM To: Stefan Roese Cc: u-boot@lists.denx.de; rhabarber1...@web.de; Giuseppe CONDORELLI Subject: Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3 Dear Stefan Roese, In message <200907241356.06963...@denx.de> you wrote: > > >Uncompressing Kernel Image ... Error: inflate() returned -2 > > GUNZIP: uncompress, out-of-mem or overwrite error - must RESET board to > > recover > > > > Maybe the zlib update is responsible? > > Yes, I'm just noticing the same behaviour: ... > I checked and verified that commit b201171f2b4d509f3ad510b214bee70ff902e3d6 > [zlib: updated to v.1.2.3] is responsible for this. > > So we should probably revert this patch for now. Wolfgang, what do you think? I reverted the patch. Giuseppe, please resubmit, but unly after *thorough* testing, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Harrisberger's Fourth Law of the Lab: Experience is directly proportional to the amount of equipment ruined. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
On Fri, 24 Jul 2009 09:25:23 +0200 rhabarber1848 wrote: > Wolfgang Denk wrote: > > >> include/u-boot/zlib.h | 718 ++--- > >> lib_generic/zlib.c| 3931 > >> + 2 files changed, 2464 > >> insertions(+), 2185 deletions(-) > > > > Applied, thanks. > > Hi, > > yesterday morning I could use the U-Boot git code to successfully decompress > a gzip compressed image, using today's git checkout this does not work > anymore: > > ## Booting kernel from Legacy Image at 0020 ... >Image Name: Linux-2.4.37.2-dbox2 >Image Type: PowerPC Linux Kernel Image (gzip compressed) >Data Size:748627 Bytes = 731.1 kB >Load Address: >Entry Point: >Verifying Checksum ... OK >Uncompressing Kernel Image ... Error: inflate() returned -2 > GUNZIP: uncompress, out-of-mem or overwrite error - must RESET board to > recover I'm seeing this, too. Reverting commits 28958b8b and b201171f2 makes uncompressing work again. Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
Dear Stefan Roese, In message <200907241356.06963...@denx.de> you wrote: > > >Uncompressing Kernel Image ... Error: inflate() returned -2 > > GUNZIP: uncompress, out-of-mem or overwrite error - must RESET board to > > recover > > > > Maybe the zlib update is responsible? > > Yes, I'm just noticing the same behaviour: ... > I checked and verified that commit b201171f2b4d509f3ad510b214bee70ff902e3d6 > [zlib: updated to v.1.2.3] is responsible for this. > > So we should probably revert this patch for now. Wolfgang, what do you think? I reverted the patch. Giuseppe, please resubmit, but unly after *thorough* testing, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Harrisberger's Fourth Law of the Lab: Experience is directly proportional to the amount of equipment ruined. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
On Friday 24 July 2009 09:25:23 rhabarber1848 wrote: > yesterday morning I could use the U-Boot git code to successfully > decompress a gzip compressed image, using today's git checkout this does > not work anymore: > > ## Booting kernel from Legacy Image at 0020 ... >Image Name: Linux-2.4.37.2-dbox2 >Image Type: PowerPC Linux Kernel Image (gzip compressed) >Data Size:748627 Bytes = 731.1 kB >Load Address: >Entry Point: >Verifying Checksum ... OK >Uncompressing Kernel Image ... Error: inflate() returned -2 > GUNZIP: uncompress, out-of-mem or overwrite error - must RESET board to > recover > > Maybe the zlib update is responsible? Yes, I'm just noticing the same behaviour: ## Booting kernel from Legacy Image at 0020 ... Image Name: Linux-2.6.30 Created: 2009-06-30 7:45:03 UTC Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:1350151 Bytes = 1.3 MB Load Address: Entry Point: Verifying Checksum ... OK ## Flattened Device Tree blob at 0080 Booting using the fdt blob at 0x80 Uncompressing Kernel Image ... Error: inflate() returned -2 GUNZIP: uncompress, out-of-mem or overwrite error - must RESET board to recover I checked and verified that commit b201171f2b4d509f3ad510b214bee70ff902e3d6 [zlib: updated to v.1.2.3] is responsible for this. So we should probably revert this patch for now. Wolfgang, what do you think? Thanks. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
Wolfgang Denk wrote: >> include/u-boot/zlib.h | 718 ++--- >> lib_generic/zlib.c| 3931 >> + 2 files changed, 2464 >> insertions(+), 2185 deletions(-) > > Applied, thanks. Hi, yesterday morning I could use the U-Boot git code to successfully decompress a gzip compressed image, using today's git checkout this does not work anymore: ## Booting kernel from Legacy Image at 0020 ... Image Name: Linux-2.4.37.2-dbox2 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:748627 Bytes = 731.1 kB Load Address: Entry Point: Verifying Checksum ... OK Uncompressing Kernel Image ... Error: inflate() returned -2 GUNZIP: uncompress, out-of-mem or overwrite error - must RESET board to recover Maybe the zlib update is responsible? This is the newest commit from the U-Boot git checkout I used today: commit 28958b8bea4c66629c5a22fd3c8b0d49df90383d Author: Wolfgang Denk Date: Thu Jul 23 22:23:23 2009 +0200 Coding Style cleanup; update CHANGELOG. Signed-off-by: Wolfgang Denk Cheers, rhabarber1848 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] zlib: updated to v.1.2.3
Dear Giuseppe CONDORELLI, In message <1248339285-19580-1-git-send-email-giuseppe.condore...@st.com> you wrote: > This patch updates zlib to the latest stable version. > Only relevant zlib parts were ported to u-boot tree, as already did for the > current zlib (0.95). New zlib guarantees a faster inflate performances > other then others improvements as explained at www.zlib.net > > Signed-off-by: Giuseppe Condorelli > Reviewed-by: Angelo Castello > --- > include/u-boot/zlib.h | 718 ++--- > lib_generic/zlib.c| 3931 > + > 2 files changed, 2464 insertions(+), 2185 deletions(-) Applied, thanks. [This time it seems to compile without issues.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are two kinds of people, those who do the work and those who take the credit. Try to be in the first group; there is less competition there.- Indira Gandhi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
