Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
Hi Marek, > -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: Sunday, January 24, 2016 3:38 AM > To: Anand Moon > Cc: Joe Hershberger; Ted; Stephen Warren; Joe Hershberger; u-boot > Subject: Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek > RTL8152B/RTL8153 DRIVER > > On Saturday, January 23, 2016 at 07:55:58 PM, Anand Moon wrote: > > Hi Marek, > > > > On 23 January 2016 at 20:53, Marek Vasut wrote: > > > On Saturday, January 23, 2016 at 01:42:55 AM, Marek Vasut wrote: > > >> On Friday, January 22, 2016 at 09:41:33 PM, Joe > Hershberger wrote: > > >> > Hi Marek, > > >> > > > >> > On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut > wrote: > > >> > > On Friday, January 22, 2016 at 08:50:04 PM, Joe > Hershberger wrote: > > >> > >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen > > >> > >> > wrote: > > >> > >> > This patch adds driver support for the Realtek > > >> > >> > RTL8152B/RTL8153 USB network adapters. > > >> > >> > > > >> > >> > Signed-off-by: Ted Chen > [swarren, > > >> > >> > fixed a few compiler warnings] [swarren, with permission, > > >> > >> > converted license header to SPDX] [swarren, > removed printf() > > >> > >> > spew during probe()] > > >> > >> > Signed-off-by: Stephen Warren > > >> > >> > --- > > >> > >> > > > >> > >> > drivers/usb/eth/Makefile|1 + > > >> > >> > drivers/usb/eth/r8152.c | 1456 > > >> > >> > +++ > > >> > >> > drivers/usb/eth/r8152.h > > >> > >> > > > >> > >> > | 631 +++ > > >> > >> > > > >> > >> > drivers/usb/eth/r8152_fw.c | 980 > + > > >> > >> > drivers/usb/eth/usb_ether.c |7 + > > >> > >> > include/usb_ether.h |6 + > > >> > >> > 6 files changed, 3081 insertions(+) create mode 100644 > > >> > >> > drivers/usb/eth/r8152.c create mode 100644 > > >> > >> > drivers/usb/eth/r8152.h create mode 100644 > > >> > >> > drivers/usb/eth/r8152_fw.c > > >> > >> > > > >> > >> > Changes for v2: Modified by Marek's comments. > > >> > >> > - Remove pattern informations. > > >> > >> > - Don't allocate & free when read/write register. > > >> > >> > - relpace udelay to mdelay. > > >> > >> > - pull firmware into global variable. > > >> > >> > - code review. > > >> > >> > > > >> > >> > Changes for v3: Modified by Marek's and Joe's comments. > > >> > >> > - Remove driver version informations. > > >> > >> > - separate firmware code to individual file. > > >> > >> > - split extensive defines to r8152.h. > > >> > >> > - code review. > > >> > >> > > > >> > >> > Changes for v4: Modified by Marek's comments. > > >> > >> > - remove the redundant code in generic_ocp_read and > > >> > >> > generic_ocp_write. - remove redundant typecasting. > > >> > >> > - collect the codes of busy waiting to > rtl8152_reinit_ll and > > >> > >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid > having 0x00 > > >> > >> > as a terminating entry of r8152_dongles. - using if > > >> > >> > (!ep_in_found && (ep_addr & USB_DIR_IN)) ... to > replace old > > >> > >> > version. - code review. > > >> > >> > > > >> > >> > Changes for v5: Modified by Marek's comments. > > >> > >> > - add r8152_wait_for_bit to replace busy wait. > > >> > >> > - change the name of patch4 to r8152b_set_dq_desc. > > >> > >> > - add r8152_versions to store the hw's version. > > >> > >> > > >> > >> Acked-by: Joe Hershberger > > >> > > > > >> > > Do you want to pick this or shall I ? > > >> > > > >> > If there is some dependency (patch 1) that you will > take first, > > >> > you can just take this as well. > > >> > > >> I cannot find patch 1/2. > > >> > > >> Ted, can you repost both of the patches , so I can pick them ? > > > > > > I applied 2/2 to u-boot-usb since it seems harmless, but I still > > > don't know what 1/2 is . > > > > > > Best regards, > > > > I probably belive this is the patch. > > > > https://patchwork.ozlabs.org/patch/548453/ > > Thanks, in that case , please repost that one patch. The patch 1/2 is there : https://patchwork.ozlabs.org/patch/544360/ That patch is posted by "Stephen Warren". Thanks~ BRs Ted ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Monday, January 25, 2016 at 04:42:50 AM, Ted wrote: > Hi Marek, Hi, > > -Original Message- > > From: Marek Vasut [mailto:ma...@denx.de] > > Sent: Sunday, January 24, 2016 3:38 AM > > To: Anand Moon > > Cc: Joe Hershberger; Ted; Stephen Warren; Joe Hershberger; u-boot > > Subject: Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek > > RTL8152B/RTL8153 DRIVER > > > > On Saturday, January 23, 2016 at 07:55:58 PM, Anand Moon wrote: > > > Hi Marek, > > > > > > On 23 January 2016 at 20:53, Marek Vasut wrote: > > > > On Saturday, January 23, 2016 at 01:42:55 AM, Marek Vasut wrote: > > > >> On Friday, January 22, 2016 at 09:41:33 PM, Joe > > > > Hershberger wrote: > > > >> > Hi Marek, > > > >> > > > > >> > On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut > > > > wrote: > > > >> > > On Friday, January 22, 2016 at 08:50:04 PM, Joe > > > > Hershberger wrote: > > > >> > >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen > > > >> > >> > > > > wrote: > > > >> > >> > This patch adds driver support for the Realtek > > > >> > >> > RTL8152B/RTL8153 USB network adapters. > > > >> > >> > > > > >> > >> > Signed-off-by: Ted Chen > > > > [swarren, > > > > > >> > >> > fixed a few compiler warnings] [swarren, with permission, > > > >> > >> > converted license header to SPDX] [swarren, > > > > removed printf() > > > > > >> > >> > spew during probe()] > > > >> > >> > Signed-off-by: Stephen Warren > > > >> > >> > --- > > > >> > >> > > > > >> > >> > drivers/usb/eth/Makefile|1 + > > > >> > >> > drivers/usb/eth/r8152.c | 1456 > > > >> > >> > +++ > > > >> > >> > drivers/usb/eth/r8152.h > > > >> > >> > > > > >> > >> > | 631 +++ > > > >> > >> > > > > >> > >> > drivers/usb/eth/r8152_fw.c | 980 > > > > + > > > > > >> > >> > drivers/usb/eth/usb_ether.c |7 + > > > >> > >> > include/usb_ether.h |6 + > > > >> > >> > 6 files changed, 3081 insertions(+) create mode 100644 > > > >> > >> > > > > >> > >> > drivers/usb/eth/r8152.c create mode 100644 > > > >> > >> > drivers/usb/eth/r8152.h create mode 100644 > > > >> > >> > drivers/usb/eth/r8152_fw.c > > > >> > >> > > > > >> > >> > Changes for v2: Modified by Marek's comments. > > > >> > >> > - Remove pattern informations. > > > >> > >> > - Don't allocate & free when read/write register. > > > >> > >> > - relpace udelay to mdelay. > > > >> > >> > - pull firmware into global variable. > > > >> > >> > - code review. > > > >> > >> > > > > >> > >> > Changes for v3: Modified by Marek's and Joe's comments. > > > >> > >> > - Remove driver version informations. > > > >> > >> > - separate firmware code to individual file. > > > >> > >> > - split extensive defines to r8152.h. > > > >> > >> > - code review. > > > >> > >> > > > > >> > >> > Changes for v4: Modified by Marek's comments. > > > >> > >> > - remove the redundant code in generic_ocp_read and > > > >> > >> > generic_ocp_write. - remove redundant typecasting. > > > >> > >> > - collect the codes of busy waiting to > > > > rtl8152_reinit_ll and > > > > > >> > >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid > > > > having 0x00 > > > > > >> > >> > as a terminating entry of r8152_dongles. - using if > > > >> > >> > (!ep_in_found && (ep_addr & USB_DIR_IN)) ... to > > > > replace old > > > > > >> > >> > version. - code review. > > > >> > >> > > > > >> > >> > Changes for v5: Modified by Marek's comments. > > > >> > >> > - add r8152_wait_for_bit to replace busy wait. > > > >> > >> > - change the name of patch4 to r8152b_set_dq_desc. > > > >> > >> > - add r8152_versions to store the hw's version. > > > >> > >> > > > >> > >> Acked-by: Joe Hershberger > > > >> > > > > > >> > > Do you want to pick this or shall I ? > > > >> > > > > >> > If there is some dependency (patch 1) that you will > > > > take first, > > > > > >> > you can just take this as well. > > > >> > > > >> I cannot find patch 1/2. > > > >> > > > >> Ted, can you repost both of the patches , so I can pick them ? > > > > > > > > I applied 2/2 to u-boot-usb since it seems harmless, but I still > > > > don't know what 1/2 is . > > > > > > > > Best regards, > > > > > > I probably belive this is the patch. > > > > > > https://patchwork.ozlabs.org/patch/548453/ > > > > Thanks, in that case , please repost that one patch. > > The patch 1/2 is there : > https://patchwork.ozlabs.org/patch/544360/ Urgh, looks like PW mixed 1/2 and 2/2 and all the review of 2/2 is part of that 1/2 patch too. Sigh. > That patch is posted by "Stephen Warren". Did that 1/2 patch get any review other than mine ? If not , please do repost it and and CC Tom Rini and Simon Glass at least . Feel free to keep my reviewed- by already. Thanks! > Thanks~ > > BRs > Ted ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
Hi Marek, On 23 January 2016 at 20:53, Marek Vasut wrote: > On Saturday, January 23, 2016 at 01:42:55 AM, Marek Vasut wrote: >> On Friday, January 22, 2016 at 09:41:33 PM, Joe Hershberger wrote: >> > Hi Marek, >> > >> > On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut wrote: >> > > On Friday, January 22, 2016 at 08:50:04 PM, Joe Hershberger wrote: >> > >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: >> > >> > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB >> > >> > network adapters. >> > >> > >> > >> > Signed-off-by: Ted Chen >> > >> > [swarren, fixed a few compiler warnings] >> > >> > [swarren, with permission, converted license header to SPDX] >> > >> > [swarren, removed printf() spew during probe()] >> > >> > Signed-off-by: Stephen Warren >> > >> > --- >> > >> > >> > >> > drivers/usb/eth/Makefile|1 + >> > >> > drivers/usb/eth/r8152.c | 1456 >> > >> > +++ drivers/usb/eth/r8152.h >> > >> > >> > >> > | 631 +++ >> > >> > >> > >> > drivers/usb/eth/r8152_fw.c | 980 + >> > >> > drivers/usb/eth/usb_ether.c |7 + >> > >> > include/usb_ether.h |6 + >> > >> > 6 files changed, 3081 insertions(+) >> > >> > create mode 100644 drivers/usb/eth/r8152.c >> > >> > create mode 100644 drivers/usb/eth/r8152.h >> > >> > create mode 100644 drivers/usb/eth/r8152_fw.c >> > >> > >> > >> > Changes for v2: Modified by Marek's comments. >> > >> > - Remove pattern informations. >> > >> > - Don't allocate & free when read/write register. >> > >> > - relpace udelay to mdelay. >> > >> > - pull firmware into global variable. >> > >> > - code review. >> > >> > >> > >> > Changes for v3: Modified by Marek's and Joe's comments. >> > >> > - Remove driver version informations. >> > >> > - separate firmware code to individual file. >> > >> > - split extensive defines to r8152.h. >> > >> > - code review. >> > >> > >> > >> > Changes for v4: Modified by Marek's comments. >> > >> > - remove the redundant code in generic_ocp_read and >> > >> > generic_ocp_write. - remove redundant typecasting. >> > >> > - collect the codes of busy waiting to rtl8152_reinit_ll and >> > >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid having 0x00 as a >> > >> > terminating entry of r8152_dongles. - using if (!ep_in_found && >> > >> > (ep_addr & USB_DIR_IN)) ... to replace old version. - code review. >> > >> > >> > >> > Changes for v5: Modified by Marek's comments. >> > >> > - add r8152_wait_for_bit to replace busy wait. >> > >> > - change the name of patch4 to r8152b_set_dq_desc. >> > >> > - add r8152_versions to store the hw's version. >> > >> >> > >> Acked-by: Joe Hershberger >> > > >> > > Do you want to pick this or shall I ? >> > >> > If there is some dependency (patch 1) that you will take first, you >> > can just take this as well. >> >> I cannot find patch 1/2. >> >> Ted, can you repost both of the patches , so I can pick them ? > > I applied 2/2 to u-boot-usb since it seems harmless, but I still don't know > what 1/2 is . > > Best regards, I probably belive this is the patch. https://patchwork.ozlabs.org/patch/548453/ Best Regards -Anand Moon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Saturday, January 23, 2016 at 07:55:58 PM, Anand Moon wrote: > Hi Marek, > > On 23 January 2016 at 20:53, Marek Vasut wrote: > > On Saturday, January 23, 2016 at 01:42:55 AM, Marek Vasut wrote: > >> On Friday, January 22, 2016 at 09:41:33 PM, Joe Hershberger wrote: > >> > Hi Marek, > >> > > >> > On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut wrote: > >> > > On Friday, January 22, 2016 at 08:50:04 PM, Joe Hershberger wrote: > >> > >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: > >> > >> > This patch adds driver support for the Realtek RTL8152B/RTL8153 > >> > >> > USB network adapters. > >> > >> > > >> > >> > Signed-off-by: Ted Chen > >> > >> > [swarren, fixed a few compiler warnings] > >> > >> > [swarren, with permission, converted license header to SPDX] > >> > >> > [swarren, removed printf() spew during probe()] > >> > >> > Signed-off-by: Stephen Warren > >> > >> > --- > >> > >> > > >> > >> > drivers/usb/eth/Makefile|1 + > >> > >> > drivers/usb/eth/r8152.c | 1456 > >> > >> > +++ > >> > >> > drivers/usb/eth/r8152.h > >> > >> > > >> > >> > | 631 +++ > >> > >> > > >> > >> > drivers/usb/eth/r8152_fw.c | 980 + > >> > >> > drivers/usb/eth/usb_ether.c |7 + > >> > >> > include/usb_ether.h |6 + > >> > >> > 6 files changed, 3081 insertions(+) > >> > >> > create mode 100644 drivers/usb/eth/r8152.c > >> > >> > create mode 100644 drivers/usb/eth/r8152.h > >> > >> > create mode 100644 drivers/usb/eth/r8152_fw.c > >> > >> > > >> > >> > Changes for v2: Modified by Marek's comments. > >> > >> > - Remove pattern informations. > >> > >> > - Don't allocate & free when read/write register. > >> > >> > - relpace udelay to mdelay. > >> > >> > - pull firmware into global variable. > >> > >> > - code review. > >> > >> > > >> > >> > Changes for v3: Modified by Marek's and Joe's comments. > >> > >> > - Remove driver version informations. > >> > >> > - separate firmware code to individual file. > >> > >> > - split extensive defines to r8152.h. > >> > >> > - code review. > >> > >> > > >> > >> > Changes for v4: Modified by Marek's comments. > >> > >> > - remove the redundant code in generic_ocp_read and > >> > >> > generic_ocp_write. - remove redundant typecasting. > >> > >> > - collect the codes of busy waiting to rtl8152_reinit_ll and > >> > >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid having 0x00 as a > >> > >> > terminating entry of r8152_dongles. - using if (!ep_in_found && > >> > >> > (ep_addr & USB_DIR_IN)) ... to replace old version. - code > >> > >> > review. > >> > >> > > >> > >> > Changes for v5: Modified by Marek's comments. > >> > >> > - add r8152_wait_for_bit to replace busy wait. > >> > >> > - change the name of patch4 to r8152b_set_dq_desc. > >> > >> > - add r8152_versions to store the hw's version. > >> > >> > >> > >> Acked-by: Joe Hershberger > >> > > > >> > > Do you want to pick this or shall I ? > >> > > >> > If there is some dependency (patch 1) that you will take first, you > >> > can just take this as well. > >> > >> I cannot find patch 1/2. > >> > >> Ted, can you repost both of the patches , so I can pick them ? > > > > I applied 2/2 to u-boot-usb since it seems harmless, but I still don't > > know what 1/2 is . > > > > Best regards, > > I probably belive this is the patch. > > https://patchwork.ozlabs.org/patch/548453/ Thanks, in that case , please repost that one patch. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Saturday, January 23, 2016 at 01:42:55 AM, Marek Vasut wrote: > On Friday, January 22, 2016 at 09:41:33 PM, Joe Hershberger wrote: > > Hi Marek, > > > > On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut wrote: > > > On Friday, January 22, 2016 at 08:50:04 PM, Joe Hershberger wrote: > > >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: > > >> > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > > >> > network adapters. > > >> > > > >> > Signed-off-by: Ted Chen > > >> > [swarren, fixed a few compiler warnings] > > >> > [swarren, with permission, converted license header to SPDX] > > >> > [swarren, removed printf() spew during probe()] > > >> > Signed-off-by: Stephen Warren > > >> > --- > > >> > > > >> > drivers/usb/eth/Makefile|1 + > > >> > drivers/usb/eth/r8152.c | 1456 > > >> > +++ drivers/usb/eth/r8152.h > > >> > > > >> > | 631 +++ > > >> > > > >> > drivers/usb/eth/r8152_fw.c | 980 + > > >> > drivers/usb/eth/usb_ether.c |7 + > > >> > include/usb_ether.h |6 + > > >> > 6 files changed, 3081 insertions(+) > > >> > create mode 100644 drivers/usb/eth/r8152.c > > >> > create mode 100644 drivers/usb/eth/r8152.h > > >> > create mode 100644 drivers/usb/eth/r8152_fw.c > > >> > > > >> > Changes for v2: Modified by Marek's comments. > > >> > - Remove pattern informations. > > >> > - Don't allocate & free when read/write register. > > >> > - relpace udelay to mdelay. > > >> > - pull firmware into global variable. > > >> > - code review. > > >> > > > >> > Changes for v3: Modified by Marek's and Joe's comments. > > >> > - Remove driver version informations. > > >> > - separate firmware code to individual file. > > >> > - split extensive defines to r8152.h. > > >> > - code review. > > >> > > > >> > Changes for v4: Modified by Marek's comments. > > >> > - remove the redundant code in generic_ocp_read and > > >> > generic_ocp_write. - remove redundant typecasting. > > >> > - collect the codes of busy waiting to rtl8152_reinit_ll and > > >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid having 0x00 as a > > >> > terminating entry of r8152_dongles. - using if (!ep_in_found && > > >> > (ep_addr & USB_DIR_IN)) ... to replace old version. - code review. > > >> > > > >> > Changes for v5: Modified by Marek's comments. > > >> > - add r8152_wait_for_bit to replace busy wait. > > >> > - change the name of patch4 to r8152b_set_dq_desc. > > >> > - add r8152_versions to store the hw's version. > > >> > > >> Acked-by: Joe Hershberger > > > > > > Do you want to pick this or shall I ? > > > > If there is some dependency (patch 1) that you will take first, you > > can just take this as well. > > I cannot find patch 1/2. > > Ted, can you repost both of the patches , so I can pick them ? I applied 2/2 to u-boot-usb since it seems harmless, but I still don't know what 1/2 is . Best regards, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Friday, January 22, 2016 at 09:41:33 PM, Joe Hershberger wrote: > Hi Marek, > > On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut wrote: > > On Friday, January 22, 2016 at 08:50:04 PM, Joe Hershberger wrote: > >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: > >> > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > >> > network adapters. > >> > > >> > Signed-off-by: Ted Chen > >> > [swarren, fixed a few compiler warnings] > >> > [swarren, with permission, converted license header to SPDX] > >> > [swarren, removed printf() spew during probe()] > >> > Signed-off-by: Stephen Warren > >> > --- > >> > > >> > drivers/usb/eth/Makefile|1 + > >> > drivers/usb/eth/r8152.c | 1456 > >> > +++ drivers/usb/eth/r8152.h > >> > > >> > | 631 +++ > >> > > >> > drivers/usb/eth/r8152_fw.c | 980 + > >> > drivers/usb/eth/usb_ether.c |7 + > >> > include/usb_ether.h |6 + > >> > 6 files changed, 3081 insertions(+) > >> > create mode 100644 drivers/usb/eth/r8152.c > >> > create mode 100644 drivers/usb/eth/r8152.h > >> > create mode 100644 drivers/usb/eth/r8152_fw.c > >> > > >> > Changes for v2: Modified by Marek's comments. > >> > - Remove pattern informations. > >> > - Don't allocate & free when read/write register. > >> > - relpace udelay to mdelay. > >> > - pull firmware into global variable. > >> > - code review. > >> > > >> > Changes for v3: Modified by Marek's and Joe's comments. > >> > - Remove driver version informations. > >> > - separate firmware code to individual file. > >> > - split extensive defines to r8152.h. > >> > - code review. > >> > > >> > Changes for v4: Modified by Marek's comments. > >> > - remove the redundant code in generic_ocp_read and generic_ocp_write. > >> > - remove redundant typecasting. > >> > - collect the codes of busy waiting to rtl8152_reinit_ll and > >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid having 0x00 as a > >> > terminating entry of r8152_dongles. - using if (!ep_in_found && > >> > (ep_addr & USB_DIR_IN)) ... to replace old version. - code review. > >> > > >> > Changes for v5: Modified by Marek's comments. > >> > - add r8152_wait_for_bit to replace busy wait. > >> > - change the name of patch4 to r8152b_set_dq_desc. > >> > - add r8152_versions to store the hw's version. > >> > >> Acked-by: Joe Hershberger > > > > Do you want to pick this or shall I ? > > If there is some dependency (patch 1) that you will take first, you > can just take this as well. I cannot find patch 1/2. Ted, can you repost both of the patches , so I can pick them ? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
Hi Marek, On Fri, Jan 22, 2016 at 2:00 PM, Marek Vasut wrote: > On Friday, January 22, 2016 at 08:50:04 PM, Joe Hershberger wrote: >> On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: >> > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB >> > network adapters. >> > >> > Signed-off-by: Ted Chen >> > [swarren, fixed a few compiler warnings] >> > [swarren, with permission, converted license header to SPDX] >> > [swarren, removed printf() spew during probe()] >> > Signed-off-by: Stephen Warren >> > --- >> > >> > drivers/usb/eth/Makefile|1 + >> > drivers/usb/eth/r8152.c | 1456 >> > +++ drivers/usb/eth/r8152.h >> > | 631 +++ >> > drivers/usb/eth/r8152_fw.c | 980 + >> > drivers/usb/eth/usb_ether.c |7 + >> > include/usb_ether.h |6 + >> > 6 files changed, 3081 insertions(+) >> > create mode 100644 drivers/usb/eth/r8152.c >> > create mode 100644 drivers/usb/eth/r8152.h >> > create mode 100644 drivers/usb/eth/r8152_fw.c >> > >> > Changes for v2: Modified by Marek's comments. >> > - Remove pattern informations. >> > - Don't allocate & free when read/write register. >> > - relpace udelay to mdelay. >> > - pull firmware into global variable. >> > - code review. >> > >> > Changes for v3: Modified by Marek's and Joe's comments. >> > - Remove driver version informations. >> > - separate firmware code to individual file. >> > - split extensive defines to r8152.h. >> > - code review. >> > >> > Changes for v4: Modified by Marek's comments. >> > - remove the redundant code in generic_ocp_read and generic_ocp_write. >> > - remove redundant typecasting. >> > - collect the codes of busy waiting to rtl8152_reinit_ll and >> > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid having 0x00 as a >> > terminating entry of r8152_dongles. - using if (!ep_in_found && (ep_addr >> > & USB_DIR_IN)) ... to replace old version. - code review. >> > >> > Changes for v5: Modified by Marek's comments. >> > - add r8152_wait_for_bit to replace busy wait. >> > - change the name of patch4 to r8152b_set_dq_desc. >> > - add r8152_versions to store the hw's version. >> >> Acked-by: Joe Hershberger > > Do you want to pick this or shall I ? If there is some dependency (patch 1) that you will take first, you can just take this as well. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Friday, January 22, 2016 at 08:50:04 PM, Joe Hershberger wrote: > On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: > > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > > network adapters. > > > > Signed-off-by: Ted Chen > > [swarren, fixed a few compiler warnings] > > [swarren, with permission, converted license header to SPDX] > > [swarren, removed printf() spew during probe()] > > Signed-off-by: Stephen Warren > > --- > > > > drivers/usb/eth/Makefile|1 + > > drivers/usb/eth/r8152.c | 1456 > > +++ drivers/usb/eth/r8152.h > > | 631 +++ > > drivers/usb/eth/r8152_fw.c | 980 + > > drivers/usb/eth/usb_ether.c |7 + > > include/usb_ether.h |6 + > > 6 files changed, 3081 insertions(+) > > create mode 100644 drivers/usb/eth/r8152.c > > create mode 100644 drivers/usb/eth/r8152.h > > create mode 100644 drivers/usb/eth/r8152_fw.c > > > > Changes for v2: Modified by Marek's comments. > > - Remove pattern informations. > > - Don't allocate & free when read/write register. > > - relpace udelay to mdelay. > > - pull firmware into global variable. > > - code review. > > > > Changes for v3: Modified by Marek's and Joe's comments. > > - Remove driver version informations. > > - separate firmware code to individual file. > > - split extensive defines to r8152.h. > > - code review. > > > > Changes for v4: Modified by Marek's comments. > > - remove the redundant code in generic_ocp_read and generic_ocp_write. > > - remove redundant typecasting. > > - collect the codes of busy waiting to rtl8152_reinit_ll and > > rtl8152_nic_reset. - use ARRAY_SIZE() to avoid having 0x00 as a > > terminating entry of r8152_dongles. - using if (!ep_in_found && (ep_addr > > & USB_DIR_IN)) ... to replace old version. - code review. > > > > Changes for v5: Modified by Marek's comments. > > - add r8152_wait_for_bit to replace busy wait. > > - change the name of patch4 to r8152b_set_dq_desc. > > - add r8152_versions to store the hw's version. > > Acked-by: Joe Hershberger Do you want to pick this or shall I ? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Wed, Jan 20, 2016 at 12:24 AM, Ted Chen wrote: > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > network adapters. > > Signed-off-by: Ted Chen > [swarren, fixed a few compiler warnings] > [swarren, with permission, converted license header to SPDX] > [swarren, removed printf() spew during probe()] > Signed-off-by: Stephen Warren > --- > drivers/usb/eth/Makefile|1 + > drivers/usb/eth/r8152.c | 1456 > +++ > drivers/usb/eth/r8152.h | 631 +++ > drivers/usb/eth/r8152_fw.c | 980 + > drivers/usb/eth/usb_ether.c |7 + > include/usb_ether.h |6 + > 6 files changed, 3081 insertions(+) > create mode 100644 drivers/usb/eth/r8152.c > create mode 100644 drivers/usb/eth/r8152.h > create mode 100644 drivers/usb/eth/r8152_fw.c > > Changes for v2: Modified by Marek's comments. > - Remove pattern informations. > - Don't allocate & free when read/write register. > - relpace udelay to mdelay. > - pull firmware into global variable. > - code review. > > Changes for v3: Modified by Marek's and Joe's comments. > - Remove driver version informations. > - separate firmware code to individual file. > - split extensive defines to r8152.h. > - code review. > > Changes for v4: Modified by Marek's comments. > - remove the redundant code in generic_ocp_read and generic_ocp_write. > - remove redundant typecasting. > - collect the codes of busy waiting to rtl8152_reinit_ll and > rtl8152_nic_reset. > - use ARRAY_SIZE() to avoid having 0x00 as a terminating entry of > r8152_dongles. > - using if (!ep_in_found && (ep_addr & USB_DIR_IN)) ... to replace old > version. > - code review. > > Changes for v5: Modified by Marek's comments. > - add r8152_wait_for_bit to replace busy wait. > - change the name of patch4 to r8152b_set_dq_desc. > - add r8152_versions to store the hw's version. Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
Hi Marek, On 21 January 2016 at 02:04, Marek Vasut wrote: > On Wednesday, January 20, 2016 at 09:10:07 PM, Anand Moon wrote: >> Hi Ted / Marek / Stephen, >> >> On 20 January 2016 at 22:22, Stephen Warren wrote: >> > On 01/19/2016 11:24 PM, Ted Chen wrote: >> >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB >> >> network adapters. >> > >> > This looks fine to me, although I didn't take a detailed enough look to >> > actually give and an ack/reviewed-by. >> >> What about the other patch: usb xhci Fix vendor command error if the >> request.patch > > Please repost it , make sure to CC everyone . If there is agreement that > it fixes real issue, I'll pick it. > >> After setting the usbether mac address my odroid xu4 board shop booting. >> even after reset of environment it dose not boot. >> --- >> -- U-Boot 2016.01-00406-g048c61d-dirty (Jan 21 >> 2016 - 06:27:09 +1030) for ODROID-XU3 >> >> CPU: Exynos5422 @ 800 MHz >> Model: Odroid XU3 based on EXYNOS5422 >> Board: Odroid XU3 based on EXYNOS5422 >> Type: xu4 >> DRAM: 2 GiB >> MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1 >> *** Warning - bad CRC, using default environment >> >> In:serial >> Out: serial >> Err: serial >> Net: No ethernet found. >> Hit any key to stop autoboot: 0 >> ODROID-XU3 # >> ODROID-XU3 # >> ODROID-XU3 # >> ODROID-XU3 # setenv usbethaddr 00:1e:06:31:06:b3 >> ODROID-XU3 # saveenv > > You ran saveenv, so usbethaddr is now in permanent storage. That's why > 'reset' won't help you. > But I need to set common mac address so that I will get single IP. I don't need random mac address. Any way thanks for your input. >> Saving Environment to MMC... >> Writing to MMC(0)... done >> ODROID-XU3 # usb info >> USB is stopped. Please issue 'usb start' first. >> ODROID-XU3 # usb start >> starting USB... >> USB0: USB EHCI 1.00 >> USB1: Register 2000140 NbrPorts 2 >> Starting the controller >> USB XHCI 1.00 >> USB2: Register 2000140 NbrPorts 2 >> Starting the controller >> USB XHCI 1.00 >> scanning bus 0 for devices... 1 USB Device(s) found >> scanning bus 1 for devices... Device not responding to set address. >> >> USB device not accepting new address (error=8000) > > This error looks suspicious. I had another wireless mouse and USB to Ethernet adapter connected to the board may be it's not getting recognized at that moment. Any way thanks for you input. > >> 2 USB Device(s) found >> scanning bus 2 for devices... 2 USB Device(s) found >>scanning usb for ethernet devices... 1 Ethernet Device(s) found > [...] Well I have tested the TFTP booting functionality of the board and it was success. Fell free to add my tested by for this version. Tested-by: Anand Moon Best Regards. -Anand Moon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Thursday, January 21, 2016 at 09:55:59 AM, Anand Moon wrote: > Hi Marek, > > On 21 January 2016 at 02:04, Marek Vasut wrote: > > On Wednesday, January 20, 2016 at 09:10:07 PM, Anand Moon wrote: > >> Hi Ted / Marek / Stephen, > >> > >> On 20 January 2016 at 22:22, Stephen Warren wrote: > >> > On 01/19/2016 11:24 PM, Ted Chen wrote: > >> >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > >> >> network adapters. > >> > > >> > This looks fine to me, although I didn't take a detailed enough look > >> > to actually give and an ack/reviewed-by. > >> > >> What about the other patch: usb xhci Fix vendor command error if the > >> request.patch > > > > Please repost it , make sure to CC everyone . If there is agreement that > > it fixes real issue, I'll pick it. > > > >> After setting the usbether mac address my odroid xu4 board shop booting. > >> even after reset of environment it dose not boot. > >> > >> --- -- U-Boot 2016.01-00406-g048c61d-dirty > >> (Jan 21 2016 - 06:27:09 +1030) for ODROID-XU3 > >> > >> CPU: Exynos5422 @ 800 MHz > >> Model: Odroid XU3 based on EXYNOS5422 > >> Board: Odroid XU3 based on EXYNOS5422 > >> Type: xu4 > >> DRAM: 2 GiB > >> MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1 > >> *** Warning - bad CRC, using default environment > >> > >> In:serial > >> Out: serial > >> Err: serial > >> Net: No ethernet found. > >> Hit any key to stop autoboot: 0 > >> ODROID-XU3 # > >> ODROID-XU3 # > >> ODROID-XU3 # > >> ODROID-XU3 # setenv usbethaddr 00:1e:06:31:06:b3 > >> ODROID-XU3 # saveenv > > > > You ran saveenv, so usbethaddr is now in permanent storage. That's why > > 'reset' won't help you. > > But I need to set common mac address so that I will get single IP. > I don't need random mac address. > > Any way thanks for your input. That was just a comment /wrt your observation that the board stops booting and reset doesn't fix it ;-) > >> Saving Environment to MMC... > >> Writing to MMC(0)... done > >> ODROID-XU3 # usb info > >> USB is stopped. Please issue 'usb start' first. > >> ODROID-XU3 # usb start > >> starting USB... > >> USB0: USB EHCI 1.00 > >> USB1: Register 2000140 NbrPorts 2 > >> Starting the controller > >> USB XHCI 1.00 > >> USB2: Register 2000140 NbrPorts 2 > >> Starting the controller > >> USB XHCI 1.00 > >> scanning bus 0 for devices... 1 USB Device(s) found > >> scanning bus 1 for devices... Device not responding to set address. > >> > >> USB device not accepting new address (error=8000) > > > > This error looks suspicious. > > I had another wireless mouse and USB to Ethernet adapter connected to the > board may be it's not getting recognized at that moment. > > Any way thanks for you input. Looks like something might be afoot with the controller itself ? > >> 2 USB Device(s) found > >> scanning bus 2 for devices... 2 USB Device(s) found > >> > >>scanning usb for ethernet devices... 1 Ethernet Device(s) found > > > > [...] > > Well I have tested the TFTP booting functionality of the board and it > was success. > Fell free to add my tested by for this version. > > Tested-by: Anand Moon Excellent, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
Hi Ted / Marek / Stephen, On 20 January 2016 at 22:22, Stephen Warren wrote: > On 01/19/2016 11:24 PM, Ted Chen wrote: >> >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB >> network adapters. > > > This looks fine to me, although I didn't take a detailed enough look to > actually give and an ack/reviewed-by. What about the other patch: usb xhci Fix vendor command error if the request.patch After setting the usbether mac address my odroid xu4 board shop booting. even after reset of environment it dose not boot. - U-Boot 2016.01-00406-g048c61d-dirty (Jan 21 2016 - 06:27:09 +1030) for ODROID-XU3 CPU: Exynos5422 @ 800 MHz Model: Odroid XU3 based on EXYNOS5422 Board: Odroid XU3 based on EXYNOS5422 Type: xu4 DRAM: 2 GiB MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1 *** Warning - bad CRC, using default environment In:serial Out: serial Err: serial Net: No ethernet found. Hit any key to stop autoboot: 0 ODROID-XU3 # ODROID-XU3 # ODROID-XU3 # ODROID-XU3 # setenv usbethaddr 00:1e:06:31:06:b3 ODROID-XU3 # saveenv Saving Environment to MMC... Writing to MMC(0)... done ODROID-XU3 # usb info USB is stopped. Please issue 'usb start' first. ODROID-XU3 # usb start starting USB... USB0: USB EHCI 1.00 USB1: Register 2000140 NbrPorts 2 Starting the controller USB XHCI 1.00 USB2: Register 2000140 NbrPorts 2 Starting the controller USB XHCI 1.00 scanning bus 0 for devices... 1 USB Device(s) found scanning bus 1 for devices... Device not responding to set address. USB device not accepting new address (error=8000) 2 USB Device(s) found scanning bus 2 for devices... 2 USB Device(s) found scanning usb for ethernet devices... 1 Ethernet Device(s) found ODROID-XU3 # usb info 1: Hub, USB Revision 2.0 - u-boot EHCI Host Controller - Class: Hub - PacketSize: 64 Configurations: 1 - Vendor: 0x Product 0x Version 1.0 Configuration: 1 - Interfaces: 1 Self Powered 0mA Interface: 0 - Alternate Setting 0, Endpoints: 1 - Class Hub - Endpoint 1 In Interrupt MaxPacket 8 Interval 255ms 1: Hub, USB Revision 3.0 - U-Boot XHCI Host Controller - Class: Hub - PacketSize: 9 Configurations: 1 - Vendor: 0x Product 0x Version 1.0 Configuration: 1 - Interfaces: 1 Self Powered 0mA Interface: 0 - Alternate Setting 0, Endpoints: 1 - Class Hub - Endpoint 1 In Interrupt MaxPacket 8 Interval 255ms 2: Hub, USB Revision 2.10 - GenesysLogic USB2.0 Hub - Class: Hub - PacketSize: 64 Configurations: 1 - Vendor: 0x05e3 Product 0x0610 Version 146.34 Configuration: 1 - Interfaces: 1 Self Powered Remote Wakeup 100mA Interface: 0 - Alternate Setting 0, Endpoints: 1 - Class Hub - Endpoint 1 In Interrupt MaxPacket 1 Interval 12ms - Endpoint 1 In Interrupt MaxPacket 1 Interval 12ms 1: Hub, USB Revision 3.0 - U-Boot XHCI Host Controller - Class: Hub - PacketSize: 9 Configurations: 1 - Vendor: 0x Product 0x Version 1.0 Configuration: 1 - Interfaces: 1 Self Powered 0mA Interface: 0 - Alternate Setting 0, Endpoints: 1 - Class Hub - Endpoint 1 In Interrupt MaxPacket 8 Interval 255ms 2: Vendor specific, USB Revision 2.10 - Realtek USB 10/100/1000 LAN 0100 - Class: (from Interface) Vendor specific - PacketSize: 64 Configurations: 2 - Vendor: 0x0bda Product 0x8153 Version 48.0 Configuration: 1 - Interfaces: 1 Bus Powered Remote Wakeup 180mA Interface: 0 - Alternate Setting 0, Endpoints: 3 - Class Vendor specific - Endpoint 1 In Bulk MaxPacket 512 - Endpoint 2 Out Bulk MaxPacket 512 - Endpoint 3 In Interrupt MaxPacket 2 Interval 8ms ODROID-XU3 # reset resetting ... U-Boot 2016.01-00406-g048c61d-dirty (Jan 21 2016 - 06:27:09 +1030) for ODROID-XU3 CPU: Exynos5422 @ 800 MHz Model: Odroid XU3 based on EXYNOS5422 Board: Odroid XU3 based on EXYNOS5422 Type: xu4 DRAM: 2 GiB MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1 In:serial Out: serial Err: serial Net: No ethernet found. Hit any key to stop autoboot: 0 Card did not respond to voltage select! switch to partitions #0, OK mmc0 is current device Scanning mmc 0:1... Found U-Boot script /boot.scr reading /boot.scr 3033 bytes read in 3 ms (987.3 KiB/s) ## Executing script at 5000 Found kernel image: zImage reading exynos5422-odroidxu4.dtb 50674 bytes read in 9 ms (5.4 MiB/s) Found ramdisk image. reading uInitrd 2159156 bytes read in 127 ms (16.2 MiB/s) reading zImage 3225648 bytes read in 187 ms (16.4 MiB/s) Kernel image @ 0x40007fc0 [ 0x00 - 0x313830 ] ## Loading init Ramdisk from Legacy Image at 4200 ... Image Name: uInitrd 3.10.92 Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size:2159092 Bytes = 2.1 MiB Load Address: Entry Point: Verifying Checksum ... OK ## Flattened Device Tree blob at
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Wednesday, January 20, 2016 at 09:10:07 PM, Anand Moon wrote: > Hi Ted / Marek / Stephen, > > On 20 January 2016 at 22:22, Stephen Warren wrote: > > On 01/19/2016 11:24 PM, Ted Chen wrote: > >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > >> network adapters. > > > > This looks fine to me, although I didn't take a detailed enough look to > > actually give and an ack/reviewed-by. > > What about the other patch: usb xhci Fix vendor command error if the > request.patch Please repost it , make sure to CC everyone . If there is agreement that it fixes real issue, I'll pick it. > After setting the usbether mac address my odroid xu4 board shop booting. > even after reset of environment it dose not boot. > --- > -- U-Boot 2016.01-00406-g048c61d-dirty (Jan 21 > 2016 - 06:27:09 +1030) for ODROID-XU3 > > CPU: Exynos5422 @ 800 MHz > Model: Odroid XU3 based on EXYNOS5422 > Board: Odroid XU3 based on EXYNOS5422 > Type: xu4 > DRAM: 2 GiB > MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1 > *** Warning - bad CRC, using default environment > > In:serial > Out: serial > Err: serial > Net: No ethernet found. > Hit any key to stop autoboot: 0 > ODROID-XU3 # > ODROID-XU3 # > ODROID-XU3 # > ODROID-XU3 # setenv usbethaddr 00:1e:06:31:06:b3 > ODROID-XU3 # saveenv You ran saveenv, so usbethaddr is now in permanent storage. That's why 'reset' won't help you. > Saving Environment to MMC... > Writing to MMC(0)... done > ODROID-XU3 # usb info > USB is stopped. Please issue 'usb start' first. > ODROID-XU3 # usb start > starting USB... > USB0: USB EHCI 1.00 > USB1: Register 2000140 NbrPorts 2 > Starting the controller > USB XHCI 1.00 > USB2: Register 2000140 NbrPorts 2 > Starting the controller > USB XHCI 1.00 > scanning bus 0 for devices... 1 USB Device(s) found > scanning bus 1 for devices... Device not responding to set address. > > USB device not accepting new address (error=8000) This error looks suspicious. > 2 USB Device(s) found > scanning bus 2 for devices... 2 USB Device(s) found >scanning usb for ethernet devices... 1 Ethernet Device(s) found [...] ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On 01/19/2016 11:24 PM, Ted Chen wrote: This patch adds driver support for the Realtek RTL8152B/RTL8153 USB network adapters. This looks fine to me, although I didn't take a detailed enough look to actually give and an ack/reviewed-by. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
On Wednesday, January 20, 2016 at 07:24:52 AM, Ted Chen wrote: > This patch adds driver support for the Realtek RTL8152B/RTL8153 USB > network adapters. > > Signed-off-by: Ted Chen > [swarren, fixed a few compiler warnings] > [swarren, with permission, converted license header to SPDX] > [swarren, removed printf() spew during probe()] > Signed-off-by: Stephen Warren Looks good, Acked-by: Marek Vasut Let's see if others have any comments and I can pick it then. [...] Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
