Re: [U-Boot-Users] [PATCH] FIT: Fix handling of images without ramdisks

[Michal Simek]

Yes, you are right. I tested it and works.

Ack-by: Michal Simek <[EMAIL PROTECTED]>

WD: This is bug fix - can you please handle this bug directly to your tree.

Thanks,
Michal


> boot_get_ramdisk() should not treat the case when a FIT image does not 
> contain a
> ramdisk as an error.
> 
> Signed-off-by: Peter Tyser <[EMAIL PROTECTED]>
> ---
> The original code would not allow booting of a FIT image which didn't contain 
> a
> ramdisk.  The bug was observed and fixed on a powerpc 85xx system.
> 
>  common/image.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/image.c b/common/image.c
> index 535c302..c3545a7 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -833,7 +833,7 @@ int boot_get_ramdisk (int argc, char *argv[],
> bootm_headers_t *images,
>   rd_noffset = fit_conf_get_ramdisk_node (fit_hdr, 
> cfg_noffset);
>   if (rd_noffset < 0) {
>   debug ("*  ramdisk: no ramdisk in config\n");
> - return 1;
> + return 0;
>   }
>   }
>  #endif
> -- 
> 1.5.4.3
> 
> 

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] FIT: Fix handling of images without ramdisks

[Michal Simek]

Hi Peter,


> I've included my kernel_fdt.its below as well as 2 boot attempts with
> some debug enabled - the 1st on without the patch, the 2nd with the
> patch.  I'm using the mainline master (based on
> 1953d128fd07f07d1c3810a28c0863ea64dae1b6), not the 85xx repo, but I
> believe the problem exists in both repos.

OK. I will test it today and send you my result.

> Conceptually, I believe the patch makes sense.  I'm calling bootm with
> no arguments (as seen in the FIT howto.txt), so boot_get_ramdisk() is
> unconditionally called by do_bootm_linux().  With no command arguments
> and a FIT image this section of code in boot_get_ramdisk() gets called:
> 
> rd_noffset = fit_conf_get_ramdisk_node (fit_hdr, cfg_noffset);
> if (rd_noffset < 0) {
>   debug ("*  ramdisk: no ramdisk in config\n");
>   return 1;
> }
> 
> which returns 1 causing the calling code from do_bootm_linux() to error
> out:
> 
> /* find ramdisk */
> ret = boot_get_ramdisk (argc, argv, images, IH_ARCH_PPC,
>   &rd_data_start, &rd_data_end);
> if (ret)
>   goto error;

I'll look at it in detail. Please wait some hours.


> Did you by chance try testing a PPC board?  I noticed the
> boot_get_ramdisk() call is not used for microblaze.

Sorry but I don't have any ppc board.
Yes, it is but this code is not in master or microblaze branch but I sent first
patch to mailing list some week ago.

Regards,
Michal

> Thanks!
> Peter
> 
> 
>>> Contents of kernel_fdt.its
>>>
> 
> / {
>   description = "Basic image with single Linux kernel and FDT blob";
>   #address-cells = <1>;
> 
>   images {
>   [EMAIL PROTECTED] {
>   description = "X-ES MPC8572 Kernel v2.6.23";
>   data = /incbin/("./vmlinux.bin.gz");
>   type = "kernel";
>   arch = "ppc";
>   os = "linux";
>   compression = "gzip";
>   load = <>;
>   entry = <>;
>   [EMAIL PROTECTED] {
>   algo = "crc32";
>   };
>   };
>   [EMAIL PROTECTED] {
>   description = "Flattened Device Tree blob";
>   data = /incbin/("./xpedite5370.dtb");
>   type = "flat_dt";
>   arch = "ppc";
>   load = <00c0>;
>   compression = "none";
>   [EMAIL PROTECTED] {
>   algo = "crc32";
>   };
>   };
>   };
> 
>   configurations {
>   default = "[EMAIL PROTECTED]";
>   [EMAIL PROTECTED] {
>   description = "Boot Linux kernel with FDT blob";
>   kernel = "[EMAIL PROTECTED]";
>   fdt = "[EMAIL PROTECTED]";
>   };
>   };
> };
> 
>>> Without the patch applied
>>>
> 
> => imi
> 
> ## Checking Image at 0100 ...
>FIT image found
>FIT description: Basic image with single Linux kernel and FDT blob
>Created: 2008-08-06  20:47:47 UTC
> Image 0 ([EMAIL PROTECTED])
>  Description:  X-ES MPC8572 Kernel v2.6.23
>  Type: Kernel Image
>  Compression:  gzip compressed
>  Data Start:   0x01f0
>  Data Size:3947406 Bytes =  3.8 MB
>  Architecture: PowerPC
>  OS:   Linux
>  Load Address: 0x
>  Entry Point:  0x
>  Hash node:'[EMAIL PROTECTED]'
>  Hash algo:crc32
>  Hash value:   10a29645
>  Hash len: 4
> Image 1 ([EMAIL PROTECTED])
>  Description:  Flattened Device Tree blob
>  Type: Flat Device Tree
>  Compression:  uncompressed
>  Data Start:   0x013c3d64
>  Data Size:9628 Bytes =  9.4 kB
>  Architecture: PowerPC
>  Hash node:'[EMAIL PROTECTED]'
>  Hash algo:crc32
>  Hash value:   b351fc1d
>  Hash len: 4
> Default Configuration: '[EMAIL PROTECTED]'
> Configuration 0 ([EMAIL PROTECTED])
>  Description:  Boot Linux kernel with FDT blob
>  Kernel:   [EMAIL PROTECTED]
>  FDT:  [EMAIL PROTECTED]
> => bootm
> *  kernel: default image load address = 0x0100
> ## Booting kernel from FIT Image at 0100 ...
> No configuration specified, trying default...
> Found default configuration: '[EMAIL PROTECTED]'
>Using '[EMAIL PROTECTED]' configuration
>Trying '[EMAIL PROTECTED]' kernel subimage
>  Description:  X-ES MPC8572 Kernel v2.6.23
>  Type: Kernel Image
>  Compression:  gzip compressed
>  Data Start:   0x01f0
>  Data Size:3947406 Bytes =  3.8 MB
>  Architecture: PowerPC
>  OS:   Linux
>  Load Address: 0x
>  Entry Point:  0x
>  Hash node:'[EMAIL PROTECTED]'
>  Hash algo:crc32
>  Hash value:   10a29645
>  Hash le

Re: [U-Boot-Users] [PATCH] FIT: Fix handling of images without ramdisks

[Michal Simek]

Hi Peter,

I tested current head on my boards and I have no problem with it.
Can you post your config part where you have problem?
And I look at 85xx repo and I haven't found this fix there. The last patch on
master branch in mine.

Regards,
Michal Simek



> boot_get_ramdisk() should not treat the case when a FIT image does not 
> contain a ramdisk as an error.
> 
> Signed-off-by: Peter Tyser <[EMAIL PROTECTED]>
> ---
> The original code would not allow booting of a FIT image which didn't contain 
> a ramdisk.  The bug was observed and fixed on a powerpc 85xx system.
> 
>  common/image.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/image.c b/common/image.c
> index 535c302..c3545a7 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -833,7 +833,7 @@ int boot_get_ramdisk (int argc, char *argv[], 
> bootm_headers_t *images,
>   rd_noffset = fit_conf_get_ramdisk_node (fit_hdr, 
> cfg_noffset);
>   if (rd_noffset < 0) {
>   debug ("*  ramdisk: no ramdisk in config\n");
> - return 1;
> + return 0;
>   }
>   }
>  #endif

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] U-Boot v1.3.4-rc2 released

[Michal Simek]

Hi Wolfgang,

Microblaze boards are without any warnings.

I sent some patches about Makefiles(driver folder and others)  two weeks ago - 
but they need some testing. 
These patches should go to next merge window.

Regards,
Michal


> Hello everybody,
> 
> I have released U-Boot v1.3.4-rc2, and it is available both from the
> git repository and the FTP server.
> 
> Please help testing.
> 
> Please also check if all your patches that you want to have  included
> in  v1.3.4  have really been added - I don't have anything pending on
> my list, but I might have missed something.
> 
> If nothing bad pops up, we might have a new release soon... :-)
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> "Athens  built  the  Acropolis.  Corinth  was  a   commercial   city,
> interested  in  purely  materialistic things. Today we admire Athens,
> visit it, preserve the old temples, yet we hardly ever  set  foot  in
> Corinth."  - Dr. Harold Urey, Nobel Laureate in chemistry
> 
> -
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ___
> U-Boot-Users mailing list
> U-Boot-Users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> 
> 
> 

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/1] Add support for the hammerhead (AVR32) board

[Michal Simek]

Could someone explain me what this message has relation with AVR32?
This is 100% microblaze relate problems.
Please change subject and cc to me if you have any problem with latest U-BOOT
for Microblaze.

Michal Simek



> Hi John,
> 
> look at
> http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/archive/2008/05/msg00163.html
> 
> Please use 
> 
>> Hi, again.
>>
>> I've used a new vendor/platform, I have the uclinux running in the same
>> target a ML501 with an older version based on ise and edk 8.2, but I need
>> approach the advantages of microblaze v7.00 and the PLB. Please thanks for
>> your help, and excuse my English.
>>
>> I don't know about inittab, and that init is selected in the application
>> menu.
>>
>>
>> 2008/7/24 Mostafa Ali <[EMAIL PROTECTED]>:
>>
>>> Look there are so many reasons for this problem, Please mention more
>>> detalis(like have you used one of the predefined platforms in the
>>> vendor/platform menu or you created a new one).
>>>
>>> One of the reasons is that the kernel doesn't find a start up application.
>>> Make sure that inittab is exist in /romfs and init is selected in the
>>> application menu in petalinux configuration wizard. I need more de tails fro
>>> you, I'll be waiting.
>>>
>>> --- On *Thu, 7/24/08, John Osorio <[EMAIL PROTECTED]>* wrote:
>>>
>>> From: John Osorio <[EMAIL PROTECTED]>
>>> Subject: [microblaze-uclinux] Help with kernel boot, PLEASE
>>> To: [EMAIL PROTECTED]
>>> Date: Thursday, July 24, 2008, 8:36 AM
>>>
>>>
>>>  Hi, folks
>>>
>>> I have a problem with the kernel boot, I'm using petalinux-v0.30-rc1 and
>>> kernel 2.6, my hardware is development under EDK 9.2_02 and ISE 9.2_04. When
>>> I'll try boot the image, the boot show in kermit the following:
>>>
>>>
>>> ## Booting image at 8c08 ...
>>>Image Name:   PetaLinux Kernel 2.6
>>>Image Type:   Microblaze Linux Kernel Image (uncompressed)
>>>Data Size:2678812 Bytes =  2.6 MB
>>>Load Address: 9000
>>>Entry Point:  9000
>>>Verifying Checksum ... OK
>>> OK
>>>
>>> That's  all I don't know, what's the problem, Please I need your Help, Bye.
>>> The boot is freeze, Kermit don't show anything
>>>
>>> --
>>> John Osorio
>>>
>>>
>>>
>>
>> -- 
>> John Osorio
>>
>>
>>
> 
> No virus found in this incoming message.
> Checked by AVG - http://www.avg.com 
> Version: 8.0.138 / Virus Database: 270.5.5/1571 - Release Date: 24.7.2008 
> 05:42
> 
> 
> 

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C EEPROM simulator (Resubmit)

[Michal Simek]

for, if

M

> Hello Michal
> 
>   No hints about where are this codyng style issues?
> 
>  Best regards
> 
> 
> 
> 

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C EEPROM simulator (Resubmit)

[Michal Simek]

still coding style issues.

M

> This driver provides access to a simulated i2c eeprom.
> This simulated eeprom could be very useful in boards with
> ddr2 memories and no i2c interfaces.
> 
> Using this driver the user can simulate a spd eeprom
> of a ddr2 memory and use the ddr2 auto config.
> 
> User can use the macros CONFIG_EEPROM_SIMUL_LEN
> and CONFIG_EEPROM_SIMUL_DATA to define the content
> of the simulated eeprom
> 
> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/i2c/Makefile   |1 +
>  drivers/i2c/eeprom_simul.c |   68 
> 
>  2 files changed, 69 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/eeprom_simul.c
> 
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index 534c015..2aeabe5 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
>  COBJS-y += omap24xx_i2c.o
>  COBJS-y += tsi108_i2c.o
>  COBJS-y += mxc_i2c.o
> +COBJS-$(CONFIG_EEPROM_SIMUL) += eeprom_simul.o
>  
>  COBJS:= $(COBJS-y)
>  SRCS := $(COBJS:.o=.c)
> diff --git a/drivers/i2c/eeprom_simul.c b/drivers/i2c/eeprom_simul.c
> new file mode 100644
> index 000..d8dbb3b
> --- /dev/null
> +++ b/drivers/i2c/eeprom_simul.c
> @@ -0,0 +1,68 @@
> +/*
> +(C) Copyright 2008
> +Ricado Ribalda-Universidad Autonoma de [EMAIL PROTECTED]
> +This work has been supported by: QTechnology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 2 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +
> +#include 
> +#include 
> +
> +#ifndef CONFIG_EEPROM_SIMUL_LEN
> +#define CONFIG_EEPROM_SIMUL_LEN 256
> +#endif
> +
> +u8 eeprom_simul_buffer[CONFIG_EEPROM_SIMUL_LEN]
> +#ifdef CONFIG_EEPROM_SIMUL_DATA
> +   = CONFIG_EEPROM_SIMUL_DATA
> +#endif
> +;
> +
> +void i2c_init(int speed, int slaveaddr){
> +   return ;
> +}
> +
> +int i2c_read(uchar chip, uint addr, int alen, uchar * buffer, int len)
> +{
> +   int i;
> +
> +   if (addr+len>CONFIG_EEPROM_SIMUL_LEN)
> +   return -1;
> +
> +   for(i=0;i +   buffer[i]=eeprom_simul_buffer[i+addr];
> +   }
> +
> +   return 0;
> +}
> +int i2c_write(uchar chip, uint addr, int alen, uchar * buffer, int len)
> +{
> +   int i;
> +
> +   if (addr+len>CONFIG_EEPROM_SIMUL_LEN)
> +   return -1;
> +
> +   for(i=0;i +   eeprom_simul_buffer[i+addr]=buffer[i];
> +   }
> +
> +   return 0;
> +}
> +
> +int i2c_probe(uchar chip)
> +{
> +   return 0;
> +}
> +

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] ppc4xx: [PATCH] ML507 Board Support

[Michal Simek]

> Added Flash Support
> 
> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  CREDITS  |5 ++
>  MAINTAINERS  |4 +
>  MAKEALL  |1 +
>  Makefile |3 +
>  board/xilinx/ml507/Makefile  |   58 +
>  board/xilinx/ml507/config.mk |   24 +++
>  board/xilinx/ml507/init.S|   47 ++
>  board/xilinx/ml507/ml507.c   |   46 +
>  board/xilinx/ml507/u-boot.lds|  130 
> ++
>  board/xilinx/ml507/xparameters.h |   35 ++
>  include/configs/ml507.h  |  116 +
>  11 files changed, 469 insertions(+), 0 deletions(-)
>  create mode 100644 board/xilinx/ml507/Makefile
>  create mode 100644 board/xilinx/ml507/config.mk
>  create mode 100644 board/xilinx/ml507/init.S
>  create mode 100644 board/xilinx/ml507/ml507.c
>  create mode 100644 board/xilinx/ml507/u-boot.lds
>  create mode 100644 board/xilinx/ml507/xparameters.h
>  create mode 100644 include/configs/ml507.h
> 
> diff --git a/CREDITS b/CREDITS
> index 3b6e57d..06e78bf 100644
> --- a/CREDITS
> +++ b/CREDITS
> @@ -399,6 +399,11 @@ N: Stelian Pop
>  E: [EMAIL PROTECTED]
>  D: Atmel AT91CAP9ADK support
>  
> +N: Ricardo Ribalda Delgado
> +E: [EMAIL PROTECTED]
> +D: PPC440x5 (Virtex5), ML507 Board, eeprom_simul, adt7460
> +W: http://www.ii.uam.es/~rribalda
> +
>  N: Stefan Roese
>  E: [EMAIL PROTECTED]
>  D: AMCC PPC4xx Support
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b667c8e..75b5b02 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -311,6 +311,10 @@ Daniel Poirot <[EMAIL PROTECTED]>
>   sbc8240 MPC8240
>   sbc405  PPC405GP
>  
> +Ricardo Ribalda <[EMAIL PROTECTED]>
> +
> + ml507   PPC440x5
> +
>  Stefan Roese <[EMAIL PROTECTED]>
>  
>   P3M7448 MPC7448
> diff --git a/MAKEALL b/MAKEALL
> index a256e9a..5463a58 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -239,6 +239,7 @@ LIST_4xx="\
>   yosemite\
>   yucca   \
>   zeus\
> + ml507   \
>  "

keep list sorted

>  #
> diff --git a/Makefile b/Makefile
> index 10a3e06..40029e6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1336,6 +1336,9 @@ ML2_config: unconfig
>  ml300_config:unconfig
>   @$(MKCONFIG) $(@:_config=) ppc ppc4xx ml300 xilinx
>  
> +ml507_config:unconfig
> + @$(MKCONFIG) $(@:_config=) ppc ppc4xx ml507 xilinx
> +
>  ocotea_config:   unconfig
>   @$(MKCONFIG) $(@:_config=) ppc ppc4xx ocotea amcc
>  
> diff --git a/board/xilinx/ml507/Makefile b/board/xilinx/ml507/Makefile
> new file mode 100644
> index 000..b9bd737
> --- /dev/null
> +++ b/board/xilinx/ml507/Makefile
> @@ -0,0 +1,58 @@
> +#
> +# (C) Copyright 2000-2006
> +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +ifneq ($(OBJTREE),$(SRCTREE))
> +endif
> +
> +INCS :=
> +CFLAGS   += $(INCS)
> +HOST_CFLAGS  += $(INCS)
> +
> +LIB  = $(obj)lib$(BOARD).a
> +
> +COBJS= $(BOARD).o \

why is back-slash here?

> +SOBJS= init.o
> +
> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS))
> +SOBJS:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):  $(OBJS) $(SOBJS)
> + $(AR) $(ARFLAGS) $@ $^
> +
> +clean:
> + rm -f $(SOBJS) $(OBJS)
> +
> +distclean:   clean
> + rm -f $(LIB) core *.bak .depend
> +
> +#
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#
> diff --git a/board/xilinx/ml507/config.mk b/board/xilinx/ml507/config.mk
> new file mode 100644
> index 000..35c52ad
> --- /dev/null
> +++ b/board/xilinx/ml507/config.mk
> @@ -0,0 +1,24 @@
> +#
> +# (C) Copyright 2000
> +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
> +

Re: [U-Boot-Users] [PATCH 1/1] v2: coding style cleaning for sc520_spunk

[Michal Simek]

Hi Jean,

> > From: Michal Simek <[EMAIL PROTECTED]>
> > 
> > there are some long lines in config file
> > but this patches clean a lot of coding style issues
> > 
> > There could be small problem with Daniel name.
> > Please check it in merge
> > 
> > Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
> > ---
> >  include/configs/sc520_spunk.h |  138
> +++--
> >  1 files changed, 63 insertions(+), 75 deletions(-)
> > 
> > diff --git a/include/configs/sc520_spunk.h b/include/configs/sc520_spunk.h
> > index 051b2e0..179ecdf 100644
> > --- a/include/configs/sc520_spunk.h
> > +++ b/include/configs/sc520_spunk.h
> > @@ -1,6 +1,6 @@
> >  /*
> >   * (C) Copyright 2002
> > - * Daniel Engstr?m, Omicron Ceti AB, [EMAIL PROTECTED]
> > + * Daniel Engstr�m, Omicron Ceti AB, [EMAIL PROTECTED]
> >   *
> >   * See file CREDITS for list of people who contributed to this
> >   * project.
> > @@ -12,7 +12,7 @@
> >   *
> >   * This program is distributed in the hope that it will be useful,
> >   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> Please do not modify generic licence header

This is absurd tab in header which should be removed from all licenses in 
U-BOOT.


> >   * GNU General Public License for more details.
> >   *
> >   * You should have received a copy of the GNU General Public License
> > @@ -33,38 +33,36 @@
> >   * (easy to change)
> >   */
> >  #define CONFIG_BOOTDELAY   15
> > -#define CONFIG_BOOTARGS"root=/dev/mtdblock1 console=ttyS0,9600 
> > " \
> > -   "mtdparts=phys:7936k(root),256k(uboot) "
> > -#define CONFIG_BOOTCOMMAND "setenv bootargs root=/dev/nfs ip=autoconf " \
> > -   "console=ttyS0,9600 " \
> > -   
> > "mtdparts=phys:7808k(root),128k(env),256k(uboot);" \
> > -   "bootp;bootm"
> > +#define CONFIG_BOOTARGS"root=/dev/mtdblock1 console=ttyS0,9600
> mtdparts=phys:7936k(root),256k(uboot) "
> > +#define CONFIG_BOOTCOMMAND "setenv bootargs root=/dev/nfs ip=autoconf
> console=ttyS0,9600 mtdparts=phys:7808k(root),128k(env),256k(uboot); bootp;
> bootm"
> too long, please let the previous way

I know there are some long lines.

M


> >  
> >  #if defined(CONFIG_CMD_KGDB)
> >  #define CONFIG_KGDB_BAUDRATE   115200  /* speed to run kgdb 
> > serial port */
> >  #define CONFIG_KGDB_SER_INDEX  2   /* which serial port to 
> > use */
> >  #endif
> 
> Please be carreful about the 80 characters limits
> 
> Best Regards,
> J.
> 
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] CPU PPC440x5 on Virtex5 FX

[Michal Simek]

> > You are right, but I cannot see how to share code between
> > architechtures... If WD don't have a good idea we should have here the
> > xilinx iic code repeated.
> 
> No. Duplicating code is never a good idea.
 
I agree. 

Michal
 
> Best regards,
> 
> Wolfgang Denk

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] CPU PPC440x5 on Virtex5 FX

[Michal Simek]

Hi Ricardo,

> Hi Michal
> 
>   I am trying to solve the xilinx irq I have some questions:
> 
>   1) Where can I find the official u-boot bsp for edk?
> http://git.monstr.eu/ is dead

yes. git.monstr.eu was temporary down because I was changing my servers. 
currently is server up.

>   2) Do we really need a new bsp for this? Can't we just use the
> Linux_2_6. I just need a couple of definitions...
 
No. we don't need new BSP for this. The BSP exists more than year.
http://git.monstr.eu/cgi-bin/gitweb.cgi?p=u-boot-bsp.git;a=summary
and description is at:
http://www.monstr.eu/wiki/doku.php?id=uboot:uboot

Could you send me your mhs and mss file? I'll add it to u-boot bsp and I send 
you bsp and output.

Thanks,
Michal



 
>Best Regards
> 
> 
> 
> -- 
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
> 
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/1] FIS: repare incorrect return value with ramdisk handling

[Michal Simek]

Look good.

Thanks,
Michal Simek


> In message <[EMAIL PROTECTED]> you wrote:
>> From: Michal Simek <[EMAIL PROTECTED]>
>>
>> Microblaze and PowerPC use boot_get_ramdisk for loading
>> ramdisk to memory with checking return value.
>> Return 0 means success. Return 1 means failed.
>> Here is correspond part of code from bootm.c which check
>> return code.
>>
>> ret = boot_get_ramdisk (argc, argv, images, IH_ARCH_PPC,
>>  &rd_data_start, &rd_data_end);
>> if (ret)
>>  goto error;
>>
>> Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
>> ---
>>  common/image.c |   16 
>>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> As far as I can tell this is exactly the same patch as submitted
> earlier. I think this was just by mistake?
> 
> I committed the first one - please check.
> 
> Best regards,
> 
> Wolfgang Denk
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] CPU PPC440x5 on Virtex5 FX

[Michal Simek]

>> In message <[EMAIL PROTECTED]> you wrote:
>>> 2. I don't know if is good idea to create drivers for interrupt
>>> controllers.
>> I have to admit that such an idea surprises me a bit.
>>
>>> If yes xilinx_intc.c, will be better.
>>> I will wait for WD comments.
>> In my opinion an interrupt controller is fundamentally different from
>> an device that is handled by a device driver. It therefore has no
>> place in the drivers/ directory.
> 
> Yes, I was hesitating here too. Only other idea that comes to my mind is:
> 
> cpu/xilinx/interrupt.c
>
> Better?
>
xilinx is not type of cpu. :-( I'll think about smarter way.

Best regards,
Michal


> Best regards,
> Stefan
> 
> =
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]
> =
> 
> No virus found in this incoming message.
> Checked by AVG - http://www.avg.com 
> Version: 8.0.138 / Virus Database: 270.4.7/1545 - Release Date: 10.7.2008 
> 06:43
> 
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] CPU PPC440x5 on Virtex5 FX

[Michal Simek]

Hi Stefan,


>> Some days ago a sent to mailing list patch (currently is in) where I rename
>> CONFIG_XILINX_ML300 -> CONFIG_XILINX_405.
>>
>> I would like to see if you can use the same style for 440 ->
>> CONFIG_XILINX_440. I have no detail information about ppc440 but IMHO only
>> virtex5 fx (or whatever) support it -> make no sense to me use virtex5 in
>> name.
>>
>> SR: Do you agree with me?
> 
> Yes, renaming this to CONFIG_XILINX_440 is a good idea.

nice to hear.

>> There is big part of code relate with interrupt controller which is the
>> same with microblaze. This should be handled in the same way. Any
>> suggestion? (Do generic driver?)
> 
> Yes, I already mentioned in my review, that this code should go into a 
> separate file. If the microblaze implementation is the same or very similar 
> then please use the same code here and move to to a common directory. 
> Perhaps:
> 
> drivers/interrupt/xilinx.c ?
> 
> Comments?

1. use macros names which are in microblaze xparameters.h. These values are
generate by u-boot BSP. Add ppc440 to it solves your problem with generic 
boards.
2. I don't know if is good idea to create drivers for interrupt controllers.
If yes xilinx_intc.c, will be better.
I will wait for WD comments.

>>
>> BTW: some comments in code.
> 
> Michal, your comments are very hard to spot since you don't quote the 
> original 
> code by "> ".

I used web based email which is ...

Michal

> Best regards,
> Stefan
> 
> =
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]
> =
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] New Dummy I2C Driver

[Michal Simek]

>> This driver provides access to a false i2c eeprom.
>>  This false eeprom could be very useful in boards with
>>  ddr2 memories and no i2c interfaces.
>>  Using this driver the user can simulate the spd interface
>>  of the ddr2 memory and use the ddr2 auto config
> 
> Hi Ricardo:
> 
> Nitpicking - "fake" would be a better word than "false" in this context. 
>   I wouldn't reroll the patch for this, but if you reroll it for some 
> other reason...
> 
> Thanks,
> gvb

:-)
M

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] ML507: New board support

[Michal Simek]

my comments are below



-Suport for the Xilinx ML507 Development Board

Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 Makefile|3 +
 board/xilinx/ml507/Makefile |   53 
 board/xilinx/ml507/config.mk|   18 
 board/xilinx/ml507/init.S   |   45 +++
 board/xilinx/ml507/ml507.c  |   57 +
 board/xilinx/ml507/u-boot.lds   |  149 +++
 board/xilinx/ml507/u-boot.lds.debug |  136 
 board/xilinx/ml507/xparameters.h|   33 
 include/configs/ml507.h |  108 +
 9 files changed, 602 insertions(+), 0 deletions(-)
 create mode 100644 board/xilinx/ml507/Makefile
 create mode 100644 board/xilinx/ml507/config.mk
 create mode 100644 board/xilinx/ml507/init.S
 create mode 100644 board/xilinx/ml507/ml507.c
 create mode 100644 board/xilinx/ml507/u-boot.lds
 create mode 100644 board/xilinx/ml507/u-boot.lds.debug
 create mode 100644 board/xilinx/ml507/xparameters.h
 create mode 100644 include/configs/ml507.h

diff --git a/Makefile b/Makefile
index 6a734d1..2696ac6 100644
--- a/Makefile
+++ b/Makefile
@@ -1337,6 +1337,9 @@ ML2_config:   unconfig
 ml300_config:  unconfig
@$(MKCONFIG) $(@:_config=) ppc ppc4xx ml300 xilinx
 
+ml507_config:  unconfig
+   @$(MKCONFIG) $(@:_config=) ppc ppc4xx ml507 xilinx
+
 ocotea_config: unconfig
@$(MKCONFIG) $(@:_config=) ppc ppc4xx ocotea amcc
 

I think all makefile had WD copyright

diff --git a/board/xilinx/ml507/Makefile b/board/xilinx/ml507/Makefile
new file mode 100644
index 000..3708e43
--- /dev/null
+++ b/board/xilinx/ml507/Makefile
@@ -0,0 +1,53 @@
+#(C) Copyright 2008
+#Ricado Ribalda-Universidad Autonoma de [EMAIL PROTECTED]
+#Work supported supported by: Q-Technology  http://qtec.com/
+#based on Makefile by Wolfgang Denk, DENX Software Engineering,
[EMAIL PROTECTED]
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU General Public License as published by
+#the Free Software Foundation, either version 2 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU General Public License for more details.
+#
+#You should have received a copy of the GNU General Public License
+#along with this program.  If not, see .
+#
+
+include $(TOPDIR)/config.mk
+ifneq ($(OBJTREE),$(SRCTREE))
+endif
+
+INCS   := 
+CFLAGS += $(INCS)
+HOST_CFLAGS+= $(INCS)
+
+LIB= $(obj)lib$(BOARD).a
+
+COBJS  = $(BOARD).o \
+
+SOBJS  = init.o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+SOBJS  := $(addprefix $(obj),$(SOBJS))
+
+$(LIB):$(OBJS) $(SOBJS)
+   $(AR) $(ARFLAGS) $@ $^
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak .depend
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#

I know you like two email - but choose only one.

diff --git a/board/xilinx/ml507/config.mk b/board/xilinx/ml507/config.mk
new file mode 100644
index 000..d9a805f
--- /dev/null
+++ b/board/xilinx/ml507/config.mk
@@ -0,0 +1,18 @@
+#(C) Copyright 2008
+#Ricado Ribalda, Universidad Autonoma de Madrid, ricardo.ribaldauam.es
, ricardo.ribaldagmail.com
+#Work supported supported by: Q-Technology  http://qtec.com/
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU General Public License as published by
+#the Free Software Foundation, either version 2 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU General Public License for more details.
+#
+#You should have received a copy of the GNU General Public License
+#along with this program.  If not, see .
+#
+TEXT_BASE = 0x0400
diff --git a/board/xilinx/ml507/init.S b/board/xilinx/ml507/init.S
new file mode 100644
index 000..34ee5ed
--- /dev/null
+++ b/board/xilinx/ml507/init.S
@@ -0,0 +1,45 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda, Universidad Autonoma de Madrid, ricardo.ribaldauam.es ,
ricardo.ribaldagmail.com
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it an

Re: [U-Boot-Users] [PATCH] CPU PPC440x5 on Virtex5 FX

[Michal Simek]

Some days ago a sent to mailing list patch (currently is in) where I rename 
CONFIG_XILINX_ML300 -> CONFIG_XILINX_405.

I would like to see if you can use the same style for 440 -> CONFIG_XILINX_440.
I have no detail information about ppc440 but IMHO only virtex5 fx (or 
whatever) support it -> 
make no sense to me use virtex5 in name.

SR: Do you agree with me?

There is big part of code relate with interrupt controller which is the same 
with microblaze.
This should be handled in the same way. Any suggestion? (Do generic driver?)

M

BTW: some comments in code.



author  


This patchs gives support for the embbedded ppc440
on the Virtex5 FPGAs
---
 cpu/ppc4xx/4xx_enet.c   |3 +-
 cpu/ppc4xx/4xx_uart.c   |3 +
 cpu/ppc4xx/cpu.c|4 +
 cpu/ppc4xx/gpio.c   |5 +
 cpu/ppc4xx/interrupts.c |  238 ---
 cpu/ppc4xx/miiphy.c |5 +
 cpu/ppc4xx/speed.c  |6 +-
 include/asm-ppc/processor.h |3 +-
 net/eth.c   |3 +-
 9 files changed, 228 insertions(+), 42 deletions(-)

diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c
index 4e863dc..cf26237 100644
--- a/cpu/ppc4xx/4xx_enet.c
+++ b/cpu/ppc4xx/4xx_enet.c
@@ -97,7 +97,8 @@
  * network support enabled.
  * Remark: CONFIG_405 describes Xilinx PPC405 FPGA without EMAC controller!
  */
-#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && !defined(CONFIG_IOP480)
+#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && !defined(CONFIG_IOP480)
\
+   && !defined(CONFIG_440_VIRTEX5)
 
 #if !(defined(CONFIG_MII) || defined(CONFIG_CMD_MII))
 #error "CONFIG_MII has to be defined!"
diff --git a/cpu/ppc4xx/4xx_uart.c b/cpu/ppc4xx/4xx_uart.c
index a7587d4..37d3dbc 100644
--- a/cpu/ppc4xx/4xx_uart.c
+++ b/cpu/ppc4xx/4xx_uart.c
@@ -48,6 +48,7 @@
 #include 
 #include 
 
+#if !defined(CONFIG_440_VIRTEX5)
 #ifdef CONFIG_SERIAL_MULTI
 #include 
 #endif
@@ -873,3 +874,5 @@ int serial_tstc(void)
 #endif /* CONFIG_SERIAL_MULTI */
 
 #endif /* CONFIG_405GP || CONFIG_405CR */
+
+#endif
diff --git a/cpu/ppc4xx/cpu.c b/cpu/ppc4xx/cpu.c
index 39f439d..f510cdd 100644
--- a/cpu/ppc4xx/cpu.c
+++ b/cpu/ppc4xx/cpu.c
@@ -508,6 +508,10 @@ int checkcpu (void)
puts("GT Rev. A");
strcpy(addstr, "Security/Kasumi support");
break;
+   
+   case PVR_VIRTEX5:
+   printf(" VIRTEX5");
+   break;
 

why you use printf here? puts is enough.




default:
printf (" UNKNOWN (PVR=%08x)", pvr);
diff --git a/cpu/ppc4xx/gpio.c b/cpu/ppc4xx/gpio.c
index df99f53..59159ee 100644
--- a/cpu/ppc4xx/gpio.c
+++ b/cpu/ppc4xx/gpio.c
@@ -26,6 +26,9 @@
 #include 
 #include 
 
+
+#if !defined(CONFIG_440_VIRTEX5)
+
 #if defined(CFG_4xx_GPIO_TABLE)
 gpio_param_s const gpio_tab[GPIO_GROUP_MAX][GPIO_MAX] = CFG_4xx_GPIO_TABLE;
 #endif
@@ -253,3 +256,5 @@ void gpio_set_chip_configuration(void)
}
 }
 #endif /* CFG_4xx_GPIO_TABLE */
+
+#endif
diff --git a/cpu/ppc4xx/interrupts.c b/cpu/ppc4xx/interrupts.c
index 8620e2b..4648f52 100644
--- a/cpu/ppc4xx/interrupts.c
+++ b/cpu/ppc4xx/interrupts.c
@@ -8,6 +8,10 @@
  * (C) Copyright 2003 (440GX port)
  * Travis B. Sawyer, Sandburst Corporation, [EMAIL PROTECTED]
  *
+ * (C) Copyright 2008 (PPC440X05 port for Virtex 5 FX)
+ * Ricardo Ribalda, Universidad Autonoma de Madrid, [EMAIL PROTECTED]
+ * Work supported by Qtechnology (htpp://qtec.com)
+ *
  * See file CREDITS for list of people who contributed to this
  * project.
  *
@@ -41,6 +45,7 @@ DECLARE_GLOBAL_DATA_PTR;
 /*
  * Define the number of UIC's
  */
+#if !defined(CONFIG_440_VIRTEX5)
 #if defined(CONFIG_440SPE) || \
 defined(CONFIG_460EX) || defined(CONFIG_460GT)
 #define UIC_MAX4
@@ -54,17 +59,23 @@ DECLARE_GLOBAL_DATA_PTR;
 #else
 #define UIC_MAX1
 #endif
-
+#else
+void xilinx_pic_enable(void);
+#endif
 /*
  * CPM interrupt vector functions.
  */
-struct irq_action {
+struct irq_action {
interrupt_handler_t *handler;
void *arg;
int count;
 };
 
+#if !defined(CONFIG_440_VIRTEX5)
 static struct irq_action irq_vecs[UIC_MAX * 32];
+#else
+static struct irq_action irq_vecs[XPAR_INTC_MAX_NUM_INTR_INPUTS];
+#endif
 
 u32 get_dcr(u16);
 void set_dcr(u16, u32);
@@ -81,27 +92,25 @@ static __inline__ void set_evpr(unsigned long val)
asm volatile("mtspr 0x03f,%0" : : "r" (val));
 }
 
-#else /* !defined(CONFIG_440) */
+#else  /* !defined(CONFIG_440) */
 
 static __inline__ void set_pit(unsigned long val)
 {
asm volatile("mtpit %0" : : "r" (val));
 }
 
-
 static __inline__ void set_tcr(unsigned long val)
 {
asm volatile("mttcr %0" : : "r" (val));
 }
 
-
 static __inline__ void set_evpr(unsigned long val)
 {
asm volatile("mtevpr %0" : : "r" (val));
 }
-#endif /* defined(CONFIG_440 */
+#endif /* defined(CONFIG_440 */
 
-int interrupt_init_cpu (unsigned *decrementer_cou

Re: [U-Boot-Users] [PATCH 1/1] hwmon: Cleaning hwmon devices

[Michal Simek]

> From: Michal Simek <[EMAIL PROTECTED]>
>
> Clean Makefile
> Move device specific values to driver for better reading

>Thanks. One comment below though:
you are welcome


>> -COBJS-y += adm1021.o
>> -COBJS-y += ds1621.o
>> -COBJS-y += ds1722.o
>> -COBJS-y += ds1775.o
>> +COBJS-$(CONFIG_DTT_ADM1021) += adm1021.o
>> +COBJS-$(CONFIG_DTT_DS1621) += ds1621.o
>> +COBJS-$(CONFIG_DS1722) += ds1722.o

>CONFIG_DS1722 does not match the "CONFIG_DTT_foo" idea all other sensors are 
>using. Perhaps you could fix this up too (CONFIG_DS1722 -> CONFIG_DTT_DS1722) 
>with another version of this patch?

Second patch for it seems reasonable for me because there will be change in 
board config and it will be
better to have full change in one commit. I'll do it and send it.

M


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/1] FIS: repare incorrect return value with ramdisk handling

[Michal Simek]

oou. this patches I sent twice because I used git-send-email with 0001* and I 
had two files there. :-(
Sorry for that.

M

From: Michal Simek <[EMAIL PROTECTED]>

Microblaze and PowerPC use boot_get_ramdisk for loading
ramdisk to memory with checking return value.
Return 0 means success. Return 1 means failed.
Here is correspond part of code from bootm.c which check
return code.

ret = boot_get_ramdisk (argc, argv, images, IH_ARCH_PPC,
&rd_data_start, &rd_data_end);
if (ret)
goto error;

Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
---
 common/image.c |   16 
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/common/image.c b/common/image.c
index 4a024d4..4a4472f 100644
--- a/common/image.c
+++ b/common/image.c
@@ -826,13 +826,13 @@ int boot_get_ramdisk (int argc, char *argv[],
bootm_headers_t *images,
cfg_noffset = fit_conf_get_node (fit_hdr, 
fit_uname_config);
if (cfg_noffset < 0) {
debug ("*  ramdisk: no such config\n");
-   return 0;
+   return 1;
}
 
rd_noffset = fit_conf_get_ramdisk_node (fit_hdr, 
cfg_noffset);
if (rd_noffset < 0) {
debug ("*  ramdisk: no ramdisk in config\n");
-   return 0;
+   return 1;
}
}
 #endif
@@ -871,7 +871,7 @@ int boot_get_ramdisk (int argc, char *argv[],
bootm_headers_t *images,
if (!fit_check_format (fit_hdr)) {
puts ("Bad FIT ramdisk image format!\n");
show_boot_progress (-120);
-   return 0;
+   return 1;
}
show_boot_progress (121);
 
@@ -886,7 +886,7 @@ int boot_get_ramdisk (int argc, char *argv[],
bootm_headers_t *images,
if (cfg_noffset < 0) {
puts ("Could not find configuration 
node\n");
show_boot_progress (-122);
-   return 0;
+   return 1;
}
fit_uname_config = fdt_get_name (fit_hdr, 
cfg_noffset, NULL);
printf ("   Using '%s' configuration\n", 
fit_uname_config);
@@ -901,20 +901,20 @@ int boot_get_ramdisk (int argc, char *argv[],
bootm_headers_t *images,
if (rd_noffset < 0) {
puts ("Could not find subimage node\n");
show_boot_progress (-124);
-   return 0;
+   return 1;
}
 
printf ("   Trying '%s' ramdisk subimage\n", 
fit_uname_ramdisk);
 
show_boot_progress (125);
if (!fit_check_ramdisk (fit_hdr, rd_noffset, arch, 
images->verify))
-   return 0;
+   return 1;
 
/* get ramdisk image data address and length */
if (fit_image_get_data (fit_hdr, rd_noffset, &data, 
&size)) {
puts ("Could not find ramdisk subimage 
data!\n");
show_boot_progress (-127);
-   return 0;
+   return 1;
}
show_boot_progress (128);
 
@@ -924,7 +924,7 @@ int boot_get_ramdisk (int argc, char *argv[],
bootm_headers_t *images,
if (fit_image_get_load (fit_hdr, rd_noffset, &rd_load)) 
{
puts ("Can't get ramdisk subimage load 
address!\n");
show_boot_progress (-129);
-   return 0;
+   return 1;
}
show_boot_progress (129);
 
-- 
1.5.4.GIT


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users



-

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

[Michal Simek]

Still you have 3 empty lines. Look at code.

 Do not add more than 2 empty lines to source files 

M

From: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>


Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 drivers/hwmon/Makefile  |1 +
 drivers/hwmon/adt7460.c |   90 +++
 include/dtt.h   |3 +-
 3 files changed, 93 insertions(+), 1 deletions(-)
 create mode 100644 drivers/hwmon/adt7460.c

diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 065433a..e301eaa 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -37,6 +37,7 @@ COBJS-y += ds1775.o
 COBJS-$(CONFIG_DTT_LM73) += lm73.o
 COBJS-y += lm75.o
 COBJS-y += lm81.o
+COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
new file mode 100644
index 000..cf54d40
--- /dev/null
+++ b/drivers/hwmon/adt7460.c
@@ -0,0 +1,90 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda-Universidad Autonoma de Madrid, [EMAIL PROTECTED]
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see .
+*/
+
+#include 
+
+#include 
+#include 
+
+#define ADT7460_ADDRESS0x2c
+#define ADT7460_INVALID128
+#define ADT7460_CONFIG 0x40
+#define ADT7460_REM1_TEMP  0x25
+#define ADT7460_LOCAL_TEMP 0x26
+#define ADT7460_REM2_TEMP  0x27
+
+int dtt_read(int sensor, int reg)
+{
+   u8 dir=reg;
+   u8 data;
+
+   if ( i2c_read(ADT7460_ADDRESS,dir,1,&data,1) ==-1 )
+   return -1;
+   
+   if (data==ADT7460_INVALID)
+   return -1;
+
+   return data;
+} 
+
+int dtt_write(int sensor, int reg, int val)
+{
+   u8 dir=reg;
+   u8 data=val;
+   
+   if ( i2c_write(ADT7460_ADDRESS,dir,1,&data,1) ==-1 )
+   return -1;
+
+   return 0;
+} 
+
+
+

here

+int dtt_init (void)
+{
+   printf("ADT7460 at I2C address 0x%2x\n",ADT7460_ADDRESS);
+
+   if ( dtt_write(0,ADT7460_CONFIG,1) ==-1 ){
+   printf("Error initialiting ADT7460\n");
+   return -1;
+   }
+
+   return 0;
+} 
+
+int dtt_get_temp(int sensor)
+{
+   int aux;
+   u8 table[]={ADT7460_REM1_TEMP,ADT7460_LOCAL_TEMP,ADT7460_REM2_TEMP};
+
+   if (sensor>2){
+   printf("DTT sensor does not exist\n");
+   return -1;
+   }
+   
+   aux=dtt_read(0,table[sensor]);
+
+   if (aux==-1){
+   printf("DTT temperature read failed\n");
+   return -1;
+
+   }
+   return aux;
+}
+
diff --git a/include/dtt.h b/include/dtt.h
index 4e8aaad..db448ce 100644
--- a/include/dtt.h
+++ b/include/dtt.h
@@ -32,7 +32,8 @@
 defined(CONFIG_DTT_DS1775) || \
 defined(CONFIG_DTT_LM81) || \
 defined(CONFIG_DTT_ADM1021) || \
-defined(CONFIG_DTT_LM73)
+defined(CONFIG_DTT_LM73)|| \
+defined(CONFIG_DTT_ADT7460)
 
 #define CONFIG_DTT /* We have a DTT */
 
-- 
1.5.6.2


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

[Michal Simek]

Still is there coding style issue.

and you have one extra header file which is uneeded. I recommend you 
move usefull values directly to driver. 

WD: I looked at include/dtt.h there are many driver specific values. IMHO these
value should be usefull move to driver c file. What do you think about?

Michal


Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 drivers/hwmon/Makefile  |1 +
 drivers/hwmon/adt7460.c |   81 +++
 drivers/hwmon/adt7460.h |   49 
 include/dtt.h   |3 +-
 4 files changed, 133 insertions(+), 1 deletions(-)
 create mode 100644 drivers/hwmon/adt7460.c
 create mode 100644 drivers/hwmon/adt7460.h

diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 065433a..e301eaa 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -37,6 +37,7 @@ COBJS-y += ds1775.o
 COBJS-$(CONFIG_DTT_LM73) += lm73.o
 COBJS-y += lm75.o
 COBJS-y += lm81.o
+COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
new file mode 100644
index 000..3fbd6fa
--- /dev/null
+++ b/drivers/hwmon/adt7460.c
@@ -0,0 +1,81 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda-Universidad Autonoma de Madrid, [EMAIL PROTECTED]
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see .
+*/
+
+#include 
+
+#include 
+#include 
+#include "adt7460.h"
+
+#define ADT7460_ADDRESS 0x2c
+int dtt_read(int sensor, int reg)
+{
+   u8 dir=reg;
+   u8 data;
+
+   if (i2c_read(ADT7460_ADDRESS,dir,1,&data,1)==-1)
+   return -1;
+   
+   if (data==ADT7460_INVALID)
+   return -1;
+
+   return data;
+} 
+
+int dtt_write(int sensor, int reg, int val)
+{
+   u8 dir=reg;
+   u8 data=val;
+   
+   if (i2c_write(ADT7460_ADDRESS,dir,1,&data,1)==-1)
+   return -1;
+
+   return 0;
+} 
+
+
+

Many blank lines.

+int dtt_init (void)
+{
+   printf("ADT7460 at I2C address 0x%2x\n",ADT7460_ADDRESS);
+   if (dtt_write(0,ADT7460_CONFIG,1)==-1){
+   printf("Error initialiting ADT7460\n");
+   return -1;
+   }
+   return 0;
+} 
+
+int dtt_get_temp(int sensor)
+{
+   int aux;
+   u8 table[]={ADT7460_REM1_TEMP,ADT7460_LOCAL_TEMP,ADT7460_REM2_TEMP};
+   if (sensor>2){
+   printf("DTT sensor does not exist\n");
+   return -1;
+   }
+   
+   aux=dtt_read(0,table[sensor]);
+
+   if (aux==-1){
+   printf("DTT temperature read failed\n");
+   return -1;
+
+   }
+   return aux;
+}

IMHO this header should be in c file and these values are not used anywhere.

+#define ADT7460_2_5V   0x20
+#define ADT7460_VCCP   0x21
+#define ADT7460_VCC0x22
+#define ADT7460_V5 0x23
+#define ADT7460_V120x24
+#define ADT7460_TACH1L 0x28
+#define ADT7460_TACH1H 0x29
+#define ADT7460_TACH2L 0x2a
+#define ADT7460_TACH2H 0x2b
+#define ADT7460_TACH3L 0x2c
+#define ADT7460_TACH3H 0x2d
+#define ADT7460_TACH4L 0x2e
+#define ADT7460_TACH4H 0x2f
+#define ADT7460_TACH5L 0xa9
+#define ADT7460_TACH5H 0xaa
+#define ADT7460_TACH6L 0xab
+#define ADT7460_TACH6H 0xac
+#define ADT7460_REVISION   0x3f




diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
new file mode 100644
index 000..d915d1b
--- /dev/null
+++ b/drivers/hwmon/adt7460.h
@@ -0,0 +1,49 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda-Universidad Autonoma de Madrid, [EMAIL PROTECTED]
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received 

Re: [U-Boot-Users] [PATCH 1/2] microblaze: Clean uartlite driver

[Michal Simek]

I haven't seen problem with patch.

M

[EMAIL PROTECTED] u-boot-denx.de]$ git-am < 
0001-microblaze-Clean-uartlite-driver.patch 
Applying microblaze: Clean uartlite driver
[EMAIL PROTECTED] u-boot-denx.de]$ git log
commit 104b87cd4ee3dbea172ee1d39e81216e46b2070f
Author: Michal Simek <[EMAIL PROTECTED]>
Date:   Fri Jul 11 10:06:36 2008 +0200

microblaze: Clean uartlite driver

Redesign uartlite driver to in_be32 and out_be32 macros
Fix missing header in io.h

Signed-off-by: Michal Simek <[EMAIL PROTECTED]>

commit 829bef9be1671973b04d9c2fcc279211a4b59b5e
Merge: df76983... c956717...
Author: Michal Simek <[EMAIL PROTECTED]>
Date:   Mon Jul 7 15:14:56 2008 +0200

Merge branch 'master' of git://git.denx.de/u-boot

commit c956717ab25c962ef49d49064dfc73f4edcba1fb


Hi Michal

I have been unable to use your patch:


patching file include/asm-microblaze/io.h
[EMAIL PROTECTED]:~/curro/ml507/software/u-boot-ppc4xx$ patch -p1
 wrote:
> From: Michal Simek <[EMAIL PROTECTED]>
>
> Redesign uartlite driver to in_be32 and out_be32 macros
> Fix missing header in io.h
>
> Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
> ---
>  drivers/serial/serial_xuartlite.c |   37
+
>  include/asm-microblaze/io.h   |2 ++
>  2 files changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c
b/drivers/serial/serial_xuartlite.c
> index d678ab6..5c41a1c 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -1,6 +1,8 @@
>  /*
> - * (C) Copyright 2004 Atmark Techno, Inc.
> + * (C) Copyright 2008 Michal Simek <[EMAIL PROTECTED]>
> + * Clean driver and add xilinx constant from header file
>  *
> + * (C) Copyright 2004 Atmark Techno, Inc.
>  * Yasushi SHOJI <[EMAIL PROTECTED]>
>  *
>  * See file CREDITS for list of people who contributed to this
> @@ -13,7 +15,7 @@
>  *
>  * This program is distributed in the hope that it will be useful,
>  * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>  * GNU General Public License for more details.
>  *
>  * You should have received a copy of the GNU General Public License
> @@ -23,19 +25,21 @@
>  */
>
>  #include 
> +#include 
>
>  #ifdef CONFIG_XILINX_UARTLITE
>
> -#include 
> +#define RX_FIFO_OFFSET 0 /* receive FIFO, read only */
> +#define TX_FIFO_OFFSET 4 /* transmit FIFO, write only */
> +#define STATUS_REG_OFFSET  8 /* status register, read only */
>
> -/* FIXME: we should convert these to in32 and out32 */
> -#define IO_WORD(offset) (*(volatile unsigned long *)(offset))
> -#define IO_SERIAL(offset)IO_WORD(CONFIG_SERIAL_BASE + (offset))
> +#define SR_TX_FIFO_FULL0x08 /* transmit FIFO full */
> +#define SR_RX_FIFO_VALID_DATA  0x01 /* data in receive FIFO */
> +#define SR_RX_FIFO_FULL0x02 /* receive FIFO full */
>
> -#define IO_SERIAL_RX_FIFO   IO_SERIAL(XUL_RX_FIFO_OFFSET)
> -#define IO_SERIAL_TX_FIFO   IO_SERIAL(XUL_TX_FIFO_OFFSET)
> -#define IO_SERIAL_STATUSIO_SERIAL(XUL_STATUS_REG_OFFSET)
> -#define IO_SERIAL_CONTROL   IO_SERIAL(XUL_CONTROL_REG_OFFSET)
> +#define UARTLITE_STATUS(CONFIG_SERIAL_BASE +
STATUS_REG_OFFSET)
> +#define UARTLITE_TX_FIFO   (CONFIG_SERIAL_BASE + TX_FIFO_OFFSET)
> +#define UARTLITE_RX_FIFO   (CONFIG_SERIAL_BASE + RX_FIFO_OFFSET)
>
>  int serial_init(void)
>  {
> @@ -50,9 +54,10 @@ void serial_setbrg(void)
>
>  void serial_putc(const char c)
>  {
> -   if (c == '\n') serial_putc('\r');
> -   while (IO_SERIAL_STATUS & XUL_SR_TX_FIFO_FULL);
> -   IO_SERIAL_TX_FIFO = (unsigned char) (c & 0xff);
> +   if (c == '\n')
> +   serial_putc('\r');
> +   while (in_be32(UARTLITE_STATUS) & SR_TX_FIFO_FULL);
> +   out_be32(UARTLITE_TX_FIFO, (unsigned char) (c & 0xff));
>  }
>
>  void serial_puts(const char * s)
> @@ -64,13 +69,13 @@ void serial_puts(const char * s)
>
>  int serial_getc(void)
>  {
> -   while (!(IO_SERIAL_STATUS & XUL_SR_RX_FIFO_VALID_DATA));
> -   return IO_SERIAL_RX_FIFO & 0xff;
> +   while (!(in_be32(UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA));
> +   return in_be32(UARTLITE_RX_FIFO) & 0xff;
>  }
>
>  int serial_tstc(void)
>  {
> -   return (IO_SERIAL_STATUS & XUL_SR_RX_FIFO_VALID_DATA);
> +   return (in_be32(UARTLITE_STATUS) & SR_RX_

Re: [U-Boot-Users] [PATCH] New Dummy I2C Driver

[Michal Simek]

Hi Stefan and Ricardo,

>> I didn't add this to the description sorry:
>>
>>  This driver provides access to a false i2c eeprom.
>>  This false eeprom could be very useful in boards with
>>  ddr2 memories and no i2c interfaces.
>>  Using this driver the user can simulate the spd interface
>>  of the ddr2 memory and use the ddr2 auto configuration
>
>Problem is, that those SPD values in this driver are board specific. Other 
>boards with other DIMM(s) would need other EEPROM values. So it doesn't make 
>sense to add this in such a common file for me. And I really don't like the 
>name "dummy_i2c.c".

The dummy driver could be useful but without board specific values as Stefan 
wrote.
The name is awful. If is board specific setting you have to move it to board 
specific path.
(board/xilinx/ml507)

M

>Which SDRAM controller is used on your 440/Virtex SoC? Is it an IBM compatible 
>one? Or an IP core from Xilinx? I suggest you take a look at the similar 
>implementation selectable via CFG_SIMULATE_SPD_EEPROM (used on bamboo).


>Best regards,
>Stefan

=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]
=

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Michal Simek]

Hi Wolfgang and Ricardo,

> Hello again
> 
> This files already exist on the u-boot tree. They are located in
> include/asm-microblaze and include/asm-microblaze/arch-microblaze .
> They give support to a simple uart which can also be used on the
> powerpc, I have just copied them from one directory to another.

These files are ancient and they are added 4 years ago. I'll look at it if they
are use anywhere.

BTW in next merge open window I want to remove big bunch of code relate with
xilinx generic driver.

Michal


> This files have been provided by Xilinx, and they are the same in
> all the OS and boot loaders, I don't  think they break any GPL
> license,
> 
> 
>Best regards and sorry for the coding style I am correcting it.
> 
> On Thu, Jul 10, 2008 at 8:41 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
>> In message <[EMAIL PROTECTED]> you wrote:
>>> +* This program is free software; you can redistribute it and/or modify 
>>> it
>>> +* under the terms of the GNU General Public License as published by the
>>> +* Free Software Foundation; either version 2 of the License, or (at 
>>> your
>>> +* option) any later version.
>> ..
>>> +* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
>>> +* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
>>> +* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
>>> +* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
>>> +* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR 
>>> OBTAINING
>>> +* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
>> This is IMHO in contradiction to the GPL clause above.
>>
>>> +* Xilinx hardware products are not intended for use in life support
>>> +* appliances, devices, or systems. Use in such applications is
>>> +* expressly prohibited.
>> This restriction is IMHO in contradiction to the GPL clause above.
>>
>> ..
>>> +#define XCOMPONENT_IS_READY  0x  /* component has been 
>>> initialized */
>>> +#define XCOMPONENT_IS_STARTED0x  /* component has been 
>>> started */
>> Lines too long.
>>
>>> +/* the following constants and declarations are for unit test purposes and 
>>> are
>>> + * designed to be used in test applications.
>>> + */
>>> +#define XTEST_PASSED 0
>>> +#define XTEST_FAILED 1
>>> +
>>> +#define XASSERT_NONE  0
>>> +#define XASSERT_OCCURRED 1
>>> +
>>> +extern unsigned int XAssertStatus;
>>> +extern void XAssert(char *, int);
>>> +
>>> +/ Type Definitions 
>>> ***/
>>> +
>>> +/** @name Primitive types
>>> + * These primitive types are created for transportability.
>>> + * They are dependent upon the target architecture.
>>> + * @{
>>> + */
>>> +#include 
>>> +
>>> +typedef struct {
>>> + u32 Upper;
>>> + u32 Lower;
>>> +} Xuint64;
>>> +
>>> +/* Xilinx's unsigned integer types */
>>> +typedef u32 Xuint32;
>>> +typedef u16 Xuint16;
>>> +typedef u8 Xuint8;
>>> +
>>> +/* and signed integer types */
>>> +typedef s32 Xint32;
>>> +typedef s16 Xint16;
>>> +typedef s8 Xint8;
>>> +
>>> +#ifndef NULL
>>> +#define NULL 0
>>> +#endif
>>> +
>>> +typedef unsigned long Xboolean;
>>> +#define XNULLNULL
>>> +
>>> +#define XTRUE1
>>> +#define XFALSE   0
>>> +
>>> +/[EMAIL PROTECTED]/
>>> +
>>> +/**
>>> + * This data type defines an interrupt handler for a device.
>>> + * The argument points to the instance of the component
>>> + */
>>> +typedef void (*XInterruptHandler) (void *InstancePtr);
>>> +
>>> +/**
>>> + * This data type defines a callback to be invoked when an
>>> + * assert occurs. The callback is invoked only when asserts are enabled
>>> + */
>>> +typedef void (*XAssertCallback) (char *FilenamePtr, int LineNumber);
>>> +
>>> +/* Macros (Inline Functions) Definitions 
>>> */
>>> +
>>> +/*/
>>> +/**
>>> +* Return the most significant half of the 64 bit data type.
>>> +*
>>> +* @param x is the 64 bit word.
>>> +*
>>> +* @return
>>> +*
>>> +* The upper 32 bits of the 64 bit word.
>>> +*
>>> +* @note
>>> +*
>>> +* None.
>>> +*
>>> +**/
>>> +#define XUINT64_MSW(x) ((x).Upper)
>>> +
>>> +/*/
>>> +/**
>>> +* Return the least significant half of the 64 bit data type.
>>> +*
>>> +* @param x is the 64 bit word.
>>> +*
>>> +* @return
>>> +*
>>> +* The lower 32 bits of the 64 bit word.
>>> +*
>>> +* @note
>>> +*
>>> +* None.
>>> +*
>>> +**/
>>> +#define XUINT64_LSW(x) ((x).Lower)
>>> +
>>> +#ifndef NDEBUG
>>> +
>>> +/*/
>>> +/**
>>> +* This assert macro is to be u

Re: [U-Boot-Users] [PATCH] I2C Dummy Driver

[Michal Simek]

Hi Ricardo,


> Hi Wolfgang
> 
>> What is the intention or practical use of this dummy driver?
> 
> 
>   I developed this driver for two reasons,
> 
>  I wanted a dummy driver to test the i2c subsystem
>  I wanted a way of use the ddr2 autoconfiguration for ppc440 without i2c.
> 
> 
>>> +#if defined(CONFIG_DUMMY_I2C)
>>> +u8 
>>> i2c_dummy_buffer[256]={0x80,0x8,0x8,0x0D,0x0A,0x60,0x40,0x0,0x5,0x3D,0x50,0x0,0x82,0x10,0x0,0x0,0x0C,0x4,0x18,0x1,0x4,0x0,0x1,0x50,0x50,0x0,0x0,0x3C,0x28,0x3C,0x2D,0x40,0x25,0x37,0x10,0x22,0x3C,0x1E,0x1E,0x0,0x0,0x3C,0x69,0x80,0x1E,0x28,0x0,0x0,0x0,
>>> 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x12,0xC9,0x2C,'0','0','0','0','0','0','0',0x0,'4','H','T','F','3','2','6','4','H','Y','-','5','3','E','D','3',0x3,0x0,0x0,0x0,0x0};
>> Line way too long.
>>
>> Maybe you also want to explain where these magic data is coming from
>> or what it means?
> 
> It is the identification data of my ddr2 memory.

I think you will have to recoded it for better understanding.

M




> I will redo this patch and sent it again if you consider it useful for
> the mainline.
> 
> 
>  Best Regards and thanks for your comments
> 
> 
>> --
>> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
>> "Plan to throw one away.  You will anyway."
>>  - Fred Brooks, "The Mythical Man Month"
>>
> 
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Support for the ML507

[Michal Simek]

Hi Ricardo,

> Hello again:
> 
>   This is my third submission of the same thing, please be indulgent:

Please don't send next submission of the same thing if you know that minimally
half of these patches are wrong.

Michal

>   This month I have been working on the ml507 board, trying to give it
> support. This boards has a lot of components and I have developed
> drivers for some of them. On my first submission, the board and the
> drivers were on a single diff file. The mail list didn't like a
> message so big so I cutted it in 4 parts, bziped it and resend it.
> Later on I have realized that, it do not support the guidelines on the
> web And it will be huge work for the mantainers to check all that
> code
> 
>   So, I have spent the evening dividing the big patch in 8 independent
> patches. I have used the git tools to prepare the patches and resend
> them... Unfortunatelly some of this files are bigged than the 40kb
> limit If the mail list administrator don't accept this parts you
> can download the full set of patches from my website:
> http://www.ii.uam.es/~rribalda/ml507.tgz
> 
>   Why my patches are so big... They give support to IPs by Xilinx,
> which have some kind of generic drivers to adapt them to multiple
> OS... When the driver was very complex I have used this generic
> drivers and added an adaptor. Because it does not follows the coding
> guidelines, all this drivers have been located under the board
> directory to respect all your "clean" work.
> 
>Sorry for the mess I have created in just a matter of minutes.
> 
> 
>  Best Regards and I hope to see my code on the main line someday.
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Michal Simek]

Clean coding style especially long lines, free lines and please choose only one
email address.

Michal

> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/hwmon/Makefile  |1 +
>  drivers/hwmon/adt7460.c |   89 
> +++
>  drivers/hwmon/adt7460.h |   49 ++
>  include/dtt.h   |2 +-
>  4 files changed, 140 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/hwmon/adt7460.c
>  create mode 100644 drivers/hwmon/adt7460.h
> 
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 065433a..83aa297 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -34,6 +34,7 @@ COBJS-y += adm1021.o
>  COBJS-y += ds1621.o
>  COBJS-y += ds1722.o
>  COBJS-y += ds1775.o
> +COBJS-y += adt7460.o

look at line below to proper style.

>  COBJS-$(CONFIG_DTT_LM73) += lm73.o


>  COBJS-y += lm75.o
>  COBJS-y += lm81.o
> diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
> new file mode 100644
> index 000..255d6ed
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.c
> @@ -0,0 +1,89 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
long line

> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +
> +#include 
> +
> +#ifdef CONFIG_DTT_ADT7460

why is this ifdef here?

> +
> +#include 
> +#include 
> +#include "adt7460.h"
> +
> +#define ADT7460_ADDRESS 0x2c
> +
> +
> +int dtt_read(int sensor, int reg)
> +{
> + u8 dir=reg;
> + u8 data;
> +
> + if (-1==i2c_read(ADT7460_ADDRESS,dir,1,&data,1))
> + return -1;
> + 
> + if (data==ADT7460_INVALID)
> + return -1;
> +
> + return data;
> +
> +} 
> +
> +
> +int dtt_write(int sensor, int reg, int val)
> +{
> + u8 dir=reg;
> + u8 data=val;
> + 
> + if (-1==i2c_write(ADT7460_ADDRESS,dir,1,&data,1))
> + return -1;
> +
> + return 0;
> +} 
> +
> +
> +
> +int dtt_init (void)
> +{
> + printf("ADT7460 at I2C address 0x%2x\n",ADT7460_ADDRESS);
> + if (-1==dtt_write(0,ADT7460_CONFIG,1)){
> + printf("Error initialiting ADT7460\n");
> + return -1;
> + }
> + return 0;
> +} 
> +
> +
> +int dtt_get_temp(int sensor)
> +{
> + int aux;
> + u8 table[]={ADT7460_REM1_TEMP,ADT7460_LOCAL_TEMP,ADT7460_REM2_TEMP};
> + if (sensor>2){
> + printf("DTT sensor does not exist\n");
> + return -1;
> + }
> + 
> + aux=dtt_read(0,table[sensor]);
> +
> + if (-1==aux){
> + printf("DTT temperature read failed\n");
> + return -1;
> +
> + }
> + return aux;
> +}
> +#endif 
> diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
> new file mode 100644
> index 000..48666f7
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.h
> @@ -0,0 +1,49 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +#ifndef ADT7460
> +#define ADT7460
> +
> +
> +#define ADT7460_INVALID 128
> +
> +#define ADT7460_2_5V 0x20
> +#define ADT7460_VCCP 0x21
> +#define ADT7460_VCC  0x22
> +#define ADT7460_V5   0x23
> +#define ADT7460_V12  0x24
> +#define ADT7460_REM1_TEMP0x25
> +#define ADT7460_LOCAL_TEMP   0x26
> +#define ADT7460_REM2_TEMP0x27
> +#define ADT7460_TACH1L   0x28
> +#define ADT7460_TACH1H 

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Michal Simek]

Hi Ricardo,

> Hi Michael
> 
>   Sorry to hear that. I have tried to give all my best and follow the
> style of the ml300 board, which was the closest board to mine.
> On FPGAs board I think that it is not  a horrible idea to follow this
> style. Maybe you should consider to create an FPGA branch, where the
> generic drivers could be accepted. As I said, the FPGA hardware
> changes a lot and support a so changing hardware will be very
> difficult... Or just should not support FPGAs and its IP devices...

Any FPGA branch is not acceptable in U-BOOT mainline. Mainline U-BOOT is only
one. If you want to add your changes to U-BOOT mainline you have to change your
design style.

> By the way:
> 
>   patches 1 2  and 6 follow the guidelines and don't add any generic driver
>   patches 8 (except xparameters.h) follow the guidelines
>   patch 6 could be redesined. You should be aware that
> driver/serial/serial_xuartlite.c does not compile for ppc440 without
> that patch

This should be truth but without compatible board doesn't make sense to me. You
use any numbers but I haven't seen these numbers anywhere. Please use git for
your work and use more generic subject of your email. In set of patches you use
conventional style which generate git. Add there at the begging ml507 or xilinx
or whatever what will be specify xilinx relate topic.

Michal

>   Best regards
> 
> On Thu, Jul 10, 2008 at 9:04 PM, Michal Simek <[EMAIL PROTECTED]> wrote:
>> Hi Ricardo,
>>
>> I read your patches in your weird style.
>> These style of patches never go to mainline. You use xilinx generated files 
>> which is currently use only with ml300.
>> For example look at your xparameters.h there are a lot of values which are 
>> not used.
>> If you want to add ml507 to mainline U-BOOT you have to change completely 
>> handling style of xilinx board for ppc.
>> In next U-BOOT release I will clean ancient ml300. I want to remove a lot of 
>> xilinx generic files.
>>
>> 100% NACK for these patches.
>>
>> The size of patches is due to your incorrect design strategy.
>>
>> Michal Simek
>>
>>
>> Hi List:
>>
>>  This is my first contribution to u-boot. I have ported u-boot to the
>> ML507 Board by Xilinx.
>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>
>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>
>> The port supports:
>>-Virtex 5 ppc440x5
>>-XIlinx Interrupt Controller
>>-Xilinx I2C Controller (Interrupted mode)
>>-Xilinx Uart Lite (simple port)
>>-Xilinx LL_TEMA (Interrupted and SGDMA)
>>-Save environment on board eeprom
>>-DTT support for the ADT sensor on board (new hwmon driver)
>>-Dummy I2C driver (for testing purposes)
>>
>> This patch works against the last commit to the p4xx branch.
>>
>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>> has been supported by Q-Technology ( http://qtec.com ) under a
>> Research Agreement.
>>
>> Any comment will be very welcomed.
>>
>> PS: I have divided the patch in four parts for the mailing list
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>>
>>
> 
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C Dummy Driver

[Michal Simek]

Clean coding style. http://www.denx.de/wiki/UBoot/CodingStyle


> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/i2c/Makefile|1 +
>  drivers/i2c/dummy_i2c.c |   84 
> +++
>  2 files changed, 85 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/dummy_i2c.c
> 
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index 534c015..322c822 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
>  COBJS-y += omap24xx_i2c.o
>  COBJS-y += tsi108_i2c.o
>  COBJS-y += mxc_i2c.o
> +COBJS-y += dummy_i2c.o
>  
>  COBJS:= $(COBJS-y)
>  SRCS := $(COBJS:.o=.c)
> diff --git a/drivers/i2c/dummy_i2c.c b/drivers/i2c/dummy_i2c.c
> new file mode 100644
> index 000..04f6edb
> --- /dev/null
> +++ b/drivers/i2c/dummy_i2c.c
> @@ -0,0 +1,84 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +
> +#include 
> +
> +#if defined(CONFIG_DUMMY_I2C)
> +
> +
> +#include 
> +u8 
> i2c_dummy_buffer[256]={0x80,0x8,0x8,0x0D,0x0A,0x60,0x40,0x0,0x5,0x3D,0x50,0x0,0x82,0x10,0x0,0x0,0x0C,0x4,0x18,0x1,0x4,0x0,0x1,0x50,0x50,0x0,0x0,0x3C,0x28,0x3C,0x2D,0x40,0x25,0x37,0x10,0x22,0x3C,0x1E,0x1E,0x0,0x0,0x3C,0x69,0x80,0x1E,0x28,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x12,0xC9,0x2C,'0','0','0','0','0','0','0',0x0,'4','H','T','F','3','2','6','4','H','Y','-','5','3','E','D','3',0x3,0x0,0x0,0x0,0x0};
> + 
> +
> +
> +void i2c_init(int speed, int slaveaddr){
> + return ;
> +}
> +
> +
> +
> +int
> +i2c_read(uchar chip, uint addr, int alen, uchar * buffer, int len)
> +{
> + int i;
> + if (alen!=1)
> + return -1;
> +
> + if (addr+len>0xff)
> + return -1;
> +
> + for(i=0;i + buffer[i]=i2c_dummy_buffer[i+addr];
> + }
> +
> + return 0;
> +
> +
> +}
> +
> +
> +int
> +i2c_write(uchar chip, uint addr, int alen, uchar * buffer, int len)
> +{
> + int i;
> + if (alen!=1)
> + return -1;
> + if (addr+len>0xff)
> + return -1;
> +
> + for(i=0;i + i2c_dummy_buffer[i+addr]=buffer[i];
> + }
> +
> + return 0;
> +}
> +
> +
> +int
> +i2c_probe(uchar chip)
> +{
> + return 0;
> +}
> +
> +
> +
> +
> +
> +#endif
> +

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Michal Simek]

100% NACK.


> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  include/asm-ppc/arch-ppc4xx/xbasic_types.h |  301 
> 
>  include/asm-ppc/arch-ppc4xx/xio.h  |   63 ++
>  include/asm-ppc/arch-ppc4xx/xuartlite_l.h  |  256 +++
>  include/asm-ppc/serial_xuartlite.h |   25 +++
>  4 files changed, 645 insertions(+), 0 deletions(-)
>  create mode 100644 include/asm-ppc/arch-ppc4xx/xbasic_types.h
>  create mode 100644 include/asm-ppc/arch-ppc4xx/xio.h
>  create mode 100644 include/asm-ppc/arch-ppc4xx/xuartlite_l.h
>  create mode 100644 include/asm-ppc/serial_xuartlite.h
> 
> diff --git a/include/asm-ppc/arch-ppc4xx/xbasic_types.h 
> b/include/asm-ppc/arch-ppc4xx/xbasic_types.h
> new file mode 100644
> index 000..25012e6
> --- /dev/null
> +++ b/include/asm-ppc/arch-ppc4xx/xbasic_types.h
> @@ -0,0 +1,301 @@
> +/**
> +*
> +* Author: Xilinx, Inc.
> +*
> +*
> +* This program is free software; you can redistribute it and/or modify it
> +* under the terms of the GNU General Public License as published by the
> +* Free Software Foundation; either version 2 of the License, or (at your
> +* option) any later version.
> +*
> +*
> +* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
> +* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
> +* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
> +* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
> +* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
> +* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
> +* XILINX EXPRESSLY DISCLAIMS ANY WARRANTY WHATSOEVER WITH RESPECT TO
> +* THE ADEQUACY OF THE IMPLEMENTATION, INCLUDING BUT NOT LIMITED TO ANY
> +* WARRANTIES OR REPRESENTATIONS THAT THIS IMPLEMENTATION IS FREE FROM
> +* CLAIMS OF INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND
> +* FITNESS FOR A PARTICULAR PURPOSE.
> +*
> +*
> +* Xilinx hardware products are not intended for use in life support
> +* appliances, devices, or systems. Use in such applications is
> +* expressly prohibited.
> +*
> +*
> +* (c) Copyright 2002-2003 Xilinx Inc.
> +* All rights reserved.
> +*
> +*
> +* You should have received a copy of the GNU General Public License along
> +* with this program; if not, write to the Free Software Foundation, Inc.,
> +* 675 Mass Ave, Cambridge, MA 02139, USA.
> +*
> +**/
> +/*/
> +/**
> +*
> +* @file xbasic_types.h
> +*
> +* This file contains basic types for Xilinx software IP.  These types do not
> +* follow the standard naming convention with respect to using the component
> +* name in front of each name because they are considered to be primitives.
> +*
> +* @note
> +*
> +* This file contains items which are architecture dependent.
> +*
> +* 
> +* MODIFICATION HISTORY:
> +*
> +* Ver WhoDateChanges
> +* -   ---
> +* 1.00a rmm  12/14/01 First release
> +*rmm  05/09/03 Added "xassert always" macros to rid ourselves of diab
> +*  compiler warnings
> +* 
> +*
> +**/
> +
> +#ifndef XBASIC_TYPES_H   /* prevent circular inclusions */
> +#define XBASIC_TYPES_H   /* by using protection macros */
> +
> +/* Include Files 
> */
> +
> +/** Constant Definitions 
> */
> +
> +#ifndef TRUE
> +#define TRUE 1
> +#endif
> +#ifndef FALSE
> +#define FALSE 0
> +#endif
> +
> +#ifndef NULL
> +#define NULL 0
> +#endif
> +/** Null */
> +
> +#define XCOMPONENT_IS_READY  0x  /* component has been 
> initialized */
> +#define XCOMPONENT_IS_STARTED0x  /* component has been 
> started */
> +
> +/* the following constants and declarations are for unit test purposes and 
> are
> + * designed to be used in test applications.
> + */
> +#define XTEST_PASSED 0
> +#define XTEST_FAILED 1
> +
> +#define XASSERT_NONE  0
> +#define XASSERT_OCCURRED 1
> +
> +extern unsigned int XAssertStatus;
> +extern void XAssert(char *, int);
> +
> +/ Type Definitions 
> ***/
> +
> +/** @name Primitive types
> + * These primitive types are created for transportability.
> + * They are dependent upon the target architecture.
> + * @{
> + */
> +#include 
> +
> +typedef struct {
> + u32 Upper;
> + u32 Lower;
> +} Xuint64;
> +
> +/* Xilinx's unsigned integer types */
> +typedef u32 Xuint32;
> +typedef u16 Xuint

Re: [U-Boot-Users] Support for the ML507

[Michal Simek]

Hi,
>Hello again:

>  I have adapted the Xilinx drivers just because there were other
>examples of that behaviour on the u-boot code
>(board/xilinx/xilinx_enet, board/xilinx/xilinx_iic and
>board/xilinx/common) for the xilinx drivers.

This style is deprecated. xilinx_enet is emaclite(drivers/net/xilinx_emac.c) 
driver which I rewrite some month ago.
IIC driver is easy to rewrite. You used bad example.

>  About redesigning the drivers from scratch Maybe is not a good
>idea on FPGA soft cores. This devices made of hardware/software change
>very frequently (even twice per year) and if we develop a driver from
>scratch, it will be very hard to mantain. On the other hand, if we use
>the "generic drivers" we just need to change them when the devices are
>upgraded.

Almost all IP cores are backward compatible. I developed for Microblaze cpu 
MLD(TCL) which
helps you with changes in your design. You can do the same thing. Bsp is 
available at git.monstr.eu. Patches are welcomed.

>  Maybe an option will be just not give support to FPGAs boards...,
>but they are used by a lot of people (students and companies). We can
>have the risk that if we do not give support to that boards, the FPGAs
>manufacturers will create a fork and take full control of the u-boot
>roadmap (more money and resources).

Of course you can add support for generic board or for small amount of board in 
generic style.
Look at ml401 and xupv2p for microblaze. It is not to hard to add support for 
xilinx fpga board but
you have to do it correctly. I see a space for adding one generic board with 
ppc440 which will be sufficient 
for others.

>  I have tried to follow the coding guidelines for all the files I
>have created from scratch, but not for the drivers by xilinx.

If you want to help with handling of xilinx board, you can contact me.

Michal Simek

>  Best Regards

On Thu, Jul 10, 2008 at 8:48 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you
wrote:
>>
>>   So, I have spent the evening dividing the big patch in 8 independent
>> patches. I have used the git tools to prepare the patches and resend
>> them... Unfortunatelly some of this files are bigged than the 40kb
>> limit If the mail list administrator don't accept this parts you
>> can download the full set of patches from my website:
>> http://www.ii.uam.es/~rribalda/ml507.tgz
>
> 40 kB is the soft limit; the hard limit is 100 kB.
>
>>   Why my patches are so big... They give support to IPs by Xilinx,
>> which have some kind of generic drivers to adapt them to multiple
>
> You are aware that some similar code laready exists  in  U-Boot?  and
> that  your  patches  contain  lots  of code that will most definitely
> never be used in U-Boot?
>
>> OS... When the driver was very complex I have used this generic
>> drivers and added an adaptor. Because it does not follows the coding
>
> I have extremely little emthusiasm to add big and complex drivers that
> are intended to support many operating systems plus an adaption layer
> to a small boot loader like U-Boot.
>
> I think such drivers should be reimplemented from scratch, with
> efficiency and style in mind.
>
>> guidelines, all this drivers have been located under the board
>> directory to respect all your "clean" work.
>
> The Coding Style reqyierements apply to code in the board/ directories
> as well.
>
> And adding thsi stuff there makes it only worse, as the next similar
> board that gets added will copy the whole crap.
>
> This is bound to be unmaintainable.
>
> I *strongly* recommend to redesign and reimplement.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> How much net work could a network work, if a network could net work?
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open 

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Michal Simek]

Hi Ricardo,

I read your patches in your weird style. 
These style of patches never go to mainline. You use xilinx generated files 
which is currently use only with ml300.
For example look at your xparameters.h there are a lot of values which are not 
used.
If you want to add ml507 to mainline U-BOOT you have to change completely 
handling style of xilinx board for ppc.
In next U-BOOT release I will clean ancient ml300. I want to remove a lot of 
xilinx generic files.

100% NACK for these patches.

The size of patches is due to your incorrect design strategy.

Michal Simek


Hi List:

 This is my first contribution to u-boot. I have ported u-boot to the
ML507 Board by Xilinx.
http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm

This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.

The port supports:
-Virtex 5 ppc440x5
-XIlinx Interrupt Controller
-Xilinx I2C Controller (Interrupted mode)
-Xilinx Uart Lite (simple port)
-Xilinx LL_TEMA (Interrupted and SGDMA)
-Save environment on board eeprom
-DTT support for the ADT sensor on board (new hwmon driver)
-Dummy I2C driver (for testing purposes)

This patch works against the last commit to the p4xx branch.

I am a researcher of the Universidad Autonoma de Madrid, and this work
has been supported by Q-Technology ( http://qtec.com ) under a
Research Agreement.

Any comment will be very welcomed.

PS: I have divided the patch in four parts for the mailing list
-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] PHY lib

[Michal Simek]

Hi Ben,

> Hi Michal,
> 
> Michal Simek wrote:
>> Hi Ben and others,
>>
>> do you have any plan to start with PHY libs?
>> I saw to tsec driver - there are some phy description.
>> I would like to use phy description for one eth driver which I do.
>>
>>   
> I'm finally finding time to work on refactoring U-boot's networking
> support, one of the parts of which is a proper PHY library.  For several
> reasons, it pulls a lot from the TSEC driver.  Cutting and pasting the
> PHY descriptions from TSEC is probably a good idea (in as much as
> cutting and pasting is a good idea :)).

That's great. What next changes do you plan?
Thanks for information.

Best regards,
Michal

> regards,
> Ben

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] PHY lib

[Michal Simek]

Hi Ben and others,

do you have any plan to start with PHY libs?
I saw to tsec driver - there are some phy description.
I would like to use phy description for one eth driver which I do.

Thanks,
Michal

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] DTC and Binary Includes

[Michal Simek]

Hi Jon and Detlev,

I sent the similar patch to Jon yesterday.

I can confirm that I can compile DTC with small change
in convert-dtsv0-lexer.l (add missing library). I tested it with
Microblaze linux and seems that work well. I will test it binary include
as well and I'll send you if is work or not.

Michal


> Hi Jon,
> 
>> I seem to recall that those working on the either
>> the next U-Boot V2 or the next version of the FDT
>> image structure were planning on using the binary
>> include mechanism of the DTC.
>>
>> Several days ago I added the Binary Include patch
>> to DTC and tagged a candidate release.  Could you
>> verify that this version satisfies your needs and
>> works for you?
> 
> Hm, you mean the tag "v1.2.0-rc1"?  I couldn't compile nor install that
> version on my system without the attached patch.
> 
> I did not yet test the functionality, but that is only a question of
> time ;)
> 
> Cheers
>   Detlev
> 
> 
> 
> 
> 
> -
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> 
> 
> 
> 
> ___
> U-Boot-Users mailing list
> U-Boot-Users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/1] ppc4xx: Rename CONFIG_XILINX_ML300 to CONFIG_XILINX_405

[Michal Simek]

Thanks Stefan,

M

> From: Michal Simek <[EMAIL PROTECTED]>
>
> This change helps with better handling with others
> Xilinx based platform.
>
> Signed-off-by: Michal Simek <[EMAIL PROTECTED]>

Acked-by: Stefan Roese <[EMAIL PROTECTED]>

Wolfgang, please apply this directly, since it doesn't "fit" into one
of the custodian repositories.

Thanks.

Best regards,
Stefan

=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]
=



-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/1] FAT Bare Partition Support

[Michal Simek]

If you can't find who is it - because I think there is no any special custodian
for disks, Wolfgang Denk is that person.

And please send your emails about U-BOOT directly to mailing list not personally
to me. If you want use to me for a support, we can sign a contract.

Michal


> Sorry Michael but I'm pretty new... how can I know who is it?
> I looked into MAINTAINERS and CREDITS but no disk/ directory found.
> 
> Regards,
> Antonio
> 
> 2008/6/16 Michal Simek <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>:
> 
> 
> 
> > 2008/6/16 Michal Simek <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>:
> >
> > Hi Antonio
> >
> > I am not responsible for this part of U-BOOT but your patch
>     contain
> > coding style
> > violation.
> >
> > Regards,
> > Michal Simek
> >
> > > Logic unit:
> > > Purpose:Add support for bare partitions (no partition table)
> > > Author: Antnoio R. Costa  atmel.com
> <http://atmel.com>
> > <http://atmel.com>>
> > > Date  : 11 Jun 2008
> > >
> > > Status:
> > > ~~
> > > Some SD cards are not formatted with a partition table but with
> > > just a bare partition at the beginnig of the memory.
> > >
> > > I modified get_partition_info_extended to call test_block_type
> > > as done by print_partition_extended. In this way bare FAT
> partitions
> > > are recognised. Now we need a test for Ext2.
> > >
> > > Signed-off-by: Antonio R. Costa <[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>
> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>
> > >
> > > diff --git a/disk/part_dos.c b/disk/part_dos.c
> > > index 4d778ec..e5cc8aa 100644
> > > --- a/disk/part_dos.c
> > > +++ b/disk/part_dos.c
> > > @@ -1,4 +1,7 @@
> > >  /*
> > > + * (C) Copyright 2008 Atmel Corp.
> > > + * Antonio R. Costa  atmel.com
> <http://atmel.com> <http://atmel.com>>
> > > + *   gmail.com
> <http://gmail.com>
> > <http://gmail.com>>
> >
> > choose only one email
> >
> >
> > Ok
> >
> >
> >
> >
> > >   * (C) Copyright 2001
> > >   * Raymond Lo, [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
> > >   * Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>
> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>.
> > > @@ -53,6 +56,11 @@ static inline int le32_to_int(unsigned
> char *le32)
> > >  );
> > >  }
> > >
> > > +static inline int le16_to_int(unsigned char *le16)
> > > +{
> > > +return ((le16[1] << 8) + le16[0]);
> > > +}
> > > +
> >
> > this should be in header file
> >
> >
> > why? le32_to_int is defined in this file just above my function ???
> >
> OK, keep it.
> 
> >
> > >  static inline int is_extended(int part_type)
> > >  {
> > >  return (part_type == 0x5 ||
> > > @@ -166,12 +174,20 @@ static int get_partition_info_extended
> > (block_dev_desc_t *dev_desc, int ext_part
> > >   unsigned char buffer[DEFAULT_SECTOR_SIZE];
> > >   dos_partition_t *pt;
> > >   int i;
> > > -
> > > +
> >
> > Coding style issue.
> >
> > What is this ? Some kind of white spaces instead tabs or what?
> 
> In our initial patch, you had on this line tab - look at it.
> 
> And send this patch with cc to person who is responsible for this
> part of u-boot.
> 
> Michal
> 
> > >   if (dev_desc->block_read (dev_desc->dev,
> ext_part_sector, 1,
> > (ulong *) buffer) != 1) {
> > > 

Re: [U-Boot-Users] [PATCH 1/1] FAT Bare Partition Support

[Michal Simek]

Hi Antonio

I am not responsible for this part of U-BOOT but your patch contain coding style
violation.

Regards,
Michal Simek

> Logic unit:
> Purpose:Add support for bare partitions (no partition table)
> Author: Antnoio R. Costa  atmel.com>
> Date  : 11 Jun 2008
> 
> Status:
> ~~
> Some SD cards are not formatted with a partition table but with
> just a bare partition at the beginnig of the memory.
> 
> I modified get_partition_info_extended to call test_block_type
> as done by print_partition_extended. In this way bare FAT partitions
> are recognised. Now we need a test for Ext2.
> 
> Signed-off-by: Antonio R. Costa <[EMAIL PROTECTED]>
> 
> diff --git a/disk/part_dos.c b/disk/part_dos.c
> index 4d778ec..e5cc8aa 100644
> --- a/disk/part_dos.c
> +++ b/disk/part_dos.c
> @@ -1,4 +1,7 @@
>  /*
> + * (C) Copyright 2008 Atmel Corp.
> + * Antonio R. Costa  atmel.com>
> + *   gmail.com>

choose only one email

>   * (C) Copyright 2001
>   * Raymond Lo, [EMAIL PROTECTED]
>   * Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
> @@ -53,6 +56,11 @@ static inline int le32_to_int(unsigned char *le32)
>  );
>  }
>  
> +static inline int le16_to_int(unsigned char *le16)
> +{
> +return ((le16[1] << 8) + le16[0]);
> +}
> +

this should be in header file

>  static inline int is_extended(int part_type)
>  {
>  return (part_type == 0x5 ||
> @@ -166,12 +174,20 @@ static int get_partition_info_extended 
> (block_dev_desc_t *dev_desc, int ext_part
>   unsigned char buffer[DEFAULT_SECTOR_SIZE];
>   dos_partition_t *pt;
>   int i;
> -
> + 

Coding style issue.

>   if (dev_desc->block_read (dev_desc->dev, ext_part_sector, 1, (ulong *) 
> buffer) != 1) {
>   printf ("** Can't read partition table on %d:%d **\n",
>   dev_desc->dev, ext_part_sector);
>   return -1;
>   }
> +
> +/* 
> + * ARC:  This check is bad: 
> + * unfortunately both MBR and FAT bootsector
> + * have a sign 0x55aa @ 0x1FF
> + * I replaced it by test_block_type as in
> + * print_partition_extended
> + 
>   if (buffer[DOS_PART_MAGIC_OFFSET] != 0x55 ||
>   buffer[DOS_PART_MAGIC_OFFSET + 1] != 0xaa) {
>   printf ("bad MBR sector signature 0x%02x%02x\n",
> @@ -179,7 +195,19 @@ static int get_partition_info_extended (block_dev_desc_t 
> *dev_desc, int ext_part
>   buffer[DOS_PART_MAGIC_OFFSET + 1]);
>   return -1;
>   }
> -
> +*/
> + i=test_block_type(buffer);
> + 
> + if(i==-1) {
> + printf ("bad MBR sector signature 0x%02x%02x\n",
> + buffer[DOS_PART_MAGIC_OFFSET],
> + buffer[DOS_PART_MAGIC_OFFSET + 1]);
> + return -1;
> + }
> + 
> + if(i==DOS_PBR)
> + return -1;
> + 
>   /* Print all primary/logical partitions */
>   pt = (dos_partition_t *) (buffer + DOS_PART_TBL_OFFSET);
>   for (i = 0; i < 4; i++, pt++) {
> @@ -193,6 +221,7 @@ static int get_partition_info_extended (block_dev_desc_t 
> *dev_desc, int ext_part
>   info->blksz = 512;
>   info->start = ext_part_sector + le32_to_int 
> (pt->start4);
>   info->size  = le32_to_int (pt->size4);
> +
>   switch(dev_desc->if_type) {
>   case IF_TYPE_IDE:
>   case IF_TYPE_SATA:
> @@ -208,6 +237,13 @@ static int get_partition_info_extended (block_dev_desc_t 
> *dev_desc, int ext_part
>   case IF_TYPE_DOC:
>   sprintf ((char *)info->name, 
> "docd%c%d\n", 'a' + dev_desc->dev, part_num);
>   break;
> + case IF_TYPE_MMC:
> + sprintf ((char *)info->name, 
> "mmc%c%d\n", 'a' + dev_desc->dev, part_num);
> + break;
> +     case IF_TYPE_SD:
> + case IF_TYPE_SDHC:
> + sprintf ((char *)info->name, 
> "sd%c%d\n", 'a' + dev_desc->dev, part_num);
> + break;
>   default:
>   sprintf ((char *)info->name, 
> "xx%c%d\n", 'a' + dev_desc->dev, part_num);
>   break;
> 
> 

Regards,
Michal Simek


-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] LL_TEMAC on Avnet MiniModule-FX12

[Michal Simek]

Hi Llandre,

that's why you use opb_emac driver for ll_temac. That's all. Different driver
and different ip_core.

Regards,
Michal


> Hi all,
> 
> I ported U-Boot 1.3.1 on Avnet MiniModule-FX12 (the repository I'm 
> working with has been patched previously with ML403 patch). Here is my 
> first dirty patch:
> 
> http://www.dave.eu/download/misc/mmfx12/mmfx12-0.8.3.patch
> 
> U-Boot works fine and it boots correctly from flash, however ethernet 
> interface (LL_TEMAC) does not work.
> For example, when I try to perform a TFTP download, the XEmac_PollSend 
> function never returns because the following loop never ends:
> 
> /*
>   * Loop on the MAC's status to wait for the transmit to complete. The
>   * transmit status is in the FIFO when the XMIT_DONE bit is set.
>   */
> do {
>  IntrStatus = XIIF_V123B_READ_IISR(InstancePtr->BaseAddress);
> }
> while ((IntrStatus & XEM_EIR_XMIT_DONE_MASK) == 0);
> 
> Please note that the FPGA bitstream is ok because the linux kernel works 
> fine and can mount root file system via NFS so I pretty sure something 
> is wrong in my U-Boot port.
> 
> Anybody experienced similar problems?
> 
> 
> TIA,
> llandre
> 
> DAVE Electronics System House - R&D Department
> web:   http://www.dave.eu
> email: r&[EMAIL PROTECTED]
> 
> -
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> ___
> U-Boot-Users mailing list
> U-Boot-Users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> 


-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH-v3] Big white-space cleanup.

[Michal Simek]

Hi Wolfgang,

Whitespace cleanup for 2 Microblaze files are OK.

I checked:
include/asm-microblaze/asm.h
lib_microblaze/Makefile

Regards,
Michal Simek

> In message <[EMAIL PROTECTED]> I wrote:
>> This commit gets rid of a huge amount of silly white-space issues.
>> Especially, all sequences of SPACEs followed by TAB characters get
>> removed (unless they appear in print statements).
>>
>> Also remove all embedded "vim:" and "vi:" statements which hide
>> indentation problems.
>>
>> Signed-off-by: Wolfgang Denk <[EMAIL PROTECTED]>
> 
> The latest version of this patch is available for download here:
> 
> ftp://ftp.denx.de/pub/tmp/big-white-space-cleanup.patch-v.3.gz
> 
> I also checked in this patch in the master branch of the
> "u-boot-testing" repository, so you can just pull from there for
> easier testing.
> 
> Best regards,
> 
> Wolfgang Denk
> 

-
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] NOKIA's BB5 boards

[Michal Simek]

Hi Divel

Why did you send your message twice?

Michal Simek

> Can anybody write initialisation for BB5 boards ? It based on OMAP 1710  
> ARM processor and NOKIA's RAP 3G
> 
> -
> This SF.net email is sponsored by: Microsoft 
> Defy all challenges. Microsoft(R) Visual Studio 2008. 
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> U-Boot-Users mailing list
> U-Boot-Users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> 
> 

-
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] FYI, updated CustodianGitTrees page

[Michal Simek]

Hi Jerry,

I found NIOS2-5_0_0 branch. I think we can kill off this too.

Michal Simek

> <http://www.denx.de/wiki/rdiff/UBoot/CustodianGitTrees?rev2=1.29&rev1=1.30>
> 
> The major change was adding a "maintenance" bullet to the list and add a 
> tip on how to remove unnecessary branch labels from the remote 
> repository.  We (custodians) inherited some branches from a while ago 
> and I wanted to clean up the unused branches, had to figure out how.
> 
> Hint of you want to do the same cleanup on your repositories:
> 
> # show all branches:
> git branch -a
> 
> # kill off the obsolete ones:
> git push ssh://[EMAIL PROTECTED]/u-boot-fdt.git :heads/[EMAIL PROTECTED]
> git push ssh://[EMAIL PROTECTED]/u-boot-fdt.git :heads/[EMAIL PROTECTED]
> git push ssh://[EMAIL PROTECTED]/u-boot-fdt.git :heads/testing-4xx_enet
> git push ssh://[EMAIL PROTECTED]/u-boot-fdt.git :heads/testing-NAND
> git push ssh://[EMAIL PROTECTED]/u-boot-fdt.git :heads/testing-USB
> 
> While I was in the page, I also changed all the "git+ssh" to "ssh" - 
> unless I'm grossly confused, newer git versions no longer need to use 
> the "git+" hack.  I also changed the "gu-fdt" ssh user names to the 
> generic form "git-" so people cutting and pasting get a better 
> hint if they forget to fix the login name.
> 
> Best regards,
> gvb

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] 1.3.3-rc3 - release status

[Michal Simek]

Hi Wolfgang,

Microblaze cpu is OK for 1.3.3.

Regards,
Michal Simek

> Hello,
> 
> U-Boot v1.3.3-rc3 has been released.
> 
> The major architectures (PowerPC, ARM, MIPS) seemt o be in a prtty
> good shape now, with only few (usually minor and/or old) issues
> remaining.
> 
> We have one week left before the  scheduled  release  of  v1.3.3,  an
> unless  someone comes up with a real show-stopper I think we can make
> the deadline (hey, that would be a novelty - having deadlines at  all
> was one already, and not it seems we can actually meet those - wow!).
> 
> So please - help test the new code, and report any  problems  /  post
> remaining fixes within the next few days.
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Xilinx PowerPC XPS_LL_TEMAC driver

[Michal Simek]

p;tx_bd;
> +   flush_dcache_range((unsigned int)&tx_bd, sizeof(cdmac_bd));
> +   *(unsigned int *)TX_CURDESC_PTR = (unsigned int)&tx_bd;
> +}
> +
> +static int xps_ll_temac_send(unsigned char *buffer, int length)
> +{
> +   if(xps_ll_temac_phy_ctrl() == 0) return 0;
> +
> +   memcpy(tx_buffer, buffer, length);
> +   flush_dcache_range((unsigned int)tx_buffer, length);
> +
> +   tx_bd.stat = BDSTAT_SOP_MASK | BDSTAT_EOP_MASK | BDSTAT_STOP_ON_END_
> MASK;
> +   tx_bd.buf_len = length;
> +   flush_dcache_range((unsigned int)&tx_bd, sizeof(cdmac_bd));
> +
> +   *(unsigned int *)TX_CURDESC_PTR = (unsigned int)&tx_bd;
> +   *(unsigned int *)TX_TAILDESC_PTR = (unsigned int)&tx_bd; /* DMA 
> start */
> +
> +   do {
> +   invalidate_dcache_range((unsigned int)&tx_bd, sizeof(cdmac_bd));
> +   } while(!((volatile int)tx_bd.stat & BDSTAT_COMPLETED_MASK));
> +
> +   return length;
> +}
> +
> +static int xps_ll_temac_recv(void)
> +{
> +   int length;
> +
> +   invalidate_dcache_range((unsigned int)&rx_bd, sizeof(cdmac_bd));
> +   if(!(rx_bd.stat & BDSTAT_COMPLETED_MASK)) return 0;
> +
> +   length = rx_bd.app5;
> +   invalidate_dcache_range((unsigned int)rx_bd.phys_buf_p, length);
> +
> +   rx_bd.buf_len = ETHER_MTU;
> +   rx_bd.stat = 0;
> +   rx_bd.app5 = 0;
> +   flush_dcache_range((unsigned int)&rx_bd, sizeof(cdmac_bd));
> +   *(unsigned int *)RX_TAILDESC_PTR = (unsigned int)&rx_bd;
> +
> +   if(length > 0) {
> +   NetReceive(rx_bd.phys_buf_p, length);
> +   }
> +
> +   return length;
> +}
> +
> +static int xps_ll_temac_addr_setup(struct xps_ll_temac_private * lp)
> +{
> +char * env_p;
> +char * end;
> +inti, val;
> +
> +env_p = getenv("ethaddr");
> +if (env_p == NULL) {
> +printf("cannot get enviroment for \"ethaddr\".\n");
> +return -1;
> +}
> +
> +for (i = 0; i < 6; i++) {
> +lp->dev_addr[i] = env_p ? simple_strtoul(env_p, &end, 
> 16) : 0;
> +if (env_p) env_p = (*end) ? end + 1 : end;
> +}
> +
> +/* set up unicast MAC address filter */
> +val = lp->dev_addr[3] << 24 | lp->dev_addr[2] << 16 |
> +   lp->dev_addr[1] <<  8 | lp->dev_addr[0];
> +   xps_ll_temac_indirect_set(0, UAW0, val);
> +val = lp->dev_addr[5] << 8 |  lp->dev_addr[4];
> +   xps_ll_temac_indirect_set(0, UAW1, val);
> +
> +return 0;
> +}
> +
> +static void xps_ll_temac_init(struct eth_device *dev, bd_t *bis)
> +{
> +   struct xps_ll_temac_private *lp = (struct xps_ll_temac_private *)
> dev->priv;
> +
> +   xps_ll_temac_bd_init();
> +   xps_ll_temac_indirect_set(0, MC, MDIO_ENABLE_MASK | MDIO_CLOCK_DIV_
> 100MHz);
> +   
> +   xps_ll_temac_addr_setup(lp);
> +   xps_ll_temac_indirect_set(0, AFM, 0x);  /* Promiscuos mode 
> disable */
> +   xps_ll_temac_indirect_set(0, RCW1, 0x1000); /* Enable Receiver *
> /
> +   xps_ll_temac_indirect_set(0, TC, 0x1000);   /* Enable 
> Transmitter */
> +
> +}
> +
> +int eth_init(bd_t *bis)
> +{
> +   static int first = 1;
> +   struct eth_device *dev;
> +   struct xps_ll_temac_private *lp;
> +   int i;
> +
> +   if(!first) return 0;
> +   first = 0;
> +dev = (struct eth_device *) calloc(1, sizeof(struct eth_device))
> ;
> +if (NULL == dev) return 0;
> +
> +lp = (struct xps_ll_temac_private *) calloc(1, sizeof(struct 
> xps_ll_temac_private));
> +if (lp == NULL) return 0;
> +   dev->priv = lp;
> +   sprintf(dev->name, "eth0");
> +
> +   xps_ll_temac_init(dev, bis);
> +
> +   printf("%s: Xilinx XPS LocalLink Tri-Mode Ether MAC #%d at 0x%08X.\
> n",
> +   dev->name, 0, XPS_LLTEMAC_BASEADDR);
> +
> +   for(i = 0;i < 3;i++) {  
> +   if(xps_ll_temac_phy_ctrl()) break;
> +   udelay(1);  /* wait second */
> +   }
> +   return 1;
> +}
> +
> +int eth_send(volatile void *packet, int length)
> +{
> +   return xps_ll_temac_send((unsigned char *)packet, length);
> +}
> +
> +int eth_rx(void)
> +{
> +   return xps_ll_temac_recv();
> +}
> +
> +void eth_halt(void)
> +{
> +}
> +

BTW. Good work. Please clean it and resubmit.
I check it again.

Regards,
Michal Simek

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 04/13] microblaze: add Emaclite ethernet driver

[Michal Simek]

Hi Ben,

>> Dear Michal,
>>
>>  in message <[EMAIL PROTECTED]> you wrote:
>>  >
>>  > this code was sent to mailing list I think twice. I think Grant reviewed 
>> this
>>  > code once, didn't he?
>>
>>  Maybe, I don't remember the details. But if Ben had accepted the
>>  patch, he would have checked it into the u-boot-net custodian
>>  repository, where network stuff belongs to.
>>
>>  It should not go through other repositories normally (unless Ben gives
>>  his explicit permission).
>>
> 
> I did see these patches, but haven't reviewed yet.  I'll have a look
> in the next couple of days and will provide feedback.
> 
> regards,
> Ben

Thanks for it,

Michal Simek

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 04/13] microblaze: add Emaclite ethernet driver

[Michal Simek]

Hi Wolfgang,

this code was sent to mailing list I think twice. I think Grant reviewed this
code once, didn't he?

For Ben.
Can you look at drivers/net/xilinx_emac.c and xilinx_emaclite.c?

>> Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
> 
> I see you sneaked this in via your microblaze custodian repo. This was
> a Bad Thing, and I ask you not to do such things. You were supposed to
> run this through the Net custodian.

Sorry for that. Explanation is above.

> Ditto for [PATCH 05/13] microblaze: add Emac ethernet driver
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Michal Simek



-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Pull request u-boot-microblaze.git

[Michal Simek]

>> Could you look at it?
>Sure. Done. Sorry for the delay.

>Best regards,
>Wolfgang Denk

No worries.
Thanks,
Michal Simek
www.monstr.eu

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Pull request u-boot-microblaze.git

[Michal Simek]

Hi Wolfgang,

Could you look at it?

Thanks,
Michal


> Hi Wolfgang,
> 
> please pull microblaze git repo.
> 
> Thanks,
> Michal Simek
> 
> The following changes since commit aeff6d503b6006573d5c6b04fc658a64bebee5fa:
>   Wolfgang Denk (1):
> Merge branch 'master' of git://www.denx.de/git/u-boot-fdt
> 
> are available in the git repository at:
> 
>   . master
> 
> Michal Simek (13):
>   microblaze: Clean Makefile from ancient emac driver
>   microblaze: remove old setting for emac driver
>   microblaze: ML401 and XUPV2P remove emac and emaclite reference
>   microblaze: add Emaclite ethernet driver
>   microblaze: add Emac ethernet driver
>   microblaze: Add Emac driver to Makefile
>   microblaze: Add Emaclite driver to Makefile
>   microblaze: clean uart16550 and uartlite handling
>   microblaze: ml401 - add ifdef for GPIO
>   microblaze: ml401 fix config file for supporting FDT
>   microblaze: xupv2p fix config file for supporting FDT
>   microblaze: clean microblaze_config.mk
>   microblaze: Sort microblaze boards in MAKEALL script
> 
>  MAKEALL   |2 +-
>  board/xilinx/ml401/Makefile   |   17 +--
>  board/xilinx/ml401/xparameters.h  |   12 +-
>  board/xilinx/xupv2p/Makefile  |   17 +--
>  board/xilinx/xupv2p/xparameters.h |   12 +-
>  drivers/net/Makefile  |2 +
>  drivers/net/xilinx_emac.c |  462 
> +
>  drivers/net/xilinx_emaclite.c |  351 
>  include/configs/ml401.h   |   42 +++-
>  include/configs/xupv2p.h  |   37 +++-
>  microblaze_config.mk  |   16 +-
>  11 files changed, 890 insertions(+), 80 deletions(-)
>  create mode 100644 drivers/net/xilinx_emac.c
>  create mode 100644 drivers/net/xilinx_emaclite.c
> 
> -
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Register now and save $200. Hurry, offer ends at 11:59 p.m., 
> Monday, April 7! Use priority code J8TLD2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> ___
> U-Boot-Users mailing list
> U-Boot-Users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> 

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] FIS DTC

[Michal Simek]

Hi Jon,

I have had version with /incbin/. I found patches from Scott.

Michal Simek
www.monstr.eu

>>> Hi David,
>>>
>>>> The /incbin/ is probably the problem.  Support for binary includes has
>>>> been suggested, and patches have floated around, but it hasn't yet
>>>> been merged into dtc mainline.
>>> :-( Do you have any floated version?
>> I don't have the patches ready to hand, I'm afraid.  I do mean to get
>> the feature merged, but I'm not happy with how it's implemented right
>> now, and have only been slowly getting to the pieces we need for a
>> version I'd be happy with. 
> 
> Which is why it hasn't gone in yet.
> 
>>  Plus jdl appears not to have had a lot of
>> time to spend on dtc lately.
> 
> Also true.
> 
> jdl
> 
> 
> 

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] FIS DTC

[Michal Simek]

Thanks for your answers,

Michal Simek
www.monstr.eu

>> Hi David,
>>
>>> The /incbin/ is probably the problem.  Support for binary includes has
>>> been suggested, and patches have floated around, but it hasn't yet
>>> been merged into dtc mainline.
>> :-( Do you have any floated version?
> 
> I don't have the patches ready to hand, I'm afraid.  I do mean to get
> the feature merged, but I'm not happy with how it's implemented right
> now, and have only been slowly getting to the pieces we need for a
> version I'd be happy with.  Plus jdl appears not to have had a lot of
> time to spend on dtc lately.
> 

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] Pull request u-boot-microblaze.git

[Michal Simek]

Hi Wolfgang,

please pull microblaze git repo.

Thanks,
Michal Simek

The following changes since commit aeff6d503b6006573d5c6b04fc658a64bebee5fa:
  Wolfgang Denk (1):
Merge branch 'master' of git://www.denx.de/git/u-boot-fdt

are available in the git repository at:

  . master

Michal Simek (13):
  microblaze: Clean Makefile from ancient emac driver
  microblaze: remove old setting for emac driver
  microblaze: ML401 and XUPV2P remove emac and emaclite reference
  microblaze: add Emaclite ethernet driver
  microblaze: add Emac ethernet driver
  microblaze: Add Emac driver to Makefile
  microblaze: Add Emaclite driver to Makefile
  microblaze: clean uart16550 and uartlite handling
  microblaze: ml401 - add ifdef for GPIO
  microblaze: ml401 fix config file for supporting FDT
  microblaze: xupv2p fix config file for supporting FDT
  microblaze: clean microblaze_config.mk
  microblaze: Sort microblaze boards in MAKEALL script

 MAKEALL   |2 +-
 board/xilinx/ml401/Makefile   |   17 +--
 board/xilinx/ml401/xparameters.h  |   12 +-
 board/xilinx/xupv2p/Makefile  |   17 +--
 board/xilinx/xupv2p/xparameters.h |   12 +-
 drivers/net/Makefile  |2 +
 drivers/net/xilinx_emac.c |  462 +
 drivers/net/xilinx_emaclite.c |  351 
 include/configs/ml401.h   |   42 +++-
 include/configs/xupv2p.h  |   37 +++-
 microblaze_config.mk  |   16 +-
 11 files changed, 890 insertions(+), 80 deletions(-)
 create mode 100644 drivers/net/xilinx_emac.c
 create mode 100644 drivers/net/xilinx_emaclite.c

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] FIS DTC

[Michal Simek]

Hi David,

>The /incbin/ is probably the problem.  Support for binary includes has
>been suggested, and patches have floated around, but it hasn't yet
>been merged into dtc mainline.

:-( Do you have any floated version?

Thanks,
Michal Simek
www.monstr.eu

>David Gibson   | I'll have my music baroque, and my code
>david AT gibson.dropbear.id.au | minimalist, thank you.  NOT _the_ _other_
>   | _way_ _around_!
>http://www.ozlabs.org/~dgibson





-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] FIS DTC

[Michal Simek]

Hi Jon, David and others,

I am working on FIS for Microblaze CPU. I would like to use it. I have one 
problem.

I download latest DTC version from Jon git server.

Version: DTC 1.1.0-g1577696b

I tryied to convert DTS to DTB for Microblaze CPU. (DTS is below)
#dtc -f -O dtb -b 0 -V 16 system.dts 
DTC: dts->dtb  on file "system.dts"
system.dts:27 syntax error
FATAL ERROR: Couldn't read input tree

I got this error - I don't understand what is wrong. Older DTC version has no 
problem with it.
This part is no problem - I can use older version of DTC(Version: DTC 
1.1.0-g2512a7eb-dirty
).

The second things is around mkimage utility. I want to generate ITB file from 
ITS description.
Latest DTC compiler has problem with it too. 

Can you tell me which version are you using?
I tryied to complile ITS to ITB with older DTC version and this version don't 
know about data label in kernel specification.
I had no problem to add (for FDT + kernel version) DTB file but kernel file is 
not loaded.
Is label data = "/incbin/("./linux.bin")"; OK? linux bin is in the same 
dirctore where is microblaze.its file.

Latest DTC has problem with ITS too
$ mkimage -f microblaze.its  microblaze.itb
FIT format handling
Trying to execute "dtc -I dts -O dtb -p 500 microblaze.its > microblaze.itb.tmp"
DTC: dts->dtb  on file "microblaze.its"
microblaze.its:5 syntax error
FATAL ERROR: Couldn't read input tree
mkimage: Can't read microblaze.itb.tmp: Invalid argument
$ dtc -v
Version: DTC 1.1.0-g1577696b
[EMAIL PROTECTED] linux-eu-2.6.24]$ 



# mkimage -f microblaze.its  microblaze.itb
FIT format handling
Trying to execute "dtc -I dts -O dtb -p 500 microblaze.its > microblaze.itb.tmp"
DTC: dts->dtb  on file "microblaze.its"
microblaze.its:5 syntax error
FATAL ERROR: Couldn't read input tree
mkimage: Can't read microblaze.itb.tmp: Invalid argument
# cat -n microblaze.its
 1  /*
 2   * Simple U-boot uImage source file containing a single kernel
 3   */
 4  / {
 5  description = "Simple image with single Linux kernel";
 6  #address-cells = <1>;
 7
 8  images {
 9  [EMAIL PROTECTED] {
10  description = "Vanilla Linux kernel";
11  data = /incbin/("./linux.bin");
12  type = "kernel";
13  arch = "microblaze";
14  os = "linux";
15  compression = "none";
16  load = <2000>;
17  entry = <2000>;
18  [EMAIL PROTECTED] {
19  algo = "crc32";
20  };
21  [EMAIL PROTECTED] {
22  algo = "sha1";
23  };
24  };
25  };
26
27  configurations {
28  default = "[EMAIL PROTECTED]";
29      [EMAIL PROTECTED] {
30  description = "Boot Linux kernel";
31      kernel = "[EMAIL PROTECTED]";
32  };
33  };
34  };

Thanks for help,
Michal Simek
www.monstr.eu








 1  /*
 2   * (C) Copyright 2007-2008 Michal Simek
 3   *
 4   * Michal SIMEK <[EMAIL PROTECTED]>
 5   *
 6   * This program is free software; you can redistribute it and/or
 7   * modify it under the terms of the GNU General Public License as
 8   * published by the Free Software Foundation; either version 2 of
 9   * the License, or (at your option) any later version.
10   *
11   * This program is distributed in the hope that it will be useful,
12   * but WITHOUT ANY WARRANTY; without even the implied warranty of
13   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14   * GNU General Public License for more details.
15   *
16   * You should have received a copy of the GNU General Public License
17   * along with this program; if not, write to the Free Software
18   * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
19   * MA 02111-1307 USA
20   *
21   * CAUTION: This file is automatically generated by libgen.
22   * Version: Xilinx EDK 9.2.02 EDK_Jm_SP2.3
23   * Generate by FDT v1.00.a
24   */
25
26  / {
27  #address-cells = <1>;
28  #size-cells = <1>;
29  compatible = "xlnx,microblaze";
30  model = "testing";
31  DDR_SDRAM_32Mx16: [EMAIL PROTECTED] {
32  device_type

Re: [U-Boot-Users] [PATCH 07/13] microblaze: Add Emaclite driver to Makefile

[Michal Simek]

Hi Jean,

I will do it when I add the driver. The set of patches were only for review.

Can you add me ACK for them?

Thanks,

Michal Simek
www.monstr.eu

>> From: Michal Simek <[EMAIL PROTECTED]>
>>
>> Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
>> ---
>>  drivers/net/Makefile |1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
>> index e6b0543..1ae517d 100644
>> --- a/drivers/net/Makefile
>> +++ b/drivers/net/Makefile
>> @@ -60,6 +60,7 @@ COBJS-y += tsi108_eth.o
>>  COBJS-y += uli526x.o
>>  COBJS-y += vsc7385.o
>>  COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
>> +COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
>>  
>>  COBJS   := $(COBJS-y)
>>  SRCS:= $(COBJS:.o=.c)
>> -- 
> Please do it when you add the driver
> 
> Best Regards,
> J.
> 


-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 2/6] [new uImage] Removed dead ramdisk code on microblaze architecture

[Michal Simek]

Hi Bartolomiej,

>> Hi Marian,
>>
>> do you have git repository with your changes?
> 
> Hi Michal,
> 
> Let me answer this, as Marian is out of office. Yes, the changes are
> available form the new-image branch of the u-boot-testing repo. For more
> details, please see my email to the list announcing it, sent a while ago
> ([U-Boot-Users] [new uImage] Code available on new-image branch of
> u-boot-testing repo).

Thanks.

>> I would like to see what is changed from previous state. I have some
>> changes in my internal repository which modified linux booting with
>> using ramdisk too.
> 
> It would be very good to have a look at your changes -- could you post
> them (preferably using the new-image branch as a baseline :).

Microblaze linux bootm function will be simpler powerpc bootm function.
Microblaze supports FDT and Ramdisk now.

I'll check it soon and I'll send my changes.

Regards,
Michal Simek


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 2/6] [new uImage] Removed dead ramdisk code on microblaze architecture

[Michal Simek]

Hi Marian,

do you have git repository with your changes?
I would like to see what is changed from previous state.
I have some changes in my internal repository which modified
linux booting with using ramdisk too.

Regards,
Michal Simek


> Microblaze do_bootm_linux() includes ramdisk processing code but
> the ramdisk does not get used anywhere later on.
> 
> Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]>
> ---
> 
>  lib_microblaze/bootm.c |5 -
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> 
> diff --git a/lib_microblaze/bootm.c b/lib_microblaze/bootm.c
> index 1f3e777..bccfbe1 100644
> --- a/lib_microblaze/bootm.c
> +++ b/lib_microblaze/bootm.c
> @@ -35,17 +35,12 @@ DECLARE_GLOBAL_DATA_PTR;
>  void do_bootm_linux (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],
>image_header_t *hdr, int verify)
>  {
> - ulong initrd_start, initrd_end;
> -
>   /* First parameter is mapped to $r5 for kernel boot args */
>   void (*theKernel) (char *);
>   char *commandline = getenv ("bootargs");
>  
>   theKernel = (void (*)(char *))image_get_ep (hdr);
>  
> - get_ramdisk (cmdtp, flag, argc, argv, hdr, verify,
> - IH_ARCH_MICROBLAZE, &initrd_start, &initrd_end);
> -
>   show_boot_progress (15);
>  
>  #ifdef DEBUG


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] u-boot for Microblaze

[Michal Simek]

Hi Bruce,

1. Please give CC to u-boot mailing list not only me privately.

> Thanks for your response last week.  I am too new to this to know which
> IP core I want to use.  I am just trying to get familiar with u-boot and
> what it does.
> I tried to get the latest u-boot with git and this is what I get.
> 
> git-clone git://www.denx.de/git/u-boot/u-boot-ixp.git mystuff
> Initialized empty Git repository in /home/bruce/mystuff/.git/
> fatal: The remote end hung up unexpectedly
> fetch-pack from 'git://www.denx.de/git/u-boot/u-boot-microblase.git' failed.

2. You ask you want to port u-boot to Microblaze and you tried to clone
ixp architecture. This is awesome...
http://www.monstr.eu/wiki/doku.php?id=uboot

> After I get past this, I still have a bunch of questions that I would
> like to ask you if you do not mind me asking.
> Thanks for your help.
> Bruce

3. If you have question you can ask. 
Please see http://www.catb.org/~esr/faqs/smart-questions.html

Regards,
Michal Simek

>> I am having trouble compiling a build for u-boot 1.1.6.  I have a
>> microblaze processor.  I know that I am just missing a step but I am new
>> to using u-boot and need some help.
>> I have done a "make suzaku_config"
>> When I compile the code I get the error "#error Unknown CPU type".
>> What parameter do I use to configure for a microblaze?
>>
>> Here are some other questions that I have.
>>
>> Where do I get the latest version of U-Boot for microblaze?
> 
> Latest version of U-BOOT is in git repository on denx.de <http://denx.de>.
> gitweb is www.denx.de/cgi-bin/gitweb.cgi
> <http://www.denx.de/cgi-bin/gitweb.cgi>
> 
>> Where do I get the latest version of mb-gcc (Microblaze gcc compiler)?
> 
> I personally use Petalogix uclibc toolchain.
> 
>> Where is the best documentation to help me get U-Boot up and running on
>> my board?
> 
> http://www.monstr.eu/wiki/
> What IP cores do you want to use?
> 
>> Any help would be appreciated.
>> Thanks
>> Bruce Christensen
> 
> Regards,
> Michal Simek


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] u-boot for Microblaze build problem

[Michal Simek]

Hi Bruce

> I am having trouble compiling a build for u-boot 1.1.6.  I have a 
> microblaze processor.  I know that I am just missing a step but I am new 
> to using u-boot and need some help.
> I have done a "make suzaku_config"
> When I compile the code I get the error "#error Unknown CPU type".
> What parameter do I use to configure for a microblaze?
> 
> Here are some other questions that I have.
> 
> Where do I get the latest version of U-Boot for microblaze?

Latest version of U-BOOT is in git repository on denx.de.
gitweb is www.denx.de/cgi-bin/gitweb.cgi

> Where do I get the latest version of mb-gcc (Microblaze gcc compiler)?

I personally use Petalogix uclibc toolchain.

> Where is the best documentation to help me get U-Boot up and running on 
> my board?

http://www.monstr.eu/wiki/
What IP cores do you want to use?

> Any help would be appreciated.
> Thanks
> Bruce Christensen

Regards,
Michal Simek


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users