Hi Stefan,
>> Some days ago a sent to mailing list patch (currently is in) where I rename >> CONFIG_XILINX_ML300 -> CONFIG_XILINX_405. >> >> I would like to see if you can use the same style for 440 -> >> CONFIG_XILINX_440. I have no detail information about ppc440 but IMHO only >> virtex5 fx (or whatever) support it -> make no sense to me use virtex5 in >> name. >> >> SR: Do you agree with me? > > Yes, renaming this to CONFIG_XILINX_440 is a good idea. nice to hear. >> There is big part of code relate with interrupt controller which is the >> same with microblaze. This should be handled in the same way. Any >> suggestion? (Do generic driver?) > > Yes, I already mentioned in my review, that this code should go into a > separate file. If the microblaze implementation is the same or very similar > then please use the same code here and move to to a common directory. > Perhaps: > > drivers/interrupt/xilinx.c ? > > Comments? 1. use macros names which are in microblaze xparameters.h. These values are generate by u-boot BSP. Add ppc440 to it solves your problem with generic boards. 2. I don't know if is good idea to create drivers for interrupt controllers. If yes xilinx_intc.c, will be better. I will wait for WD comments. >> >> BTW: some comments in code. > > Michal, your comments are very hard to spot since you don't quote the > original > code by "> ". I used web based email which is ... Michal > Best regards, > Stefan > > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] > ===================================================================== > ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
