[Bug 1850529]
(In reply to Nathan Froyd [:froydnj] from comment #19) > (In reply to Mike Hommey [:glandium] (high latency) from comment #18) > > It's very possible this is the same as bug 1601707. If it is, we don't need > > to exclude clang 6. > > OTOH, I don't want to be rediscovering that people are using a compiler that > doesn't implement some finer point of C++17 (bug 1601707 comment 5) every > couple of weeks or months, wasting time debugging, and rewriting the code to > compensate. That specific comment explicitly says current GCC doesn't implement it. Are we going to require clang only now? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
It's very possible this is the same as bug 1601707. If it is, we don't need to exclude clang 6. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1830096]
I'm confused at to why a MOZ_BUILDID "override" is necessary for you, and why the build date is a problem in the first place. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1830096 Title: Firefox 67 in Ubuntu 18.10 thinks it's an older version To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1830096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Comment on attachment 8956309 Bug 440908 - Remove gIsAnyPrefLocked. https://reviewboard.mozilla.org/r/225182/#review231210 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Comment on attachment 8956311 Bug 440908 - Convert sticky prefs in default pref files to the new syntax. https://reviewboard.mozilla.org/r/225186/#review231216 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
The ability to lock prefs at the .js level is not *only* for enterprise customization. Specifically, we have many "prefs" that are meant to allow e.g. per channel (release, beta, nightly) tweaks but are not meant for users to change. There are multiple such footguns that would be avoided by having firefox ship those as locked. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Comment on attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
https://reviewboard.mozilla.org/r/225184/#review231212
::: modules/libpref/Preferences.cpp:3982
(Diff revision 1)
> -Preferences::GetCString(kChannelPref, updateChannelPrefValue,
> -PrefValueKind::Default);
> +Preferences::GetCString(
> + kChannelPref, updateChannelPrefValue, PrefValueKind::Default);
> releaseCandidateOnBeta = updateChannelPrefValue.EqualsLiteral("beta");
>}
>
>if (!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "nightly") ||
>!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "aurora") ||
> - !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") ||
> + !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") || developerBuild ||
clang-format changed its mind, I guess?
::: modules/libpref/parser/src/lib.rs:282
(Diff revision 1)
> struct KeywordInfo {
>string: &'static [u8],
>token: Token,
> }
>
> -const KEYWORD_INFOS: &[KeywordInfo; 5] = &[
> +const KEYWORD_INFOS: &[KeywordInfo; 7] = &[
In passing, AFAIK, this could actually me [KeywordInfo; 7] (without the
ref)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Created attachment 8931547 Bug 440908 - Allow preference files to set locked prefs. Review commit: https://reviewboard.mozilla.org/r/202672/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/202672/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
(In reply to Benjamin Smedberg [:bsmedberg] from comment #36) > Comment on attachment 8613433 > Allow .js preference files to set locked prefs with lockPref() > > Because this came up on the mailing list, I'll try to be explicit about the > decision here. I don't think we should allow extensions to lock preferences, As mentioned in the long history of this bug, extensions can already lock preferences. See the attached xpi. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Created attachment 8613433 Allow .js preference files to set locked prefs with lockPref() Refreshed after bug 1098343. Benjamin, would you like to review this, this time, considering comment 26? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
(In reply to Mike Kaply [:mkaply] from comment #28) > I really don't want it being called lockPref. That will confuse it with the > autoconfig "lockPref" function. What is confusing? It's the same syntax. The only difference aiui, is the execution environment, which means autoconf can do more javascript-y things, which, as you point out, is already a source of confusion. I'd argue that having two different names is what would be confusing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Comment on attachment 8613433
Allow .js preference files to set locked prefs with lockPref()
>From b8015e0754742650a4877de9ebe7d6db2671970d Mon Sep 17 00:00:00 2001
>From: Mike Hommey
>Date: Sat, 21 Jun 2008 02:48:46 +0200
>Subject: [PATCH] Allow .js preference files to set locked prefs with
> lockPref()
>
>---
> modules/libpref/prefapi.cpp | 5 -
> modules/libpref/prefapi.h| 3 ++-
> modules/libpref/prefread.cpp | 12 +---
> modules/libpref/prefread.h | 4 +++-
> 4 files changed, 18 insertions(+), 6 deletions(-)
>
>diff --git a/modules/libpref/prefapi.cpp b/modules/libpref/prefapi.cpp
>index e898433..081c922 100644
>--- a/modules/libpref/prefapi.cpp
>+++ b/modules/libpref/prefapi.cpp
>@@ -1002,16 +1002,19 @@ static nsresult pref_DoCallback(const char*
>changed_pref)
> return rv;
> }
>
> void PREF_ReaderCallback(void *closure,
> const char *pref,
> PrefValue value,
> PrefTypetype,
> boolisDefault,
>- boolisStickyDefault)
>+ boolisStickyDefault,
>+ boolisLocked)
> {
> uint32_t flags = isDefault ? kPrefSetDefault : kPrefForceSet;
> if (isDefault && isStickyDefault) {
> flags |= kPrefStickyDefault;
> }
> pref_HashPref(pref, value, type, flags);
>+if (isLocked)
>+PREF_LockPref(pref, true);
> }
>diff --git a/modules/libpref/prefapi.h b/modules/libpref/prefapi.h
>index f1e412a..24618a7 100644
>--- a/modules/libpref/prefapi.h
>+++ b/modules/libpref/prefapi.h
>@@ -181,14 +181,15 @@ nsresult PREF_UnregisterCallback( const char* domain,
> /*
> * Used by nsPrefService as the callback function of the 'pref' parser
> */
> void PREF_ReaderCallback( void *closure,
> const char *pref,
> PrefValue value,
> PrefTypetype,
> boolisDefault,
>- boolisStickyDefault);
>+ boolisStickyDefault,
>+ boolisLocked);
>
> #ifdef __cplusplus
> }
> #endif
> #endif
>diff --git a/modules/libpref/prefread.cpp b/modules/libpref/prefread.cpp
>index 6c4d339..16c5057 100644
>--- a/modules/libpref/prefread.cpp
>+++ b/modules/libpref/prefread.cpp
>@@ -38,16 +38,17 @@ enum {
> PREF_PARSE_UNTIL_EOL
> };
>
> #define UTF16_ESC_NUM_DIGITS4
> #define HEX_ESC_NUM_DIGITS 2
> #define BITS_PER_HEX_DIGIT 4
>
> static const char kUserPref[] = "user_pref";
>+static const char kLockPref[] = "lockPref";
> static const char kPref[] = "pref";
> static const char kPrefSticky[] = "sticky_pref";
> static const char kTrue[] = "true";
> static const char kFalse[] = "false";
>
> /**
> * pref_GrowBuf
> *
>@@ -126,17 +127,17 @@ pref_DoCallback(PrefParseState *ps)
> break;
> case PREF_BOOL:
> value.boolVal = (ps->vb == kTrue);
> break;
> default:
> break;
> }
> (*ps->reader)(ps->closure, ps->lb, value, ps->vtype, ps->fdefault,
>- ps->fstickydefault);
>+ ps->fstickydefault, ps->flock);
> return true;
> }
>
> void
> PREF_InitParseState(PrefParseState *ps, PrefReader reader, void *closure)
> {
> memset(ps, 0, sizeof(*ps));
> ps->reader = reader;
>@@ -186,29 +187,32 @@ PREF_ParseBuf(PrefParseState *ps, const char *buf, int
>bufLen)
> /* initial state */
> case PREF_PARSE_INIT:
> if (ps->lbcur != ps->lb) { /* reset state */
> ps->lbcur = ps->lb;
> ps->vb= nullptr;
> ps->vtype = PREF_INVALID;
> ps->fdefault = false;
> ps->fstickydefault = false;
>+ps->flock = false;
> }
> switch (c) {
> case '/': /* begin comment block or line? */
> state = PREF_PARSE_COMMENT_MAYBE_START;
> break;
> case '#': /* accept shell style comments */
> state = PREF_PARSE_UNTIL_EOL;
> break;
> case 'u': /* indicating user_pref */
> case 'p': /* indicating pref */
> case 's': /* indicating sticky_pref */
>+case 'l': /* indicating lockPref */
> ps->smatch = (c == 'u' ? kUserPref :
>- (c == 's' ? kPrefSticky : kPref));
>+ (c == 's' ? kPrefSticky :
>+ (c == 'p' ? kPref : kLockPref)));
> ps->sindex = 1;
> ps->nextstate = PREF_PARSE_UNTIL_OPEN_PAREN;
> state = PREF_PARSE_MATCH_STRING;
> break;
> /* else skip char */
> }
> break;
>
>@@ -242,18 +246,20 @@ PREF_ParseBuf(PrefParseState *ps, cons
[Bug 541951]
The preferences code is being heavily refactored, and this needs to wait a bit for things to settle first. That being said, I do think the ideal timing for this would be to get it into 60. Nick, what do you think? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
The syntax is a triviality of the patch. The core problem here is that there's no one to review the patch so that it possibly lands. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
(In reply to Mike Kaply [:mkaply] from comment #39) > Oddly, this document: > > https://developer.mozilla.org/en-US/docs/Mozilla/Preferences/ > A_brief_guide_to_Mozilla_preferences > > Says we already support lockPref in JS files? It says: "All preferences files may call pref(), user_pref() and sticky_pref(), while the config file in addition may call lockPref()." which is about autoconf. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
>From a quick glance at the history of the patch in Debian, in the past 5 years, I had to do actual but trivial code changes twice, and adapt to context changes twice (one of them having been the change from PRBool to bool) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Comment on attachment 8956311 Bug 440908 - Convert sticky prefs in default pref files to the new syntax. https://reviewboard.mozilla.org/r/225186/#review231216 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Comment on attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
https://reviewboard.mozilla.org/r/225184/#review231212
::: modules/libpref/Preferences.cpp:3982
(Diff revision 1)
> -Preferences::GetCString(kChannelPref, updateChannelPrefValue,
> -PrefValueKind::Default);
> +Preferences::GetCString(
> + kChannelPref, updateChannelPrefValue, PrefValueKind::Default);
> releaseCandidateOnBeta = updateChannelPrefValue.EqualsLiteral("beta");
>}
>
>if (!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "nightly") ||
>!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "aurora") ||
> - !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") ||
> + !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") || developerBuild ||
clang-format changed its mind, I guess?
::: modules/libpref/parser/src/lib.rs:282
(Diff revision 1)
> struct KeywordInfo {
>string: &'static [u8],
>token: Token,
> }
>
> -const KEYWORD_INFOS: &[KeywordInfo; 5] = &[
> +const KEYWORD_INFOS: &[KeywordInfo; 7] = &[
In passing, AFAIK, this could actually me [KeywordInfo; 7] (without the
ref)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Comment on attachment 8956309 Bug 440908 - Remove gIsAnyPrefLocked. https://reviewboard.mozilla.org/r/225182/#review231210 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
The syntax is a triviality of the patch. The core problem here is that there's no one to review the patch so that it possibly lands. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
The ability to lock prefs at the .js level is not *only* for enterprise customization. Specifically, we have many "prefs" that are meant to allow e.g. per channel (release, beta, nightly) tweaks but are not meant for users to change. There are multiple such footguns that would be avoided by having firefox ship those as locked. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
The preferences code is being heavily refactored, and this needs to wait a bit for things to settle first. That being said, I do think the ideal timing for this would be to get it into 60. Nick, what do you think? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Comment on attachment 8613433
Allow .js preference files to set locked prefs with lockPref()
>From b8015e0754742650a4877de9ebe7d6db2671970d Mon Sep 17 00:00:00 2001
>From: Mike Hommey
>Date: Sat, 21 Jun 2008 02:48:46 +0200
>Subject: [PATCH] Allow .js preference files to set locked prefs with
> lockPref()
>
>---
> modules/libpref/prefapi.cpp | 5 -
> modules/libpref/prefapi.h| 3 ++-
> modules/libpref/prefread.cpp | 12 +---
> modules/libpref/prefread.h | 4 +++-
> 4 files changed, 18 insertions(+), 6 deletions(-)
>
>diff --git a/modules/libpref/prefapi.cpp b/modules/libpref/prefapi.cpp
>index e898433..081c922 100644
>--- a/modules/libpref/prefapi.cpp
>+++ b/modules/libpref/prefapi.cpp
>@@ -1002,16 +1002,19 @@ static nsresult pref_DoCallback(const char*
>changed_pref)
> return rv;
> }
>
> void PREF_ReaderCallback(void *closure,
> const char *pref,
> PrefValue value,
> PrefTypetype,
> boolisDefault,
>- boolisStickyDefault)
>+ boolisStickyDefault,
>+ boolisLocked)
> {
> uint32_t flags = isDefault ? kPrefSetDefault : kPrefForceSet;
> if (isDefault && isStickyDefault) {
> flags |= kPrefStickyDefault;
> }
> pref_HashPref(pref, value, type, flags);
>+if (isLocked)
>+PREF_LockPref(pref, true);
> }
>diff --git a/modules/libpref/prefapi.h b/modules/libpref/prefapi.h
>index f1e412a..24618a7 100644
>--- a/modules/libpref/prefapi.h
>+++ b/modules/libpref/prefapi.h
>@@ -181,14 +181,15 @@ nsresult PREF_UnregisterCallback( const char* domain,
> /*
> * Used by nsPrefService as the callback function of the 'pref' parser
> */
> void PREF_ReaderCallback( void *closure,
> const char *pref,
> PrefValue value,
> PrefTypetype,
> boolisDefault,
>- boolisStickyDefault);
>+ boolisStickyDefault,
>+ boolisLocked);
>
> #ifdef __cplusplus
> }
> #endif
> #endif
>diff --git a/modules/libpref/prefread.cpp b/modules/libpref/prefread.cpp
>index 6c4d339..16c5057 100644
>--- a/modules/libpref/prefread.cpp
>+++ b/modules/libpref/prefread.cpp
>@@ -38,16 +38,17 @@ enum {
> PREF_PARSE_UNTIL_EOL
> };
>
> #define UTF16_ESC_NUM_DIGITS4
> #define HEX_ESC_NUM_DIGITS 2
> #define BITS_PER_HEX_DIGIT 4
>
> static const char kUserPref[] = "user_pref";
>+static const char kLockPref[] = "lockPref";
> static const char kPref[] = "pref";
> static const char kPrefSticky[] = "sticky_pref";
> static const char kTrue[] = "true";
> static const char kFalse[] = "false";
>
> /**
> * pref_GrowBuf
> *
>@@ -126,17 +127,17 @@ pref_DoCallback(PrefParseState *ps)
> break;
> case PREF_BOOL:
> value.boolVal = (ps->vb == kTrue);
> break;
> default:
> break;
> }
> (*ps->reader)(ps->closure, ps->lb, value, ps->vtype, ps->fdefault,
>- ps->fstickydefault);
>+ ps->fstickydefault, ps->flock);
> return true;
> }
>
> void
> PREF_InitParseState(PrefParseState *ps, PrefReader reader, void *closure)
> {
> memset(ps, 0, sizeof(*ps));
> ps->reader = reader;
>@@ -186,29 +187,32 @@ PREF_ParseBuf(PrefParseState *ps, const char *buf, int
>bufLen)
> /* initial state */
> case PREF_PARSE_INIT:
> if (ps->lbcur != ps->lb) { /* reset state */
> ps->lbcur = ps->lb;
> ps->vb= nullptr;
> ps->vtype = PREF_INVALID;
> ps->fdefault = false;
> ps->fstickydefault = false;
>+ps->flock = false;
> }
> switch (c) {
> case '/': /* begin comment block or line? */
> state = PREF_PARSE_COMMENT_MAYBE_START;
> break;
> case '#': /* accept shell style comments */
> state = PREF_PARSE_UNTIL_EOL;
> break;
> case 'u': /* indicating user_pref */
> case 'p': /* indicating pref */
> case 's': /* indicating sticky_pref */
>+case 'l': /* indicating lockPref */
> ps->smatch = (c == 'u' ? kUserPref :
>- (c == 's' ? kPrefSticky : kPref));
>+ (c == 's' ? kPrefSticky :
>+ (c == 'p' ? kPref : kLockPref)));
> ps->sindex = 1;
> ps->nextstate = PREF_PARSE_UNTIL_OPEN_PAREN;
> state = PREF_PARSE_MATCH_STRING;
> break;
> /* else skip char */
> }
> break;
>
>@@ -242,18 +246,20 @@ PREF_ParseBuf(PrefParseState *ps, cons
[Bug 623844]
Created attachment 8931547 Bug 440908 - Allow preference files to set locked prefs. Review commit: https://reviewboard.mozilla.org/r/202672/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/202672/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
(In reply to Mike Kaply [:mkaply] from comment #28) > I really don't want it being called lockPref. That will confuse it with the > autoconfig "lockPref" function. What is confusing? It's the same syntax. The only difference aiui, is the execution environment, which means autoconf can do more javascript-y things, which, as you point out, is already a source of confusion. I'd argue that having two different names is what would be confusing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
>From a quick glance at the history of the patch in Debian, in the past 5 years, I had to do actual but trivial code changes twice, and adapt to context changes twice (one of them having been the change from PRBool to bool) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
(In reply to Mike Kaply [:mkaply] from comment #39) > Oddly, this document: > > https://developer.mozilla.org/en-US/docs/Mozilla/Preferences/ > A_brief_guide_to_Mozilla_preferences > > Says we already support lockPref in JS files? It says: "All preferences files may call pref(), user_pref() and sticky_pref(), while the config file in addition may call lockPref()." which is about autoconf. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
(In reply to Benjamin Smedberg [:bsmedberg] from comment #36) > Comment on attachment 8613433 > Allow .js preference files to set locked prefs with lockPref() > > Because this came up on the mailing list, I'll try to be explicit about the > decision here. I don't think we should allow extensions to lock preferences, As mentioned in the long history of this bug, extensions can already lock preferences. See the attached xpi. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Created attachment 8613433 Allow .js preference files to set locked prefs with lockPref() Refreshed after bug 1098343. Benjamin, would you like to review this, this time, considering comment 26? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
It was removed in 39.0. I updated https://developer.mozilla.org/en- US/docs/Mozilla/Command_Line_Options#-remote_remote_command to some extent. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 684982]
FWIW, Gtk+3 >= 3.10 has gdk_x11_window_get_desktop() and gdk_x11_window_move_to_desktop() functions... which, if you ask me, is shortsighted, since it's limited to X11, and won't work in Wayland. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684982 Title: Firefox windows don't restore on correct workspaces To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/684982/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
(In reply to Karl Tomlinson (ni?:karlt) from comment #122) > Comment on attachment 8630422 > Replace g_slice_set_config() with G_SLICE environment variable > > The g_type_init() call has been dropped. > I don't know of a static constructor using GSlice in GLib 2.32. Yeah, I was mistaken, I thought there was, but there isn't. Only g_thread is initialized, not g_slice. > >+#if defined(MOZ_WIDGET_GTK) > >+#if !GLIB_CHECK_VERSION(2, 32, 0) > > The compile time glib version check is contrary to our goal of compiling the > same code irrespective of the compile environment. I thought that too, and then I found a bunch of preprocessor glib version checks (various GLIB_CHECK_VERSION in harfbuzz, and various GLIB_MAJOR/MINOR_VERSION checks here and there, although, looking at them, they are actually useless because they're for versions even older than what we support ; harfbuzz does check for versions well above 2.18). > Can this just be "if MOZ_WIDGET_GTK == 2" ? sure > I'd also be happy to drop support for G_SLICE=always-malloc on versions prior > to 2.32 if that makes the g_thread_init situation simpler. However, I don't > know whether it is acceptable to call g_thread_init after g_type_init in > versions prior to 2.24. g_thread_init can be called multiple times in versions >= 2.24, and gtype.c says, about g_type_init, "Since version 2.24 this also initializes the thread system". So if we're okay with dropping G_SLICE =always-malloc for versions 2.18 to 2.23 included, we should be able to get away with only calling g_type_init. Another option would be to just call g_slice_alloc/g_slice_free1, which will obviously initialize gslice, and after all, sounds much simpler. Thoughts? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
... and it so happens that we're calling g_thread_init(NULL) from different places, and likely crash for that reason with older glib... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
Created attachment 8631479 Replace g_slice_set_config() with G_SLICE environment variable Not enough changes to require another review from Nathan. This should address your concerns. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
Created attachment 8628085 Replace g_slice_set_config() with G_SLICE environment variable -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
Created attachment 8630422 Replace g_slice_set_config() with G_SLICE environment variable Turns out there aren't many places where g_thread_init is actually called. There's some webrtc code that we don't build, and other than that, other uses are exclusive... but need to be factored in, so this became a bit awful. At the same time I added a compile time glib check that removes the g_thread_init call when building against glib >= 2.32, which is the case for gtk3 builds. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
(In reply to Karl Tomlinson (ni?:karlt back June 30) from comment #112) > I had intentionally chosen not to override an existing G_SLICE environment > variable so that this could be overridden or debug-blocks could be used if > desired. That's not a show-stopper, but avoiding overriding would avoid > having to copy the old value to restore. I guess that would work just as much. I was worried that some systems might have G_SLICE set for some wrong reasons. I don't have a strong opinion anyways. > I don't know why you are preferring setenv over putenv here. > I had chosen putenv to avoid the leak. I chose setenv to avoid having both "G_SLICE" and "G_SLICE=always- malloc" as .rodata. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
Created attachment 8626818 0001-Bug-833117-Replace-g_slice_set_config-with-G_SLICE-e.patch Using g_slice_set_config() fails with newer glib because the slice allocator now has a static constructor that runs when glib is loaded, consequently emitting a noisy error message which confuses people into believing it's the root of their problems. The only way left to force the slice allocator to use "system" malloc (in practice, jemalloc) is to set the G_SLICE environment variable to always-malloc, and that needs to happen before glib is loaded. Fortunately, the firefox and plugin-container executables don't depend on glib. Unfortunately, webapprt does, so the problem remains for web apps running through it. xpcshell and other executables that depend on libxul directly (as opposed to loading it dynamically) are not covered either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
(In reply to Mike Hommey [:glandium] from comment #117) > Backed out for gtest bustage: > https://hg.mozilla.org/integration/mozilla-inbound/rev/c0f955560a47 > > 23:59:34 INFO - GThread-ERROR **: GThread system may only be initialized > once. And this error was removed in glib 2.23.x 5 years ago, which is why I can't reproduce locally... https://bugzilla.gnome.org/show_bug.cgi?id=606775 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
Backed out for gtest bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0f955560a47 23:59:34 INFO - GThread-ERROR **: GThread system may only be initialized once. 23:59:34 INFO - aborting... 23:59:34 INFO - Redirecting call to abort() to mozalloc_abort 23:59:35 WARNING - gtest TEST-UNEXPECTED-FAIL | gtest | test failed with return code -139 23:59:35 INFO - make[1]: *** [check] Error 1 It also happens to break valgrind builds: /builds/slave/m-in-l64-valgrind-/src/xpcom/glue/standalone/nsXPCOMGlue.cpp:469:14: error: unused variable 'gSliceInit' [-Werror=unused-variable] -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
Comment on attachment 8573128 Backout the part that removed -remote That being said, I can see a point in being more conservative for the upcoming ESR. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
(In reply to noitidart from comment #85) > (In reply to Mike Hommey [:glandium] from comment #84) > > (In reply to noitidart from comment #83) > > > (In reply to Mike Hommey [:glandium] from comment #82) > > > > Comment on attachment 8573128 > > > > Backout the part that removed -remote > > > > > > > > Approval Request Comment: See comment 64 > > > > > > > > Considering how late we are in the beta cycle, it's more reasonable to > > > > get > > > > this on 37. 38 will get the alternative approach. > > > > > > Aw darn are you sure we can't land it in 36? Then for backwards > > > compatability addons have to work in an exception for just FF36. :( And I > > > know software like Notepad++ and other softwares won't add in an exception > > > for FF36. It will impact ESR when it gets to FF36 for the longest amount > > > of > > > time. > > > > > > Just sharing my thoughts on some ways it hurts if we cant get it into FF36 > > > but I appreciate you guys bringing it back, even if it doesnt get to FF36. > > > > Do you mean 38 everywhere you wrote 36? Do you also mean that notepad++ on > > windows is actually using the -remote option? And what addons are you > > talking about? Addons should not care about Firefox command line. > > No man I was hoping for FF36 :( I'm addon dev and I use this command line. -remote was restored in 36.0.1 already. But maybe you're still talking about comment 80? In which case, it is not related to this bug. > Yep Notepad++ when you do preview in webbrowser it wont open. I just tested, and it works. Also, Notepad++ doesn't use -remote, it just invokes "firefox.exe edited-file-name". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
Comment on attachment 8573128 Backout the part that removed -remote Approval Request Comment: See comment 64 Considering how late we are in the beta cycle, it's more reasonable to get this on 37. 38 will get the alternative approach. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
(In reply to noitidart from comment #83) > (In reply to Mike Hommey [:glandium] from comment #82) > > Comment on attachment 8573128 > > Backout the part that removed -remote > > > > Approval Request Comment: See comment 64 > > > > Considering how late we are in the beta cycle, it's more reasonable to get > > this on 37. 38 will get the alternative approach. > > Aw darn are you sure we can't land it in 36? Then for backwards > compatability addons have to work in an exception for just FF36. :( And I > know software like Notepad++ and other softwares won't add in an exception > for FF36. It will impact ESR when it gets to FF36 for the longest amount of > time. > > Just sharing my thoughts on some ways it hurts if we cant get it into FF36 > but I appreciate you guys bringing it back, even if it doesnt get to FF36. Do you mean 38 everywhere you wrote 36? Do you also mean that notepad++ on windows is actually using the -remote option? And what addons are you talking about? Addons should not care about Firefox command line. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
(In reply to noitidart from comment #80) > (In reply to Pavlos Touboulidis from comment #79) > > (In reply to noitidart from comment #78) > > > I opened my 2nd profile with this: > > > firefox.exe -P Dev -no-remote > > > > Try "firefox.exe -P Dev -new-instance" > > Thanks Pavlos I tried that. > > 1) firefox.exe -P Dev -new-instance > 2) it opened new window of the current profile already open, it did not open > my proflie named Dev > > So i tried this: > 1) firefox.exe -P Dev -new-instance -no-remote > > this opened my profiled named Dev in parallel/concurrent to my other running > profile > I then tried to remote it: > 2) firefox.exe -P Dev -remote "openURL(http://www.bing.com,new-tab)" > > but it just opens a new window in my first running profile, and it doesnt > even point to bing.com just the homepage of that first running profile :( That's bug 1138053 and it's fixed in nightly. Use -new-tab instead of -remote, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/emacs/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
(In reply to Jean-Yves Perrier [:teoli] from comment #75) > So, if I'm following correctly: -remote was removed in Fx 36, readded in the > chemspill 36.0.1 and won't be removed in 37 at least? > > Is this correct (We also need to update Fx 36 for devs). Err, I missed a not in my sentence. It is *not* guaranteed to still be there in 37. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/exo/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
It's in 36.0.1, but it's guaranteed to still be there in 37. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/exo/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1425972]
(In reply to noitidart from comment #69) > Quick update, another thing this broke is the Windows 7 + jump menu: > http://i.imgur.com/OiyEzUI.png This makes no sense, those are not using -remote: https://dxr.mozilla.org/mozilla- central/source/browser/modules/WindowsJumpLists.jsm#91 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1425972 Title: Firefox no longer supports -remote parameter To manage notifications about this bug go to: https://bugs.launchpad.net/exo/+bug/1425972/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1401402]
If every distro uses a different key, then Google can distinguish which distro users are using. Wouldn't that qualify as a privacy breach? IIRC, we explicitely don't send the google cookie for safebrowsing. If we don't do that for geoloc, that would seem like a bug. OTOH, they can probably correlate with the google cookie the user is already using in the same browser... So while using a different key means more information available to google, is it actually making things worse than they already are? That being said, doesn't shipping those keys in the source packages in distros breach their TOS? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1401402 Title: Ubuntu build of Firefox lacks Google OAuth ID, prevents contact import in Hello To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1401402/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1401402]
(In reply to Chris Coulson from comment #17) > The next Firefox update on Ubuntu will have this fixed How are you fixing this? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1401402 Title: Ubuntu build of Firefox lacks Google OAuth ID, prevents contact import in Hello To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1401402/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
(In reply to Jacob Bramley [:jbramley] from comment #35) > Doesn't this affect Android too? They use armhf these days, I believe. Android builds use softfp afaik. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
And, in fact, Fedora does too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1398898]
Ubuntu also does Firefox builds on armhf. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1398898 Title: [armhf] segfaults when trying to save a file To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1398898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1315020]
(In reply to Matt Woodrow (:mattwoodrow) from comment #35) > https://hg.mozilla.org/integration/mozilla-inbound/rev/3b5fb4abaa3f Matt, can you get this landed on beta? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1315020 Title: PDF.js prints blank pages To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1315020/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 263661]
(In reply to comment #59) > Who would I have to blackmail to get more recent Nouveau drivers into > experimental? You can try debia...@lists.debian.org directly, or file a wishlist bug against xserver-xorg-video-nouveau. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/263661 Title: Black Line appears next to gif and png images To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/263661/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 263661]
Using cairo 1.10.0 and pixmap 0.21.2, everything is displayed gracefully on 4.0b8 built against system cairo, on intel display. (iceweasel from http://mozilla.debian.net/packages/, and cairo and pixmap from current debian experimental, for those who care). Nouveau drivers are likely to be the culprit. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/263661 Title: Black Line appears next to gif and png images To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/263661/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
(In reply to Karl Tomlinson (back Jan 28 :karlt) from comment #44) > On irc, glandium indicated that he would prefer to dlopen libglib (before > anything depends on libgobject) and use the deprecated g_slice_set_config > internal debugging api, than follow Matthias' suggestion to use > GSLICE=always-malloc, because of the awkwardness of putenv/unsetenv. Note you can actually just use g_slice_set_config directly, and build with -lglib-2.0. Makes it less easy to do that centrally, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion `sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
Comment on attachment 8367119 replace g_slice_set_config with G_SLICE env var Review of attachment 8367119: - Considering g_slice_set_config is only deprecated at the moment, I'd rather use it and fallback to environment variables if it can't be used. Also, you're only touching browser, while at least b2g and xulrunner have the same initialization code (which is why it was better in nsAppRunner in the first place, but i guess it's too late there). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion `sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
I concur with Karl. In fact, those crashes might be related to bug 920200. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion `sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
(In reply to Karl Tomlinson (:karlt) from comment #27) > It seems unfortunate that different libraries and apps have a need to > implement their own allocators. It seems unfortunate that disabling a library's internal allocator is an "internal debugging API" -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion `sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 217300]
(In reply to Alexander Korsunsky from comment #114) > This HAS been implemented as an addon: > https://github.com/infinity0/mozilla-gnome-keyring > > The problem is that it has to be a binary add-on (...) This isn't true. jsctypes can be used to call whatever APIs the binary addon uses. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/217300 Title: Seahorse integration To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/217300/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 41179]
(In reply to Alexander Korsunsky from comment #114) > This HAS been implemented as an addon: > https://github.com/infinity0/mozilla-gnome-keyring > > The problem is that it has to be a binary add-on (...) This isn't true. jsctypes can be used to call whatever APIs the binary addon uses. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/41179 Title: Integrate with Gnome Keyring To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/41179/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
gah these things are confusing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion `sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1160569]
(In reply to Chris Coulson from comment #0) > On Linux, the glib slice allocator is disabled in |XREMain::XRE_main| by > calling |g_slice_set_config| (see bug 431221). However, this no longer works > since glib 2.35 because libgobject (which libxul depends on) now has a > static initializer which indirectly initializes the slice allocator before > |main| is reached (in order to automatically initialize the gobject dynamic > type system). This means that the call to g_slice_set_config always fails > with the following assertion: > > (process:24722): GLib-CRITICAL **: g_slice_set_config: assertion > `sys_page_size == 0' failed That's not what the glib code suggests. That error (sys_page_size == 0) happens because the slice allocator is *not* initialized. If it was initialized, sys_page_size would be set (it is set in g_slice_init_nomessage). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion `sys_page_size == 0' failed To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1160569/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1051559]
It depends if you are talking about runtime requirements or build-time requirements. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1051559 Title: Build Firefox with GStreamer support To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1051559/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 41179]
Comment on attachment 713377 Store Master Password by using libsecret to Gnome Keyring patch v1 Review of attachment 713377: - ::: security/manager/ssl/src/nsNSSCallbacks.cpp @@ +800,5 @@ > + rv = profileDir->GetNativeLeafName(profileName); > + if (rv != NS_OK) > +return; > + nsCString keyDescription; > + keyDescription.Assign(MOZ_APP_NAME); You don't want to use MOZ_APP_NAME here. Use nsIXULAppInfo data. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/41179 Title: Integrate with Gnome Keyring To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/41179/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 217300]
Comment on attachment 713377 Store Master Password by using libsecret to Gnome Keyring patch v1 Review of attachment 713377: - ::: security/manager/ssl/src/nsNSSCallbacks.cpp @@ +800,5 @@ > + rv = profileDir->GetNativeLeafName(profileName); > + if (rv != NS_OK) > +return; > + nsCString keyDescription; > + keyDescription.Assign(MOZ_APP_NAME); You don't want to use MOZ_APP_NAME here. Use nsIXULAppInfo data. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/217300 Title: Seahorse integration To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/217300/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 217300]
(In reply to jhorak from comment #79) > Thanks for feedback. > The u"str" or NS_LL is char16_t*. I'm not sure if I can safely cast it to > PRUnichar), can I? Note you can't use u"" because that's only supported in c++11 mode, and we still support not building in that mode. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/217300 Title: Seahorse integration To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/217300/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 41179]
(In reply to jhorak from comment #79) > Thanks for feedback. > The u"str" or NS_LL is char16_t*. I'm not sure if I can safely cast it to > PRUnichar), can I? Note you can't use u"" because that's only supported in c++11 mode, and we still support not building in that mode. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/41179 Title: Integrate with Gnome Keyring To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/41179/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 428306]
(In reply to Chris Coulson from comment #14) > Created attachment 602368 > Treat distribution/searchplugins as a known location and don't use the full > path for the search engine ID's > > We've been carrying a distro patch for a long time to do the normalize() in > _loadEnginesFromDir(), and I'd like to be able to drop this at some point. > Whilst normalize() works for us, it probably wouldn't work in all cases (ie, > if the application directory can move around and nobody symlinked the > distribution folder to a stable path). > > Would you accept something like the attached patch (which basically treats > distribution/searchplugins as a known location)? Interestingly, I have a somehow similar patch in debian, but i treat distribution/searchplugins as [app]/ instead of [distribution]/, because i moved all the default searchplugins there. And I have some additional code to make the transition smoother, although there are apparently some edge cases where that doesn't work quite well. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/428306 Title: default search engines are removed and readded (keywords wiped) with upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/428306/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 901838]
(In reply to Mike Hommey [:glandium] from comment #17) > Risk to taking this patch (and alternatives if risky): (forgot to fill here) very low risk, and has been tested widely for a while now (since it was released in 11). It would be nice if it was applied on ESR, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/901838 Title: Ugly busy cursor in Thunderbird 9 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/901838/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 901838]
Comment on attachment 581198 Try creating a named cursor before a bitmap cursor (v2) [Approval Request Comment] User impact if declined: Regression in aspect of various mouse cursors not following the system theme on Linux systems in Firefox with ui.use_activity_cursor set to true, and in Thunderbird. Fix Landed on Version: 11 Risk to taking this patch (and alternatives if risky): String changes made by this patch: None -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/901838 Title: Ugly busy cursor in Thunderbird 9 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/901838/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a3a7b9c6b0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Landry Breuil from comment #117)
> So that'd mean replacing :
>
> #error "The cacheFlush support is missing on this platform."
>
> by
>
> static void cacheFlush(void*, size_t)
> {
> #warning "Using dummy generic & empty cacheFlush for this platform."
> }
>
> Do you think that'll work out ? Since from my understanding of the previous
> comments cacheFlush() is only called if there's a JIT..
That would work, but that would fail to ensure people adding a JIT for a
new platform make sure cacheFlush is implemented correctly for that
platform. (a warning is most probably not going to be seen)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/908508
Title:
Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
What might work, is to remove the error and put nothing to replace it. Adding a JIT for a new platform will make the function required, and compilation will fail because it is completely missing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Landry Breuil from comment #115) > So let's try to get this reviewed and hope this time it sticks. Only change > from att 619876 is indentation fixed in Makefile.in (use tabs) and > (defined(WTF_CPU_PPC) && !defined(JS_CPU_PPC_OSX)) for using the dummy > cacheFlush. You should use something else than (defined(WTF_CPU_PPC) && !defined(JS_CPU_PPC_OSX)), otherwise, I'll have to file yet another bug for other platforms... I'm not convinced listing architectures is going to be any helpful there. I think what is important is whether there is a JIT or not. If there is no JIT, then the dummy cacheFlush works. If there is, then there should be an actual cacheFlush implementation for the given platform, or an explicit use of the dummy one like for x86/x64, which don't require cache flushing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
A safe way to implement cacheFlush that would be to have a dummy implementation that does nothing (cacheFlush is completely unimportant when there is no JIT), with the following preprocessor goop (or something similar): #ifndef ENABLE_ASSEMBLER #error cacheFlush unimplemented for this platform #endif. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to David Mandelin from comment #91) > JSC sets those flags in what we imported as assembler/wtf/Platform.h, which > seems reasonable. In fact, I see they set ENABLE_ASSEMBLER in there > depending on various conditions, which is maybe why the patch works on most > platforms already. Platform.h is not supposed to be a public header; at least it's not exposed as one presently. Relying on it is going to break third parties using public headers. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Landry Breuil from comment #88) > Righto.. but ENABLE_YARR_JIT is not known when you're creating js-config.h, > since it's in Makefile.in. and ENABLE_YARR_JIT is needed to know if we need > to define ENABLE_ASSEMBLER. So ENABLE_YARR_JIT definition would have to go > to configure too ? Yes. That these things are in Makefile.in is a mistake anyways. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
The best place is probably js-config.h.in, so that external apps building against the headers don't end up with the same problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Landry Breuil from comment #85) > (In reply to David Mandelin from comment #82) > > Landry, following up on a hint from billm, I got your patch to work on Linux > > with this addition: > > > > diff -r e7bbcbb6c24a js/src/jscntxt.h > > --- a/js/src/jscntxt.h Tue Mar 13 17:42:33 2012 -0700 > > +++ b/js/src/jscntxt.h Tue Mar 13 18:32:46 2012 -0700 > > @@ -64,6 +64,7 @@ > > #include "js/HashTable.h" > > #include "js/Vector.h" > > #include "vm/Stack.h" > > +#include "assembler/jit/ExecutableAllocator.h" > > > > #ifdef _MSC_VER > > #pragma warning(push) > > > > > > I'm not quite sure what's going on, but it kind of seems like > > ENABLE_ASSEMBLER=1 is not being set for all the files in the build, and so > > different object files get different definitions of JSRuntime, which causes > > the trc field to get overwritten with junk, and then you crash. Your patch > > does modify how ENABLE_ASSEMBLER is set, so it seems vaguely plausible that > > could be the problem. > > Aha. Very interesting... a shroedingbug. > > > The strange thing is that it seems like js.cpp is the file that doesn't get > > ENABLE_ASSEMBLER=1, but I do see it being set on the command line to build > > js.o. And it also doesn't make much sense that the patch above would solve > > the problem. > > If i look at old build logs on amd64, i don't see ENABLE_ASSEMBLER=1 in the > js.o build > line, maybe because it's set in js/src/Makefile.in and not in > js/src/shell/Makefile.in ? > > I'll recheck with a clean tip and only that patch. > I've also pushed the corresponding patchset to > https://tbpl.mozilla.org/?tree=Try&rev=88122a478851 > > For me that change make sense, since that brings ExecutableAllocator > definition > to jscntxt.h where as of now, it's used without knowing how it's defined. Except iirc, including that header leads to a failure to build on various architectures. So you'd fix what the patch here broke, but you break what the patch was supposed to fix. The right solution is probably to define ENABLE_ASSEMBLER elsewhere than js/src/Makefile.in. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Well, if it's breaking linux debug builds, it means it's *not* only shuffling ifdefs around. So you should start by checking that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Marco Bonardo [:mak] from comment #67) > backed out as suspected for a bunch of jit tests failures in linux debug > builds > see > https://tbpl.mozilla.org/php/getParsedLog.php?id=9878244&tree=Mozilla-Inbound > https://tbpl.mozilla.org/php/getParsedLog.php?id=9878570&tree=Mozilla-Inbound > > while this looks like for other platforms, it was the most likely candidate Note that theoretically, this patch doesn't change anything on tier-1 platforms. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 603183 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported I refreshed the patch against current mozilla-inbound. Landry, can you check I didn't break anything? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
These symbols are supposed to be in one OR the other, not in both. The relevant snippet in js/src/Makefile.in is: ifeq (,$(MOZ_GLUE_PROGRAM_LDFLAGS)) # When building standalone, we need to include mfbt sources, and to declare # "exported" mfbt symbols on its behalf when we use its headers. include $(srcdir)/../../mfbt/sources.mk DEFINES += -DIMPL_MFBT endif when building the js engine standalone, MOZ_GLUE_PROGRAM_LDFLAGS is empty, but not when building Gecko. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
For checkSyntax, nothing needs to be done, really. Essentially, the #ifdef is wrong, the code is not tied to the YARR JIT, it's tied to YARR. So removing the #ifdef works. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
> Yes, except that YarrSyntaxChecker.cpp is in CPPSRCS only in ENABLE_YARR_JIT case.. Both your patch and my older patch add YarrSyntaxChecker.cpp to CPPSRCS in the non-ENABLE_YARR_JIT case -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Yes, but for sparc, it's more subtle: ENABLE_ASSEMBLER needs to be set for the normal non YARR JIT. Man, what a mess. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
That's why ENABLE_ASSEMBLER needs to be off. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Hint: a lot of the !ENABLE_YARR_JIT uses really mean USE_PCRE. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Landry Breuil from comment #14) > Just to clarify.. is your patch in debian a build fix for fx 10.0beta on ppc > & sparc, or only sparc ? "on platforms where YARR JIT is not supported" -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
(In reply to Mike Hommey [:glandium] from comment #12) > Created attachment 588391 > Use YARR interpreter instead of PCRE on platforms where YARR JIT is not > supported > > This is the bug Err. the patch, not the bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 908508]
Created attachment 588391 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported This is the bug I have for beta in Debian. Unfortunately, it doesn't apply to aurora and m-c. For me, this seriously raises the question as to whether we (mozilla) should be adding js-only builds with JIT disabled at compile time to avoid this in the future, because this is exhausting, especially at the pace of changes in the JS engine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Created attachment 576542 Allow .js preference files to set locked prefs with lockPref() Sorry for the noise, just testing "hg bzexport". I'm still interested to know who could review this, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Created attachment 576542 Allow .js preference files to set locked prefs with lockPref() Sorry for the noise, just testing "hg bzexport". I'm still interested to know who could review this, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 541951]
Created attachment 572068 Allow .js preference files to set locked prefs with lockPref() Refreshed after the PRBool/bool change. Now, as bsmedberg won't review it, and dwitte is essentially not around anymore, who can review this? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/541951 Title: Firefox 3.6 does not honour lockPref To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 623844]
Created attachment 572068 Allow .js preference files to set locked prefs with lockPref() Refreshed after the PRBool/bool change. Now, as bsmedberg won't review it, and dwitte is essentially not around anymore, who can review this? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 102408]
Something else: mailcap support uses nsIProcess to start commands. These wouldn't be covered either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/102408 Title: Helper apps inherit open file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/centos-dead/+bug/102408/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 176902]
Something else: mailcap support uses nsIProcess to start commands. These wouldn't be covered either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/176902 Title: kpdf locks sound output To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/176902/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 159258]
Something else: mailcap support uses nsIProcess to start commands. These wouldn't be covered either. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/159258 Title: Helper applications launched by Firefox inherit ALL file descriptors To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/159258/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
