[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Corey Bryant]

** Also affects: cloud-archive/icehouse
   Importance: Undecided
   Status: New

** Changed in: cloud-archive
   Status: New => Invalid

** Changed in: cloud-archive
   Status: Invalid => Fix Released

** Also affects: neutron (Ubuntu Trusty)
   Importance: Undecided
   Status: New

** Changed in: neutron (Ubuntu Trusty)
 Assignee: (unassigned) => Shane Peters (shaner)

** Changed in: cloud-archive/icehouse
 Assignee: (unassigned) => Shane Peters (shaner)

** Changed in: neutron (Ubuntu)
 Assignee: Shane Peters (shaner) => (unassigned)

** Changed in: cloud-archive/icehouse
   Status: New => In Progress

** Changed in: neutron (Ubuntu Trusty)
   Status: New => In Progress

** Changed in: neutron (Ubuntu)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Shane Peters]

Corey,
  I appreciate the feedback! Here's an updated patch.

** Patch added: "lp1374663.debdiff"
   
https://bugs.launchpad.net/neutron/+bug/1374663/+attachment/4772061/+files/lp1374663.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Corey Bryant]

Shane,

Thanks for the patch. Just a few minor comments:
* did you mean to bump concurrency to 16? it's probably fine since it's just 
for running tests. just want to make sure it doesn't lock up the next dev's 
machine. :)
* if it's possible to cherry-pick this patch from the next higher available 
upstream release branch/tag (> icehouse) then I'd prefer you did that (git 
checkout icehouse-eol; git cherry-pick -x uuid of commit).
* also relevant patch headers should be added: 
http://packaging.ubuntu.com/html/patches-to-packages.html#patch-headers

Thanks,
Corey

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Shane Peters]

** Changed in: neutron (Ubuntu)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Ubuntu Foundations Team Bug Bot]

The attachment "trusty_lp1374663.debdiff" seems to be a debdiff.  The
ubuntu-sponsors team has been subscribed to the bug report so that they
can review and hopefully sponsor the debdiff.  If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe
the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Shane Peters]

Patch for neutron_2014.1.5-0ubuntu6

** Patch added: "trusty_lp1374663.debdiff"
   
https://bugs.launchpad.net/neutron/+bug/1374663/+attachment/4770768/+files/trusty_lp1374663.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Shane Peters]

** Description changed:

- The get_devices() method in neutron/agent/linux/ip_lib.py chokes if
- 'iproute2' presents interface names containing '@', such as ipip
- tunnels:
+ [Impact]
  
- 513: tunl0@NONE:  mtu 1480 qdisc noop state DOWN mode DEFAULT 
group default 
- link/ipip 0.0.0.0 brd 0.0.0.0
+  * The get_devices() method in neutron/agent/linux/ip_lib.py chokes if 
'iproute2' presents interface names containing '@', such as ipip tunnels and 
macvlan devices:
+   
+   tunl0@NONE:  mtu 1480 qdisc noop state DOWN mode DEFAULT 
group default
+   clone@eth0:  mtu 1454 qdisc noop state 
DOWN mode DEFAULT
+ 
+   * The mere presence of one of the above interface names will cause the
+ code to fail with:
  
- And macvlan devices:
+   RuntimeError:
+   Command: ['ip', 'addr', 'show', 'tunl0@NONE']
+   Exit code: 1
+   Stdout: ''
+   Stderr: 'Device "tunl0@NONE" does not exist.\n'
  
- 4: clone@eth0:  mtu 1454 qdisc noop state DOWN mode 
DEFAULT group default 
- link/ether c6:dd:66:a5:f6:5c brd ff:ff:ff:ff:ff:ff
  
- Consider the follow sample code:
+ [Test Case]
  
- from neutron.agent.linux.ip_lib import IPWrapper
+  * This has been seen in the vpn_agent.log after upgrading to a xenial kernel 
(4.4.0-45-generic) in a trusty/icehouse environment.
+
+ /var/log/neutron/vpn_agent.log:
+ ERROR neutron.agent.linux.interface [-] Failed unplugging interface   
'qg-e75da35-63@if10' 
  
- ip = IPWrapper()
- for iface in ip.get_devices():
- print iface.name, iface.addr.list()
  
- The mere presence of one of the above interface names will cause the
- code to fail with:
+ [Regression Potential]
  
- RuntimeError: 
- Command: ['ip', 'addr', 'show', 'tunl0@NONE']
- Exit code: 1
- Stdout: ''
- Stderr: 'Device "tunl0@NONE" does not exist.\n'
+   * iproute2 is still used, however, a search path was added
+ (/sys/class/net) which returns the interfaces without the '@'.
  
- This can cause failures in, e.g.,
- neutron/plugins/linuxbridge/agent/linuxbridge_neutron_agent.py, which
- performs almost exactly the same iteration in the
- get_interface_by_ip() method.
+   * This has been fixed since Kilo so there is minimal regression
+ potential.
+ 
+ 
+ [ Other Info ]
+ 
+   *

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Shane]

** Tags added: sts

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Shane]

** Also affects: neutron (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: neutron (Ubuntu)
 Assignee: (unassigned) => Shane (shaner)

** Also affects: cloud-archive
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs