Shane,

Thanks for the patch. Just a few minor comments:
* did you mean to bump concurrency to 16? it's probably fine since it's just 
for running tests. just want to make sure it doesn't lock up the next dev's 
machine. :)
* if it's possible to cherry-pick this patch from the next higher available 
upstream release branch/tag (> icehouse) then I'd prefer you did that (git 
checkout icehouse-eol; git cherry-pick -x uuid of commit).
* also relevant patch headers should be added: 
http://packaging.ubuntu.com/html/patches-to-packages.html#patch-headers

Thanks,
Corey

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to