[Bug 1892558] Re: [SRU] binhex always segfaults
This bug was fixed in the package macutils - 2.0b3-16ubuntu0.1 --- macutils (2.0b3-16ubuntu0.1) focal; urgency=medium * Fix segfault with binhex, frommac and tomac. (LP: #1892558) -- Sudip Mukherjee Fri, 29 Mar 2024 14:16:10 + ** Changed in: macutils (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892558] Re: [SRU] binhex always segfaults
** Changed in: macutils (Ubuntu Focal) Assignee: Sudip Mukherjee (sudipmuk) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892558] Re: [SRU] binhex always segfaults
I can confirm that the package macutils from focal-proposed has fixed the bug for me. Test done: Install macutils on a focal installation. execute "binhex -H" and confirm the issue is seen Add focal-proposed to apt sources update macutils from focal-proposed follow the testplan and execute all the binaries with "-H" and confirm that none of them segfaults. Test result: the issue with macutils has been fixed. Package tested: $ apt-cache policy macutils macutils: Installed: 2.0b3-16ubuntu0.1 Candidate: 2.0b3-16ubuntu0.1 Version table: *** 2.0b3-16ubuntu0.1 500 500 http://gb.archive.ubuntu.com/ubuntu focal-proposed/universe amd64 Packages 100 /var/lib/dpkg/status 2.0b3-16build1 500 500 http://gb.archive.ubuntu.com/ubuntu focal/universe amd64 Packages ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892558] Re: [SRU] binhex always segfaults
$ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done focal Version: 2.0b3-16build1 /usr/bin/binhex RC = 139 /usr/bin/frommac RC = 139 /usr/bin/hexbin RC = 0 /usr/bin/macsave RC = 0 /usr/bin/macstream RC = 0 /usr/bin/macunpack RC = 0 /usr/bin/tomac RC = 139 ubuntu@focal:~$ $ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done jammy Version: 2.0b3-17 /usr/bin/binhex RC = 0 /usr/bin/frommac RC = 0 /usr/bin/hexbin RC = 0 /usr/bin/macsave RC = 0 /usr/bin/macstream RC = 0 /usr/bin/macunpack RC = 0 /usr/bin/tomac RC = 0 $ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done No LSB modules are available. mantic Version: 2.0b3-17 /usr/bin/binhex RC = 0 /usr/bin/frommac RC = 0 /usr/bin/hexbin RC = 0 /usr/bin/macsave RC = 0 /usr/bin/macstream RC = 0 /usr/bin/macunpack RC = 0 /usr/bin/tomac RC = 0 $ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done No LSB modules are available. noble Version: 2.0b3-17 /usr/bin/binhex RC = 0 /usr/bin/frommac RC = 0 /usr/bin/hexbin RC = 0 /usr/bin/macsave RC = 0 /usr/bin/macstream RC = 0 /usr/bin/macunpack RC = 0 /usr/bin/tomac RC = 0 ** Changed in: macutils (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892558] Re: [SRU] binhex always segfaults
Hi Sudip, Thanks for debugging, backporting, and submitting a patch! Nice touch on the DEP-3 headers. Just a style/cosmetic _suggestion_ that is helpful: in the future, please list the .patch file in d/changelog; e.g., '* d/p/fix-segfault.patch: Fix segfault with binhex, frommac and tomac. (LP: #1892558)' And just for documentation purposes: > There is no change in code, only the relevant header file has been included. > And, so there are minimum chances of a regression. The inclusion of a header file even 'without code changes' may actually cause code changes _indirectly_. For example, a header file defines a macro that is checked in the source file (to change code paths) with a preprocessor #if/#ifdef. This is _not_ the case here, as the included headers only define the function prototypes, and nothing else/no macro; so it looks good! I also confirmed that the newer releases have the change and are not affected. Accepting macutils to focal-proposed. Thanks again! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892558] Re: [SRU] binhex always segfaults
Thank you for the patch. Uploaded to Focal. ** Changed in: macutils (Ubuntu Focal) Status: Confirmed => In Progress ** Changed in: macutils (Ubuntu Focal) Assignee: (unassigned) => Sudip Mukherjee (sudipmuk) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892558] Re: [SRU] binhex always segfaults
debdiff attached. ** Summary changed: - binhex always segfaults + [SRU] binhex always segfaults ** Description changed: + [ Impact ] + + some of the binaries provided by macutils are completely unusable as they will immediately segfault as soon as they are executed. + The impacted binaries are: + binhex + tomac + frommac + + This is because the relevant header file was not included and so as as + result the compiler assumed the functions return an integer. + + [ Test Plan ] + + 1. Install macutils + 2. Execute all the binaries provided by macutils for a basic sanity test + + binhex -H + frommac -H + hexbin -H + macsave -H + macstream -H + macunpack -H + tomac -H + + If the package is not fixed then binhex, tomac and frommac will result in segfault. + + + [ Where problems could occur ] + + There is no change in code, only the relevant header file has been + included. And, so there are minimum chances of a regression. The change + has been part of Debian and also Jammy onwards and there has been no + regression reported. + + [ Other Info ] + + The testplan only does a basic sanity test. Ideally a macutils user + should test and confirm that everything is working as expected. + + [ Original Bug Description ] + Steps to reproduce: binhex -H Expected result: binhex prints help information Actual result: binhex crashes with SIGSEGV Comments: binhex doesn't only crash with the -H flag, it crashes with any flag. It appears to crash in the main() function before any argument handling actually happens. Version is 2.0b3-16build1. ProblemType: Bug DistroRelease: Ubuntu 18.04 Package: macutils 2.0b3-16build1 ProcVersionSignature: Ubuntu 5.4.0-42.46~18.04.1-generic 5.4.44 Uname: Linux 5.4.0-42-generic x86_64 ApportVersion: 2.20.9-0ubuntu7.16 Architecture: amd64 CurrentDesktop: KDE Date: Fri Aug 21 20:57:56 2020 Dependencies: - gcc-8-base 8.4.0-1ubuntu1~18.04 - libc6 2.27-3ubuntu1.2 - libgcc1 1:8.4.0-1ubuntu1~18.04 + gcc-8-base 8.4.0-1ubuntu1~18.04 + libc6 2.27-3ubuntu1.2 + libgcc1 1:8.4.0-1ubuntu1~18.04 InstallationDate: Installed on 2020-02-01 (202 days ago) InstallationMedia: Ubuntu 18.04.2 LTS "Bionic Beaver" - Release amd64 (20190210) SourcePackage: macutils UpgradeStatus: No upgrade log present (probably fresh install) ** Patch added: "macutils.debdiff" https://bugs.launchpad.net/ubuntu/focal/+source/macutils/+bug/1892558/+attachment/5760592/+files/macutils.debdiff ** Changed in: macutils (Ubuntu Focal) Status: In Progress => Confirmed ** Changed in: macutils (Ubuntu Focal) Assignee: Sudip Mukherjee (sudipmuk) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892558 Title: [SRU] binhex always segfaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/macutils/+bug/1892558/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
