[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
Hello, I've been busy with school and life - Cinnamon 5.2 is currently WIP in Debian experimental This shouldn't slow anything down significantly. The only slowing that could happen is processing and checking the issue on info change. I can agree that this may not be as important but it shouldn't cause any error. I tested the patch a lot before I finished submitting it to LM and I think it will be fine for Ubuntu. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
** Changed in: cinnamon (Ubuntu Impish) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
is there any risk here that enumerating the users, in environments where a large number of users are visible to the system (AD realms, etc), will cause all user creation to be slow here? I would normally expect either to do a try and then catch whatever exception is raised when trying to create an already-existing user, or else to query for the exact username from the backend to find out whether it exists rather than enumerating. (Basically, one of the two options already listed in https://github.com/linuxmint/cinnamon/issues/9494#issue-667846043.) I see that this is already committed upstream, but I still have reservations about making a change such as this in SRU because of the risk that making a change that fixes behavior when the user has made an uncommon error (conflicting username) could impact all users in certain environments (AD realms) that haven't committed an error. ** Bug watch added: github.com/linuxmint/cinnamon/issues #9494 https://github.com/linuxmint/cinnamon/issues/9494 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
$ dput cinnamon_4.8.6-2ubuntu0.1_source.changes Trying to upload package to ubuntu Checking signature on .changes gpg: /tmp/pkgs/impish/cinnamon_4.8.6-2ubuntu0.1_source.changes: Valid signature from 1E918B66765B3E31 Checking signature on .dsc gpg: /tmp/pkgs/impish/cinnamon_4.8.6-2ubuntu0.1.dsc: Valid signature from 1E918B66765B3E31 Uploading to ubuntu (via ftp to upload.ubuntu.com): Uploading cinnamon_4.8.6-2ubuntu0.1.dsc: done. Uploading cinnamon_4.8.6-2ubuntu0.1.debian.tar.xz: done. Uploading cinnamon_4.8.6-2ubuntu0.1_source.buildinfo: done. Uploading cinnamon_4.8.6-2ubuntu0.1_source.changes: done. Successfully uploaded packages. This now awaiting review by the SRU team. ** Also affects: cinnamon (Ubuntu Impish) Importance: Undecided Status: New ** Changed in: cinnamon (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
I'm not that interested in groovy/hirsute, but feel free to play with it if you *really* wish. ** Patch added: "cinnamon_4.8.6-2ubuntu0.1.debdiff" https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+attachment/5533324/+files/cinnamon_4.8.6-2ubuntu0.1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
** Description changed: - In the user creation dialog if you create a user that already exists (or - try to), a GLib.Error is thrown and the dialog holds. I will make a - patch for this. + [Impact] + + * In the user creation dialog if you create a user that already exists + (or try to), a GLib.Error is thrown and the dialog holds. + + * While of course someone could see a user exists, it's better to maybe + not have someone try to make a user named 'root', 'sudo', 'linux', 'etc' + and watch Python mess up and think they screwed up their system. + + * This patch checks that the user exists when the information changes + and will adjust to not allow the user to be created (while giving a + helpful warning + + [Test Plan] + + * Boot up Cinnamon < 5.0.0 + + * Run cinnamon-settings-users, and enable root if you must + + * Try to create a user, type in a username, your own or another + existing one, and see that when trying to add it the application hangs. + + [Where problems could occur] + + * Nothing too big except the normal fact that we are using Python. + Python breakage to always happen (an update, syntax error, etc.) + + * Another patch that plays with cinnamon-settings, cinnamon-settings- + users, or critically the AccountsService or any part of the library that + is adjusted can mess up things. + + * Regression is unlikely, but still possible due to the world of + Python, and definitely AccountsService in this GTK4/libraries world with + Impish specifically + + [Other Info] + + * Two patches - one to fix and one for translations fixing Affected: Focal - Cinnamon 4.4.8 Impish - Cinnamon 4.8.6 - Jammy - Solved in Debian Unstable - Cinnamon 5.0.5 (Debian #985138) + Jammy - Fixed in the current unstable, 5.0.5. Check Debian #985138 ProblemType: Bug DistroRelease: Ubuntu 20.10 Package: cinnamon 4.6.7-1ubuntu1.1 ProcVersionSignature: Ubuntu 5.8.0-44.50-generic 5.8.18 Uname: Linux 5.8.0-44-generic x86_64 ApportVersion: 2.20.11-0ubuntu50.5 Architecture: amd64 CasperMD5CheckResult: skip CurrentDesktop: ubuntu:GNOME Date: Sat Mar 13 09:14:42 2021 InstallationDate: Installed on 2020-10-23 (141 days ago) InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Release amd64 (20201022) ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR= LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: cinnamon UpgradeStatus: No upgrade log present (probably fresh install) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
** Description changed: In the user creation dialog if you create a user that already exists (or try to), a GLib.Error is thrown and the dialog holds. I will make a patch for this. Affected: Focal - Cinnamon 4.4.8 - Groovy - Cinnamon 4.6.7 - Hirsute - current unstable. Check Debian #985138 + Impish - Cinnamon 4.8.6 + Jammy - Solved in Debian Unstable - Cinnamon 5.0.0 (Debian #985138) ProblemType: Bug DistroRelease: Ubuntu 20.10 Package: cinnamon 4.6.7-1ubuntu1.1 ProcVersionSignature: Ubuntu 5.8.0-44.50-generic 5.8.18 Uname: Linux 5.8.0-44-generic x86_64 ApportVersion: 2.20.11-0ubuntu50.5 Architecture: amd64 CasperMD5CheckResult: skip CurrentDesktop: ubuntu:GNOME Date: Sat Mar 13 09:14:42 2021 InstallationDate: Installed on 2020-10-23 (141 days ago) InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Release amd64 (20201022) ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR= LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: cinnamon UpgradeStatus: No upgrade log present (probably fresh install) ** Description changed: In the user creation dialog if you create a user that already exists (or try to), a GLib.Error is thrown and the dialog holds. I will make a patch for this. Affected: Focal - Cinnamon 4.4.8 Impish - Cinnamon 4.8.6 - Jammy - Solved in Debian Unstable - Cinnamon 5.0.0 (Debian #985138) + Jammy - Solved in Debian Unstable - Cinnamon 5.0.5 (Debian #985138) ProblemType: Bug DistroRelease: Ubuntu 20.10 Package: cinnamon 4.6.7-1ubuntu1.1 ProcVersionSignature: Ubuntu 5.8.0-44.50-generic 5.8.18 Uname: Linux 5.8.0-44-generic x86_64 ApportVersion: 2.20.11-0ubuntu50.5 Architecture: amd64 CasperMD5CheckResult: skip CurrentDesktop: ubuntu:GNOME Date: Sat Mar 13 09:14:42 2021 InstallationDate: Installed on 2020-10-23 (141 days ago) InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Release amd64 (20201022) ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR= LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: cinnamon UpgradeStatus: No upgrade log present (probably fresh install) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
Could you please add SRU information to this bug report? Once that is done I'll be happy to sponsor it! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
** Changed in: cinnamon (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
Groovy patch. The patch file is the same, this is just really an adjusted changelog and patch file name. ** Patch added: "cinnamon_4.6.7-1ubuntu1.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+attachment/5494404/+files/cinnamon_4.6.7-1ubuntu1.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
** Changed in: cinnamon (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
** Also affects: cinnamon (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985138 Importance: Unknown Status: Unknown ** Changed in: cinnamon (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
The attachment "cinnamon_4.4.8-4ubuntu0.3.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
I have a debdiff/patch for this, based on two commits-one is the actual patch and another one is a localization fix. I put them into one if whoever reviews doesn't mind. ** Patch added: "cinnamon_4.4.8-4ubuntu0.3.debdiff" https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+attachment/5494074/+files/cinnamon_4.4.8-4ubuntu0.3.debdiff ** Changed in: cinnamon (Ubuntu) Status: New => Confirmed ** Changed in: cinnamon (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1919026] Re: cinnamon-settings-users: User dialog holds if user creates a user that already exists
For Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985138 ** Description changed: In the user creation dialog if you create a user that already exists (or try to), a GLib.Error is thrown and the dialog holds. I will make a patch for this. Affected: Focal - Cinnamon 4.4.8 Groovy - Cinnamon 4.6.7 - Hirsute - current unstable + Hirsute - current unstable. Check Debian #985138 ProblemType: Bug DistroRelease: Ubuntu 20.10 Package: cinnamon 4.6.7-1ubuntu1.1 ProcVersionSignature: Ubuntu 5.8.0-44.50-generic 5.8.18 Uname: Linux 5.8.0-44-generic x86_64 ApportVersion: 2.20.11-0ubuntu50.5 Architecture: amd64 CasperMD5CheckResult: skip CurrentDesktop: ubuntu:GNOME Date: Sat Mar 13 09:14:42 2021 InstallationDate: Installed on 2020-10-23 (141 days ago) InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Release amd64 (20201022) ProcEnviron: - TERM=xterm-256color - PATH=(custom, no user) - XDG_RUNTIME_DIR= - LANG=en_US.UTF-8 - SHELL=/bin/bash + TERM=xterm-256color + PATH=(custom, no user) + XDG_RUNTIME_DIR= + LANG=en_US.UTF-8 + SHELL=/bin/bash SourcePackage: cinnamon UpgradeStatus: No upgrade log present (probably fresh install) ** Tags added: focal hirsute ** Bug watch added: Debian Bug tracker #985138 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985138 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1919026 Title: cinnamon-settings-users: User dialog holds if user creates a user that already exists To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1919026/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
