[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-29 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-advantage-tools - 32.3~16.04

---
ubuntu-advantage-tools (32.3~16.04) xenial; urgency=medium

  * Backport 32.3 to xenial (LP: #2060732)

ubuntu-advantage-tools (32.3) oracular; urgency=medium

  * d/apparmor: adjust the profiles to account for usr-merge consequences
(LP: #2067319)

ubuntu-advantage-tools (32.2) oracular; urgency=medium

  * d/apparmor: adjust rules for violations found during testing (LP:
#2066929)

ubuntu-advantage-tools (32.1) oracular; urgency=medium

  * d/apparmor: allow access for /etc/os-release on all supported
profiles (LP: #2065573)
  * apport: get path for timer job status from the correct place (LP: #2065616)

ubuntu-advantage-tools (32) oracular; urgency=medium

  * d/postinst: ensure migrations happen in correct package postinst (GH: #2982)
  * d/apparmor: introduce new ubuntu_pro_esm_cache apparmor policy
  * New upstream release 32 (LP: #2060732)
- api:
  + u.pro.attach.token.full_token_attach.v1: add support for attach
with token
  + u.pro.services.disable.v1: add support for disable operation
  + u.pro.services.enable.v1: add support for enable operation
  + u.pro.detach.v1: add support for detach operation
  + u.pro.status.is_attached.v1: add extra fields to API response
  + u.pro.services.dependencies.v1: add support for service dependencies
  + u.pro.security.fix.*.plan.v1: update ESM cache during plan API
if needed
- apt_news: add architectures and packages selectors filters for apt news
- cli:
  + improved cli/log message for unexpected errors (GH: #2600)
  + properly handle setting empty config values (GH: #2925)
- cloud-init: support ubuntu_pro user-data
- collect-logs: update default output file to pro_logs.tar.gz (LP: #2033313)
- config: create public and private config (GH: #2809)
- entitlements:
  + update logic that checks if a service is enabled (LP: #2031192)
- fips: warn/confirm with user if enabling fips downgrades the kernel
- fix: warn users if ESM cache cannot be updated (GH: #2841)
- logging:
  + use journald logging for all systemd services
  + add redundancy to secret redaction
- messaging:
  + add consistent messaging for end of contract state
  + make explicit that unattached enable/disable is a noop (GH: #2487)
  + make explicit that disabling a disabled service is a noop
  + make explicit that enabling an enabled service is a noop
- notices: filter unreadable notices when listing notices (GH: #2898)

 -- Renan Rodrigo   Tue, 28 May 2024
15:15:32 -0300

** Changed in: ubuntu-advantage-tools (Ubuntu Xenial)
   Status: Invalid => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-29 Thread Andreas Hasenack
In comment https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-
tools/+bug/2059952/comments/19 we decided to not release 31.2.3 for
xenial at that time, since the same fix would be included in an upcoming
SRU.

That upcoming SRU has arrived in the form of version 32.3, which I'm
releasing now, including for xenial.

Doing an early release of 32.3 according to point 7 in the plan from
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-
tools/+bug/2067319/comments/1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-29 Thread Andreas Hasenack
I'm changing the xenial tags back to verification-done (from
verification-failed, which I had set in
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-
tools/+bug/2059952/comments/19), because, as was discussed, xenial is
not (yet) affected by this bug. The xenial bug task was already set to
invalid to reflect this.

** Tags removed: verification-failed-xenial
** Tags added: verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-07 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-advantage-tools - 31.2.3~20.04

---
ubuntu-advantage-tools (31.2.3~20.04) focal; urgency=medium

  * Backport new upstream release to focal (LP: #2059952)

ubuntu-advantage-tools (31.2.3) noble; urgency=medium

  * daemon: wait for cloud-init.service to fully activate (LP: #2059952)

 -- Lucas Moura   Fri, 05 Apr 2024 10:08:58
-0300

** Changed in: ubuntu-advantage-tools (Ubuntu Bionic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-07 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-advantage-tools - 31.2.3~18.04

---
ubuntu-advantage-tools (31.2.3~18.04) bionic; urgency=medium

  * Backport new upstream release to bionic (LP: #2059952)

ubuntu-advantage-tools (31.2.3) noble; urgency=medium

  * daemon: wait for cloud-init.service to fully activate (LP: #2059952)

 -- Lucas Moura   Fri, 05 Apr 2024 10:08:53
-0300

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-07 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-advantage-tools - 31.2.3~22.04

---
ubuntu-advantage-tools (31.2.3~22.04) jammy; urgency=medium

  * Backport new upstream release to jammy (LP: #2059952)

ubuntu-advantage-tools (31.2.3) noble; urgency=medium

  * daemon: wait for cloud-init.service to fully activate (LP: #2059952)

 -- Lucas Moura   Fri, 05 Apr 2024 10:09:04
-0300

** Changed in: ubuntu-advantage-tools (Ubuntu Jammy)
   Status: Fix Committed => Fix Released

** Changed in: ubuntu-advantage-tools (Ubuntu Focal)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-07 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-advantage-tools - 31.2.3~23.10

---
ubuntu-advantage-tools (31.2.3~23.10) mantic; urgency=medium

  * Backport new upstream release to mantic (LP: #2059952)

ubuntu-advantage-tools (31.2.3) noble; urgency=medium

  * daemon: wait for cloud-init.service to fully activate (LP: #2059952)

 -- Lucas Moura   Fri, 05 Apr 2024 10:09:10
-0300

** Changed in: ubuntu-advantage-tools (Ubuntu Mantic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-07 Thread Andreas Hasenack
** Tags added: verification-done-mantic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-07 Thread Lucas Albuquerque Medeiros de Moura
I am adding the test results for Mantic. Those tests confirm that the
daemon doesn't run on Mantic, which makes this release unaffected by
this issue.

** Attachment added: "mantic-test-results.tar.xz"
   
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+attachment/5775924/+files/mantic-test-results.tar.xz

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-06 Thread Andreas Hasenack
The versions used for these updates were expecting a mantic update as
well, to have an upgrade path. But we can't release mantic without any
testing whatsoever.

Even if we don't have gcp images for mantic, the right version of cloud-
init is there and available, so we could hit the bug there as well in
other clouds or scenarios.

What testing can we do here for mantic, since we don't have gcp images
for it?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-06 Thread Andreas Hasenack
Thanks for this extra verification.

Since xenial is then not affected by this bug, and there is another
upcoming ubuntu-advantage-tools v32 SRU which, among many other changes,
includes this same fix, let's not release v31.2.3~16.04 into xenial.
This avoids an unnecessary update to xenial users, with no immediate
benefit for them.

cloud-init may at some point in the future be updated for xenial and
then include the mentioned attach logic, and introduce this bug, at
which time we can revisit this bug and verify it's fixed with the
upcoming v32 update of u-a-t.


** Changed in: ubuntu-advantage-tools (Ubuntu Xenial)
   Status: Fix Committed => Invalid

** Tags removed: verification-needed-xenial
** Tags added: verification-failed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-06 Thread Catherine Redfield
I reran the Xenial verification process and found that this proposed
package does not change the behavior; that is, with the proposed
package, pro services are still enable on first boot.  Upon further
investigation, I found that the version of cloud-init in xenial is
21.1-19-gbad84ad4-0ubuntu1~16.04.4 which does not contain the logic to
drive the pro auto-attach process (which is where this bug exists).

The details of the testing I did are shown below:

$ gcloud compute instances create pro-order-bug --image testing-
ubuntu-1604-xenial-v20240417 --image-project ubuntu-catred --metadata-
from-file=user-data=userdata.yaml --zone us-central1-a

catred@pro-order-bug:~$ apt-cache policy ubuntu-pro-client
ubuntu-pro-client:
  Installed: 31.2.3~16.04
  Candidate: 31.2.3~16.04
  Version table:
 *** 31.2.3~16.04 100
100 /var/lib/dpkg/status
 31.2.2~16.04 500
500 http://us-central1.gce.archive.ubuntu.com/ubuntu 
xenial-updates/main amd64 Packages
catred@pro-order-bug:~$ pro status
SERVICE  ENTITLED  STATUS   DESCRIPTION
cc-eal   yes   disabled Common Criteria EAL2 Provisioning 
Packages
cis  yes   disabled Security compliance and audit tools
esm-apps yes   enabled  Expanded Security Maintenance for 
Applications
esm-infrayes   enabled  Expanded Security Maintenance for 
Infrastructure
livepatchyes   warning  Current kernel is not supported

NOTICES
The current kernel (4.15.0-1160-gcp, x86_64) is not supported by livepatch.
Supported kernels are listed here: 
https://ubuntu.com/security/livepatch/docs/kernels
Either switch to a supported kernel or `pro disable livepatch` to dismiss this 
warning.

For a list of all Ubuntu Pro services, run 'pro status --all'
Enable services with: pro enable 

Account: ubuntu-catred
   Subscription: ubuntu-catred
Valid until: Fri Dec 31 00:00:00  UTC
Technical support level: essential
catred@pro-order-bug:~$ sudo apt-cache policy cloud-init
cloud-init:
  Installed: 21.1-19-gbad84ad4-0ubuntu1~16.04.4
  Candidate: 21.1-19-gbad84ad4-0ubuntu1~16.04.4
  Version table:
 *** 21.1-19-gbad84ad4-0ubuntu1~16.04.4 510
510 https://esm.ubuntu.com/infra/ubuntu xenial-infra-security/main 
amd64 Packages
100 /var/lib/dpkg/status
 21.1-19-gbad84ad4-0ubuntu1~16.04.2 500
500 http://us-central1.gce.archive.ubuntu.com/ubuntu 
xenial-updates/main amd64 Packages
 0.7.7~bzr1212-0ubuntu1 500
500 http://us-central1.gce.archive.ubuntu.com/ubuntu xenial/main amd64 
Packages

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-06 Thread Andreas Hasenack
I think the xenial verification at comment #14 was not complete,
because, as we can see in the NOTICES section, the attaching was still
going on, so the output of "pro status" does not yet show if services
were auto-enabled or not, i.e., we don't have the STATUS column in that
output.

** Tags removed: verification-done-xenial
** Tags added: verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-06 Thread Andreas Hasenack
** Tags added: verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-05-02 Thread Catherine Redfield
After some further investigation it seems that this bug does not occur
in AWS (since the available pro image does not include the affected
packages) and testing is not possible in Azure due to their image
registration policies.  Please let me know if the verification can be
approved with solely the GCP results.

** Tags removed: verification-needed verification-needed-bionic
verification-needed-focal verification-needed-jammy verification-needed-
mantic verification-needed-xenial

** Tags added: verification-done-bionic verification-done-focal
verification-done-jammy

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-17 Thread Catherine Redfield
We do not publish GCP pro images for mantic so the bug does occur there,
hence there is no validation for mantic GCP.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-17 Thread Catherine Redfield
Xenial Validation GCP:

$ gcloud compute instances create pro-order-bug --image testing-
ubuntu-1604-xenial-v20240417 --image-project ubuntu-catred --metadata-
from-file=user-data=userdata.yaml --zone us-central1-a

catred@pro-order-bug:~$ apt-cache policy ubuntu-pro-client
ubuntu-pro-client:
  Installed: 31.2.3~16.04
  Candidate: 31.2.3~16.04
  Version table:
 *** 31.2.3~16.04 100
100 /var/lib/dpkg/status
 31.2.2~16.04 500
500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
catred@pro-order-bug:~$ cat /var/log/cloud-init.log | grep 'WARNING'
catred@pro-order-bug:~$ pro status
SERVICE  AVAILABLE  DESCRIPTION
cc-eal   yesCommon Criteria EAL2 Provisioning Packages
cis  yesSecurity compliance and audit tools
esm-apps yesExpanded Security Maintenance for Applications
esm-infrayesExpanded Security Maintenance for Infrastructure
fips yesNIST-certified FIPS crypto packages
fips-updates yesFIPS compliant crypto packages with stable security 
updates
livepatchyesCurrent kernel is not supported
ros  yesSecurity Updates for the Robot Operating System
ros-updates  yesAll Updates for the Robot Operating System
NOTICES
Operation in progress: pro.daemon.attempt_auto_attach

For a list of all Ubuntu Pro services, run 'pro status --all'

This machine is not attached to an Ubuntu Pro subscription.
See https://ubuntu.com/pro

Supported livepatch kernels are listed here:
https://ubuntu.com/security/livepatch/docs/kernels


No warnings from cloud-init; all services are disabled.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-17 Thread Catherine Redfield
Bionic Validation GCP:

$ gcloud compute instances create pro-order-bug --image testing-
ubuntu-1804-bionic-v20240417 --image-project ubuntu-catred --metadata-
from-file=user-data=userdata.yaml --zone us-central1-a

catred@pro-order-bug:~$ apt-cache policy ubuntu-pro-client
ubuntu-pro-client:
  Installed: 31.2.3~18.04
  Candidate: 31.2.3~18.04
  Version table:
 *** 31.2.3~18.04 100
100 /var/lib/dpkg/status
 31.2.2~18.04 500
500 http://us-central1.gce.archive.ubuntu.com/ubuntu 
bionic-updates/main amd64 Packages
catred@pro-order-bug:~$ cat /var/log/cloud-init.log | grep 'WARNING'
catred@pro-order-bug:~$ pro status
SERVICE  ENTITLED  STATUS   DESCRIPTION
cc-eal   yes   disabled Common Criteria EAL2 Provisioning 
Packages
cis  yes   disabled Security compliance and audit tools
esm-apps yes   disabled Expanded Security Maintenance for 
Applications
esm-infrayes   disabled Expanded Security Maintenance for 
Infrastructure
fips yes   disabled NIST-certified FIPS crypto packages
fips-updates yes   disabled FIPS compliant crypto packages with 
stable security updates
livepatchyes   disabled Canonical Livepatch service

For a list of all Ubuntu Pro services, run 'pro status --all'
Enable services with: pro enable 

Account: ubuntu-catred
   Subscription: ubuntu-catred
Valid until: Fri Dec 31 00:00:00  UTC
Technical support level: essential


No warnings from cloud-init; all services are disabled.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-16 Thread Catherine Redfield
Focal Validation GCP:

$ gcloud compute instances create pro-order-bug --image testing-
ubuntu-2004-focal-v20240416 --image-project ubuntu-catred --metadata-
from-file=user-data=userdata.yaml --zone us-central1-a


catred@pro-order-bug:~$ apt-cache policy ubuntu-pro-client
ubuntu-pro-client:
  Installed: 31.2.3~20.04
  Candidate: 31.2.3~20.04
  Version table:
 *** 31.2.3~20.04 100
100 /var/lib/dpkg/status
 31.2.2~20.04 500
500 http://us-central1.gce.archive.ubuntu.com/ubuntu focal-updates/main 
amd64 Packages
catred@pro-order-bug:~$ cat /var/log/cloud-init.log | grep 'WARNING'
catred@pro-order-bug:~$ pro status
SERVICE  ENTITLED  STATUS   DESCRIPTION
anbox-cloud  yes   disabled Scalable Android in the cloud
esm-apps yes   disabled Expanded Security Maintenance for 
Applications
esm-infrayes   disabled Expanded Security Maintenance for 
Infrastructure
fips yes   disabled NIST-certified FIPS crypto packages
fips-updates yes   disabled FIPS compliant crypto packages with 
stable security updates
livepatchyes   disabled Canonical Livepatch service
usg  yes   disabled Security compliance and audit tools

For a list of all Ubuntu Pro services, run 'pro status --all'
Enable services with: pro enable 

Account: ubuntu-catred
   Subscription: ubuntu-catred
Valid until: Fri Dec 31 00:00:00  UTC
Technical support level: essential


No warnings from cloud-init; all services are disabled.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-16 Thread Catherine Redfield
Jammy Validation GCP:

$ gcloud compute instances create pro-order-bug --image testing-
ubuntu-2204-jammy-v20240416 --image-project ubuntu-catred --metadata-
from-file=user-data=userdata.yaml --zone us-central1-a

catred@pro-order-bug:~$ apt-cache policy ubuntu-pro-client
ubuntu-pro-client:
  Installed: 31.2.3~22.04
  Candidate: 31.2.3~22.04
  Version table:
 *** 31.2.3~22.04 100
100 /var/lib/dpkg/status
 31.2.2~22.04 500 (phased 40%)
500 http://us-central1.gce.archive.ubuntu.com/ubuntu jammy-updates/main 
amd64 Packages
catred@pro-order-bug:~$ cat /var/log/cloud-init.log | grep 'WARNING'
catred@pro-order-bug:~$  pro status
SERVICE  ENTITLED  STATUS   DESCRIPTION
anbox-cloud  yes   disabled Scalable Android in the cloud
esm-apps yes   disabled Expanded Security Maintenance for 
Applications
esm-infrayes   disabled Expanded Security Maintenance for 
Infrastructure
fips-preview yes   disabled Preview of FIPS crypto packages 
undergoing certification with NIST
fips-updates yes   disabled FIPS compliant crypto packages with 
stable security updates
livepatchyes   disabled Canonical Livepatch service
usg  yes   disabled Security compliance and audit tools

For a list of all Ubuntu Pro services, run 'pro status --all'
Enable services with: pro enable 

Account: ubuntu-catred
   Subscription: ubuntu-catred
Valid until: Fri Dec 31 00:00:00  UTC
Technical support level: essential


No warnings from cloud-init; all services are disabled.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-16 Thread Catherine Redfield
** Description changed:

  [ Impact ]
  Currently, the Pro client support a daemon named ubuntu-advantage.service that
  performs two actions:
  
  * Actively look for Pro licenses on Azure and GCP images to perform an 
auto-attach
  * Retry auto-attach on Pro images if that command fails on boot
  
  Therefore, this daemon is only being activated on generic Azure and GCP
  images and all Pro cloud images.
  
  This daemon was originally setup to run after the cloud-config.service. 
However,
  due to a race condition, this is no longer happening. Right now, we manually
  check in the daemon code to see if the cloud-config service has finished.
  
  Unfortunately, this new logic now breaks the current Pro setup through
  cloud-init userdata in both GCP and Azure Pro cloud images. That is
  because our daemon is now running before cloud-init has even started
  running. This means that the daemon will perform the attach and not
  cloud-init itself. This will be clearer, in the following example:
  
  Let's imagine this situation where a user is launching a Pro GCP image:
  
  1) User provides the following cloud-init userdata to the cloud image
  before booting it:
  
  #cloud-config
  
  ubuntu_advantage:
    enable: []
  
  This means that the user wants no services to be enabled, but still want
  to attach to the Pro license.
  
  2) Our daemon starts running before cloud-config.service has even started
  3) Our daemon see the cloud-config.service as inactive and proceeds normally
  4) Our daemon identifies that the user is running on a GCP instance and there 
is a valid Pro license for it.
  5) Due to that, our daemon auto-attach the machine completely ignoring the 
cloud-init directives.
  
  Therefore, to fix that issue we need to guarantee that we will only
  execute the daemon, if and only if, cloud-init has already started. That
  is because, on this situation, the cloud-config.service will already
  perform the attach operation following the user directives. When the
  daemon starts running, it will see that the image is already attached
  and do nothing.
  
  Finally, given this scenario, this bug is only affecting GCP/Azure Pro
  images, as these are the only ones that will be able to reach the flow
  described here.
  
  [Discussion]
  
  To address that issue, we are now also checking if the cloud-init service
  has already started if we detect that cloud-config service is inactive. If it 
isn't, the daemon will sleep for an specific amount of time before trying again.
  
  [ Test Plan ]
  Since this is a first boot issue, we will need to create a custom image with 
the package in proposed. Then, we need to guarantee that Pro configuration 
delivered
  through cloud-init is being honored when we launch the image.
  
  Additionally, it is worth noting that we cannot reproduce this issue on
  a VM easily. That is because, we would need "mock" the VM to pass as one
  of the affected clouds and also add a valid Pro license to it.
  
- However, CPC is already aware of this issue and will help us creating
- the test plan here.
+ Build image that pulls pro from -proposed but otherwise follows the
+ standard pro image build hook. Upload and register the image with the
+ cloud for testing.
+ 
+ #Set cloud-init userdata that disables all pro services
+ $ cat userdata.yaml
+ #cloud-config
+ 
+ ubuntu_advantage:
+   enable: []
+ 
+ #Instantiate VM (GCP)
+ $ gcloud compute instances create pro-order-bug-mantic --image [IMAGE_NAME] 
--image-project ubuntu-catred --metadata-from-file=user-data=userdata.yaml 
--zone us-central1-a
+ 
+ #Instantiate VM (Azure)
+ [TODO]
+ 
+ #On VM, validate version of pro and bugfix (services disable, no cloud-init 
warnings in log)
+ $ apt-cache policy ubuntu-pro-client
+ ubuntu-pro-client:
+   Installed: 31.2.3~[RELEASE]
+   Candidate: 31.2.3~[RELEASE]
+ 
+ $ cat /var/log/cloud-init.log | grep 'WARNING'
+ 
+ $ pro status
+ SERVICE  AVAILABLE  DESCRIPTION
+ anbox-cloud  yesScalable Android in the cloud
+ esm-apps yesExpanded Security Maintenance for Applications
+ esm-infrayesExpanded Security Maintenance for Infrastructure
+ landscapeyesManagement and administration tool for Ubuntu
+ livepatchyesCurrent kernel is not supported
+ 
+ For a list of all Ubuntu Pro services, run 'pro status --all'
+ 
+ This machine is not attached to an Ubuntu Pro subscription.
+ See https://ubuntu.com/pro
+ 
+ Supported livepatch kernels are listed here:
+ https://ubuntu.com/security/livepatch/docs/kernels
+ 
+ 
+ If the bug is still present, there will be a WARNING in the cloud-init log 
and pro status will return something similar to:
+ SERVICE  ENTITLED  STATUS   DESCRIPTION
+ anbox-cloud  yes   disabled Scalable Android in the cloud
+ esm-apps yes   enabled  Expanded Security Maintenance for 
Applications
+ esm-infrayes   enabled  Expanded Security 

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-16 Thread Andreas Hasenack
Looks good, but please also include:
- azure run (to at least show it's still working, if you cannot reproduce the 
bug there easily)
- what a test failure looks like, according to this plan

+1 to go ahead and update the bug description's [test plan].

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-16 Thread Catherine Redfield
Test plan details:

Build image that pulls pro from -proposed.  If necessary, I can expand
on the exact bartender command/changes made.  Upload and register the
image with a cloud (GCP will be used for testing since that was where I
first observed the bug and could reliably reproduce).


#Instantiate VM
$ cat userdata.yaml 
#cloud-config

ubuntu_advantage:
  enable: []
$ gcloud compute instances create pro-order-bug-mantic --image [IMAGE_NAME] 
--image-project ubuntu-catred --metadata-from-file=user-data=userdata.yaml 
--zone us-central1-a


#On VM, validate version of pro and bugfix (services disable, no cloud-init 
warnings in log)
$ apt-cache policy ubuntu-pro-client
$ cat /var/log/cloud-init.log | grep 'WARNING'
$ pro status

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-16 Thread Andreas Hasenack
> However, CPC is already aware of this issue and will help us creating
the test plan here.

I understand CPC can hit this bug quite frequently in the affected cloud
images, so releasing this SRU to updates is conditional on an actual
test plan being better described by them, and followed.


** Also affects: ubuntu-advantage-tools (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Bionic)
   Importance: Undecided
   Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Mantic)
   Importance: Undecided
   Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Jammy)
   Importance: Undecided
   Status: New

** Changed in: ubuntu-advantage-tools (Ubuntu Mantic)
   Status: New => Fix Committed

** Tags added: verification-needed verification-needed-mantic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-07 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-advantage-tools - 31.2.3

---
ubuntu-advantage-tools (31.2.3) noble; urgency=medium

  * daemon: wait for cloud-init.service to fully activate (LP: #2059952)

 -- Lucas Moura   Tue, 02 Apr 2024 10:13:32
-0300

** Changed in: ubuntu-advantage-tools (Ubuntu)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-05 Thread Andreas Hasenack
** Description changed:

  [ Impact ]
  Currently, the Pro client support a daemon named ubuntu-advantage.service that
  performs two actions:
  
  * Actively look for Pro licenses on Azure and GCP images to perform an 
auto-attach
  * Retry auto-attach on Pro images if that command fails on boot
  
  Therefore, this daemon is only being activated on generic Azure and GCP
  images and all Pro cloud images.
  
  This daemon was originally setup to run after the cloud-config.service. 
However,
  due to a race condition, this is no longer happening. Right now, we manually
  check in the daemon code to see if the cloud-config service has finished.
  
  Unfortunately, this new logic now breaks the current Pro setup through
  cloud-init userdata in both GCP and Azure Pro cloud images. That is
  because our daemon is now running before cloud-init has even started
  running. This means that the daemon will perform the attach and not
  cloud-init itself. This will be clearer, in the following example:
  
  Let's imagine this situation where a user is launching a Pro GCP image:
  
  1) User provides the following cloud-init userdata to the cloud image
  before booting it:
  
  #cloud-config
  
  ubuntu_advantage:
    enable: []
  
  This means that the user wants no services to be enabled, but still want
  to attach to the Pro license.
  
- 2) Our daemon starts running before cloud-init has even started
+ 2) Our daemon starts running before cloud-config has even started
  3) Our daemon see the cloud-config.service as inactive and proceeds normally
  4) Our daemon identifies that the user is running on a GCP instance and there 
is a valid Pro license for it.
  5) Due to that, our daemon auto-attach the machine completely ignoring the 
cloud-init directives.
  
  Therefore, to fix that issue we need to guarantee that we will only
  execute the daemon, if and only if, cloud-init has already started. That
  is because, on this situation, the cloud-config.service will already
  perform the attach operation following the user directives. When the
  daemon starts running, it will see that the image is already attached
  and do nothing.
  
  Finally, given this scenario, this bug is only affecting GCP/Azure Pro
  images, as these are the only ones that will be able to reach the flow
  described here.
  
  [Discussion]
  
  To address that issue, we are now also checking if the cloud-init service
  has already started if we detect that cloud-config service is inactive. If it 
isn't, the daemon will sleep for an specific amount of time before trying again.
  
  [ Test Plan ]
  Since this is a first boot issue, we will need to create a custom image with 
the package in proposed. Then, we need to guarantee that Pro configuration 
delivered
  through cloud-init is being honored when we launch the image.
  
  Additionally, it is worth noting that we cannot reproduce this issue on
  a VM easily. That is because, we would need "mock" the VM to pass as one
  of the affected clouds and also add a valid Pro license to it.
  
  However, CPC is already aware of this issue and will help us creating
  the test plan here.
  
  [ Where problems could occur ]
  We are updating the cloud-init wait logic on the daemon. This could 
potentially make our daemon to not start. However, since we are just now 
waiting on the base cloud-init.service to start and we have already tested this 
solution in a custom image, we believe this is a low risk for this fix.
  
  [ Original Description ]
  We have recently updated the Pro to not strictly run after 
cloud-config.service. If cloud-config.service has not been started when pro 
runs, it can complete before cloud-config.service begins and thus the 
user-specificed pro configuration will be ignored since the instance is already 
attached.
  
  When cloud-config.service has yet to run, ubuntu-advantage.service
  should wait until it's finished before running.

** Description changed:

  [ Impact ]
  Currently, the Pro client support a daemon named ubuntu-advantage.service that
  performs two actions:
  
  * Actively look for Pro licenses on Azure and GCP images to perform an 
auto-attach
  * Retry auto-attach on Pro images if that command fails on boot
  
  Therefore, this daemon is only being activated on generic Azure and GCP
  images and all Pro cloud images.
  
  This daemon was originally setup to run after the cloud-config.service. 
However,
  due to a race condition, this is no longer happening. Right now, we manually
  check in the daemon code to see if the cloud-config service has finished.
  
  Unfortunately, this new logic now breaks the current Pro setup through
  cloud-init userdata in both GCP and Azure Pro cloud images. That is
  because our daemon is now running before cloud-init has even started
  running. This means that the daemon will perform the attach and not
  cloud-init itself. This will be clearer, in the following example:
  
  Let's imagine this situation where a user is 

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-03 Thread Renan Rodrigo
** Changed in: ubuntu-advantage-tools (Ubuntu)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-02 Thread Lucas Albuquerque Medeiros de Moura
** Description changed:

  [ Impact ]
  Currently, the Pro client support a daemon named ubuntu-advantage.service that
  performs two actions:
  
  * Actively look for Pro licenses on Azure and GCP images to perform an 
auto-attach
  * Retry auto-attach on Pro images if that command fails on boot
  
- Therefore, this daemon is only being activated on Azure and GCP images
- and all Pro cloud images.
+ Therefore, this daemon is only being activated on generic Azure and GCP
+ images and all Pro cloud images.
  
  This daemon was originally setup to run after the cloud-config.service. 
However,
  due to a race condition, this is no longer happening. Right now, we manually
  check in the daemon code to see if the cloud-config service has finished.
  
  Unfortunately, this new logic now breaks the current Pro setup through
  cloud-init userdata in both GCP and Azure Pro cloud images. That is
  because our daemon is now running before cloud-init has even started
  running. This means that the daemon will perform the attach and not
  cloud-init itself. This will be clearer, in the following example:
  
  Let's imagine this situation where a user is launching a Pro GCP image:
  
  1) User provides the following cloud-init userdata to the cloud image
  before booting it:
  
  #cloud-config
  
  ubuntu_advantage:
    enable: []
  
  This means that the user wants no services to be enabled, but still want
  to attach to the Pro license.
  
  2) Our daemon starts running before cloud-init has even started
  3) Our daemon see the cloud-config.service as inactive and proceeds normally
  4) Our daemon identifies that the user is running on a GCP instance and there 
is a valid Pro license for it.
  5) Due to that, our daemon auto-attach the machine completely ignoring the 
cloud-init directives.
  
  Therefore, to fix that issue we need to guarantee that we will only
  execute the daemon, if and only if, cloud-init has already started. That
  is because, on this situation, the cloud-config.service will already
  perform the attach operation following the user directives. When the
  daemon starts running, it will see that the image is already attached
  and do nothing.
  
  Finally, given this scenario, this bug is only affecting GCP/Azure Pro
  images, as these are the only ones that will be able to reach the flow
  described here.
  
  [Discussion]
  
  To address that issue, we are now also checking if the cloud-init service
  has already started if we detect that cloud-config service is inactive. If it 
isn't, the daemon will sleep for an specific amount of time before trying again.
  
  [ Test Plan ]
  Since this is a first boot issue, we will need to create a custom image with 
the package in proposed. Then, we need to guarantee that Pro configuration 
delivered
  through cloud-init is being honored when we launch the image.
  
  Additionally, it is worth noting that we cannot reproduce this issue on
  a VM easily. That is because, we would need "mock" the VM to pass as one
  of the affected clouds and also add a valid Pro license to it.
  
  However, CPC is already aware of this issue and will help us creating
  the test plan here.
  
  [ Where problems could occur ]
  We are updating the cloud-init wait logic on the daemon. This could 
potentially make our daemon to not start. However, since we are just now 
waiting on the base cloud-init.service to start and we have already tested this 
solution in a custom image, we believe this is a low risk for this fix.
  
  [ Original Description ]
  We have recently updated the Pro to not strictly run after 
cloud-config.service. If cloud-config.service has not been started when pro 
runs, it can complete before cloud-config.service begins and thus the 
user-specificed pro configuration will be ignored since the instance is already 
attached.
  
  When cloud-config.service has yet to run, ubuntu-advantage.service
  should wait until it's finished before running.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-02 Thread Lucas Albuquerque Medeiros de Moura
** Description changed:

  [ Impact ]
  Currently, the Pro client support a daemon named ubuntu-advantage.service that
  performs two actions:
  
  * Actively look for Pro licenses on Azure and GCP images to perform an 
auto-attach
  * Retry auto-attach on Pro images if that command fails on boot
  
  Therefore, this daemon is only being activated on Azure and GCP images
  and all Pro cloud images.
  
  This daemon was originally setup to run after the cloud-config.service. 
However,
  due to a race condition, this is no longer happening. Right now, we manually
  check in the daemon code to see if the cloud-config service has finished.
  
  Unfortunately, this new logic now breaks the current Pro setup through
  cloud-init userdata in both GCP and Azure Pro cloud images. That is
  because our daemon is now running before cloud-init has even started
  running. This means that the daemon will perform the attach and not
  cloud-init itself. This will be clearer, in the following example:
  
  Let's imagine this situation where a user is launching a Pro GCP image:
  
  1) User provides the following cloud-init userdata to the cloud image
  before booting it:
  
  #cloud-config
  
  ubuntu_advantage:
-   enable: []
+   enable: []
  
- This means that the user wants to services to be enabled, but still want
+ This means that the user wants no services to be enabled, but still want
  to attach to the Pro license.
  
  2) Our daemon starts running before cloud-init has even started
  3) Our daemon see the cloud-config.service as inactive and proceeds normally
  4) Our daemon identifies that the user is running on a GCP instance and there 
is a valid Pro license for it.
  5) Due to that, our daemon auto-attach the machine completely ignoring the 
cloud-init directives.
  
  Therefore, to fix that issue we need to guarantee that we will only
  execute the daemon, if and only if, cloud-init has already started. That
  is because, on this situation, the cloud-config.service will already
  perform the attach operation following the user directives. When the
  daemon starts running, it will see that the image is already attached
  and do nothing.
  
  Finally, given this scenario, this bug is only affecting GCP/Azure Pro
  images, as these are the only ones that will be able to reach the flow
  described here.
  
  [Discussion]
  
  To address that issue, we are now also checking if the cloud-init service
  has already started if we detect that cloud-config service is inactive. If it 
isn't, the daemon will sleep for an specific amount of time before trying again.
  
  [ Test Plan ]
  Since this is a first boot issue, we will need to create a custom image with 
the package in proposed. Then, we need to guarantee that Pro configuration 
delivered
  through cloud-init is being honored when we launch the image.
  
  Additionally, it is worth noting that we cannot reproduce this issue on
  a VM easily. That is because, we would need "mock" the VM to pass as one
  of the affected clouds and also add a valid Pro license to it.
  
  However, CPC is already aware of this issue and will help us creating
  the test plan here.
  
  [ Where problems could occur ]
  We are updating the cloud-init wait logic on the daemon. This could 
potentially make our daemon to not start. However, since we are just now 
waiting on the base cloud-init.service to start and we have already tested this 
solution in a custom image, we believe this is a low risk for this fix.
  
  [ Original Description ]
  We have recently updated the Pro to not strictly run after 
cloud-config.service. If cloud-config.service has not been started when pro 
runs, it can complete before cloud-config.service begins and thus the 
user-specificed pro configuration will be ignored since the instance is already 
attached.
  
  When cloud-config.service has yet to run, ubuntu-advantage.service
  should wait until it's finished before running.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-02 Thread Lucas Albuquerque Medeiros de Moura
** Description changed:

  [ Impact ]
- If the user has specified custom setup for the Pro client through cloud-init, 
there is a high chance that this setup will be ignored.
+ Currently, the Pro client support a daemon named ubuntu-advantage.service that
+ performs two actions:
  
- This happened due to a recent change made on the Pro client. We
- identified a race condition when our daemon waited for the cloud-config
- service to be finished. We have removed that condition, by manually
- checking the cloud-config service state in the daemon itself and only
- proceeding if it has already finished.
+ * Actively look for Pro licenses on Azure and GCP images to perform an 
auto-attach
+ * Retry auto-attach on Pro images if that command fails on boot
  
- However, there is a situation where the cloud-init service has not even
- started yet, which would generate a inactive state for the cloud-config
- service, allowing our daemon to proceed, causing the problem.
+ Therefore, this daemon is only being activated on Azure and GCP images
+ and all Pro cloud images.
+ 
+ This daemon was originally setup to run after the cloud-config.service. 
However,
+ due to a race condition, this is no longer happening. Right now, we manually
+ check in the daemon code to see if the cloud-config service has finished.
+ 
+ Unfortunately, this new logic now breaks the current Pro setup through
+ cloud-init userdata in both GCP and Azure Pro cloud images. That is
+ because our daemon is now running before cloud-init has even started
+ running. This means that the daemon will perform the attach and not
+ cloud-init itself. This will be clearer, in the following example:
+ 
+ Let's imagine this situation where a user is launching a Pro GCP image:
+ 
+ 1) User provides the following cloud-init userdata to the cloud image
+ before booting it:
+ 
+ #cloud-config
+ 
+ ubuntu_advantage:
+   enable: []
+ 
+ This means that the user wants to services to be enabled, but still want
+ to attach to the Pro license.
+ 
+ 2) Our daemon starts running before cloud-init has even started
+ 3) Our daemon see the cloud-config.service as inactive and proceeds normally
+ 4) Our daemon identifies that the user is running on a GCP instance and there 
is a valid Pro license for it.
+ 5) Due to that, our daemon auto-attach the machine completely ignoring the 
cloud-init directives.
+ 
+ Therefore, to fix that issue we need to guarantee that we will only
+ execute the daemon, if and only if, cloud-init has already started. That
+ is because, on this situation, the cloud-config.service will already
+ perform the attach operation following the user directives. When the
+ daemon starts running, it will see that the image is already attached
+ and do nothing.
+ 
+ Finally, given this scenario, this bug is only affecting GCP/Azure Pro
+ images, as these are the only ones that will be able to reach the flow
+ described here.
  
  [Discussion]
  
  To address that issue, we are now also checking if the cloud-init service
  has already started if we detect that cloud-config service is inactive. If it 
isn't, the daemon will sleep for an specific amount of time before trying again.
  
  [ Test Plan ]
  Since this is a first boot issue, we will need to create a custom image with 
the package in proposed. Then, we need to guarantee that Pro configuration 
delivered
  through cloud-init is being honored when we launch the image.
  
- CPC is already aware of this issue and will help us creating the test
- plan here.
+ Additionally, it is worth noting that we cannot reproduce this issue on
+ a VM easily. That is because, we would need "mock" the VM to pass as one
+ of the affected clouds and also add a valid Pro license to it.
+ 
+ However, CPC is already aware of this issue and will help us creating
+ the test plan here.
  
  [ Where problems could occur ]
  We are updating the cloud-init wait logic on the daemon. This could 
potentially make our daemon to not start. However, since we are just now 
waiting on the base cloud-init.service to start and we have already tested this 
solution in a custom image, we believe this is a low risk for this fix.
  
  [ Original Description ]
  We have recently updated the Pro to not strictly run after 
cloud-config.service. If cloud-config.service has not been started when pro 
runs, it can complete before cloud-config.service begins and thus the 
user-specificed pro configuration will be ignored since the instance is already 
attached.
  
  When cloud-config.service has yet to run, ubuntu-advantage.service
  should wait until it's finished before running.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-02 Thread Launchpad Bug Tracker
** Merge proposal linked:
   
https://code.launchpad.net/~lamoura/ubuntu/+source/ubuntu-advantage-tools/+git/ubuntu-advantage-tools/+merge/463510

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 2059952] Re: pro sometimes runs before cloud-config.service

2024-04-02 Thread Lucas Albuquerque Medeiros de Moura
** Description changed:

- We have recently updated the Pro to not strictly run after cloud-
- config.service. If cloud-config.service has not been started when pro
- runs, it can complete before cloud-config.service begins and thus the
- user-specificed pro configuration will be ignored since the instance is
- already attached.
+ [ Impact ]
+ If the user has specified custom setup for the Pro client through cloud-init, 
there is a high chance that this setup will be ignored.
+ 
+ This happened due to a recent change made on the Pro client. We
+ identified a race condition when our daemon waited for the cloud-config
+ service to be finished. We have removed that condition, by manually
+ checking the cloud-config service state in the daemon itself and only
+ proceeding if it has already finished.
+ 
+ However, there is a situation where the cloud-init service has not even
+ started yet, which would generate a inactive state for the cloud-config
+ service, allowing our daemon to proceed, causing the problem.
+ 
+ [Discussion]
+ 
+ To address that issue, we are now also checking if the cloud-init service
+ has already started if we detect that cloud-config service is inactive. If it 
isn't, the daemon will sleep for an specific amount of time before trying again.
+ 
+ [ Test Plan ]
+ Since this is a first boot issue, we will need to create a custom image with 
the package in proposed. Then, we need to guarantee that Pro configuration 
delivered
+ through cloud-init is being honored when we launch the image.
+ 
+ CPC is already aware of this issue and will help us creating the test
+ plan here.
+ 
+ [ Where problems could occur ]
+ We are updating the cloud-init wait logic on the daemon. This could 
potentially make our daemon to not start. However, since we are just now 
waiting on the base cloud-init.service to start and we have already tested this 
solution in a custom image, we believe this is a low risk for this fix.
+ 
+ [ Original Description ]
+ We have recently updated the Pro to not strictly run after 
cloud-config.service. If cloud-config.service has not been started when pro 
runs, it can complete before cloud-config.service begins and thus the 
user-specificed pro configuration will be ignored since the instance is already 
attached.
  
  When cloud-config.service has yet to run, ubuntu-advantage.service
  should wait until it's finished before running.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059952

Title:
  pro sometimes runs before cloud-config.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2059952/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs