[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
** Changed in: eject (Debian) Status: Unknown = Fix Released -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
** Bug watch added: Debian Bug tracker #504480 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504480 ** Also affects: eject (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504480 Importance: Unknown Status: Unknown -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
This bug was fixed in the package eject - 2.1.5-9ubuntu2 --- eject (2.1.5-9ubuntu2) intrepid; urgency=low * eject.c: Resolve symbolic links when reading CD-ROM names, to fix eject -X and possibly other modes. Thanks to Adam Buchbinder for the patch! (Patch submitted upstream via email) LP: #264071 -- Martin Pitt [EMAIL PROTECTED] Mon, 29 Sep 2008 08:20:46 +0200 ** Changed in: eject (Ubuntu) Status: Fix Committed = Fix Released -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
Uploaded, now waiting in unapproved queue (will get into intrepid after the beta freeze). Thank you! ** Changed in: eject (Ubuntu) Status: Confirmed = Fix Committed -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
Thanks, Adam. Some more comments: - ah, so SymLink() already uses and returns realpath(), so the loop is unnecessary. You'll always get the fully canonicalized file name as a result. This will make the code quite a bit easier. - This line full_str_name[strlen(full_str_name)-1] = '\0'; // chop trailing \n looks fishy. asprintf() does not silently append a line break, so it looks like you'd chop off the last real character? IMHO this like should just go. - Indeed you are right wrt. existing code style, the asprintf() configure.in check addition is a bit ugly. But don't worry too much about it, for an Ubuntu patch that's fine. Thanks for sending it upstream, if they know about it, they can change the patch to whichever style they prefer. Thank you! -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
The full_str_name[strlen(full_str_name)-1] = '\0'; // chop trailing \n is there because str_name was returned with a trailing \n; that is, it looks something like sr0\n when it should read sr0. ** Changed in: eject (Ubuntu) Status: Incomplete = Confirmed -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
Some issues: - why does the patch move around the Symlink() function? That's confusing and unnecessary IMHO. If you need it earlier, maybe just add a prototype? - calloc/strcat/strcat could be replaced with a single asprintf() to improve readability and robustness - resolving symlinks should be done with realpath(3), instead of doing a loop all by yourself - can you please report this to upstream? ** Changed in: eject (Ubuntu) Status: Confirmed = Incomplete -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
Updated patch: moved SymLink() back to where it was; added a prototype before the first function that uses it. Used asprintf() instead of calloc/strcat/strcat, and added a configure check for that function. I used a loop to resolve symlinks because that's what the source does in main(), and I figured I'd use the patterns that the original coder used elsewhere. (SymLink() itself does call realpath().) I wanted to change the existing code style as little as possible. I've already forwarded this (via email; there's no active upstream bugtracker) along with the initial version of the patch. I'm attaching the revised patch, and I'll also send it upstream. Thanks for the review, and please let me know if you have any other updates or suggestions. ** Attachment added: Revised patch, per Martin Pitt's advice. http://launchpadlibrarian.net/17883393/eject-264071-v2.diff -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
** Changed in: eject (Ubuntu) Status: New = Confirmed -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
Debdiff with Adam's patch applied. Could someone in u-m-s look? ** Attachment added: eject.debdiff http://launchpadlibrarian.net/17297946/eject.debdiff -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
** Attachment added: Contents of /proc/sys/dev/cdrom/info. http://launchpadlibrarian.net/17245652/proc-sys-dev-cdrom-info -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
Attached find a patch to the original sources which will follow symlinks from the 'device name' line in /proc/sys/dev/cdrom/info. It assumes that device names listed in the 'drive name' section of /proc/sys/dev/cdrom/info exist in /dev. If this is wrong, then this patch will break portability somewhere. This allows the -X option to once again work on the current kernel in Hardy. ** Attachment added: Patch to follow symlinks from /proc/sys/dev/cdrom/info. http://launchpadlibrarian.net/17247601/eject-264071.diff -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 264071] Re: eject -X reports error while finding CD-ROM name.
** Bug watch added: Email to [EMAIL PROTECTED] # mailto:[EMAIL PROTECTED] ** Also affects: eject via mailto:[EMAIL PROTECTED] Importance: Undecided Status: New -- eject -X reports error while finding CD-ROM name. https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
