Re: Epiphany 3.10 landed sans title bar
On 23/12/13 09:53, Marco Trevisan wrote: > What about patching gtk itself so that GtkHeaderBar is rendered in a > different way here? A number of apps (epiphany, nautilus etc) in 3.10 weren't fully ported to GtkHeaderBar, ie they are adding their own close button etc. I don't think upstream will take patches for these since they will be ported to GtkHeaderBar for 3.12. For the rest it makes sense to patch gtk, and I suspect upstream will take these patches. I will look into it and file an upstream bug. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Epiphany 3.10 landed sans title bar
On 12/22/2013 11:53 PM, Marco Trevisan wrote: > What about patching gtk itself so that GtkHeaderBar is rendered in a > different way here? I've only read the API, so I'm not familiar with the > actual code, but wouldn't be possible to find a generic way to hide the > close, title and subtitle elements (and handling in a different way the > other eventual packed elements) in ubuntu desktop for the other apps > that aren't in archives (i.e. I guess people will provide PPAs for some > gnome apps in next months/years, it would be nice to handle these in a > more native way)? That sounds like a very good idea. Such a patch may even be upstreamed as this would be useful for other platforms (OSX, Windows..) too. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Epiphany 3.10 landed sans title bar
On dom, 2013-12-22 at 21:03 +0400, Dmitry Shachnev wrote: > On Sun, Dec 22, 2013 at 7:26 PM, Adam Dingle wrote: > > I assume that this title bar patch is the first of many to come - I imagine > > you'll need a similar patch for every single GNOME application. > > I think we should add GtkHeaderBar support to ubuntu-themes (i.e. set > the correct gradient and move close button to the left), and patch > only apps that are part of standard Ubuntu desktop install. What about patching gtk itself so that GtkHeaderBar is rendered in a different way here? I've only read the API, so I'm not familiar with the actual code, but wouldn't be possible to find a generic way to hide the close, title and subtitle elements (and handling in a different way the other eventual packed elements) in ubuntu desktop for the other apps that aren't in archives (i.e. I guess people will provide PPAs for some gnome apps in next months/years, it would be nice to handle these in a more native way)? -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Pipelight in 14.04LTS?
On 12/22/2013 08:49 PM, Scott Ritchie wrote: > Pipelight has been working with upstream Wine to get their patches > there. But they won't be in a stable release till wine1.8, which will > be some years from now. > > In the meantime the PPA actually works by bundling a second, modified > version of Wine only used by pipelight and installed in /opt. This is > similar to how ported games that embed Wine work. This is good design > as it prevents underlying changes to the system wine (such as a user > following the Wine PPA) from breaking pipelight, and also a necessary > design as it has to hold their pipelight-specific patches. > > A distro package would use a similar approach (although perhaps moving > the wine-compholio from /opt to /usr/lib/wine-compholio), and then > when wine1.8 is released we can evaluate having it just depend on > system wine. You're right. I just remember that some people object to packaging two versions of the same library. I personally would prefer if the patches were upstreamed and Ubuntu would add a wine1.7/wine-unstable package like in the wine PPA. That way also people who want the latest wine would benefit from this. However, I guess we are running out of time to do this until feature freeze. -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Pipelight in 14.04LTS?
Pipelight has been working with upstream Wine to get their patches there. But they won't be in a stable release till wine1.8, which will be some years from now. In the meantime the PPA actually works by bundling a second, modified version of Wine only used by pipelight and installed in /opt. This is similar to how ported games that embed Wine work. This is good design as it prevents underlying changes to the system wine (such as a user following the Wine PPA) from breaking pipelight, and also a necessary design as it has to hold their pipelight-specific patches. A distro package would use a similar approach (although perhaps moving the wine-compholio from /opt to /usr/lib/wine-compholio), and then when wine1.8 is released we can evaluate having it just depend on system wine. On Sat, Dec 21, 2013 at 5:38 PM, Jo-Erlend Schinstad wrote: > That is a valid point, Pipelight depending on a patched version of Wine. I > hadn't actually considered that when I wrote the original email. > > So I guess that'd be the challenge if anyone was up for it. I still don't > understand why it would have to block anything, though, if it enables you to > do stuff on its own. There would be no real-life competition between > compholio and upstream wine. It should be possible to have both if that's > necessary in order to accomplish something major. And I think Pipelight does > exactly that. > > > On 21 December 2013 22:26, Bryan Quigley wrote: >> >> It definitely needs a good number of patches.. They are working to get >> them upstream though: >> http://fds-team.de/cms/pipelight-compile-wine.html >> http://www.compholio.com/wine-compholio/ >> >> https://bazaar.launchpad.net/~pipelight/netflix-desktop/wine-compholio/files/head:/patches/ >> >> I have not investigated which page is the most up-to-date I'm pretty >> sure they would be open to help upstreaming some of their patches... >> >> Stable branch does not appear to be an option for this number of patches. >> >> Thanks, >> Bryan >> >> >> On Sat, Dec 21, 2013 at 10:40 AM, Kai Mast wrote: >>> >>> On 12/21/2013 04:09 PM, Jo-Erlend Schinstad wrote: >>> > I've used Pipelight for some time now, and I've found it to be one of >>> > the most valuable new packages I've come across this year. It enables >>> > the use of the Silverlight plugin in native Ubuntu browsers. >>> > >>> > In my opinion, if this plugin could be made easily available in >>> > 14.04LTS without adding a PPA and so forth, I think this could be >>> > considered a killer-feature in 14.04LTS. >>> > >>> > Has this been up to discussion at all? What are the chances it'll make >>> > it into official repositories in time? >>> >>> Hi, >>> >>> if I see this correctly Pipelight depends on a patched version of Wine. >>> Will these patches be upstreamed at some point? >>> The compholio PPA also seems to build wine 1.7. Does it also work with >>> the stable branch? >>> >>> Thanks, >>> Kai >>> >>> -- >>> ubuntu-desktop mailing list >>> ubuntu-desktop@lists.ubuntu.com >>> https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop >> >> >> >> -- >> ubuntu-desktop mailing list >> ubuntu-desktop@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop >> > > > -- > ubuntu-desktop mailing list > ubuntu-desktop@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop > -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Epiphany 3.10 landed sans title bar
On Sun, Dec 22, 2013 at 11:03 AM, Dmitry Shachnev wrote: > I think we should add GtkHeaderBar support to ubuntu-themes (i.e. set > the correct gradient and move close button to the left), and patch > only apps that are part of standard Ubuntu desktop install. And what about Compiz/Unity? Do CSD apps behave well? (i.e. they integrate window buttons to Unity’s panel when maximized, etc.? -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Epiphany 3.10 landed sans title bar
On Sun, Dec 22, 2013 at 7:26 PM, Adam Dingle wrote: > I assume that this title bar patch is the first of many to come - I imagine > you'll need a similar patch for every single GNOME application. I think we should add GtkHeaderBar support to ubuntu-themes (i.e. set the correct gradient and move close button to the left), and patch only apps that are part of standard Ubuntu desktop install. -- Dmitry Shachnev -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
Re: Epiphany 3.10 landed sans title bar
On Sat, Dec 21, 2013 at 7:47 PM, Tim wrote: On 22/12/13 10:36, Tim wrote: On 22/12/13 08:51, Iain Lane wrote: Indeed, we shouldn't be uploading GtkHeaderBar-using software into the archive without fixing it to use traditional menus when appropriate. https://wiki.gnome.org/HowDoI/AlternateMenubarLayout I hope someone from Ubuntu GNOME is going to look into this for ephy. & sorry—I did hear about this update before it was uploaded, but didn't think to check if it used the header bar. I don't think the menus have changed since the last release? So really its just the missing titlebar and close button that are the issue? Have added a patch that brings back the traditional titlebar and hides the CSD close button for non-GNOME sessions. I believe this should be equivalent to how it was in the previous release. Thanks for the quick fix! This makes Epiphany look much better, though I've noticed one bug where launching the app sometimes opens multiple windows: https://bugs.launchpad.net/ubuntu/+source/epiphany-browser/+bug/1263495 I assume that this title bar patch is the first of many to come - I imagine you'll need a similar patch for every single GNOME application. Do you think you'll be able to upstream these? adam -- ubuntu-desktop mailing list ubuntu-desktop@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-desktop
