Re: Adding logo images to base-files?
Hey again, I went ahead and uploaded the basic change initially suggested. I think it could make sense to allow flavors to divert os-release and tweak the content according to what they want to define but it shouldn't block us doing the first step. Cheers, Sebastien Bacher Le 14/06/2022 à 15:06, Sebastien Bacher a écrit : Hey, Le 14/06/2022 à 02:09, Erich Eickmeyer a écrit : Just chiming-in here from a Flavor Lead perspective. It seems like this could be something that could be implemented via update-alternatives, similar to how plymouth themes and distributor-logo and are controlled. How are flavor handling /etc/os-release today? LOGO isn't the only thing there they might want to set differently from Ubuntu (pretty_name, support_url, bug_report_url are other examples). Using alternatives for the logo here sounds like the wrong solution, it's the os-release that should be diverted instead. Cheers, Sebastien Bacher -- ubuntu-devel mailing list ubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
Re: Adding logo images to base-files?
On Tuesday, June 14, 2022 6:06:21 AM PDT Sebastien Bacher wrote: > Le 14/06/2022 à 02:09, Erich Eickmeyer a écrit : > >> Just chiming-in here from a Flavor Lead perspective. It seems like this > >> could be something that could be implemented via update-alternatives, > >> similar to how plymouth themes and distributor-logo and are controlled. > > How are flavor handling /etc/os-release today? LOGO isn't the only thing > there they might want to set differently from Ubuntu (pretty_name, > support_url, bug_report_url are other examples). > Currently, we're not, and I for one am OK with it. As far as I am concerned, the OS *should* be reporting itself as Ubuntu since it *is* Ubuntu. We're not trying to disguise ourselves as a different distro, but as a different out-of- the-box configuration of said distro. In Studio, we don't try to hide that as much as other flavors might. That said, I don't know of a single flavor that does change-out /etc/os-release. -- Erich Eickmeyer Project Leader - Ubuntu Studio Member - Ubuntu Community Council signature.asc Description: This is a digitally signed message part. -- ubuntu-devel mailing list ubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
Re: Adding logo images to base-files?
Hey, Le 14/06/2022 à 02:09, Erich Eickmeyer a écrit : Just chiming-in here from a Flavor Lead perspective. It seems like this could be something that could be implemented via update-alternatives, similar to how plymouth themes and distributor-logo and are controlled. How are flavor handling /etc/os-release today? LOGO isn't the only thing there they might want to set differently from Ubuntu (pretty_name, support_url, bug_report_url are other examples). Using alternatives for the logo here sounds like the wrong solution, it's the os-release that should be diverted instead. Cheers, Sebastien Bacher -- ubuntu-devel mailing list ubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
Re: Adding logo images to base-files?
On Monday, June 13, 2022 5:08:37 PM PDT Erich Eickmeyer wrote: > On Monday, June 13, 2022 4:44:04 PM PDT Steve Langasek wrote: > > Hi Seb, > > > > On Mon, Jun 13, 2022 at 09:44:30PM +0200, Sebastien Bacher wrote: > > > Hey there, > > > > > > I'm trying to see how we can fix https://launchpad.net/bugs/1931582 in > > > Ubuntu, which is about adding a LOGO= entry to os-release. > > > > > > I think it somewhat would make sense to provide the logos (plural > > > because > > > following > > > https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/985 > > > it > > > makes sense to have -text/-dark/text-dark variants.) in the same package > > > as > > > the key is defined? > > > > > > Checking the current logo images it would be ~15kB of svg (or maybe png) > > > files added to the package. > > > > > > Would that sound something reasonable? > > > > This seems ok in terms of the impact on the size of the base system (i.e. > > negligible), but I wonder about the interfaces here. Flavors have their > > own individual logos, which they use for plymouth/grub themes for > > example. If we add LOGO to /etc/os-release, do we have to worry about > > other upstreams picking this up and using it in other contexts where it's > > less appropriate, because we want flavors to be able to customize > > appearance independently of base-files? > > Just chiming-in here from a Flavor Lead perspective. It seems like this > could be something that could be implemented via update-alternatives, > similar to how plymouth themes and distributor-logo and are controlled. > > In fact, there are multiple ways alternatives could be used by flavors with > simple alternatives registrations, if only they were utilized. > > Just my two pennies. :) Heh, meant that to go to the ML. -- Erich Eickmeyer Project Leader - Ubuntu Studio Member - Ubuntu Community Council signature.asc Description: This is a digitally signed message part. -- ubuntu-devel mailing list ubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
Re: Adding logo images to base-files?
Hi Seb, On Mon, Jun 13, 2022 at 09:44:30PM +0200, Sebastien Bacher wrote: > Hey there, > I'm trying to see how we can fix https://launchpad.net/bugs/1931582 in > Ubuntu, which is about adding a LOGO= entry to os-release. > I think it somewhat would make sense to provide the logos (plural because > following > https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/985 it > makes sense to have -text/-dark/text-dark variants.) in the same package as > the key is defined? > Checking the current logo images it would be ~15kB of svg (or maybe png) > files added to the package. > Would that sound something reasonable? This seems ok in terms of the impact on the size of the base system (i.e. negligible), but I wonder about the interfaces here. Flavors have their own individual logos, which they use for plymouth/grub themes for example. If we add LOGO to /etc/os-release, do we have to worry about other upstreams picking this up and using it in other contexts where it's less appropriate, because we want flavors to be able to customize appearance independently of base-files? -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org signature.asc Description: PGP signature -- ubuntu-devel mailing list ubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
Adding logo images to base-files?
Hey there, I'm trying to see how we can fix https://launchpad.net/bugs/1931582 in Ubuntu, which is about adding a LOGO= entry to os-release. I think it somewhat would make sense to provide the logos (plural because following https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/985 it makes sense to have -text/-dark/text-dark variants.) in the same package as the key is defined? Checking the current logo images it would be ~15kB of svg (or maybe png) files added to the package. Would that sound something reasonable? Cheers, Sebastien Bacher -- ubuntu-devel mailing list ubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel
