Re: Question about submitting patches for repositories on Launchpad

[Dan Bungert]

On Thu, Mar 30, 2023 at 05:34:10PM +, Alexander Koskovich wrote:
> I submitted my patch to the 'master' branch since that looked to be active
> development, ubuntu/devel seemed abandoned.
> https://code.launchpad.net/~nexusprism/curtin/+git/curtin/+merge/439880

Hi Alexander,

Thanks for the merge proposal.  I have responded with some feedback, so we can
continue the discussion there.

-Dan

-- 
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel

Re: Question about submitting patches for repositories on Launchpad

[Steve Langasek]

On Thu, Mar 30, 2023 at 05:34:10PM +, Alexander Koskovich wrote:
> Steve Langasek wrote:

> > Which branches are you looking to submit to? There are lots of branches
> > that unfortunately we don't have monitoring of. MPs are great, but I
> > wouldn't want you to do work on one only to have it go nowhere because no
> > one is listening.

> I submitted my patch to the 'master' branch since that looked to be active 
> development, ubuntu/devel seemed abandoned.

> https://code.launchpad.net/~nexusprism/curtin/+git/curtin/+merge/439880

> I have an MP here, is this the correct way to go about it, or would I need
> to seek sponsorship like you had mentioned?

Conveniently, curtin is a project whose upstream is maintained in Launchpad,
and you've targeted your MP to the correct branch - and there are sensible
default reviewers ("curtin developers" instead of, say "Ubuntu Core
Development Team" who do not receive launchpad email) so everything's on
track for this to be reviewed by the maintainers, there's nothing else you
need to do out of band.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature
-- 
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel

Re: Question about submitting patches for repositories on Launchpad

[Alexander Koskovich]

Steve Langasek wrote:

> Which branches are you looking to submit to? There are lots of branches
> that unfortunately we don't have monitoring of. MPs are great, but I
> wouldn't want you to do work on one only to have it go nowhere because no
> one is listening.

I submitted my patch to the 'master' branch since that looked to be active 
development, ubuntu/devel seemed abandoned.

https://code.launchpad.net/~nexusprism/curtin/+git/curtin/+merge/439880

I have an MP here, is this the correct way to go about it, or would I need to 
seek sponsorship like you had mentioned?

-- 
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel

Re: Question about submitting patches for repositories on Launchpad

[Steve Langasek]

Hi Alexander,

On Thu, Mar 30, 2023 at 03:03:10PM +, Alexander Koskovich wrote:

> I'm fairly new to submitting patches for Ubuntu and I wanted to confirm
> that I'm doing everything right inline with Ubuntu procedures.

> I read that you should fork the original repository in Launchpad, upload
> your commit to it, and open a merge request on the original repository. 
> This is fairly similar to GitHub, but I also read somewhere else that you
> should submit the relevant patches through a mailing list?  Just wanted
> some clarification.

Where did you read that patches should be submitted by email?  Because
that's definitely incorrect.

> Also, if there's anything I would need to do on a merge request past just
> pushing it to get it reviewed.

Which branches are you looking to submit to?  There are lots of branches
that unfortunately we don't have monitoring of.  MPs are great, but I
wouldn't want you to do work on one only to have it go nowhere because no
one is listening.

The official process for getting patches included in Ubuntu is
.  The sponsorship queue is
sadly also under-managed at this time, so sometimes a ping on IRC
(#ubuntu-devel@libera) or email is productive.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature
-- 
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel

Question about submitting patches for repositories on Launchpad

[Alexander Koskovich]

Hello,

I'm fairly new to submitting patches for Ubuntu and I wanted to confirm that 
I'm doing everything right inline with Ubuntu procedures.

I read that you should fork the original repository in Launchpad, upload your 
commit to it, and open a merge request on the original repository. This is 
fairly similar to GitHub, but I also read somewhere else that you should submit 
the relevant patches through a mailing list? Just wanted some clarification.

Also, if there's anything I would need to do on a merge request past just 
pushing it to get it reviewed.

Thanks!-- 
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel